[Jenkins] SUCCESS: CouchDB » master #236

2018-03-29 Thread Apache Jenkins Server
Yay, we passed. https://builds.apache.org/job/CouchDB/job/master/236/

[GitHub] wohali commented on issue #1226: Investigate how hard could it be to reintroduce etags in index's views.

2018-03-29 Thread GitBox
wohali commented on issue #1226: Investigate how hard could it be to reintroduce etags in index's views. URL: https://github.com/apache/couchdb/issues/1226#issuecomment-377359278 Thanks @eiri, good to know. Let's not merge this into `master` until 2.2.0 is released, then.

[GitHub] jjrodrig commented on issue #1139: Fix for issue #1136 - Error 500 deleting DB without quorum

2018-03-29 Thread GitBox
jjrodrig commented on issue #1139: Fix for issue #1136 - Error 500 deleting DB without quorum URL: https://github.com/apache/couchdb/pull/1139#issuecomment-377358283 @wohali I'll modify the condition to respond with 200 - Ok only if we have a response from all the nodes, If we have a

[GitHub] eiri commented on issue #1226: Investigate how hard could it be to reintroduce etags in index's views.

2018-03-29 Thread GitBox
eiri commented on issue #1226: Investigate how hard could it be to reintroduce etags in index's views. URL: https://github.com/apache/couchdb/issues/1226#issuecomment-377356072 Good news - this is doable and not even overly esoteric. Bad news - the change is touching a lot of modules

[GitHub] davisp closed pull request #1255: Fix compaction resumption for the BT engine

2018-03-29 Thread GitBox
davisp closed pull request #1255: Fix compaction resumption for the BT engine URL: https://github.com/apache/couchdb/pull/1255 This is an automated message from the Apache Git Service. To respond to the message, please log

[Jenkins] SUCCESS: CouchDB » master #235

2018-03-29 Thread Apache Jenkins Server
Yay, we passed. https://builds.apache.org/job/CouchDB/job/master/235/

[GitHub] davisp commented on a change in pull request #1255: Fix compaction resumption for the BT engine

2018-03-29 Thread GitBox
davisp commented on a change in pull request #1255: Fix compaction resumption for the BT engine URL: https://github.com/apache/couchdb/pull/1255#discussion_r178136382 ## File path: src/couch/test/couch_bt_engine_compactor_tests.erl ## @@ -0,0 +1,130 @@ +% Licensed under

[GitHub] davisp commented on a change in pull request #1255: Fix compaction resumption for the BT engine

2018-03-29 Thread GitBox
davisp commented on a change in pull request #1255: Fix compaction resumption for the BT engine URL: https://github.com/apache/couchdb/pull/1255#discussion_r178136164 ## File path: src/couch/test/couch_bt_engine_compactor_tests.erl ## @@ -0,0 +1,130 @@ +% Licensed under

[GitHub] iilyak commented on a change in pull request #1255: Fix compaction resumption for the BT engine

2018-03-29 Thread GitBox
iilyak commented on a change in pull request #1255: Fix compaction resumption for the BT engine URL: https://github.com/apache/couchdb/pull/1255#discussion_r178133287 ## File path: src/couch/test/couch_bt_engine_compactor_tests.erl ## @@ -0,0 +1,130 @@ +% Licensed under

[GitHub] janl commented on issue #1238: Fix users_db_security.js delete/recreate _users DB

2018-03-29 Thread GitBox
janl commented on issue #1238: Fix users_db_security.js delete/recreate _users DB URL: https://github.com/apache/couchdb/issues/1238#issuecomment-377314335 Fixed in https://github.com/apache/couchdb/pull/1258 This is an

[GitHub] janl closed issue #1238: Fix users_db_security.js delete/recreate _users DB

2018-03-29 Thread GitBox
janl closed issue #1238: Fix users_db_security.js delete/recreate _users DB URL: https://github.com/apache/couchdb/issues/1238 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] iilyak commented on a change in pull request #1255: Fix compaction resumption for the BT engine

2018-03-29 Thread GitBox
iilyak commented on a change in pull request #1255: Fix compaction resumption for the BT engine URL: https://github.com/apache/couchdb/pull/1255#discussion_r178129717 ## File path: src/couch/test/couch_bt_engine_compactor_tests.erl ## @@ -0,0 +1,130 @@ +% Licensed under

[GitHub] janl closed pull request #1258: Make loginUser wait for successful authentication

2018-03-29 Thread GitBox
janl closed pull request #1258: Make loginUser wait for successful authentication URL: https://github.com/apache/couchdb/pull/1258 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] eiri opened a new pull request #1258: Make loginUser wait for successful authentication

2018-03-29 Thread GitBox
eiri opened a new pull request #1258: Make loginUser wait for successful authentication URL: https://github.com/apache/couchdb/pull/1258 ## Overview On restrained hosts bcrypt and sometimes pbkdf2 can't finish hashing for new users within 5 sec timeout leading to tests failures.

[GitHub] janl commented on issue #1238: Fix users_db_security.js delete/recreate _users DB

2018-03-29 Thread GitBox
janl commented on issue #1238: Fix users_db_security.js delete/recreate _users DB URL: https://github.com/apache/couchdb/issues/1238#issuecomment-377292201 This is it, we need to send log_rounds to 1 as well This is an

[GitHub] wohali opened a new issue #1257: Support replication scheduler priority queue

2018-03-29 Thread GitBox
wohali opened a new issue #1257: Support replication scheduler priority queue URL: https://github.com/apache/couchdb/issues/1257 ## Expected Behaviour In tandem with #1256, it could be nice to add an exposed `priority` field to any replication scheduler job. This would reflect the

[GitHub] wohali opened a new issue #1256: Support triggered one-time replications in the scheduler

2018-03-29 Thread GitBox
wohali opened a new issue #1256: Support triggered one-time replications in the scheduler URL: https://github.com/apache/couchdb/issues/1256 ## Expected Behaviour As an alternative to continuous replications, the replication scheduler could provide a repeatable, triggered one-time

[GitHub] rnewson commented on issue #1255: Fix compaction resumption for the BT engine

2018-03-29 Thread GitBox
rnewson commented on issue #1255: Fix compaction resumption for the BT engine URL: https://github.com/apache/couchdb/pull/1255#issuecomment-377287292 +1 This is an automated message from the Apache Git Service. To respond to

[GitHub] davisp opened a new pull request #1255: Fix compaction resumption for the BT engine

2018-03-29 Thread GitBox
davisp opened a new pull request #1255: Fix compaction resumption for the BT engine URL: https://github.com/apache/couchdb/pull/1255 This bug prevents the proper resumption of compactions that died during the meta copy phase. The issue is that we were setting the update_seq but not

[GitHub] janl commented on issue #1238: Fix users_db_security.js delete/recreate _users DB

2018-03-29 Thread GitBox
janl commented on issue #1238: Fix users_db_security.js delete/recreate _users DB URL: https://github.com/apache/couchdb/issues/1238#issuecomment-377274262 s/pbkdf/bcrypt/ apologies This is an automated message from the

[GitHub] eiri commented on issue #1238: Fix users_db_security.js delete/recreate _users DB

2018-03-29 Thread GitBox
eiri commented on issue #1238: Fix users_db_security.js delete/recreate _users DB URL: https://github.com/apache/couchdb/issues/1238#issuecomment-377274171 1. Totally agree, this test and the whole javascript suite are **really** hard to follow. It'd be amazing to revive Russel's

[GitHub] katsel opened a new issue #1254: Add aggregation functions to Mango

2018-03-29 Thread GitBox
katsel opened a new issue #1254: Add aggregation functions to Mango URL: https://github.com/apache/couchdb/issues/1254 The Mango query language provides CRUD operations and basic selector syntax for document retrieval. There are no aggregation functions. Thus, Mango does currently

[GitHub] janl commented on issue #1253: [DISCUSS] Validate new document writes against max_http_request_size

2018-03-29 Thread GitBox
janl commented on issue #1253: [DISCUSS] Validate new document writes against max_http_request_size URL: https://github.com/apache/couchdb/pull/1253#issuecomment-377241308 The travis fails here point to

[GitHub] janl commented on issue #1238: Fix users_db_security.js delete/recreate _users DB

2018-03-29 Thread GitBox
janl commented on issue #1238: Fix users_db_security.js delete/recreate _users DB URL: https://github.com/apache/couchdb/issues/1238#issuecomment-377231543 Two points: 1. we are in dire need of rewriting this test file 2. it *might* be that this failure points to pbkdf not working as

[GitHub] janl commented on a change in pull request #1253: [DISCUSS] Validate new document writes against max_http_request_size

2018-03-29 Thread GitBox
janl commented on a change in pull request #1253: [DISCUSS] Validate new document writes against max_http_request_size URL: https://github.com/apache/couchdb/pull/1253#discussion_r178029434 ## File path: src/couch/src/couch_att.erl ## @@ -708,6 +709,9 @@ upgrade(#att{} =

[GitHub] janl commented on a change in pull request #1253: [DISCUSS] Validate new document writes against max_http_request_size

2018-03-29 Thread GitBox
janl commented on a change in pull request #1253: [DISCUSS] Validate new document writes against max_http_request_size URL: https://github.com/apache/couchdb/pull/1253#discussion_r178028983 ## File path: src/couch/src/couch_doc.erl ## @@ -136,12 +136,27 @@

[GitHub] rnewson commented on a change in pull request #1253: [DISCUSS] Validate new document writes against max_http_request_size

2018-03-29 Thread GitBox
rnewson commented on a change in pull request #1253: [DISCUSS] Validate new document writes against max_http_request_size URL: https://github.com/apache/couchdb/pull/1253#discussion_r178028228 ## File path: src/couch/src/couch_att.erl ## @@ -708,6 +709,9 @@ upgrade(#att{}

[GitHub] rnewson commented on a change in pull request #1253: [DISCUSS] Validate new document writes against max_http_request_size

2018-03-29 Thread GitBox
rnewson commented on a change in pull request #1253: [DISCUSS] Validate new document writes against max_http_request_size URL: https://github.com/apache/couchdb/pull/1253#discussion_r178028114 ## File path: src/couch/src/couch_doc.erl ## @@ -136,12 +136,27 @@

[GitHub] janl commented on issue #1238: Fix users_db_security.js delete/recreate _users DB

2018-03-29 Thread GitBox
janl commented on issue #1238: Fix users_db_security.js delete/recreate _users DB URL: https://github.com/apache/couchdb/issues/1238#issuecomment-377207053 on it This is an automated message from the Apache Git Service.

[GitHub] janl commented on issue #1200: [DISCUSS] CouchDB Request Size Limits

2018-03-29 Thread GitBox
janl commented on issue #1200: [DISCUSS] CouchDB Request Size Limits URL: https://github.com/apache/couchdb/pull/1200#issuecomment-37720 Thanks for the great discussion here. Closing this out in favour of the new proposed approach: https://github.com/apache/couchdb/pull/1253

[GitHub] janl closed pull request #1200: [DISCUSS] CouchDB Request Size Limits

2018-03-29 Thread GitBox
janl closed pull request #1200: [DISCUSS] CouchDB Request Size Limits URL: https://github.com/apache/couchdb/pull/1200 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub

[GitHub] janl opened a new pull request #1253: [DISCUSS] Validate new document writes against max_http_request_size

2018-03-29 Thread GitBox
janl opened a new pull request #1253: [DISCUSS] Validate new document writes against max_http_request_size URL: https://github.com/apache/couchdb/pull/1253 This supersedes #1200. ## New Behaviour This variant introduces no new config variable and no formula, instead, there

[GitHub] kdoran commented on issue #1221: `_changes` filtered on `_doc_ids` returns unexpected `last_seq`

2018-03-29 Thread GitBox
kdoran commented on issue #1221: `_changes` filtered on `_doc_ids` returns unexpected `last_seq` URL: https://github.com/apache/couchdb/issues/1221#issuecomment-377190829 @wohali yup, sorry for the delay! Here's a quick js example I ran in the chrome devtools console while on the fauxton

[GitHub] arunp123 commented on issue #546: Support additional INCLUDE/LIB paths during compile

2018-03-29 Thread GitBox
arunp123 commented on issue #546: Support additional INCLUDE/LIB paths during compile URL: https://github.com/apache/couchdb/issues/546#issuecomment-377186093 installing libmozjs185-dev fixed my problem This is an automated