[GitHub] [couchdb-docker] sinny777 commented on issue #167: Partitioned key not working with Docker image of CouchDB

2020-02-11 Thread GitBox
sinny777 commented on issue #167: Partitioned key not working with Docker image of CouchDB URL: https://github.com/apache/couchdb-docker/issues/167#issuecomment-585030018 Thanks @willholley , It seems that "partitioned" is supported by latest version ( 3.0) of CouchDB and here's the

[GitHub] [couchdb] leo-pires closed pull request #2541: Port reduce_false.js and reduce_builtin.js to Elixir

2020-02-11 Thread GitBox
leo-pires closed pull request #2541: Port reduce_false.js and reduce_builtin.js to Elixir URL: https://github.com/apache/couchdb/pull/2541 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [couchdb] leo-pires opened a new pull request #2541: Port reduce_false.js and reduce_builtin.js to Elixir

2020-02-11 Thread GitBox
leo-pires opened a new pull request #2541: Port reduce_false.js and reduce_builtin.js to Elixir URL: https://github.com/apache/couchdb/pull/2541 Let's try out! This is an automated message from the Apache Git Service. To

[GitHub] [couchdb] wohali commented on issue #1271: Add units to all stats

2020-02-11 Thread GitBox
wohali commented on issue #1271: Add units to all stats URL: https://github.com/apache/couchdb/issues/1271#issuecomment-584879908 @tabeth Careful. On Windows, `erlang:system_time/0` will return time only in ms, not us. You'll need to check the code to be sure this does the right thing on

[GitHub] [couchdb] nickva commented on a change in pull request #2540: Use multi-transactional iterators

2020-02-11 Thread GitBox
nickva commented on a change in pull request #2540: Use multi-transactional iterators URL: https://github.com/apache/couchdb/pull/2540#discussion_r377920781 ## File path: src/fabric/src/fabric2_fdb.erl ## @@ -1361,21 +1426,66 @@ get_fold_opts(RangePrefix, Options) ->

[GitHub] [couchdb] eiri commented on issue #2539: Implement flattened doc storage

2020-02-11 Thread GitBox
eiri commented on issue #2539: Implement flattened doc storage URL: https://github.com/apache/couchdb/pull/2539#issuecomment-584851873 @davisp sorry for confusion, when I said "still wrestling" I meant as in "not pushed out yet", should've been clearer. For implementation, yes, limit on

[GitHub] [couchdb] davisp commented on issue #2539: Implement flattened doc storage

2020-02-11 Thread GitBox
davisp commented on issue #2539: Implement flattened doc storage URL: https://github.com/apache/couchdb/pull/2539#issuecomment-584845472 I read through this and am not seeing where you're limiting depth at all. In terms of implementing it, if I'm not mistaken that's just extending your

[GitHub] [couchdb] tabeth edited a comment on issue #1271: Add units to all stats

2020-02-11 Thread GitBox
tabeth edited a comment on issue #1271: Add units to all stats URL: https://github.com/apache/couchdb/issues/1271#issuecomment-584836884 @wohali OK. I'll take a look at the files and start trying to update the descriptions. So for example (to make sure I'm doing this right):

[GitHub] [couchdb] nickva commented on a change in pull request #2540: Use multi-transactional iterators

2020-02-11 Thread GitBox
nickva commented on a change in pull request #2540: Use multi-transactional iterators URL: https://github.com/apache/couchdb/pull/2540#discussion_r377881851 ## File path: src/fabric/src/fabric2_db.erl ## @@ -1001,6 +1002,11 @@ maybe_set_user_ctx(Db, Options) -> end.

[GitHub] [couchdb] tabeth commented on issue #1271: Add units to all stats

2020-02-11 Thread GitBox
tabeth commented on issue #1271: Add units to all stats URL: https://github.com/apache/couchdb/issues/1271#issuecomment-584836884 @wohali OK. I'll take a look at the files and start trying to update the descriptions. So for example (to make sure I'm doing this right): We

[GitHub] [couchdb] nickva commented on a change in pull request #2540: Use multi-transactional iterators

2020-02-11 Thread GitBox
nickva commented on a change in pull request #2540: Use multi-transactional iterators URL: https://github.com/apache/couchdb/pull/2540#discussion_r377880280 ## File path: src/fabric/src/fabric2_fdb.erl ## @@ -815,25 +846,52 @@ get_last_change(#{} = Db) -> end.

[GitHub] [couchdb] nickva commented on a change in pull request #2540: Use multi-transactional iterators

2020-02-11 Thread GitBox
nickva commented on a change in pull request #2540: Use multi-transactional iterators URL: https://github.com/apache/couchdb/pull/2540#discussion_r377880172 ## File path: src/fabric/include/fabric2.hrl ## @@ -57,7 +57,10 @@ -define(PDICT_TX_ID_KEY, '$fabric_tx_id').

[GitHub] [couchdb] davisp commented on a change in pull request #2540: Use multi-transactional iterators

2020-02-11 Thread GitBox
davisp commented on a change in pull request #2540: Use multi-transactional iterators URL: https://github.com/apache/couchdb/pull/2540#discussion_r377874095 ## File path: src/fabric/src/fabric2_fdb.erl ## @@ -815,25 +846,52 @@ get_last_change(#{} = Db) -> end.

[GitHub] [couchdb] davisp commented on a change in pull request #2540: Use multi-transactional iterators

2020-02-11 Thread GitBox
davisp commented on a change in pull request #2540: Use multi-transactional iterators URL: https://github.com/apache/couchdb/pull/2540#discussion_r377872657 ## File path: src/fabric/include/fabric2.hrl ## @@ -57,7 +57,10 @@ -define(PDICT_TX_ID_KEY, '$fabric_tx_id').

[GitHub] [couchdb] davisp commented on a change in pull request #2540: Use multi-transactional iterators

2020-02-11 Thread GitBox
davisp commented on a change in pull request #2540: Use multi-transactional iterators URL: https://github.com/apache/couchdb/pull/2540#discussion_r377875422 ## File path: src/fabric/src/fabric2_fdb.erl ## @@ -1361,21 +1426,66 @@ get_fold_opts(RangePrefix, Options) ->

[GitHub] [couchdb] davisp commented on a change in pull request #2538: Encode startkey/endkey for all_docs

2020-02-11 Thread GitBox
davisp commented on a change in pull request #2538: Encode startkey/endkey for all_docs URL: https://github.com/apache/couchdb/pull/2538#discussion_r377872107 ## File path: test/elixir/test/all_docs_test.exs ## @@ -41,11 +41,9 @@ defmodule AllDocsTest do assert

[GitHub] [couchdb] davisp commented on a change in pull request #2538: Encode startkey/endkey for all_docs

2020-02-11 Thread GitBox
davisp commented on a change in pull request #2538: Encode startkey/endkey for all_docs URL: https://github.com/apache/couchdb/pull/2538#discussion_r377870849 ## File path: src/fabric/src/fabric2_util.erl ## @@ -235,3 +237,12 @@ hex_to_nibble(N) -> uuid() ->

[GitHub] [couchdb] wohali commented on issue #1271: Add units to all stats

2020-02-11 Thread GitBox
wohali commented on issue #1271: Add units to all stats URL: https://github.com/apache/couchdb/issues/1271#issuecomment-584814923 You got it! Anything that isn't a counter should be reviewed and ensure the description contains the correct unit.

[GitHub] [couchdb] tabeth edited a comment on issue #1271: Add units to all stats

2020-02-11 Thread GitBox
tabeth edited a comment on issue #1271: Add units to all stats URL: https://github.com/apache/couchdb/issues/1271#issuecomment-584814649 Ah, I see @wohali So this is more investigative, where we want (for all of the `stats_descriptions.cfg` files) This: ```erlang

[GitHub] [couchdb] tabeth commented on issue #1271: Add units to all stats

2020-02-11 Thread GitBox
tabeth commented on issue #1271: Add units to all stats URL: https://github.com/apache/couchdb/issues/1271#issuecomment-584814649 Ah, I see @wohali So this is more investigative, where we want (for all of the `stats_descriptions.cfg` files) This: ```erlang

[GitHub] [couchdb] wohali commented on issue #1271: Add units to all stats

2020-02-11 Thread GitBox
wohali commented on issue #1271: Add units to all stats URL: https://github.com/apache/couchdb/issues/1271#issuecomment-584813023 Hey @tabeth , thanks for looking at this. There's a lot of files: ``` ./src/couch/priv/stats_descriptions.cfg

[GitHub] [couchdb] wohali commented on issue #1303: Replace nssm.exe and install the Windows service differently

2020-02-11 Thread GitBox
wohali commented on issue #1303: Replace nssm.exe and install the Windows service differently URL: https://github.com/apache/couchdb/issues/1303#issuecomment-584801079 An alternative: https://github.com/kohsuke/winsw This requires the .NET Framework as a dependency, though, which would

[GitHub] [couchdb] wohali commented on issue #1303: Replace nssm.exe and install the Windows service differently

2020-02-11 Thread GitBox
wohali commented on issue #1303: Replace nssm.exe and install the Windows service differently URL: https://github.com/apache/couchdb/issues/1303#issuecomment-584796044 Unfortunately that last link depends on https://github.com/DSorlov/Sorlov.PowerShell which is GPL v3. :(

[GitHub] [couchdb] wohali commented on issue #1303: Replace nssm.exe and install the Windows service differently

2020-02-11 Thread GitBox
wohali commented on issue #1303: Replace nssm.exe and install the Windows service differently URL: https://github.com/apache/couchdb/issues/1303#issuecomment-584794999 I spent a bit of time today looking at this and considering http://erlang.org/doc/man/erlsrv.html as an alternative.

[GitHub] [couchdb] tabeth commented on issue #1271: Add units to all stats

2020-02-11 Thread GitBox
tabeth commented on issue #1271: Add units to all stats URL: https://github.com/apache/couchdb/issues/1271#issuecomment-584781401 Hi @wohali. I was looking at this issue, and the [referenced file](https://github.com/apache/couchdb/blob/master/src/couch/priv/stats_descriptions.cfg).

[GitHub] [couchdb] nickva opened a new pull request #2540: Use multi-transactional iterators

2020-02-11 Thread GitBox
nickva opened a new pull request #2540: Use multi-transactional iterators URL: https://github.com/apache/couchdb/pull/2540 This is a 3rd approach. Simplified even more after talking with @davisp This one is driven by an optioned passed in to fold_range. There is also just a

[GitHub] [couchdb] eiri opened a new pull request #2539: Implement flattened doc storage

2020-02-11 Thread GitBox
eiri opened a new pull request #2539: Implement flattened doc storage URL: https://github.com/apache/couchdb/pull/2539 ## Overview Implementation of "flattened" doc storage format to [Document Storage

[GitHub] [couchdb] garrensmith opened a new pull request #2538: Encode startkey/endkey for all_docs

2020-02-11 Thread GitBox
garrensmith opened a new pull request #2538: Encode startkey/endkey for all_docs URL: https://github.com/apache/couchdb/pull/2538 ## Overview Encodes the startkey/endkey so that if a startkey is not binary it will return the expected results. ## Testing recommendations ##