[jira] [Commented] (COUCHDB-3216) Corrupted compact.meta files can lead to cyclic crashes with no recovery
[ https://issues.apache.org/jira/browse/COUCHDB-3216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16612752#comment-16612752 ] ASF GitHub Bot commented on COUCHDB-3216: - Github user iilyak closed the pull request at: https://github.com/apache/couchdb-couch/pull/209 > Corrupted compact.meta files can lead to cyclic crashes with no recovery > > > Key: COUCHDB-3216 > URL: https://issues.apache.org/jira/browse/COUCHDB-3216 > Project: CouchDB > Issue Type: Bug >Reporter: ILYA >Priority: Major > > In the case when compact.meta file is corrupted the compactor keeps crashing > over and over with no recovery. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (COUCHDB-2789) Refactor test suite for endpoint testing to skip overriden handlers
[ https://issues.apache.org/jira/browse/COUCHDB-2789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16612094#comment-16612094 ] ASF GitHub Bot commented on COUCHDB-2789: - Github user iilyak closed the pull request at: https://github.com/apache/couchdb-mem3/pull/12 > Refactor test suite for endpoint testing to skip overriden handlers > --- > > Key: COUCHDB-2789 > URL: https://issues.apache.org/jira/browse/COUCHDB-2789 > Project: CouchDB > Issue Type: Test >Reporter: ILYA >Priority: Major > > Currently if you override an endpoint handler and try to run couchdb test > suite it will fail due to the fact that the test suite expects it's couchdb > handler for the endpoint. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (COUCHDB-2789) Refactor test suite for endpoint testing to skip overriden handlers
[ https://issues.apache.org/jira/browse/COUCHDB-2789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16612089#comment-16612089 ] ASF GitHub Bot commented on COUCHDB-2789: - Github user iilyak closed the pull request at: https://github.com/apache/couchdb-couch/pull/92 > Refactor test suite for endpoint testing to skip overriden handlers > --- > > Key: COUCHDB-2789 > URL: https://issues.apache.org/jira/browse/COUCHDB-2789 > Project: CouchDB > Issue Type: Test >Reporter: ILYA >Priority: Major > > Currently if you override an endpoint handler and try to run couchdb test > suite it will fail due to the fact that the test suite expects it's couchdb > handler for the endpoint. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (COUCHDB-2789) Refactor test suite for endpoint testing to skip overriden handlers
[ https://issues.apache.org/jira/browse/COUCHDB-2789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16612087#comment-16612087 ] ASF GitHub Bot commented on COUCHDB-2789: - Github user iilyak closed the pull request at: https://github.com/apache/couchdb-chttpd/pull/65 > Refactor test suite for endpoint testing to skip overriden handlers > --- > > Key: COUCHDB-2789 > URL: https://issues.apache.org/jira/browse/COUCHDB-2789 > Project: CouchDB > Issue Type: Test >Reporter: ILYA >Priority: Major > > Currently if you override an endpoint handler and try to run couchdb test > suite it will fail due to the fact that the test suite expects it's couchdb > handler for the endpoint. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (COUCHDB-2650) Etag is 'undefined' when _all_docs
[ https://issues.apache.org/jira/browse/COUCHDB-2650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16612081#comment-16612081 ] ASF GitHub Bot commented on COUCHDB-2650: - Github user iilyak closed the pull request at: https://github.com/apache/couchdb-chttpd/pull/34 > Etag is 'undefined' when _all_docs > -- > > Key: COUCHDB-2650 > URL: https://issues.apache.org/jira/browse/COUCHDB-2650 > Project: CouchDB > Issue Type: Bug > Components: HTTP Interface >Affects Versions: 2.0.0 >Reporter: ILYA >Assignee: Klaus Trainer >Priority: Blocker > Fix For: 2.0.0 > > > Steps to reproduce > http --json --auth='adm:pass' PUT 'http://localhost:15984/test_db' > http -v --json --auth='adm:pass' GET > 'http://localhost:15984/test_db/_all_docs' > HTTP/1.1 200 OK > Cache-Control: must-revalidate > Content-Type: application/json > Date: Thu, 26 Mar 2015 15:21:56 GMT > ETag: undefined > Server: CouchDB/b6d8665 (Erlang OTP/17) > Transfer-Encoding: chunked > X-Couch-Request-ID: 2f7f8320 > X-CouchDB-Body-Time: 0 > { > "offset": 0, > "rows": [], > "total_rows": 0 > } > The cause of this is in the following line > https://github.com/apache/couchdb-couch-mrview/blob/master/src/couch_mrview_http.erl#L331 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (COUCHDB-2625) Make customizable dbname_validator
[ https://issues.apache.org/jira/browse/COUCHDB-2625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16612078#comment-16612078 ] ASF GitHub Bot commented on COUCHDB-2625: - Github user iilyak closed the pull request at: https://github.com/apache/couchdb-chttpd/pull/26 > Make customizable dbname_validator > --- > > Key: COUCHDB-2625 > URL: https://issues.apache.org/jira/browse/COUCHDB-2625 > Project: CouchDB > Issue Type: Bug > Components: Database Core >Reporter: ILYA >Assignee: ILYA >Priority: Major > Fix For: 2.0.0 > > > Currently allowed databases names are either should match regexp or hardcoded > list of internal databases like _users or _replicator. Which make it hard to > customize without modifying source code. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (COUCHDB-2547) Fix broken tests for couch app
[ https://issues.apache.org/jira/browse/COUCHDB-2547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16612077#comment-16612077 ] ASF GitHub Bot commented on COUCHDB-2547: - Github user iilyak closed the pull request at: https://github.com/apache/couchdb-chttpd/pull/24 > Fix broken tests for couch app > -- > > Key: COUCHDB-2547 > URL: https://issues.apache.org/jira/browse/COUCHDB-2547 > Project: CouchDB > Issue Type: Test >Reporter: ILYA >Assignee: ILYA >Priority: Major > Fix For: 2.0.0 > > > Some of the tests suites are disabled with -ifdef(run_broken_tests). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (COUCHDB-2552) unknown metric: [couchdb,mrview,map_docs]
[ https://issues.apache.org/jira/browse/COUCHDB-2552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16612076#comment-16612076 ] ASF GitHub Bot commented on COUCHDB-2552: - Github user iilyak closed the pull request at: https://github.com/apache/couchdb-couch/pull/32 > unknown metric: [couchdb,mrview,map_docs] > - > > Key: COUCHDB-2552 > URL: https://issues.apache.org/jira/browse/COUCHDB-2552 > Project: CouchDB > Issue Type: Bug > Components: Database Core >Reporter: ILYA >Assignee: Alexander Shorin >Priority: Major > > There is a typo in priv/stats_descriptions.cfg of mrview app. It contains > definition of map_doc metric which should be map_docs. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (COUCHDB-1606) Replicator leaves plaintext password in logs
[ https://issues.apache.org/jira/browse/COUCHDB-1606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16612052#comment-16612052 ] ASF GitHub Bot commented on COUCHDB-1606: - Github user iilyak closed the pull request at: https://github.com/apache/couchdb-couch-replicator/pull/51 > Replicator leaves plaintext password in logs > > > Key: COUCHDB-1606 > URL: https://issues.apache.org/jira/browse/COUCHDB-1606 > Project: CouchDB > Issue Type: Bug > Components: Logging, Replication >Affects Versions: 1.2 >Reporter: Nathan Vander Wilt >Assignee: Bob Dionne >Priority: Major > Attachments: pwd log.txt > > > While reviewing logs, I noticed that a password had been recorded in the logs > as part of a replicator error. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (COUCHDB-3125) Trigger cookie renewal on /_session
[ https://issues.apache.org/jira/browse/COUCHDB-3125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16593338#comment-16593338 ] ASF GitHub Bot commented on COUCHDB-3125: - Github user adrienverge closed the pull request at: https://github.com/apache/couchdb-couch/pull/194 > Trigger cookie renewal on /_session > --- > > Key: COUCHDB-3125 > URL: https://issues.apache.org/jira/browse/COUCHDB-3125 > Project: CouchDB > Issue Type: Improvement >Reporter: Adrien Vergé >Priority: Major > > It is currently not possible to programmatically renew an `AuthSession` > cookie. The only way is to wait 10% of the cookie expiration time then make > any request to CouchDB, so it sends a new cookie. > Programmatically getting cookies can be needed, for example, when passwords > are managed by authentication server. E.g., a third-party auth server gets a > cookie, forwards it to a user, and the user needs the CouchDB server to > install a new cookie in his/her browser with a `Set-Cookie` header. (Browsers > don't allow JS to install cookies, only a `Set-Cookie` header from the server > can set the cookie.) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (COUCHDB-3323) Idle dbs cause excessive overhead
[ https://issues.apache.org/jira/browse/COUCHDB-3323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16024878#comment-16024878 ] ASF GitHub Bot commented on COUCHDB-3323: - Github user nickva closed the pull request at: https://github.com/apache/couchdb-couch/pull/236 > Idle dbs cause excessive overhead > - > > Key: COUCHDB-3323 > URL: https://issues.apache.org/jira/browse/COUCHDB-3323 > Project: CouchDB > Issue Type: Bug >Reporter: Nick Vatamaniuc > > Idle dbs, especially sys_dbs like _replicator shards once opened > once for scanning would stay open forever. In a large cluster with many > _replicator shards that can add up to a significant overhead, mostly in terms > of number of active processes. > Add a mechanism to close dbs which are idle. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (COUCHDB-3337) End-point _local_docs doesn't conform to query params of _all_docs
[ https://issues.apache.org/jira/browse/COUCHDB-3337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15990800#comment-15990800 ] ASF GitHub Bot commented on COUCHDB-3337: - Github user eiri closed the pull request at: https://github.com/apache/couchdb-couch-mrview/pull/72 > End-point _local_docs doesn't conform to query params of _all_docs > -- > > Key: COUCHDB-3337 > URL: https://issues.apache.org/jira/browse/COUCHDB-3337 > Project: CouchDB > Issue Type: Bug >Reporter: Eric Avdey >Assignee: Eric Avdey > > There are following issues with {{/db/_local_doc end-point}} > # It ignores include_docs parameter > # It reports incorrect total_rows value, returning total rows of non-local > docs instead > # It crashes with {{badrecord}} {{full_doc_info}} when query trying to skip > records -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (COUCHDB-3324) Scheduling Replicator
[ https://issues.apache.org/jira/browse/COUCHDB-3324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15968502#comment-15968502 ] ASF GitHub Bot commented on COUCHDB-3324: - Github user nickva closed the pull request at: https://github.com/apache/couchdb-couch-replicator/pull/64 > Scheduling Replicator > - > > Key: COUCHDB-3324 > URL: https://issues.apache.org/jira/browse/COUCHDB-3324 > Project: CouchDB > Issue Type: New Feature >Reporter: Nick Vatamaniuc > > Improve CouchDB replicator > * Allow running a large number of replication jobs > * Improve API with a focus on ease of use and performance. Avoid updating > replication document with transient state updates. Instead create a proper > API for querying replication states. At the same time provide a compatibility > mode to let users keep existing behavior (of getting updates in documents). > * Improve network resource usage and performance. Multiple connection to the > same cluster could share socket connections > * Handle rate limiting on target and source HTTP endpoints. Let replication > request auto-discover rate limit capacity based on a proven algorithm such as > Additive Increase / Multiplicative Decrease feedback control loop. > * Improve performance by avoiding repeatedly retrying failing replication > jobs. Instead use exponential backoff. > * Improve recovery from long (but temporary) network failure. Currently if > replications jobs fail to start 10 times in a row they will not be retried > anymore. This is not always desirable. In case of a long enough DNS (or other > network) failure replication jobs will effectively stop until they are > manually restarted. > * Better handling of filtered replications: Failing to fetch filters could > block couch replicator manager, lead to message queue backups and memory > exhaustion. Also, when replication filter code changes update replication > accordingly (replication job ID should change in that case) > * Provide better metrics to introspect replicator behavior. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (COUCHDB-3324) Scheduling Replicator
[ https://issues.apache.org/jira/browse/COUCHDB-3324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15956270#comment-15956270 ] ASF GitHub Bot commented on COUCHDB-3324: - Github user nickva closed the pull request at: https://github.com/apache/couchdb-chttpd/pull/158 > Scheduling Replicator > - > > Key: COUCHDB-3324 > URL: https://issues.apache.org/jira/browse/COUCHDB-3324 > Project: CouchDB > Issue Type: New Feature >Reporter: Nick Vatamaniuc > > Improve CouchDB replicator > * Allow running a large number of replication jobs > * Improve API with a focus on ease of use and performance. Avoid updating > replication document with transient state updates. Instead create a proper > API for querying replication states. At the same time provide a compatibility > mode to let users keep existing behavior (of getting updates in documents). > * Improve network resource usage and performance. Multiple connection to the > same cluster could share socket connection > * Handle rate limiting on target and source HTTP endpoints. Let replication > request auto-discover rate limit capacity based on a proven algorithm such as > Additive Increase / Multiplicative Decrease feedback control loop. > * Improve performance by avoiding repeatedly retrying failing replication > jobs. Instead use exponential backoff. > * Improve recovery from long (but temporary) network failure. Currently if > replications jobs fail to start 10 times in a row they will not be retried > anymore. This is not always desirable. In case of a long enough DNS (or other > network) failure replication jobs will effectively stop until they are > manually restarted. > * Better handling of filtered replications: Failing to fetch filters could > block couch replicator manager, lead to message queue backups and memory > exhaustion. Also, when replication filter code changes update replication > accordingly (replication job ID should change in that case) > * Provide better metrics to introspect replicator behavior. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (COUCHDB-3324) Scheduling Replicator
[ https://issues.apache.org/jira/browse/COUCHDB-3324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15956268#comment-15956268 ] ASF GitHub Bot commented on COUCHDB-3324: - Github user nickva closed the pull request at: https://github.com/apache/couchdb-couch/pull/238 > Scheduling Replicator > - > > Key: COUCHDB-3324 > URL: https://issues.apache.org/jira/browse/COUCHDB-3324 > Project: CouchDB > Issue Type: New Feature >Reporter: Nick Vatamaniuc > > Improve CouchDB replicator > * Allow running a large number of replication jobs > * Improve API with a focus on ease of use and performance. Avoid updating > replication document with transient state updates. Instead create a proper > API for querying replication states. At the same time provide a compatibility > mode to let users keep existing behavior (of getting updates in documents). > * Improve network resource usage and performance. Multiple connection to the > same cluster could share socket connection > * Handle rate limiting on target and source HTTP endpoints. Let replication > request auto-discover rate limit capacity based on a proven algorithm such as > Additive Increase / Multiplicative Decrease feedback control loop. > * Improve performance by avoiding repeatedly retrying failing replication > jobs. Instead use exponential backoff. > * Improve recovery from long (but temporary) network failure. Currently if > replications jobs fail to start 10 times in a row they will not be retried > anymore. This is not always desirable. In case of a long enough DNS (or other > network) failure replication jobs will effectively stop until they are > manually restarted. > * Better handling of filtered replications: Failing to fetch filters could > block couch replicator manager, lead to message queue backups and memory > exhaustion. Also, when replication filter code changes update replication > accordingly (replication job ID should change in that case) > * Provide better metrics to introspect replicator behavior. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (COUCHDB-3324) Scheduling Replicator
[ https://issues.apache.org/jira/browse/COUCHDB-3324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15954157#comment-15954157 ] ASF GitHub Bot commented on COUCHDB-3324: - Github user nickva closed the pull request at: https://github.com/apache/couchdb/pull/454 > Scheduling Replicator > - > > Key: COUCHDB-3324 > URL: https://issues.apache.org/jira/browse/COUCHDB-3324 > Project: CouchDB > Issue Type: New Feature >Reporter: Nick Vatamaniuc > > Merge scheduling replicator -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (COUCHDB-2722) The keys from the rewrited query params of a view should be blank when not specified in the URL
[ https://issues.apache.org/jira/browse/COUCHDB-2722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15950553#comment-15950553 ] ASF GitHub Bot commented on COUCHDB-2722: - GitHub user benel opened a pull request: https://github.com/apache/couchdb/pull/465 COUCHDB-2722 https://issues.apache.org/jira/browse/COUCHDB-2722 ## Overview Test for COUCHDB-2722 bug report. ## Testing recommendations ## JIRA issue number COUCHDB-2722 ## Related Pull Requests Rebase of #324. ## Checklist - [ ] Code is written and works correctly; - [ ] Changes are covered by tests; - [ ] Documentation reflects the changes; - [ ] I will not forget to update [rebar.config.script](https://github.com/apache/couchdb/blob/master/rebar.config.script) with the correct commit hash once this PR get merged. You can merge this pull request into a Git repository by running: $ git pull https://github.com/benel/couchdb COUCHDB-2722 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/couchdb/pull/465.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #465 commit 28708eb3d6dec1f12e9f28eb5c80741531574359 Author: Martin Lagrange Date: 2015-06-22T14:52:13Z COUCHDB-2722 https://issues.apache.org/jira/browse/COUCHDB-2722 > The keys from the rewrited query params of a view should be blank when not > specified in the URL > --- > > Key: COUCHDB-2722 > URL: https://issues.apache.org/jira/browse/COUCHDB-2722 > Project: CouchDB > Issue Type: Bug > Components: HTTP Interface >Affects Versions: 1.5.1, 1.6.0, 1.6.1 >Reporter: Martin Lagrange >Priority: Minor > > When we rewrite the query params of a view as in the following example : > > {code:title=Design document test|borderStyle=solid} > { > _id:"_design/test", > views : { > rewriteKeyView: { >// ... > } > }, > rewrites: [ > { >"from": "renamedRewriteKeyView", >"to": "_view/rewriteKeyView", >"query": { >"startkey": [ >":by" >], >"endkey": [ >":by", >{} >] >} > } > ] > } > {code} > specifying the param *by* as the main component of startkey and endkey > When we access the renamed view "renamedRewriteKeyView", without specifying > the by param in the URI like : > {code}GET dbName/_design/test/renamedRewriteKeyView{code} > the internal call should be : > {code}rewriteKeyView?startkey=[""]&endkey=["",{}]{code} > instead of : {code}rewriteKeyView?startkey=[":by"]&endkey=[":by",{}]{code} > As you can see, when a key is not specified in the URI, it the value of this > key will be kept as its name. Quite annoying in some cases. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (COUCHDB-2722) The keys from the rewrited query params of a view should be blank when not specified in the URL
[ https://issues.apache.org/jira/browse/COUCHDB-2722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15950442#comment-15950442 ] ASF GitHub Bot commented on COUCHDB-2722: - Github user wohali closed the pull request at: https://github.com/apache/couchdb/pull/324 > The keys from the rewrited query params of a view should be blank when not > specified in the URL > --- > > Key: COUCHDB-2722 > URL: https://issues.apache.org/jira/browse/COUCHDB-2722 > Project: CouchDB > Issue Type: Bug > Components: HTTP Interface >Affects Versions: 1.5.1, 1.6.0, 1.6.1 >Reporter: Martin Lagrange >Priority: Minor > > When we rewrite the query params of a view as in the following example : > > {code:title=Design document test|borderStyle=solid} > { > _id:"_design/test", > views : { > rewriteKeyView: { >// ... > } > }, > rewrites: [ > { >"from": "renamedRewriteKeyView", >"to": "_view/rewriteKeyView", >"query": { >"startkey": [ >":by" >], >"endkey": [ >":by", >{} >] >} > } > ] > } > {code} > specifying the param *by* as the main component of startkey and endkey > When we access the renamed view "renamedRewriteKeyView", without specifying > the by param in the URI like : > {code}GET dbName/_design/test/renamedRewriteKeyView{code} > the internal call should be : > {code}rewriteKeyView?startkey=[""]&endkey=["",{}]{code} > instead of : {code}rewriteKeyView?startkey=[":by"]&endkey=[":by",{}]{code} > As you can see, when a key is not specified in the URI, it the value of this > key will be kept as its name. Quite annoying in some cases. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (COUCHDB-2722) The keys from the rewrited query params of a view should be blank when not specified in the URL
[ https://issues.apache.org/jira/browse/COUCHDB-2722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15950441#comment-15950441 ] ASF GitHub Bot commented on COUCHDB-2722: - Github user wohali commented on the issue: https://github.com/apache/couchdb/pull/324 @benel Yes thank you! Open a new PR and reference this one. I will close this one now. > The keys from the rewrited query params of a view should be blank when not > specified in the URL > --- > > Key: COUCHDB-2722 > URL: https://issues.apache.org/jira/browse/COUCHDB-2722 > Project: CouchDB > Issue Type: Bug > Components: HTTP Interface >Affects Versions: 1.5.1, 1.6.0, 1.6.1 >Reporter: Martin Lagrange >Priority: Minor > > When we rewrite the query params of a view as in the following example : > > {code:title=Design document test|borderStyle=solid} > { > _id:"_design/test", > views : { > rewriteKeyView: { >// ... > } > }, > rewrites: [ > { >"from": "renamedRewriteKeyView", >"to": "_view/rewriteKeyView", >"query": { >"startkey": [ >":by" >], >"endkey": [ >":by", >{} >] >} > } > ] > } > {code} > specifying the param *by* as the main component of startkey and endkey > When we access the renamed view "renamedRewriteKeyView", without specifying > the by param in the URI like : > {code}GET dbName/_design/test/renamedRewriteKeyView{code} > the internal call should be : > {code}rewriteKeyView?startkey=[""]&endkey=["",{}]{code} > instead of : {code}rewriteKeyView?startkey=[":by"]&endkey=[":by",{}]{code} > As you can see, when a key is not specified in the URI, it the value of this > key will be kept as its name. Quite annoying in some cases. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (COUCHDB-3046) Improve reduce function overflow protection
[ https://issues.apache.org/jira/browse/COUCHDB-3046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15945441#comment-15945441 ] ASF GitHub Bot commented on COUCHDB-3046: - Github user nickva commented on the issue: https://github.com/apache/couchdb/pull/425 Thanks for taking a look @wohali and @kxepal There is a JIRA issue already: https://issues.apache.org/jira/browse/COUCHDB-3046. Also rebased on master. > Improve reduce function overflow protection > > > Key: COUCHDB-3046 > URL: https://issues.apache.org/jira/browse/COUCHDB-3046 > Project: CouchDB > Issue Type: Bug > Components: Database Core >Reporter: Nick Vatamaniuc > > The protection algorithm: > https://github.com/apache/couchdb/blob/master/share/server/views.js#L36-L41 > When enabled, looks at couchjs' reduce command input and output line lengths > (as stringy-fied json). If 2*len(output) > len(input) and len(output) > 200 > then an error is triggered. > There a few issues in that scheme: > * No mode to first log failures only. This way user can handle bad reduce > functions as a warning rather than as a failed query result. > * Input line contains the length of the reduce function code itself. A large > reduce function body (say 100KB) might skew the result and allow allow > through reduce function with larger than needed output (without tripping the > error). > * On the other hand, output size checking threshold is too small = 200. It > prevents functions using single large accumulator object (say with fields > like .sum, .count, .stddev, and so on) from working. The size of output will > be > 200 but, even though it won't be growing it will still be prevented from > running. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (COUCHDB-3340) EUnit: syslog timeout
[ https://issues.apache.org/jira/browse/COUCHDB-3340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15943968#comment-15943968 ] ASF GitHub Bot commented on COUCHDB-3340: - Github user asfgit closed the pull request at: https://github.com/apache/couchdb-couch-log/pull/17 > EUnit: syslog timeout > - > > Key: COUCHDB-3340 > URL: https://issues.apache.org/jira/browse/COUCHDB-3340 > Project: CouchDB > Issue Type: Test > Components: Test Suite >Reporter: Joan Touzet >Assignee: Jay Doane > > Happening semi-often (but not consistently) in our Jenkins builds. These are > within Docker images, so this failure may be related to syslogd running > slowly inside the images. > {noformat} > module 'couch_log_writer_syslog_test' > couch_log_writer_syslog_test: > couch_log_writer_syslog_test_...*timed out* > undefined > {noformat} > Here's a bit more detail from a recent log: > {noformat} > module 'couch_log_writer_syslog_test' > couch_log_writer_syslog_test: couch_log_writer_syslog_test_...[0.181 s] ok > couch_log_writer_syslog_test: couch_log_writer_syslog_test_...Internal > error: {error,undef, > [{io,fwrite,["*timed out*\n",[]],[]}, > {eunit_tty,handle_cancel,3, > [{file,"eunit_tty.erl"},{line,171}]}, > {eunit_listener,call,3, > [{file,"eunit_listener.erl"},{line,132}]}, > {eunit_listener,group_loop,4, > [{file,"eunit_listener.erl"},{line,93}]}, > {eunit_listener,'-init_fun/2-fun-0-',2, > [{file,"eunit_listener.erl"},{line,58}]}]}. > {noformat} -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (COUCHDB-3340) EUnit: syslog timeout
[ https://issues.apache.org/jira/browse/COUCHDB-3340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15942747#comment-15942747 ] ASF GitHub Bot commented on COUCHDB-3340: - GitHub user jaydoane opened a pull request: https://github.com/apache/couchdb-couch-log/pull/17 Fix dns timeout for undefined syslog host On some platforms, inet:getaddr can take several seconds to return when passed the undefined atom, which is the default value of "syslog_host", and therefore the value used when running tests. On platforms where it takes longer to return than the test is allowed to run, the couch_log_writer_syslog_test will fail with *timed out*. This short circuits the case when "syslog_host" is undefined, and removes the race from the test. COUCHDB-3340 You can merge this pull request into a Git repository by running: $ git pull https://github.com/cloudant/couchdb-couch-log 3340-fix-dns-timeout Alternatively you can review and apply these changes as the patch at: https://github.com/apache/couchdb-couch-log/pull/17.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #17 commit 24112cf6ce9ed23029f7697b84548dc8acff28b5 Author: Jay Doane Date: 2017-03-27T06:46:15Z Fix dns timeout for undefined syslog host On some platforms, inet:getaddr can take several seconds to return when passed the undefined atom, which is the default value of "syslog_host", and therefore the value used when running tests. On platforms where it takes longer to return than the test is allowed to run, the couch_log_writer_syslog_test will fail with *timed out*. This short circuits the case when "syslog_host" is undefined, and removes the race from the test. COUCHDB-3340 > EUnit: syslog timeout > - > > Key: COUCHDB-3340 > URL: https://issues.apache.org/jira/browse/COUCHDB-3340 > Project: CouchDB > Issue Type: Test > Components: Test Suite >Reporter: Joan Touzet >Assignee: Jay Doane > > Happening semi-often (but not consistently) in our Jenkins builds. These are > within Docker images, so this failure may be related to syslogd running > slowly inside the images. > {noformat} > module 'couch_log_writer_syslog_test' > couch_log_writer_syslog_test: > couch_log_writer_syslog_test_...*timed out* > undefined > {noformat} > Here's a bit more detail from a recent log: > {noformat} > module 'couch_log_writer_syslog_test' > couch_log_writer_syslog_test: couch_log_writer_syslog_test_...[0.181 s] ok > couch_log_writer_syslog_test: couch_log_writer_syslog_test_...Internal > error: {error,undef, > [{io,fwrite,["*timed out*\n",[]],[]}, > {eunit_tty,handle_cancel,3, > [{file,"eunit_tty.erl"},{line,171}]}, > {eunit_listener,call,3, > [{file,"eunit_listener.erl"},{line,132}]}, > {eunit_listener,group_loop,4, > [{file,"eunit_listener.erl"},{line,93}]}, > {eunit_listener,'-init_fun/2-fun-0-',2, > [{file,"eunit_listener.erl"},{line,58}]}]}. > {noformat} -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (COUCHDB-3337) End-point _local_docs doesn't conform to query params of _all_docs
[ https://issues.apache.org/jira/browse/COUCHDB-3337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15935485#comment-15935485 ] ASF GitHub Bot commented on COUCHDB-3337: - GitHub user eiri opened a pull request: https://github.com/apache/couchdb-couch-mrview/pull/72 Fix end-point _local_docs This fixes the following issues with `/{db}/_local_docs` end-point: 1. Query ignores `include_docs` parameter 1. Query reports incorrect `total_rows` value, returning total rows for non-local docs instead 1. Query crashes with `badrecord` when trying to skip records, e.g. when `start_key` not the first local doc COUCHDB-3337 You can merge this pull request into a Git repository by running: $ git pull https://github.com/cloudant/couchdb-couch-mrview 84617-fix-_local_docs Alternatively you can review and apply these changes as the patch at: https://github.com/apache/couchdb-couch-mrview/pull/72.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #72 commit 021e46ad2792460e968021de84d42a8f3faa5f4d Author: Eric Avdey Date: 2017-03-17T14:04:53Z Make _local_docs conform to include_docs commit 6867449cce3618a065f8c966c65a391d42e35283 Author: Eric Avdey Date: 2017-03-21T15:03:09Z Adopt all_docs_reduce_to_count/1 to _local docs We are using all_docs_reduce_to_count/1 in _local_docs handler, but reductions got from local btree are different from reductions passed from id btree's enumerator. This change converts passed local's KVs to list of expected #doc_full_info records. commit 79ad8bd1bf52c363334a5e55c627f46109d494bf Author: Eric Avdey Date: 2017-03-21T19:49:24Z Fix total_row for _local_docs commit beaa1bab96c8876dce1e49a91a59041556c789ec Author: Eric Avdey Date: 2017-03-21T22:37:08Z Add utests for _local_docs > End-point _local_docs doesn't conform to query params of _all_docs > -- > > Key: COUCHDB-3337 > URL: https://issues.apache.org/jira/browse/COUCHDB-3337 > Project: CouchDB > Issue Type: Bug >Reporter: Eric Avdey >Assignee: Eric Avdey > > There are following issues with {{/db/_local_doc end-point}} > # It ignores include_docs parameter > # It reports incorrect total_rows value, returning total rows of non-local > docs instead > # It crashes with {{badrecord}} {{full_doc_info}} when query trying to skip > records -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (COUCHDB-3314) Add an option in doc creation APIs to specify a random value for an initial doc revision
[ https://issues.apache.org/jira/browse/COUCHDB-3314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15932727#comment-15932727 ] ASF GitHub Bot commented on COUCHDB-3314: - GitHub user rnewson opened a pull request: https://github.com/apache/couchdb-couch/pull/240 Include meta randomness when generating new rev id COUCHDB-3314 You can merge this pull request into a Git repository by running: $ git pull https://github.com/cloudant/couchdb-couch 3314-random-initial-rev Alternatively you can review and apply these changes as the patch at: https://github.com/apache/couchdb-couch/pull/240.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #240 commit bf89f288b9059636e1dd41be9ce73c459f30a54d Author: Robert Newson Date: 2017-03-20T14:28:55Z Include meta randomness when generating new rev id COUCHDB-3314 > Add an option in doc creation APIs to specify a random value for an initial > doc revision > > > Key: COUCHDB-3314 > URL: https://issues.apache.org/jira/browse/COUCHDB-3314 > Project: CouchDB > Issue Type: New Feature > Components: Database Core, HTTP Interface >Reporter: Mayya Sharipova > > Currently the initial revision of a document is deterministic. For instance, > anyone that has created an empty document probably recognizes the revision > starting with "1-967a00dff...". In order to account for situations when a > document is continually purged and recreated we're going to add randomness to > this initial revision by specifying a 0-$rev in the request coordinator. We > will then include this in the revision generation but drop the 0-$rev entry > from the revision's path. > Thus, the new API will look like this: > acurl -X PUT > https://http://adm:pass@127.0.0.1:5984/test-db/newdoc1?rev=0-adfdafa123 -d > '{}' > And similarly for _bulk_docs > For a user who wants to create a doc, then purge it, and then re-create, it > is recommended to recreate it with another random revision. > It is important to note that the 0-$rev only affects document creation. Once > a document exists, updates to the document will continue to update their hash > in the same deterministic fashion. Ie, once a document exists, identical > updates will result in identical revisions. > _ > The following changes need to be made in the code: > 1. API changes to allow to specify random rev in doc PUT requests, _bulk_docs > 2. Internals: > 2.1 Use a new revision here: > https://github.com/apache/couchdb-couch/blob/master/src/couch_db.erl#L886 > 2.2 Don't include provided 0-$rev entry to the revision's path (find wherever > new_revid is called from; could be 2-3 places) > 2.3 Reject a 0-$rev during replication -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (COUCHDB-3315) Introduce randomness to initial revisions of docs
[ https://issues.apache.org/jira/browse/COUCHDB-3315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15932725#comment-15932725 ] ASF GitHub Bot commented on COUCHDB-3315: - GitHub user rnewson opened a pull request: https://github.com/apache/couchdb-fabric/pull/92 Generate a random value at the coordinator if creating docs COUCHDB-3315 You can merge this pull request into a Git repository by running: $ git pull https://github.com/cloudant/couchdb-fabric 3314-random-initial-rev Alternatively you can review and apply these changes as the patch at: https://github.com/apache/couchdb-fabric/pull/92.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #92 commit 49ac6b56af324f57634aa0b93fbfc8ba39a61e40 Author: Robert Newson Date: 2017-03-20T14:26:09Z Generate a random value at the coordinator if creating docs COUCHDB-3315 > Introduce randomness to initial revisions of docs > - > > Key: COUCHDB-3315 > URL: https://issues.apache.org/jira/browse/COUCHDB-3315 > Project: CouchDB > Issue Type: Improvement > Components: Database Core >Reporter: Mayya Sharipova > Fix For: 3.0.0 > > > This ticket is for couch 3.0 to add randomness to the initial revision of any > doc with an option to specify that random value in the API by a user. > While a goal for COUCHDB-3314 is to allow a user to supply a random initial > revision for a doc through API when desired and if not supplied a > deterministic {0, <<>>} will be used for all docs; the goal of this ticket > is to make initial revisions of all docs to be random. This is done to > account for situations when a document is continually purged and recreated. > This change does affect one specific behavior. Any user that currently sends > identical writes to two independent databases and then replicates between > those databases would see conflicts whenever they create a new database. The > downside of this change is that there's a use case where someone may make the > same exact writes to two or more databases and expect there to be no > conflicts due to replication. > It is important to note that the 0-$rev only affects document creation. Once > a document exists, updates to the document will continue to update their hash > in the same deterministic fashion. Ie, once a document exists, identical > updates will result in identical revisions. > > Changes to code: > Swap the logic in new_revid to produce random revisions for the initial > creation > {0, <<>>} which it is now, we'll replace it with randomness the <<>> binary > bit -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (COUCHDB-2295) Connection hangs on document update for multipart/related and transfer encoding chunked request
[ https://issues.apache.org/jira/browse/COUCHDB-2295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15932202#comment-15932202 ] ASF GitHub Bot commented on COUCHDB-2295: - GitHub user stevebest opened an issue: https://github.com/apache/couchdb-nano/issues/36 Streamable multipart attachments are not supported Consider a scenario when you want to upload a document and several attachments to a CouchDB in a single request - a typical example would be uploading a "Couchapp": a design doc with multiple HTML/JS/CSS attachments. This scenario is [supported by CouchDB API](http://docs.couchdb.org/en/1.6.1/api/document/common.html?highlight=multipart/related#creating-multiple-attachments) using `Content-Type: multipart/related` request. Furthermore, you could expect to leverage Node `Stream`s in order to avoid the necessity of buffering a bunch of files in memory. Unfortunately, the combination of issues in CouchDB and `request` prevents this. 1) CouchDB has [a nasty bug](https://issues.apache.org/jira/browse/COUCHDB-2295) which prevents from using `Transfer-Encoding: chunked` along with `Content-Type: multipart/related`. It won't be fixed until `1.7`, and its status in `2.x` branch is unknown. 2) `request` uses exactly the `Transfer-Encoding: chunked` to upload data from `Stream`s. Uh-oh. 3) `request` could be told explicitly not to use `chunked` encoding - but then you can't give it any `Stream`s! See [docs for a `multipart` option in request(options, callback)](https://github.com/request/request#requestoptions-callback). Bummer. Technically, it should be possible to stream a bunch of attachments, in case where one knows the length of the stream beforehand (which is not a problem when you upload files from a disk). I attempted to add the support for this case in dscape/nano#300, but failed miserably because `request` rightfully thinks it's smarter than me. > Connection hangs on document update for multipart/related and transfer > encoding chunked request > --- > > Key: COUCHDB-2295 > URL: https://issues.apache.org/jira/browse/COUCHDB-2295 > Project: CouchDB > Issue Type: Bug > Components: HTTP Interface >Reporter: Alexander Shorin > Fix For: 1.7.0 > > > Script to reproduce: > {code} > import pprint > import requests > body = [ > b'--996713c691ec4fd5b717ef2740893b78\r\n', > b'Content-Type: application/json\r\n', > b'\r\n', > b'{"_id": "test","_attachments": {"foo": {"follows": true, > "content_type": "text/plain", "length": 12}}}\r\n', > b'--996713c691ec4fd5b717ef2740893b78\r\n', > b'Content-Type: text/plain\r\n' > b'Content-Disposition: attachment;filename="foo"\r\n' > b'Content-Length: 12\r\n' > b'\r\n', > b'Time to Relax!', > b'--996713c691ec4fd5b717ef2740893b78--\r\n' > ] > url = 'http://localhost:5984/db/test' > headers = { > 'Content-Type': 'multipart/related; > boundary="996713c691ec4fd5b717ef2740893b78"' > } > resp = requests.put(url, headers=headers, data=iter(body)) > pprint.pprint(resp.json()) > {code} > This runs a request: > {code} > PUT /db/test HTTP/1.1 > Host: localhost:5984 > Accept-Encoding: gzip, deflate > Transfer-Encoding: chunked > User-Agent: python-requests/2.3.0 CPython/3.4.1 Linux/3.15.5-gentoo > Accept: */* > Content-Type: multipart/related; boundary="996713c691ec4fd5b717ef2740893b78" > 24 > --996713c691ec4fd5b717ef2740893b78 > 20 > Content-Type: application/json > 2 > 68 > {"_id": "test","_attachments": {"foo": {"follows": true, "content_type": > "text/plain", "length": 14}}} > 24 > --996713c691ec4fd5b717ef2740893b78 > 60 > Content-Type: text/plain > Content-Disposition: attachment;filename="foo" > Content-Length: 12 > e > Time to Relax! > 26 > --996713c691ec4fd5b717ef2740893b78-- > 0 > {code} > But connection hangs: CouchDB thinks that there have to more data while zero > length chunk had been send and doesn't reply with anything back to client > which had finished the request and awaits for the response. > The problem could be "fixed" by specifying full Content-Length of multipart > body in request, which kills all the idea of chunked transfer. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (COUCHDB-2591) Documentation
[ https://issues.apache.org/jira/browse/COUCHDB-2591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15932108#comment-15932108 ] ASF GitHub Bot commented on COUCHDB-2591: - Github user wohali closed the pull request at: https://github.com/apache/couchdb-documentation/pull/22 > Documentation > - > > Key: COUCHDB-2591 > URL: https://issues.apache.org/jira/browse/COUCHDB-2591 > Project: CouchDB > Issue Type: Bug > Components: BigCouch, Documentation >Reporter: Robert Kowalski >Priority: Blocker > Fix For: 2.0.0 > > > people would like to use 2.0 but they don’t know how to maintain it (e.g. > adding and rebalancing nodes, general setup) -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (COUCHDB-3329) Remove PDF and texinfo targets from default doc build
[ https://issues.apache.org/jira/browse/COUCHDB-3329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15932033#comment-15932033 ] ASF GitHub Bot commented on COUCHDB-3329: - Github user wohali closed the pull request at: https://github.com/apache/couchdb/pull/457 > Remove PDF and texinfo targets from default doc build > - > > Key: COUCHDB-3329 > URL: https://issues.apache.org/jira/browse/COUCHDB-3329 > Project: CouchDB > Issue Type: Wish > Components: Documentation >Reporter: Joan Touzet > > I'd like to propose dropping the PDF and texinfo targets from our > documentation build, or at the very least, having them not be part of the > default target / not standard deliverables for the project. > We'd continue to build HTML documentation as part of the workflow, naturally, > as well as the man pages. > I don't have any solid numbers, but I'm fairly sure most people use > https://docs.couchdb.org/ or a locally installed copy for their documentation > for CouchDB rather than the PDF documentation. I personally can't remember > the last time I opened the docs in PDF form. I also have never seen anyone > refer to the PDF docs on the mailing lists, IRC or Slack when asking for > advice or support. > I've never seen anyone use or talk about the texinfo target. > Dropping this dependency will allow us to drop TeX/LaTeX from our build > chain, which speeds up build times by about 90 seconds and reduces the size > of containers currently being built for our Jenkins CI workflow. It also > means CouchDB devs don't have to install 0.5-1.5GB worth of toolset. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (COUCHDB-3329) Remove PDF and texinfo targets from default doc build
[ https://issues.apache.org/jira/browse/COUCHDB-3329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15932031#comment-15932031 ] ASF GitHub Bot commented on COUCHDB-3329: - Github user wohali closed the pull request at: https://github.com/apache/couchdb-documentation/pull/116 > Remove PDF and texinfo targets from default doc build > - > > Key: COUCHDB-3329 > URL: https://issues.apache.org/jira/browse/COUCHDB-3329 > Project: CouchDB > Issue Type: Wish > Components: Documentation >Reporter: Joan Touzet > > I'd like to propose dropping the PDF and texinfo targets from our > documentation build, or at the very least, having them not be part of the > default target / not standard deliverables for the project. > We'd continue to build HTML documentation as part of the workflow, naturally, > as well as the man pages. > I don't have any solid numbers, but I'm fairly sure most people use > https://docs.couchdb.org/ or a locally installed copy for their documentation > for CouchDB rather than the PDF documentation. I personally can't remember > the last time I opened the docs in PDF form. I also have never seen anyone > refer to the PDF docs on the mailing lists, IRC or Slack when asking for > advice or support. > I've never seen anyone use or talk about the texinfo target. > Dropping this dependency will allow us to drop TeX/LaTeX from our build > chain, which speeds up build times by about 90 seconds and reduces the size > of containers currently being built for our Jenkins CI workflow. It also > means CouchDB devs don't have to install 0.5-1.5GB worth of toolset. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (COUCHDB-3016) Allow secure-by-default option for database security object
[ https://issues.apache.org/jira/browse/COUCHDB-3016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15932028#comment-15932028 ] ASF GitHub Bot commented on COUCHDB-3016: - Github user wohali closed the pull request at: https://github.com/apache/couchdb/pull/415 > Allow secure-by-default option for database security object > --- > > Key: COUCHDB-3016 > URL: https://issues.apache.org/jira/browse/COUCHDB-3016 > Project: CouchDB > Issue Type: Improvement >Reporter: Robert Newson > Fix For: 2.0.0 > > > Currently, a database defaults to allowing read/write by all until the > security object is changed to restrict. > Add a configuration property to allow alternative default behaviours, > beginning with "admin only". -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (COUCHDB-769) Store large attachments external to the .couch file
[ https://issues.apache.org/jira/browse/COUCHDB-769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15932022#comment-15932022 ] ASF GitHub Bot commented on COUCHDB-769: Github user wohali commented on the issue: https://github.com/apache/couchdb/pull/361 Hi @rnewson and @davisp , is this affected at all by the pluggable storage engine work? (I'm guessing it might very well be.) If not, could we consider merging it? > Store large attachments external to the .couch file > --- > > Key: COUCHDB-769 > URL: https://issues.apache.org/jira/browse/COUCHDB-769 > Project: CouchDB > Issue Type: New Feature > Components: Database Core >Reporter: Robert Newson >Assignee: Adam Kocoloski > Attachments: external_attachments_alpha.patch > > > For attachment-heavy applications storing the attachments in separate files > significantly eases compaction problems. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (COUCHDB-2722) The keys from the rewrited query params of a view should be blank when not specified in the URL
[ https://issues.apache.org/jira/browse/COUCHDB-2722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15932020#comment-15932020 ] ASF GitHub Bot commented on COUCHDB-2722: - Github user wohali commented on the issue: https://github.com/apache/couchdb/pull/324 Ping @supertinou . We'd love to merge this if you can run the tests and get back to us. > The keys from the rewrited query params of a view should be blank when not > specified in the URL > --- > > Key: COUCHDB-2722 > URL: https://issues.apache.org/jira/browse/COUCHDB-2722 > Project: CouchDB > Issue Type: Bug > Components: HTTP Interface >Affects Versions: 1.5.1, 1.6.0, 1.6.1 >Reporter: Martin Lagrange >Priority: Minor > > When we rewrite the query params of a view as in the following example : > > {code:title=Design document test|borderStyle=solid} > { > _id:"_design/test", > views : { > rewriteKeyView: { >// ... > } > }, > rewrites: [ > { >"from": "renamedRewriteKeyView", >"to": "_view/rewriteKeyView", >"query": { >"startkey": [ >":by" >], >"endkey": [ >":by", >{} >] >} > } > ] > } > {code} > specifying the param *by* as the main component of startkey and endkey > When we access the renamed view "renamedRewriteKeyView", without specifying > the by param in the URI like : > {code}GET dbName/_design/test/renamedRewriteKeyView{code} > the internal call should be : > {code}rewriteKeyView?startkey=[""]&endkey=["",{}]{code} > instead of : {code}rewriteKeyView?startkey=[":by"]&endkey=[":by",{}]{code} > As you can see, when a key is not specified in the URI, it the value of this > key will be kept as its name. Quite annoying in some cases. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (COUCHDB-1415) Re-insering a document silently fails after compact is executed
[ https://issues.apache.org/jira/browse/COUCHDB-1415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15932010#comment-15932010 ] ASF GitHub Bot commented on COUCHDB-1415: - Github user wohali closed the pull request at: https://github.com/apache/couchdb/pull/98 > Re-insering a document silently fails after compact is executed > --- > > Key: COUCHDB-1415 > URL: https://issues.apache.org/jira/browse/COUCHDB-1415 > Project: CouchDB > Issue Type: Bug > Components: Database Core >Affects Versions: 1.1.1 > Environment: Tested on multiple linux platforms >Reporter: Viktor Szabo >Assignee: Paul Joseph Davis > Fix For: 2.0.0 > > Attachments: patch > > > When a document is re-inserted after a compact operation using the same > contents it was originally created, the insert operation is silently ignored, > leaving the client unaware of the fact it's document is not available in the > database. > Can be reproduced using the following sequence of steps: > alias curl='curl -H "Content-Type: application/json"' > url="http://localhost:5984/database"; > 1 curl -X PUT $url > 2 curl -X POST $url -d '{"_id": "bug", "key": "value"}' > 3 curl -X DELETE "$url/bug?rev=1-59414e77c768bc202142ac82c2f129de" > 4 curl -X POST "$url/_compact" > 5 curl -X POST $url -d '{"_id": "bug", "key": "value"}' > 6 curl -X GET "$url/bug" > (bug here) > 1 {"ok":true} > 201 > 2 [{"ok":true,"id":"bug","rev":"1-59414e77c768bc202142ac82c2f129de"}] > 201 > 3 {"ok":true,"id":"bug","rev":"2-9b2e3bcc3752a3a952a3570b2ed4d27e"} > 200 > 4 {"ok":true} > 202 > 5 [{"ok":true,"id":"bug","rev":"1-59414e77c768bc202142ac82c2f129de"}] > 201 > 6 {"error":"not_found","reason":"deleted"} > 404 > CouchDB shouldn't report "ok" on step 5 and then go on to claim that the doc > is deleted. Also, it seems to work on second try: > 7 curl -X POST $url -d '{"_id": "bug", "key": "value"}' > 8 curl -X GET "$url/bug" > 7 {"ok":true,"id":"bug","rev":"3-674f864b73df1c80925e48436e21d550"} > 201 > 8 {"_id":"bug","_rev":"3-674f864b73df1c80925e48436e21d550","key":"value"} > 200 -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (COUCHDB-1893) Allow replication filters to meaningfully apply to deleted documents
[ https://issues.apache.org/jira/browse/COUCHDB-1893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15932009#comment-15932009 ] ASF GitHub Bot commented on COUCHDB-1893: - Github user wohali closed the pull request at: https://github.com/apache/couchdb/pull/92 > Allow replication filters to meaningfully apply to deleted documents > > > Key: COUCHDB-1893 > URL: https://issues.apache.org/jira/browse/COUCHDB-1893 > Project: CouchDB > Issue Type: Improvement > Components: JavaScript View Server >Reporter: Stéphane Alnet > > A document that is deleted using the DELETE command will be presented to a > replication filter as an empty record with only a `_deleted:true` field. A > replication filter can then only use the document ID to decide whether or not > to propagate the deletion; in most cases this is not sufficient, and one may > have to pass along deletion documents for IDs that would not have been > replicated by the filter. > This might lead to document IDs being leaked to the target database, which > might be undesirable; more importantly if the goal of filtering was to build > a smaller subset of the source database (for example to replicate a very > large database to a device that has smaller storage space), those deletion > documents might overfill the database (they never get compacted). > I had somewhat documented this issue on the Wiki > (http://wiki.apache.org/couchdb/Replication#Filtered_Replication) a while > back but never got to add it to JIRA. > Dave Cottlehuber on the PouchDB list suggested to use PUT with a > `_deleted:true` field to work around the problem (the PUT body can then > contain data sufficient to enable the filter to work). However we're still > stuck in case DELETE was used instead. > My suggestion is to expand the replication filter API to add an optional > third argument > filter(doc,req,old_doc) > where old_doc if present references the version of the document that will get > deleted. It is then up to the filter to use the _deleted flag in `doc` and > the values in `old_doc`. > (It might be useful/meaningful/easier to add old_doc in all cases; at this > point I'm only suggesting to add it in the case doc contains a _deleted > field.) -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (COUCHDB-906) Please offer offline downloadable documentation
[ https://issues.apache.org/jira/browse/COUCHDB-906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15931993#comment-15931993 ] ASF GitHub Bot commented on COUCHDB-906: Github user wohali closed the pull request at: https://github.com/apache/couchdb/pull/85 > Please offer offline downloadable documentation > --- > > Key: COUCHDB-906 > URL: https://issues.apache.org/jira/browse/COUCHDB-906 > Project: CouchDB > Issue Type: Improvement > Components: Documentation >Reporter: Chris Wilson >Assignee: Alexander Shorin > Fix For: 1.5.0 > > > I mainly work on the train or in airports without Internet access, so I need > offline documentation. > I tried to wget -r the couchdb wiki but I hit some kind of flood protection. > Apparently MoinMoin can sync between two instances if xmlrpc is enabled. It > seems to be enabled but broken in the CouchDB wiki. > Please could you put the wiki pages into hg or git and offer a read-only > clone or a downloadable tarball of the html versions of the pages? > Cheers, Chris. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (COUCHDB-259) Ability to store abitrary data in attachment stubs
[ https://issues.apache.org/jira/browse/COUCHDB-259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15931850#comment-15931850 ] ASF GitHub Bot commented on COUCHDB-259: Github user wohali closed the pull request at: https://github.com/apache/couchdb/pull/54 > Ability to store abitrary data in attachment stubs > -- > > Key: COUCHDB-259 > URL: https://issues.apache.org/jira/browse/COUCHDB-259 > Project: CouchDB > Issue Type: Wish > Components: Database Core >Affects Versions: 0.8.1 >Reporter: Sho Fukamachi >Priority: Minor > > I suggest the ability to store arbitrary data in line with single attachments > to a doc. The mooted use is to store metadata about that attachment. > For example, a current attachment: > m['_attachments'] > => {"yamanote.jpg"=>{"content_type"=>"image/jpeg", "stub"=>true, > "length"=>382613}} > Desired behaviour is to be able to insert persistent metadata like so: > m['_attachments'] > => {"yamanote.jpg"=>{"content_type"=>"image/jpeg", "stub"=>true, > "length"=>382613, "width" => 800, "height" => 600, "md5" => > "95de7a118ee28824afa8d2ad8fe5819f"}} > And many other use cases according to media type. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (COUCHDB-259) Ability to store abitrary data in attachment stubs
[ https://issues.apache.org/jira/browse/COUCHDB-259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15931849#comment-15931849 ] ASF GitHub Bot commented on COUCHDB-259: Github user wohali commented on the issue: https://github.com/apache/couchdb/pull/54 @argl We dropped the ball on this PR big time, and I'm sorry for that. Due to the age of this PR and the release of CouchDB 2.0 I'm going to close out this PR. Do you feel like you might be able to try re-submitting this PR against the CouchDB 2.0 code base? You may also want to look at the pluggable storage engine work coming from Cloudant over on the branch COUCHDB-3287-pluggable-storage-engines in the couchdb-couch, couchdb-mem3 and couchdb-chttpd repositories. Thank you again for contributing to CouchDB! > Ability to store abitrary data in attachment stubs > -- > > Key: COUCHDB-259 > URL: https://issues.apache.org/jira/browse/COUCHDB-259 > Project: CouchDB > Issue Type: Wish > Components: Database Core >Affects Versions: 0.8.1 >Reporter: Sho Fukamachi >Priority: Minor > > I suggest the ability to store arbitrary data in line with single attachments > to a doc. The mooted use is to store metadata about that attachment. > For example, a current attachment: > m['_attachments'] > => {"yamanote.jpg"=>{"content_type"=>"image/jpeg", "stub"=>true, > "length"=>382613}} > Desired behaviour is to be able to insert persistent metadata like so: > m['_attachments'] > => {"yamanote.jpg"=>{"content_type"=>"image/jpeg", "stub"=>true, > "length"=>382613, "width" => 800, "height" => 600, "md5" => > "95de7a118ee28824afa8d2ad8fe5819f"}} > And many other use cases according to media type. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (COUCHDB-259) Ability to store abitrary data in attachment stubs
[ https://issues.apache.org/jira/browse/COUCHDB-259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15931847#comment-15931847 ] ASF GitHub Bot commented on COUCHDB-259: Github user wohali closed the pull request at: https://github.com/apache/couchdb/pull/51 > Ability to store abitrary data in attachment stubs > -- > > Key: COUCHDB-259 > URL: https://issues.apache.org/jira/browse/COUCHDB-259 > Project: CouchDB > Issue Type: Wish > Components: Database Core >Affects Versions: 0.8.1 >Reporter: Sho Fukamachi >Priority: Minor > > I suggest the ability to store arbitrary data in line with single attachments > to a doc. The mooted use is to store metadata about that attachment. > For example, a current attachment: > m['_attachments'] > => {"yamanote.jpg"=>{"content_type"=>"image/jpeg", "stub"=>true, > "length"=>382613}} > Desired behaviour is to be able to insert persistent metadata like so: > m['_attachments'] > => {"yamanote.jpg"=>{"content_type"=>"image/jpeg", "stub"=>true, > "length"=>382613, "width" => 800, "height" => 600, "md5" => > "95de7a118ee28824afa8d2ad8fe5819f"}} > And many other use cases according to media type. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (COUCHDB-259) Ability to store abitrary data in attachment stubs
[ https://issues.apache.org/jira/browse/COUCHDB-259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15931846#comment-15931846 ] ASF GitHub Bot commented on COUCHDB-259: Github user wohali commented on the issue: https://github.com/apache/couchdb/pull/51 @argl We dropped the ball on this PR big time, and I'm sorry for that. Due to the age of this PR and the release of CouchDB 2.0 I'm going to close out this PR. Do you feel like you might be able to try re-submitting this PR against the CouchDB 2.0 code base? You may also want to look at the pluggable storage engine work coming from Cloudant that @davisp is gathering together over on the branch COUCHDB-3287-pluggable-storage-engines in the couchdb-couch, couchdb-mem3 and couchdb-chttpd repositories. Thank you again for contributing to CouchDB! > Ability to store abitrary data in attachment stubs > -- > > Key: COUCHDB-259 > URL: https://issues.apache.org/jira/browse/COUCHDB-259 > Project: CouchDB > Issue Type: Wish > Components: Database Core >Affects Versions: 0.8.1 >Reporter: Sho Fukamachi >Priority: Minor > > I suggest the ability to store arbitrary data in line with single attachments > to a doc. The mooted use is to store metadata about that attachment. > For example, a current attachment: > m['_attachments'] > => {"yamanote.jpg"=>{"content_type"=>"image/jpeg", "stub"=>true, > "length"=>382613}} > Desired behaviour is to be able to insert persistent metadata like so: > m['_attachments'] > => {"yamanote.jpg"=>{"content_type"=>"image/jpeg", "stub"=>true, > "length"=>382613, "width" => 800, "height" => 600, "md5" => > "95de7a118ee28824afa8d2ad8fe5819f"}} > And many other use cases according to media type. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (COUCHDB-3329) Remove PDF and texinfo targets from default doc build
[ https://issues.apache.org/jira/browse/COUCHDB-3329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15931597#comment-15931597 ] ASF GitHub Bot commented on COUCHDB-3329: - GitHub user wohali opened a pull request: https://github.com/apache/couchdb/pull/457 Remove PDF, TeX/LaTeX and texinfo from the build chain As discussed on the mailing list, this removes the PDF and info builds from the default build. Also includes apache/couchdb-documentation:PR#116. Fixes COUCHDB-3329 You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/couchdb 3329-kill-pdf-texinfo Alternatively you can review and apply these changes as the patch at: https://github.com/apache/couchdb/pull/457.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #457 commit 942f33e18dccbea68917856c27e32c9d86204393 Author: Joan Touzet Date: 2017-03-19T06:20:33Z Remove TeX/LaTeX and texinfo from the build chain > Remove PDF and texinfo targets from default doc build > - > > Key: COUCHDB-3329 > URL: https://issues.apache.org/jira/browse/COUCHDB-3329 > Project: CouchDB > Issue Type: Wish > Components: Documentation >Reporter: Joan Touzet > > I'd like to propose dropping the PDF and texinfo targets from our > documentation build, or at the very least, having them not be part of the > default target / not standard deliverables for the project. > We'd continue to build HTML documentation as part of the workflow, naturally, > as well as the man pages. > I don't have any solid numbers, but I'm fairly sure most people use > https://docs.couchdb.org/ or a locally installed copy for their documentation > for CouchDB rather than the PDF documentation. I personally can't remember > the last time I opened the docs in PDF form. I also have never seen anyone > refer to the PDF docs on the mailing lists, IRC or Slack when asking for > advice or support. > I've never seen anyone use or talk about the texinfo target. > Dropping this dependency will allow us to drop TeX/LaTeX from our build > chain, which speeds up build times by about 90 seconds and reduces the size > of containers currently being built for our Jenkins CI workflow. It also > means CouchDB devs don't have to install 0.5-1.5GB worth of toolset. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (COUCHDB-3329) Remove PDF and texinfo targets from default doc build
[ https://issues.apache.org/jira/browse/COUCHDB-3329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15931596#comment-15931596 ] ASF GitHub Bot commented on COUCHDB-3329: - GitHub user wohali opened a pull request: https://github.com/apache/couchdb-documentation/pull/116 Remove pdf and info builds from default target As discussed on the mailing list, this removes the PDF and info builds from the default build. Fixes COUCHDB-3329 Relates to apache/couchdb:3329-kill-pdf-texinfo branch. You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/couchdb-documentation 3329-kill-pdf-texinfo Alternatively you can review and apply these changes as the patch at: https://github.com/apache/couchdb-documentation/pull/116.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #116 commit 2474c99cd23aab89823df8901afb1a690b63fb1d Author: Joan Touzet Date: 2017-03-19T06:37:18Z Remove pdf and info builds from default target > Remove PDF and texinfo targets from default doc build > - > > Key: COUCHDB-3329 > URL: https://issues.apache.org/jira/browse/COUCHDB-3329 > Project: CouchDB > Issue Type: Wish > Components: Documentation >Reporter: Joan Touzet > > I'd like to propose dropping the PDF and texinfo targets from our > documentation build, or at the very least, having them not be part of the > default target / not standard deliverables for the project. > We'd continue to build HTML documentation as part of the workflow, naturally, > as well as the man pages. > I don't have any solid numbers, but I'm fairly sure most people use > https://docs.couchdb.org/ or a locally installed copy for their documentation > for CouchDB rather than the PDF documentation. I personally can't remember > the last time I opened the docs in PDF form. I also have never seen anyone > refer to the PDF docs on the mailing lists, IRC or Slack when asking for > advice or support. > I've never seen anyone use or talk about the texinfo target. > Dropping this dependency will allow us to drop TeX/LaTeX from our build > chain, which speeds up build times by about 90 seconds and reduces the size > of containers currently being built for our Jenkins CI workflow. It also > means CouchDB devs don't have to install 0.5-1.5GB worth of toolset. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (COUCHDB-3328) JS test runner does not report failures correctly
[ https://issues.apache.org/jira/browse/COUCHDB-3328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15931577#comment-15931577 ] ASF GitHub Bot commented on COUCHDB-3328: - Github user wohali closed the pull request at: https://github.com/apache/couchdb/pull/456 > JS test runner does not report failures correctly > - > > Key: COUCHDB-3328 > URL: https://issues.apache.org/jira/browse/COUCHDB-3328 > Project: CouchDB > Issue Type: Bug > Components: Test Suite >Reporter: Joan Touzet >Assignee: Joan Touzet > > Currently {{test/javascript/run}} always returns an exit code of {{0}}, > regardless of whether any tests fail or not. This makes any sort of automated > testing that expects to inspect the results of the run invalid. > This ticket will update the runner so that it will: > * Return a 1 when any test fails, and > * Print a count summary at the end of the run of how many tests succeeded, > failed, or were ignored/skipped. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (COUCHDB-1594) Incoherent behavior when delete attachments
[ https://issues.apache.org/jira/browse/COUCHDB-1594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15931116#comment-15931116 ] ASF GitHub Bot commented on COUCHDB-1594: - Github user wohali commented on the issue: https://github.com/apache/couchdb/issues/452 This is a duplicate of https://issues.apache.org/jira/browse/COUCHDB-1594 which shows that this issue has been around since ~CouchDB 1.2. We should fix it, but this is at least not a regression. @rnewson you might be amused by this one. đź‘€ > Incoherent behavior when delete attachments > --- > > Key: COUCHDB-1594 > URL: https://issues.apache.org/jira/browse/COUCHDB-1594 > Project: CouchDB > Issue Type: Bug > Components: Database Core >Affects Versions: 1.2 > Environment: Mac OS X Lion 10.7.5 >Reporter: Filippo Fadda >Priority: Minor > > There is an incoherent behavior when a client asks CouchDB to delete a > resource. In fact, when you try to delete a Database or a Document and they > don't exist, you get a 404 error. Instead, in case you delete an Attachment > that doesn't exist, you'll get a 200 status code. > Here the three cases: > == > Database deletion > == > DELETE /adajhdgas HTTP/1.1 > Accept: application/json > User-Agent: ElephantOnCouch 0.1 > Connection: close > Host: 127.0.0.1:5984 > Authorization: Basic cGlwcG86Y2FsaXBwbw== > HTTP/1.1 404 Object Not Found > Server: CouchDB/1.2.0 (Erlang OTP/R15B02) > Date: Thu, 08 Nov 2012 16:58:07 GMT > Content-Type: application/json > Content-Length: 41 > Cache-Control: must-revalidate > {"error":"not_found","reason":"missing"} > == > == > Document deletion > == > DELETE /programmazione/000569be-ecd9-446f-f681-74224e3dfc8b?rev=hhgg HTTP/1.1 > Accept: application/json > User-Agent: ElephantOnCouch 0.1 > Connection: close > Host: 127.0.0.1:5984 > Authorization: Basic cGlwcG86Y2FsaXBwbw== > HTTP/1.1 404 Object Not Found > Server: CouchDB/1.2.0 (Erlang OTP/R15B02) > Date: Thu, 08 Nov 2012 16:55:26 GMT > Content-Type: application/json > Content-Length: 41 > Cache-Control: must-revalidate > {"error":"not_found","reason":"deleted"} > == > == > Attachment deletion > == > DELETE > /programmazione/0003ef13-f2dd-4ccd-cbcb-dec902e7bca7/pippo%3F.txt?rev=3-54bb13543ca770a223611a1307e45dc9 > HTTP/1.1 > Accept: application/json > User-Agent: ElephantOnCouch 0.1 > Connection: close > Host: 127.0.0.1:5984 > Authorization: Basic cGlwcG86Y2FsaXBwbw== > HTTP/1.1 200 OK > Server: CouchDB/1.2.0 (Erlang OTP/R15B02) > Date: Thu, 08 Nov 2012 16:59:49 GMT > Content-Type: application/json > Content-Length: 99 > Cache-Control: must-revalidate > {"ok":true,"id":"0003ef13-f2dd-4ccd-cbcb-dec902e7bca7","rev":"4-e8973f12e1ad7190d8a6b737b97b7073"} > == -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (COUCHDB-2992) Add additional support for document size
[ https://issues.apache.org/jira/browse/COUCHDB-2992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15931063#comment-15931063 ] ASF GitHub Bot commented on COUCHDB-2992: - Github user nickva closed the pull request at: https://github.com/apache/couchdb-documentation/pull/113 > Add additional support for document size > > > Key: COUCHDB-2992 > URL: https://issues.apache.org/jira/browse/COUCHDB-2992 > Project: CouchDB > Issue Type: Improvement > Components: Database Core >Reporter: Tony Sun > > Currently, only max_document_size of 64 GB is the restriction for users > creating documents. Large documents often leads to issues with our indexers. > This feature will allow users more finer grain control over document size. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (COUCHDB-3328) JS test runner does not report failures correctly
[ https://issues.apache.org/jira/browse/COUCHDB-3328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15930875#comment-15930875 ] ASF GitHub Bot commented on COUCHDB-3328: - GitHub user wohali opened a pull request: https://github.com/apache/couchdb/pull/456 Count JS test pass/fails; return proper exit code Currently `test/javascript/run` always returns an exit code of `0`, regardless of whether any tests fail or not. This makes any sort of automated testing that expects to inspect the results of the run invalid. `make javascript` should now properly fail if any of the JS tests fail. It also prints a numerical summary of passed/failed tests, similar to the eunit results. Fixes COUCHDB-3328 You can merge this pull request into a Git repository by running: $ git pull https://github.com/wohali/couchdb 3328-fix-js-test-runner Alternatively you can review and apply these changes as the patch at: https://github.com/apache/couchdb/pull/456.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #456 commit fe16873de170f08beae90116fc5e0126eb22cf43 Author: Joan Touzet Date: 2017-03-17T23:08:33Z Count JS test pass/fails; return proper exit code > JS test runner does not report failures correctly > - > > Key: COUCHDB-3328 > URL: https://issues.apache.org/jira/browse/COUCHDB-3328 > Project: CouchDB > Issue Type: Bug > Components: Test Suite >Reporter: Joan Touzet >Assignee: Joan Touzet > > Currently {{test/javascript/run}} always returns an exit code of {{0}}, > regardless of whether any tests fail or not. This makes any sort of automated > testing that expects to inspect the results of the run invalid. > This ticket will update the runner so that it will: > * Return a 1 when any test fails, and > * Print a count summary at the end of the run of how many tests succeeded, > failed, or were ignored/skipped. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (COUCHDB-3224) Fauxton not correctly display database with "-" and "/" symbol in name
[ https://issues.apache.org/jira/browse/COUCHDB-3224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15928151#comment-15928151 ] ASF GitHub Bot commented on COUCHDB-3224: - Github user garrensmith commented on the issue: https://github.com/apache/couchdb-fauxton/pull/802 @sergey-safarov I will take a look next week. The PR has quite wide reaching effects. So I need to take a look at it. Leave it as is for now. > Fauxton not correctly display database with "-" and "/" symbol in name > -- > > Key: COUCHDB-3224 > URL: https://issues.apache.org/jira/browse/COUCHDB-3224 > Project: CouchDB > Issue Type: Bug > Components: Fauxton >Reporter: Sergey Safarov > > Fauxton cannot display database with "-" symbol in name and cannot display > view with "/" simbol in database name. > Tu reproduce execute "curl -X PUT > http://127.0.0.1:5984/mytest%2Fdata%2Fbase-201609"; ant try open this database > via fauxton. > Also if you create view for this database then this view wont work. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (COUCHDB-3224) Fauxton not correctly display database with "-" and "/" symbol in name
[ https://issues.apache.org/jira/browse/COUCHDB-3224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15928146#comment-15928146 ] ASF GitHub Bot commented on COUCHDB-3224: - Github user sergey-safarov commented on the issue: https://github.com/apache/couchdb-fauxton/pull/802 @garrensmith I updated PR but exist two issues: 1) tests is looped 2) two tests is failed. I can revert back last changes. > Fauxton not correctly display database with "-" and "/" symbol in name > -- > > Key: COUCHDB-3224 > URL: https://issues.apache.org/jira/browse/COUCHDB-3224 > Project: CouchDB > Issue Type: Bug > Components: Fauxton >Reporter: Sergey Safarov > > Fauxton cannot display database with "-" symbol in name and cannot display > view with "/" simbol in database name. > Tu reproduce execute "curl -X PUT > http://127.0.0.1:5984/mytest%2Fdata%2Fbase-201609"; ant try open this database > via fauxton. > Also if you create view for this database then this view wont work. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (COUCHDB-2565) Responsive Fauxton
[ https://issues.apache.org/jira/browse/COUCHDB-2565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15928127#comment-15928127 ] ASF GitHub Bot commented on COUCHDB-2565: - GitHub user garrensmith opened an issue: https://github.com/apache/couchdb-fauxton/issues/876 More responsive Fauxton For a full responsive Fauxton I think we would need: throw out the current not maintained Bootstrap 2 which is mainly just used for button styling at the moment make use of an actively maintained bootstrap and use it's helper to create responsive grids Some good points from @michellephung Suggestions: 1. We could collapse the left most nav when the screen is below a certain width. 2. Also maybe when the width gets really small, collapse the api url/ add new database/ search buttons down to icon-only (like in buttons the code editor). Taken from https://issues.apache.org/jira/browse/COUCHDB-2565 > Responsive Fauxton > -- > > Key: COUCHDB-2565 > URL: https://issues.apache.org/jira/browse/COUCHDB-2565 > Project: CouchDB > Issue Type: Improvement > Components: Fauxton >Reporter: Robert Kowalski > Attachments: after.png, before.png > > > For a full responsive Fauxton I think we would need: > - throw out the current not maintained Bootstrap 2 which is mainly just used > for button styling at the moment > - make use of an actively maintained bootstrap and use it's helper to create > responsive grids > Some good points from [~michellep]: > Suggestions: > 1. We could collapse the left most nav when the screen is below a certain > width. > 2. Also maybe when the width gets really small, collapse the api url/ add new > database/ search buttons down to icon-only (like in buttons the code editor). -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (COUCHDB-3045) replace safeURLName in code
[ https://issues.apache.org/jira/browse/COUCHDB-3045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15928091#comment-15928091 ] ASF GitHub Bot commented on COUCHDB-3045: - GitHub user garrensmith opened an issue: https://github.com/apache/couchdb-fauxton/issues/875 replace safeURLName in code We have a still some usages of safeURLName where we manually slice of the _design prefix for design docs. Later we glue the prefix on again. We have a helper function that handles that already, which is also available in the utils.js file. Task: find appearances of safeURLName with code search, understand how it is used, remove custom safeURLName shenanigans with their design doc handling and replace it with other helper function. Good beginner task to get your toes wet with our codebase. Taken from https://issues.apache.org/jira/browse/COUCHDB-3045 > replace safeURLName in code > --- > > Key: COUCHDB-3045 > URL: https://issues.apache.org/jira/browse/COUCHDB-3045 > Project: CouchDB > Issue Type: Bug > Components: Fauxton >Reporter: Robert Kowalski >Assignee: Ryan Millay > Labels: beginner > > We have a still some usages of safeURLName where we manually slice of the > _design prefix for design docs. Later we glue the prefix on again. We have a > helper function that handles that already, which is also available in the > utils.js file. > Task: find appearances of safeURLName with code search, understand how it is > used, remove custom safeURLName shenanigans with their design doc handling > and replace it with other helper function. > Good beginner task to get your toes wet with our codebase. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (COUCHDB-3139) Single Node Setup on Fauxton forces non-127.0.0.1 IP
[ https://issues.apache.org/jira/browse/COUCHDB-3139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15928084#comment-15928084 ] ASF GitHub Bot commented on COUCHDB-3139: - GitHub user garrensmith opened an issue: https://github.com/apache/couchdb-fauxton/issues/874 Single Node Setup on Fauxton forces non-127.0.0.1 IP Single node setups might just want to bind to 127.0.0.1, this could be fore security on the db server, or on a dev machine. Currently, the setup wizard for the single-node case forces an ip address other than 127.0.0.1, we should not do that Taken from https://issues.apache.org/jira/browse/COUCHDB-3139 > Single Node Setup on Fauxton forces non-127.0.0.1 IP > > > Key: COUCHDB-3139 > URL: https://issues.apache.org/jira/browse/COUCHDB-3139 > Project: CouchDB > Issue Type: Bug > Components: Fauxton >Reporter: Jan Lehnardt > > Single node setups might just want to bind to 127.0.0.1, this could be fore > security on the db server, or on a dev machine. > Currently, the setup wizard for the single-node case forces an ip address > other than 127.0.0.1, we should not do that :) -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (COUCHDB-2120) Navigate to the user's document
[ https://issues.apache.org/jira/browse/COUCHDB-2120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15928071#comment-15928071 ] ASF GitHub Bot commented on COUCHDB-2120: - GitHub user garrensmith opened an issue: https://github.com/apache/couchdb-fauxton/issues/873 Navigate to the user's document Futon doesn't allows this, but this would be extremely useful if by clicking on username on sidebar while user is logged in to quickly navigate to the document in auth db that belongs to that user. Some kind of profile feature. Taken from https://issues.apache.org/jira/browse/COUCHDB-2120 > Navigate to the user's document > --- > > Key: COUCHDB-2120 > URL: https://issues.apache.org/jira/browse/COUCHDB-2120 > Project: CouchDB > Issue Type: New Feature > Components: Fauxton >Reporter: Alexander Shorin > > Futon doesn't allows this, but this would be extremely useful if by clicking > on username on sidebar while user is logged in to quickly navigate to the > document in auth db that belongs to that user. Some kind of profile feature. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (COUCHDB-2757) Copied & pasted string with newlines should show JSON syntax error in Ace editors
[ https://issues.apache.org/jira/browse/COUCHDB-2757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15928056#comment-15928056 ] ASF GitHub Bot commented on COUCHDB-2757: - GitHub user garrensmith opened an issue: https://github.com/apache/couchdb-fauxton/issues/871 Copied & pasted string with newlines should show JSON syntax error in Ace editors Copying & pasting in text with newlines into a string in the full page doc editor (and probably any Ace editor field) should show an error icon in the gutter, but it doesn't. Taken from https://issues.apache.org/jira/browse/COUCHDB-2757 > Copied & pasted string with newlines should show JSON syntax error in Ace > editors > - > > Key: COUCHDB-2757 > URL: https://issues.apache.org/jira/browse/COUCHDB-2757 > Project: CouchDB > Issue Type: Bug > Components: Fauxton >Reporter: Ben Keen >Assignee: Ben Keen > > Copying & pasting in text with newlines into a string in the full page doc > editor (and probably any Ace editor field) should show an error icon in the > gutter, but it doesn't. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (COUCHDB-2586) Problem scrolling to end of a long line in Ace editor
[ https://issues.apache.org/jira/browse/COUCHDB-2586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15927988#comment-15927988 ] ASF GitHub Bot commented on COUCHDB-2586: - GitHub user garrensmith opened an issue: https://github.com/apache/couchdb-fauxton/issues/870 Problem scrolling to end of a long line in Ace editor There's a bug with the Ace editor configuration (full page + elsewhere) where if you have a single very long line of text - long enough to make the horizontal scrollbar appear, you can't scroll to the very end of the line. This occurs in all browsers. It looks like the editor is failing to take into account the width of the vertical scrollbar, so the final 1 or 2 characters get hidden. I spent some time investigating this thinking it was our bug, but it turns out to be a bug with Ace itself. I've opened a ticket here: https://github.com/ajaxorg/ace/issues/2360 Taken from https://issues.apache.org/jira/browse/COUCHDB-2586 > Problem scrolling to end of a long line in Ace editor > - > > Key: COUCHDB-2586 > URL: https://issues.apache.org/jira/browse/COUCHDB-2586 > Project: CouchDB > Issue Type: Bug > Components: Fauxton >Reporter: Ben Keen >Assignee: Ben Keen > > There's a bug with the Ace editor configuration (full page + elsewhere) where > if you have a single very long line of text - long enough to make the > horizontal scrollbar appear, you can't scroll to the very end of the line. > This occurs in all browsers. It looks like the editor is failing to take into > account the width of the vertical scrollbar, so the final 1 or 2 characters > get hidden. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (COUCHDB-2108) Group databases with / char
[ https://issues.apache.org/jira/browse/COUCHDB-2108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15927984#comment-15927984 ] ASF GitHub Bot commented on COUCHDB-2108: - GitHub user garrensmith opened an issue: https://github.com/apache/couchdb-fauxton/issues/869 Group databases with / char Currently databases with / char in name showed as flat list. While it's ok, but the main trick of having this char in db name is to group the databases on filesystem. It would be awesome if Fauxton will also group them in UI, providing fold/unfold buttons. Taken from https://issues.apache.org/jira/browse/COUCHDB-2108 > Group databases with / char > --- > > Key: COUCHDB-2108 > URL: https://issues.apache.org/jira/browse/COUCHDB-2108 > Project: CouchDB > Issue Type: Improvement > Components: Fauxton >Reporter: Alexander Shorin > Labels: advanced > > Currently databases with / char in name showed as flat list. While it's ok, > but the main trick of having this char in db name is to group the databases > on filesystem. It would be awesome if Fauxton will also group them in UI, > providing fold/unfold buttons. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (COUCHDB-3224) Fauxton not correctly display database with "-" and "/" symbol in name
[ https://issues.apache.org/jira/browse/COUCHDB-3224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15927954#comment-15927954 ] ASF GitHub Bot commented on COUCHDB-3224: - Github user garrensmith commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/802#discussion_r106408017 --- Diff: app/addons/databases/actions.js --- @@ -155,7 +155,7 @@ export default { type: 'success', clear: true }); -var route = FauxtonAPI.urls('allDocs', 'app', app.utils.safeURLName(databaseName), '?limit=' + Resources.DocLimit); +var route = FauxtonAPI.urls('allDocs', 'app', encodeURIComponent(databaseName), '?limit=' + Resources.DocLimit); --- End diff -- Could you rather use this function https://github.com/apache/couchdb-fauxton/blob/master/app/addons/documents/base.js#L40 and then you don't need to encodeURIComponent > Fauxton not correctly display database with "-" and "/" symbol in name > -- > > Key: COUCHDB-3224 > URL: https://issues.apache.org/jira/browse/COUCHDB-3224 > Project: CouchDB > Issue Type: Bug > Components: Fauxton >Reporter: Sergey Safarov > > Fauxton cannot display database with "-" symbol in name and cannot display > view with "/" simbol in database name. > Tu reproduce execute "curl -X PUT > http://127.0.0.1:5984/mytest%2Fdata%2Fbase-201609"; ant try open this database > via fauxton. > Also if you create view for this database then this view wont work. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (COUCHDB-3224) Fauxton not correctly display database with "-" and "/" symbol in name
[ https://issues.apache.org/jira/browse/COUCHDB-3224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15927953#comment-15927953 ] ASF GitHub Bot commented on COUCHDB-3224: - Github user garrensmith commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/802#discussion_r106408073 --- Diff: app/addons/databases/actions.js --- @@ -176,7 +176,7 @@ export default { databaseName = databaseName.trim(); -const url = FauxtonAPI.urls('allDocs', 'app', app.utils.safeURLName(databaseName), ''); +const url = FauxtonAPI.urls('allDocs', 'app', encodeURIComponent(databaseName), ''); --- End diff -- Same as aboce it seems its better to use `allDocsSantized` then you don't need to encodeURIComponent > Fauxton not correctly display database with "-" and "/" symbol in name > -- > > Key: COUCHDB-3224 > URL: https://issues.apache.org/jira/browse/COUCHDB-3224 > Project: CouchDB > Issue Type: Bug > Components: Fauxton >Reporter: Sergey Safarov > > Fauxton cannot display database with "-" symbol in name and cannot display > view with "/" simbol in database name. > Tu reproduce execute "curl -X PUT > http://127.0.0.1:5984/mytest%2Fdata%2Fbase-201609"; ant try open this database > via fauxton. > Also if you create view for this database then this view wont work. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (COUCHDB-3224) Fauxton not correctly display database with "-" and "/" symbol in name
[ https://issues.apache.org/jira/browse/COUCHDB-3224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15927946#comment-15927946 ] ASF GitHub Bot commented on COUCHDB-3224: - Github user garrensmith commented on the issue: https://github.com/apache/couchdb-fauxton/pull/802 @sergey-safarov seems it was a travis issue. Could you fix the lint issues and try again. > Fauxton not correctly display database with "-" and "/" symbol in name > -- > > Key: COUCHDB-3224 > URL: https://issues.apache.org/jira/browse/COUCHDB-3224 > Project: CouchDB > Issue Type: Bug > Components: Fauxton >Reporter: Sergey Safarov > > Fauxton cannot display database with "-" symbol in name and cannot display > view with "/" simbol in database name. > Tu reproduce execute "curl -X PUT > http://127.0.0.1:5984/mytest%2Fdata%2Fbase-201609"; ant try open this database > via fauxton. > Also if you create view for this database then this view wont work. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (COUCHDB-2992) Add additional support for document size
[ https://issues.apache.org/jira/browse/COUCHDB-2992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15927455#comment-15927455 ] ASF GitHub Bot commented on COUCHDB-2992: - GitHub user nickva opened a pull request: https://github.com/apache/couchdb-documentation/pull/113 Bring back the correct implementation of max_document_size COUCHDB-2992 You can merge this pull request into a Git repository by running: $ git pull https://github.com/cloudant/couchdb-documentation couchdb-2992 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/couchdb-documentation/pull/113.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #113 commit 55cad9af960e4d299bbf387a9e57cd8c7e6273c8 Author: Nick Vatamaniuc Date: 2017-03-16T04:07:02Z Bring back the correct implementation of max_document_size COUCHDB-2992 > Add additional support for document size > > > Key: COUCHDB-2992 > URL: https://issues.apache.org/jira/browse/COUCHDB-2992 > Project: CouchDB > Issue Type: Improvement > Components: Database Core >Reporter: Tony Sun > > Currently, only max_document_size of 64 GB is the restriction for users > creating documents. Large documents often leads to issues with our indexers. > This feature will allow users more finer grain control over document size. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (COUCHDB-2992) Add additional support for document size
[ https://issues.apache.org/jira/browse/COUCHDB-2992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15927383#comment-15927383 ] ASF GitHub Bot commented on COUCHDB-2992: - Github user asfgit closed the pull request at: https://github.com/apache/couchdb-couch-mrview/pull/69 > Add additional support for document size > > > Key: COUCHDB-2992 > URL: https://issues.apache.org/jira/browse/COUCHDB-2992 > Project: CouchDB > Issue Type: Improvement > Components: Database Core >Reporter: Tony Sun > > Currently, only max_document_size of 64 GB is the restriction for users > creating documents. Large documents often leads to issues with our indexers. > This feature will allow users more finer grain control over document size. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (COUCHDB-2992) Add additional support for document size
[ https://issues.apache.org/jira/browse/COUCHDB-2992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15927366#comment-15927366 ] ASF GitHub Bot commented on COUCHDB-2992: - Github user asfgit closed the pull request at: https://github.com/apache/couchdb-fabric/pull/91 > Add additional support for document size > > > Key: COUCHDB-2992 > URL: https://issues.apache.org/jira/browse/COUCHDB-2992 > Project: CouchDB > Issue Type: Improvement > Components: Database Core >Reporter: Tony Sun > > Currently, only max_document_size of 64 GB is the restriction for users > creating documents. Large documents often leads to issues with our indexers. > This feature will allow users more finer grain control over document size. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (COUCHDB-2992) Add additional support for document size
[ https://issues.apache.org/jira/browse/COUCHDB-2992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15927363#comment-15927363 ] ASF GitHub Bot commented on COUCHDB-2992: - Github user asfgit closed the pull request at: https://github.com/apache/couchdb-chttpd/pull/157 > Add additional support for document size > > > Key: COUCHDB-2992 > URL: https://issues.apache.org/jira/browse/COUCHDB-2992 > Project: CouchDB > Issue Type: Improvement > Components: Database Core >Reporter: Tony Sun > > Currently, only max_document_size of 64 GB is the restriction for users > creating documents. Large documents often leads to issues with our indexers. > This feature will allow users more finer grain control over document size. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (COUCHDB-2992) Add additional support for document size
[ https://issues.apache.org/jira/browse/COUCHDB-2992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15927357#comment-15927357 ] ASF GitHub Bot commented on COUCHDB-2992: - Github user asfgit closed the pull request at: https://github.com/apache/couchdb-couch/pull/235 > Add additional support for document size > > > Key: COUCHDB-2992 > URL: https://issues.apache.org/jira/browse/COUCHDB-2992 > Project: CouchDB > Issue Type: Improvement > Components: Database Core >Reporter: Tony Sun > > Currently, only max_document_size of 64 GB is the restriction for users > creating documents. Large documents often leads to issues with our indexers. > This feature will allow users more finer grain control over document size. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (COUCHDB-2992) Add additional support for document size
[ https://issues.apache.org/jira/browse/COUCHDB-2992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15927073#comment-15927073 ] ASF GitHub Bot commented on COUCHDB-2992: - GitHub user nickva opened a pull request: https://github.com/apache/couchdb-couch-mrview/pull/69 Allow limiting maximum document body size This is a companion commit to this one: https://github.com/apache/couchdb-couch/pull/235 COUCHDB-2992 You can merge this pull request into a Git repository by running: $ git pull https://github.com/cloudant/couchdb-couch-mrview couchdb-2992 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/couchdb-couch-mrview/pull/69.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #69 commit 398c30e8785c3cd880d7d9788d25810dfe626c18 Author: Nick Vatamaniuc Date: 2017-03-15T21:55:22Z Allow limiting maximum document body size This is a companion commit to this one: https://github.com/apache/couchdb-couch/pull/235 COUCHDB-2992 > Add additional support for document size > > > Key: COUCHDB-2992 > URL: https://issues.apache.org/jira/browse/COUCHDB-2992 > Project: CouchDB > Issue Type: Improvement > Components: Database Core >Reporter: Tony Sun > > Currently, only max_document_size of 64 GB is the restriction for users > creating documents. Large documents often leads to issues with our indexers. > This feature will allow users more finer grain control over document size. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (COUCHDB-3224) Fauxton not correctly display database with "-" and "/" symbol in name
[ https://issues.apache.org/jira/browse/COUCHDB-3224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15926942#comment-15926942 ] ASF GitHub Bot commented on COUCHDB-3224: - Github user sergey-safarov commented on the issue: https://github.com/apache/couchdb-fauxton/pull/802 Hello @garrensmith Could you look error present in build log. Think some dependency cannot be installed. > Fauxton not correctly display database with "-" and "/" symbol in name > -- > > Key: COUCHDB-3224 > URL: https://issues.apache.org/jira/browse/COUCHDB-3224 > Project: CouchDB > Issue Type: Bug > Components: Fauxton >Reporter: Sergey Safarov > > Fauxton cannot display database with "-" symbol in name and cannot display > view with "/" simbol in database name. > Tu reproduce execute "curl -X PUT > http://127.0.0.1:5984/mytest%2Fdata%2Fbase-201609"; ant try open this database > via fauxton. > Also if you create view for this database then this view wont work. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (COUCHDB-3325) Track _replicator/_user shards with LRU
[ https://issues.apache.org/jira/browse/COUCHDB-3325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15926161#comment-15926161 ] ASF GitHub Bot commented on COUCHDB-3325: - Github user asfgit closed the pull request at: https://github.com/apache/couchdb-couch/pull/237 > Track _replicator/_user shards with LRU > --- > > Key: COUCHDB-3325 > URL: https://issues.apache.org/jira/browse/COUCHDB-3325 > Project: CouchDB > Issue Type: Bug >Reporter: Robert Newson > > We excluded _replicator and _users databases from the LRU many years ago, > before clustering. > It is now possible to make many _replicator and _users databases (and > clustering multiples this effect). > A couchdb cluster can degrade considerably in the presence of many of these > databases even when they are empty and idle. They consume resources but are > never closed. > Let's include all sys_db databases in the LRU. Any active ones will remain > open anyway, that's the point of an LRU. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (COUCHDB-2992) Add additional support for document size
[ https://issues.apache.org/jira/browse/COUCHDB-2992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15925154#comment-15925154 ] ASF GitHub Bot commented on COUCHDB-2992: - Github user tonysun83 closed the pull request at: https://github.com/apache/couchdb-chttpd/pull/114 > Add additional support for document size > > > Key: COUCHDB-2992 > URL: https://issues.apache.org/jira/browse/COUCHDB-2992 > Project: CouchDB > Issue Type: Improvement > Components: Database Core >Reporter: Tony Sun > > Currently, only max_document_size of 64 GB is the restriction for users > creating documents. Large documents often leads to issues with our indexers. > This feature will allow users more finer grain control over document size. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (COUCHDB-3324) Scheduling Replicator
[ https://issues.apache.org/jira/browse/COUCHDB-3324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15924955#comment-15924955 ] ASF GitHub Bot commented on COUCHDB-3324: - GitHub user nickva opened a pull request: https://github.com/apache/couchdb-chttpd/pull/158 63012 scheduler This is part of a set of PRs to merge the new scheduling replicator Main PR is this: apache/couchdb-couch-replicator#64 Top level PR to gather and help test all the dependencies: apache/couchdb#454 COUCHDB-3324 You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/couchdb-chttpd 63012-scheduler Alternatively you can review and apply these changes as the patch at: https://github.com/apache/couchdb-chttpd/pull/158.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #158 commit b8c218b2e586adeb84d8d496105ede4cc6357331 Author: Benjamin Bastian Date: 2017-03-10T21:06:04Z Add `_scheduler/{jobs,docs}` API endpoints The `_scheduler/docs` endpoint provides a view of all replicator docs which have been seen by the scheduler. This endpoint includes useful information such as the state of the replication and the coordinator node. The `_scheduler/jobs` endpoint provides a view of all replications managed by the scheduler. This endpoint includes more information on the replication than the `_scheduler/docs` endpoint, including the history of state transitions of the replication. commit d493c9573f88520c5d24ef0f7ad9fc2e19a398b2 Author: Benjamin Bastian Date: 2017-03-14T18:15:52Z Merge pull request #3 from cloudant/63012-scheduler-tasks-api Add `_scheduler/{jobs,docs}` API endpoints > Scheduling Replicator > - > > Key: COUCHDB-3324 > URL: https://issues.apache.org/jira/browse/COUCHDB-3324 > Project: CouchDB > Issue Type: New Feature >Reporter: Nick Vatamaniuc > > Merge scheduling replicator -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (COUCHDB-3324) Scheduling Replicator
[ https://issues.apache.org/jira/browse/COUCHDB-3324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15924947#comment-15924947 ] ASF GitHub Bot commented on COUCHDB-3324: - GitHub user nickva opened a pull request: https://github.com/apache/couchdb-couch/pull/238 Add _replication_start_time to the doc field validation section. This is part of a set of PRs to merge the new scheduling replicator Main PR is this: https://github.com/apache/couchdb-couch-replicator/pull/64 Top level PR to gather and help test all the dependencies: https://github.com/apache/couchdb/pull/454 COUCHDB-3324 You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/couchdb-couch 63012-scheduler Alternatively you can review and apply these changes as the patch at: https://github.com/apache/couchdb-couch/pull/238.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #238 commit f92b68f66bfd286b8702527a2322cfc4c0c2a2bc Author: Nick Vatamaniuc Date: 2016-11-04T21:27:13Z Add _replication_start_time to the doc field validation section. > Scheduling Replicator > - > > Key: COUCHDB-3324 > URL: https://issues.apache.org/jira/browse/COUCHDB-3324 > Project: CouchDB > Issue Type: New Feature >Reporter: Nick Vatamaniuc > > Merge scheduling replicator -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (COUCHDB-3324) Scheduling Replicator
[ https://issues.apache.org/jira/browse/COUCHDB-3324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15924944#comment-15924944 ] ASF GitHub Bot commented on COUCHDB-3324: - GitHub user nickva opened a pull request: https://github.com/apache/couchdb-couch-replicator/pull/64 63012 scheduler Pull request to merge scheduling replicator work to ASF master. This repository has most of the changes. The feature overall consists of updates to 3 repositories: this one (replicator), couch and chttpd. To test all there is a separate top level PR to couchdb: https://github.com/apache/couchdb/pull/454 COUCHDB-3324 You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/couchdb-couch-replicator 63012-scheduler Alternatively you can review and apply these changes as the patch at: https://github.com/apache/couchdb-couch-replicator/pull/64.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #64 > Scheduling Replicator > - > > Key: COUCHDB-3324 > URL: https://issues.apache.org/jira/browse/COUCHDB-3324 > Project: CouchDB > Issue Type: New Feature >Reporter: Nick Vatamaniuc > > Merge scheduling replicator -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (COUCHDB-3324) Scheduling Replicator
[ https://issues.apache.org/jira/browse/COUCHDB-3324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15924899#comment-15924899 ] ASF GitHub Bot commented on COUCHDB-3324: - GitHub user nickva opened a pull request: https://github.com/apache/couchdb/pull/454 Point to scheduling replicator dependencies. This updates chttpd, couch, and couch_replicator to point to current commits on 63012-scheduler branches which contain code for the new scheduling replicator. COUCHDB-3324 This PR can be used to test current heads of all the scheduling replicator branches on all the involved dependencies. You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/couchdb 63012-scheduler Alternatively you can review and apply these changes as the patch at: https://github.com/apache/couchdb/pull/454.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #454 commit e9840c74adc9c7622cda1d964294f910530066f2 Author: Nick Vatamaniuc Date: 2017-03-14T19:55:06Z Point to scheduling replicator dependencies. This updates chttpd, couch, and couch_replicator to point to current commits on 63012-scheduler branches which contain code for the new scheduling replicator. COUCHDB-3324 > Scheduling Replicator > - > > Key: COUCHDB-3324 > URL: https://issues.apache.org/jira/browse/COUCHDB-3324 > Project: CouchDB > Issue Type: New Feature >Reporter: Nick Vatamaniuc > > Merge scheduling replicator -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (COUCHDB-2992) Add additional support for document size
[ https://issues.apache.org/jira/browse/COUCHDB-2992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15923697#comment-15923697 ] ASF GitHub Bot commented on COUCHDB-2992: - GitHub user nickva opened a pull request: https://github.com/apache/couchdb-fabric/pull/91 Allow limiting maximum document body size Update doc function to check and validate document body sizes Main implementation is in PR: https://github.com/apache/couchdb-couch/pull/235 COUCHDB-2992 You can merge this pull request into a Git repository by running: $ git pull https://github.com/cloudant/couchdb-fabric couchdb-2992 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/couchdb-fabric/pull/91.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #91 commit 3b15107df83a16a26dbc6c06a1a080437cb558b8 Author: Nick Vatamaniuc Date: 2017-03-14T06:59:31Z Allow limiting maximum document body size Update doc function to check and validate document body sizes Main implementation is in PR: https://github.com/apache/couchdb-couch/pull/235 COUCHDB-2992 > Add additional support for document size > > > Key: COUCHDB-2992 > URL: https://issues.apache.org/jira/browse/COUCHDB-2992 > Project: CouchDB > Issue Type: Improvement > Components: Database Core >Reporter: Tony Sun > > Currently, only max_document_size of 64 GB is the restriction for users > creating documents. Large documents often leads to issues with our indexers. > This feature will allow users more finer grain control over document size. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (COUCHDB-3323) Idle dbs cause excessive overhead
[ https://issues.apache.org/jira/browse/COUCHDB-3323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15922822#comment-15922822 ] ASF GitHub Bot commented on COUCHDB-3323: - GitHub user nickva opened a pull request: https://github.com/apache/couchdb-couch/pull/236 Close idle dbs Previously idle dbs, especially sys_dbs like _replicator shards once opened once for scanning would stay open forever. In a large cluster with many _replicator shards that can add up to a significant overhead, mostly in terms of number of active processes. Add a mechanism to close dbs which have an idle db updater. Before hibernation was used to limit the memory pressure, however that is often not enough in practice. Ideally timeout value would be a configuration option, however we don't want to add an ets call for every couch_db_updater callback, and modifiying the db record is prohibitive for this patch, however PSE does this work and once it lands we can read the idle configuration when the process starts. (Original idea for this belongs to Paul Davis) COUCHDB-3323 You can merge this pull request into a Git repository by running: $ git pull https://github.com/cloudant/couchdb-couch close-idle-dbs Alternatively you can review and apply these changes as the patch at: https://github.com/apache/couchdb-couch/pull/236.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #236 commit 85a9f13632a6828420e01cc7d39cdaa7c19c2170 Author: Nick Vatamaniuc Date: 2017-03-10T19:24:01Z Close idle dbs Previously idle dbs, especially sys_dbs like _replicator shards once opened once for scanning would stay open forever. In a large cluster with many _replicator shards that can add up to a significant overhead, mostly in terms of number of active processes. Add a mechanism to close dbs which have an idle db updater. Before hibernation was used to limit the memory pressure, however that is often not enough in practice. Ideally timeout value would be a configuration option, however we don't want to add an ets call for every couch_db_updater callback, and modifiying the db record is prohibitive for this patch, however PSE does this work and once it lands we can read the idle configuration when the process starts. (Original idea for this belongs to Paul Davis) COUCHDB-3323 > Idle dbs cause excessive overhead > - > > Key: COUCHDB-3323 > URL: https://issues.apache.org/jira/browse/COUCHDB-3323 > Project: CouchDB > Issue Type: Bug >Reporter: Nick Vatamaniuc > > Idle dbs, especially sys_dbs like _replicator shards once opened > once for scanning would stay open forever. In a large cluster with many > _replicator shards that can add up to a significant overhead, mostly in terms > of number of active processes. > Add a mechanism to close dbs which are idle. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (COUCHDB-2992) Add additional support for document size
[ https://issues.apache.org/jira/browse/COUCHDB-2992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15907580#comment-15907580 ] ASF GitHub Bot commented on COUCHDB-2992: - GitHub user nickva opened a pull request: https://github.com/apache/couchdb-chttpd/pull/157 Allow limiting maximum document body size This is the HTTP layer and some tests. The actual checking is done in couch application's from_json_obj/1 function. If a document is too large it will return a 413 response code. The error reason will be the document ID. The intent is to help users identify the document if they used _bulk_docs endpoint. It will also help replicator skip over documents which are too large. COUCHDB-2992 You can merge this pull request into a Git repository by running: $ git pull https://github.com/cloudant/couchdb-chttpd couchdb-2992 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/couchdb-chttpd/pull/157.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #157 commit 95ecd629f77444dd5fa2820fbc18cccaba350f6d Author: Nick Vatamaniuc Date: 2017-03-13T06:22:19Z Allow limiting maximum document body size This is the HTTP layer and some tests. The actual checking is done in couch application's from_json_obj/1 function. If a document is too large it will return a 413 response code. The error reason will be the document ID. The intent is to help users identify the document if they used _bulk_docs endpoint. It will also help replicator skip over documents which are too large. COUCHDB-2992 > Add additional support for document size > > > Key: COUCHDB-2992 > URL: https://issues.apache.org/jira/browse/COUCHDB-2992 > Project: CouchDB > Issue Type: Improvement > Components: Database Core >Reporter: Tony Sun > > Currently, only max_document_size of 64 GB is the restriction for users > creating documents. Large documents often leads to issues with our indexers. > This feature will allow users more finer grain control over document size. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (COUCHDB-2992) Add additional support for document size
[ https://issues.apache.org/jira/browse/COUCHDB-2992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15907575#comment-15907575 ] ASF GitHub Bot commented on COUCHDB-2992: - GitHub user nickva opened a pull request: https://github.com/apache/couchdb-couch/pull/235 Allow limiting maximum document body size Configuration is via the `couchdb.max_document_size`. In the past that was implemented as a maximum http request body size and this finally implements it by actually checking a document's body size. COUCHDB-2992 You can merge this pull request into a Git repository by running: $ git pull https://github.com/cloudant/couchdb-couch couchdb-2992 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/couchdb-couch/pull/235.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #235 commit c51c3f2bdc8e2f2a135c8363096762607ed33f2c Author: Nick Vatamaniuc Date: 2017-03-13T06:33:57Z Allow limiting maximum document body size Configuration is via the `couchdb.max_document_size`. In the past that was implemented as a maximum http request body size and this finally implements it by actually checking a document's body size. COUCHDB-2992 > Add additional support for document size > > > Key: COUCHDB-2992 > URL: https://issues.apache.org/jira/browse/COUCHDB-2992 > Project: CouchDB > Issue Type: Improvement > Components: Database Core >Reporter: Tony Sun > > Currently, only max_document_size of 64 GB is the restriction for users > creating documents. Large documents often leads to issues with our indexers. > This feature will allow users more finer grain control over document size. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (COUCHDB-3305) don't crash with invalid input to built in reducer function
[ https://issues.apache.org/jira/browse/COUCHDB-3305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15901996#comment-15901996 ] ASF GitHub Bot commented on COUCHDB-3305: - Github user asfgit closed the pull request at: https://github.com/apache/couchdb-couch/pull/234 > don't crash with invalid input to built in reducer function > --- > > Key: COUCHDB-3305 > URL: https://issues.apache.org/jira/browse/COUCHDB-3305 > Project: CouchDB > Issue Type: Improvement > Components: Database Core >Reporter: Tony Sun >Assignee: Tony Sun > > When users use a built in reduce function such as _sum, and documents have > invalid input, we currently crash and return a 500 with error message. This > improvement will return an error row without crashing for better debugging. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (COUCHDB-3305) don't crash with invalid input to built in reducer function
[ https://issues.apache.org/jira/browse/COUCHDB-3305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15901925#comment-15901925 ] ASF GitHub Bot commented on COUCHDB-3305: - GitHub user iilyak opened a pull request: https://github.com/apache/couchdb-couch/pull/234 Fix initial accumulator value for builtin_sum_rows This a fixup for https://github.com/apache/couchdb-couch/pull/229. The initial value for accumulator suppose to be 0. Since the result of sum and count is integer. The problem was discovered by dialyzer. COUCHDB-3305 You can merge this pull request into a Git repository by running: $ git pull https://github.com/cloudant/couchdb-couch 70794-fix-initial-acc-for-builtin_sum_rows Alternatively you can review and apply these changes as the patch at: https://github.com/apache/couchdb-couch/pull/234.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #234 commit 1f152daaac23dc96132139fb532786f77becdd64 Author: ILYA Khlopotov Date: 2017-03-08T20:24:46Z Fix initial accumulator value for builtin_sum_rows This a fixup for https://github.com/apache/couchdb-couch/pull/229. The initial value for accumulator suppose to be 0. Since the result of sum and count is integer. The problem was discovered by dialyzer. COUCHDB-3305 > don't crash with invalid input to built in reducer function > --- > > Key: COUCHDB-3305 > URL: https://issues.apache.org/jira/browse/COUCHDB-3305 > Project: CouchDB > Issue Type: Improvement > Components: Database Core >Reporter: Tony Sun >Assignee: Tony Sun > > When users use a built in reduce function such as _sum, and documents have > invalid input, we currently crash and return a 500 with error message. This > improvement will return an error row without crashing for better debugging. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (COUCHDB-2992) Add additional support for document size
[ https://issues.apache.org/jira/browse/COUCHDB-2992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15901475#comment-15901475 ] ASF GitHub Bot commented on COUCHDB-2992: - Github user asfgit closed the pull request at: https://github.com/apache/couchdb-documentation/pull/105 > Add additional support for document size > > > Key: COUCHDB-2992 > URL: https://issues.apache.org/jira/browse/COUCHDB-2992 > Project: CouchDB > Issue Type: Improvement > Components: Database Core >Reporter: Tony Sun > > Currently, only max_document_size of 64 GB is the restriction for users > creating documents. Large documents often leads to issues with our indexers. > This feature will allow users more finer grain control over document size. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (COUCHDB-3305) don't crash with invalid input to built in reducer function
[ https://issues.apache.org/jira/browse/COUCHDB-3305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15900648#comment-15900648 ] ASF GitHub Bot commented on COUCHDB-3305: - Github user asfgit closed the pull request at: https://github.com/apache/couchdb-couch/pull/229 > don't crash with invalid input to built in reducer function > --- > > Key: COUCHDB-3305 > URL: https://issues.apache.org/jira/browse/COUCHDB-3305 > Project: CouchDB > Issue Type: Improvement > Components: Database Core >Reporter: Tony Sun >Assignee: Tony Sun > > When users use a built in reduce function such as _sum, and documents have > invalid input, we currently crash and return a 500 with error message. This > improvement will return an error row without crashing for better debugging. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (COUCHDB-2992) Add additional support for document size
[ https://issues.apache.org/jira/browse/COUCHDB-2992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15900639#comment-15900639 ] ASF GitHub Bot commented on COUCHDB-2992: - GitHub user nickva opened a pull request: https://github.com/apache/couchdb-documentation/pull/105 Add documentation for the new `max_http_request_size` parameter COUCHDB-2992 You can merge this pull request into a Git repository by running: $ git pull https://github.com/cloudant/couchdb-documentation update-max-http-request-size Alternatively you can review and apply these changes as the patch at: https://github.com/apache/couchdb-documentation/pull/105.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #105 commit 96773e78d4fcc8107e43af020c0dc1def62e229d Author: Nick Vatamaniuc Date: 2017-03-08T03:35:21Z Add documentation for the new `max_http_request_size` parameter COUCHDB-2992 > Add additional support for document size > > > Key: COUCHDB-2992 > URL: https://issues.apache.org/jira/browse/COUCHDB-2992 > Project: CouchDB > Issue Type: Improvement > Components: Database Core >Reporter: Tony Sun > > Currently, only max_document_size of 64 GB is the restriction for users > creating documents. Large documents often leads to issues with our indexers. > This feature will allow users more finer grain control over document size. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (COUCHDB-2992) Add additional support for document size
[ https://issues.apache.org/jira/browse/COUCHDB-2992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15900528#comment-15900528 ] ASF GitHub Bot commented on COUCHDB-2992: - Github user asfgit closed the pull request at: https://github.com/apache/couchdb-couch/pull/233 > Add additional support for document size > > > Key: COUCHDB-2992 > URL: https://issues.apache.org/jira/browse/COUCHDB-2992 > Project: CouchDB > Issue Type: Improvement > Components: Database Core >Reporter: Tony Sun > > Currently, only max_document_size of 64 GB is the restriction for users > creating documents. Large documents often leads to issues with our indexers. > This feature will allow users more finer grain control over document size. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (COUCHDB-2992) Add additional support for document size
[ https://issues.apache.org/jira/browse/COUCHDB-2992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15900438#comment-15900438 ] ASF GitHub Bot commented on COUCHDB-2992: - Github user asfgit closed the pull request at: https://github.com/apache/couchdb-couch-replicator/pull/61 > Add additional support for document size > > > Key: COUCHDB-2992 > URL: https://issues.apache.org/jira/browse/COUCHDB-2992 > Project: CouchDB > Issue Type: Improvement > Components: Database Core >Reporter: Tony Sun > > Currently, only max_document_size of 64 GB is the restriction for users > creating documents. Large documents often leads to issues with our indexers. > This feature will allow users more finer grain control over document size. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (COUCHDB-2992) Add additional support for document size
[ https://issues.apache.org/jira/browse/COUCHDB-2992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15900296#comment-15900296 ] ASF GitHub Bot commented on COUCHDB-2992: - GitHub user nickva opened a pull request: https://github.com/apache/couchdb-couch-replicator/pull/61 Fix unit test after renaming max_document_size config parameter `couchdb.max_document_size` was renamed to `httpd.max_http_request_size` The unit tests was testing how replicator behaves when faced with reduced request size configuration on the target. COUCHDB-2992 You can merge this pull request into a Git repository by running: $ git pull https://github.com/cloudant/couchdb-couch-replicator 64229-add-new-request-parameter Alternatively you can review and apply these changes as the patch at: https://github.com/apache/couchdb-couch-replicator/pull/61.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #61 commit d43aa56c8814dbfd94c8856dc017bfe45047 Author: Nick Vatamaniuc Date: 2017-03-07T22:24:00Z Fix unit test after renaming max_document_size config parameter `couchdb.max_document_size` was renamed to `httpd.max_http_request_size` The unit tests was testing how replicator behaves when faced with reduced request size configuration on the target. COUCHDB-2992 > Add additional support for document size > > > Key: COUCHDB-2992 > URL: https://issues.apache.org/jira/browse/COUCHDB-2992 > Project: CouchDB > Issue Type: Improvement > Components: Database Core >Reporter: Tony Sun > > Currently, only max_document_size of 64 GB is the restriction for users > creating documents. Large documents often leads to issues with our indexers. > This feature will allow users more finer grain control over document size. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (COUCHDB-2992) Add additional support for document size
[ https://issues.apache.org/jira/browse/COUCHDB-2992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15900268#comment-15900268 ] ASF GitHub Bot commented on COUCHDB-2992: - GitHub user nickva opened a pull request: https://github.com/apache/couchdb-couch/pull/233 Rename max_document_size to max_http_request_size `max_document_size` is implemented as `max_http_request_size`. There was no real check for document size. In some cases the implementation was close enough of a proxy (PUT-ing and GET-ing single docs), but in some edge cases, like _bulk_docs requests the discrepancy between request size and document size could be rather large. The section was changed accordingly from `couchdb` to `httpd`. `httpd` was chosen as it applies to both clustered as well as local interface. There is a parallel effort to implement an actual max_document_size check. The set of commit should be merged close enough together to allow for a backwards compatible transition. COUCHDB-2992 You can merge this pull request into a Git repository by running: $ git pull https://github.com/cloudant/couchdb-couch 64229-add-new-request-parameter Alternatively you can review and apply these changes as the patch at: https://github.com/apache/couchdb-couch/pull/233.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #233 commit d3055f191797f8b637e3b64f6a50e522d2c8bbde Author: Nick Vatamaniuc Date: 2017-03-07T21:47:11Z Rename max_document_size to max_http_request_size `max_document_size` is implemented as `max_http_request_size`. There was no real check for document size. In some cases the implementation was close enough of a proxy (PUT-ing and GET-ing single docs), but in some edge cases, like _bulk_docs requests the discrepancy between request size and document size could be rather large. The section was changed accordingly from `couchdb` to `httpd`. `httpd` was chosen as it applies to both clustered as well as local interface. There is a parallel effort to implement an actual max_document_size check. The set of commit should be merged close enough together to allow for a backwards compatible transition. COUCHDB-2992 > Add additional support for document size > > > Key: COUCHDB-2992 > URL: https://issues.apache.org/jira/browse/COUCHDB-2992 > Project: CouchDB > Issue Type: Improvement > Components: Database Core >Reporter: Tony Sun > > Currently, only max_document_size of 64 GB is the restriction for users > creating documents. Large documents often leads to issues with our indexers. > This feature will allow users more finer grain control over document size. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (COUCHDB-2992) Add additional support for document size
[ https://issues.apache.org/jira/browse/COUCHDB-2992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15900264#comment-15900264 ] ASF GitHub Bot commented on COUCHDB-2992: - Github user asfgit closed the pull request at: https://github.com/apache/couchdb-couch-replicator/pull/60 > Add additional support for document size > > > Key: COUCHDB-2992 > URL: https://issues.apache.org/jira/browse/COUCHDB-2992 > Project: CouchDB > Issue Type: Improvement > Components: Database Core >Reporter: Tony Sun > > Currently, only max_document_size of 64 GB is the restriction for users > creating documents. Large documents often leads to issues with our indexers. > This feature will allow users more finer grain control over document size. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (COUCHDB-2992) Add additional support for document size
[ https://issues.apache.org/jira/browse/COUCHDB-2992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15900027#comment-15900027 ] ASF GitHub Bot commented on COUCHDB-2992: - GitHub user nickva opened a pull request: https://github.com/apache/couchdb-couch-replicator/pull/60 Remove unused mp_parse_doc function from replicator It was left accidentally when merging Cloudant's dbcore work. COUCHDB-2992 You can merge this pull request into a Git repository by running: $ git pull https://github.com/cloudant/couchdb-couch-replicator couchdb-2992-remove-dead-code Alternatively you can review and apply these changes as the patch at: https://github.com/apache/couchdb-couch-replicator/pull/60.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #60 > Add additional support for document size > > > Key: COUCHDB-2992 > URL: https://issues.apache.org/jira/browse/COUCHDB-2992 > Project: CouchDB > Issue Type: Improvement > Components: Database Core >Reporter: Tony Sun > > Currently, only max_document_size of 64 GB is the restriction for users > creating documents. Large documents often leads to issues with our indexers. > This feature will allow users more finer grain control over document size. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (COUCHDB-3318) bypass couch_httpd_vhost if there are none
[ https://issues.apache.org/jira/browse/COUCHDB-3318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15897361#comment-15897361 ] ASF GitHub Bot commented on COUCHDB-3318: - Github user asfgit closed the pull request at: https://github.com/apache/couchdb-couch/pull/232 > bypass couch_httpd_vhost if there are none > -- > > Key: COUCHDB-3318 > URL: https://issues.apache.org/jira/browse/COUCHDB-3318 > Project: CouchDB > Issue Type: Bug >Reporter: Robert Newson > Fix For: 2.1.0 > > > all http requests call couch_httpd_vhost (a gen_server:call) on all requests. > On hosts that have no virtual hosts this is a waste of time and can lead to > request failures if the gen_server doesn't respond within the default timeout > of five seconds. > Find an efficient way to avoid the gen_server call on hosts with no > configured virtual hosts. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (COUCHDB-3318) bypass couch_httpd_vhost if there are none
[ https://issues.apache.org/jira/browse/COUCHDB-3318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15897183#comment-15897183 ] ASF GitHub Bot commented on COUCHDB-3318: - GitHub user rnewson opened a pull request: https://github.com/apache/couchdb-couch/pull/232 Efficiently bypass vhost handling if there are none COUCHDB-3318 You can merge this pull request into a Git repository by running: $ git pull https://github.com/cloudant/couchdb-couch 3318-bypass-vhosts Alternatively you can review and apply these changes as the patch at: https://github.com/apache/couchdb-couch/pull/232.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #232 commit f706bb87be71006875c2fbaed3a14a18c79396f8 Author: Robert Newson Date: 2017-03-06T12:05:33Z Efficiently bypass vhost handling if there are none COUCHDB-3318 > bypass couch_httpd_vhost if there are none > -- > > Key: COUCHDB-3318 > URL: https://issues.apache.org/jira/browse/COUCHDB-3318 > Project: CouchDB > Issue Type: Bug >Reporter: Robert Newson > > all http requests call couch_httpd_vhost (a gen_server:call) on all requests. > On hosts that have no virtual hosts this is a waste of time and can lead to > request failures if the gen_server doesn't respond within the default timeout > of five seconds. > Find an efficient way to avoid the gen_server call on hosts with no > configured virtual hosts. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (COUCHDB-3224) Fauxton not correctly display database with "-" and "/" symbol in name
[ https://issues.apache.org/jira/browse/COUCHDB-3224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15896575#comment-15896575 ] ASF GitHub Bot commented on COUCHDB-3224: - Github user sergey-safarov commented on the issue: https://github.com/apache/couchdb-fauxton/pull/802 Is may be removed "safeURLName" function from app.utils? View name displaying is fixed view not work properly. I not know how to fix. > Fauxton not correctly display database with "-" and "/" symbol in name > -- > > Key: COUCHDB-3224 > URL: https://issues.apache.org/jira/browse/COUCHDB-3224 > Project: CouchDB > Issue Type: Bug > Components: Fauxton >Reporter: Sergey Safarov > > Fauxton cannot display database with "-" symbol in name and cannot display > view with "/" simbol in database name. > Tu reproduce execute "curl -X PUT > http://127.0.0.1:5984/mytest%2Fdata%2Fbase-201609"; ant try open this database > via fauxton. > Also if you create view for this database then this view wont work. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (COUCHDB-3224) Fauxton not correctly display database with "-" and "/" symbol in name
[ https://issues.apache.org/jira/browse/COUCHDB-3224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15896574#comment-15896574 ] ASF GitHub Bot commented on COUCHDB-3224: - Github user sergey-safarov commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/802#discussion_r104326088 --- Diff: app/addons/documents/index-editor/stores.js --- @@ -186,7 +186,7 @@ Stores.IndexEditorStore = FauxtonAPI.Store.extend({ getSaveDesignDoc: function () { if (this._designDocId === 'new-doc') { var doc = { -_id: '_design/' + this._newDesignDocName, +_id: '_design/' + encodeURIComponent(this._newDesignDocName), --- End diff -- Is may be removed "safeURLName" function from app.utils? > Fauxton not correctly display database with "-" and "/" symbol in name > -- > > Key: COUCHDB-3224 > URL: https://issues.apache.org/jira/browse/COUCHDB-3224 > Project: CouchDB > Issue Type: Bug > Components: Fauxton >Reporter: Sergey Safarov > > Fauxton cannot display database with "-" symbol in name and cannot display > view with "/" simbol in database name. > Tu reproduce execute "curl -X PUT > http://127.0.0.1:5984/mytest%2Fdata%2Fbase-201609"; ant try open this database > via fauxton. > Also if you create view for this database then this view wont work. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (COUCHDB-3224) Fauxton not correctly display database with "-" and "/" symbol in name
[ https://issues.apache.org/jira/browse/COUCHDB-3224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15896571#comment-15896571 ] ASF GitHub Bot commented on COUCHDB-3224: - Github user sergey-safarov commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/802#discussion_r104326008 --- Diff: app/addons/documents/components/jumptodoc.react.jsx --- @@ -28,7 +28,7 @@ const JumpToDoc = ({database, loadOptions}) => { ignoreCase={false} cache={false} onChange={({value: docId}) => { - const url = FauxtonAPI.urls('document', 'app', encodeURIComponent(database.id), app.utils.safeURLName(docId)); + const url = FauxtonAPI.urls('document', 'app', encodeURIComponent(database.id), encodeURIComponent(docId)); --- End diff -- Is may be removed "safeURLName" function from app.utils? > Fauxton not correctly display database with "-" and "/" symbol in name > -- > > Key: COUCHDB-3224 > URL: https://issues.apache.org/jira/browse/COUCHDB-3224 > Project: CouchDB > Issue Type: Bug > Components: Fauxton >Reporter: Sergey Safarov > > Fauxton cannot display database with "-" symbol in name and cannot display > view with "/" simbol in database name. > Tu reproduce execute "curl -X PUT > http://127.0.0.1:5984/mytest%2Fdata%2Fbase-201609"; ant try open this database > via fauxton. > Also if you create view for this database then this view wont work. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (COUCHDB-3224) Fauxton not correctly display database with "-" and "/" symbol in name
[ https://issues.apache.org/jira/browse/COUCHDB-3224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15896567#comment-15896567 ] ASF GitHub Bot commented on COUCHDB-3224: - Github user sergey-safarov commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/802#discussion_r104325765 --- Diff: app/addons/documents/index-editor/stores.js --- @@ -186,7 +186,7 @@ Stores.IndexEditorStore = FauxtonAPI.Store.extend({ getSaveDesignDoc: function () { if (this._designDocId === 'new-doc') { var doc = { -_id: '_design/' + this._newDesignDocName, +_id: '_design/' + encodeURIComponent(this._newDesignDocName), --- End diff -- Here is encoded DesignDoc name in POST request to CouchDB Where is may be encoded viewname in POST request to CouchDB? > Fauxton not correctly display database with "-" and "/" symbol in name > -- > > Key: COUCHDB-3224 > URL: https://issues.apache.org/jira/browse/COUCHDB-3224 > Project: CouchDB > Issue Type: Bug > Components: Fauxton >Reporter: Sergey Safarov > > Fauxton cannot display database with "-" symbol in name and cannot display > view with "/" simbol in database name. > Tu reproduce execute "curl -X PUT > http://127.0.0.1:5984/mytest%2Fdata%2Fbase-201609"; ant try open this database > via fauxton. > Also if you create view for this database then this view wont work. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (COUCHDB-3316) Log replicator db name not just doc ids
[ https://issues.apache.org/jira/browse/COUCHDB-3316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15894599#comment-15894599 ] ASF GitHub Bot commented on COUCHDB-3316: - Github user asfgit closed the pull request at: https://github.com/apache/couchdb-couch-replicator/pull/59 > Log replicator db name not just doc ids > --- > > Key: COUCHDB-3316 > URL: https://issues.apache.org/jira/browse/COUCHDB-3316 > Project: CouchDB > Issue Type: Improvement >Reporter: Nick Vatamaniuc > > Currently replicator logs only doc_id. However in 2.0 there could be more > than one _replicator db. So for logs to be useful it would be nice to log the > db as well. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (COUCHDB-3316) Log replicator db name not just doc ids
[ https://issues.apache.org/jira/browse/COUCHDB-3316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15894583#comment-15894583 ] ASF GitHub Bot commented on COUCHDB-3316: - Github user asfgit closed the pull request at: https://github.com/apache/couchdb-couch/pull/231 > Log replicator db name not just doc ids > --- > > Key: COUCHDB-3316 > URL: https://issues.apache.org/jira/browse/COUCHDB-3316 > Project: CouchDB > Issue Type: Improvement >Reporter: Nick Vatamaniuc > > Currently replicator logs only doc_id. However in 2.0 there could be more > than one _replicator db. So for logs to be useful it would be nice to log the > db as well. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (COUCHDB-3316) Log replicator db name not just doc ids
[ https://issues.apache.org/jira/browse/COUCHDB-3316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15893633#comment-15893633 ] ASF GitHub Bot commented on COUCHDB-3316: - GitHub user nickva opened a pull request: https://github.com/apache/couchdb-couch/pull/231 Fix `badarith` error in couch_db:get_db_info call When folding we account for a previous `null`, `undefined`, or a number. However btree:size/1 returns 0, `nil` or a number. Switched `undefined` to `nil`. Couldn't find where btree:size would ever return `undefined`, it seems we meant to use `nil` instead. COUCHDB-3316 You can merge this pull request into a Git repository by running: $ git pull https://github.com/cloudant/couchdb-couch couchdb-3316 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/couchdb-couch/pull/231.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #231 commit 63ef337475a266379c7208f52f827980e69d1d1b Author: Nick Vatamaniuc Date: 2017-03-03T02:24:52Z Fix `badarith` error in couch_db:get_db_info call When folding we account for a previous `null`, `undefined`, or a number. However btree:size/1 returns 0, `nil` or a number. Switched `undefined` to `nil`. Couldn't find where btree:size would ever return `undefined`, it seems we meant to use `nil` instead. COUCHDB-3316 > Log replicator db name not just doc ids > --- > > Key: COUCHDB-3316 > URL: https://issues.apache.org/jira/browse/COUCHDB-3316 > Project: CouchDB > Issue Type: Improvement >Reporter: Nick Vatamaniuc > > Currently replicator logs only doc_id. However in 2.0 there could be more > than one _replicator db. So for logs to be useful it would be nice to log the > db as well. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (COUCHDB-3316) Log replicator db name not just doc ids
[ https://issues.apache.org/jira/browse/COUCHDB-3316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15893350#comment-15893350 ] ASF GitHub Bot commented on COUCHDB-3316: - GitHub user nickva opened a pull request: https://github.com/apache/couchdb-couch-replicator/pull/59 Make sure to log db as well as doc in replicator logs. COUCHDB-3316 You can merge this pull request into a Git repository by running: $ git pull https://github.com/cloudant/couchdb-couch-replicator couchdb-3316 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/couchdb-couch-replicator/pull/59.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #59 commit 50dcd7d7c5f7ce003e8e2fc84646c1aa9931ebaa Author: Nick Vatamaniuc Date: 2017-03-03T00:12:47Z Make sure to log db as well as doc in replicator logs. COUCHDB-3316 > Log replicator db name not just doc ids > --- > > Key: COUCHDB-3316 > URL: https://issues.apache.org/jira/browse/COUCHDB-3316 > Project: CouchDB > Issue Type: Improvement >Reporter: Nick Vatamaniuc > > Currently replicator logs only doc_id. However in 2.0 there could be more > than one _replicator db. So for logs to be useful it would be nice to log the > db as well. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (COUCHDB-3311) Restore jitter-ed sleep to replicator manager shard discovery
[ https://issues.apache.org/jira/browse/COUCHDB-3311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15890454#comment-15890454 ] ASF GitHub Bot commented on COUCHDB-3311: - Github user asfgit closed the pull request at: https://github.com/apache/couchdb-couch-replicator/pull/58 > Restore jitter-ed sleep to replicator manager shard discovery > - > > Key: COUCHDB-3311 > URL: https://issues.apache.org/jira/browse/COUCHDB-3311 > Project: CouchDB > Issue Type: Bug >Reporter: Nick Vatamaniuc > > Jitter-ed sleep or was dropped inadvertently when we switch to using mem3 > shards instead of scanning the file system. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (COUCHDB-3311) Restore jitter-ed sleep to replicator manager shard discovery
[ https://issues.apache.org/jira/browse/COUCHDB-3311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15889992#comment-15889992 ] ASF GitHub Bot commented on COUCHDB-3311: - GitHub user rnewson opened a pull request: https://github.com/apache/couchdb-couch-replicator/pull/58 Prevent couch_replicator_manager crashing when replicator db is deleted couch_replicator_manager can crash in a couple of spots if the replicator db is deleted between the time the scan finds it and the resume_scan message is processed. This patch also reverts the jitter patch which attempted to address this situation. COUCHDB-3311 You can merge this pull request into a Git repository by running: $ git pull https://github.com/cloudant/couchdb-couch-replicator 83663-crashes Alternatively you can review and apply these changes as the patch at: https://github.com/apache/couchdb-couch-replicator/pull/58.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #58 commit 1e413b8afa6eb156eb5293d1dc0d5726cd5063fc Author: Robert Newson Date: 2017-03-01T11:15:55Z Revert "Restore adding some jitter-ed sleep to shard scanning code." This reverts commit 45d739af3fcf8b4f8e3ccca152cb3c2d781dc2fc. commit 7a2b2b68bf4afa6d20b56a8ae51361f83981412a Author: Robert Newson Date: 2017-03-01T11:14:02Z fix crashes when replicator db is deleted BugzID: 83663 > Restore jitter-ed sleep to replicator manager shard discovery > - > > Key: COUCHDB-3311 > URL: https://issues.apache.org/jira/browse/COUCHDB-3311 > Project: CouchDB > Issue Type: Bug >Reporter: Nick Vatamaniuc > > Jitter-ed sleep or was dropped inadvertently when we switch to using mem3 > shards instead of scanning the file system. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (COUCHDB-3307) Limit calls to maybe_add_sys_db_callbacks to once per db open
[ https://issues.apache.org/jira/browse/COUCHDB-3307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15888923#comment-15888923 ] ASF GitHub Bot commented on COUCHDB-3307: - Github user asfgit closed the pull request at: https://github.com/apache/couchdb-couch/pull/230 > Limit calls to maybe_add_sys_db_callbacks to once per db open > - > > Key: COUCHDB-3307 > URL: https://issues.apache.org/jira/browse/COUCHDB-3307 > Project: CouchDB > Issue Type: Bug > Components: Database Core >Reporter: Bala Kolla > > As part of performance regression testing we found out that there was a code > change in > {{couch_server:open/2,}} > {{Options = maybe_add_sys_db_callbacks(DbName, Options0)}} > and as a result of that change, we are basically calling > {{maybe_add_sys_db_callbacks}} for each request instead of once per db open. > We have tested a fix to ensure that we call {{maybe_add_sys_db_callbacks}} > only once per db open. And executed a GET performance benchmark and found the > following improvements. > * Throughput: Up to ~5% improvement. > * Up to ~22% improvement in p90 and p99 latencies -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (COUCHDB-3311) Restore jitter-ed sleep to replicator manager shard discovery
[ https://issues.apache.org/jira/browse/COUCHDB-3311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15888710#comment-15888710 ] ASF GitHub Bot commented on COUCHDB-3311: - Github user asfgit closed the pull request at: https://github.com/apache/couchdb-couch-replicator/pull/57 > Restore jitter-ed sleep to replicator manager shard discovery > - > > Key: COUCHDB-3311 > URL: https://issues.apache.org/jira/browse/COUCHDB-3311 > Project: CouchDB > Issue Type: Bug >Reporter: Nick Vatamaniuc > > Jitter-ed sleep or was dropped inadvertently when we switch to using mem3 > shards instead of scanning the file system. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (COUCHDB-3311) Restore jitter-ed sleep to replicator manager shard discovery
[ https://issues.apache.org/jira/browse/COUCHDB-3311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15888697#comment-15888697 ] ASF GitHub Bot commented on COUCHDB-3311: - GitHub user nickva opened a pull request: https://github.com/apache/couchdb-couch-replicator/pull/57 Restore adding some jitter-ed sleep to shard scanning code. Otherwise a large cluster will flood replicator manager with potentially hundreds of thousands of `{resume, Shard}` messages. For each one, it would try to open a changes feed which can add significant load and has been seen in production to hit varios system limits. This brings back the change from before the switch to using mem3 shards for replicator db scans. Also adds a few tests. COUCHDB-3311 You can merge this pull request into a Git repository by running: $ git pull https://github.com/cloudant/couchdb-couch-replicator couchdb-3311 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/couchdb-couch-replicator/pull/57.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #57 > Restore jitter-ed sleep to replicator manager shard discovery > - > > Key: COUCHDB-3311 > URL: https://issues.apache.org/jira/browse/COUCHDB-3311 > Project: CouchDB > Issue Type: Bug >Reporter: Nick Vatamaniuc > > Jitter-ed sleep or was dropped inadvertently when we switch to using mem3 > shards instead of scanning the file system. -- This message was sent by Atlassian JIRA (v6.3.15#6346)