[GitHub] couchdb-fauxton issue #864: Update replication to work with scheduler api
Github user justin-mcdavid-ibm commented on the issue: https://github.com/apache/couchdb-fauxton/pull/864 Thanks for the work, Garren. It looks great. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-fauxton issue #864: Update replication to work with scheduler api
Github user justin-mcdavid-ibm commented on the issue: https://github.com/apache/couchdb-fauxton/pull/864 Hey Garren, Lookin' good! That section is rather slick. I see a few lingering issues, and a handful of things to polish, and then I think we're good. Something has changed broken alignment of the values in the replication form:  And the width for the dropdown values is still not matching the width of the dropdown field (for both source and target local dbs):  The doc-conflict buttons could still use some extra space (20px) between them:  I noticed that the job-deleted banner message (and message in the notification center) is picking up more than just the replication number:  The length is such that I noticed a lack-of-wrapping bug in the notification center, which is something I'll open up a bug on.  Can we strip off the non-job-id information in that job name, and add a period to the end of the statement? **Some polish and tweaks:** With only one Action icon on the _replicate Activity table, I think it would be better to align it under the column header:  I realize that "everybody" permissions terminology is going to be confusing for those who've set permissions using the CL, where the user is "nobody." For the last paragraph in this hoverhelp, I'd like to change the statement to "If the remote database granted permissions to unauthenticated connections, you do not need to enter a username or password."  Let's align the (now shorter) caveats with the text in the first content column (Source) in the tables. I think that would be 80px from the left.   It would be nice to swap out the white-check icon for the previously used replication icon:   And swap the white-check icon on the verify-deletion buttons for trashcan icons:  Thanks for your work on this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-fauxton issue #864: Update replication to work with scheduler api
Github user justin-mcdavid-ibm commented on the issue: https://github.com/apache/couchdb-fauxton/pull/864 Here's the mockup: https://cloud.githubusercontent.com/assets/12969375/23628932/edf63806-026a-11e7-949a-1224760807ac.png;> So, no tab on this page. And instead of "Replication > New Replication" or the proposed "Replication-Job Details," I think "Job Configuration" in the header will be a better descriptor. Because you can edit an existing job on this page, "New" isn't exactly correct (though I know an edited job is just a new job on the back of a stopped one). I know you're mid-way through this, and the beta doesn't necessarily reflect the most recent work, so apologies if this is already on your radar, but the local source/target dropdown component doesn't yet match the length of the longer dropdown field. Also, I realized that we can now remove some of the text from our Verify Deletion error messages, now that replicator and _replicate have separate tabs. Also, we need to change some of the button text, as _replicate deletions don't involve deleting a document. Here are the messages, varying on whether deletion is triggered through the bulk selector, or in the table-row trashcan icons: https://cloud.githubusercontent.com/assets/12969375/23630045/6315d04e-026e-11e7-9f24-5f5eab144b50.png;> https://cloud.githubusercontent.com/assets/12969375/23630044/6314733e-026e-11e7-8c5a-475f3cf9c6b6.png;> Thanks for the work on this. It's looking great. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-fauxton issue #833: remove backbone from auth
Github user justin-mcdavid-ibm commented on the issue: https://github.com/apache/couchdb-fauxton/pull/833 Hi Tim, thanks for your work on this section. Here are some ideas of what we might do with that section. https://cloud.githubusercontent.com/assets/12969375/22844688/4c306926-ef94-11e6-82f9-7026754807d4.png;> https://cloud.githubusercontent.com/assets/12969375/22844690/4f9b2ed4-ef94-11e6-9e72-e371123acd53.png;> https://cloud.githubusercontent.com/assets/12969375/22844692/52c7aeb6-ef94-11e6-94d2-e238399d6186.png;> https://cloud.githubusercontent.com/assets/12969375/22844697/5505d374-ef94-11e6-80d5-8c1150c7ab70.png;> We've been trying to move towards a main-nav/tabs model to free up more real estate (you can see this in the Replication section, where we have a tabs component that you could reuse). I'm sure Garren would be able to help if you have any questions on the component. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-fauxton issue #837: Add an ETA field for active tasks tab
Github user justin-mcdavid-ibm commented on the issue: https://github.com/apache/couchdb-fauxton/pull/837 @kevinjqiu great idea and work. If we add ETA, though, I think it might make sense to re-order the display of information slightly. Placing **Started on** and **Estimated Completion** side-by-side would make it easier to make quick relative comparisons. And it might make sense to add the **Updated on** value to the value list in the **Status** column-- which would mean that the display on smaller screens (like mine) wouldn't be squished by the addition of a new column. Thanks for the work on this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-fauxton issue #761: New replication
Github user justin-mcdavid-ibm commented on the issue: https://github.com/apache/couchdb-fauxton/pull/761 Hey Garren, Great work. Thanks for all the effort that you put into this. The UI looks ready to go. Everything appears to be behaving as it should. +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-fauxton issue #761: New replication
Github user justin-mcdavid-ibm commented on the issue: https://github.com/apache/couchdb-fauxton/pull/761 Hi Garren, 1. As we just discussed, the combining of the two remote options will not be feasible (thanks for the clarification), but we can add a caveat to the form so that users will not have incorrect expectations about system behavior (replicating into a pre-existing db when they think they're creating a new database). So, when the user selects "New remote database" from the dropdown, let's add the following statement below the example string. If a "new" database already exists, data will replicate into that existing database. 2. Also, when a user selects "New remote database," the middle sentence in the embedded help panel should not appear, (as db permissions cannot be set on not-yet-existing dbs). 3. On looking at the example string, I think the icon in the middle of the example isn't working as well as it could. I think the following changes to that string would be improvements: - Remove the "Example:" label. I think the combination of grayed-out text plus the icon make it implicitly clearer as to what it is. - Move the hover help icon to the end of the example string. - Keep the string grayed out, but change the icon color to #08c - Give the icon an orange (#F3812D) hover in addition to the evoking of the help panel. 4. I noticed that hover-state for the clear-field X in the dashboard is now Cloudant-orange but that the drop-down arrows are still Fauxton red. 5. Add the following sentence to the Replication page when there are not any replication jobs showing: There is no replicator-db activity or history to display. Component fixes (not necessary to finish this feature): 1. I'm still seeing a bit of styling-weirdness that happens when horizontal scrolling happens in the dropdown component. But I think that's a component fix, and not necessarily for this feature. 2. The bulk selector checkbox remains selected after bulk-delete happens. Not a big thing, 3. The ellipses on long values selected in dropdown boxes still overlap with dropdown arrows, and are of a different text color than the selected values are. Once we have those final changes (1-5), I believe we're good to go. Thanks for all your work on this. https://cloud.githubusercontent.com/assets/12969375/20279754/a8e016b0-aa5e-11e6-857f-a3c3de8f82ce.png;> https://cloud.githubusercontent.com/assets/12969375/20279762/b39a2bcc-aa5e-11e6-86e5-7940bfd5a068.png;> https://cloud.githubusercontent.com/assets/12969375/20279895/3620f3c8-aa5f-11e6-8dde-f48e1a32a7e6.png;> --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-fauxton issue #761: New replication
Github user justin-mcdavid-ibm commented on the issue: https://github.com/apache/couchdb-fauxton/pull/761 This is looking better and better. There are a few bugs we still want to squish, but I think we're almost there. # Create Replication Page 1. The Create Replication page should not have the polling or refresh components. 2. The dropdown arrows and the X for clearing the custom-doc field are picking up the Fauxton red hover state, rather than the Cloudant orange. 3. Most selected/entered text in the completed form is now #55, However text in the Source Name dropdown is #33. I'd previously was hoping that all that text could be consistently #33. If that's too much of a pain, I'd settle for consistently #55. # Activity Page 1. The hyperlink highlighting for local dbs listed in either source or target columns is being picked up by the final forward slash before the database name starts. Might be tricky to fix, as I see that line-breaks are also happening before that final slash. 2. The down arrow for column sort is picking up Fauxton red, rather than Cloudant Orange # Dialogues 1. In the last sentence of the Fix Document Conflict Dialogue, please change "Replicationed documents" to "replicated documents." 2. Remove the unstyled "Close" button on the error-message dialogue. https://cloud.githubusercontent.com/assets/12969375/20197785/208ba1f4-a756-11e6-8426-a16eda4c74c6.png;> https://cloud.githubusercontent.com/assets/12969375/20197793/2884791c-a756-11e6-98ff-c4356f004ac5.png;> https://cloud.githubusercontent.com/assets/12969375/20197865/7c0b4052-a756-11e6-8b16-41c853348cc0.png;> https://cloud.githubusercontent.com/assets/12969375/20197878/83f1c976-a756-11e6-91d6-f26c1bd7fa62.png;> --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-fauxton issue #761: New replication
Github user justin-mcdavid-ibm commented on the issue: https://github.com/apache/couchdb-fauxton/pull/761 Hi Garren, 1. Looking at replication, and as we discussed, we should combine the "New remote database" and "Existing remote database" options into a single "A remote database" option. We can't currently validate that a "new" database doesn't already exist, and back out of the replication process. 2. After chatting about the remote source/target issues, I think we should clarify our examples. I don't want to clutter up the page with too much text, but I think we should do some handholding here, just to clarify. I propose that we simplify the URL example to: Example: https://$USERNAME:$PASSWORD@$REMOTE_SERVER/$DATABASE and then add a ? icon to the "Example:" label with the following explanatory text: "If you have username and password for the remote account, use the remote username and remote password. If your local account has permissions on the remote database, you can use your local username and local password. If the remote database has granted permissions to "everybody," you do not need to include a username and password." --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-fauxton issue #761: New replication
Github user justin-mcdavid-ibm commented on the issue: https://github.com/apache/couchdb-fauxton/pull/761 Hey Garren-- This is looking great. Beyond the changes we talked about on video conference, here are some things I've noticed while playing around. And I'm having problems getting remote->remote replication to work (I'm getting permissions errors that I'm not expecting), and local->remote are failing to complete. So I'm not able to test some thing at this time. # Activity Page 1. In-field text for "Filter replication" is 16px. Please reduce to 14px. And let's get rid of the input box's padding; the box doesn't need to be so visually dominant. 2. Remove the "Ok" button on error-message dialogue boxes 3. To slightly improve readability, can we strip the first set of curly brackets off of displayed error messages? 4. The Edit Replication (wrench) functionality breaks if the replication document ID starts with a forward slash. 5. Can we have the Activity page column-sort default to State Time, descending from new-to-old? 6. When you add the refresh options to the header, could you make sure that column-sort selection persists over refreshes or when the back-button is clicked? When I refresh via the browser, it's resetting my sort selection. # New Replication Page 1. The "Clear" replication-clear-link text is 16px. Please reduce to 14px. Also increase the left-padding of replication-clear-link from 12px to something like 12px 0 12px 24px (ow whatever will move it a similar distance to the right). 2. On hover for truncated long values in dropdowns, can we have the full value display? 3. Remover the API URL button from the header on this page, too. 4. Change the title of the Replication Error dialogue to "Fix Document Conflict." Capitalize the first letter of the first paragraph in the message. Add the eraser icon (http://fontawesome.io/3.2.1/icon/eraser/) to the "Overwrite Existing Document" button. 5. Malformed remote source/target URLs prevent a replication from being sent off when the Start Replication button is clicked, but there's no indicator of why the job failed. Can we add highlighting to URL fields that are malformed once the Start Replication button is clicked? # Component issues? 1. Long db names in the local-db dropdown list are hidden behind the slider (this is a component issue?). We should either give them some right-padding so that the slider doesn't cover them, or allow horizontal scroll in the window. 2. The ellipses in truncated long values are running into the arrow on the right side of dropdowns. Truncating a character or two earlier would likely fix the issue. 3. In the fields of the form, font colors are not consistent between selected text (#333) and entered text (#555). Let's make them a consistent #333, to match the label color. 4. Related, the ellipses for truncated values should also be #333 (they're currently picking up the color of in-field text). 5. The .Select-arrow-zone icons are not consistently colored, and don't have consistent color states. They're #000 with no hover state before a value is selected. After a value is selected, they change to #999, with a hover state involving an odd border-top color-change. Hovers of #F3812D in Cloudant and #E73D34 for CouchDB would be better for all dropown-select arrows, as well as for the field-clearing Xs, as we have in the Replication document field. # Odd Ways to Break Things. 1. If I create a job and specify a custom replication doc of /// the Replication Activity section fails to to load. If I go into _replicator and delete the doc, it comes back. A couple of hours later, I now can't reproduce this, so it might have been a system hiccup. Or an odd bug that just happens on first /// creation. 2. If I create a job and specify a custom replication doc of """ the replication doc never updates, even though the replication job completed. Thanks again for all the work on this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-fauxton issue #761: New replication
Github user justin-mcdavid-ibm commented on the issue: https://github.com/apache/couchdb-fauxton/pull/761 Hey Garren-- This is coming along great. Comments below. # Activity Page: 1. When I click on the column header, it changes the active-state coloring to orange, but I need to click a second time for it to do the actual sorting. 2. Is it possible to just highlight the sorting triangle, rather than the entire column-header text? 3. Change the Activity tab label to "Replicator DB Activity." 4. Add some padding (try 8px?) between the funnel icon and the Filter Replications entry box 5. Increase the text size of and padding around action icons. Warehousing uses 16px for the icons. _all_dbs uses 19px (+enclosure box). I think 16px font and 8px left/right padding should suffice with our current information density. 6. Encoding for db names containing forward slashes still appears to be broken for source/target displays in Activity. The broken encoding also extends to the linking to the actual databases. 7. The action to edit the Replication document for a job listed in the activity section doesn't appear to be working yet. 8. Same with the action to view the Replication document. 9. The Verify Deletion dialogue does not differentiate between single-doc deletions, and multi-doc deletions (performed through the bulk-selector). It would probably be better if the dialogue triggered through the bulk selector had it's own (pluralized) text and could reference the actual number of documents being deleted. (Instead of "You are deleting a replication document." make it "You are deleting replication documents." 10. When does the Activity page refresh? I'm wondering if we should have polling/refresh controls on the page, similarly to how we have them for Monitoring and Active Tasks. 11. Replication jobs that fail to create a new local database still have active links to the non-existant database. # New Replication Page 1. The Start Replication button is not quite aligned with the field above it. If they could be left-aligned, it would be great. 2. Padding and password-entry-box length on the replication dialogue are broken. Also, what are requirements around this? How regularly should it be asking for password, if you're triggering multiple jobs. Can we have permission extend over a session? 3. Infield-text on the dialogue's password-entry box should be change to "Local-account password." Apologies for the confusion, but please remove the period from the end of the dialogue box's title, as well. 4. I got a "Database target may not start with an underscore." error when attempting to replicate to an existing db named "a_c." So it looks like the validation might be a bit overzealous there. Also, is that message new? And a way to prevent replicating system dbs? I'm a little gunshy to test this, but I see that the "Start Replication" button is active if I select my local _replicator as both source and target. Perhaps we can strip dbs starting with an underscore from the source/target dropdowns, as well? Also, now I'm still getting the underscore error, but none of the information in the form contains underscores, so it looks like something buggier might be afoot. 5. Related to above: Did you add validation to prevent replicating a database to itself? 6. Change the "Database target may not start with an underscore." message to "The names of database sources and targets cannot begin with underscores." (and then you can reuse this message for underscored sources, as well. 7. I can still use local -> new remote replication to replicate into an **existing** remote database. Same goes for replicating something to a "new" database that actually already exists. There should be an error for remote-instance-overwrite attempts, and validation for local-instance-overwrite attempts. 8. To reduce triggering of multiple jobs (and the errors that would arise), after a Replication is triggered, the "Start Replication" button should go into an inactive state until a change has been made to the form. 9. Can we implement the replication-doc conflicting handling described here: https://github.com/apache/couchdb-fauxton/pull/761#issuecomment-249692858 # General 1. The "Replication" breadcrumb for the replication section takes you to New Replication, rather than the Activity page; however, unless Advanced Replication is going to happen sometime soon (which it doesn't look like it will), I think it would be better to follow the same model we have for Warehousing, where there is a Create Replication button on the Activity page, and then the creation page has breadcrumbs and no tabs. 2. The message upon triggering a replicat
[GitHub] couchdb-fauxton issue #761: New replication
Github user justin-mcdavid-ibm commented on the issue: https://github.com/apache/couchdb-fauxton/pull/761 1. Because the current view can only show replication jobs for which a replication document exists, the section should probably have a more specific title like "Replicator DB Activity." It's not replication history-- cancelled continuous jobs will not appear, because we currently delete a continuous job's replication doc to stop it. "Replication Activity" implies active jobs-- But the view shows errored/completed jobs. 2. We should implement the bulk-doc selector to give users an opportunity clean up completed jobs from the view. 3. Add sortable columns so that jobs can be organized. 4. Add a filter box so that jobs can be filtered. 5. Add "State" and "State Time" columns so that jobs can be ordered by recency. Failed jobs should be in our warning red, and completed jobs can be in green. 6. Improve access to local dbs in either of the "Source" or "Target" columns by making the db name clickable. Because "Replicator DB Activity" is the top-level tab in the "Replication" section, it will be easy to navigate back view-- Meaning don't bother trying to implement any sort of complicated back functionality, depending on how a user gets to a db. 7. Create an action icon (wrench) that will take the user to the simple replication form, but pre-populated with details from the replication job. 8. Create an action icon (document) that will take the user to the listed job's replication document. Again, no need to implement complicated back functionality-- The activity view will be easy to return to. It would also be great if hovering over the icon could create a pop-up similar to the one we have for the copy icon table view of documents, and if the custom document ID, while not appearing as a value in the table, was still associated (metadata?) with the row, allowing users to "find" a custom doc through the filter. 9. Create an action icon (trashcan) that will delete a replication job's document (after action verification through a pop-up-- screenshot attached). 10. Implement an action icon (red triangular warning) for replication errors. The icon should only appears when errors exist. I recommend lifting the code we use for warehousing error messages in Cloudant to display the actual errors. (screenshots attached). 11. The type column should be either "Continuous" or "One time," rather than true/false   https://cloud.githubusercontent.com/assets/12969375/18851985/41660ac6-83f3-11e6-9538-c81de2d77022.png;> --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-fauxton issue #761: New replication
Github user justin-mcdavid-ibm commented on the issue: https://github.com/apache/couchdb-fauxton/pull/761 For replication activity I recommend that we implement something along the lines of the following mockup: https://cloud.githubusercontent.com/assets/12969375/18851330/4809c1fe-83f0-11e6-9cf3-b57efa5c4edf.png;> --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-fauxton issue #761: New replication
Github user justin-mcdavid-ibm commented on the issue:
https://github.com/apache/couchdb-fauxton/pull/761
Hey Garren, I've given things a look. Thanks for tag-teaming this with Ben.
Here're my comments:
## General Testing
I was able to replicate into an **existing** remote database using
**target: New Remote Database**. That should fail.
Forward slashes are allowed in db names, but replication fails (on both
remote-local and local-local) when a slash is included. I'm assuming that this
might be an issue for remote sources, as well. Also, replication messages
aren't picking up the full db name. Replicating (locally) from cat/dog to
fish/bird triggers a message that 'Replication from "dog" to "bird" has begun.'
Related FB ticket on the Cloudant side:
https://cloudant.fogbugz.com/f/cases/66917/
Tangentially related (?) ticket: https://cloudant.fogbugz.com/f/cases/45464/
"source": {
"headers": {
"Authorization": "Basic am1tY2Rhdmk6Z2V0aW4xMDFDbG91ZGFudA=="
},
"url": "https://jmmcdavi.cloudant.com/conflicts;
},
"target":
"https://justinmcdavidibm:***@justinmcdavidibm.cloudant.com/conflict/testing;,
"create_target": true,
"continuous": false,
"owner": "jmmcdavi",
"_replication_state": "error",
"_replication_state_time": "2016-08-19T18:12:36+00:00",
"_replication_state_reason": "{db_not_found,<<\"could not open
https://justinmcdavidibm:*@justinmcdavidibm.cloudant.com/conflict/testing/\;>>}",
"_replication_id": "7ebd686ea179ba68db907a776a85b74f"
## Usability
Are we unable to separate the database name from the remote-host info in
the form (making two separate fields), and then recombine them for the actual
request we're sending off? Were I to want to trigger a number of replications
in a row, it would be great if I could just change a database-name field,
rather than modifying the end of the
https://$REMOTE_USERNAME:$REMOTE_PASSWORD@$REMOTE_SERVER/$DATABASE string
before clicking Start Replication again. Fewer keystrokes and less mousing.
The Start Replication button is inactive until an "Existing Local Database"
is selected, but for the other three options (existing remote, new local, new
remote), the button activates before the fields are populated. The button
should be in an inactive state until all required fields are populated.
To reduce triggering of multiple jobs (and the errors that would arise),
after a Replication is triggered, the "Start Replication" button should go into
an inactive state until a change has been made to the form.
Along the same lines as the above, can we provide some validation for the
fields (illegal characters, spaces, databases not following naming rules,
replicating to and from the same database, replicating system databases that
shouldn't be replicated (or should everything be up for grabs?)? Or are we
leaving all of that to the server? The current lagtime and architecture between
sending off replicate jobs that we know would fail leaves me leaning toward
providing our own validation where we can.
Can the "Document Update Conflict" message that appears when you attempt to
specify an existing replication document as the Custom ID be made more
specific, so that users know that it's a conflict between replication
documents, rather than a conflict arising out of the actual replication process?
## Styles
With the different dropdowns/fields, we have two different font families
(Source Sans Pro and Helvetica Neue) and a couple different font sizes
(14px-16px). Let's make all the text (labels/fields) in that form 14px Source
Sans Pro (so as to match the localdb-selection dropdown). And just for
consistent units, let's change the example text for remote sources/targets from
9pt to 12px.
The confirmation dialogue styles appear broken, padding-wise.
The inactive "Start Replication" button has a hover state that should be
removed.
## Strings
Change "e.g." to "Example:" in the case of remote-db example text.
(apologies to @benkeen ), but in the Replication doc field, I've had a
change of heart, and think that just "Custom ID (optional)" will work as
in-field text.
On the confirmation dialogue:
Change the dialogue's title to "Enter Account Password."
Change the explanatory test to "Replication requires authentication on your
local account."
Change the in-field text to "Password"
Change the text on the button to "Start Replicatio
[GitHub] couchdb-fauxton pull request #756: Refactoring the Navigation Panel [wip]
GitHub user justin-mcdavid-ibm opened a pull request: https://github.com/apache/couchdb-fauxton/pull/756 Refactoring the Navigation Panel [wip] You can merge this pull request into a Git repository by running: $ git pull https://github.com/justin-mcdavid-ibm/couchdb-fauxton sidebar-design Alternatively you can review and apply these changes as the patch at: https://github.com/apache/couchdb-fauxton/pull/756.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #756 commit 849061da0dececa86cc786fcb8296b0f6468cc3b Author: Justin McDavid <jmmcd...@us.ibm.com> Date: 2016-07-28T18:25:04Z wip --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-fauxton issue #741: show vertical scrollbar on attachment list when ...
Github user justin-mcdavid-ibm commented on the issue: https://github.com/apache/couchdb-fauxton/pull/741 This great functionality to add, @samk1. Thanks for your time in working on this. While testing, I found that file information is disappearing behind the scroll bar (Chrome 51), though. Design-wise, I there are a few things you might consider: You'd be able to show visual hierarchy better if you have the drop-down panel end some point before the bottom of the page. Parallel scroll bars can be a bit disorienting if you can't easily intuit which panel is supposed to be on top. Dialing-up the padding (from 6px to 12px) for the filter so that the field isn't shorter than drop-down entry fields will help draw attention to the functionality. Making the filter case-insensitive would probably provide a bit more utility. Adding an ability to easily clear a filter, though a clickable "clear" icon on the right side of the filter field would be helpful, but far from required. Again, thanks for the work. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-fauxton pull request #740: improve string-edit-modal
Github user justin-mcdavid-ibm closed the pull request at: https://github.com/apache/couchdb-fauxton/pull/740 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-fauxton pull request #740: improve string-edit-modal
Github user justin-mcdavid-ibm closed the pull request at: https://github.com/apache/couchdb-fauxton/pull/740 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-fauxton pull request #740: improve string-edit-modal
GitHub user justin-mcdavid-ibm opened a pull request: https://github.com/apache/couchdb-fauxton/pull/740 improve string-edit-modal - change text - make cursor a pointer for cancel link - make cancel-button a link You can merge this pull request into a Git repository by running: $ git pull https://github.com/justin-mcdavid-ibm/couchdb-fauxton string-edit-modal-improvements Alternatively you can review and apply these changes as the patch at: https://github.com/apache/couchdb-fauxton/pull/740.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #740 commit 7f649d97942d9aab0ef9d567c112500ec82ec3b4 Author: Justin McDavid <jmmcd...@us.ibm.com> Date: 2016-06-30T18:25:03Z improve string-edit-modal - change text - make cursor a pointer for cancel link - make cancel-button a link --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-fauxton pull request: Style update for metadata page
Github user justin-mcdavid-ibm commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/663#issuecomment-194410189 I feel strongly about consistent alignment (and wish it was used throughout our application, too). :) I'd like to see spacing used to separate different types of values. If you remove the one between purge sequence and data, I'd on board, but I think the other spaces allow you to visually group certain data types. I accidentally covered the horizontal rule, and am completely fine with it coming back. Thanks much, Ben. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-fauxton pull request: Style update for metadata page
Github user justin-mcdavid-ibm commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/663#issuecomment-194095712 How about something like this (and hear me out)? - Detailed field labels will help in understanding the metadata. - The sub-headings don't currently provide much logical organization. - Consistent justification (and units) should help in understanding values at a glance. And there shouldn't be massive orders of difference between actual data sizes and size on disk. - The signature isn't going to mean anything on visual glance, so we can stick it under the copy-to-clipboard action.  --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-fauxton pull request: make dbs deletable from db list
Github user justin-mcdavid-ibm commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/632#issuecomment-176282608 I recommend increasing spacing between the buttons (10px would be better). Change the text for the warning modal to: Delete Database Warning: This action will permanently delete the database. To confirm the deletion of the database and all of the database's documents, you must enter the database's name. Otherwise, looks good. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-fauxton pull request: Table view: add prioritized table vi...
Github user justin-mcdavid-ibm commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/580#issuecomment-169812572 Looks great, Robert. The only thing that we might tweak is some sort of even distribution across the footer for: Showing document X of X. (Keep left-justification) Showing X of X columns. [] Show all Columns Documents per page: X (Keep right-justification) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-fauxton pull request: Table view: add prioritized table vi...
Github user justin-mcdavid-ibm commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/580#issuecomment-159693218 Inverted selection sounds like buggy behavior. The version of this I was playing with had normal bulk-selector behavior. Include docs could be brought out, but I don't understand why we'd do away with the Table All view. I'd like to see the Displaying/Showing messages consolidated in the footer. I've already talked to Robert about changes to the strings: "Showing document 21 - 40. Showing 5 of 13 table columns." And then on the right side, it would need to say âDocuments per page:â rather than âPer Page:" We don't have functionality to support the down arrow by the bulk selector. Currently there's only the ability to delete selected docs. I'd like to see the bulk selector moves to the top left of the table, to better use screen real estate:  But then we run into issue of the clipboard icon and trashcan Icon being more closely aligned, and looking rather similar. The trashcan does trigger a confirmation dialogue box, though. I need to think about this one a bit. The filter icon should probably only show up when a column field has been cleared, so that we can still maintain as much horizontal space for values as we can. Anyway, a lot of these things could be handled in another PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-fauxton pull request: a table view for fauxton
Github user justin-mcdavid-ibm commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/543#issuecomment-149738820 I think #aaa should do for that color, Robert. I played around with it a bit, and it looks ok. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-fauxton pull request: a table view for fauxton
Github user justin-mcdavid-ibm commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/543#issuecomment-149364112 Comments below (on things design-related). **I find "View" as the default text for the different views a little unclear until I click on it. We shied away from just having the three icons in a row? (each with a tooltips, say?)** We had (still have) a lot of problem with horizontal real estate in that header. I believe Robert is planning to move the search box down to right next to the bulk selector, which might give us the room we'd need for that. But, frankly, bringing the "Include Docs" check box out of the Query Options panel might be a better use of that space. **maybe a pale grey line to the right of View, just to make it like the other header btns?** I agree. Left justification helps, but we should give View the same button-ish treatment. **might be nice to change up the icon in the header based on the selected View rather than just having the eye icon all the time.** I agree. Good call, Ben. If there is a default docs display, then that means doing away with the eye icon. **the clickable link locations to take you to the full page doc editor differ depending on whether you're on the all docs or a View. All docs has _id in the first column; Views have the last. Any chance that could be consistent? I'd favour the first column.** I'm not sure I understand the question. I believe that we are having all table values be clickable. When ID isn't displayed, we still need a way to evoke the editor. Docs (collapsed or uncollapsed) always have doc ID at the top, and that ID is clickable. **the greys are a little weak for the bulk selector, in context of Fauxton. Maybe they should be a hair darker?** I agree. Or if we can dial up the weight of the lines. **the down arrow on the bulk selector widget should show a cursor:pointer to indicate clickable. The clickable area should be the full square behind it, too.** I agree. I think we need to also obviate the bulk selector behavior (select all docs in the database vs. select all docs on the page). Feedback showing the number of docs currently selected would help, if it'd be possible to provide this information on the same line as the bulk selector. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
