Github user nickva commented on the pull request:
https://github.com/apache/couchdb-couch/pull/162#issuecomment-222195609
@colinskow that implies some kind of persistence. The selector passed in a
change feed request is active only in the context of the POST request. There
could be
Github user colinskow commented on the pull request:
https://github.com/apache/couchdb-couch/pull/162#issuecomment-222065965
@nickva thank you very much for your response. A "live query" would be a
very useful feature for front-end app developers.
I have [successfully
Github user nickva commented on the pull request:
https://github.com/apache/couchdb-couch/pull/162#issuecomment-221969885
@colinskow there is no easy way to add that I can think of. The query is in
the context of the changes request. As long as there are results filtering back
from
Github user colinskow commented on the pull request:
https://github.com/apache/couchdb-couch/pull/162#issuecomment-218081585
That's a great feature! In order to maintain a live list of docs that match
a query, I will need changes from docs that used to match the query but no
longer
Github user asfgit closed the pull request at:
https://github.com/apache/couchdb-couch/pull/162
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user tonysun83 commented on the pull request:
https://github.com/apache/couchdb-couch/pull/162#issuecomment-210548778
simpler than I thought, +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user davisp commented on the pull request:
https://github.com/apache/couchdb-couch/pull/162#issuecomment-210532037
Good point @rnewson. I'd go with the 400 approach then.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-couch/pull/162#issuecomment-210511943
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user nickva commented on the pull request:
https://github.com/apache/couchdb-couch/pull/162#issuecomment-210510951
@kxepal @davisp @rnewson Updated error message for bad methods to be
explicit, fixed get_selector duplicate code, use mango_error:info to format
selector error
Github user rnewson commented on the pull request:
https://github.com/apache/couchdb-couch/pull/162#issuecomment-210497574
impressive brevity for such a powerful new feature.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-couch/pull/162#issuecomment-210493613
@davisp Ok, thanks. Indeed decoupling these things would be quite
problematic task now without any significant profit.
---
If your project is set up for it, you
Github user nickva commented on a diff in the pull request:
https://github.com/apache/couchdb-couch/pull/162#discussion_r59887227
--- Diff: src/couch_changes.erl ---
@@ -336,6 +343,16 @@ get_doc_ids(_) ->
throw({bad_request, no_doc_ids_provided}).
Github user nickva commented on a diff in the pull request:
https://github.com/apache/couchdb-couch/pull/162#discussion_r59887144
--- Diff: src/couch_changes.erl ---
@@ -336,6 +343,16 @@ get_doc_ids(_) ->
throw({bad_request, no_doc_ids_provided}).
Github user rnewson commented on a diff in the pull request:
https://github.com/apache/couchdb-couch/pull/162#discussion_r59886640
--- Diff: src/couch_changes.erl ---
@@ -336,6 +343,16 @@ get_doc_ids(_) ->
throw({bad_request, no_doc_ids_provided}).
Github user davisp commented on the pull request:
https://github.com/apache/couchdb-couch/pull/162#issuecomment-210489852
Except for the various tweaks to error messaging, +1 to the feature. Sure
did come out a lot simpler than I was expecting.
---
If your project is set up for it,
Github user davisp commented on a diff in the pull request:
https://github.com/apache/couchdb-couch/pull/162#discussion_r59885221
--- Diff: src/couch_changes.erl ---
@@ -336,6 +343,16 @@ get_doc_ids(_) ->
throw({bad_request, no_doc_ids_provided}).
Github user davisp commented on a diff in the pull request:
https://github.com/apache/couchdb-couch/pull/162#discussion_r59884495
--- Diff: src/couch_changes.erl ---
@@ -349,6 +366,18 @@ check_docids(_) ->
throw({bad_request, Msg}).
Github user kxepal commented on a diff in the pull request:
https://github.com/apache/couchdb-couch/pull/162#discussion_r59882439
--- Diff: src/couch_changes.erl ---
@@ -336,6 +343,16 @@ get_doc_ids(_) ->
throw({bad_request, no_doc_ids_provided}).
Github user nickva commented on a diff in the pull request:
https://github.com/apache/couchdb-couch/pull/162#discussion_r59881499
--- Diff: src/couch_changes.erl ---
@@ -349,6 +366,19 @@ check_docids(_) ->
throw({bad_request, Msg}).
Github user nickva commented on a diff in the pull request:
https://github.com/apache/couchdb-couch/pull/162#discussion_r59881398
--- Diff: src/couch_changes.erl ---
@@ -336,6 +343,16 @@ get_doc_ids(_) ->
throw({bad_request, no_doc_ids_provided}).
Github user kxepal commented on a diff in the pull request:
https://github.com/apache/couchdb-couch/pull/162#discussion_r59880805
--- Diff: src/couch_changes.erl ---
@@ -336,6 +343,16 @@ get_doc_ids(_) ->
throw({bad_request, no_doc_ids_provided}).
Github user nickva commented on a diff in the pull request:
https://github.com/apache/couchdb-couch/pull/162#discussion_r59880422
--- Diff: src/couch_changes.erl ---
@@ -336,6 +343,16 @@ get_doc_ids(_) ->
throw({bad_request, no_doc_ids_provided}).
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-couch/pull/162#issuecomment-210476013
Nice feature, but I feel quite strange about creating dependency from mango
for couch app. Since mango is a cluster thing, shouldn't it be on chttpd side?
---
If
Github user kxepal commented on a diff in the pull request:
https://github.com/apache/couchdb-couch/pull/162#discussion_r59878224
--- Diff: src/couch_changes.erl ---
@@ -349,6 +366,19 @@ check_docids(_) ->
throw({bad_request, Msg}).
Github user kxepal commented on a diff in the pull request:
https://github.com/apache/couchdb-couch/pull/162#discussion_r59877824
--- Diff: src/couch_changes.erl ---
@@ -336,6 +343,16 @@ get_doc_ids(_) ->
throw({bad_request, no_doc_ids_provided}).
Github user kxepal commented on a diff in the pull request:
https://github.com/apache/couchdb-couch/pull/162#discussion_r59877477
--- Diff: src/couch_changes.erl ---
@@ -336,6 +343,16 @@ get_doc_ids(_) ->
throw({bad_request, no_doc_ids_provided}).
GitHub user nickva opened a pull request:
https://github.com/apache/couchdb-couch/pull/162
Implement Mango selectors for change feeds
API is modeled after _doc_ids filter for change feeds.
User POSTs to {db}/_changes with `filter=_selector`.
Document body should have a
27 matches
Mail list logo
