Re: [PR] [Feature 3.3] Triple Rest Cors Support [dubbo]

2024-05-22 Thread via GitHub
EarthChen merged PR #14073: URL: https://github.com/apache/dubbo/pull/14073 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [Feature 3.3] Triple Rest Cors Support [dubbo]

2024-05-21 Thread via GitHub
Rawven commented on code in PR #14073: URL: https://github.com/apache/dubbo/pull/14073#discussion_r1609281715 ## dubbo-rpc/dubbo-rpc-api/src/main/java/org/apache/dubbo/rpc/HeaderFilter.java: ## @@ -22,5 +22,5 @@ @SPI(scope = ExtensionScope.FRAMEWORK) public interface

Re: [PR] [Feature 3.3] Triple Rest Cors Support [dubbo]

2024-05-21 Thread via GitHub
sonarcloud[bot] commented on PR #14073: URL: https://github.com/apache/dubbo/pull/14073#issuecomment-2123889813 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [Feature 3.3] Triple Rest Cors Support [dubbo]

2024-05-21 Thread via GitHub
sonarcloud[bot] commented on PR #14073: URL: https://github.com/apache/dubbo/pull/14073#issuecomment-2123882657 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [Feature 3.3] Triple Rest Cors Support [dubbo]

2024-05-21 Thread via GitHub
oxsean commented on code in PR #14073: URL: https://github.com/apache/dubbo/pull/14073#discussion_r1609223477 ## dubbo-rpc/dubbo-rpc-api/src/main/java/org/apache/dubbo/rpc/HeaderFilter.java: ## @@ -22,5 +22,5 @@ @SPI(scope = ExtensionScope.FRAMEWORK) public interface

Re: [PR] [Feature 3.3] Triple Rest Cors Support [dubbo]

2024-05-21 Thread via GitHub
sonarcloud[bot] commented on PR #14073: URL: https://github.com/apache/dubbo/pull/14073#issuecomment-2123791134 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [Feature 3.3] Triple Rest Cors Support [dubbo]

2024-05-21 Thread via GitHub
AlbumenJ commented on code in PR #14073: URL: https://github.com/apache/dubbo/pull/14073#discussion_r1609192897 ## dubbo-rpc/dubbo-rpc-api/src/main/java/org/apache/dubbo/rpc/HeaderFilter.java: ## @@ -22,5 +22,5 @@ @SPI(scope = ExtensionScope.FRAMEWORK) public interface

Re: [PR] [Feature 3.3] Triple Rest Cors Support [dubbo]

2024-05-21 Thread via GitHub
EarthChen commented on code in PR #14073: URL: https://github.com/apache/dubbo/pull/14073#discussion_r1609188260 ## dubbo-rpc/dubbo-rpc-api/src/main/java/org/apache/dubbo/rpc/HeaderFilter.java: ## @@ -22,5 +22,5 @@ @SPI(scope = ExtensionScope.FRAMEWORK) public interface

Re: [PR] [Feature 3.3] Triple Rest Cors Support [dubbo]

2024-05-21 Thread via GitHub
Rawven commented on PR #14073: URL: https://github.com/apache/dubbo/pull/14073#issuecomment-2121991692 @AlbumenJ PTAL I have fix the license,but But it looks like the latest commit of the integration test will make the workflow fail -- This is an automated message from the Apache

Re: [PR] [Feature 3.3] Triple Rest Cors Support [dubbo]

2024-05-21 Thread via GitHub
sonarcloud[bot] commented on PR #14073: URL: https://github.com/apache/dubbo/pull/14073#issuecomment-2121980177 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [Feature 3.3] Triple Rest Cors Support [dubbo]

2024-05-21 Thread via GitHub
sonarcloud[bot] commented on PR #14073: URL: https://github.com/apache/dubbo/pull/14073#issuecomment-2121898467 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [Feature 3.3] Triple Rest Cors Support [dubbo]

2024-05-20 Thread via GitHub
oxsean commented on code in PR #14073: URL: https://github.com/apache/dubbo/pull/14073#discussion_r1607641302 ## dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/rest/cors/CorsHeaderFilter.java: ## @@ -0,0 +1,274 @@ +/* + * Licensed to the Apache

Re: [PR] [Feature 3.3] Triple Rest Cors Support [dubbo]

2024-05-20 Thread via GitHub
sonarcloud[bot] commented on PR #14073: URL: https://github.com/apache/dubbo/pull/14073#issuecomment-2121786016 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [Feature 3.3] Triple Rest Cors Support [dubbo]

2024-05-20 Thread via GitHub
oxsean commented on code in PR #14073: URL: https://github.com/apache/dubbo/pull/14073#discussion_r1607641302 ## dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/rest/cors/CorsHeaderFilter.java: ## @@ -0,0 +1,274 @@ +/* + * Licensed to the Apache

Re: [PR] [Feature 3.3] Triple Rest Cors Support [dubbo]

2024-05-20 Thread via GitHub
Rawven commented on code in PR #14073: URL: https://github.com/apache/dubbo/pull/14073#discussion_r1607632135 ## dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/rest/cors/CorsHeaderFilter.java: ## @@ -0,0 +1,274 @@ +/* + * Licensed to the Apache

Re: [PR] [Feature 3.3] Triple Rest Cors Support [dubbo]

2024-05-20 Thread via GitHub
AlbumenJ commented on code in PR #14073: URL: https://github.com/apache/dubbo/pull/14073#discussion_r1607564322 ## dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/rest/cors/CorsHeaderFilter.java: ## @@ -0,0 +1,274 @@ +/* + * Licensed to the Apache

Re: [PR] [Feature 3.3] Triple Rest Cors Support [dubbo]

2024-05-20 Thread via GitHub
sonarcloud[bot] commented on PR #14073: URL: https://github.com/apache/dubbo/pull/14073#issuecomment-2120180131 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [Feature 3.3] Triple Rest Cors Support [dubbo]

2024-05-20 Thread via GitHub
sonarcloud[bot] commented on PR #14073: URL: https://github.com/apache/dubbo/pull/14073#issuecomment-2119760367 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [Feature 3.3] Triple Rest Cors Support [dubbo]

2024-05-20 Thread via GitHub
oxsean commented on PR #14073: URL: https://github.com/apache/dubbo/pull/14073#issuecomment-2119727985 @AlbumenJ LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [Feature 3.3] Triple Rest Cors Support [dubbo]

2024-05-19 Thread via GitHub
sonarcloud[bot] commented on PR #14073: URL: https://github.com/apache/dubbo/pull/14073#issuecomment-2119677662 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [Feature 3.3] Triple Rest Cors Support [dubbo]

2024-05-19 Thread via GitHub
sonarcloud[bot] commented on PR #14073: URL: https://github.com/apache/dubbo/pull/14073#issuecomment-2119181526 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [Feature 3.3] Triple Rest Cors Support [dubbo]

2024-05-19 Thread via GitHub
sonarcloud[bot] commented on PR #14073: URL: https://github.com/apache/dubbo/pull/14073#issuecomment-2119159158 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [Feature 3.3] Triple Rest Cors Support [dubbo]

2024-05-18 Thread via GitHub
sonarcloud[bot] commented on PR #14073: URL: https://github.com/apache/dubbo/pull/14073#issuecomment-2118849198 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [Feature 3.3] Triple Rest Cors Support [dubbo]

2024-05-17 Thread via GitHub
sonarcloud[bot] commented on PR #14073: URL: https://github.com/apache/dubbo/pull/14073#issuecomment-2117887867 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [Feature 3.3] Triple Rest Cors Support [dubbo]

2024-05-17 Thread via GitHub
sonarcloud[bot] commented on PR #14073: URL: https://github.com/apache/dubbo/pull/14073#issuecomment-2117792016 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [Feature 3.3] Triple Rest Cors Support [dubbo]

2024-05-17 Thread via GitHub
Rawven commented on code in PR #14073: URL: https://github.com/apache/dubbo/pull/14073#discussion_r1605074993 ## dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/rest/cors/CorsUtils.java: ## @@ -0,0 +1,84 @@ +/* + * Licensed to the Apache Software

Re: [PR] [Feature 3.3] Triple Rest Cors Support [dubbo]

2024-05-17 Thread via GitHub
AlbumenJ commented on code in PR #14073: URL: https://github.com/apache/dubbo/pull/14073#discussion_r1604996990 ## dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/rest/cors/CorsUtils.java: ## @@ -0,0 +1,84 @@ +/* + * Licensed to the Apache Software

Re: [PR] [Feature 3.3] Triple Rest Cors Support [dubbo]

2024-04-25 Thread via GitHub
sonarcloud[bot] commented on PR #14073: URL: https://github.com/apache/dubbo/pull/14073#issuecomment-2076624455 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [Feature 3.3] Triple Rest Cors Support [dubbo]

2024-04-24 Thread via GitHub
oxsean commented on code in PR #14073: URL: https://github.com/apache/dubbo/pull/14073#discussion_r1578018213 ## dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/rest/mapping/DefaultRequestMappingRegistry.java: ## @@ -61,8 +61,7 @@ public

Re: [PR] [Feature 3.3] Triple Rest Cors Support [dubbo]

2024-04-24 Thread via GitHub
Rawven commented on PR #14073: URL: https://github.com/apache/dubbo/pull/14073#issuecomment-2074714911 @oxsean I have modified all the parts you mentioned PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [Feature 3.3] Triple Rest Cors Support [dubbo]

2024-04-24 Thread via GitHub
sonarcloud[bot] commented on PR #14073: URL: https://github.com/apache/dubbo/pull/14073#issuecomment-2074698851 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [Feature 3.3] Triple Rest Cors Support [dubbo]

2024-04-24 Thread via GitHub
sonarcloud[bot] commented on PR #14073: URL: https://github.com/apache/dubbo/pull/14073#issuecomment-2074612166 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [Feature 3.3] Triple Rest Cors Support [dubbo]

2024-04-24 Thread via GitHub
sonarcloud[bot] commented on PR #14073: URL: https://github.com/apache/dubbo/pull/14073#issuecomment-2074593267 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [Feature 3.3] Triple Rest Cors Support [dubbo]

2024-04-23 Thread via GitHub
oxsean commented on code in PR #14073: URL: https://github.com/apache/dubbo/pull/14073#discussion_r1576518108 ## dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/rest/RestConstants.java: ## @@ -48,6 +48,24 @@ public final class RestConstants {

Re: [PR] [Feature 3.3] Triple Rest Cors Support [dubbo]

2024-04-23 Thread via GitHub
Rawven commented on code in PR #14073: URL: https://github.com/apache/dubbo/pull/14073#discussion_r1576535280 ## dubbo-plugin/dubbo-rest-spring/src/main/java/org/apache/dubbo/rpc/protocol/tri/rest/support/spring/SpringMvcRequestMappingResolver.java: ## @@ -104,4 +113,31 @@

Re: [PR] [Feature 3.3] Triple Rest Cors Support [dubbo]

2024-04-23 Thread via GitHub
oxsean commented on code in PR #14073: URL: https://github.com/apache/dubbo/pull/14073#discussion_r1576516651 ## dubbo-plugin/dubbo-rest-spring/src/main/java/org/apache/dubbo/rpc/protocol/tri/rest/support/spring/SpringMvcRequestMappingResolver.java: ## @@ -104,4 +113,31 @@

Re: [PR] [Feature 3.3] Triple Rest Cors Support [dubbo]

2024-04-23 Thread via GitHub
oxsean commented on code in PR #14073: URL: https://github.com/apache/dubbo/pull/14073#discussion_r1576514369 ## dubbo-plugin/dubbo-rest-spring/src/main/java/org/apache/dubbo/rpc/protocol/tri/rest/support/spring/SpringMvcRequestMappingResolver.java: ## @@ -104,4 +113,31 @@

Re: [PR] [Feature 3.3] Triple Rest Cors Support [dubbo]

2024-04-23 Thread via GitHub
oxsean commented on code in PR #14073: URL: https://github.com/apache/dubbo/pull/14073#discussion_r1576509805 ## dubbo-plugin/dubbo-rest-spring/src/main/java/org/apache/dubbo/rpc/protocol/tri/rest/support/spring/SpringMvcRequestMappingResolver.java: ## @@ -104,4 +113,31 @@

Re: [PR] [Feature 3.3] Triple Rest Cors Support [dubbo]

2024-04-22 Thread via GitHub
Rawven commented on PR #14073: URL: https://github.com/apache/dubbo/pull/14073#issuecomment-2069489919 @oxsean PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [Feature 3.3] Triple Rest Cors Support [dubbo]

2024-04-18 Thread via GitHub
sonarcloud[bot] commented on PR #14073: URL: https://github.com/apache/dubbo/pull/14073#issuecomment-2065675877 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [Feature 3.3] Triple Rest Cors Support [dubbo]

2024-04-12 Thread via GitHub
sonarcloud[bot] commented on PR #14073: URL: https://github.com/apache/dubbo/pull/14073#issuecomment-2052211416 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [Feature 3.3] Triple Rest Cors Support [dubbo]

2024-04-12 Thread via GitHub
sonarcloud[bot] commented on PR #14073: URL: https://github.com/apache/dubbo/pull/14073#issuecomment-2052005170 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [Feature 3.3] Triple Rest Cors Support [dubbo]

2024-04-12 Thread via GitHub
sonarcloud[bot] commented on PR #14073: URL: https://github.com/apache/dubbo/pull/14073#issuecomment-2051284502 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [Feature 3.3] Triple Rest Cors Support [dubbo]

2024-04-12 Thread via GitHub
sonarcloud[bot] commented on PR #14073: URL: https://github.com/apache/dubbo/pull/14073#issuecomment-2051255148 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate