[GitHub] keith-turner commented on a change in pull request #5: Fixes #3 Check if application is running before starting

2017-08-16 Thread git
] instructions Review comment: Why repeat this info? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about

[GitHub] keith-turner commented on a change in pull request #913: Fluo 912

2017-08-16 Thread git
System.out.println("NOT_FOUND"); +return; + } +} + +if (FluoAdminImpl.oracleExists(config)) { Review comment: what about workers? -------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and us

[GitHub] mikewalch opened a new issue #914: Allow configuration to be passed to 'fluo oracle' & 'fluo worker' commands

2017-08-16 Thread git
fluo-conn.properties`: ``` fluo oracle -p key1=value1,key2=value2 fluo oracle myapp -p fluo.connection.zookepers=localhost/fluo,fluo.connection.zookeeper.secret=mysecret ``` This is an automated message from the Apache

[GitHub] mikewalch closed issue #2: Print yarn app id

2017-08-16 Thread git
mikewalch closed issue #2: Print yarn app id URL: https://github.com/apache/fluo-yarn/issues/2 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above

[GitHub] mikewalch commented on issue #2: Print yarn app id

2017-08-16 Thread git
mikewalch commented on issue #2: Print yarn app id URL: https://github.com/apache/fluo-yarn/issues/2#issuecomment-322837270 Fixed by #1 This is an automated message from the Apache Git Service. To respond to the message

[GitHub] mikewalch opened a new pull request #5: Fixes #3 Check if application is running before starting

2017-08-16 Thread git
mikewalch opened a new pull request #5: Fixes #3 Check if application is running before starting URL: https://github.com/apache/fluo-yarn/pull/5 * Also improved README.md This is an automated message from the Apache Git

[GitHub] mikewalch opened a new pull request #913: Fluo 912

2017-08-16 Thread git
mikewalch opened a new pull request #913: Fluo 912 URL: https://github.com/apache/fluo/pull/913 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above

[GitHub] cjmctague commented on issue #879: CollisionIT test failed on Travis

2017-08-16 Thread git
l:2000 at org.apache.fluo.integration.impl.CollisionIT.testLotsOfCollisions(CollisionIT.java:174) ``` https://travis-ci.org/apache/fluo/jobs/265159869 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use t

[GitHub] mikewalch commented on issue #912: Create 'fluo status' command

2017-08-16 Thread git
the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services

[GitHub] mikewalch closed pull request #910: Fixes #909 Move netty jar to lib/twill

2017-08-16 Thread git
mikewalch closed pull request #910: Fixes #909 Move netty jar to lib/twill URL: https://github.com/apache/fluo/pull/910 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] mikewalch closed issue #909: Move netty jar to lib/twill

2017-08-16 Thread git
mikewalch closed issue #909: Move netty jar to lib/twill URL: https://github.com/apache/fluo/issues/909 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use

[GitHub] mikewalch closed pull request #4: Removed unused dependencies & add travis.yml

2017-08-16 Thread git
mikewalch closed pull request #4: Removed unused dependencies & add travis.yml URL: https://github.com/apache/fluo-yarn/pull/4 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] mikewalch commented on a change in pull request #4: Removed unused dependencies & add travis.yml

2017-08-16 Thread git
ment: Ok, I'll remove This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org

[GitHub] ctubbsii commented on a change in pull request #4: Removed unused dependencies & add travis.yml

2017-08-15 Thread git
any case, I don't think it's necessary to specify one way or the other, because this build probably does not depend on either. This is an automated message from the Apache Git Service. To respond to the message, please log on GitH

[GitHub] ctubbsii closed pull request #911: Preserve license header comment formatting

2017-08-15 Thread git
ctubbsii closed pull request #911: Preserve license header comment formatting URL: https://github.com/apache/fluo/pull/911 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] ctubbsii closed pull request #905: Add Accumulo API checks to checkstyle rules

2017-08-15 Thread git
ctubbsii closed pull request #905: Add Accumulo API checks to checkstyle rules URL: https://github.com/apache/fluo/pull/905 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] mikewalch commented on issue #4: Removed unused dependencies & add travis.yml

2017-08-15 Thread git
fore this work is done. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please con

[GitHub] cjmctague commented on issue #4: Removed unused dependencies & add travis.yml

2017-08-15 Thread git
ache This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache

[GitHub] cjmctague commented on issue #4: Removed unused dependencies & add travis.yml

2017-08-15 Thread git
ache This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache

[GitHub] mikewalch opened a new issue #912: Create 'fluo status' command

2017-08-15 Thread git
hers. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at

[GitHub] mikewalch opened a new pull request #4: Removed unused dependencies & add travis.yml

2017-08-15 Thread git
mikewalch opened a new pull request #4: Removed unused dependencies & add travis.yml URL: https://github.com/apache/fluo-yarn/pull/4 This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] ctubbsii opened a new pull request #911: Preserve license header comment formatting

2017-08-15 Thread git
they are supposed to, for easier readability. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service

[GitHub] mikewalch closed pull request #1: Initial implementation of Apache Fluo YARN launcher

2017-08-15 Thread git
mikewalch closed pull request #1: Initial implementation of Apache Fluo YARN launcher URL: https://github.com/apache/fluo-yarn/pull/1 This is an automated message from the Apache Git Service. To respond to the message

[GitHub] mikewalch commented on a change in pull request #1: Initial implementation of Apache Fluo YARN launcher

2017-08-15 Thread git
Review comment: Added This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact

[GitHub] mikewalch commented on a change in pull request #1: Initial implementation of Apache Fluo YARN launcher

2017-08-15 Thread git
nv.sh" ]; then fi source "$conf/fluo-yarn-env.sh" export CLASSPATH=$LAUNCHER_CLASSPATH +export HADOOP_HOME=$HADOOP_PREFIX Review comment: It's not needed so I removed it This is an automated message from th

[GitHub] mikewalch opened a new pull request #910: Fixes #909 Move netty jar to lib/twill

2017-08-15 Thread git
mikewalch opened a new pull request #910: Fixes #909 Move netty jar to lib/twill URL: https://github.com/apache/fluo/pull/910 * Also put log4j & logback jars together This is an automated message from the Apache Git Ser

[GitHub] keith-turner commented on a change in pull request #1: Initial implementation of Apache Fluo YARN launcher

2017-08-15 Thread git
nv.sh" ]; then fi source "$conf/fluo-yarn-env.sh" export CLASSPATH=$LAUNCHER_CLASSPATH +export HADOOP_HOME=$HADOOP_PREFIX Review comment: why set this? This is an automated message from the Apache Git

[GitHub] keith-turner commented on a change in pull request #1: Initial implementation of Apache Fluo YARN launcher

2017-08-15 Thread git
Review comment: could add a comment This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service

[GitHub] mikewalch opened a new issue #3: Check if application is running before starting in YARN

2017-08-14 Thread git
This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards

[GitHub] keith-turner closed pull request #899: fixes #893 added ability to secure zookeeper

2017-08-14 Thread git
keith-turner closed pull request #899: fixes #893 added ability to secure zookeeper URL: https://github.com/apache/fluo/pull/899 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] keith-turner closed issue #893: Support locking down properties in zookeeper

2017-08-14 Thread git
keith-turner closed issue #893: Support locking down properties in zookeeper URL: https://github.com/apache/fluo/issues/893 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] keith-turner closed pull request #902: fixes #894 merge SimpleConfiguration Objects

2017-08-14 Thread git
keith-turner closed pull request #902: fixes #894 merge SimpleConfiguration Objects URL: https://github.com/apache/fluo/pull/902 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] keith-turner commented on issue #900: Document properties in FluoConfiguration javadoc

2017-08-14 Thread git
. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services

[GitHub] kpm1985 commented on issue #900: Document properties in FluoConfiguration javadoc

2017-08-13 Thread git
This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git

[GitHub] mikewalch commented on a change in pull request #1: Initial implementation of Apache Fluo YARN launcher

2017-08-11 Thread git
twill:twill-zookeeper:jar:0.11.0 Review comment: fixed. `fluo-yarn-env.sh` now adds jar to classpath given ZOOKEEPER_HOME This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific

[GitHub] keith-turner opened a new issue #80: Improve Fluo's front page and short description.

2017-08-11 Thread git
This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache

[GitHub] keith-turner opened a new issue #908: Discuss get jars behavior

2017-08-11 Thread git
. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us

[GitHub] mikewalch closed pull request #907: Fixes #906 - Create 'fluo get-jars' command

2017-08-11 Thread git
mikewalch closed pull request #907: Fixes #906 - Create 'fluo get-jars' command URL: https://github.com/apache/fluo/pull/907 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] mikewalch closed issue #906: Create 'fluo get-jars' command

2017-08-11 Thread git
mikewalch closed issue #906: Create 'fluo get-jars' command URL: https://github.com/apache/fluo/issues/906 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use

[GitHub] ctubbsii closed pull request #1: Provide initial README

2017-08-10 Thread git
ctubbsii closed pull request #1: Provide initial README URL: https://github.com/apache/fluo-bytes/pull/1 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use

[GitHub] ctubbsii commented on a change in pull request #1: Provide initial README

2017-08-10 Thread git
he developers"... but that's basically *always the case*. -------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastr

[GitHub] keith-turner commented on a change in pull request #1: Initial implementation of Apache Fluo YARN launcher

2017-08-10 Thread git
be specified but doesn't need to be named '/fluo-yarn'. Review comment: Is the chroot dir limited to depth 1? If so that would be useful to mention. This is an automated message from the Apache Git Service. To respond

[GitHub] keith-turner commented on a change in pull request #1: Provide initial README

2017-08-10 Thread git
the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services

[GitHub] keith-turner commented on a change in pull request #1: Provide initial README

2017-08-10 Thread git
val is not mentioned, so the new parameter will mesh well with the current javadoc. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comm

[GitHub] keith-turner commented on a change in pull request #1: Provide initial README

2017-08-10 Thread git
: `No runtime dependencies to use the library` this seems a bit off. To use this library a runtime dep on this library will be needed. This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] keith-turner commented on a change in pull request #1: Provide initial README

2017-08-10 Thread git
wording was `bytes library`. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact

[GitHub] ctubbsii commented on a change in pull request #1: Provide initial README

2017-08-09 Thread git
--- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services

[GitHub] ctubbsii commented on a change in pull request #1: Provide initial README

2017-08-09 Thread git
on this subject. :) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact

[GitHub] ctubbsii commented on a change in pull request #1: Provide initial README

2017-08-09 Thread git
in Java, by providing convenient objects to +represent a string of bytes and associated utility classes for situations when Review comment: Fixed. This is an automated message from the Apache Git Service. To respond to the message

[GitHub] ctubbsii commented on a change in pull request #1: Provide initial README

2017-08-09 Thread git
correctly when I saw this comment in my email, but I pushed a change which basically applies the same fix, based on your feedback above the blockquote section. This is an automated message from the Apache Git Service. To respond

[GitHub] mikewalch opened a new pull request #907: Fixes #906 - Create 'fluo get-jars' command

2017-08-09 Thread git
mikewalch opened a new pull request #907: Fixes #906 - Create 'fluo get-jars' command URL: https://github.com/apache/fluo/pull/907 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] mikewalch opened a new issue #906: Create 'fluo get-jars' command

2017-08-09 Thread git
the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services

[GitHub] keith-turner commented on a change in pull request #902: fixes #894 merge SimpleConfiguration Objects

2017-08-09 Thread git
Else(sc1).orElse(sc2); Review comment: need to keep the return val like ```java sc4 = sc3.orElse(sc1).orElse(sc2); sc3.set(...) //ensure sc4 did not change. ``` This is an automated message from the Apach

[GitHub] mikewalch closed issue #897: Add high level application lifecycle overview to docs

2017-08-09 Thread git
mikewalch closed issue #897: Add high level application lifecycle overview to docs URL: https://github.com/apache/fluo/issues/897 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] mikewalch closed pull request #904: Fixes #897 added context to application docs and moved some docs from?

2017-08-09 Thread git
mikewalch closed pull request #904: Fixes #897 added context to application docs and moved some docs from? URL: https://github.com/apache/fluo/pull/904 This is an automated message from the Apache Git Service. To respond

[GitHub] keith-turner commented on a change in pull request #1: Provide initial README

2017-08-09 Thread git
This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services

[GitHub] keith-turner commented on a change in pull request #1: Provide initial README

2017-08-09 Thread git
in other projects' APIs. ``` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] keith-turner commented on a change in pull request #1: Provide initial README

2017-08-09 Thread git
the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services

[GitHub] mikewalch commented on a change in pull request #904: Fixes #897 added context to application docs and moved some docs from?

2017-08-09 Thread git
the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services

[GitHub] mikewalch commented on a change in pull request #904: Fixes #897 added context to application docs and moved some docs from?

2017-08-09 Thread git
from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services

[GitHub] mikewalch commented on a change in pull request #904: Fixes #897 added context to application docs and moved some docs from?

2017-08-09 Thread git
. This text could be incorporated into architecture.md to improve it. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment

[GitHub] keith-turner commented on a change in pull request #902: fixes #894 merge SimpleConfiguration Objects

2017-08-09 Thread git
lowing : ```java sc1 = ... sc2 = ... sc3 = sc1.orElse(sc2) //set something on sc1 and sc2 // verify that sc3 did not change ``` This is an automated message from the Apache Git Service. To respond to the m

[GitHub] ctubbsii commented on a change in pull request #905: Add Accumulo API checks to checkstyle rules

2017-08-09 Thread git
`[.]`, because I think that construction is more clear (escapes are hard to reason about). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go

[GitHub] keith-turner commented on a change in pull request #904: Fixes #897 added context to application docs and moved some docs from?

2017-08-09 Thread git
. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org

[GitHub] keith-turner commented on a change in pull request #904: Fixes #897 added context to application docs and moved some docs from?

2017-08-09 Thread git
of? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards

[GitHub] mikewalch commented on a change in pull request #899: fixes #893 added ability to secure zookeeper

2017-08-09 Thread git
ment: What happens if a user a passes in an incorrect Zookeeper secret? It would be good to make sure there is a good exception or error message for this case. A unit test could also be written to verify this behavior. -------- This is an

[GitHub] mikewalch commented on a change in pull request #902: fixes #894 merge SimpleConfiguration Objects

2017-08-09 Thread git
s in on sc matches the other. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, plea

[GitHub] ctubbsii opened a new pull request #905: Add Accumulo API checks to checkstyle rules

2017-08-08 Thread git
API checks in Fluo projects. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] mikewalch opened a new pull request #78: Remove incubator references on website

2017-08-08 Thread git
mikewalch opened a new pull request #78: Remove incubator references on website URL: https://github.com/apache/fluo-website/pull/78 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] mikewalch closed issue #843: Rename FluoConfiguration properties

2017-08-08 Thread git
mikewalch closed issue #843: Rename FluoConfiguration properties URL: https://github.com/apache/fluo/issues/843 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub

[GitHub] mikewalch closed issue #851: Create FluoList command

2017-08-08 Thread git
mikewalch closed issue #851: Create FluoList command URL: https://github.com/apache/fluo/issues/851 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL

[GitHub] mikewalch closed issue #848: Create FluoOracle command

2017-08-08 Thread git
mikewalch closed issue #848: Create FluoOracle command URL: https://github.com/apache/fluo/issues/848 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL

[GitHub] mikewalch commented on issue #845: Create FluoInit command

2017-08-08 Thread git
mikewalch commented on issue #845: Create FluoInit command URL: https://github.com/apache/fluo/issues/845#issuecomment-321079261 Closed by #883 This is an automated message from the Apache Git Service. To respond

[GitHub] mikewalch commented on issue #851: Create FluoList command

2017-08-08 Thread git
mikewalch commented on issue #851: Create FluoList command URL: https://github.com/apache/fluo/issues/851#issuecomment-321079167 Closed by #883 This is an automated message from the Apache Git Service. To respond

[GitHub] ctubbsii commented on a change in pull request #902: fixes #894 merge SimpleConfiguration Objects

2017-08-08 Thread git
onjoin' is 'with' (mutual relationship) instead of 'to' (directional relationship), as in 'conjoinWith' instead of 'conjoinTo'. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use t

[GitHub] keith-turner commented on a change in pull request #77: update links in pages/ to https

2017-08-08 Thread git
://www.tetraconcepts.com/ Review comment: @cjnolet do you have any opinion on this? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific

[GitHub] cjmctague commented on a change in pull request #902: fixes #894 merge SimpleConfiguration Objects

2017-08-08 Thread git
tValue()); Review comment: `conjoinTo(SimpleConfiguration)` Means "join; combine" This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go

[GitHub] keith-turner commented on a change in pull request #902: fixes #894 merge SimpleConfiguration Objects

2017-08-08 Thread git
hang off of something. What where you thinking it would hang off of? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specifi

[GitHub] keith-turner commented on issue #900: Document properties in FluoConfiguration javadoc

2017-08-08 Thread git
all yours. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at:

[GitHub] mikewalch commented on issue #900: Document properties in FluoConfiguration javadoc

2017-08-08 Thread git
mikewalch commented on issue #900: Document properties in FluoConfiguration javadoc URL: https://github.com/apache/fluo/issues/900#issuecomment-320965130 Thanks @kpm1985! This is an automated message from the Apache Git

[GitHub] mikewalch commented on a change in pull request #904: Fixes #897 added context to application docs and moved some docs from?

2017-08-08 Thread git
` instead of `instance` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact

[GitHub] mikewalch commented on a change in pull request #904: Fixes #897 added context to application docs and moved some docs from?

2017-08-08 Thread git
to know when to trigger observers. 6. Start your Fluo instance so that your Fluo workers load the new observer. Review comment: Could be `Start your Fluo application so that` This is an automated message from the Apache Git Service

[GitHub] mikewalch commented on a change in pull request #904: Fixes #897 added context to application docs and moved some docs from?

2017-08-08 Thread git
` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services

[GitHub] mikewalch commented on a change in pull request #904: Fixes #897 added context to application docs and moved some docs from?

2017-08-08 Thread git
below):` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure

[GitHub] keith-turner commented on a change in pull request #1: Initial implementation of Apache Fluo YARN launcher

2017-08-07 Thread git
the version of Fluo YARN launcher" + echo " " + exit 1 +} + +function build_bundled_jar { + app_dir=$lib/apps/$app + mkdir -p "$app_dir/lib" + + java org.apache.fluo.command.FluoGetJars "$FLUO_CONN_PROPS" "$app" "$app_dir/lib" Review comment: What hap

[GitHub] keith-turner commented on issue #891: Migrate to checkstyle 8.1 rules

2017-08-07 Thread git
ice. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache

[GitHub] keith-turner commented on a change in pull request #891: Migrate to checkstyle 8.1 rules

2017-08-07 Thread git
ion. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services

[GitHub] keith-turner commented on a change in pull request #891: Migrate to checkstyle 8.1 rules

2017-08-07 Thread git
ted message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services

[GitHub] ctubbsii commented on issue #891: Migrate to checkstyle 8.1 rules

2017-08-07 Thread git
the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services

[GitHub] ctubbsii commented on a change in pull request #891: Migrate to checkstyle 8.1 rules

2017-08-07 Thread git
@@ + Review comment: I thought that's basically what my log message said, but I can reword it if it's not clear. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL

[GitHub] keith-turner commented on a change in pull request #891: Migrate to checkstyle 8.1 rules

2017-08-07 Thread git
ore informative. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastruct

[GitHub] ctubbsii commented on a change in pull request #891: Migrate to checkstyle 8.1 rules

2017-08-07 Thread git
because the rules won't work. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] keith-turner commented on a change in pull request #891: Migrate to checkstyle 8.1 rules

2017-08-07 Thread git
@@ + Review comment: > It had to be moved in order to work with the newer version of Checkstyle. Where did the version of Checkstyle change? This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] ctubbsii commented on a change in pull request #902: fixes #894 merge SimpleConfiguration Objects

2017-08-07 Thread git
nfiguration.html This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services

[GitHub] ctubbsii commented on a change in pull request #902: fixes #894 merge SimpleConfiguration Objects

2017-08-07 Thread git
nfiguration.html This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services

[GitHub] ctubbsii commented on a change in pull request #891: Migrate to checkstyle 8.1 rules

2017-08-07 Thread git
from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services

[GitHub] keith-turner commented on a change in pull request #891: Migrate to checkstyle 8.1 rules

2017-08-07 Thread git
@@ + Review comment: Can you provide a bit of context for this? I don't understand these changes. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go

[GitHub] keith-turner commented on a change in pull request #903: Fluo 897

2017-08-07 Thread git
This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache

[GitHub] keith-turner commented on issue #903: Fluo 897

2017-08-07 Thread git
Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services

[GitHub] cjmctague commented on a change in pull request #903: Fluo 897

2017-08-07 Thread git
This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git

  1   2   3   4   5   >