Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
/FluoConfiguration.java
##
@@ -47,59 +48,140 @@
// Client properties
private static final String CLIENT_PREFIX = FLUO_PREFIX + ".client";
+ @Deprecated
Review comment:
Fixed
This is an automated message from the
ETRY_TIMEOUT_MS_DEFAULT = -1;
- // Administration
+ // Connection properties
+ public static final String CONNECTION_PREFIX = FLUO_PREFIX + ".connection";
Review comment:
It has to be public due to reference in `FluoAdminImpl` so I added since tag
is prop somewhere. Not sure if it
should be here, maybe in the fluo-app.props file?
--------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
and `fluo.hdfs.root`.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
ystemClassLoader();
Review comment:
It might be better to get the classloader from the current class.
----
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
not documented here.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact I
y test for diff combos of these configs? Combos of accumulo
jars, init dir, observers jars, etc
----
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to
x, configurable via an impl
property.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
n about containers of Fluo
application"
- echo " scan Prints snapshot of data in Fluo application"
- echo " classpath Prints the classpath setup in fluo-env.sh"
- echo " wait Waits until all notifications are processed"
- echo " vers
0 replaced by ...`
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
myself wondering, why isn't this documentation in the app
docs?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries
in a per app dfs dir.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
));
- }
+ config = FluoAdminImpl.mergeZookeeperConfig(config);
Review comment:
could curator be passed here?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use
OP,
CLIENT_ACCUMULO_USER_PROP);
Review comment:
It seems like this prop is no longer required for a client. Maybe only
check for old accumulo props if `CLIENT_APPLICATION_NAME_PROP ` is present?
--------
This is an automated messag
LIENT_RETRY_TIMEOUT_MS_DEFAULT = -1;
- // Administration
+ // Connection properties
+ public static final String CONNECTION_PREFIX = FLUO_PREFIX + ".connection";
Review comment:
Can this be private? If its public it should have a since tag.
getObserverInitDir() {
Review comment:
Would it be better to use `Url` instead of `Dir` here? Just thinking about
consistency with other method names.
This is an automated message from the Apache Git Service.
To respond
factor code to avoid creating
multiple connections to ZK.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For querie
static final String HDFS_PREFIX = FLUO_PREFIX + ".hdfs";
+ public static final String HDFS_ROOT_PROP = HDFS_PREFIX + ".root";
Review comment:
since tag
--------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
$FLUO_HOME/apps/app/conf/fluo.properties` file. This
is kinda unfortunate because it means we now have to connect to zookeeper
before running the user code.
This is an automated message from the Apache Git Service.
To respond to the messa
coverage? If not I can try that.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
amp; !key.equals(FluoConfiguration.OBSERVER_PROVIDER)
+ && !key.equals(FluoConfiguration.OBSERVER_INIT_DIR_PROP)
Review comment:
Tests were broken without the exclusions
This is an automated message from the Apache
message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
be changed to limit the number of connections to Zookeeper.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries
on about containers of Fluo
application"
- echo " scan Prints snapshot of data in Fluo application"
- echo " classpath Prints the classpath setup in fluo-env.sh"
- echo " wait Waits until all notifications are processed"
- echo " version Prints the version of Fluo"
- echo " exec{}";
+ echo " init {} Initializes Fluo application using
. Run with -h to see additional args."
Review comment:
Fixed
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
ckArgument(connConfig.hasRequiredConnectionProps(),
+"missing required connection properties");
+config = FluoAdminImpl.mergeZookeeperConfig(connConfig);
Review comment:
Created #896
This is an automated message from th
FLUO_LOG_ID="${cmd}_$(hostname)_$(date +%s)"
+
+JAVA_OPTS=("-Dlog4j.configuration=file:${FLUO_LOG4J_CONFIG}"
Review comment:
Fixed.. changed `JAVA_OPTS` to `SERVICE_OPTS`
----
This is an automated message from the Apach
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards
}
+ @Deprecated
public String getAccumuloClasspath() {
return getString(ADMIN_ACCUMULO_CLASSPATH_PROP,
ADMIN_ACCUMULO_CLASSPATH_DEFAULT);
}
+ /**
+ * @since 1.2.0
Review comment:
Fixed
--------
This is an automated
mLocalFile(new Path(jarPath), new Path(hdfsDestDir));
+ } catch (IOException e) {
+logger.error("Failed to copy file {} to HDFS directory {}", jarPath,
hdfsDestDir);
Review comment:
Fixed
--------
This is an automated me
the
application specific docs in the install docs to the application docs.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment
:
I added check to `FluoAdminImpl.initialized()`
----
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please c
rk but can be edited.
+#
Review comment:
Should all of the logging stuff move to this new section?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use
ment:
With #893 I think storing the accumulo credentials in ZK is a good way to go
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to
.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
--------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
getObserverInitDir() {
Review comment:
The property is set to a directory so I think `Dir` makes more sense.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL
ew comment:
Fixed
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With
stored away in HDFS during
initialization
+#fluo.observer.init.dir=/path/to/observer/jars/
Review comment:
Fixed
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub a
stored away in HDFS during
initialization
Review comment:
Fixed
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
:
Fixed
----
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
mikewalch opened a new pull request #4: Removed unused dependencies & add
travis.yml
URL: https://github.com/apache/fluo-yarn/pull/4
This is an automated message from the Apache Git Service.
To respond to the mes
ache
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache
ache
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache
fore this work is done.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please con
ctubbsii closed pull request #905: Add Accumulo API checks to checkstyle rules
URL: https://github.com/apache/fluo/pull/905
This is an automated message from the Apache Git Service.
To respond to the message, please log
hers.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at
they
are supposed to, for easier readability.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service
any case, I don't think it's
necessary to specify one way or the other, because this build probably does not
depend on either.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitH
ctubbsii closed pull request #911: Preserve license header comment formatting
URL: https://github.com/apache/fluo/pull/911
This is an automated message from the Apache Git Service.
To respond to the message, please log
mikewalch opened a new pull request #910: Fixes #909 Move netty jar to lib/twill
URL: https://github.com/apache/fluo/pull/910
* Also put log4j & logback jars together
This is an automated message from the Apache Git Ser
nv.sh" ]; then
fi
source "$conf/fluo-yarn-env.sh"
export CLASSPATH=$LAUNCHER_CLASSPATH
+export HADOOP_HOME=$HADOOP_PREFIX
Review comment:
It's not needed so I removed it
This is an automated message from th
Review comment:
Added
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact
mikewalch closed pull request #1: Initial implementation of Apache Fluo YARN
launcher
URL: https://github.com/apache/fluo-yarn/pull/1
This is an automated message from the Apache Git Service.
To respond to the message
ment:
Ok, I'll remove
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
mikewalch closed pull request #4: Removed unused dependencies & add travis.yml
URL: https://github.com/apache/fluo-yarn/pull/4
This is an automated message from the Apache Git Service.
To respond to the message, please
mikewalch closed pull request #910: Fixes #909 Move netty jar to lib/twill
URL: https://github.com/apache/fluo/pull/910
This is an automated message from the Apache Git Service.
To respond to the message, please log
mikewalch closed issue #909: Move netty jar to lib/twill
URL: https://github.com/apache/fluo/issues/909
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use
the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git
twill:twill-zookeeper:jar:0.11.0
Review comment:
fixed. `fluo-yarn-env.sh` now adds jar to classpath given ZOOKEEPER_HOME
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards
nv.sh" ]; then
fi
source "$conf/fluo-yarn-env.sh"
export CLASSPATH=$LAUNCHER_CLASSPATH
+export HADOOP_HOME=$HADOOP_PREFIX
Review comment:
why set this?
This is an automated message from the Apache Git
Review comment:
could add a comment
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service
val is not mentioned, so the new parameter will mesh well with the
current javadoc.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comm
:
`No runtime dependencies to use the library` this seems a bit off. To use
this library a runtime dep on this library will be needed.
This is an automated message from the Apache Git Service.
To respond to the message, please
.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
of?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards
`[.]`, because I think that construction is
more clear (escapes are hard to reason about).
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go
lowing :
```java
sc1 = ...
sc2 = ...
sc3 = sc1.orElse(sc2)
//set something on sc1 and sc2
// verify that sc3 did not change
```
This is an automated message from the Apache Git Service.
To respond to the m
from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
. This text could be incorporated into
architecture.md to improve it.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment
---
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
correctly when
I saw this comment in my email, but I pushed a change which basically applies
the same fix, based on your feedback above the blockquote section.
This is an automated message from the Apache Git Service.
To respond
in Java, by providing convenient objects to
+represent a string of bytes and associated utility classes for situations when
Review comment:
Fixed.
This is an automated message from the Apache Git Service.
To respond to the message
on this subject. :)
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact
be specified but doesn't need to be named
'/fluo-yarn'.
Review comment:
Is the chroot dir limited to depth 1? If so that would be useful to mention.
This is an automated message from the Apache Git Service.
To respond
ctubbsii closed pull request #1: Provide initial README
URL: https://github.com/apache/fluo-bytes/pull/1
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use
the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
mikewalch closed pull request #907: Fixes #906 - Create 'fluo get-jars' command
URL: https://github.com/apache/fluo/pull/907
This is an automated message from the Apache Git Service.
To respond to the message, please log
mikewalch closed issue #906: Create 'fluo get-jars' command
URL: https://github.com/apache/fluo/issues/906
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache
.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us
keith-turner closed pull request #899: fixes #893 added ability to secure
zookeeper
URL: https://github.com/apache/fluo/pull/899
This is an automated message from the Apache Git Service.
To respond to the message, please
keith-turner closed issue #893: Support locking down properties in zookeeper
URL: https://github.com/apache/fluo/issues/893
This is an automated message from the Apache Git Service.
To respond to the message, please log
.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
keith-turner closed pull request #902: fixes #894 merge SimpleConfiguration
Objects
URL: https://github.com/apache/fluo/pull/902
This is an automated message from the Apache Git Service.
To respond to the message, please
fluo-conn.properties`:
```
fluo oracle -p key1=value1,key2=value2
fluo oracle myapp -p
fluo.connection.zookepers=localhost/fluo,fluo.connection.zookeeper.secret=mysecret
```
This is an automated message from the Apache
he developers"... but that's basically *always the case*.
--------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastr
wording was
`bytes library`.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact
apache.org/
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
on it. Hoping to have a working
plugin by the end of the day.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
keith-turner opened a new pull request #71: re apache/fluo#881 improved
documentation about issues
URL: https://github.com/apache/incubator-fluo-website/pull/71
This is an automated message from the Apache Git Service
message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
keith-turner closed pull request #71: re apache/fluo#881 improved documentation
about issues
URL: https://github.com/apache/incubator-fluo-website/pull/71
This is an automated message from the Apache Git Service
expected:<c[??]e> but was:<c[?? ]e>
at
org.apache.fluo.api.data.BytesTest.testCopyToWithUnicode(BytesTest.java:343)
```
Broke another test with the fix in 3302fd6
This is an automated message fro
1 - 100 of 420 matches
Mail list logo
