[GitHub] mikewalch commented on a change in pull request #67: fixes #64 updated Tour for new Observer API

2017-06-28 Thread git
rows to multiple mysql tables. To do this it creates an observers per a export Review comment: Should be `To do this, it creates an observer per` This is an automated message from the Apache Git Service. To respond

[GitHub] cjmctague opened a new issue #69: Look into better site SEO

2017-07-05 Thread git
This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org

[GitHub] mikewalch closed pull request #877: re #585 print debug info when CollisionIT fails

2017-06-27 Thread git
mikewalch closed pull request #877: re #585 print debug info when CollisionIT fails URL: https://github.com/apache/incubator-fluo/pull/877 This is an automated message from the Apache Git Service. To respond to the message

[GitHub] keith-turner opened a new pull request #67: fixes #64 updated Tour for new Observer API

2017-06-27 Thread git
keith-turner opened a new pull request #67: fixes #64 updated Tour for new Observer API URL: https://github.com/apache/incubator-fluo-website/pull/67 This is an automated message from the Apache Git Service. To respond

[GitHub] keith-turner closed issue #878: Logging test failed on Travis

2017-06-28 Thread git
keith-turner closed issue #878: Logging test failed on Travis URL: https://github.com/apache/incubator-fluo/issues/878 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] keith-turner closed pull request #880: fixes #878 made LogIT handle delayed tx close()

2017-06-28 Thread git
keith-turner closed pull request #880: fixes #878 made LogIT handle delayed tx close() URL: https://github.com/apache/incubator-fluo/pull/880 This is an automated message from the Apache Git Service. To respond

[GitHub] keith-turner commented on a change in pull request #62: Fluo Recipes 1.1.0 rel notes

2017-06-28 Thread git
changes]: https://github.com/apache/incubator-fluo-recipes/milestone/1?closed=1 +[obsAPI]: /release/fluo-1.1.0-incubating/#new-api-for-configuring-observers +[ObserverProvider]: {{ site.fluo_api_static }}/1.1.0-incubating/org/apache/fluo/api/observer/ObserverProvider.html +[CombineQueue]: {{

[GitHub] keith-turner commented on a change in pull request #62: Fluo Recipes 1.1.0 rel notes

2017-06-28 Thread git
This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org

[GitHub] keith-turner opened a new pull request #899: fixes #893 added ability to secure zookeeper

2017-08-04 Thread git
keith-turner opened a new pull request #899: fixes #893 added ability to secure zookeeper URL: https://github.com/apache/fluo/pull/899 This is an automated message from the Apache Git Service. To respond to the message

[GitHub] keith-turner commented on issue #900: Document properties in FluoConfiguration javadoc

2017-08-04 Thread git
This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services

[GitHub] keith-turner commented on issue #898: Determine if FluoExec should read config from Zookeeper

2017-08-04 Thread git
. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org

[GitHub] keith-turner opened a new issue #900: Document properties in FluoConfiguration javadoc

2017-08-04 Thread git
ing secret) { setProperty(CONNECTION_ZOOKEEPER_SECRET, verifyNotNull(CONNECTION_ZOOKEEPER_SECRET, secret)); } ``` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and u

[GitHub] keith-turner opened a new pull request #76: remove incubator from github links

2017-08-04 Thread git
URLs. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure

[GitHub] keith-turner commented on issue #1: Initial implementation of Apache Fluo YARN launcher

2017-08-04 Thread git
from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services

[GitHub] keith-turner commented on issue #894: Support merging multiple SimpleConfiguration objects

2017-07-28 Thread git
); ``` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services

[GitHub] ctubbsii opened a new pull request #905: Add Accumulo API checks to checkstyle rules

2017-08-08 Thread git
API checks in Fluo projects. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] mikewalch commented on a change in pull request #883: Fixes #842 Support multiple ways for running Fluo applications

2017-08-01 Thread git
e, we need to update these classes to grab all configuration from Zookeeper. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific com

[GitHub] mikewalch commented on a change in pull request #883: Fixes #842 Support multiple ways for running Fluo applications

2017-08-01 Thread git
il.ByteUtil; +import org.apache.fluo.core.util.Hex; +import org.apache.fluo.core.util.SpanUtil; +import org.apache.log4j.Level; +import org.apache.log4j.Logger; + +public class FluoScan { Review comment: fixed This is an automated message from th

[GitHub] mikewalch commented on a change in pull request #883: Fixes #842 Support multiple ways for running Fluo applications

2017-08-01 Thread git
uot;$lib/*" + if [ -f "$conf/connection.properties" ]; then Review comment: fixed in d464bd97629a13 ---- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL abo

[GitHub] mikewalch commented on a change in pull request #883: Fixes #842 Support multiple ways for running Fluo applications

2017-08-01 Thread git
This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services

[GitHub] mikewalch commented on a change in pull request #883: Fixes #842 Support multiple ways for running Fluo applications

2017-08-01 Thread git
: fixed This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us

[GitHub] mikewalch commented on a change in pull request #883: Fixes #842 Support multiple ways for running Fluo applications

2017-08-01 Thread git
This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services

[GitHub] mikewalch commented on a change in pull request #883: Fixes #842 Support multiple ways for running Fluo applications

2017-08-01 Thread git
containers and their logs will be spread across the cluster. +The oracle & worker logs can be found in the `logs/` directory of your Fluo installation. Review comment: fixed This is an automated message from the Apache Git Ser

[GitHub] mikewalch commented on a change in pull request #883: Fixes #842 Support multiple ways for running Fluo applications

2017-08-01 Thread git
This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services

[GitHub] keith-turner commented on issue #883: Fixes #842 Support multiple ways for running Fluo applications

2017-07-31 Thread git
. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org

[GitHub] keith-turner commented on a change in pull request #883: Fixes #842 Support multiple ways for running Fluo applications

2017-07-31 Thread git
. | Review comment: Could mention that this is a template for the file that will be passed to init This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL

[GitHub] keith-turner commented on a change in pull request #883: Fixes #842 Support multiple ways for running Fluo applications

2017-07-31 Thread git
uses the app name instead. A dir like `logs/apps//` or `logs/` . Could do this as a follow on issue. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above t

[GitHub] keith-turner commented on a change in pull request #883: Fixes #842 Support multiple ways for running Fluo applications

2017-07-31 Thread git
on each node, so maybe just the order the information is introduced needs to be reworked? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go

[GitHub] mikewalch commented on issue #883: Fixes #842 Support multiple ways for running Fluo applications

2017-08-01 Thread git
had to delete `fluo-conn.properties` (as expected) but everything else worked out of the box. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go

[GitHub] mikewalch commented on a change in pull request #883: Fixes #842 Support multiple ways for running Fluo applications

2017-08-02 Thread git
This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services

[GitHub] keith-turner commented on a change in pull request #883: Fixes #842 Support multiple ways for running Fluo applications

2017-08-02 Thread git
stores observer jars in HDFS and app config in ZooKeeper. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about

[GitHub] cjmctague commented on a change in pull request #902: fixes #894 merge SimpleConfiguration Objects

2017-08-08 Thread git
tValue()); Review comment: `conjoinTo(SimpleConfiguration)` Means "join; combine" This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go

[GitHub] mikewalch commented on a change in pull request #904: Fixes #897 added context to application docs and moved some docs from?

2017-08-08 Thread git
` instead of `instance` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact

[GitHub] mikewalch commented on a change in pull request #904: Fixes #897 added context to application docs and moved some docs from?

2017-08-08 Thread git
to know when to trigger observers. 6. Start your Fluo instance so that your Fluo workers load the new observer. Review comment: Could be `Start your Fluo application so that` This is an automated message from the Apache Git Service

[GitHub] mikewalch commented on a change in pull request #904: Fixes #897 added context to application docs and moved some docs from?

2017-08-08 Thread git
` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services

[GitHub] mikewalch commented on a change in pull request #904: Fixes #897 added context to application docs and moved some docs from?

2017-08-08 Thread git
below):` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure

[GitHub] mikewalch commented on issue #900: Document properties in FluoConfiguration javadoc

2017-08-08 Thread git
mikewalch commented on issue #900: Document properties in FluoConfiguration javadoc URL: https://github.com/apache/fluo/issues/900#issuecomment-320965130 Thanks @kpm1985! This is an automated message from the Apache Git

[GitHub] keith-turner commented on a change in pull request #77: update links in pages/ to https

2017-08-08 Thread git
://www.tetraconcepts.com/ Review comment: @cjnolet do you have any opinion on this? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific

[GitHub] ctubbsii commented on a change in pull request #902: fixes #894 merge SimpleConfiguration Objects

2017-08-08 Thread git
onjoin' is 'with' (mutual relationship) instead of 'to' (directional relationship), as in 'conjoinWith' instead of 'conjoinTo'. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use t

[GitHub] mikewalch commented on issue #851: Create FluoList command

2017-08-08 Thread git
mikewalch commented on issue #851: Create FluoList command URL: https://github.com/apache/fluo/issues/851#issuecomment-321079167 Closed by #883 This is an automated message from the Apache Git Service. To respond

[GitHub] mikewalch commented on issue #845: Create FluoInit command

2017-08-08 Thread git
mikewalch commented on issue #845: Create FluoInit command URL: https://github.com/apache/fluo/issues/845#issuecomment-321079261 Closed by #883 This is an automated message from the Apache Git Service. To respond

[GitHub] mikewalch closed issue #851: Create FluoList command

2017-08-08 Thread git
mikewalch closed issue #851: Create FluoList command URL: https://github.com/apache/fluo/issues/851 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL

[GitHub] mikewalch closed issue #848: Create FluoOracle command

2017-08-08 Thread git
mikewalch closed issue #848: Create FluoOracle command URL: https://github.com/apache/fluo/issues/848 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL

[GitHub] mikewalch closed issue #843: Rename FluoConfiguration properties

2017-08-08 Thread git
mikewalch closed issue #843: Rename FluoConfiguration properties URL: https://github.com/apache/fluo/issues/843 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub

[GitHub] mikewalch opened a new pull request #78: Remove incubator references on website

2017-08-08 Thread git
mikewalch opened a new pull request #78: Remove incubator references on website URL: https://github.com/apache/fluo-website/pull/78 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] mikewalch commented on a change in pull request #902: fixes #894 merge SimpleConfiguration Objects

2017-08-09 Thread git
s in on sc matches the other. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, plea

[GitHub] mikewalch opened a new issue #906: Create 'fluo get-jars' command

2017-08-09 Thread git
the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services

[GitHub] mikewalch closed pull request #904: Fixes #897 added context to application docs and moved some docs from?

2017-08-09 Thread git
mikewalch closed pull request #904: Fixes #897 added context to application docs and moved some docs from? URL: https://github.com/apache/fluo/pull/904 This is an automated message from the Apache Git Service. To respond

[GitHub] keith-turner commented on a change in pull request #1: Provide initial README

2017-08-09 Thread git
This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services

[GitHub] keith-turner commented on a change in pull request #1: Provide initial README

2017-08-09 Thread git
the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services

[GitHub] keith-turner commented on a change in pull request #1: Provide initial README

2017-08-09 Thread git
in other projects' APIs. ``` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] mikewalch closed issue #897: Add high level application lifecycle overview to docs

2017-08-09 Thread git
mikewalch closed issue #897: Add high level application lifecycle overview to docs URL: https://github.com/apache/fluo/issues/897 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] keith-turner commented on a change in pull request #902: fixes #894 merge SimpleConfiguration Objects

2017-08-09 Thread git
Else(sc1).orElse(sc2); Review comment: need to keep the return val like ```java sc4 = sc3.orElse(sc1).orElse(sc2); sc3.set(...) //ensure sc4 did not change. ``` This is an automated message from the Apach

[GitHub] mikewalch opened a new pull request #907: Fixes #906 - Create 'fluo get-jars' command

2017-08-09 Thread git
mikewalch opened a new pull request #907: Fixes #906 - Create 'fluo get-jars' command URL: https://github.com/apache/fluo/pull/907 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] mikewalch commented on a change in pull request #899: fixes #893 added ability to secure zookeeper

2017-08-09 Thread git
ment: What happens if a user a passes in an incorrect Zookeeper secret? It would be good to make sure there is a good exception or error message for this case. A unit test could also be written to verify this behavior. -------- This is an

[GitHub] keith-turner opened a new pull request #903: Fluo 897

2017-08-07 Thread git
keith-turner opened a new pull request #903: Fluo 897 URL: https://github.com/apache/fluo/pull/903 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL

[GitHub] cjmctague commented on a change in pull request #903: Fluo 897

2017-08-07 Thread git
This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git

[GitHub] keith-turner commented on a change in pull request #903: Fluo 897

2017-08-07 Thread git
This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache

[GitHub] keith-turner commented on issue #903: Fluo 897

2017-08-07 Thread git
Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services

[GitHub] keith-turner commented on issue #900: Document properties in FluoConfiguration javadoc

2017-08-08 Thread git
all yours. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at:

[GitHub] keith-turner commented on a change in pull request #902: fixes #894 merge SimpleConfiguration Objects

2017-08-08 Thread git
hang off of something. What where you thinking it would hang off of? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specifi

[GitHub] keith-turner commented on a change in pull request #891: Migrate to checkstyle 8.1 rules

2017-08-07 Thread git
@@ + Review comment: Can you provide a bit of context for this? I don't understand these changes. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go

[GitHub] ctubbsii commented on a change in pull request #891: Migrate to checkstyle 8.1 rules

2017-08-07 Thread git
from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services

[GitHub] keith-turner commented on a change in pull request #891: Migrate to checkstyle 8.1 rules

2017-08-07 Thread git
ore informative. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastruct

[GitHub] keith-turner commented on a change in pull request #1: Initial implementation of Apache Fluo YARN launcher

2017-08-07 Thread git
the version of Fluo YARN launcher" + echo " " + exit 1 +} + +function build_bundled_jar { + app_dir=$lib/apps/$app + mkdir -p "$app_dir/lib" + + java org.apache.fluo.command.FluoGetJars "$FLUO_CONN_PROPS" "$app" "$app_dir/lib" Review comment: What hap

[GitHub] keith-turner commented on a change in pull request #891: Migrate to checkstyle 8.1 rules

2017-08-07 Thread git
@@ + Review comment: > It had to be moved in order to work with the newer version of Checkstyle. Where did the version of Checkstyle change? This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] keith-turner commented on a change in pull request #891: Migrate to checkstyle 8.1 rules

2017-08-07 Thread git
ted message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services

[GitHub] ctubbsii commented on issue #891: Migrate to checkstyle 8.1 rules

2017-08-07 Thread git
the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services

[GitHub] ctubbsii commented on a change in pull request #902: fixes #894 merge SimpleConfiguration Objects

2017-08-07 Thread git
nfiguration.html This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services

[GitHub] ctubbsii commented on a change in pull request #891: Migrate to checkstyle 8.1 rules

2017-08-07 Thread git
because the rules won't work. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] keith-turner commented on a change in pull request #891: Migrate to checkstyle 8.1 rules

2017-08-07 Thread git
ion. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services

[GitHub] ctubbsii commented on a change in pull request #902: fixes #894 merge SimpleConfiguration Objects

2017-08-07 Thread git
nfiguration.html This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services

[GitHub] ctubbsii commented on a change in pull request #891: Migrate to checkstyle 8.1 rules

2017-08-07 Thread git
@@ + Review comment: I thought that's basically what my log message said, but I can reword it if it's not clear. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL

[GitHub] keith-turner commented on issue #891: Migrate to checkstyle 8.1 rules

2017-08-07 Thread git
ice. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache

[GitHub] mikewalch commented on issue #883: Fixes #842 Support multiple ways for running Fluo applications

2017-07-27 Thread git
fbe This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastruct

[GitHub] ctubbsii closed pull request #887: Update plugins, drop incubating, sort imports

2017-07-27 Thread git
ctubbsii closed pull request #887: Update plugins, drop incubating, sort imports URL: https://github.com/apache/incubator-fluo/pull/887 This is an automated message from the Apache Git Service. To respond to the message

[GitHub] mikewalch closed issue #842: Support multiple ways for running Fluo Applications as downstream projects

2017-08-04 Thread git
mikewalch closed issue #842: Support multiple ways for running Fluo Applications as downstream projects URL: https://github.com/apache/fluo/issues/842 This is an automated message from the Apache Git Service. To respond

[GitHub] mikewalch closed pull request #883: Fixes #842 Support multiple ways for running Fluo applications

2017-08-04 Thread git
mikewalch closed pull request #883: Fixes #842 Support multiple ways for running Fluo applications URL: https://github.com/apache/fluo/pull/883 This is an automated message from the Apache Git Service. To respond

[GitHub] mikewalch opened a new issue #898: Determine if FluoExec should read config from Zookeeper

2017-08-04 Thread git
in Fluo Recipes will need to be modified. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about

[GitHub] cjmctague commented on a change in pull request #902: fixes #894 merge SimpleConfiguration Objects

2017-08-07 Thread git
iously set values.` That's why I used add properties because it was more of a merge by adding all the properties together. I could be misunderstanding it. This is an automated message from the Apache Git Service. To r

[GitHub] cjmctague commented on a change in pull request #902: fixes #894 merge SimpleConfiguration Objects

2017-08-07 Thread git
ent This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services

[GitHub] mikewalch commented on a change in pull request #902: fixes #894 merge SimpleConfiguration Objects

2017-08-07 Thread git
are merged if they are set in multiple SimpleConfigurations. Also does first configuration parameter listed take precedent or does last? This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] mikewalch commented on a change in pull request #902: fixes #894 merge SimpleConfiguration Objects

2017-08-07 Thread git
a list of values if a property is already set. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] cjmctague commented on a change in pull request #902: fixes #894 merge SimpleConfiguration Objects

2017-08-07 Thread git
This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services

[GitHub] mikewalch commented on a change in pull request #902: fixes #894 merge SimpleConfiguration Objects

2017-08-07 Thread git
files. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services

[GitHub] cjmctague commented on a change in pull request #902: fixes #894 merge SimpleConfiguration Objects

2017-08-07 Thread git
e a list while `setProperty()` overwrites the value of anything with the same key. Note how we lose `value1` in this example. Is that acceptable? In my mind that's not really a merge but rather a rewrite of the property. T

[GitHub] cjmctague commented on a change in pull request #902: fixes #894 merge SimpleConfiguration Objects

2017-08-07 Thread git
e a list while `setProperty()` overwrites the value of anything with the same key. Note how we lose `value1` in this example. Is that acceptable? In my mind that's not really a merge but rather a rewrite of the property if they have the same key value. --

[GitHub] mikewalch opened a new pull request #913: Fluo 912

2017-08-16 Thread git
mikewalch opened a new pull request #913: Fluo 912 URL: https://github.com/apache/fluo/pull/913 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above

[GitHub] mikewalch commented on issue #2: Print yarn app id

2017-08-16 Thread git
mikewalch commented on issue #2: Print yarn app id URL: https://github.com/apache/fluo-yarn/issues/2#issuecomment-322837270 Fixed by #1 This is an automated message from the Apache Git Service. To respond to the message

[GitHub] mikewalch opened a new pull request #5: Fixes #3 Check if application is running before starting

2017-08-16 Thread git
mikewalch opened a new pull request #5: Fixes #3 Check if application is running before starting URL: https://github.com/apache/fluo-yarn/pull/5 * Also improved README.md This is an automated message from the Apache Git

[GitHub] cjmctague commented on issue #879: CollisionIT test failed on Travis

2017-08-16 Thread git
l:2000 at org.apache.fluo.integration.impl.CollisionIT.testLotsOfCollisions(CollisionIT.java:174) ``` https://travis-ci.org/apache/fluo/jobs/265159869 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use t

[GitHub] mikewalch closed issue #2: Print yarn app id

2017-08-16 Thread git
mikewalch closed issue #2: Print yarn app id URL: https://github.com/apache/fluo-yarn/issues/2 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above

[GitHub] keith-turner commented on a change in pull request #5: Fixes #3 Check if application is running before starting

2017-08-16 Thread git
] instructions Review comment: Why repeat this info? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about

[GitHub] keith-turner commented on a change in pull request #913: Fluo 912

2017-08-16 Thread git
System.out.println("NOT_FOUND"); +return; + } +} + +if (FluoAdminImpl.oracleExists(config)) { Review comment: what about workers? -------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and us

[GitHub] keith-turner opened a new pull request #134: Changes in prep for 1.1.0 Release

2017-06-12 Thread git
keith-turner opened a new pull request #134: Changes in prep for 1.1.0 Release URL: https://github.com/apache/incubator-fluo-recipes/pull/134 This is an automated message from the Apache Git Service. To respond

[GitHub] keith-turner commented on issue #790: Add verification code to RC email

2017-06-12 Thread git
ash and check those. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please cont

[GitHub] ctubbsii commented on a change in pull request #56: updated release process

2017-06-12 Thread git
```shell -# Creates 1.0.0-beta-1-RC1 from 1.0.0-beta-1 -git tag 1.0.0-beta-1-RC1 1.0.0-beta-1 -# Delete 1.0.0-beta-1 -git tag -d 1.0.0-beta-1 -# Push RC tag to fork -git push origin 1.0.0-beta-1-RC1 -``` - - 7. The artifacts will be staged in nexus OSS. Send a message

[GitHub] ctubbsii commented on issue #790: Add verification code to RC email

2017-06-12 Thread git
ecursive --level inf --no-parent --no-host-directories \ --reject 'index.html,maven-metadata.xml*,archetype-catalog.xml' \ -P download \ "$url" ``` ---- This is an automated message from the Apache Gi

[GitHub] ctubbsii commented on a change in pull request #56: updated release process

2017-06-12 Thread git
```shell -# Creates 1.0.0-beta-1-RC1 from 1.0.0-beta-1 -git tag 1.0.0-beta-1-RC1 1.0.0-beta-1 -# Delete 1.0.0-beta-1 -git tag -d 1.0.0-beta-1 -# Push RC tag to fork -git push origin 1.0.0-beta-1-RC1 -``` - - 7. The artifacts will be staged in nexus OSS. Send a message

[GitHub] keith-turner commented on a change in pull request #56: updated release process

2017-06-12 Thread git
```shell -# Creates 1.0.0-beta-1-RC1 from 1.0.0-beta-1 -git tag 1.0.0-beta-1-RC1 1.0.0-beta-1 -# Delete 1.0.0-beta-1 -git tag -d 1.0.0-beta-1 -# Push RC tag to fork -git push origin 1.0.0-beta-1-RC1 -``` - - 7. The artifacts will be staged in nexus OSS. Send a message

<    1   2   3   4   5   >