mhansonp commented on a change in pull request #5281:
URL: https://github.com/apache/geode/pull/5281#discussion_r444638563
##
File path:
geode-management/src/main/java/org/apache/geode/management/internal/operation/RestoreRedundancyResultsImpl.java
##
@@ -38,24 +37,55 @@
mhansonp commented on a change in pull request #5281:
URL: https://github.com/apache/geode/pull/5281#discussion_r444638686
##
File path:
geode-core/src/test/java/org/apache/geode/internal/cache/control/SerializableRestoreRedundancyResultsImplTest.java
##
@@ -153,39 +157,64 @@
mhansonp commented on a change in pull request #5281:
URL: https://github.com/apache/geode/pull/5281#discussion_r444638294
##
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/control/SerializableRestoreRedundancyResultsImpl.java
##
@@ -39,7 +39,8 @@
mhansonp commented on a change in pull request #5281:
URL: https://github.com/apache/geode/pull/5281#discussion_r444638260
##
File path:
geode-core/src/test/java/org/apache/geode/internal/cache/control/SerializableRestoreRedundancyResultsImplTest.java
##
@@ -153,39 +157,64 @@
jinmeiliao commented on a change in pull request #5288:
URL: https://github.com/apache/geode/pull/5288#discussion_r444622138
##
File path:
geode-management/src/main/java/org/apache/geode/management/configuration/DiskStore.java
##
@@ -0,0 +1,166 @@
+/*
+ * Licensed to the
jinmeiliao commented on a change in pull request #5281:
URL: https://github.com/apache/geode/pull/5281#discussion_r444619369
##
File path:
geode-core/src/test/java/org/apache/geode/internal/cache/control/SerializableRestoreRedundancyResultsImplTest.java
##
@@ -153,39 +157,64
jinmeiliao commented on a change in pull request #5285:
URL: https://github.com/apache/geode/pull/5285#discussion_r444618488
##
File path:
geode-core/src/main/java/org/apache/geode/management/internal/api/LocatorClusterManagementService.java
##
@@ -113,7 +113,7 @@
public
jinmeiliao commented on a change in pull request #5285:
URL: https://github.com/apache/geode/pull/5285#discussion_r444618066
##
File path:
geode-gfsh/src/main/java/org/apache/geode/management/internal/cli/remote/CommandExecutor.java
##
@@ -207,4 +219,32 @@ protected Object
agingade commented on a change in pull request #5285:
URL: https://github.com/apache/geode/pull/5285#discussion_r444588637
##
File path:
geode-core/src/main/java/org/apache/geode/management/internal/api/LocatorClusterManagementService.java
##
@@ -113,7 +113,7 @@
public class
kohlmu-pivotal commented on a change in pull request #5292:
URL: https://github.com/apache/geode/pull/5292#discussion_r444577930
##
File path: gradle/publish-java.gradle
##
@@ -28,3 +28,53 @@ publishing {
}
}
}
+
+gradle.taskGraph.whenReady({ graph ->
+
kohlmu-pivotal commented on a change in pull request #5292:
URL: https://github.com/apache/geode/pull/5292#discussion_r444574296
##
File path: gradle/publish-java.gradle
##
@@ -28,3 +28,53 @@ publishing {
}
}
}
+
+gradle.taskGraph.whenReady({ graph ->
+
davebarnes97 opened a new pull request #5294:
URL: https://github.com/apache/geode/pull/5294
Updates regarding log4j 2 customization.
@kirklund Please provide a JIRA number, if there is one. Thanks!
This is an automated
kohlmu-pivotal commented on a change in pull request #5292:
URL: https://github.com/apache/geode/pull/5292#discussion_r444574613
##
File path: gradle.properties
##
@@ -82,3 +82,4 @@ org.gradle.parallel = true
org.gradle.internal.http.socketTimeout=12
kohlmu-pivotal commented on a change in pull request #5292:
URL: https://github.com/apache/geode/pull/5292#discussion_r444574296
##
File path: gradle/publish-java.gradle
##
@@ -28,3 +28,53 @@ publishing {
}
}
}
+
+gradle.taskGraph.whenReady({ graph ->
+
yozaner1324 opened a new pull request #5293:
URL: https://github.com/apache/geode/pull/5293
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all
rhoughton-pivot commented on a change in pull request #5292:
URL: https://github.com/apache/geode/pull/5292#discussion_r444573116
##
File path: gradle/java.gradle
##
@@ -29,88 +29,65 @@ targetCompatibility = 1.8
compileJava.options.encoding = 'UTF-8'
dependencies {
- //
yozaner1324 opened a new pull request #5292:
URL: https://github.com/apache/geode/pull/5292
Add Gradle config to generate manifest file containing 'Class-Path' and
'Dependent-Modules' attributes.
Thank you for submitting a contribution to Apache Geode.
In order to streamline
rhoughton-pivot commented on pull request #5291:
URL: https://github.com/apache/geode/pull/5291#issuecomment-648487629
Tried to get Spring to handle this, but they punted:
https://github.com/spring-projects/spring-security/issues/8733
rhoughton-pivot opened a new pull request #5291:
URL: https://github.com/apache/geode/pull/5291
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
jhuynh1 opened a new pull request #5290:
URL: https://github.com/apache/geode/pull/5290
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all
dschneider-pivotal opened a new pull request #5289:
URL: https://github.com/apache/geode/pull/5289
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
###
mhansonp commented on pull request #5281:
URL: https://github.com/apache/geode/pull/5281#issuecomment-648466908
This code is to fix another serialization issue with the Restore Redundancy
code. Basically, it is very painful from what I have seen to json deserialize a
Duration object type.
mmartell opened a new pull request #622:
URL: https://github.com/apache/geode-native/pull/622
This PR replaces the previous PR which was pulled due to a CI failure on
ubuntu.
This is an automated message from the Apache Git
rhoughton-pivot merged pull request #5287:
URL: https://github.com/apache/geode/pull/5287
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
lgtm-com[bot] commented on pull request #5256:
URL: https://github.com/apache/geode/pull/5256#issuecomment-648449196
This pull request **fixes 1 alert** when merging
186bf85298b3606d1dff4d58c4673dd05859f1c4 into
91fd5f51ea99250753e249d2ef90a24543be9b7e - [view on
gesterzhou commented on a change in pull request #5253:
URL: https://github.com/apache/geode/pull/5253#discussion_r444529874
##
File path:
geode-core/src/main/java/org/apache/geode/internal/InternalDataSerializer.java
##
@@ -2506,153 +2506,156 @@ public static Object
jmelchio opened a new pull request #5288:
URL: https://github.com/apache/geode/pull/5288
- Provides create, get, list and delete operations
- Can create with locator only running
Co-Authored-By: Jason Huynh
Thank you for submitting a contribution to Apache Geode.
In
rhoughton-pivot merged pull request #5283:
URL: https://github.com/apache/geode/pull/5283
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
rhoughton-pivot edited a comment on pull request #5283:
URL: https://github.com/apache/geode/pull/5283#issuecomment-648404584
> I tried this and it appears to clean up the `geode-old-versions/build` dir
but not the dirs for the "synthesized" subprojects:
>
>
rhoughton-pivot commented on pull request #5283:
URL: https://github.com/apache/geode/pull/5283#issuecomment-648404584
> I tried this and it appears to clean up the `geode-old-versions/build` dir
but not the dirs for the "synthesized" subprojects:
>
>
Bill edited a comment on pull request #5283:
URL: https://github.com/apache/geode/pull/5283#issuecomment-648402388
I tried this and it appears to clean up the `geode-old-versions/build` dir
but not the dirs for the "synthesized" subprojects:
rhoughton-pivot commented on pull request #5287:
URL: https://github.com/apache/geode/pull/5287#issuecomment-648403305
Please see the inaugural run of this pipeline at:
https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-mass-test-run.
Changes are based on actual GCP
rhoughton-pivot opened a new pull request #5287:
URL: https://github.com/apache/geode/pull/5287
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For
Bill edited a comment on pull request #5283:
URL: https://github.com/apache/geode/pull/5283#issuecomment-648402388
I tried this and it appears to clean up the `geode-old-versions/build` dir
but not the dirs for the "synthesized" subprojects:
Bill commented on pull request #5283:
URL: https://github.com/apache/geode/pull/5283#issuecomment-648402388
I tried this and it appears to clean up the `geode-old-versions/build` dir
but not the dirs for the "synthesized" subprojects:
kirklund edited a comment on pull request #5268:
URL: https://github.com/apache/geode/pull/5268#issuecomment-648391431
@jinmeiliao I'm going to request a re-review. I'm not able to remove my
manipulation of TemporaryFolder and I don't want to spend more time trying to
debug why GfshRule
kirklund commented on pull request #5268:
URL: https://github.com/apache/geode/pull/5268#issuecomment-648391431
@jinmeiliao I'm going to request a re-review. I'm not able to remove my
manipulation of TemporaryFolder and I don't want to spend more time trying to
debug why GfshRule doesn't
kirklund commented on a change in pull request #5268:
URL: https://github.com/apache/geode/pull/5268#discussion_r77471
##
File path:
geode-assembly/src/acceptanceTest/java/org/apache/geode/logging/LocatorWithCustomLogConfigAcceptanceTest.java
##
@@ -0,0 +1,291 @@
+/*
+ *
kirklund commented on a change in pull request #5268:
URL: https://github.com/apache/geode/pull/5268#discussion_r76417
##
File path:
geode-assembly/src/acceptanceTest/java/org/apache/geode/logging/LocatorWithCustomLogConfigAcceptanceTest.java
##
@@ -0,0 +1,291 @@
+/*
+ *
kirklund commented on a change in pull request #5268:
URL: https://github.com/apache/geode/pull/5268#discussion_r76057
##
File path:
geode-assembly/src/acceptanceTest/java/org/apache/geode/logging/LocatorWithCustomLogConfigAcceptanceTest.java
##
@@ -0,0 +1,291 @@
+/*
+ *
DonalEvans commented on a change in pull request #5256:
URL: https://github.com/apache/geode/pull/5256#discussion_r34215
##
File path:
extensions/geode-modules/src/main/java/org/apache/geode/modules/session/catalina/DeltaSessionManagerConfiguration.java
##
@@ -0,0 +1,74
kirklund merged pull request #5267:
URL: https://github.com/apache/geode/pull/5267
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
pivotal-eshu commented on a change in pull request #5256:
URL: https://github.com/apache/geode/pull/5256#discussion_r444393667
##
File path:
extensions/geode-modules/src/main/java/org/apache/geode/modules/session/catalina/DeltaSession.java
##
@@ -231,6 +236,11 @@ public void
lgtm-com[bot] commented on pull request #5286:
URL: https://github.com/apache/geode/pull/5286#issuecomment-648321874
This pull request **introduces 1 alert** when merging
4e9f37af5cfe477fe488813c2e7241eff27b206d into
cd4477a25e8a7125b265c7c715276197114cd151 - [view on
BenjaminPerryRoss opened a new pull request #5286:
URL: https://github.com/apache/geode/pull/5286
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For
pivotal-jbarrett commented on a change in pull request #621:
URL: https://github.com/apache/geode-native/pull/621#discussion_r444346251
##
File path: cppcache/src/SerializationRegistry.hpp
##
@@ -23,6 +23,7 @@
#include
#include
#include
+#include
Review comment:
alb3rtobr commented on pull request #619:
URL: https://github.com/apache/geode-native/pull/619#issuecomment-648001141
@pivotal-jbarrett & @pdxcodemonkey thanks for your help with this PR!
This is an automated message from
albertogpz edited a comment on pull request #621:
URL: https://github.com/apache/geode-native/pull/621#issuecomment-647987941
The shared_lock provided by boost offered a much worse performance than the
spinlock or the mutex (see https://github.com/apache/geode-native/pull/611).
There is
albertogpz commented on a change in pull request #611:
URL: https://github.com/apache/geode-native/pull/611#discussion_r437398002
##
File path: cppcache/src/SerializationRegistry.cpp
##
@@ -409,44 +411,56 @@ void TheTypeMap::bindDataSerializable(TypeFactoryMethod
func,
albertogpz commented on pull request #621:
URL: https://github.com/apache/geode-native/pull/621#issuecomment-647987941
The shared_lock provided by boost offered a much worse performance than the
spinlock or the mutex.
There is a tiny gain according to the benchmark performance test in
albertogpz opened a new pull request #621:
URL: https://github.com/apache/geode-native/pull/621
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
51 matches
Mail list logo
