[GitHub] [geode] jdeppe-pivotal commented on a change in pull request #7478: GEODE-10126: Replace Geode for Redis properties with system properties

2022-04-01 Thread GitBox
jdeppe-pivotal commented on a change in pull request #7478: URL: https://github.com/apache/geode/pull/7478#discussion_r840749048 ## File path: geode-for-redis/src/integrationTest/java/org/apache/geode/redis/internal/commands/executor/connection/AuthIntegrationTest.java ## @@

[GitHub] [geode] jdeppe-pivotal commented on a change in pull request #7478: GEODE-10126: Replace Geode for Redis properties with system properties

2022-04-01 Thread GitBox
jdeppe-pivotal commented on a change in pull request #7478: URL: https://github.com/apache/geode/pull/7478#discussion_r840748900 ## File path: geode-for-redis/src/commonTest/java/org/apache/geode/redis/TestRedisConfiguration.java ## @@ -0,0 +1,97 @@ +/* + * Licensed to the

[GitHub] [geode] jdeppe-pivotal commented on a change in pull request #7478: GEODE-10126: Replace Geode for Redis properties with system properties

2022-04-01 Thread GitBox
jdeppe-pivotal commented on a change in pull request #7478: URL: https://github.com/apache/geode/pull/7478#discussion_r840748771 ## File path: geode-for-redis/src/acceptanceTest/java/org/apache/geode/redis/internal/commands/executor/GeodeRedisServerStartupUsingGfshAcceptanceTest.java

[GitHub] [geode] jdeppe-pivotal commented on a change in pull request #7478: GEODE-10126: Replace Geode for Redis properties with system properties

2022-04-01 Thread GitBox
jdeppe-pivotal commented on a change in pull request #7478: URL: https://github.com/apache/geode/pull/7478#discussion_r840737832 ## File path: geode-for-redis/src/main/java/org/apache/geode/redis/internal/GeodeRedisService.java ## @@ -83,18 +86,12 @@ public void

[GitHub] [geode] jdeppe-pivotal commented on a change in pull request #7478: GEODE-10126: Replace Geode for Redis properties with system properties

2022-04-01 Thread GitBox
jdeppe-pivotal commented on a change in pull request #7478: URL: https://github.com/apache/geode/pull/7478#discussion_r840737832 ## File path: geode-for-redis/src/main/java/org/apache/geode/redis/internal/GeodeRedisService.java ## @@ -83,18 +86,12 @@ public void

[GitHub] [geode] jdeppe-pivotal commented on a change in pull request #7478: GEODE-10126: Replace Geode for Redis properties with system properties

2022-04-01 Thread GitBox
jdeppe-pivotal commented on a change in pull request #7478: URL: https://github.com/apache/geode/pull/7478#discussion_r840737832 ## File path: geode-for-redis/src/main/java/org/apache/geode/redis/internal/GeodeRedisService.java ## @@ -83,18 +86,12 @@ public void