[GitHub] [geode] kirklund commented on a change in pull request #5309: GEODE-8250: Create new custom log config acceptance tests

2020-06-25 Thread GitBox
kirklund commented on a change in pull request #5309: URL: https://github.com/apache/geode/pull/5309#discussion_r445904115 ## File path: geode-assembly/src/acceptanceTest/java/org/apache/geode/management/internal/cli/commands/StartLocatorAcceptanceTest.java ## @@ -14,43

[GitHub] [geode] kirklund commented on a change in pull request #5309: GEODE-8250: Create new custom log config acceptance tests

2020-06-25 Thread GitBox
kirklund commented on a change in pull request #5309: URL: https://github.com/apache/geode/pull/5309#discussion_r445904267 ## File path: geode-assembly/src/acceptanceTest/java/org/apache/geode/management/internal/cli/commands/StartLocatorAcceptanceTest.java ## @@ -14,43

[GitHub] [geode] kirklund commented on a change in pull request #5309: GEODE-8250: Create new custom log config acceptance tests

2020-06-25 Thread GitBox
kirklund commented on a change in pull request #5309: URL: https://github.com/apache/geode/pull/5309#discussion_r445903549 ## File path: geode-assembly/src/acceptanceTest/java/org/apache/geode/management/internal/cli/commands/StartLocatorAcceptanceTest.java ## @@ -14,43

[GitHub] [geode] kirklund commented on a change in pull request #5309: GEODE-8250: Create new custom log config acceptance tests

2020-06-25 Thread GitBox
kirklund commented on a change in pull request #5309: URL: https://github.com/apache/geode/pull/5309#discussion_r445903215 ## File path: geode-junit/src/main/java/org/apache/geode/test/junit/rules/gfsh/GfshRule.java ## @@ -145,9 +145,7 @@ public GfshExecution

[GitHub] [geode] kirklund commented on a change in pull request #5309: GEODE-8250: Create new custom log config acceptance tests

2020-06-25 Thread GitBox
kirklund commented on a change in pull request #5309: URL: https://github.com/apache/geode/pull/5309#discussion_r445902105 ## File path: geode-assembly/src/acceptanceTest/java/org/apache/geode/management/internal/cli/commands/StartLocatorAcceptanceTest.java ## @@ -14,43

[GitHub] [geode] kirklund commented on a change in pull request #5309: GEODE-8250: Create new custom log config acceptance tests

2020-06-25 Thread GitBox
kirklund commented on a change in pull request #5309: URL: https://github.com/apache/geode/pull/5309#discussion_r445902008 ## File path: geode-assembly/src/acceptanceTest/java/org/apache/geode/management/internal/cli/commands/StartLocatorAcceptanceTest.java ## @@ -14,43