[GitHub] [geode] kohlmu-pivotal commented on a change in pull request #7456: make ResourceManager's interaction with JVM customizable with the HeapUsageProvider SPI

2022-03-23 Thread GitBox
kohlmu-pivotal commented on a change in pull request #7456: URL: https://github.com/apache/geode/pull/7456#discussion_r833826168 ## File path: geode-core/src/main/java/org/apache/geode/internal/cache/control/HeapMemoryMonitor.java ## @@ -554,12 +579,12 @@ private String

[GitHub] [geode] kohlmu-pivotal commented on a change in pull request #7456: make ResourceManager's interaction with JVM customizable with the HeapUsageProvider SPI

2022-03-23 Thread GitBox
kohlmu-pivotal commented on a change in pull request #7456: URL: https://github.com/apache/geode/pull/7456#discussion_r833809142 ## File path: geode-core/src/main/java/org/apache/geode/internal/cache/control/HeapMemoryMonitor.java ## @@ -88,30 +90,52 @@ @MutableForTesting

[GitHub] [geode] kohlmu-pivotal commented on a change in pull request #7456: make ResourceManager's interaction with JVM customizable with the HeapUsageProvider SPI

2022-03-23 Thread GitBox
kohlmu-pivotal commented on a change in pull request #7456: URL: https://github.com/apache/geode/pull/7456#discussion_r833801795 ## File path: geode-core/src/main/java/org/apache/geode/internal/cache/control/HeapMemoryMonitor.java ## @@ -88,30 +90,52 @@ @MutableForTesting

[GitHub] [geode] kohlmu-pivotal commented on a change in pull request #7456: make ResourceManager's interaction with JVM customizable with the HeapUsageProvider SPI

2022-03-23 Thread GitBox
kohlmu-pivotal commented on a change in pull request #7456: URL: https://github.com/apache/geode/pull/7456#discussion_r833677841 ## File path: geode-core/src/main/java/org/apache/geode/internal/cache/control/HeapMemoryMonitor.java ## @@ -144,82 +84,34 @@ private final

[GitHub] [geode] kohlmu-pivotal commented on a change in pull request #7456: make ResourceManager's interaction with JVM customizable with the HeapUsageProvider SPI

2022-03-23 Thread GitBox
kohlmu-pivotal commented on a change in pull request #7456: URL: https://github.com/apache/geode/pull/7456#discussion_r833674820 ## File path: geode-core/src/main/java/org/apache/geode/internal/cache/control/HeapMemoryMonitor.java ## @@ -144,82 +84,34 @@ private final

[GitHub] [geode] kohlmu-pivotal commented on a change in pull request #7456: make ResourceManager's interaction with JVM customizable with the HeapUsageProvider SPI

2022-03-23 Thread GitBox
kohlmu-pivotal commented on a change in pull request #7456: URL: https://github.com/apache/geode/pull/7456#discussion_r833674376 ## File path: geode-core/src/main/java/org/apache/geode/internal/cache/control/HeapMemoryMonitor.java ## @@ -144,82 +84,34 @@ private final

[GitHub] [geode] kohlmu-pivotal commented on a change in pull request #7456: make ResourceManager's interaction with JVM customizable with the HeapUsageProvider SPI

2022-03-23 Thread GitBox
kohlmu-pivotal commented on a change in pull request #7456: URL: https://github.com/apache/geode/pull/7456#discussion_r833671018 ## File path: geode-core/src/main/java/org/apache/geode/internal/cache/control/HeapMemoryMonitor.java ## @@ -429,29 +207,33 @@ void

[GitHub] [geode] kohlmu-pivotal commented on a change in pull request #7456: make ResourceManager's interaction with JVM customizable with the HeapUsageProvider SPI

2022-03-22 Thread GitBox
kohlmu-pivotal commented on a change in pull request #7456: URL: https://github.com/apache/geode/pull/7456#discussion_r832778862 ## File path: geode-core/src/main/java/org/apache/geode/internal/cache/control/HeapMemoryMonitor.java ## @@ -144,82 +84,34 @@ private final

[GitHub] [geode] kohlmu-pivotal commented on a change in pull request #7456: make ResourceManager's interaction with JVM customizable with the HeapUsageProvider SPI

2022-03-22 Thread GitBox
kohlmu-pivotal commented on a change in pull request #7456: URL: https://github.com/apache/geode/pull/7456#discussion_r832774433 ## File path: geode-core/src/main/java/org/apache/geode/internal/cache/control/HeapMemoryMonitor.java ## @@ -144,82 +84,34 @@ private final

[GitHub] [geode] kohlmu-pivotal commented on a change in pull request #7456: make ResourceManager's interaction with JVM customizable with the HeapUsageProvider SPI

2022-03-22 Thread GitBox
kohlmu-pivotal commented on a change in pull request #7456: URL: https://github.com/apache/geode/pull/7456#discussion_r832774433 ## File path: geode-core/src/main/java/org/apache/geode/internal/cache/control/HeapMemoryMonitor.java ## @@ -144,82 +84,34 @@ private final

[GitHub] [geode] kohlmu-pivotal commented on a change in pull request #7456: make ResourceManager's interaction with JVM customizable with the HeapUsageProvider SPI

2022-03-22 Thread GitBox
kohlmu-pivotal commented on a change in pull request #7456: URL: https://github.com/apache/geode/pull/7456#discussion_r832774433 ## File path: geode-core/src/main/java/org/apache/geode/internal/cache/control/HeapMemoryMonitor.java ## @@ -144,82 +84,34 @@ private final