[GitHub] [geode] kohlmu-pivotal commented on a change in pull request #7456: make ResourceManager's interaction with JVM customizable with the HeapUsageProvider SPI

[GitBox]

kohlmu-pivotal commented on a change in pull request #7456:
URL: https://github.com/apache/geode/pull/7456#discussion_r833826168



##########
File path: 
geode-core/src/main/java/org/apache/geode/internal/cache/control/HeapMemoryMonitor.java
##########
@@ -554,12 +579,12 @@ private String 
createCriticalThresholdLogMessage(MemoryEvent event, String event
   }
 
   public long getMaxMemory() {
-    return heapUsageMonitor.getMaxMemory();
+    return heapUsageProvider.getMaxMemory();
   }
 
   @TestOnly
-  public NotificationListener getHeapUsageMonitor() {
-    return (MemoryPoolMXBeanHeapUsageProvider) heapUsageMonitor;
+  public NotificationListener getHeapUsageProvider() {
+    return (MemoryPoolMXBeanHeapUsageProvider) heapUsageProvider;

Review comment:
       Should this not be cast to a NotificationListener?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org