[GitHub] [geode-native] alb3rtobr commented on pull request #628: GEODE-8344: Add GatewaySenderEventCallbackArgument class

2020-08-18 Thread GitBox
alb3rtobr commented on pull request #628: URL: https://github.com/apache/geode-native/pull/628#issuecomment-675311553 thanks for the reviews! Sorry but I need someone to merge the PR because Im not a committer This is an

[GitHub] [geode-native] alb3rtobr commented on pull request #628: GEODE-8344: Add GatewaySenderEventCallbackArgument class

2020-08-17 Thread GitBox
alb3rtobr commented on pull request #628: URL: https://github.com/apache/geode-native/pull/628#issuecomment-674947497 Hi @moleske @echobravopapa @pivotal-jbarrett , is there anything else missing to approve this PR? This

[GitHub] [geode-native] alb3rtobr commented on pull request #628: GEODE-8344: Add GatewaySenderEventCallbackArgument class

2020-08-06 Thread GitBox
alb3rtobr commented on pull request #628: URL: https://github.com/apache/geode-native/pull/628#issuecomment-669938261 With the new integration test it is possible to reproduce the problem and ensure it is solved. These two logs messages can be found on test log: ```

[GitHub] [geode-native] alb3rtobr commented on pull request #628: GEODE-8344: Add GatewaySenderEventCallbackArgument class

2020-08-04 Thread GitBox
alb3rtobr commented on pull request #628: URL: https://github.com/apache/geode-native/pull/628#issuecomment-668701694 Sorry for the late answer, I have been on vacation. I have changed the PR to draft because Im still working on the tests. I have added some functionality to the