[GitHub] [geode] jujoramos opened a new pull request #5167: [DO NOT REVIEW]: Debug 4 Regression Introduced Through GEODE-8119

jujoramos opened a new pull request #5167: URL: https://github.com/apache/geode/pull/5167 Hello @mkevo, This is just a draft `PR` to reproduce the regression introduced through [GEODE-8119](https://issues.apache.org/jira/browse/GEODE-8119). The first commit contains only your original

[GitHub] [geode] kohlmu-pivotal opened a new pull request #5170: 1.13 GEODE-8174: Fix ConcurrentModificationException when using JTA transaction.

kohlmu-pivotal opened a new pull request #5170: URL: https://github.com/apache/geode/pull/5170 (cherry picked from commit 93ef47c8c4d8712f60c2961fce1b28457fe447cc) Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the

[GitHub] [geode] dschneider-pivotal commented on a change in pull request #5165: GEODE-8182: change String commands to use one region

dschneider-pivotal commented on a change in pull request #5165: URL: https://github.com/apache/geode/pull/5165#discussion_r431238457 ## File path: geode-redis/src/main/java/org/apache/geode/redis/internal/executor/string/SetNXExecutor.java ## @@ -36,27 +36,23 @@ public

[GitHub] [geode] kohlmu-pivotal opened a new pull request #5168: GEODE-8174: Fix ConcurrentModificationException when using JTA transaction.

kohlmu-pivotal opened a new pull request #5168: URL: https://github.com/apache/geode/pull/5168 Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For

[GitHub] [geode] bschuchardt commented on a change in pull request #5164: Feature/geode 8144

bschuchardt commented on a change in pull request #5164: URL: https://github.com/apache/geode/pull/5164#discussion_r431292388 ## File path: geode-gfsh/src/distributedTest/java/org/apache/geode/management/internal/cli/commands/GfshHostNameVerificationDistributedTest.java ## @@

[GitHub] [geode] alb3rtobr opened a new pull request #5166: GEODE-8193: Broken link in statistics list

alb3rtobr opened a new pull request #5166: URL: https://github.com/apache/geode/pull/5166 The link of region entry heap-based eviction is wrong and shows the html anchor id in the statistics lists: * Region Entry Eviction - Heap-based eviction

[GitHub] [geode] jdeppe-pivotal commented on a change in pull request #5165: GEODE-8182: change String commands to use one region

jdeppe-pivotal commented on a change in pull request #5165: URL: https://github.com/apache/geode/pull/5165#discussion_r431140254 ## File path: geode-redis/src/main/java/org/apache/geode/redis/internal/executor/string/SetNXExecutor.java ## @@ -36,27 +36,23 @@ public void

[GitHub] [geode] kohlmu-pivotal opened a new pull request #5169: GEODE-8174: Fix ConcurrentModificationException when using JTA transaction.

kohlmu-pivotal opened a new pull request #5169: URL: https://github.com/apache/geode/pull/5169 …ction. (cherry picked from commit 93ef47c8c4d8712f60c2961fce1b28457fe447cc) Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the

[GitHub] [geode] dschneider-pivotal merged pull request #5165: GEODE-8182: change String commands to use one region

dschneider-pivotal merged pull request #5165: URL: https://github.com/apache/geode/pull/5165 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [geode] bschuchardt commented on a change in pull request #5164: Feature/geode 8144

bschuchardt commented on a change in pull request #5164: URL: https://github.com/apache/geode/pull/5164#discussion_r431292388 ## File path: geode-gfsh/src/distributedTest/java/org/apache/geode/management/internal/cli/commands/GfshHostNameVerificationDistributedTest.java ## @@

[GitHub] [geode] bschuchardt merged pull request #5164: Feature/geode 8144

bschuchardt merged pull request #5164: URL: https://github.com/apache/geode/pull/5164 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [geode] kohlmu-pivotal closed pull request #5168: 1.13 - GEODE-8174: Fix ConcurrentModificationException when using JTA transaction.

kohlmu-pivotal closed pull request #5168: URL: https://github.com/apache/geode/pull/5168 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [geode] bschuchardt closed pull request #5163: Revert "GEODE-8144: endpoint identification in servers is not working…

bschuchardt closed pull request #5163: URL: https://github.com/apache/geode/pull/5163 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [geode] agingade closed pull request #4987: GEODE-7678: Support for cache-listener and client-notification for Partitioned Region Clear operation.

agingade closed pull request #4987: URL: https://github.com/apache/geode/pull/4987 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [geode] gesterzhou commented on a change in pull request #5164: Feature/geode 8144

gesterzhou commented on a change in pull request #5164: URL: https://github.com/apache/geode/pull/5164#discussion_r431288262 ## File path: geode-gfsh/src/distributedTest/java/org/apache/geode/management/internal/cli/commands/GfshHostNameVerificationDistributedTest.java ## @@

[GitHub] [geode] rhoughton-pivot opened a new pull request #5173: GEODE-8083: Add API Checking to Geode. (#5066) (#5103)

rhoughton-pivot opened a new pull request #5173: URL: https://github.com/apache/geode/pull/5173 * Add API check gradle task. * Add CI job that calls API check gradle task. * Fix spotless rules so it doesn't mistakenly mess up our gradle. * Allow changes if a class or superclass is

[GitHub] [geode] lgtm-com[bot] commented on pull request #4866: GEODE-7864: Overriding hashCode when equals is overridden.

lgtm-com[bot] commented on pull request #4866: URL: https://github.com/apache/geode/pull/4866#issuecomment-634978509 This pull request **fixes 7 alerts** when merging 598d886b9c3beae173cc223167f2a0e9cdb70ca4 into a185267dca016954f857f6848863bc4f74e6de81 - [view on

[GitHub] [geode] bschuchardt merged pull request #5172: GEODE-8144 another attempt to fix a failing test

bschuchardt merged pull request #5172: URL: https://github.com/apache/geode/pull/5172 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [geode] yozaner1324 closed pull request #5171: GEODE-8194 - Refactor Result type into geode-common for usage in othe…

yozaner1324 closed pull request #5171: URL: https://github.com/apache/geode/pull/5171 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [geode] lgtm-com[bot] commented on pull request #4871: GEODE-7864: Override the default implementation of write(byte[],int,int)

lgtm-com[bot] commented on pull request #4871: URL: https://github.com/apache/geode/pull/4871#issuecomment-634981031 This pull request **fixes 5 alerts** when merging 54c972f1bcd078f62f2cfe78fea4add1ce9016a2 into a185267dca016954f857f6848863bc4f74e6de81 - [view on

[GitHub] [geode] onichols-pivotal merged pull request #5173: GEODE-8083: Add API Checking to Geode. (#5066) (#5103)

onichols-pivotal merged pull request #5173: URL: https://github.com/apache/geode/pull/5173 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [geode] bschuchardt opened a new pull request #5172: GEODE-8144 another attempt to fix a failing test

bschuchardt opened a new pull request #5172: URL: https://github.com/apache/geode/pull/5172 The JMX tests in this test class use "localhost" to connect to a Manager. This is being transformed somehow into an IP numeric address and is failing endpoint verification. The test passes on

[GitHub] [geode] kohlmu-pivotal merged pull request #5170: 1.13 GEODE-8174: Fix ConcurrentModificationException when using JTA transaction.

kohlmu-pivotal merged pull request #5170: URL: https://github.com/apache/geode/pull/5170 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [geode] karensmolermiller commented on a change in pull request #5147: GEODE-8171: javadoc for putAll need to have accurate exception

karensmolermiller commented on a change in pull request #5147: URL: https://github.com/apache/geode/pull/5147#discussion_r431440863 ## File path: geode-core/src/main/java/org/apache/geode/cache/Region.java ## @@ -1362,49 +1362,77 @@ Object selectValue(String queryPredicate)

[GitHub] [geode] yozaner1324 opened a new pull request #5171: GEODE-8194 - Refactor Result type into geode-common for usage in othe…

yozaner1324 opened a new pull request #5171: URL: https://github.com/apache/geode/pull/5171 …r modules. Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken:

[GitHub] [geode] gesterzhou merged pull request #5147: GEODE-8171: javadoc for putAll need to have accurate exception

gesterzhou merged pull request #5147: URL: https://github.com/apache/geode/pull/5147 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [geode] gesterzhou commented on a change in pull request #5147: GEODE-8171: javadoc for putAll need to have accurate exception

gesterzhou commented on a change in pull request #5147: URL: https://github.com/apache/geode/pull/5147#discussion_r431450182 ## File path: geode-core/src/main/java/org/apache/geode/cache/Region.java ## @@ -1362,49 +1362,77 @@ Object selectValue(String queryPredicate) throws

[GitHub] [geode] rhoughton-pivot commented on a change in pull request #5115: Feature/GEODE-7414_2_redo

rhoughton-pivot commented on a change in pull request #5115: URL: https://github.com/apache/geode/pull/5115#discussion_r431420569 ## File path: geode-core/src/main/java/org/apache/geode/net/SSLParameterExtension.java ## @@ -29,9 +29,9 @@ /** * Initialize the

[GitHub] [geode-native] pivotal-jbarrett commented on a change in pull request #604: GEODE-8183: Update dockerfile versions

pivotal-jbarrett commented on a change in pull request #604: URL: https://github.com/apache/geode-native/pull/604#discussion_r431562733 ## File path: docker/Dockerfile ## @@ -41,15 +42,15 @@ RUN apt-get update && \ update-alternatives --install /usr/bin/clang-tidy

[GitHub] [geode-native] moleske commented on a change in pull request #604: GEODE-8183: Update dockerfile versions

moleske commented on a change in pull request #604: URL: https://github.com/apache/geode-native/pull/604#discussion_r431572960 ## File path: docker/Dockerfile ## @@ -41,15 +42,15 @@ RUN apt-get update && \ update-alternatives --install /usr/bin/clang-tidy

[GitHub] [geode-native] pivotal-jbarrett opened a new pull request #607: Wip/no ace stats

pivotal-jbarrett opened a new pull request #607: URL: https://github.com/apache/geode-native/pull/607 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [geode-native] pivotal-jbarrett opened a new pull request #606: GEODE-8181: Fixes default value for statistic-sampling-enabled.

pivotal-jbarrett opened a new pull request #606: URL: https://github.com/apache/geode-native/pull/606 GEODE-8181: Fixes default value for statistic-sampling-enabled. This is an automated message from the Apache Git Service.

[GitHub] [geode] kohlmu-pivotal merged pull request #5169: 1.12 - GEODE-8174: Fix ConcurrentModificationException when using JTA transaction.

kohlmu-pivotal merged pull request #5169: URL: https://github.com/apache/geode/pull/5169 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [geode] lgtm-com[bot] commented on pull request #5165: GEODE-8182: change String commands to use one region

lgtm-com[bot] commented on pull request #5165: URL: https://github.com/apache/geode/pull/5165#issuecomment-634494424 This pull request **fixes 1 alert** when merging 3b4c1cd9aef9ff1a13b5172c58ae56c93934af5e into bef07b34131abddb8c0f04e0ab6a48f1daac991d - [view on

[GitHub] [geode] mkevo commented on a change in pull request #5159: GEODE-7956: correct legal region names

mkevo commented on a change in pull request #5159: URL: https://github.com/apache/geode/pull/5159#discussion_r430875852 ## File path: geode-docs/basic_config/data_regions/region_naming.html.md.erb ## @@ -24,7 +24,7 @@ follow these region naming guidelines. - Permitted