[GitHub] [geode] kirklund commented on a change in pull request #5196: GEODE-8197: Add launcher acceptance testing for custom logging config

kirklund commented on a change in pull request #5196: URL: https://github.com/apache/geode/pull/5196#discussion_r436051212 ## File path: geode-assembly/src/acceptanceTest/java/org/apache/geode/launchers/LocatorLauncherWithPulseAcceptanceTest.java ## @@ -0,0 +1,113 @@ +/* + *

[GitHub] [geode] kirklund commented on a change in pull request #5196: GEODE-8197: Add launcher acceptance testing for custom logging config

kirklund commented on a change in pull request #5196: URL: https://github.com/apache/geode/pull/5196#discussion_r436051212 ## File path: geode-assembly/src/acceptanceTest/java/org/apache/geode/launchers/LocatorLauncherWithPulseAcceptanceTest.java ## @@ -0,0 +1,113 @@ +/* + *

[GitHub] [geode] jhutchison commented on a change in pull request #5216: Refactor set executor

jhutchison commented on a change in pull request #5216: URL: https://github.com/apache/geode/pull/5216#discussion_r436079328 ## File path: geode-redis/src/main/java/org/apache/geode/redis/internal/executor/string/SetExecutor.java ## @@ -68,72 +75,141 @@ private

[GitHub] [geode] jhutchison commented on a change in pull request #5216: Refactor set executor

jhutchison commented on a change in pull request #5216: URL: https://github.com/apache/geode/pull/5216#discussion_r436079564 ## File path: geode-redis/src/main/java/org/apache/geode/redis/internal/executor/string/SetExecutor.java ## @@ -68,72 +75,141 @@ private

[GitHub] [geode] jdeppe-pivotal commented on a change in pull request #5216: Refactor set executor

jdeppe-pivotal commented on a change in pull request #5216: URL: https://github.com/apache/geode/pull/5216#discussion_r436056100 ## File path: geode-redis/src/main/java/org/apache/geode/redis/internal/executor/string/SetExecutor.java ## @@ -68,72 +75,141 @@ private

[GitHub] [geode] davebarnes97 merged pull request #5203: GEODE-8186: UG add example for query --member option

davebarnes97 merged pull request #5203: URL: https://github.com/apache/geode/pull/5203 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [geode] jchen21 commented on a change in pull request #5196: GEODE-8197: Add launcher acceptance testing for custom logging config

jchen21 commented on a change in pull request #5196: URL: https://github.com/apache/geode/pull/5196#discussion_r436080693 ## File path: geode-assembly/src/acceptanceTest/java/org/apache/geode/launchers/LocatorLauncherWithPulseAndCustomLogConfigAcceptanceTest.java ## @@ -0,0

[GitHub] [geode] kirklund commented on a change in pull request #5208: GEODE-8173: Add unit test (coverage) for PartitionedRegionClear class.

kirklund commented on a change in pull request #5208: URL: https://github.com/apache/geode/pull/5208#discussion_r436075685 ## File path: geode-core/src/main/java/org/apache/geode/internal/cache/PartitionedRegion.java ## @@ -10269,4 +10269,8 @@ boolean

[GitHub] [geode] kirklund commented on a change in pull request #5188: GEODE-8099: add dlock around cms create/delete operations.

kirklund commented on a change in pull request #5188: URL: https://github.com/apache/geode/pull/5188#discussion_r436081052 ## File path: geode-core/src/integrationTest/java/org/apache/geode/distributed/internal/InternalLocatorClusterManagementServiceIntegrationTest.java ## @@

[GitHub] [geode] kirklund commented on a change in pull request #5196: GEODE-8197: Add launcher acceptance testing for custom logging config

kirklund commented on a change in pull request #5196: URL: https://github.com/apache/geode/pull/5196#discussion_r436186564 ## File path: geode-assembly/src/acceptanceTest/java/org/apache/geode/launchers/LocatorLauncherWithPulseAndCustomLogConfigAcceptanceTest.java ## @@ -0,0

[GitHub] [geode] rhoughton-pivot commented on pull request #5115: Feature/GEODE-7414_2_redo

rhoughton-pivot commented on pull request #5115: URL: https://github.com/apache/geode/pull/5115#issuecomment-639865821 Thanks everyone for sticking with this with me! This is an automated message from the Apache Git Service.

[GitHub] [geode] rhoughton-pivot merged pull request #5115: Feature/GEODE-7414_2_redo

rhoughton-pivot merged pull request #5115: URL: https://github.com/apache/geode/pull/5115 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [geode] davebarnes97 commented on a change in pull request #5214: GEODE-8223: Update documentation of expiration accuracy as well as supported, unsupported, and unimplemented commands in Redi

davebarnes97 commented on a change in pull request #5214: URL: https://github.com/apache/geode/pull/5214#discussion_r436181874 ## File path: geode-book/master_middleman/source/subnavs/geode-subnav.erb ## @@ -2197,6 +2197,9 @@ gfsh

[GitHub] [geode] kirklund commented on a change in pull request #5196: GEODE-8197: Add launcher acceptance testing for custom logging config

kirklund commented on a change in pull request #5196: URL: https://github.com/apache/geode/pull/5196#discussion_r436051212 ## File path: geode-assembly/src/acceptanceTest/java/org/apache/geode/launchers/LocatorLauncherWithPulseAcceptanceTest.java ## @@ -0,0 +1,113 @@ +/* + *

[GitHub] [geode] davebarnes97 commented on a change in pull request #5214: GEODE-8223: Update documentation of expiration accuracy as well as supported, unsupported, and unimplemented commands in Redi

davebarnes97 commented on a change in pull request #5214: URL: https://github.com/apache/geode/pull/5214#discussion_r436181874 ## File path: geode-book/master_middleman/source/subnavs/geode-subnav.erb ## @@ -2197,6 +2197,9 @@ gfsh

[GitHub] [geode] onichols-pivotal opened a new pull request #5217: GEODE-8230: run benchmarks in parallel with other CI jobs

onichols-pivotal opened a new pull request #5217: URL: https://github.com/apache/geode/pull/5217 before, we ran Build, then all Test jobs in parallel (which takes ~5 hours), then all Benchmark jobs (which takes ~5 hours). Presumably the benchmarks were run after all tests, on the

[GitHub] [geode-benchmarks] pivotal-jbarrett commented on a change in pull request #129: TLS SNI support via "withSniProxy" Option

pivotal-jbarrett commented on a change in pull request #129: URL: https://github.com/apache/geode-benchmarks/pull/129#discussion_r436179998 ## File path: geode-benchmarks/build.gradle ## @@ -23,16 +23,29 @@ version '1.0-SNAPSHOT' sourceCompatibility = 1.8 def outputDir =

[GitHub] [geode] mhansonp closed pull request #5195: GEODE-8095 create restore redundancy

mhansonp closed pull request #5195: URL: https://github.com/apache/geode/pull/5195 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [geode] agingade commented on a change in pull request #5208: GEODE-8173: Add unit test (coverage) for PartitionedRegionClear class.

agingade commented on a change in pull request #5208: URL: https://github.com/apache/geode/pull/5208#discussion_r436215854 ## File path: geode-core/src/test/java/org/apache/geode/internal/cache/PartitionedRegionClearTest.java ## @@ -0,0 +1,598 @@ +/* + * Licensed to the

[GitHub] [geode] agingade commented on a change in pull request #5208: GEODE-8173: Add unit test (coverage) for PartitionedRegionClear class.

agingade commented on a change in pull request #5208: URL: https://github.com/apache/geode/pull/5208#discussion_r436215906 ## File path: geode-core/src/test/java/org/apache/geode/internal/cache/PartitionedRegionClearTest.java ## @@ -0,0 +1,598 @@ +/* + * Licensed to the

[GitHub] [geode] jhutchison commented on a change in pull request #5216: Refactor set executor

jhutchison commented on a change in pull request #5216: URL: https://github.com/apache/geode/pull/5216#discussion_r436187614 ## File path: geode-redis/src/main/java/org/apache/geode/redis/internal/executor/string/SetExecutor.java ## @@ -68,72 +75,141 @@ private

[GitHub] [geode] jhutchison commented on a change in pull request #5216: Refactor set executor

jhutchison commented on a change in pull request #5216: URL: https://github.com/apache/geode/pull/5216#discussion_r436187466 ## File path: geode-redis/src/main/java/org/apache/geode/redis/internal/executor/string/SetExecutor.java ## @@ -68,72 +75,141 @@ private

[GitHub] [geode] davebarnes97 commented on a change in pull request #5214: GEODE-8223: Update documentation of expiration accuracy as well as supported, unsupported, and unimplemented commands in Redi

davebarnes97 commented on a change in pull request #5214: URL: https://github.com/apache/geode/pull/5214#discussion_r436178644 ## File path: geode-docs/tools_modules/redis_api_for_geode.html.md.erb ## @@ -60,30 +65,52 @@ If the server is functioning properly, you should see a

[GitHub] [geode] davebarnes97 commented on a change in pull request #5214: GEODE-8223: Update documentation of expiration accuracy as well as supported, unsupported, and unimplemented commands in Redi

davebarnes97 commented on a change in pull request #5214: URL: https://github.com/apache/geode/pull/5214#discussion_r436181874 ## File path: geode-book/master_middleman/source/subnavs/geode-subnav.erb ## @@ -2197,6 +2197,9 @@ gfsh

[GitHub] [geode] mhansonp commented on a change in pull request #5188: GEODE-8099: add dlock around cms create/delete operations.

mhansonp commented on a change in pull request #5188: URL: https://github.com/apache/geode/pull/5188#discussion_r436208620 ## File path: geode-core/src/integrationTest/java/org/apache/geode/distributed/internal/InternalLocatorClusterManagementServiceIntegrationTest.java ## @@

[GitHub] [geode] mhansonp commented on pull request #5195: GEODE-8095 create restore redundancy

mhansonp commented on pull request #5195: URL: https://github.com/apache/geode/pull/5195#issuecomment-639888115 Taking a different path. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [geode] DonalEvans commented on a change in pull request #5208: GEODE-8173: Add unit test (coverage) for PartitionedRegionClear class.

DonalEvans commented on a change in pull request #5208: URL: https://github.com/apache/geode/pull/5208#discussion_r436210405 ## File path: geode-core/src/test/java/org/apache/geode/internal/cache/PartitionedRegionClearTest.java ## @@ -0,0 +1,598 @@ +/* + * Licensed to the

[GitHub] [geode] davebarnes97 commented on a change in pull request #5214: GEODE-8223: Update documentation of expiration accuracy as well as supported, unsupported, and unimplemented commands in Redi

davebarnes97 commented on a change in pull request #5214: URL: https://github.com/apache/geode/pull/5214#discussion_r436178644 ## File path: geode-docs/tools_modules/redis_api_for_geode.html.md.erb ## @@ -60,30 +65,52 @@ If the server is functioning properly, you should see a

[GitHub] [geode-native] pivotal-jbarrett commented on pull request #613: GEODE-8227: Updates CMake to 3.16.8.

pivotal-jbarrett commented on pull request #613: URL: https://github.com/apache/geode-native/pull/613#issuecomment-639841096 > Is this to update the minimum required version also? Or just to get packer things updated? The Jira issue doesn't go into detail Little of both... The

[GitHub] [geode-native] moleske commented on pull request #613: GEODE-8227: Updates CMake to 3.16.8.

moleske commented on pull request #613: URL: https://github.com/apache/geode-native/pull/613#issuecomment-639842268 > Little of both... The current images have a really old CMake. There are some ACE removal branches that need newer CMake. Thanks for the information. My request

[GitHub] [geode] kirklund commented on a change in pull request #5196: GEODE-8197: Add launcher acceptance testing for custom logging config

kirklund commented on a change in pull request #5196: URL: https://github.com/apache/geode/pull/5196#discussion_r436186564 ## File path: geode-assembly/src/acceptanceTest/java/org/apache/geode/launchers/LocatorLauncherWithPulseAndCustomLogConfigAcceptanceTest.java ## @@ -0,0

[GitHub] [geode] kirklund commented on a change in pull request #5196: GEODE-8197: Add launcher acceptance testing for custom logging config

kirklund commented on a change in pull request #5196: URL: https://github.com/apache/geode/pull/5196#discussion_r436186564 ## File path: geode-assembly/src/acceptanceTest/java/org/apache/geode/launchers/LocatorLauncherWithPulseAndCustomLogConfigAcceptanceTest.java ## @@ -0,0

[GitHub] [geode-native] moleske commented on pull request #608: GEODE-8207: Enfore No Unknown Pragmas as Error

moleske commented on pull request #608: URL: https://github.com/apache/geode-native/pull/608#issuecomment-639911919 @pivotal-jbarrett I switched to definitions in config.h, but also spent a little time trying to figure out the correct way in cmake to detect those pragmas. I didn't

[GitHub] [geode] agingade commented on a change in pull request #5208: GEODE-8173: Add unit test (coverage) for PartitionedRegionClear class.

agingade commented on a change in pull request #5208: URL: https://github.com/apache/geode/pull/5208#discussion_r436214984 ## File path: geode-core/src/main/java/org/apache/geode/internal/cache/PartitionedRegion.java ## @@ -10269,4 +10269,8 @@ boolean

[GitHub] [geode] kirklund commented on a change in pull request #5182: GEODE-7591: Fix for hang in ClusterDistributionManager

kirklund commented on a change in pull request #5182: URL: https://github.com/apache/geode/pull/5182#discussion_r436033017 ## File path: geode-core/src/distributedTest/java/org/apache/geode/distributed/internal/ClusterDistributionManagerDUnitTest.java ## @@ -370,6 +371,33 @@

[GitHub] [geode-native] pdxcodemonkey merged pull request #612: GEODE-8210: Geode-native C++ userman - update serialization description

pdxcodemonkey merged pull request #612: URL: https://github.com/apache/geode-native/pull/612 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [geode] kirklund commented on pull request #5196: GEODE-8197: Add launcher acceptance testing for custom logging config

kirklund commented on pull request #5196: URL: https://github.com/apache/geode/pull/5196#issuecomment-639632632 Looks like Docker blew up in AcceptanceTest. Retriggering... This is an automated message from the Apache Git

[GitHub] [geode] alb3rtobr commented on pull request #5203: GEODE-8186: UG add example for query --member option

alb3rtobr commented on pull request #5203: URL: https://github.com/apache/geode/pull/5203#issuecomment-639396478 > @alb3rtobr Nice work. I have a small grammar edit and a larger proposal: let's add the example as a new topic under Advanced Querying. > Since I don't have permission to

[GitHub] [geode] jujoramos commented on a change in pull request #5099: GEODE-8029: Delete orphaned drf files (2nd try)

jujoramos commented on a change in pull request #5099: URL: https://github.com/apache/geode/pull/5099#discussion_r435872866 ## File path: geode-core/src/main/java/org/apache/geode/internal/cache/Oplog.java ## @@ -937,14 +937,21 @@ void initAfterRecovery(boolean offline) {

[GitHub] [geode-native] pdxcodemonkey commented on a change in pull request #612: GEODE-8210: Geode-native C++ userman - update serialization description

pdxcodemonkey commented on a change in pull request #612: URL: https://github.com/apache/geode-native/pull/612#discussion_r435418278 ## File path: docs/geode-native-docs-cpp/serialization/cpp-serialization/pdx-serializable-examples.html.md.erb ## @@ -0,0 +1,165 @@ +---

[GitHub] [geode] bschuchardt commented on a change in pull request #5182: GEODE-7591: Fix for hang in ClusterDistributionManager

bschuchardt commented on a change in pull request #5182: URL: https://github.com/apache/geode/pull/5182#discussion_r436001138 ## File path: geode-core/src/distributedTest/java/org/apache/geode/distributed/internal/ClusterDistributionManagerDUnitTest.java ## @@ -370,6 +371,33

[GitHub] [geode-native] moleske commented on pull request #613: GEODE-8227: Updates CMake to 3.16.8.

moleske commented on pull request #613: URL: https://github.com/apache/geode-native/pull/613#issuecomment-639600289 Is this to update the minimum required version also? Or just to get packer things updated? The Jira issue doesn't go into detail