[ pull request closed by kirklund ]
[ Full content available at: https://github.com/apache/geode/pull/2573 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
* Disconnect would wait until there was a system, then disconnect it.
Sometimes it would wait until the next test started a new instance, then
immediately disconnect it.
* Wait for the member to finish disconnecting before ending the test.
* Remove the listener at the end of the test, so that it
- There is a subtle, low-level networking issue on Windows. See here
https://stackoverflow.com/questions/52653506/udp-socket-binding-and-sending-behavior-on-windows-1709
and here
https://serverfault.com/questions/934207/socket-binding-and-sending-on-different-addresses
Thank you for submit
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the
commit message?
- [ ] Has y
[ pull request closed by jinmeiliao ]
[ Full content available at: https://github.com/apache/geode/pull/2567 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
[ pull request closed by bschuchardt ]
[ Full content available at: https://github.com/apache/geode/pull/2562 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the
commit message?
- [ ] Has y
we can change it to java 9+
[ Full content available at: https://github.com/apache/geode/pull/2567 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
It seems like the actual `checkPom` task is only examining ``
blocks and not any other data. So, on the one hand, the existing behavior was
"copy the actual pom to the expected pom" is what's happening, but a developer
will then need to examine which difference should actually be added to their
I had been poking at it to make sure it's still good. I was getting some
strange behavior where `./gradlew uEP` updates the assembly pom with
```
diff --git a/geode-assembly/src/test/resources/expected-pom.xml
b/geode-assembly/src/test/resources/expected-pom.xml
index 3f8abf5e57..b22bc8f393 1006
This branch started out as work on unit test coverage for RegionMapDestroy.
That test coverage has been checked in with a different pull request.
This pull request has the refactoring that was done while writing the unit
tests.
Thank you for submitting a contribution to Apache Geode.
In order to
… SAN in the certificate
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the
co
This is divided up into smaller commits:
GEODE-2644: Add LogWriterLevel enum and test
GEODE-2644: Cleanup LogLevel and expand LogLevelTest
GEODE-2644: Cleanup custom log4j2 config logging tests
GEODE-2644: Cleanup Marker Filter logging tests
GEODE-2644: Cleanup logging tests
GEODE-2644: Cleanup Al
I suppose it doesn't!
[ Full content available at: https://github.com/apache/geode/pull/2569 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
[ pull request closed by dschneider-pivotal ]
[ Full content available at: https://github.com/apache/geode/pull/2535 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Why does the expected file need to exist in order to update/place. We could use
this task to generate the baseline for a newly-minted module.
[ Full content available at: https://github.com/apache/geode/pull/2569 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
[ pull request closed by jchen21 ]
[ Full content available at: https://github.com/apache/geode/pull/2556 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
We have a lot of Awaitility calls in our tests. Each test was picking
its own timeout. That lead to some tests picking too small of a timeout
and failing spuriously.
With this change, all tests will use a new factory,
GeodeAwaility.await(), rather than Awaitility.await(). This new factory
sets a d
[ pull request closed by pivotal-jbarrett ]
[ Full content available at: https://github.com/apache/geode-native/pull/366 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
[ pull request closed by pivotal-eshu ]
[ Full content available at: https://github.com/apache/geode/pull/2571 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
[ pull request closed by mmartell ]
[ Full content available at: https://github.com/apache/geode-native/pull/369 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Do we really need to add this whitespace here and the next file. If not then
these two files would have no changes.
[ Full content available at: https://github.com/apache/geode-native/pull/369 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Will address this concern with additional dunit test.
[ Full content available at: https://github.com/apache/geode/pull/2571 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
txTracker.commitProcessReceived method no longer need distribution manager
anymore.
[ Full content available at: https://github.com/apache/geode/pull/2571 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
it would be better to just use the "distributionManager" parameter. At some
point we may find that this class no longer needs to keep a reference to the dm
in an instance field.
[ Full content available at: https://github.com/apache/geode/pull/2571 ]
This message was relayed via gitbox.apache.or
I think the old code was better that passed along the "dm" parameter.
[ Full content available at: https://github.com/apache/geode/pull/2571 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
@pivotal-jbarrett how's this look now?
[ Full content available at: https://github.com/apache/geode-native/pull/369 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
done.
[ Full content available at: https://github.com/apache/geode-native/pull/369 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
done.
[ Full content available at: https://github.com/apache/geode-native/pull/369 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
done.
[ Full content available at: https://github.com/apache/geode-native/pull/369 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
This is a partial conversion to using `CMAKE_DOTNET_TARGET_FRAMEWORK_VERSION` ,
there are some remaining csproj.in files belonging to `cli` test framework that
will be addressed in https://issues.apache.org/jira/browse/GEODE-5818 until
then we need both
[ Full content available at: https://git
[ pull request closed by sboorlagadda ]
[ Full content available at: https://github.com/apache/geode/pull/2565 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Remove GUID
[ Full content available at: https://github.com/apache/geode-native/pull/369 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
This is line should be deleted.
[ Full content available at: https://github.com/apache/geode-native/pull/369 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Remove GUID
[ Full content available at: https://github.com/apache/geode-native/pull/369 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
The project GUID should not be in here as each time the project is generated
the GUID will change.
[ Full content available at: https://github.com/apache/geode-native/pull/369 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
[ Full content available at: https://github.com/apache/geode-native/pull/369 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
38 matches
Mail list logo