@echobravopapa I see it more as a "C++11 all the things." Start setting some
precedence to prefer `using` over `typedef` since you can do fun things with
templates and scope better with `using`
[ Full content available at: https://github.com/apache/geode-native/pull/419 ]
This message was relay
nabarunnag opened a new pull request #24: GEODE-6131: Pass geode version as a
parameter.
URL: https://github.com/apache/geode-benchmarks/pull/24
* -PgeodeVersion in the gradle command with set the Apache Geode
version to run the benchmark with.
---
* -PgeodeVersion in the gradle command with set the Apache Geode
version to run the benchmark with.
[ Full content available at: https://github.com/apache/geode-benchmarks/pull/24
]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
nabarunnag opened a new pull request #23: GEODE-6180: Create unique results
folder.
URL: https://github.com/apache/geode-benchmarks/pull/23
* Create unique results folder with timestamp if default output file is
not set.
---
* Create unique results folder with timestamp if default output file is
not set.
[ Full content available at: https://github.com/apache/geode-benchmarks/pull/23
]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
nabarunnag opened a new pull request #22: GEODE-6181: Testname derieved from
the Class name.
URL: https://github.com/apache/geode-benchmarks/pull/22
* Removed name from TestConfig
* Test name derieved from the classname.
* Removed name from TestConfig
* Test name derieved from the classname.
[ Full content available at: https://github.com/apache/geode-benchmarks/pull/22
]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Thank you for submitting a contribution to Apache Geode.
@mcmellawatt
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the
commit messag
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the
commit message?
- [ ] Has y
Is there some reason that this can no longer be final? Looks like we still
instantiate and assign in-line.
[ Full content available at: https://github.com/apache/geode/pull/2978 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Again, is there now a restriction where this can no longer be final? If so, it
isn't obvious to me...
[ Full content available at: https://github.com/apache/geode/pull/2978 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
It looks like IntegrationTestOpenJDK8 failed with a failure I haven't seen
before. Not related to this PR, but may require filing a new Geode Jira...this
looks similar but not exactly the same, and was also resolved recently:
https://issues.apache.org/jira/browse/GEODE-3506
[ Full content avail
[ pull request closed by agingade ]
[ Full content available at: https://github.com/apache/geode/pull/2953 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
[ pull request closed by mcmellawatt ]
[ Full content available at: https://github.com/apache/geode/pull/2979 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
I was able to run all tests and all validations pass, but it isn't obvious to
me why we no longer need to mock PartitionedRegionHelper and instead are
mocking cache.createVMRegion(). Do you mind explaining just for my own
education?
[ Full content available at: https://github.com/apache/geode/
This PR consists of two commits. First commit refactors FunctionService so that
it is unit testable. Second commit removes PowerMock from the ExecuteFunction
unit tests.
```
commit edf7d3c65892e0c3b05fdf25c4c2bfb1cd2bf23a (HEAD ->
GEODE-6176-FunctionService-PowerMock,
kirklund-fork/GEODE-6176-F
Given this is involved in a PIMPL model association, I'm not convinced this
gains much... curious to hear thoughts...
[ Full content available at: https://github.com/apache/geode-native/pull/419 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
[ Full content available at: https://github.com/apache/geode-native/pull/419 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Setting some geode properties on all benchmarks to improve the performance and
enable additional statistics.
Refactoring the location of JVMParameters and the util package.
[ Full content available at: https://github.com/apache/geode-benchmarks/pull/21
]
This message was relayed via gitbox.apac
upthewaterspout opened a new pull request #21: GEODE-6172: Configure geode
properties for benchmarks
URL: https://github.com/apache/geode-benchmarks/pull/21
Setting some geode properties on all benchmarks to improve the performance
and enable additional statistics.
Refactoring the l
…onTest
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced in the
commit message?
-
Unrelated to this PR in particular, please either use a personal fork of Apache
Geode to branch and create PRs, or be diligent in the deletion of your branches
once this PR has been resolved. This goes for this PR, your other open PR, and
the now-three-months-closed PR #2503 against `feature/GE
* Upgraded the tests to use JUnit 5.3.2
* Restructed the gradle files.
[ Full content available at: https://github.com/apache/geode-benchmarks/pull/20
]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
nabarunnag opened a new pull request #20: GEODE-6138: Upgrade to JUnit 5
URL: https://github.com/apache/geode-benchmarks/pull/20
* Upgraded the tests to use JUnit 5.3.2
* Restructed the gradle files.
This is an au
Thank you for submitting a contribution to Apache Geode.
@mcmellawatt
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the
commit messag
[ pull request closed by echobravopapa ]
[ Full content available at: https://github.com/apache/geode-native/pull/415 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
We named it "ids" here because we know in the near future it will support
multiple column names instead of just one.
[ Full content available at: https://github.com/apache/geode/pull/2969 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
I think it is best for this constructor to just like you initialize everything.
This class represents a cache.xml element
[ Full content available at: https://github.com/apache/geode/pull/2969 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
will do
[ Full content available at: https://github.com/apache/geode/pull/2969 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
fixed.
[ Full content available at: https://github.com/apache/geode/pull/2979 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Typo in method name
[ Full content available at: https://github.com/apache/geode/pull/2979 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
…nd add
some test cases.
@mcmellawatt
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR?
It holds only one field name info; probably "id" instead of "ids".
[ Full content available at: https://github.com/apache/geode/pull/2969 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
How about overloaded RegionMapping constructor to avoid passing null.
[ Full content available at: https://github.com/apache/geode/pull/2969 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
- Updated the documentation to require building from top level examples/.
- Updated CMake files to preserve executable permissions on example startup and
shutdown scripts.
- Removed unnecessary work from the CMake files.
Co-authored-by: Ernest Burghardt
[ Full content available at: https://gith
* Replace homemade 'run' task with 'application' plugin
* Create 'jigsaw' directory to contain any other similar examples.
* Copy /cq example to /jigsaw/
Co-authored-by: Patrick Rhomberg
Co-authored-by: Jacob Barrett
[ Full content available at: https://github.com/apache/geode-examples/pull/74
spotlessApply needs to be run. That is why the build failed
[ Full content available at: https://github.com/apache/geode/pull/2918 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
[ pull request closed by dschneider-pivotal ]
[ Full content available at: https://github.com/apache/geode/pull/2954 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
[ pull request closed by dschneider-pivotal ]
[ Full content available at: https://github.com/apache/geode/pull/2575 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
closing until I get a chance to work on this again. The last state of this PR
was that it passed precheckin.
[ Full content available at: https://github.com/apache/geode/pull/2575 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
New commit has the requested changes.
[ Full content available at: https://github.com/apache/geode/pull/2953 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
[ pull request closed by pivotal-jbarrett ]
[ Full content available at: https://github.com/apache/geode-examples/pull/70 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
[ pull request closed by pivotal-jbarrett ]
[ Full content available at: https://github.com/apache/geode/pull/2931 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Also, minor cleanup to remove warnings and/or follow best practices.
[ Full content available at: https://github.com/apache/geode/pull/2978 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
[ pull request closed by balesh2 ]
[ Full content available at: https://github.com/apache/geode/pull/2964 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
inexactly is one word. Can you change this to
"givenColumnAndNonNullIdsThatDoesInexactlyMatchThenKeyColumnNameIsReturned"
[ Full content available at: https://github.com/apache/geode/pull/2969 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
46 matches
Mail list logo
