gesterzhou commented on a change in pull request #5434:
URL: https://github.com/apache/geode/pull/5434#discussion_r468348971
##
File path:
geode-wan/src/distributedTest/java/org/apache/geode/internal/cache/wan/parallel/ParallelWANPropagationLoopBackDUnitTest.java
##
@@ -433,6
gesterzhou commented on a change in pull request #5434:
URL: https://github.com/apache/geode/pull/5434#discussion_r468347041
##
File path:
geode-wan/src/main/java/org/apache/geode/internal/cache/wan/serial/SerialGatewaySenderImpl.java
##
@@ -111,6 +111,7 @@ private void start(
gesterzhou commented on a change in pull request #5434:
URL: https://github.com/apache/geode/pull/5434#discussion_r468346846
##
File path:
geode-wan/src/main/java/org/apache/geode/internal/cache/wan/parallel/ParallelGatewaySenderImpl.java
##
@@ -102,6 +102,7 @@ private void st
gesterzhou commented on a change in pull request #5434:
URL: https://github.com/apache/geode/pull/5434#discussion_r468346597
##
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/xmlcache/ParallelAsyncEventQueueCreation.java
##
@@ -43,13 +43,19 @@ public void
gesterzhou commented on a change in pull request #5434:
URL: https://github.com/apache/geode/pull/5434#discussion_r468346597
##
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/xmlcache/ParallelAsyncEventQueueCreation.java
##
@@ -43,13 +43,19 @@ public void
gesterzhou commented on a change in pull request #5434:
URL: https://github.com/apache/geode/pull/5434#discussion_r468341846
##
File path:
geode-core/src/main/java/org/apache/geode/cache/asyncqueue/internal/SerialAsyncEventQueueImpl.java
##
@@ -193,6 +194,7 @@ public void stop
gesterzhou commented on a change in pull request #5434:
URL: https://github.com/apache/geode/pull/5434#discussion_r468341654
##
File path:
geode-core/src/main/java/org/apache/geode/cache/asyncqueue/internal/SerialAsyncEventQueueImpl.java
##
@@ -117,6 +117,7 @@ private void sta
gesterzhou commented on a change in pull request #5434:
URL: https://github.com/apache/geode/pull/5434#discussion_r468341257
##
File path:
geode-core/src/main/java/org/apache/geode/cache/asyncqueue/internal/ParallelAsyncEventQueueImpl.java
##
@@ -110,6 +110,7 @@ private void s
gesterzhou commented on a change in pull request #5434:
URL: https://github.com/apache/geode/pull/5434#discussion_r468341467
##
File path:
geode-core/src/main/java/org/apache/geode/cache/asyncqueue/internal/ParallelAsyncEventQueueImpl.java
##
@@ -139,6 +140,7 @@ public void st
jdeppe-pivotal merged pull request #5441:
URL: https://github.com/apache/geode/pull/5441
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
DonalEvans opened a new pull request #5443:
URL: https://github.com/apache/geode/pull/5443
Authored-by: Donal Evans
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have b
masaki-yamakawa opened a new pull request #5442:
URL: https://github.com/apache/geode/pull/5442
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For al
dschneider-pivotal opened a new pull request #5441:
URL: https://github.com/apache/geode/pull/5441
The fix for GEODE-8393 seems to have caused both GEODE-8417 and GEODE-8418.
This revert should fix those new issues.
This reverts commit 0a91484b05f1caffa8cc3a59cc7fc38abe4376ed.
rhoughton-pivot merged pull request #5440:
URL: https://github.com/apache/geode/pull/5440
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
Bill edited a comment on pull request #5409:
URL: https://github.com/apache/geode/pull/5409#issuecomment-667208641
sorry about the confusion @bschuchardt…
I had to revert due to test failures in proprietary code. No changes were
needed to this code, as it turns out. But it's taken me
rhoughton-pivot opened a new pull request #5440:
URL: https://github.com/apache/geode/pull/5440
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For al
karensmolermiller merged pull request #5437:
URL: https://github.com/apache/geode/pull/5437
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
demery-pivotal opened a new pull request #5439:
URL: https://github.com/apache/geode/pull/5439
Do not enable `SO_REUSEADDR` when binding a socket to an ephemeral port.
On some operating systems, enabling `SO_REUSEADDR` when binding to an
ephemeral port allows the system to chose a po
rhoughton-pivot merged pull request #5438:
URL: https://github.com/apache/geode/pull/5438
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
sabbeyPivotal removed a comment on pull request #5438:
URL: https://github.com/apache/geode/pull/5438#issuecomment-671573159
@smgoller @rhoughton-pivot @onichols-pivotal @dickcav
This is an automated message from the Apache G
sabbeyPivotal commented on pull request #5438:
URL: https://github.com/apache/geode/pull/5438#issuecomment-671573159
@smgoller @rhoughton-pivot @onichols-pivotal @dickcav
This is an automated message from the Apache Git Servi
sabbeyPivotal opened a new pull request #5438:
URL: https://github.com/apache/geode/pull/5438
Include more .tcl files in the Redis Tests CI job
This is an automated message from the Apache Git Service.
To respond to the messa
jdeppe-pivotal merged pull request #5431:
URL: https://github.com/apache/geode/pull/5431
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
dschneider-pivotal merged pull request #5429:
URL: https://github.com/apache/geode/pull/5429
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
lgtm-com[bot] commented on pull request #5390:
URL: https://github.com/apache/geode/pull/5390#issuecomment-671500760
This pull request **introduces 2 alerts** and **fixes 2** when merging
c572e6dcb5ab2f73dd069eb697442ddb96906876 into
6a08bba48a92db682a3443b9ce47b44796cb4ab1 - [view on
LGT
albertogpz commented on a change in pull request #5348:
URL: https://github.com/apache/geode/pull/5348#discussion_r467116996
##
File path:
geode-core/src/main/java/org/apache/geode/management/internal/configuration/functions/GatewaySenderManageFunction.java
##
@@ -0,0 +1,148 @
karensmolermiller opened a new pull request #5437:
URL: https://github.com/apache/geode/pull/5437
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
jujoramos commented on pull request #5175:
URL: https://github.com/apache/geode/pull/5175#issuecomment-671321433
The `DescribeOfflineDiskStoreCommand` class calls
`DiskStoreImpl.dumpInfo()`, which has an instance of the `DiskStoreImpl` class,
it can be used directly to call `close()`, see
mkevo commented on pull request #5175:
URL: https://github.com/apache/geode/pull/5175#issuecomment-671311587
> Sure, can you point me exactly to which commands you're referring here?.
The original ticket
([GEODE-8119](https://issues.apache.org/jira/browse/GEODE-8119)) doesn't
mention whic
jujoramos commented on pull request #5175:
URL: https://github.com/apache/geode/pull/5175#issuecomment-671309686
Sure, can you point me exactly to which commands you're referring here?. The
original ticket
([GEODE-8119](https://issues.apache.org/jira/browse/GEODE-8119)) doesn't
mention wh
mkevo commented on pull request #5175:
URL: https://github.com/apache/geode/pull/5175#issuecomment-671299214
> @mkevo
> Thanks for adding the extra tests. I'm not fully convinced about the
implemented fix, however, did you consider my comments
[here](https://github.com/apache/geode/pull
31 matches
Mail list logo