[GitHub] [geode-examples] sboorlagadda merged pull request #116: GitHub Action runAll Pipeline
sboorlagadda merged PR #116: URL: https://github.com/apache/geode-examples/pull/116 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode-site] sboorlagadda merged pull request #21: GEODE-10437: Migrate to GH Action
sboorlagadda merged PR #21: URL: https://github.com/apache/geode-site/pull/21 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] CalvinKirs commented on pull request #7869: Fix compile error in jdk11 due to toArray confusion
CalvinKirs commented on PR #7869: URL: https://github.com/apache/geode/pull/7869#issuecomment-1325917512 > According to the OpenJDK website: https://adoptopenjdk.net/support.html there are 3 TLS versions for now  So, I think we should make a plan to support compiled on JDK11 and 17. hi, @sboorlagadda WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] dschneider-pivotal closed pull request #6036: GEODE-8856: Persist gateway-sender startup-action
dschneider-pivotal closed pull request #6036: GEODE-8856: Persist gateway-sender startup-action URL: https://github.com/apache/geode/pull/6036 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] ruanwenjun commented on pull request #7869: Fix compile error in jdk11 due to toArray confusion
ruanwenjun commented on PR #7869: URL: https://github.com/apache/geode/pull/7869#issuecomment-1323562848 > @ruanwenjun as of now Geode is compiled using JDK8, while many users run geode using 8, 11 and 17 Yes, does `Geode` plan to support compiled on JDK11 :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] sboorlagadda commented on pull request #7869: Fix compile error in jdk11 due to toArray confusion
sboorlagadda commented on PR #7869: URL: https://github.com/apache/geode/pull/7869#issuecomment-132224 @ruanwenjun as of now Geode is compiled using JDK8, while many users run geode using 8, 11 and 17 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] sboorlagadda opened a new pull request, #7870: Draft: GHA
sboorlagadda opened a new pull request, #7870: URL: https://github.com/apache/geode/pull/7870 ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [ ] Is your initial contribution a single, squashed commit? - [ ] Does `gradlew build` run cleanly? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] ruanwenjun opened a new pull request, #7869: Fix compile error in jdk11 due to toArray confusion
ruanwenjun opened a new pull request, #7869:
URL: https://github.com/apache/geode/pull/7869
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in
the commit message?
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
When I compile with jdk11, I got an error below:
https://user-images.githubusercontent.com/22415594/201882997-2f20030f-132d-44c7-b81e-83f0f671af09.png;>
This is caused by we have two `toArray` in `PartitionedRegion`,
one is
```
public Object[] toArray(Object[] array)
```
other is from `Collection` which is introduced in jdk 11.
```java
default T[] toArray(IntFunction generator) {
return toArray(generator.apply(0));
}
```
This PR aims to fix this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [geode] mivanac closed pull request #7862: GEODE-10424: introduce ExtendedReplyMessage, and prepare impacts
mivanac closed pull request #7862: GEODE-10424: introduce ExtendedReplyMessage, and prepare impacts URL: https://github.com/apache/geode/pull/7862 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] mivanac closed pull request #7866: GEODE-10425: add new option
mivanac closed pull request #7866: GEODE-10425: add new option URL: https://github.com/apache/geode/pull/7866 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode-native] gaussianrecurrence closed pull request #987: [WIP] GEODE-10429: Setup GitHub actions
gaussianrecurrence closed pull request #987: [WIP] GEODE-10429: Setup GitHub actions URL: https://github.com/apache/geode-native/pull/987 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode-native] gaussianrecurrence opened a new pull request, #987: [WIP] GEODE-10429: Setup GitHub actions
gaussianrecurrence opened a new pull request, #987: URL: https://github.com/apache/geode-native/pull/987 - Testing GHCR container packages -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode-native] onichols-pivotal opened a new pull request, #986: GEODE-10401: Bump Geode version to 1.15.1
onichols-pivotal opened a new pull request, #986: URL: https://github.com/apache/geode-native/pull/986 Native client hardcodes Geode version to test with in several places. Update those variables to latest-and-greatest apache-geode 1.15.1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] onichols-pivotal opened a new pull request, #7868: GEODE-10401: Replace 1.15.0 with 1.15.1 as old version
onichols-pivotal opened a new pull request, #7868: URL: https://github.com/apache/geode/pull/7868 Replace 1.15.0 with 1.15.1 in old versions and set as default Benchmarks baseline on develop to enable rolling upgrade tests from 1.15.1 The serialization version has not changed between 1.15.0 and 1.15.1, so there should be no need to keep both -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] albertogpz merged pull request #7861: GEODE-10423: Document the system property “ON_DISCONNECT_CLEAR_PDXTYP…
albertogpz merged PR #7861: URL: https://github.com/apache/geode/pull/7861 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] wabp2005 commented on a diff in pull request #7861: GEODE-10423: Document the system property “ON_DISCONNECT_CLEAR_PDXTYP…
wabp2005 commented on code in PR #7861: URL: https://github.com/apache/geode/pull/7861#discussion_r990571610 ## geode-docs/developing/data_serialization/PDX_Serialization_Features.html.md.erb: ## @@ -44,19 +45,10 @@ If old clients write entries of a PDX type they know but the central registry do To avoid this problem, clients may be configured with the system property in the table below to clear their PDX type cache when they disconnect from the cluster. After clearing their cache, old clients will re-generate type information for all PDX types, including the types the central registry "forgot". Since new PDX type information will be written in the central registry before entries of that type are written in the cluster, the central registry and all clients, old and new, will store consistent PDX type information. -| Name | Description | Default | -|---|-|-| -| `gemfire.ON_DISCONNECT_CLEAR_PDXTYPEIDS` | Clear pdxType ids when client disconnects from servers. | `false` | -- In the API, set the System properties before the cache creation call. Example: - -``` pre -System.setProperty(PoolImpl.ON_DISCONNECT_CLEAR_PDXTYPEIDS, "true"); -``` -- At the java command line, pass in System properties using the -D switch. Example: - -``` pre -java -Dgemfire.ON_DISCONNECT_CLEAR_PDXTYPEIDS=true -``` +| Name | Default | Applies to (Java Client, Native Client)| Review Comment: done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] dependabot[bot] opened a new pull request, #7867: Bump addressable from 2.7.0 to 2.8.1 in /geode-book
dependabot[bot] opened a new pull request, #7867: URL: https://github.com/apache/geode/pull/7867 Bumps [addressable](https://github.com/sporkmonger/addressable) from 2.7.0 to 2.8.1. Changelog Sourced from https://github.com/sporkmonger/addressable/blob/main/CHANGELOG.md;>addressable's changelog. Addressable 2.8.1 refactor Addressable::URI.normalize_path to address linter offenses (https://github-redirect.dependabot.com/sporkmonger/addressable/pull/430;>#430) remove redundant colon in Addressable::URI::CharacterClasses::AUTHORITY regex (https://github-redirect.dependabot.com/sporkmonger/addressable/pull/438;>#438) update gemspec to reflect supported Ruby versions (https://github-redirect.dependabot.com/sporkmonger/addressable/issues/466;>#466, https://github-redirect.dependabot.com/sporkmonger/addressable/issues/464;>#464, https://github-redirect.dependabot.com/sporkmonger/addressable/issues/463;>#463) compatibility w/ public_suffix 5.x (https://github-redirect.dependabot.com/sporkmonger/addressable/issues/466;>#466, https://github-redirect.dependabot.com/sporkmonger/addressable/issues/465;>#465, https://github-redirect.dependabot.com/sporkmonger/addressable/issues/460;>#460) fixes invalid byte sequence in UTF-8 exception when unencoding URLs containing non UTF-8 characters (https://github-redirect.dependabot.com/sporkmonger/addressable/pull/459;>#459) Ractor compatibility (https://github-redirect.dependabot.com/sporkmonger/addressable/pull/449;>#449) use the whole string instead of a single line for template match (https://github-redirect.dependabot.com/sporkmonger/addressable/pull/431;>#431) force UTF-8 encoding only if needed (https://github-redirect.dependabot.com/sporkmonger/addressable/pull/341;>#341) https://github-redirect.dependabot.com/sporkmonger/addressable/issues/460;>#460: https://github-redirect.dependabot.com/sporkmonger/addressable/pull/460;>sporkmonger/addressable#460 https://github-redirect.dependabot.com/sporkmonger/addressable/issues/463;>#463: https://github-redirect.dependabot.com/sporkmonger/addressable/pull/463;>sporkmonger/addressable#463 https://github-redirect.dependabot.com/sporkmonger/addressable/issues/464;>#464: https://github-redirect.dependabot.com/sporkmonger/addressable/pull/464;>sporkmonger/addressable#464 https://github-redirect.dependabot.com/sporkmonger/addressable/issues/465;>#465: https://github-redirect.dependabot.com/sporkmonger/addressable/pull/465;>sporkmonger/addressable#465 https://github-redirect.dependabot.com/sporkmonger/addressable/issues/466;>#466: https://github-redirect.dependabot.com/sporkmonger/addressable/pull/466;>sporkmonger/addressable#466 Addressable 2.8.0 fixes ReDoS vulnerability in Addressable::Template#match no longer replaces + with spaces in queries for non-http(s) schemes fixed encoding ipv6 literals the :compacted flag for normalized_query now dedupes parameters fix broken escape_component alias dropping support for Ruby 2.0 and 2.1 adding Ruby 3.0 compatibility for development tasks drop support for rack-mount and remove Addressable::Template#generate performance improvements switch CI/CD to GitHub Actions Commits https://github.com/sporkmonger/addressable/commit/8657465b438d93c707aff4346fdcf74c742b4a53;>8657465 Update version, gemspec, and CHANGELOG for 2.8.1 (https://github-redirect.dependabot.com/sporkmonger/addressable/issues/474;>#474) https://github.com/sporkmonger/addressable/commit/4fc5bb6eee91d49c2f3ed7e6f060aa32e2c5929b;>4fc5bb6 CI: remove Ubuntu 18.04 job (https://github-redirect.dependabot.com/sporkmonger/addressable/issues/473;>#473) https://github.com/sporkmonger/addressable/commit/860fede2984a6ce0551e43db68262a2ec7705914;>860fede Force UTF-8 encoding only if needed (https://github-redirect.dependabot.com/sporkmonger/addressable/issues/341;>#341) https://github.com/sporkmonger/addressable/commit/99810afbd2313a550b812c512a27e99a1f376b87;>99810af Merge pull request https://github-redirect.dependabot.com/sporkmonger/addressable/issues/431;>#431 from ojab/ct-_do_not_parse_multiline_strings https://github.com/sporkmonger/addressable/commit/7ce0f485021d6ff629f0d97c5ec656636d853876;>7ce0f48 Merge branch 'main' into ct-_do_not_parse_multiline_strings https://github.com/sporkmonger/addressable/commit/7ecf75146c1a53b089150ccc33c909214d728323;>7ecf751 Merge pull request https://github-redirect.dependabot.com/sporkmonger/addressable/issues/449;>#449 from okeeblow/freeze_concatenated_strings https://github.com/sporkmonger/addressable/commit/41f12dd5a04a4bc0d5e9fc89ff538869581dbb34;>41f12dd Merge branch 'main' into freeze_concatenated_strings https://github.com/sporkmonger/addressable/commit/068f673a46ef69f7a72ff0f5d3ab972abc626a25;>068f673 Merge pull request https://github-redirect.dependabot.com/sporkmonger/addressable/issues/459;>#459 from
[GitHub] [geode-native] albertogpz merged pull request #985: GEODE-10426: Add option to toggle doc generation
albertogpz merged PR #985: URL: https://github.com/apache/geode-native/pull/985 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode-native] gaussianrecurrence opened a new pull request, #985: GEODE-10426: Add option to toggle doc generation
gaussianrecurrence opened a new pull request, #985: URL: https://github.com/apache/geode-native/pull/985 - Added a option in the CMake project to enable documentation generation. - In order to maintain backward compatibility, by default documentation generation is enabled. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode-native] gaussianrecurrence commented on pull request #968: GEODE-10291: Add ubuntu 22.04 (jammy) to CI
gaussianrecurrence commented on PR #968: URL: https://github.com/apache/geode-native/pull/968#issuecomment-1265076566 Hi @moleske & @pivotal-jbarrett, it seems to me that @moleke addressed all the comments, so I am not sure is this can be merged already? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] albertogpz commented on a diff in pull request #7861: GEODE-10423: Document the system property “ON_DISCONNECT_CLEAR_PDXTYP…
albertogpz commented on code in PR #7861: URL: https://github.com/apache/geode/pull/7861#discussion_r984297792 ## geode-docs/developing/data_serialization/PDX_Serialization_Features.html.md.erb: ## @@ -44,19 +45,10 @@ If old clients write entries of a PDX type they know but the central registry do To avoid this problem, clients may be configured with the system property in the table below to clear their PDX type cache when they disconnect from the cluster. After clearing their cache, old clients will re-generate type information for all PDX types, including the types the central registry "forgot". Since new PDX type information will be written in the central registry before entries of that type are written in the cluster, the central registry and all clients, old and new, will store consistent PDX type information. -| Name | Description | Default | -|---|-|-| -| `gemfire.ON_DISCONNECT_CLEAR_PDXTYPEIDS` | Clear pdxType ids when client disconnects from servers. | `false` | -- In the API, set the System properties before the cache creation call. Example: - -``` pre -System.setProperty(PoolImpl.ON_DISCONNECT_CLEAR_PDXTYPEIDS, "true"); -``` -- At the java command line, pass in System properties using the -D switch. Example: - -``` pre -java -Dgemfire.ON_DISCONNECT_CLEAR_PDXTYPEIDS=true -``` +| Name | Default | Applies to (Java Client, Native Client)| Review Comment: Suggestion: instead of "Applies to (Java Client, Native Client" use "Client type". -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] wabp2005 commented on a diff in pull request #7861: GEODE-10423: Document the system property “ON_DISCONNECT_CLEAR_PDXTYP…
wabp2005 commented on code in PR #7861:
URL: https://github.com/apache/geode/pull/7861#discussion_r984280585
##
geode-docs/developing/data_serialization/PDX_Serialization_Features.html.md.erb:
##
@@ -31,6 +31,33 @@ When you serialize an object using PDX,
<%=vars.product_name%> stores the object
This centralization of object type information is advantageous for
client/server installations in which clients and servers are written in
different languages. Clients pass registry information to servers automatically
when they store a PDX serialized object. Clients can run queries and functions
against the data in the servers without compatibility between server and the
stored objects. One client can store data on the server to be retrieved by
another client, with no requirements on the part of the server.
+**Note:**
+There are situations where some of the information in the central registry of
the PDX domain object metadata is lost, e.g. when restoring an old backup with
an outdated central registry.
+
+When that happens, new clients connecting to the cluster for the first time
will get outdated PDX type information from the central registry, but, since
information in the central registry is cached by clients, old clients may have
fresher information about PDX types than the central registry does. That will
result into inconsistent information about PDX types spread across the system:
+
+- old clients have fresh information
+- the central registry has outdated information
+- new clients have outdated information
+
+If old clients write entries of a PDX type they know but the central registry
doesn't, new clients will get "Unknown PDX type" errors when they read those
objects.
+
+To avoid this problem, clients may be configured with the system property in
the table below to clear their PDX type cache when they disconnect from the
cluster. After clearing their cache, old clients will re-generate type
information for all PDX types, including the types the central registry
"forgot". Since new PDX type information will be written in the central
registry before entries of that type are written in the cluster, the central
registry and all clients, old and new, will store consistent PDX type
information.
+
+| Name | Description
| Default |
+|---|-|-|
+| `gemfire.ON_DISCONNECT_CLEAR_PDXTYPEIDS` | Clear pdxType ids when client
disconnects from servers. | `false` |
+- In the API, set the System properties before the cache creation call.
Example:
+
+``` pre
+System.setProperty(PoolImpl.ON_DISCONNECT_CLEAR_PDXTYPEIDS, "true");
+```
+- At the java command line, pass in System properties using the -D switch.
Example:
+
+``` pre
+java -Dgemfire.ON_DISCONNECT_CLEAR_PDXTYPEIDS=true
+```
+
Review Comment:
Regarding Java client, there are two kinds of properties:
- GemFire Properties, user can define this kind of properties either in
gemfire.properties file or programmatically (such as:
clientCacheFactory.set(key, value)).
- GemFire System Properties, user can only define this kind properties by
setting Java System Properties.
The property `gemfire.ON_DISCONNECT_CLEAR_PDXTYPEIDS` is the Java System
Property, it cannot be set with API or in file `gemfire.properties`, so I think
this property should not be added in the `gemfire_properties.html`, since they
have the different way to be set, it would make user confused.
But regarding the native client, there is only one way to set properties,
all the properties could be found in `apache::geode::client::SystemProperties`,
and the properties could be define either programmatically (such as:
`CacheFactory().set("on-client-disconnect-clear-pdxType-Ids", "true")`
) or in a geode.properties file, so I suggest that we only list the
property here, but not include how to set it, how do you think?
I have pushed the new change, please take a look at it ,thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [geode] mivanac closed pull request #7841: GEODE-10339: Configurable IF file compaction mode
mivanac closed pull request #7841: GEODE-10339: Configurable IF file compaction mode URL: https://github.com/apache/geode/pull/7841 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] mivanac opened a new pull request, #7866: GEODE-10425: add new option
mivanac opened a new pull request, #7866: URL: https://github.com/apache/geode/pull/7866 ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [ ] Is your initial contribution a single, squashed commit? - [ ] Does `gradlew build` run cleanly? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] albertogpz opened a new pull request, #7865: [DRAFT DO NOT REVIEW] Wip limit max threads to server
albertogpz opened a new pull request, #7865: URL: https://github.com/apache/geode/pull/7865 ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [ ] Is your initial contribution a single, squashed commit? - [ ] Does `gradlew build` run cleanly? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] albertogpz closed pull request #7864: [DRAFT DO NOT REVIEW] Limit the number of threads to destinations
albertogpz closed pull request #7864: [DRAFT DO NOT REVIEW] Limit the number of threads to destinations URL: https://github.com/apache/geode/pull/7864 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] albertogpz opened a new pull request, #7864: [DRAFT DO NOT REVIEW] Limit the number of threads to destinations
albertogpz opened a new pull request, #7864: URL: https://github.com/apache/geode/pull/7864 ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [ ] Is your initial contribution a single, squashed commit? - [ ] Does `gradlew build` run cleanly? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] albertogpz commented on a diff in pull request #7861: GEODE-10423: Document the system property “ON_DISCONNECT_CLEAR_PDXTYP…
albertogpz commented on code in PR #7861: URL: https://github.com/apache/geode/pull/7861#discussion_r983280085 ## geode-docs/developing/data_serialization/PDX_Serialization_Features.html.md.erb: ## @@ -31,6 +31,33 @@ When you serialize an object using PDX, <%=vars.product_name%> stores the object This centralization of object type information is advantageous for client/server installations in which clients and servers are written in different languages. Clients pass registry information to servers automatically when they store a PDX serialized object. Clients can run queries and functions against the data in the servers without compatibility between server and the stored objects. One client can store data on the server to be retrieved by another client, with no requirements on the part of the server. +**Note:** +There are situations where some of the information in the central registry of the PDX domain object metadata is lost, e.g. when restoring an old backup with an outdated central registry. + +When that happens, new clients connecting to the cluster for the first time will get outdated PDX type information from the central registry, but, since information in the central registry is cached by clients, old clients may have fresher information about PDX types than the central registry does. That will result into inconsistent information about PDX types spread across the system: + +- old clients have fresh information +- the central registry has outdated information +- new clients have outdated information + +If old clients write entries of a PDX type they know but the central registry doesn't, new clients will get "Unknown PDX type" errors when they read those objects. + +To avoid this problem, clients may be configured with the system property in the table below to clear their PDX type cache when they disconnect from the cluster. After clearing their cache, old clients will re-generate type information for all PDX types, including the types the central registry "forgot". Since new PDX type information will be written in the central registry before entries of that type are written in the cluster, the central registry and all clients, old and new, will store consistent PDX type information. + +| Name | Description | Default | +|---|-|-| +| `gemfire.ON_DISCONNECT_CLEAR_PDXTYPEIDS` | Clear pdxType ids when client disconnects from servers. | `false` | +- In the API, set the System properties before the cache creation call. Example: + +``` pre +System.setProperty(PoolImpl.ON_DISCONNECT_CLEAR_PDXTYPEIDS, "true"); +``` +- At the java command line, pass in System properties using the -D switch. Example: + +``` pre +java -Dgemfire.ON_DISCONNECT_CLEAR_PDXTYPEIDS=true +``` + Review Comment: It would probably be better to add this variable and description to the corresponding documents of the Java and Native clients: https://geode.apache.org/docs/geode-native/cpp/115/configuring/sysprops.html https://geode.apache.org/docs/guide/115/reference/topics/gemfire_properties.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] albertogpz commented on a diff in pull request #7861: GEODE-10423: Document the system property “ON_DISCONNECT_CLEAR_PDXTYP…
albertogpz commented on code in PR #7861: URL: https://github.com/apache/geode/pull/7861#discussion_r983275654 ## geode-docs/developing/data_serialization/PDX_Serialization_Features.html.md.erb: ## @@ -31,6 +31,33 @@ When you serialize an object using PDX, <%=vars.product_name%> stores the object This centralization of object type information is advantageous for client/server installations in which clients and servers are written in different languages. Clients pass registry information to servers automatically when they store a PDX serialized object. Clients can run queries and functions against the data in the servers without compatibility between server and the stored objects. One client can store data on the server to be retrieved by another client, with no requirements on the part of the server. +**Note:** Review Comment: I suggest to add a new line after the Note so that it is clear that the contents of the note are several paragraphs and not only the first one. ## geode-docs/developing/data_serialization/PDX_Serialization_Features.html.md.erb: ## @@ -31,6 +31,33 @@ When you serialize an object using PDX, <%=vars.product_name%> stores the object This centralization of object type information is advantageous for client/server installations in which clients and servers are written in different languages. Clients pass registry information to servers automatically when they store a PDX serialized object. Clients can run queries and functions against the data in the servers without compatibility between server and the stored objects. One client can store data on the server to be retrieved by another client, with no requirements on the part of the server. +**Note:** +There are situations where some of the information in the central registry of the PDX domain object metadata is lost, e.g. when restoring an old backup with an outdated central registry. + +When that happens, new clients connecting to the cluster for the first time will get outdated PDX type information from the central registry, but, since information in the central registry is cached by clients, old clients may have fresher information about PDX types than the central registry does. That will result into inconsistent information about PDX types spread across the system: + +- old clients have fresh information +- the central registry has outdated information +- new clients have outdated information + +If old clients write entries of a PDX type they know but the central registry doesn't, new clients will get "Unknown PDX type" errors when they read those objects. + +To avoid this problem, clients may be configured with the system property in the table below to clear their PDX type cache when they disconnect from the cluster. After clearing their cache, old clients will re-generate type information for all PDX types, including the types the central registry "forgot". Since new PDX type information will be written in the central registry before entries of that type are written in the cluster, the central registry and all clients, old and new, will store consistent PDX type information. + +| Name | Description | Default | +|---|-|-| +| `gemfire.ON_DISCONNECT_CLEAR_PDXTYPEIDS` | Clear pdxType ids when client disconnects from servers. | `false` | +- In the API, set the System properties before the cache creation call. Example: + +``` pre +System.setProperty(PoolImpl.ON_DISCONNECT_CLEAR_PDXTYPEIDS, "true"); +``` +- At the java command line, pass in System properties using the -D switch. Example: + +``` pre +java -Dgemfire.ON_DISCONNECT_CLEAR_PDXTYPEIDS=true +``` + Review Comment: I would not include here how to set the variable in the different clients. Otherwise, you would also have to add the way to set the property in the native client. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] wabp2005 commented on a diff in pull request #7861: GEODE-10423: Document the system property “ON_DISCONNECT_CLEAR_PDXTYP…
wabp2005 commented on code in PR #7861: URL: https://github.com/apache/geode/pull/7861#discussion_r983108512 ## geode-docs/developing/data_serialization/PDX_Serialization_Features.html.md.erb: ## @@ -31,6 +31,31 @@ When you serialize an object using PDX, <%=vars.product_name%> stores the object This centralization of object type information is advantageous for client/server installations in which clients and servers are written in different languages. Clients pass registry information to servers automatically when they store a PDX serialized object. Clients can run queries and functions against the data in the servers without compatibility between server and the stored objects. One client can store data on the server to be retrieved by another client, with no requirements on the part of the server. +**Note:** +In some cases pdx registry may be lost, the cases include but not limited to the following: + +- A backup was restored, and such backup is missing pdx registry. Review Comment: Hi Miguel, thanks for your comment, I have pushed the new commit according to your suggestion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] miguelmt commented on a diff in pull request #7861: GEODE-10423: Document the system property “ON_DISCONNECT_CLEAR_PDXTYP…
miguelmt commented on code in PR #7861: URL: https://github.com/apache/geode/pull/7861#discussion_r982291787 ## geode-docs/developing/data_serialization/PDX_Serialization_Features.html.md.erb: ## @@ -31,6 +31,31 @@ When you serialize an object using PDX, <%=vars.product_name%> stores the object This centralization of object type information is advantageous for client/server installations in which clients and servers are written in different languages. Clients pass registry information to servers automatically when they store a PDX serialized object. Clients can run queries and functions against the data in the servers without compatibility between server and the stored objects. One client can store data on the server to be retrieved by another client, with no requirements on the part of the server. +**Note:** +In some cases pdx registry may be lost, the cases include but not limited to the following: + +- A backup was restored, and such backup is missing pdx registry. Review Comment: In my opinion, the scenarios where the central registry of the PDX domain object metadata are lost but the contents of the database remain unaffected are unlikely. The proposed change (gemfire.ON_DISCONNECT_CLEAR_PDXTYPEIDS system property) would not fix such use cases, or, to be precise, would not fix them _completely_: if a new client reads an object of a PDX type that's missing from the central registry, it would still get an "Unknown PDX type" error if the read operation happens _before_ other client writes an object of that PDX type (and adds that PDX type to the central registry) even if both clients have cleared their PDX type caches. Here's a suggestion for the text in these lines: 8<-- **Note**: There are situations where some of the information in the central registry of the PDX domain object metadata is lost, e.g. when restoring an old backup with an outdated central registry. When that happens, new clients connecting to the cluster for the first time will get outdated PDX type information from the central registry, but, since information in the central registry is cached by clients, old clients may have fresher information about PDX types than the central registry does. That will result into inconsistent information about PDX types spread across the system: - old clients have fresh information - the central registry has outdated information - new clients have outdated information If old clients write entries of a PDX type they know but the central registry doesn't, new clients will get "Unknown PDX type" errors when they read those objects. To avoid this problem, clients may be configured with the system property in the table below to clear their PDX type cache when they disconnect from the cluster. After clearing their cache, old clients will re-generate type information for all PDX types, including the types the central registry "forgot". Since new PDX type information will be written in the central registry before entries of that type are written in the cluster, the central registry and all clients, old and new, will store consistent PDX type information. 8<-- in the hope that it is useful. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] mivanac merged pull request #7863: Adding the PGP keys for Mario Kevo with apache ID
mivanac merged PR #7863: URL: https://github.com/apache/geode/pull/7863 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] mkevo opened a new pull request, #7863: Adding the PGP keys for Mario Kevo with apache ID
mkevo opened a new pull request, #7863: URL: https://github.com/apache/geode/pull/7863 ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [ ] Is your initial contribution a single, squashed commit? - [ ] Does `gradlew build` run cleanly? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] mivanac opened a new pull request, #7862: GEODE-10424: introduce ExtendedReplyMessage, and prepare impacts
mivanac opened a new pull request, #7862: URL: https://github.com/apache/geode/pull/7862 ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [ ] Is your initial contribution a single, squashed commit? - [ ] Does `gradlew build` run cleanly? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode-native] gaussianrecurrence commented on pull request #983: GEODE-10416: Bump to boost 1.80.0
gaussianrecurrence commented on PR #983: URL: https://github.com/apache/geode-native/pull/983#issuecomment-1254954586 I think the issue you are facing for Windows compilation is the same as faced while trying to upgrade to Boost 1.79.0 in this PR #967 So, after looking into it, turns out, @moleske was in the right path, the issue has to do with _WIN32_WINNT and some issue with Boost Thing is boost_log was being compiled with **_WIN32_WINNT=0x0600**, even if your compilation target is >=0x0A00 (Windows 10, Windows 2016, Windows 2017, Windows 2019), and on the other side, geode-native modules using boost_log had _WIN32_WINNT defined as 0x0602 (which is a mistake btw, as, _WIN32_WINNT should fit in 16 bits, being 8 first for the major version and the 8 remaining for the minor version), causing boost_log to use **boost::log::v2s_mt_nt62** namespace, but since boost_log was compiled with **_WIN32_WINNT=0x0600**, the only available symbols in libboost_log.lib are the ones pointing to **boost::log::v2s_mt_nt6** namespace. I've tested the fix with GH actions and seems to be working: https://github.com/Nordix/geode-native/commit/0aa3d709cbcfcf915373f589e213f796cade616a#diff-3971f6cd87e6fed8494466300f14922d1869759f063ffc6170da0542d386180c In order to ensure that boost_log was compiled with _WIN32_WINNT it's needed to define **BOOST_USE_WINAPI_VERSION=0x0602** And also, right now, we haven't seen any issue because of having set _WIN32_WINNT to the wrong value to the Boost lib interface, but it'd be good to have it set to the right value, **_WIN32_WINNT=0x0602** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] gaussianrecurrence commented on a diff in pull request #7861: GEODE-10423: Document the system property “ON_DISCONNECT_CLEAR_PDXTYP…
gaussianrecurrence commented on code in PR #7861: URL: https://github.com/apache/geode/pull/7861#discussion_r977519140 ## geode-docs/developing/data_serialization/PDX_Serialization_Features.html.md.erb: ## @@ -31,6 +31,25 @@ When you serialize an object using PDX, <%=vars.product_name%> stores the object This centralization of object type information is advantageous for client/server installations in which clients and servers are written in different languages. Clients pass registry information to servers automatically when they store a PDX serialized object. Clients can run queries and functions against the data in the servers without compatibility between server and the stored objects. One client can store data on the server to be retrieved by another client, with no requirements on the part of the server. +**Note:** +When pdx registry is not persistent or persistent pdx registry is removed, if all the servers are stopped/crashed with clients still running, then the client with previous pdx type info connects to cluster with servers that are re-started, the client will see Unknown pdx type error. Review Comment: It's much better detailed now :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] wabp2005 commented on a diff in pull request #7861: GEODE-10423: Document the system property “ON_DISCONNECT_CLEAR_PDXTYP…
wabp2005 commented on code in PR #7861: URL: https://github.com/apache/geode/pull/7861#discussion_r977410823 ## geode-docs/developing/data_serialization/PDX_Serialization_Features.html.md.erb: ## @@ -31,6 +31,25 @@ When you serialize an object using PDX, <%=vars.product_name%> stores the object This centralization of object type information is advantageous for client/server installations in which clients and servers are written in different languages. Clients pass registry information to servers automatically when they store a PDX serialized object. Clients can run queries and functions against the data in the servers without compatibility between server and the stored objects. One client can store data on the server to be retrieved by another client, with no requirements on the part of the server. +**Note:** +When pdx registry is not persistent or persistent pdx registry is removed, if all the servers are stopped/crashed with clients still running, then the client with previous pdx type info connects to cluster with servers that are re-started, the client will see Unknown pdx type error. Review Comment: I have pushed a new commit with new change, please take a look at it, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] gaussianrecurrence commented on a diff in pull request #7861: GEODE-10423: Document the system property “ON_DISCONNECT_CLEAR_PDXTYP…
gaussianrecurrence commented on code in PR #7861: URL: https://github.com/apache/geode/pull/7861#discussion_r976149597 ## geode-docs/developing/data_serialization/PDX_Serialization_Features.html.md.erb: ## @@ -31,6 +31,25 @@ When you serialize an object using PDX, <%=vars.product_name%> stores the object This centralization of object type information is advantageous for client/server installations in which clients and servers are written in different languages. Clients pass registry information to servers automatically when they store a PDX serialized object. Clients can run queries and functions against the data in the servers without compatibility between server and the stored objects. One client can store data on the server to be retrieved by another client, with no requirements on the part of the server. +**Note:** +When pdx registry is not persistent or persistent pdx registry is removed, if all the servers are stopped/crashed with clients still running, then the client with previous pdx type info connects to cluster with servers that are re-started, the client will see Unknown pdx type error. Review Comment: Maybe it would be good to indicate that the Unknown PDX error means that each entry using the missing PDX will be corrupted, hence this leads to data corruption in the cluster -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] wabp2005 commented on a diff in pull request #7861: GEODE-10423: Document the system property “ON_DISCONNECT_CLEAR_PDXTYP…
wabp2005 commented on code in PR #7861: URL: https://github.com/apache/geode/pull/7861#discussion_r976127187 ## geode-docs/developing/data_serialization/PDX_Serialization_Features.html.md.erb: ## @@ -31,6 +31,25 @@ When you serialize an object using PDX, <%=vars.product_name%> stores the object This centralization of object type information is advantageous for client/server installations in which clients and servers are written in different languages. Clients pass registry information to servers automatically when they store a PDX serialized object. Clients can run queries and functions against the data in the servers without compatibility between server and the stored objects. One client can store data on the server to be retrieved by another client, with no requirements on the part of the server. +**Note:** +When pdx registry is not persistent or persistent pdx registry is removed, if all the servers are stopped/crashed with clients still running, then the client with previous pdx type info connects to cluster with servers that are re-started, the client will see Unknown pdx type error. Review Comment: Not seen problems in sever side. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] wabp2005 commented on a diff in pull request #7861: GEODE-10423: Document the system property “ON_DISCONNECT_CLEAR_PDXTYP…
wabp2005 commented on code in PR #7861: URL: https://github.com/apache/geode/pull/7861#discussion_r976126648 ## geode-docs/developing/data_serialization/PDX_Serialization_Features.html.md.erb: ## @@ -31,6 +31,25 @@ When you serialize an object using PDX, <%=vars.product_name%> stores the object This centralization of object type information is advantageous for client/server installations in which clients and servers are written in different languages. Clients pass registry information to servers automatically when they store a PDX serialized object. Clients can run queries and functions against the data in the servers without compatibility between server and the stored objects. One client can store data on the server to be retrieved by another client, with no requirements on the part of the server. +**Note:** +When pdx registry is not persistent or persistent pdx registry is removed, if all the servers are stopped/crashed with clients still running, then the client with previous pdx type info connects to cluster with servers that are re-started, the client will see Unknown pdx type error. Review Comment: Client or GFSH would get this error when reading an entry, since this entry contain the pdx type_id, but this type_id has been lost in server side because of pdx registry is not persistent or persistent pdx registry is crashed, and all the servers are restarted. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] wabp2005 commented on a diff in pull request #7861: GEODE-10423: Document the system property “ON_DISCONNECT_CLEAR_PDXTYP…
wabp2005 commented on code in PR #7861: URL: https://github.com/apache/geode/pull/7861#discussion_r976126190 ## geode-docs/developing/data_serialization/PDX_Serialization_Features.html.md.erb: ## @@ -31,6 +31,25 @@ When you serialize an object using PDX, <%=vars.product_name%> stores the object This centralization of object type information is advantageous for client/server installations in which clients and servers are written in different languages. Clients pass registry information to servers automatically when they store a PDX serialized object. Clients can run queries and functions against the data in the servers without compatibility between server and the stored objects. One client can store data on the server to be retrieved by another client, with no requirements on the part of the server. +**Note:** +When pdx registry is not persistent or persistent pdx registry is removed, if all the servers are stopped/crashed with clients still running, then the client with previous pdx type info connects to cluster with servers that are re-started, the client will see Unknown pdx type error. Review Comment: Yes, PDX types are stored into an internal region in the cluster, this region is replicated, if any server still online, the pdx types info will not lost. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] albertogpz commented on a diff in pull request #7861: GEODE-10423: Document the system property “ON_DISCONNECT_CLEAR_PDXTYP…
albertogpz commented on code in PR #7861: URL: https://github.com/apache/geode/pull/7861#discussion_r976095117 ## geode-docs/developing/data_serialization/PDX_Serialization_Features.html.md.erb: ## @@ -31,6 +31,25 @@ When you serialize an object using PDX, <%=vars.product_name%> stores the object This centralization of object type information is advantageous for client/server installations in which clients and servers are written in different languages. Clients pass registry information to servers automatically when they store a PDX serialized object. Clients can run queries and functions against the data in the servers without compatibility between server and the stored objects. One client can store data on the server to be retrieved by another client, with no requirements on the part of the server. +**Note:** +When pdx registry is not persistent or persistent pdx registry is removed, if all the servers are stopped/crashed with clients still running, then the client with previous pdx type info connects to cluster with servers that are re-started, the client will see Unknown pdx type error. Review Comment: Would there be any problem in servers apart from the clients getting errors? ## geode-docs/developing/data_serialization/PDX_Serialization_Features.html.md.erb: ## @@ -31,6 +31,25 @@ When you serialize an object using PDX, <%=vars.product_name%> stores the object This centralization of object type information is advantageous for client/server installations in which clients and servers are written in different languages. Clients pass registry information to servers automatically when they store a PDX serialized object. Clients can run queries and functions against the data in the servers without compatibility between server and the stored objects. One client can store data on the server to be retrieved by another client, with no requirements on the part of the server. +**Note:** +When pdx registry is not persistent or persistent pdx registry is removed, if all the servers are stopped/crashed with clients still running, then the client with previous pdx type info connects to cluster with servers that are re-started, the client will see Unknown pdx type error. Review Comment: Do all servers need to be stopped in order to have issues? ## geode-docs/developing/data_serialization/PDX_Serialization_Features.html.md.erb: ## @@ -31,6 +31,25 @@ When you serialize an object using PDX, <%=vars.product_name%> stores the object This centralization of object type information is advantageous for client/server installations in which clients and servers are written in different languages. Clients pass registry information to servers automatically when they store a PDX serialized object. Clients can run queries and functions against the data in the servers without compatibility between server and the stored objects. One client can store data on the server to be retrieved by another client, with no requirements on the part of the server. +**Note:** +When pdx registry is not persistent or persistent pdx registry is removed, if all the servers are stopped/crashed with clients still running, then the client with previous pdx type info connects to cluster with servers that are re-started, the client will see Unknown pdx type error. Review Comment: When will clients get such error? Will it be when reading, writing? other? What would be the implications? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] albertogpz merged pull request #7857: GEODE-10410: Fix bucket lost during rebalance
albertogpz merged PR #7857: URL: https://github.com/apache/geode/pull/7857 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] mkevo merged pull request #7846: GEODE-10395 remove locks from List if dlock.acquireTryLocks return false
mkevo merged PR #7846: URL: https://github.com/apache/geode/pull/7846 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode-native] albertogpz commented on a diff in pull request #984: GEODE-10414: Implement Region::putIfAbsent method
albertogpz commented on code in PR #984:
URL: https://github.com/apache/geode-native/pull/984#discussion_r973963090
##
cppcache/integration/test/RegionPutTest.cpp:
##
@@ -0,0 +1,294 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+#include
+
+#include
+#include
+#include
+#include
+#include
+
+#include
+
+#include
+#include
+#include
+#include
+#include
+
+#include "CacheRegionHelper.hpp"
+#include "framework/Cluster.h"
+#include "framework/Framework.h"
+#include "framework/Gfsh.h"
+
+namespace {
+
+using apache::geode::client::Cache;
+using apache::geode::client::Cacheable;
+using apache::geode::client::CacheableKey;
+using apache::geode::client::CacheableString;
+using apache::geode::client::CommitConflictException;
+using apache::geode::client::Pool;
+using apache::geode::client::Region;
+using apache::geode::client::RegionShortcut;
+
+using std::chrono::minutes;
+
+using ::testing::Eq;
+using ::testing::IsNull;
+using ::testing::NotNull;
+
+Cache createCache() {
+ using apache::geode::client::CacheFactory;
+
+ auto cache = CacheFactory()
+ .set("log-level", "debug")
+ .set("statistic-sampling-enabled", "false")
+ .create();
+
+ return cache;
+}
+
+std::shared_ptr createPool(Cluster& cluster, Cache& cache) {
+ auto poolFactory = cache.getPoolManager().createFactory();
+ cluster.applyLocators(poolFactory);
+ return poolFactory.create("default");
+}
+
+std::shared_ptr setupRegion(Cache& cache,
+const std::shared_ptr& pool) {
+ auto region = cache.createRegionFactory(RegionShortcut::PROXY)
+.setPoolName(pool->getName())
+.create("region");
+
+ return region;
+}
+
+std::shared_ptr setupCachingRegion(Cache& cache,
+ const std::shared_ptr& pool) {
+ auto region = cache.createRegionFactory(RegionShortcut::CACHING_PROXY)
+.setPoolName(pool->getName())
+.create("region");
+
+ return region;
+}
+
+TEST(RegionPutTest, testPutIfAbsentNotExistingEntry) {
+ Cluster cluster{LocatorCount{1}, ServerCount{1}};
+
+ cluster.start();
+
+ cluster.getGfsh()
+ .create()
+ .region()
+ .withName("region")
+ .withType("REPLICATE")
+ .execute();
+
+ auto cache = createCache();
+ auto pool = createPool(cluster, cache);
+ auto region = setupRegion(cache, pool);
+ auto key = CacheableKey::create("key-1");
+ auto value = CacheableString::create("value");
+
+ EXPECT_THAT(region->putIfAbsent(key, value), IsNull());
+
+ auto retrieved = region->get(key);
+ EXPECT_THAT(retrieved, NotNull());
+
+ auto converted = std::dynamic_pointer_cast(retrieved);
+ EXPECT_THAT(converted, NotNull());
+ EXPECT_THAT(converted->toString(), Eq(value->toString()));
+}
+
+TEST(RegionPutTest, testPutIfAbsentNotExistingEntryWithCaching) {
+ Cluster cluster{LocatorCount{1}, ServerCount{1}};
+
+ cluster.start();
+
+ cluster.getGfsh()
+ .create()
+ .region()
+ .withName("region")
+ .withType("REPLICATE")
+ .execute();
+
+ auto cache = createCache();
+ auto pool = createPool(cluster, cache);
+ auto region = setupCachingRegion(cache, pool);
+ auto key = CacheableKey::create("key-1");
+ auto value = CacheableString::create("value");
+
+ EXPECT_THAT(region->putIfAbsent(key, value), IsNull());
+
+ auto retrieved = region->get(key);
+ EXPECT_THAT(retrieved, NotNull());
+
+ auto converted = std::dynamic_pointer_cast(retrieved);
+ EXPECT_THAT(converted, NotNull());
+ EXPECT_THAT(converted->toString(), Eq(value->toString()));
+
+ // Verify cached value matches expected
+ auto entry = region->getEntry(key);
+ EXPECT_THAT(entry, NotNull());
+
+ retrieved = entry->getValue();
+ EXPECT_THAT(converted, NotNull());
+
+ converted = std::dynamic_pointer_cast(retrieved);
+ EXPECT_THAT(converted, NotNull());
+ EXPECT_THAT(converted->toString(), Eq(value->toString()));
+}
+
+TEST(RegionPutTest, testPutIfAbsentExistingEntry) {
+ Cluster cluster{LocatorCount{1}, ServerCount{1}};
+
+ cluster.start();
+
+ cluster.getGfsh()
+ .create()
+ .region()
+ .withName("region")
+
[GitHub] [geode] wabp2005 opened a new pull request, #7861: GEODE-10423: Document the system property “ON_DISCONNECT_CLEAR_PDXTYP…
wabp2005 opened a new pull request, #7861: URL: https://github.com/apache/geode/pull/7861 …EIDS“ Document the java system property “ON_DISCONNECT_CLEAR_PDXTYPEIDS“. This property is used by Java client, add instructions for using this property. ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [ ] Is your initial contribution a single, squashed commit? - [ ] Does `gradlew build` run cleanly? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] albertogpz commented on a diff in pull request #7857: GEODE-10410: Fix bucket lost during rebalance
albertogpz commented on code in PR #7857:
URL: https://github.com/apache/geode/pull/7857#discussion_r973919611
##
geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/rebalance/PartitionedRegionLoadModelJUnitTest.java:
##
@@ -483,30 +485,73 @@ public void testColocationEnforceLocalMaxMemory() throws
UnknownHostException {
}
/**
- * Test that each region individually honors it's enforce local max memory
flag.
+ * Test that a region with enforceLocalMaxMemory disabled colocated with
+ * a region that memory full with enforceLocalMaxMemory enabled will prevent
a bucket move.
*/
@Test
- public void testColocationIgnoreEnforceLocalMaxMemory() throws
UnknownHostException {
+ public void testColocationOneNoneEvictionRegionReachLocalMaxMemoryLimit()
throws UnknownHostException {
Review Comment:
I would rename the test case to
`testColocationOneNonEvictionRegionReachesLocalMaxMemoryLimit()`
##
geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/rebalance/PartitionedRegionLoadModelJUnitTest.java:
##
@@ -483,30 +485,73 @@ public void testColocationEnforceLocalMaxMemory() throws
UnknownHostException {
}
/**
- * Test that each region individually honors it's enforce local max memory
flag.
+ * Test that a region with enforceLocalMaxMemory disabled colocated with
+ * a region that memory full with enforceLocalMaxMemory enabled will prevent
a bucket move.
*/
@Test
- public void testColocationIgnoreEnforceLocalMaxMemory() throws
UnknownHostException {
+ public void testColocationOneNoneEvictionRegionReachLocalMaxMemoryLimit()
throws UnknownHostException {
PartitionedRegionLoadModel model = new
PartitionedRegionLoadModel(bucketOperator, 1, 4,
getAddressComparor(false), Collections.emptySet(), partitionedRegion);
InternalDistributedMember member1 =
new InternalDistributedMember(InetAddress.getByName("127.0.0.1"), 1);
InternalDistributedMember member2 =
new InternalDistributedMember(InetAddress.getByName("127.0.0.1"), 2);
-// Create some buckets with low redundancy on member 1
PartitionMemberInfoImpl details1 =
-buildDetails(member1, new long[] {1, 1, 1, 1}, new long[] {1, 1, 1,
1});
+buildDetails(member1, 1, 8 * MB, new long[] {1 * MB, 1 * MB, 1 * MB, 1
* MB},
+new long[] {1, 1, 1, 1});
PartitionMemberInfoImpl details2 =
-buildDetails(member2, new long[] {0, 0, 0, 0}, new long[] {0, 0, 0,
0});
+buildDetails(member2, 1, 8 * MB, new long[] {0, 0, 0, 0}, new long[]
{0, 0, 0, 0});
+model.addRegion("a", Arrays.asList(details1, details2), new
FakeOfflineDetails(), false);
+
+
+PartitionMemberInfoImpl bDetails1 =
+buildDetails(member1, 1, 2 * MB, new long[] {1 * MB, 1 * MB, 1 * MB, 1
* MB},
+new long[] {1, 1, 1, 1});
+PartitionMemberInfoImpl bDetails2 =
+buildDetails(member2, 1, 2 * MB, new long[] {0, 0, 0, 0}, new long[]
{0, 0, 0, 0});
+model.addRegion("b", Arrays.asList(bDetails1, bDetails2), new
FakeOfflineDetails(), true);
+
+
+assertThat(doMoves(new CompositeDirector(true, true, false, true),
model)).isEqualTo(4);
+
+Set expectedCreates = new HashSet<>();
+expectedCreates.add(new Create(member2, 0));
+expectedCreates.add(new Create(member2, 1));
+assertThat(new
HashSet<>(bucketOperator.creates)).isEqualTo(expectedCreates);
+
+Set expectedMoves = new HashSet<>();
+expectedMoves.add(new Move(member1, member2));
+expectedMoves.add(new Move(member1, member2));
+assertThat(new
HashSet<>(bucketOperator.primaryMoves)).isEqualTo(expectedMoves);
+ }
+
+ /**
+ * Test that a region that memory full with enforceLocalMaxMemory disabled
will not prevent a
+ * bucket move.
+ */
+ @Test
+ public void testColocationOneEvictionRegionReachLocalMaxMemoryLimit() throws
UnknownHostException {
Review Comment:
I would rename the test case to:
`testColocationOneEvictionRegionReachesLocalMaxMemoryLimit()`
##
geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/rebalance/PartitionedRegionLoadModelJUnitTest.java:
##
@@ -483,30 +485,73 @@ public void testColocationEnforceLocalMaxMemory() throws
UnknownHostException {
}
/**
- * Test that each region individually honors it's enforce local max memory
flag.
+ * Test that a region with enforceLocalMaxMemory disabled colocated with
+ * a region that memory full with enforceLocalMaxMemory enabled will prevent
a bucket move.
*/
@Test
- public void testColocationIgnoreEnforceLocalMaxMemory() throws
UnknownHostException {
+ public void testColocationOneNoneEvictionRegionReachLocalMaxMemoryLimit()
throws UnknownHostException {
PartitionedRegionLoadModel model = new
PartitionedRegionLoadModel(bucketOperator, 1, 4,
getAddressComparor(false), Collections.emptySet(), partitionedRegion);
[GitHub] [geode] mivanac merged pull request #7849: GEODE-10331: schedule delayed CloseEndpoint
mivanac merged PR #7849: URL: https://github.com/apache/geode/pull/7849 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode-kafka-connector] dependabot[bot] opened a new pull request, #22: Bump geode-core from 1.12.6 to 1.15.0
dependabot[bot] opened a new pull request, #22: URL: https://github.com/apache/geode-kafka-connector/pull/22 Bumps [geode-core](https://github.com/apache/geode) from 1.12.6 to 1.15.0. Release notes Sourced from https://github.com/apache/geode/releases;>geode-core's releases. Apache Geode 1.15.0 This release includes a significant number of bug fixes and improvements, including JDK17 support. sha256 for apache-geode-1.15.0.tgz is 97cd96e94991cbd433d93e8474e1c2e65deb92f022d810a1931464017701701b See full release notes at https://cwiki.apache.org/confluence/display/GEODE/Release+Notes#ReleaseNotes-1.15.0;>https://cwiki.apache.org/confluence/display/GEODE/Release+Notes#ReleaseNotes-1.15.0 Apache Geode 1.14.4 This patch release includes a few bug fixes. sha256 for apache-geode-1.14.4.tgz is 7dd214f41d2bb1187efc83f054028e6f747a7d4ec7c417dcd003edbcd1e1f59b See full release notes at https://cwiki.apache.org/confluence/display/GEODE/Release+Notes#ReleaseNotes-1.14.4;>https://cwiki.apache.org/confluence/display/GEODE/Release+Notes#ReleaseNotes-1.14.4 Apache Geode 1.14.3 This patch release includes a few bug fixes. sha256 for apache-geode-1.14.3.tgz is 5efb1c71db34ba3b7ce1004579f8b9b7a43eae30f42c37837d5abd68c6d778bd See full release notes at https://cwiki.apache.org/confluence/display/GEODE/Release+Notes#ReleaseNotes-1.14.3;>https://cwiki.apache.org/confluence/display/GEODE/Release+Notes#ReleaseNotes-1.14.3 Apache Geode 1.14.2 This patch release upgrades to log4j 2.16.0. sha256 for apache-geode-1.14.2.tgz is 78d6d6c0534ef32396e8de790fb7318d70b7c85894c046916ff8db401b9472fd See full release notes at https://cwiki.apache.org/confluence/display/GEODE/Release+Notes#ReleaseNotes-1.14.2;>https://cwiki.apache.org/confluence/display/GEODE/Release+Notes#ReleaseNotes-1.14.2 Apache Geode 1.14.1 This patch release includes a few bug fixes. sha256 for apache-geode-1.14.1.tgz is 1be5c03d82ef852eb8bb914af6927af545cbe69d62fd645eb122f077674a014f See full release notes at https://cwiki.apache.org/confluence/display/GEODE/Release+Notes#ReleaseNotes-1.14.1;>https://cwiki.apache.org/confluence/display/GEODE/Release+Notes#ReleaseNotes-1.14.1 Apache Geode 1.14.0 This release includes a significant number of bug fixes, improvements in current behavior along with the addition of a few statistics to monitor the cluster health. sha256 for apache-geode-1.14.0.tgz is d8a72225caf63889e41f8909cffc9303fb288515387f216d3207bc6d5457b947 See full release notes at https://cwiki.apache.org/confluence/display/GEODE/Release+Notes#ReleaseNotes-1.14.0;>https://cwiki.apache.org/confluence/display/GEODE/Release+Notes#ReleaseNotes-1.14.0 Apache Geode 1.13.8 This patch release includes a few bug fixes. sha256 for apache-geode-1.13.8.tgz is b5fc105ce0a16aaf7ba341668e022d458b18d6d2c44705a8c79c42077c6d8229 See full release notes at https://cwiki.apache.org/confluence/display/GEODE/Release+Notes#ReleaseNotes-1.13.8;>https://cwiki.apache.org/confluence/display/GEODE/Release+Notes#ReleaseNotes-1.13.8 ... (truncated) Commits https://github.com/apache/geode/commit/1869f2c06681bb73de727d2080d76c6215db9fb9;>1869f2c GEODE-10380: use waitingThreadPool to notify dispatcher at re_auth (https://github-redirect.dependabot.com/apache/geode/issues/7801;>#7801) https://github.com/apache/geode/commit/c30c3ab60e31af26859f474e5200e31c80a23315;>c30c3ab GEODE-10375: update supported api docs link (https://github-redirect.dependabot.com/apache/geode/issues/7794;>#7794) https://github.com/apache/geode/commit/f75edd94c01966601acdf02252ace192d2ce9d93;>f75edd9 Revert GEODE-9632: Allow INDEX_THRESHOLD_SIZE System property to override Co... https://github.com/apache/geode/commit/90cb26ba60598e074e34789d1b75459422a87c25;>90cb26b GEODE-10342: Simplify copying jars (https://github-redirect.dependabot.com/apache/geode/issues/7788;>#7788) https://github.com/apache/geode/commit/a6da307e007a3e52fc223ef108e70ba1068b60ed;>a6da307 GEODE-10089: update LICENSE due to redis removal, change to springdoc, and in... https://github.com/apache/geode/commit/0376348409e9ed56511631d2c7d81f880a9431e9;>0376348 GEODE-10365: add missing components to table (https://github-redirect.dependabot.com/apache/geode/issues/7780;>#7780) https://github.com/apache/geode/commit/5f33d22d0cbfb7e41ea585c74973c2f9ffb55c97;>5f33d22 GEODE-10106: Use local ref to queueConnection. (https://github-redirect.dependabot.com/apache/geode/issues/7740;>#7740) https://github.com/apache/geode/commit/f05ef0d36322ac229bdfe790a89bc2e1b439645b;>f05ef0d GEODE-8977: change ThreadMonitor to reduce how long it does a stop the world... https://github.com/apache/geode/commit/3c9bb2e4575554a4ab5556e98e6e6a7324ef034f;>3c9bb2e GEODE-10301: support LocalDate and JodaTime (https://github-redirect.dependabot.com/apache/geode/issues/7737;>#7737)
[GitHub] [geode] mivanac merged pull request #7856: GEODE-10421: Improve start gw sender with clean-queue
mivanac merged PR #7856: URL: https://github.com/apache/geode/pull/7856 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] WeijieEST commented on a diff in pull request #7857: GEODE-10410: Fix bucket lost during rebalance
WeijieEST commented on code in PR #7857:
URL: https://github.com/apache/geode/pull/7857#discussion_r972577636
##
geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/rebalance/PartitionedRegionLoadModelJUnitTest.java:
##
@@ -443,7 +443,7 @@ public void testIncompleteColocation() throws
UnknownHostException {
* lmm, it will prevent a bucket move
*/
@Test
- public void testColocationEnforceLocalMaxMemory() throws
UnknownHostException {
+ public void testColocationBothEnforceLocalMaxMemory() throws
UnknownHostException {
Review Comment:
The test case was changed for several reasons.
- Test cases are renamed to make them a group together with the newly added
test case(see below description about the test group).
- Add MB to data size so the log will print the model with correct data size.
- Some comments are chanegd, most to help understand the test case better,
and the last comment was wrong.
Description about the test group
The first case test that both of the 2 regions are eviction disabled(this
was tested before),
the second and third test cases test one region is eviction enabled,
the second test case tests the none eviction region reaches its local
max memory(this was not tested before),
the third test case tests the eviction region reaches its local max
memory(this was tested before but it should be failed if the test condition was
set properly).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [geode] jvarenina commented on a diff in pull request #7856: GEODE-10421: Improve start gw sender with clean-queue
jvarenina commented on code in PR #7856:
URL: https://github.com/apache/geode/pull/7856#discussion_r972706616
##
geode-gfsh/src/main/java/org/apache/geode/management/internal/cli/commands/StartGatewaySenderCommand.java:
##
@@ -77,6 +77,44 @@ public ResultModel startGatewaySender(@CliOption(key =
CliStrings.START_GATEWAYS
return ResultModel.createError(CliStrings.NO_MEMBERS_FOUND_MESSAGE);
}
+if (cleanQueues) {
+
+ GatewaySenderMXBean bean;
+ boolean commmandRejected = false;
Review Comment:
typo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [geode] WeijieEST commented on a diff in pull request #7857: GEODE-10410: Fix bucket lost during rebalance
WeijieEST commented on code in PR #7857:
URL: https://github.com/apache/geode/pull/7857#discussion_r972580688
##
geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/rebalance/PartitionedRegionLoadModelJUnitTest.java:
##
@@ -483,30 +485,73 @@ public void testColocationEnforceLocalMaxMemory() throws
UnknownHostException {
}
/**
- * Test that each region individually honors it's enforce local max memory
flag.
+ * Test that a region with enforceLocalMaxMemory disabled colocated with
+ * a region that memory full with enforceLocalMaxMemory enabled will prevent
a bucket move.
*/
@Test
- public void testColocationIgnoreEnforceLocalMaxMemory() throws
UnknownHostException {
+ public void testColocationOneEnforceLocalMaxMemoryFull() throws
UnknownHostException {
Review Comment:
This seconde test case is newly added, I will explain why the third test
case was changed.
Most reasons is like above, special reason for this test case is to improve
the test condition.
First region lmm was set 500 before, this will make the memory judege for
all regions totally(the one I removed in this PR) pass and make the test case
pass.
So I decrease the lmm of the first region, so make the total lmm not enough
to hold all the data, this test case will pass with this PR applied, but will
fail with the old code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [geode] WeijieEST commented on a diff in pull request #7857: GEODE-10410: Fix bucket lost during rebalance
WeijieEST commented on code in PR #7857:
URL: https://github.com/apache/geode/pull/7857#discussion_r972580688
##
geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/rebalance/PartitionedRegionLoadModelJUnitTest.java:
##
@@ -483,30 +485,73 @@ public void testColocationEnforceLocalMaxMemory() throws
UnknownHostException {
}
/**
- * Test that each region individually honors it's enforce local max memory
flag.
+ * Test that a region with enforceLocalMaxMemory disabled colocated with
+ * a region that memory full with enforceLocalMaxMemory enabled will prevent
a bucket move.
*/
@Test
- public void testColocationIgnoreEnforceLocalMaxMemory() throws
UnknownHostException {
+ public void testColocationOneEnforceLocalMaxMemoryFull() throws
UnknownHostException {
Review Comment:
This seconde test case is newly added, I will explain why the third test
case was changed.
Most reasons is like above, special reason for this test case is to improve
the test condition.
First region lmm was set 500 before, this will make the outloop memory
judege(the one I removed in this PR) pass and make the test case pass.
So I decrease the lmm of the first region, so make the total lmm not enough
to hold all the data, this test case will pass with this PR applied, but will
fail with the old code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [geode] WeijieEST commented on a diff in pull request #7857: GEODE-10410: Fix bucket lost during rebalance
WeijieEST commented on code in PR #7857:
URL: https://github.com/apache/geode/pull/7857#discussion_r972577636
##
geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/rebalance/PartitionedRegionLoadModelJUnitTest.java:
##
@@ -443,7 +443,7 @@ public void testIncompleteColocation() throws
UnknownHostException {
* lmm, it will prevent a bucket move
*/
@Test
- public void testColocationEnforceLocalMaxMemory() throws
UnknownHostException {
+ public void testColocationBothEnforceLocalMaxMemory() throws
UnknownHostException {
Review Comment:
The test case was changed for several reasons.
- Test cases are renamed to make them a group together with the newly added
test case(see below description about the test group).
- Add MB to data size so the log will print the model with correct data size.
- Some comments are chanegd, most to help understand the test case better,
and the last comment was wrong.
Description about the test group
The first case test that both of the 2 regions are eviction disabled(this
was tested before),
the second and third test cases test one region is eviction enabled,
the second test case tests the none eviction region memory full(this was
not tested before),
the third test case tests the eviction region memory full(this was
tested before but it should be failed if the test condition was set properly).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [geode] WeijieEST commented on a diff in pull request #7857: GEODE-10410: Fix bucket lost during rebalance
WeijieEST commented on code in PR #7857:
URL: https://github.com/apache/geode/pull/7857#discussion_r972577636
##
geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/rebalance/PartitionedRegionLoadModelJUnitTest.java:
##
@@ -443,7 +443,7 @@ public void testIncompleteColocation() throws
UnknownHostException {
* lmm, it will prevent a bucket move
*/
@Test
- public void testColocationEnforceLocalMaxMemory() throws
UnknownHostException {
+ public void testColocationBothEnforceLocalMaxMemory() throws
UnknownHostException {
Review Comment:
The test case was changed for several reasons.
Test cases are renamed to make them a group together with the newly added
test case(see below description about the test group).
Add MB to data size so the log will print the model with correct data size.
Some comments are chanegd, most to help understand the test case better, and
the last comment was wrong.
Description about the test group
The first case test that both of the 2 regions are eviction disabled(this
was tested before),
the second and third test cases test one region is eviction enabled,
the second test case tests the none eviction region memory full(this was
not tested before),
the third test case tests the eviction region memory full(this was tested
before but it should be failed if the test condition was set properly).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [geode] WeijieEST commented on a diff in pull request #7857: GEODE-10410: Fix bucket lost during rebalance
WeijieEST commented on code in PR #7857:
URL: https://github.com/apache/geode/pull/7857#discussion_r972577636
##
geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/rebalance/PartitionedRegionLoadModelJUnitTest.java:
##
@@ -443,7 +443,7 @@ public void testIncompleteColocation() throws
UnknownHostException {
* lmm, it will prevent a bucket move
*/
@Test
- public void testColocationEnforceLocalMaxMemory() throws
UnknownHostException {
+ public void testColocationBothEnforceLocalMaxMemory() throws
UnknownHostException {
Review Comment:
The test case was changed for several reasons.
Test cases are renamed to make them a group(see below description about the
test group).
Add MB to data size so the log will print the model with correct data size.
Some comments are chanegd, most to help understand the test case better, and
the last comment was wrong.
Description about the test group
The first case test that both of the 2 regions are eviction disabled(this
was tested before),
the second and third test cases test one region is eviction enabled,
the second test case tests the none eviction region memory full(this was
not tested before),
the third test case tests the eviction region memory full(this was tested
before but it should be failed if the test condition was set properly).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [geode] mivanac commented on a diff in pull request #7856: GEODE-10421: Improve start gw sender with clean-queue
mivanac commented on code in PR #7856:
URL: https://github.com/apache/geode/pull/7856#discussion_r972559431
##
geode-gfsh/src/main/java/org/apache/geode/management/internal/cli/commands/StartGatewaySenderCommand.java:
##
@@ -77,6 +77,49 @@ public ResultModel startGatewaySender(@CliOption(key =
CliStrings.START_GATEWAYS
return ResultModel.createError(CliStrings.NO_MEMBERS_FOUND_MESSAGE);
}
+if (cleanQueues) {
+
+ Set allServers = findMembers(null, null);
+
+ if (dsMembers.size() != allServers.size()) {
+return ResultModel.createError(CliStrings.EXECUTE_ON_ALL_MEMBERS);
+ }
+
+ GatewaySenderMXBean bean;
+ boolean commmandRejected = false;
+
+ ResultModel rejectResultModel =
+ ResultModel.createError(CliStrings.START_GATEWAYSENDER_REJECTED);
+ TabularResultModel rejectResultData =
+
rejectResultModel.addTable(CliStrings.REJECT_START_GATEWAYSENDER_REASON);
+
+ for (DistributedMember member : dsMembers) {
+if
(cache.getDistributedSystem().getDistributedMember().getId().equals(member.getId()))
{
+ bean = service.getLocalGatewaySenderMXBean(senderId);
+} else {
+ ObjectName objectName = service.getGatewaySenderMBeanName(member,
senderId);
+ bean = service.getMBeanProxy(objectName, GatewaySenderMXBean.class);
+}
+if (bean != null) {
+ if (bean.isRunning()) {
+commmandRejected = true;
+rejectResultData.addMemberStatusResultRow(member.getId(),
CliStrings.GATEWAY_ERROR,
+CliStrings.format(
+
CliStrings.GATEWAY_SENDER_0_IS_ALREADY_STARTED_ON_MEMBER_1, id,
+member.getId()));
+ }
+} else {
+ commmandRejected = true;
+ rejectResultData.addMemberStatusResultRow(member.getId(),
CliStrings.GATEWAY_ERROR,
+ CliStrings.format(
+ CliStrings.GATEWAY_SENDER_0_IS_NOT_AVAILABLE_ON_MEMBER_1,
id, member.getId()));
+}
+ }
Review Comment:
This check needs to be executed prior to execution of callables, since they
are executed in parallel on all desired members.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [geode] mivanac commented on a diff in pull request #7856: GEODE-10421: Improve start gw sender with clean-queue
mivanac commented on code in PR #7856:
URL: https://github.com/apache/geode/pull/7856#discussion_r972334785
##
geode-gfsh/src/main/java/org/apache/geode/management/internal/cli/commands/StartGatewaySenderCommand.java:
##
@@ -77,6 +77,49 @@ public ResultModel startGatewaySender(@CliOption(key =
CliStrings.START_GATEWAYS
return ResultModel.createError(CliStrings.NO_MEMBERS_FOUND_MESSAGE);
}
+if (cleanQueues) {
+
+ Set allServers = findMembers(null, null);
+
+ if (dsMembers.size() != allServers.size()) {
+return ResultModel.createError(CliStrings.EXECUTE_ON_ALL_MEMBERS);
+ }
+
+ GatewaySenderMXBean bean;
+ boolean commmandRejected = false;
+
+ ResultModel rejectResultModel =
+ ResultModel.createError(CliStrings.START_GATEWAYSENDER_REJECTED);
+ TabularResultModel rejectResultData =
+
rejectResultModel.addTable(CliStrings.REJECT_START_GATEWAYSENDER_REASON);
+
+ for (DistributedMember member : dsMembers) {
+if
(cache.getDistributedSystem().getDistributedMember().getId().equals(member.getId()))
{
+ bean = service.getLocalGatewaySenderMXBean(senderId);
+} else {
+ ObjectName objectName = service.getGatewaySenderMBeanName(member,
senderId);
+ bean = service.getMBeanProxy(objectName, GatewaySenderMXBean.class);
+}
+if (bean != null) {
+ if (bean.isRunning()) {
+commmandRejected = true;
+rejectResultData.addMemberStatusResultRow(member.getId(),
CliStrings.GATEWAY_ERROR,
+CliStrings.format(
+
CliStrings.GATEWAY_SENDER_0_IS_ALREADY_STARTED_ON_MEMBER_1, id,
+member.getId()));
+ }
+} else {
+ commmandRejected = true;
+ rejectResultData.addMemberStatusResultRow(member.getId(),
CliStrings.GATEWAY_ERROR,
+ CliStrings.format(
+ CliStrings.GATEWAY_SENDER_0_IS_NOT_AVAILABLE_ON_MEMBER_1,
id, member.getId()));
+}
+ }
Review Comment:
This check needs to be executed prior to execution of callables, since they
are executed in parallel on all desired members.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [geode] jvarenina opened a new pull request, #7860: To test if sync writes
jvarenina opened a new pull request, #7860: URL: https://github.com/apache/geode/pull/7860 ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [ ] Is your initial contribution a single, squashed commit? - [ ] Does `gradlew build` run cleanly? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] jvarenina closed pull request #7835: Configurable IF file compaction writes mode
jvarenina closed pull request #7835: Configurable IF file compaction writes mode URL: https://github.com/apache/geode/pull/7835 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode-native] moleske commented on a diff in pull request #968: GEODE-10291: Add ubuntu 22.04 (jammy) to CI
moleske commented on code in PR #968:
URL: https://github.com/apache/geode-native/pull/968#discussion_r972202959
##
docker/ubuntu-22.04/Dockerfile:
##
@@ -0,0 +1,67 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+FROM ubuntu:22.04
+LABEL maintainer Apache Geode
+
+USER root
+WORKDIR /
+
+ENV DEBIAN_FRONTEND noninteractive
+RUN apt update && \
+apt -yq full-upgrade && \
+apt-get -y install \
+apt-transport-https \
+ca-certificates \
+curl \
+gnupg2 \
+software-properties-common && \
+apt-get -y autoremove && \
+apt-get autoclean
+
+RUN . /etc/os-release && \
+curl -s https://download.bell-sw.com/pki/GPG-KEY-bellsoft | apt-key add -
&& \
+apt-add-repository "deb http://apt.bell-sw.com/ stable main"
+
+RUN apt update && apt -yq full-upgrade && apt-get -y install \
+build-essential \
+libc++-dev \
+libc++abi-dev \
+zlib1g-dev \
+libssl-dev \
+bellsoft-java11 \
+git \
+doxygen \
+graphviz \
+clang-format-12 && \
+apt-get -y autoremove && \
+apt-get autoclean
+
+# Get latest release of CMake ignoring pre-releases
+RUN installer=$(mktemp) \
+&& curl -o ${installer} -L $(curl -s
https://api.github.com/repos/Kitware/CMake/releases \
+| grep -P -i
'browser_download_url.*cmake-\d+\.\d+\.\d+-linux-x86_64\.sh' \
+| head -n 1 \
+| cut -d : -f 2,3 \
+| tr -d '"') \
+&& bash ${installer} --skip-license --prefix=/usr/local \
+&& rm ${installer}
+
+ARG GEODE_VERSION=1.14.4
Review Comment:
ah joys of forgetting about prs for months on end, can bump it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [geode-native] moleske merged pull request #966: GEODE-10291: Compile on ubuntu jammy (gcc/g++ 11.2.0)
moleske merged PR #966: URL: https://github.com/apache/geode-native/pull/966 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] albertogpz commented on a diff in pull request #7857: GEODE-10410: Fix bucket lost during rebalance
albertogpz commented on code in PR #7857:
URL: https://github.com/apache/geode/pull/7857#discussion_r972056347
##
geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/rebalance/PartitionedRegionLoadModelJUnitTest.java:
##
@@ -483,30 +485,73 @@ public void testColocationEnforceLocalMaxMemory() throws
UnknownHostException {
}
/**
- * Test that each region individually honors it's enforce local max memory
flag.
+ * Test that a region with enforceLocalMaxMemory disabled colocated with
+ * a region that memory full with enforceLocalMaxMemory enabled will prevent
a bucket move.
*/
@Test
- public void testColocationIgnoreEnforceLocalMaxMemory() throws
UnknownHostException {
+ public void testColocationOneEnforceLocalMaxMemoryFull() throws
UnknownHostException {
Review Comment:
This test case is still passing without the fix in MemberRollup.java. Why
was it changed?
##
geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/rebalance/PartitionedRegionLoadModelJUnitTest.java:
##
@@ -443,7 +443,7 @@ public void testIncompleteColocation() throws
UnknownHostException {
* lmm, it will prevent a bucket move
*/
@Test
- public void testColocationEnforceLocalMaxMemory() throws
UnknownHostException {
+ public void testColocationBothEnforceLocalMaxMemory() throws
UnknownHostException {
Review Comment:
This test case is still passing without the fix in MemberRollup.java. Why
was it changed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [geode] mivanac commented on a diff in pull request #7856: GEODE-10421: Improve start gw sender with clean-queue
mivanac commented on code in PR #7856:
URL: https://github.com/apache/geode/pull/7856#discussion_r972039027
##
geode-gfsh/src/main/java/org/apache/geode/management/internal/cli/commands/StartGatewaySenderCommand.java:
##
@@ -77,6 +77,49 @@ public ResultModel startGatewaySender(@CliOption(key =
CliStrings.START_GATEWAYS
return ResultModel.createError(CliStrings.NO_MEMBERS_FOUND_MESSAGE);
}
+if (cleanQueues) {
+
+ Set allServers = findMembers(null, null);
+
+ if (dsMembers.size() != allServers.size()) {
+return ResultModel.createError(CliStrings.EXECUTE_ON_ALL_MEMBERS);
+ }
Review Comment:
Thanks for comment. It seems if partitioned region is created on just a
group of servers, this check is not valid.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [geode] jvarenina commented on a diff in pull request #7856: GEODE-10421: Improve start gw sender with clean-queue
jvarenina commented on code in PR #7856:
URL: https://github.com/apache/geode/pull/7856#discussion_r971989985
##
geode-gfsh/src/main/java/org/apache/geode/management/internal/cli/commands/StartGatewaySenderCommand.java:
##
@@ -77,6 +77,49 @@ public ResultModel startGatewaySender(@CliOption(key =
CliStrings.START_GATEWAYS
return ResultModel.createError(CliStrings.NO_MEMBERS_FOUND_MESSAGE);
}
+if (cleanQueues) {
+
+ Set allServers = findMembers(null, null);
+
+ if (dsMembers.size() != allServers.size()) {
+return ResultModel.createError(CliStrings.EXECUTE_ON_ALL_MEMBERS);
+ }
Review Comment:
This code will reject a start clean queue command when you execute it for a
particular group of servers when there are multiple groups of servers. Could it
be possible to check that only servers in the provided group have configured
senders and continue?
##
geode-gfsh/src/main/java/org/apache/geode/management/internal/cli/commands/StartGatewaySenderCommand.java:
##
@@ -77,6 +77,49 @@ public ResultModel startGatewaySender(@CliOption(key =
CliStrings.START_GATEWAYS
return ResultModel.createError(CliStrings.NO_MEMBERS_FOUND_MESSAGE);
}
+if (cleanQueues) {
+
+ Set allServers = findMembers(null, null);
+
+ if (dsMembers.size() != allServers.size()) {
+return ResultModel.createError(CliStrings.EXECUTE_ON_ALL_MEMBERS);
+ }
+
+ GatewaySenderMXBean bean;
+ boolean commmandRejected = false;
+
+ ResultModel rejectResultModel =
+ ResultModel.createError(CliStrings.START_GATEWAYSENDER_REJECTED);
+ TabularResultModel rejectResultData =
+
rejectResultModel.addTable(CliStrings.REJECT_START_GATEWAYSENDER_REASON);
+
+ for (DistributedMember member : dsMembers) {
+if
(cache.getDistributedSystem().getDistributedMember().getId().equals(member.getId()))
{
+ bean = service.getLocalGatewaySenderMXBean(senderId);
+} else {
+ ObjectName objectName = service.getGatewaySenderMBeanName(member,
senderId);
+ bean = service.getMBeanProxy(objectName, GatewaySenderMXBean.class);
+}
+if (bean != null) {
+ if (bean.isRunning()) {
+commmandRejected = true;
+rejectResultData.addMemberStatusResultRow(member.getId(),
CliStrings.GATEWAY_ERROR,
+CliStrings.format(
+
CliStrings.GATEWAY_SENDER_0_IS_ALREADY_STARTED_ON_MEMBER_1, id,
+member.getId()));
+ }
+} else {
+ commmandRejected = true;
+ rejectResultData.addMemberStatusResultRow(member.getId(),
CliStrings.GATEWAY_ERROR,
+ CliStrings.format(
+ CliStrings.GATEWAY_SENDER_0_IS_NOT_AVAILABLE_ON_MEMBER_1,
id, member.getId()));
+}
+ }
Review Comment:
The same checks are performed just a few lines below in callable objects
which execute the command on a member. Do we need still need those checks? Or,
If they are required, is it possible to create a function that encapsulates
them to avoid duplicated code?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [geode-native] pivotal-jbarrett closed pull request #899: GEODE-9896: Upgrades dependencies.
pivotal-jbarrett closed pull request #899: GEODE-9896: Upgrades dependencies. URL: https://github.com/apache/geode-native/pull/899 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode-native] gaussianrecurrence commented on pull request #899: GEODE-9896: Upgrades dependencies.
gaussianrecurrence commented on PR #899: URL: https://github.com/apache/geode-native/pull/899#issuecomment-1248021514 Considering geode-native is not using ACE anymore and SQLite was already updated, and also there is another PR to update Boost, maybe this can be closed @pivotal-jbarrett ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode-native] gaussianrecurrence commented on a diff in pull request #968: GEODE-10291: Add ubuntu 22.04 (jammy) to CI
gaussianrecurrence commented on code in PR #968:
URL: https://github.com/apache/geode-native/pull/968#discussion_r971864236
##
docker/ubuntu-22.04/Dockerfile:
##
@@ -0,0 +1,67 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+FROM ubuntu:22.04
+LABEL maintainer Apache Geode
+
+USER root
+WORKDIR /
+
+ENV DEBIAN_FRONTEND noninteractive
+RUN apt update && \
+apt -yq full-upgrade && \
+apt-get -y install \
+apt-transport-https \
+ca-certificates \
+curl \
+gnupg2 \
+software-properties-common && \
+apt-get -y autoremove && \
+apt-get autoclean
+
+RUN . /etc/os-release && \
+curl -s https://download.bell-sw.com/pki/GPG-KEY-bellsoft | apt-key add -
&& \
+apt-add-repository "deb http://apt.bell-sw.com/ stable main"
+
+RUN apt update && apt -yq full-upgrade && apt-get -y install \
+build-essential \
+libc++-dev \
+libc++abi-dev \
+zlib1g-dev \
+libssl-dev \
+bellsoft-java11 \
+git \
+doxygen \
+graphviz \
+clang-format-12 && \
+apt-get -y autoremove && \
+apt-get autoclean
+
+# Get latest release of CMake ignoring pre-releases
+RUN installer=$(mktemp) \
+&& curl -o ${installer} -L $(curl -s
https://api.github.com/repos/Kitware/CMake/releases \
+| grep -P -i
'browser_download_url.*cmake-\d+\.\d+\.\d+-linux-x86_64\.sh' \
+| head -n 1 \
+| cut -d : -f 2,3 \
+| tr -d '"') \
+&& bash ${installer} --skip-license --prefix=/usr/local \
+&& rm ${installer}
+
+ARG GEODE_VERSION=1.14.4
Review Comment:
Considering latest version is 1.15.0, maybe this needs to be updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [geode] jvarenina opened a new pull request, #7859: GEODE-8856: Persist gateway-sender startup-action
jvarenina opened a new pull request, #7859: URL: https://github.com/apache/geode/pull/7859 New startup-action parameter with values "stop", "pause" and "start" is now persisted during the runtime when following commands are issued: - pause gateway-sender --> startup-action="pause" - stop gateway-sender --> startup-action="stop" - start gateway-sender --> startup-action="start" - resume gateway-sender --> startup-action="start" The startup-action parameter is persisted within cluster configuration when above gfsh commands are executed successfully on at least one of the servers. Parameter is not updated and persisted when commands are executed per member as cluster configuration is not persisted in that case. New startup-action parameter will now inter-work with manual-start in a following way: - If manual-start="true" and startup-action parameter is missing, then gateway sender will require manual start (same as before). - If manual-start is not set (or "false") and startup-action parameter is missing, then gateway sender will be started automatically (same as before). - If parameter startup-action is available in cluster configuration at startup, then gateway-sender will try to reach that state regardless of manual-start parameter value. The manual-start is also improved in order to fully comply to above requirement to start gateway sender in stopped state. Current problem with manual-start parameter: Currently, when manual-start is configured to be "true", then colocated persistent parallel gateway sender queue region and buckets are not recovered after server is restarted. Because of that the main persistent region that is colocated with gateway sender queue region cannot reach online status. Solution to manual-start problem implemented in this commit: When manual-start parameter is "true" or gateway sender startup-action is "stop", then persistent parallel gateway-sender queues will now be recovered (if needed) from persistent storage during startup of the server. Queues will be recovered by using the existing mechanism that is used when gateway sender is automatically recovered (manual-start==false) after server is restarted. In this case parallel gateway sender queue persistent region and buckets are recovered (if needed) right after the main persistent region and buckets are recovered. Additionally in above case, parallel gateway sender will now reach the same state that it has when first started and then stopped by using gfsh command. In that state parallel gateway sender queue buckets remain on the servers, but dispatcher threads are stopped and non of the events are stored in queues. ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [x] Is your initial contribution a single, squashed commit? - [x] Does `gradlew build` run cleanly? - [x] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] mkevo merged pull request #7855: GEODE-10415: bump dependencies due to vulnerability scan
mkevo merged PR #7855: URL: https://github.com/apache/geode/pull/7855 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] mivanac commented on pull request #7856: GEODE-10421: Improve start gw sender with clean-queue
mivanac commented on PR #7856: URL: https://github.com/apache/geode/pull/7856#issuecomment-1247118764 @jvarenina could you review this PR. Hope you will soon become commiter. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] mivanac merged pull request #7851: GEODE-10419: Enhancment of backup disk-store command
mivanac merged PR #7851: URL: https://github.com/apache/geode/pull/7851 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] mivanac merged pull request #7858: GEODE-10422: add Note for parallel recovery disk store
mivanac merged PR #7858: URL: https://github.com/apache/geode/pull/7858 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] mivanac commented on a diff in pull request #7851: GEODE-10419: Enhancment of backup disk-store command
mivanac commented on code in PR #7851:
URL: https://github.com/apache/geode/pull/7851#discussion_r970804245
##
geode-core/src/main/java/org/apache/geode/internal/cache/backup/BackupTask.java:
##
@@ -38,6 +42,7 @@
class BackupTask {
private static final Logger logger = LogService.getLogger();
+ private static final String CLUSTER_CONFIG_DISK_STORE_NAME =
"cluster_config";
Review Comment:
Thanks. Updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [geode] jvarenina commented on a diff in pull request #7851: GEODE-10419: Enhancment of backup disk-store command
jvarenina commented on code in PR #7851:
URL: https://github.com/apache/geode/pull/7851#discussion_r970802822
##
geode-core/src/main/java/org/apache/geode/internal/cache/backup/BackupTask.java:
##
@@ -38,6 +42,7 @@
class BackupTask {
private static final Logger logger = LogService.getLogger();
+ private static final String CLUSTER_CONFIG_DISK_STORE_NAME =
"cluster_config";
Review Comment:
Just a minor comment. Maybe to change the access modifier of
"InternalConfigurationPersistenceService.CLUSTER_CONFIG_DISK_STORE_NAME" to
public and use it instead of this one to avoid duplicated code.
No further comments from my side, everything else looks good. Good work!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [geode] mivanac commented on a diff in pull request #7851: GEODE-10419: Enhancment of backup disk-store command
mivanac commented on code in PR #7851: URL: https://github.com/apache/geode/pull/7851#discussion_r970681780 ## geode-docs/tools_modules/gfsh/command-pages/backup.html.md.erb: ## @@ -59,6 +59,11 @@ backup disk-store --dir=value [--baseline-dir=value] Directory that contains the baseline backup used for comparison during an incremental backup. An incremental backup operation backs up any data that is not present in the directory specified in baseline-dir. If the member cannot find previously backed up data or if the previously backed up data is corrupt, the command performs a full backup on that member. + +include-disk-stores +List of disk-stores to include in backup. +Selective backup of disk-stores listed in include-disk-stores. Specified disk-stores must exist in system. If parameter is not specified, all disk-stores are backup. Review Comment: I skipped that part. I will update. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] albertogpz commented on a diff in pull request #7851: GEODE-10419: Enhancment of backup disk-store command
albertogpz commented on code in PR #7851: URL: https://github.com/apache/geode/pull/7851#discussion_r970679236 ## geode-docs/tools_modules/gfsh/command-pages/backup.html.md.erb: ## @@ -59,6 +59,11 @@ backup disk-store --dir=value [--baseline-dir=value] Directory that contains the baseline backup used for comparison during an incremental backup. An incremental backup operation backs up any data that is not present in the directory specified in baseline-dir. If the member cannot find previously backed up data or if the previously backed up data is corrupt, the command performs a full backup on that member. + +include-disk-stores +List of disk-stores to include in backup. +Selective backup of disk-stores listed in include-disk-stores. Specified disk-stores must exist in system. If parameter is not specified, all disk-stores are backup. Review Comment: Any reason for not adding "this" in "If this parameter is not specified..."? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] mkevo opened a new pull request, #7858: GEODE-10422: add Note for parallel recovery disk store
mkevo opened a new pull request, #7858: URL: https://github.com/apache/geode/pull/7858 ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [x] Is your initial contribution a single, squashed commit? - [x] Does `gradlew build` run cleanly? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] mivanac commented on a diff in pull request #7851: GEODE-10419: Enhancment of backup disk-store command
mivanac commented on code in PR #7851: URL: https://github.com/apache/geode/pull/7851#discussion_r970661703 ## geode-docs/tools_modules/gfsh/command-pages/backup.html.md.erb: ## @@ -59,6 +59,11 @@ backup disk-store --dir=value [--baseline-dir=value] Directory that contains the baseline backup used for comparison during an incremental backup. An incremental backup operation backs up any data that is not present in the directory specified in baseline-dir. If the member cannot find previously backed up data or if the previously backed up data is corrupt, the command performs a full backup on that member. + +include-disk-stores +List of disk-stores to include in backup. +Selective backup of disk-stores listed in include-disk-stores. Specified disk-stores must exist in system. If parameter is not specified, all disk-stores are backup. Review Comment: Thanks for comments. Updated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] albertogpz commented on a diff in pull request #7851: GEODE-10419: Enhancment of backup disk-store command
albertogpz commented on code in PR #7851: URL: https://github.com/apache/geode/pull/7851#discussion_r970619899 ## geode-docs/tools_modules/gfsh/command-pages/backup.html.md.erb: ## @@ -59,6 +59,11 @@ backup disk-store --dir=value [--baseline-dir=value] Directory that contains the baseline backup used for comparison during an incremental backup. An incremental backup operation backs up any data that is not present in the directory specified in baseline-dir. If the member cannot find previously backed up data or if the previously backed up data is corrupt, the command performs a full backup on that member. + +include-disk-stores +List of disk-stores to include in backup. +Selective backup of disk-stores listed in include-disk-stores. Specified disk-stores must exist in system. If parameter is not specified, all disk-stores are backup. Review Comment: I suggest the following changes to the phrasing: The specified disk-stores must exist in the system. If this parameter is not specified, all disk-stores are included in the backup. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] albertogpz commented on pull request #7851: GEODE-10419: initial commit
albertogpz commented on PR #7851: URL: https://github.com/apache/geode/pull/7851#issuecomment-1246547375 > RFC is linked in ticket, but I can also add description in PR. Yes, looking at the ticket you reach the RFC. But it would be nice to know from the title of the PR what this PR is about. The description could be optional. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] mivanac commented on pull request #7851: GEODE-10419: initial commit
mivanac commented on PR #7851: URL: https://github.com/apache/geode/pull/7851#issuecomment-1246541895 RFC is linked in ticket, but I can also add description in PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] WeijieEST opened a new pull request, #7857: GEODE-10410: Fix bucket lost during rebalance
WeijieEST opened a new pull request, #7857: URL: https://github.com/apache/geode/pull/7857 ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [ ] Is your initial contribution a single, squashed commit? - [ ] Does `gradlew build` run cleanly? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] mivanac opened a new pull request, #7856: GEODE-10421: added check gw status
mivanac opened a new pull request, #7856: URL: https://github.com/apache/geode/pull/7856 ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [ ] Is your initial contribution a single, squashed commit? - [ ] Does `gradlew build` run cleanly? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode-native] albertogpz merged pull request #981: GEODE-10402: Fix FunctionException handling
albertogpz merged PR #981: URL: https://github.com/apache/geode-native/pull/981 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] mkevo opened a new pull request, #7855: GEODE-10415: bump dependencies due to vulnerability scan
mkevo opened a new pull request, #7855: URL: https://github.com/apache/geode/pull/7855 ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [x] Is your initial contribution a single, squashed commit? - [x] Does `gradlew build` run cleanly? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] albertogpz merged pull request #7854: GEODE-10420: Finish distribute() work if interrupted
albertogpz merged PR #7854: URL: https://github.com/apache/geode/pull/7854 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] jvarenina commented on pull request #7854: GEODE-10420: Finish distribute() work if interrupted
jvarenina commented on PR #7854: URL: https://github.com/apache/geode/pull/7854#issuecomment-1243568103 Looks good to me! No comments from my side. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode-native] gaussianrecurrence opened a new pull request, #984: GEODE-10414: Implement Region::putIfAbsent method
gaussianrecurrence opened a new pull request, #984: URL: https://github.com/apache/geode-native/pull/984 - Moved PUT actions from LocalRegion into its own modules. - Added PutIfAbsent action. - Added the necessary scaffolding for put requests to return a value. - Moved TcrMessagePut implementation into its own file. Now this message type accepts an operation as input. - Moved TcrMessageDestroy implementation into its own file. Now this message accepts an operation as input. - Also, updated TcrMessageDestroy operation format so it uses a byte part instead of an object. - Added putIfAbsent method to the Region interface and its implementations both for LocalRegion and ThinClientRegion. - Modified LocalRegion and ThinClientRegion to comply with the above code changes. - Modified PUT's old value parsing to handle null pointer. - Also replaced Cacheable type by Serializable in some places in order in order to take advantage of fast-forward definition. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] albertogpz opened a new pull request, #7854: GEODE-10420: Finish distribute() work if interrupted
albertogpz opened a new pull request, #7854: URL: https://github.com/apache/geode/pull/7854 It is possible that an event of which a gateway sender is to be notified is lost if during the process the thread is interrupted. The reason is that the distribute() method in the AbstractGatewaySender when it catches the InterruptedException at some point, just returns, but does not put the event in the queue and neither drops it. The fix consists of handling the event correctly (put it in the queue or drop it) if the InterruptedException is caught but when the method returns set again the interrupt flag so that the caller is aware. ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [ ] Is your initial contribution a single, squashed commit? - [ ] Does `gradlew build` run cleanly? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] albertogpz closed pull request #7852: Finish distribute() work if interrupted
albertogpz closed pull request #7852: Finish distribute() work if interrupted URL: https://github.com/apache/geode/pull/7852 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] albertogpz merged pull request #7839: GEODE-10409: Fix rebalance load model missing collocated regions at s…
albertogpz merged PR #7839: URL: https://github.com/apache/geode/pull/7839 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] mkevo merged pull request #7853: GEODE-9484: Improve sending message to multy destinations (#7664)
mkevo merged PR #7853: URL: https://github.com/apache/geode/pull/7853 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] mkevo opened a new pull request, #7853: GEODE-9484: Improve sending message to multy destinations (#7664)
mkevo opened a new pull request, #7853: URL: https://github.com/apache/geode/pull/7853 ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [x] Is your initial contribution a single, squashed commit? - [x] Does `gradlew build` run cleanly? - [x] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] albertogpz opened a new pull request, #7852: Finish distribute() work if interrupted
albertogpz opened a new pull request, #7852: URL: https://github.com/apache/geode/pull/7852 ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [ ] Is your initial contribution a single, squashed commit? - [ ] Does `gradlew build` run cleanly? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] mivanac opened a new pull request, #7851: GEODE-10419: initial commit
mivanac opened a new pull request, #7851: URL: https://github.com/apache/geode/pull/7851 ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [ ] Is your initial contribution a single, squashed commit? - [ ] Does `gradlew build` run cleanly? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] mivanac merged pull request #7850: GEODE-10335_1: add compareAndSet
mivanac merged PR #7850: URL: https://github.com/apache/geode/pull/7850 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] mivanac opened a new pull request, #7850: GEODE-10335_1: add compareAndSet
mivanac opened a new pull request, #7850: URL: https://github.com/apache/geode/pull/7850 ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [ ] Is your initial contribution a single, squashed commit? - [ ] Does `gradlew build` run cleanly? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] mivanac merged pull request #7843: GEODE-10336: set lastInstance to null
mivanac merged PR #7843: URL: https://github.com/apache/geode/pull/7843 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
