[GitHub] [geode] metatype closed pull request #7803: GEODE-10354: Convert enum like classes to enum.
metatype closed pull request #7803: GEODE-10354: Convert enum like classes to enum. URL: https://github.com/apache/geode/pull/7803 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] metatype closed pull request #7816: GEODE-10393: Add generic type on return type
metatype closed pull request #7816: GEODE-10393: Add generic type on return type URL: https://github.com/apache/geode/pull/7816 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] metatype closed pull request #7766: [DRAFT] GEODE-10350: volunteerForPrimary should proceed when being elector or…
metatype closed pull request #7766: [DRAFT] GEODE-10350: volunteerForPrimary should proceed when being elector or… URL: https://github.com/apache/geode/pull/7766 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] metatype closed pull request #7756: Bulk op holder test
metatype closed pull request #7756: Bulk op holder test URL: https://github.com/apache/geode/pull/7756 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] metatype closed pull request #7684: Initial investigation of branchless/vesrionless client/server messages.
metatype closed pull request #7684: Initial investigation of branchless/vesrionless client/server messages. URL: https://github.com/apache/geode/pull/7684 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] metatype closed pull request #7661: [Don't review] GEODE-10279: Need to lock RVV and flush before backup
metatype closed pull request #7661: [Don't review] GEODE-10279: Need to lock RVV and flush before backup URL: https://github.com/apache/geode/pull/7661 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] metatype closed pull request #7610: GEODE-10250: Drop lock request if member departed
metatype closed pull request #7610: GEODE-10250: Drop lock request if member departed URL: https://github.com/apache/geode/pull/7610 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] metatype commented on pull request #7610: GEODE-10250: Drop lock request if member departed
metatype commented on PR #7610: URL: https://github.com/apache/geode/pull/7610#issuecomment-1172786024 Closing this out due to age. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] metatype closed pull request #7516: Trial: port authentication expiry to 1.13
metatype closed pull request #7516: Trial: port authentication expiry to 1.13 URL: https://github.com/apache/geode/pull/7516 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] metatype commented on pull request #7516: Trial: port authentication expiry to 1.13
metatype commented on PR #7516: URL: https://github.com/apache/geode/pull/7516#issuecomment-1172785578 Closing this out due to age. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] metatype commented on pull request #7514: GEODE-10183: Create tests for Transaction with loaders
metatype commented on PR #7514: URL: https://github.com/apache/geode/pull/7514#issuecomment-1172785522 Closing this out due to age. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] metatype closed pull request #7514: GEODE-10183: Create tests for Transaction with loaders
metatype closed pull request #7514: GEODE-10183: Create tests for Transaction with loaders URL: https://github.com/apache/geode/pull/7514 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] metatype closed pull request #7479: Trail: back-port auth expiry to support/1.14
metatype closed pull request #7479: Trail: back-port auth expiry to support/1.14 URL: https://github.com/apache/geode/pull/7479 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] metatype commented on pull request #7479: Trail: back-port auth expiry to support/1.14
metatype commented on PR #7479: URL: https://github.com/apache/geode/pull/7479#issuecomment-1172785422 Closing due to age. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] metatype closed pull request #7446: WIP - ignore
metatype closed pull request #7446: WIP - ignore URL: https://github.com/apache/geode/pull/7446 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] metatype closed pull request #7435: GEODE-10039: Add profiles to queue when PR is in initialization mode.
metatype closed pull request #7435: GEODE-10039: Add profiles to queue when PR is in initialization mode. URL: https://github.com/apache/geode/pull/7435 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] metatype closed pull request #7427: GEODE-288: Removes MX4J and minimally required classes.
metatype closed pull request #7427: GEODE-288: Removes MX4J and minimally required classes. URL: https://github.com/apache/geode/pull/7427 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] metatype commented on pull request #7427: GEODE-288: Removes MX4J and minimally required classes.
metatype commented on PR #7427: URL: https://github.com/apache/geode/pull/7427#issuecomment-1172784962 Closing this out due to age. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] metatype closed pull request #7385: DRAFT: P2P protocol validator
metatype closed pull request #7385: DRAFT: P2P protocol validator URL: https://github.com/apache/geode/pull/7385 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] metatype commented on pull request #7385: DRAFT: P2P protocol validator
metatype commented on PR #7385: URL: https://github.com/apache/geode/pull/7385#issuecomment-1172784835 Closing this out due to age. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] metatype closed pull request #7211: GEODE-10354: Convert enum like classes to enum.
metatype closed pull request #7211: GEODE-10354: Convert enum like classes to enum. URL: https://github.com/apache/geode/pull/7211 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] metatype commented on pull request #7211: GEODE-10354: Convert enum like classes to enum.
metatype commented on PR #7211: URL: https://github.com/apache/geode/pull/7211#issuecomment-1172784469 Closing this out until the open questions are resolved. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] metatype closed pull request #7161: add ability to turn off buffer pooling
metatype closed pull request #7161: add ability to turn off buffer pooling URL: https://github.com/apache/geode/pull/7161 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] metatype commented on pull request #7161: add ability to turn off buffer pooling
metatype commented on PR #7161: URL: https://github.com/apache/geode/pull/7161#issuecomment-1172784022 Closing this out due to age. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] metatype commented on pull request #7060: Replace inconsistent use of Integer and int with BucketId.
metatype commented on PR #7060: URL: https://github.com/apache/geode/pull/7060#issuecomment-1172783948 Closing this out due to age. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] metatype closed pull request #7060: Replace inconsistent use of Integer and int with BucketId.
metatype closed pull request #7060: Replace inconsistent use of Integer and int with BucketId. URL: https://github.com/apache/geode/pull/7060 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] metatype closed pull request #6688: GEODE-9418: Add Rolling Upgrade Tests for Tomcat 9
metatype closed pull request #6688: GEODE-9418: Add Rolling Upgrade Tests for Tomcat 9 URL: https://github.com/apache/geode/pull/6688 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] metatype commented on pull request #6688: GEODE-9418: Add Rolling Upgrade Tests for Tomcat 9
metatype commented on PR #6688: URL: https://github.com/apache/geode/pull/6688#issuecomment-1172783765 Closing this out due to age. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] metatype closed pull request #6440: DRAFT: Add New (Optional) Non-Differential Quorum Algorithm
metatype closed pull request #6440: DRAFT: Add New (Optional) Non-Differential Quorum Algorithm URL: https://github.com/apache/geode/pull/6440 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] metatype commented on pull request #6440: DRAFT: Add New (Optional) Non-Differential Quorum Algorithm
metatype commented on PR #6440: URL: https://github.com/apache/geode/pull/6440#issuecomment-1172783700 Closing this out due to age. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] metatype commented on pull request #7820: Decommission CODEOWNERS
metatype commented on PR #7820: URL: https://github.com/apache/geode/pull/7820#issuecomment-1172781598 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode-kafka-connector] JLLeitschuh opened a new pull request, #21: [SECURITY] Use HTTPS to resolve dependencies in Maven Build
JLLeitschuh opened a new pull request, #21: URL: https://github.com/apache/geode-kafka-connector/pull/21 [](https://medium.com/@jonathan.leitschuh/want-to-take-over-the-java-ecosystem-all-you-need-is-a-mitm-1fc329d898fb?source=friends_link&sk=3c99970c55a899ad9ef41f126efcde0e) --- This is a security fix for a high severity vulnerability in your [Apache Maven](https://maven.apache.org/) `pom.xml` file(s). The build files indicate that this project is resolving dependencies over HTTP instead of HTTPS. This leaves your build vulnerable to allowing a [Man in the Middle](https://en.wikipedia.org/wiki/Man-in-the-middle_attack) (MITM) attackers to execute arbitrary code on your or your computer or CI/CD system. This vulnerability has a CVSS v3.0 Base Score of [8.1/10](https://nvd.nist.gov/vuln-metrics/cvss/v3-calculator?vector=AV:N/AC:H/PR:N/UI:N/S:U/C:H/I:H/A:H). [POC code](https://max.computer/blog/how-to-take-over-the-computer-of-any-java-or-clojure-or-scala-developer/) has existed since 2014 to maliciously compromise a JAR file in-flight. MITM attacks against HTTP are [increasingly common](https://security.stackexchange.com/a/12050), for example [Comcast is known to have done it to their own users](https://thenextweb.com/insights/2017/12/11/comcast-continues-to-inject-its-own-code-into-websites-you-visit/#). This contribution is a part of a submission to the [GitHub Security Lab](https://securitylab.github.com/) Bug Bounty program. ## Resources - [Want to take over the Java ecosystem? All you need is a MITM!](https://medium.com/@jonathan.leitschuh/want-to-take-over-the-java-ecosystem-all-you-need-is-a-mitm-1fc329d898fb?source=friends_link&sk=3c99970c55a899ad9ef41f126efcde0e) - [Update: Want to take over the Java ecosystem? All you need is a MITM!](https://medium.com/bugbountywriteup/update-want-to-take-over-the-java-ecosystem-all-you-need-is-a-mitm-d069d253fe23?source=friends_link&sk=8c8e52a7d57b98d0b7e541665688b454) - [CVE-2021-26291](https://nvd.nist.gov/vuln/detail/CVE-2021-26291) ## Detecting this and Future Vulnerabilities This vulnerability was automatically detected by GitHub's [LGTM.com](https://lgtm.com) using this [CodeQL Query](https://lgtm.com/rules/155648721/). You can automatically detect future vulnerabilities like this by enabling the free (for open-source) [GitHub Action](https://github.com/github/codeql-action). I'm not an employee of GitHub, I'm simply an open-source security researcher. ## Source This contribution was automatically generated with an [OpenRewrite](https://github.com/openrewrite/rewrite) [refactoring recipe](https://docs.openrewrite.org/), which was lovingly hand crafted to bring this security fix to your repository. The source code that generated this PR can be found here: [UseHttpsForRepositories](https://github.com/openrewrite/rewrite/blob/f8c139d0d66ad9a60ee73b95b7a79571e4820769/rewrite-maven/src/main/java/org/openrewrite/maven/security/UseHttpsForRepositories.java) ## Opting-Out If you'd like to opt-out of future automated security vulnerability fixes like this, please consider adding a file called `.github/GH-ROBOTS.txt` to your repository with the line: ``` User-agent: JLLeitschuh/security-research Disallow: * ``` This bot will respect the [ROBOTS.txt](https://moz.com/learn/seo/robotstxt) format for future contributions. Alternatively, if this project is no longer actively maintained, consider [archiving](https://help.github.com/en/github/creating-cloning-and-archiving-repositories/about-archiving-repositories) the repository. ## CLA Requirements _This section is only relevant if your project requires contributors to sign a Contributor License Agreement (CLA) for external contributions._ It is unlikely that I'll be able to directly sign CLAs. However, all contributed commits are already automatically signed-off. > The meaning of a signoff depends on the project, but it typically certifies that committer has the rights to submit this work under the same license and agrees to a Developer Certificate of Origin > (see [https://developercertificate.org/](https://developercertificate.org/) for more information). > > \- [Git Commit Signoff documentation](https://developercertificate.org/) If signing your organization's CLA is a strict-requirement for merging this contribution, please feel free to close this PR. ## Sponsorship & Support This contribution is sponsored by HUMAN Security Inc. and the new Dan Kaminsky Fellowship, a fellowship created to celebrate Dan's memory and legacy by funding open-source work that makes the world a better (and more secure) place. This PR was generated by
[GitHub] [geode] mivanac merged pull request #7664: GEODE-9484: Improve sending message to multy destinations
mivanac merged PR #7664: URL: https://github.com/apache/geode/pull/7664 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] pivotal-jbarrett closed pull request #7262: GEODE-6588: Cleanup static analyzer warnings.
pivotal-jbarrett closed pull request #7262: GEODE-6588: Cleanup static analyzer warnings. URL: https://github.com/apache/geode/pull/7262 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] mivanac commented on a diff in pull request #7664: GEODE-9484: Improve sending message to multy destinations
mivanac commented on code in PR #7664:
URL: https://github.com/apache/geode/pull/7664#discussion_r911633021
##
geode-core/src/distributedTest/java/org/apache/geode/internal/cache/tier/sockets/UpdatePropagationDistributedTest.java:
##
@@ -258,7 +309,7 @@ private Integer createServerCache() throws Exception {
server.setPort(port);
server.setNotifyBySubscription(true);
server.start();
-return server.getPort();
+return new Integer(server.getPort());
Review Comment:
Thanks for comments. Updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [geode-benchmarks] nonbinaryprogrammer closed pull request #163: move baseline to most recent release
nonbinaryprogrammer closed pull request #163: move baseline to most recent release URL: https://github.com/apache/geode-benchmarks/pull/163 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] mivanac merged pull request #7323: GEODE-9997: added ParallelQueueSetPossibleDuplicateMessage
mivanac merged PR #7323: URL: https://github.com/apache/geode/pull/7323 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] onichols-pivotal merged pull request #7820: Decommission CODEOWNERS
onichols-pivotal merged PR #7820: URL: https://github.com/apache/geode/pull/7820 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] mivanac commented on a diff in pull request #7323: GEODE-9997: added ParallelQueueSetPossibleDuplicateMessage
mivanac commented on code in PR #7323:
URL: https://github.com/apache/geode/pull/7323#discussion_r909257939
##
geode-core/src/main/java/org/apache/geode/cache/wan/GatewaySender.java:
##
@@ -215,6 +216,34 @@ enum OrderPolicy {
*/
void startWithCleanQueue();
+
+ /**
+ * Prepare GatewaySender for closing of Cache.
+ *
+ *
+ * Implementation of new API in ParallelGatewaySenderImpl:
+ *
+ *
+ *
+ * public void prepareForStop() {
+ * if (!isRunning()) {
+ * return;
+ * }
+ * pause();
+ * if (eventProcessor != null && !eventProcessor.isStopped()) {
+ * eventProcessor.prepareForStopProcessing();
+ * }
+ * }
+ *
+ *
+ *
+ *
+ * Invoked at closing of cache.
+ *
+ */
+ @Experimental
+ void prepareForStop();
Review Comment:
Hi @kirklund , are changes now OK?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [geode] mivanac merged pull request #7749: GEODE-10020: For Ping task avoid registering new destination endpoint
mivanac merged PR #7749: URL: https://github.com/apache/geode/pull/7749 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] pivotal-jbarrett commented on a diff in pull request #7664: Newfeature2/geode 9484
pivotal-jbarrett commented on code in PR #7664:
URL: https://github.com/apache/geode/pull/7664#discussion_r908656969
##
geode-core/src/distributedTest/java/org/apache/geode/internal/cache/tier/sockets/UpdatePropagationDistributedTest.java:
##
@@ -258,7 +309,7 @@ private Integer createServerCache() throws Exception {
server.setPort(port);
server.setNotifyBySubscription(true);
server.start();
-return server.getPort();
+return new Integer(server.getPort());
Review Comment:
Unnecessary explicit integer boxing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [geode] pivotal-jbarrett commented on pull request #7664: Newfeature2/geode 9484
pivotal-jbarrett commented on PR #7664: URL: https://github.com/apache/geode/pull/7664#issuecomment-1168905264 This PR would probably get more notice with a properly formatted and descriptive title. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] onichols-pivotal opened a new pull request, #7820: Decommission CODEOWNERS
onichols-pivotal opened a new pull request, #7820: URL: https://github.com/apache/geode/pull/7820 CODEOWNERS has been a fun experiment, at times mildly helpful but more often just getting in the way. I propose a return to a simpler system of minimum 1 reviewer, no red tape. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] gesterzhou closed pull request #7752: [Do not review] GEODE-10349: Client connects to a new server socket should check its …
gesterzhou closed pull request #7752: [Do not review] GEODE-10349: Client connects to a new server socket should check its … URL: https://github.com/apache/geode/pull/7752 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] davebarnes97 merged pull request #7815: GEODE-10385: User Guide - Remove bad G1GC tuning advice
davebarnes97 merged PR #7815: URL: https://github.com/apache/geode/pull/7815 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] Bill closed pull request #7293: Diagnostic code for a P2P messaging Tag Mismatch exception
Bill closed pull request #7293: Diagnostic code for a P2P messaging Tag Mismatch exception URL: https://github.com/apache/geode/pull/7293 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] Bill closed pull request #7336: DRAFT NO MERGE: Latest support/1.13 sans ByteBuffer sharing framework
Bill closed pull request #7336: DRAFT NO MERGE: Latest support/1.13 sans ByteBuffer sharing framework URL: https://github.com/apache/geode/pull/7336 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] Bill closed pull request #7398: DRAFT log P2P TLS proto+cipher before/after handshake
Bill closed pull request #7398: DRAFT log P2P TLS proto+cipher before/after handshake URL: https://github.com/apache/geode/pull/7398 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] Bill closed pull request #7614: GEODE-9402: DRAFT: Experimenting with member reconnect to see if there is a port binding bug
Bill closed pull request #7614: GEODE-9402: DRAFT: Experimenting with member reconnect to see if there is a port binding bug URL: https://github.com/apache/geode/pull/7614 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] mivanac commented on pull request #7664: Newfeature2/geode 9484
mivanac commented on PR #7664: URL: https://github.com/apache/geode/pull/7664#issuecomment-1164325248 Hi @Bill, @echobravopapa, @agingade, @kamilla1201 and @pivotal-jbarrett could you review this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] nabarunnag closed pull request #7786: GEODE-10370: More info added to javadocs
nabarunnag closed pull request #7786: GEODE-10370: More info added to javadocs URL: https://github.com/apache/geode/pull/7786 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] albertogpz opened a new pull request, #7819: GEODE-10323: Add small changes after review
albertogpz opened a new pull request, #7819: URL: https://github.com/apache/geode/pull/7819 This PR is a continuation of the original one (https://github.com/apache/geode/pull/7715) addressing some small review comments that were received after the PR was merged. ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [ ] Is your initial contribution a single, squashed commit? - [ ] Does `gradlew build` run cleanly? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] kirklund closed pull request #7196: GEODE-9893: Add formatMsgNoLookups logging tests
kirklund closed pull request #7196: GEODE-9893: Add formatMsgNoLookups logging tests URL: https://github.com/apache/geode/pull/7196 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] kirklund closed pull request #7765: GEODE-10358: Add new DmTypesDistributedTest
kirklund closed pull request #7765: GEODE-10358: Add new DmTypesDistributedTest URL: https://github.com/apache/geode/pull/7765 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] kirklund closed pull request #7791: GEODE-10366: Cleanup GfshRule created Folder
kirklund closed pull request #7791: GEODE-10366: Cleanup GfshRule created Folder URL: https://github.com/apache/geode/pull/7791 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode-native] onichols-pivotal opened a new pull request, #976: GEODE-10089: Bump Geode version to 1.15.0
onichols-pivotal opened a new pull request, #976: URL: https://github.com/apache/geode-native/pull/976 Native client hardcodes Geode version to test with in several places. Update those variables to latest-and-greatest apache-geode 1.15.0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] onichols-pivotal opened a new pull request, #7818: GEODE-10089: Add 1.15.0 as old version
onichols-pivotal opened a new pull request, #7818: URL: https://github.com/apache/geode/pull/7818 Add 1.15.0 in old versions and set as Benchmarks baseline on develop to enable rolling upgrade tests from 1.15.0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] albertogpz commented on a diff in pull request #7715: GEODE-10323: Remove schedule threads in MemoryAllocatorImpl constructor
albertogpz commented on code in PR #7715:
URL: https://github.com/apache/geode/pull/7715#discussion_r904097756
##
geode-core/src/main/java/org/apache/geode/internal/offheap/MemoryAllocatorImpl.java:
##
@@ -239,11 +230,19 @@ private MemoryAllocatorImpl(final
OutOfOffHeapMemoryListener oooml,
this.stats.incMaxMemory(freeList.getTotalMemory());
this.stats.incFreeMemory(freeList.getTotalMemory());
-updateNonRealTimeStatsExecutor =
-LoggingExecutors.newSingleThreadScheduledExecutor("Update Freelist
Stats thread");
-updateNonRealTimeStatsFuture =
-
updateNonRealTimeStatsExecutor.scheduleAtFixedRate(freeList::updateNonRealTimeStats,
0,
-updateOffHeapStatsFrequencyMs, TimeUnit.MILLISECONDS);
+this.updateOffHeapStatsFrequencyMs = updateOffHeapStatsFrequencyMs;
+
+if (nonRealTimeStatsUpdaterSupplier == null) {
+ nonRealTimeStatsUpdater = new
NonRealTimeStatsUpdater(freeList::updateNonRealTimeStats);
+} else {
+ nonRealTimeStatsUpdater = nonRealTimeStatsUpdaterSupplier.get();
+}
+ }
+
+ void start() {
+if (nonRealTimeStatsUpdater != null) {
Review Comment:
I agree. As I was too quick to merge the PR, should I open a new one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [geode] albertogpz commented on a diff in pull request #7715: GEODE-10323: Remove schedule threads in MemoryAllocatorImpl constructor
albertogpz commented on code in PR #7715:
URL: https://github.com/apache/geode/pull/7715#discussion_r904097361
##
geode-core/src/main/java/org/apache/geode/internal/offheap/MemoryAllocatorImpl.java:
##
@@ -98,20 +95,17 @@ public static MemoryAllocatorImpl getAllocator() {
public static MemoryAllocator create(OutOfOffHeapMemoryListener ooohml,
OffHeapMemoryStats stats,
int slabCount, long offHeapMemorySize, long maxSlabSize,
- int updateOffHeapStatsFrequencyMs) {
+ Supplier updateOffHeapStatsFrequencyMsSupplier,
+ Supplier nonRealTimeStatsUpdaterSupplier) {
return create(ooohml, stats, slabCount, offHeapMemorySize, maxSlabSize,
null,
-SlabImpl::new, updateOffHeapStatsFrequencyMs);
+SlabImpl::new, updateOffHeapStatsFrequencyMsSupplier,
nonRealTimeStatsUpdaterSupplier);
}
- public static MemoryAllocator create(OutOfOffHeapMemoryListener ooohml,
OffHeapMemoryStats stats,
- int slabCount, long offHeapMemorySize, long maxSlabSize) {
-return create(ooohml, stats, slabCount, offHeapMemorySize, maxSlabSize,
null,
-SlabImpl::new, UPDATE_OFF_HEAP_STATS_FREQUENCY_MS);
- }
-
- private static MemoryAllocatorImpl create(OutOfOffHeapMemoryListener ooohml,
+ static MemoryAllocatorImpl create(OutOfOffHeapMemoryListener ooohml,
OffHeapMemoryStats stats, int slabCount, long offHeapMemorySize, long
maxSlabSize,
- Slab[] slabs, SlabFactory slabFactory, int
updateOffHeapStatsFrequencyMs) {
+ Slab[] slabs, SlabFactory slabFactory,
+ Supplier updateOffHeapStatsFrequencyMsSupplier,
Review Comment:
It's a good idea but there is one test case in which you don't pass a
Supplier so that the default `NonRealTimeStatsUpdater` is constructed but you
need to specify a smaller frequency so that the test does not need to wait for
the default frequency value:
See `testUpdateNonRealTimeOffHeapStorageStats()` from class
`OffHeapStorageNonRuntimeStatsJUnitTest`.
For this test case I would need to specify the frequency but not the
supplier.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [geode] jinmeiliao closed pull request #7792: GEODE-10364: do not log file content in management rest request
jinmeiliao closed pull request #7792: GEODE-10364: do not log file content in management rest request URL: https://github.com/apache/geode/pull/7792 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] jinmeiliao closed pull request #7795: GEODE-10375: improve test to catch doc link update
jinmeiliao closed pull request #7795: GEODE-10375: improve test to catch doc link update URL: https://github.com/apache/geode/pull/7795 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] jinmeiliao closed pull request #7727: Do Not Review: run stress test
jinmeiliao closed pull request #7727: Do Not Review: run stress test URL: https://github.com/apache/geode/pull/7727 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] dschneider-pivotal commented on a diff in pull request #7715: GEODE-10323: Remove schedule threads in MemoryAllocatorImpl constructor
dschneider-pivotal commented on code in PR #7715:
URL: https://github.com/apache/geode/pull/7715#discussion_r904053762
##
geode-core/src/main/java/org/apache/geode/internal/offheap/MemoryAllocatorImpl.java:
##
@@ -98,20 +95,17 @@ public static MemoryAllocatorImpl getAllocator() {
public static MemoryAllocator create(OutOfOffHeapMemoryListener ooohml,
OffHeapMemoryStats stats,
int slabCount, long offHeapMemorySize, long maxSlabSize,
- int updateOffHeapStatsFrequencyMs) {
+ Supplier updateOffHeapStatsFrequencyMsSupplier,
+ Supplier nonRealTimeStatsUpdaterSupplier) {
return create(ooohml, stats, slabCount, offHeapMemorySize, maxSlabSize,
null,
-SlabImpl::new, updateOffHeapStatsFrequencyMs);
+SlabImpl::new, updateOffHeapStatsFrequencyMsSupplier,
nonRealTimeStatsUpdaterSupplier);
}
- public static MemoryAllocator create(OutOfOffHeapMemoryListener ooohml,
OffHeapMemoryStats stats,
- int slabCount, long offHeapMemorySize, long maxSlabSize) {
-return create(ooohml, stats, slabCount, offHeapMemorySize, maxSlabSize,
null,
-SlabImpl::new, UPDATE_OFF_HEAP_STATS_FREQUENCY_MS);
- }
-
- private static MemoryAllocatorImpl create(OutOfOffHeapMemoryListener ooohml,
+ static MemoryAllocatorImpl create(OutOfOffHeapMemoryListener ooohml,
OffHeapMemoryStats stats, int slabCount, long offHeapMemorySize, long
maxSlabSize,
- Slab[] slabs, SlabFactory slabFactory, int
updateOffHeapStatsFrequencyMs) {
+ Slab[] slabs, SlabFactory slabFactory,
+ Supplier updateOffHeapStatsFrequencyMsSupplier,
Review Comment:
It seems like the update frequency "int" should be part of the
NonRealTimeStatsUpdater and then you wouldn't need two suppliers.
##
geode-core/src/main/java/org/apache/geode/internal/offheap/MemoryAllocatorImpl.java:
##
@@ -239,11 +230,19 @@ private MemoryAllocatorImpl(final
OutOfOffHeapMemoryListener oooml,
this.stats.incMaxMemory(freeList.getTotalMemory());
this.stats.incFreeMemory(freeList.getTotalMemory());
-updateNonRealTimeStatsExecutor =
-LoggingExecutors.newSingleThreadScheduledExecutor("Update Freelist
Stats thread");
-updateNonRealTimeStatsFuture =
-
updateNonRealTimeStatsExecutor.scheduleAtFixedRate(freeList::updateNonRealTimeStats,
0,
-updateOffHeapStatsFrequencyMs, TimeUnit.MILLISECONDS);
+this.updateOffHeapStatsFrequencyMs = updateOffHeapStatsFrequencyMs;
+
+if (nonRealTimeStatsUpdaterSupplier == null) {
+ nonRealTimeStatsUpdater = new
NonRealTimeStatsUpdater(freeList::updateNonRealTimeStats);
+} else {
+ nonRealTimeStatsUpdater = nonRealTimeStatsUpdaterSupplier.get();
+}
+ }
+
+ void start() {
+if (nonRealTimeStatsUpdater != null) {
Review Comment:
In the constructor above it looks like you always initialize
nonRealTimeStatsUpdaterSupplier to non-null. So what good are these null
checks? Oh I see. Your supplier returns null. That works but I think it would
be better to have the supplier returns a dummy NonRealTimeStatsUpdater that
does nothing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [geode] albertogpz merged pull request #7715: GEODE-10323: Remove schedule threads in MemoryAllocatorImpl constructor
albertogpz merged PR #7715: URL: https://github.com/apache/geode/pull/7715 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] kirklund closed pull request #7589: [DO NOT REVIEW] Bump Micrometer to 1.10.0-SNAPSHOT
kirklund closed pull request #7589: [DO NOT REVIEW] Bump Micrometer to 1.10.0-SNAPSHOT URL: https://github.com/apache/geode/pull/7589 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] kirklund closed pull request #7719: [DO NOT REVIEW] Run ClusterCommunicationsDUnitTest in stress-new-test
kirklund closed pull request #7719: [DO NOT REVIEW] Run ClusterCommunicationsDUnitTest in stress-new-test URL: https://github.com/apache/geode/pull/7719 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode-benchmarks] upthewaterspout closed pull request #147: GEODE-9175: Logging progress of benchmarks as they are running
upthewaterspout closed pull request #147: GEODE-9175: Logging progress of benchmarks as they are running URL: https://github.com/apache/geode-benchmarks/pull/147 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] yozaner1324 closed pull request #7348: GEODE-8705: Introduce classloader isolation for deployments using JBoss Modules.
yozaner1324 closed pull request #7348: GEODE-8705: Introduce classloader isolation for deployments using JBoss Modules. URL: https://github.com/apache/geode/pull/7348 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] Bill closed pull request #7785: GEODE-10391: Delay Sync After Member Departure, Whether or Not Clients Are Present
Bill closed pull request #7785: GEODE-10391: Delay Sync After Member Departure, Whether or Not Clients Are Present URL: https://github.com/apache/geode/pull/7785 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] animatedmax closed pull request #7799: GEODE-10363: add geode-deployment-legacy.jar to list of files to copy
animatedmax closed pull request #7799: GEODE-10363: add geode-deployment-legacy.jar to list of files to copy URL: https://github.com/apache/geode/pull/7799 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] demery-pivotal closed pull request #7807: spike/traverser
demery-pivotal closed pull request #7807: spike/traverser URL: https://github.com/apache/geode/pull/7807 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] jchen21 closed pull request #7588: Gem 2729
jchen21 closed pull request #7588: Gem 2729 URL: https://github.com/apache/geode/pull/7588 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] jchen21 closed pull request #7724: Feature/member reconnect bind bug repro
jchen21 closed pull request #7724: Feature/member reconnect bind bug repro URL: https://github.com/apache/geode/pull/7724 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] dschneider-pivotal closed pull request #7456: make ResourceManager's interaction with JVM customizable with the HeapUsageProvider SPI
dschneider-pivotal closed pull request #7456: make ResourceManager's interaction with JVM customizable with the HeapUsageProvider SPI URL: https://github.com/apache/geode/pull/7456 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] dschneider-pivotal closed pull request #7717: on close/disconnect clear statics that keep large objects alive
dschneider-pivotal closed pull request #7717: on close/disconnect clear statics that keep large objects alive URL: https://github.com/apache/geode/pull/7717 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] dschneider-pivotal closed pull request #7640: added test to verify a Proxy instance can be sized
dschneider-pivotal closed pull request #7640: added test to verify a Proxy instance can be sized URL: https://github.com/apache/geode/pull/7640 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] dschneider-pivotal closed pull request #7509: trying to skip proxy instances
dschneider-pivotal closed pull request #7509: trying to skip proxy instances URL: https://github.com/apache/geode/pull/7509 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] dschneider-pivotal closed pull request #7538: removed all test add-opens and add-exports
dschneider-pivotal closed pull request #7538: removed all test add-opens and add-exports URL: https://github.com/apache/geode/pull/7538 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] dschneider-pivotal closed pull request #7635: GEODE-10249: change BufferPoolStats to not be static
dschneider-pivotal closed pull request #7635: GEODE-10249: change BufferPoolStats to not be static URL: https://github.com/apache/geode/pull/7635 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode-native] gaussianrecurrence commented on a diff in pull request #974: GEODE-10371: C++ client: Improve dispersion on connections expiration
gaussianrecurrence commented on code in PR #974:
URL: https://github.com/apache/geode-native/pull/974#discussion_r902718227
##
cppcache/test/TcrConnectionTest.cpp:
##
@@ -0,0 +1,67 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+#include
+#include
+#include
+
+#include
+
+namespace {
+
+using apache::geode::client::CacheImpl;
+using apache::geode::client::TcrConnection;
+using apache::geode::client::TcrConnectionManager;
+
+class TcrConnectionTest : public TcrConnection {
+ public:
+ explicit TcrConnectionTest(const TcrConnectionManager& manager)
+ : TcrConnection(manager) {}
+
+ int getExpiryTimeVariancePercentage() {
+return expiryTimeVariancePercentage_;
+ }
+};
+
+TEST(TcrConnectionTest,
+ getExpiryTimeVariancePercentageReturnsRandomBetweenMinusNineAndNine) {
+ CacheImpl* cache = nullptr;
+
+ // Create several connections at the same time
+ const int connections = 100;
+ std::unique_ptr tcrConnections[connections];
+ for (int i = 0; i < connections; i++) {
+tcrConnections[i] =
+std::unique_ptr(new TcrConnectionTest(
+static_cast(nullptr)));
+ }
+
Review Comment:
This is a suggestion for a change to this case or maybe for another case,
but given the goal of this change is to ensure the variance is evenly
distributed along the connections created within a close period of time, I'd
suggest instead of comparing with the first value, I'd rather sample the
distribution and check no bucket in the sample has more than x times (i.e
double) the expected amount.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [geode-native] gaussianrecurrence commented on a diff in pull request #974: GEODE-10371: C++ client: Improve dispersion on connections expiration
gaussianrecurrence commented on code in PR #974:
URL: https://github.com/apache/geode-native/pull/974#discussion_r902712371
##
cppcache/src/TcrConnection.cpp:
##
@@ -63,23 +63,10 @@ bool useReplyTimeout(const
apache::geode::client::TcrMessage& request) {
}
int expiryTimeVariancePercentage() {
- auto nowTimePoint = std::chrono::steady_clock::now().time_since_epoch();
- auto now_ms =
- std::chrono::duration_cast(nowTimePoint)
- .count();
- auto now_s =
- std::chrono::duration_cast(nowTimePoint).count();
-
- srand(static_cast((now_s * 1000) + (now_ms / 1000)));
-
- const int numbers = 21;
- // NOLINTNEXTLINE(clang-analyzer-security.insecureAPI.rand): TODO replace
- int random = rand() % numbers + 1;
-
- if (random > 10) {
-random = random - numbers;
- }
- return random;
+ std::random_device rd;
+ std::default_random_engine generator(rd());
+ std::uniform_int_distribution distribution(-9, 9);
Review Comment:
It'd be good to add a couple of constants to add some semantic meaning to
the distribution limits
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [geode] albertogpz closed pull request #7811: [DRAFT DO NOT REVIEW] Fix for queueHeapSize counter after server restart and clean queues
albertogpz closed pull request #7811: [DRAFT DO NOT REVIEW] Fix for queueHeapSize counter after server restart and clean queues URL: https://github.com/apache/geode/pull/7811 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] mivanac opened a new pull request, #7817: GEODE-10392: when cleanqueue remove EvictionController from diskstore
mivanac opened a new pull request, #7817: URL: https://github.com/apache/geode/pull/7817 ### For all changes: - [*] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [*] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [*] Is your initial contribution a single, squashed commit? - [*] Does `gradlew build` run cleanly? - [*] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] jmelchio opened a new pull request, #7816: GEODE-10393: Add generic type on return type
jmelchio opened a new pull request, #7816: URL: https://github.com/apache/geode/pull/7816 - For RegionEntryFactory.getEntryClass This is to reduce compiler warnings in this interface and implementing classes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode-native] moleske commented on pull request #967: GEODE-10292: Bump to boost 1.79.0
moleske commented on PR #967: URL: https://github.com/apache/geode-native/pull/967#issuecomment-1159327204 ok I think the problem is [_WIN32_WINNT](https://github.com/apache/geode-native/blob/develop/dependencies/boost/CMakeLists.txt#L167) needs to be updated, but I don't quite understand why bumping boost would require changing what windows version to target -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] onichols-pivotal merged pull request #7805: GEODE-10387: bump dependencies
onichols-pivotal merged PR #7805: URL: https://github.com/apache/geode/pull/7805 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] davebarnes97 closed pull request #7814: GEODE-10386, 10389, 10390 doc updates
davebarnes97 closed pull request #7814: GEODE-10386, 10389, 10390 doc updates URL: https://github.com/apache/geode/pull/7814 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] davebarnes97 opened a new pull request, #7815: GEODE-10385: User Guide - Remove bad G1GC tuning advice
davebarnes97 opened a new pull request, #7815: URL: https://github.com/apache/geode/pull/7815 A passage in the G1GC tuning section was intended to get a certain test running, but it's bad practice for production systems. Delete that passage. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] davebarnes97 opened a new pull request, #7814: GEODE-10386, 10389, 10390
davebarnes97 opened a new pull request, #7814: URL: https://github.com/apache/geode/pull/7814 add v1.15 doc updates to develop -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] davebarnes97 merged pull request #7813: GEODE-10386:Document JDK 17 for 1.15 release
davebarnes97 merged PR #7813: URL: https://github.com/apache/geode/pull/7813 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] davebarnes97 opened a new pull request, #7813: GEODE-10386:Document JDK 17 for 1.15 release
davebarnes97 opened a new pull request, #7813: URL: https://github.com/apache/geode/pull/7813 Co-authored by: @animatedmax -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] davebarnes97 merged pull request #7812: GEODE-10389: Document upgrade to Geode 1.15 with SSL protocol workaround
davebarnes97 merged PR #7812: URL: https://github.com/apache/geode/pull/7812 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] dschneider-pivotal closed pull request #7793: removed add-opens for jdk.internal.ref to see what breaks
dschneider-pivotal closed pull request #7793: removed add-opens for jdk.internal.ref to see what breaks URL: https://github.com/apache/geode/pull/7793 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] albertogpz opened a new pull request, #7811: [DRAFT DO NOT REVIEW] Fix for queueHeapSize counter after server restart and clean queues
albertogpz opened a new pull request, #7811: URL: https://github.com/apache/geode/pull/7811 ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [ ] Is your initial contribution a single, squashed commit? - [ ] Does `gradlew build` run cleanly? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] albertogpz opened a new pull request, #7810: [DRAFT DO NOT REVIEW] WAN transactions extracted to module
albertogpz opened a new pull request, #7810: URL: https://github.com/apache/geode/pull/7810 commit 4ce6664631be9d371df66cddca656c19ec332762 Author: Alberto Gomez Date: Tue Dec 14 19:30:37 2021 +0100 Fix tests commit 77db403d47716562690242d805916225c50b9e8d Author: Alberto Gomez Date: Tue Dec 14 18:43:41 2021 +0100 Added exceptions to public API changes commit 8c2f77d71f618c2fd7f31088233b6a24539fd4f4 Author: Alberto Gomez Date: Tue Dec 14 17:52:24 2021 +0100 Use --type=TxGroupingParallelGatewaySender... as suggested in jbarrett's review commit cbe859d7a676d1a63c63bfd05cb8269f32f1d036 Author: Alberto Gomez Date: Mon Dec 13 12:36:50 2021 +0100 remove() refactored as suggested on jbarrett's review commit 43194d07d417d1b954b682604389a0da7d4c4ec5 Author: Alberto Gomez Date: Thu Dec 2 06:52:38 2021 +0100 Updated with Kirk's first review comments commit 0c3d8141ecf3fd8b477d8c37e09b46e2f4dc96a2 Author: Alberto Gomez Date: Fri Nov 5 08:16:10 2021 +0100 MODULE: Add gfsh create tx-grouping gw-sender cases. commit a7416a386ef32fc6a5ffb0797b276947c6f84f53 Author: Alberto Gomez Date: Fri Nov 5 08:15:46 2021 +0100 MODULE: Do not allow changing group-transaction-events commit 74f9274ce8c1e248353114a3d44ab0a555998d66 Author: Alberto Gomez Date: Fri Nov 5 08:15:28 2021 +0100 MODULE: Fix some GatewaySenderFactoryImpl tests commit 1959233c9a709ca8c95cea830dabd6249aeb5700 Author: Alberto Gomez Date: Fri Nov 5 08:13:54 2021 +0100 MODULE: Move remaining tx-grouping functionality and DUnit tests commit 5aa6bc7bc25d3f7d2f20d7b2ab9b31d40aacaedc Author: Jacob Barrett Date: Wed Oct 13 19:50:56 2021 -0700 MODULE: Move tests commit 07884e81bed83b8d4a4a7394636428373977b93c Author: Jacob Barrett Date: Wed Oct 13 19:24:12 2021 -0700 MODULE: ServiceLoader commit 0be467b0679cd10d77846ca530d7a1457acd99e8 Author: Jacob Barrett Date: Wed Oct 13 16:31:02 2021 -0700 MODULE: Stupid simple module. commit 477a823c7a68d6235ed1e068df04dfba0f1c1e26 Author: Jacob Barrett Date: Wed Oct 13 16:08:08 2021 -0700 MODULE: Remove AbstractGatwaySender.mustGroupTransactionEvents() commit f7c0d21921fd3045a7db1d46a9bd7bbeb119dfff Author: Jacob Barrett Date: Wed Oct 13 14:14:38 2021 -0700 MODULE: Create TX grouping sender impls. commit 35b072e07ff3335a437d10a4d16352801d10cf9d Author: Jacob Barrett Date: Wed Oct 13 14:01:04 2021 -0700 MODULE: Extract out TX grouping factories. commit 7a3d45cc89847312ee003dfc62eceaed642a108f Author: Jacob Barrett Date: Wed Oct 13 13:19:15 2021 -0700 MODULE: Split out some factories. commit ae74a4204a151464f58732106aa043c17e1d5486 Author: Jacob Barrett Date: Thu Sep 30 15:24:56 2021 -0700 MODULE: Extract interface for GatewaySenderAttributes. commit 8c2d23e2bf81334fa2957107e0dbf3e206fb47be Author: Jacob Barrett Date: Thu Sep 30 17:22:04 2021 -0700 GEODE-6588: Cleanup GatewaySenderFactoryImpl commit 2457963f4921afee694027bba901c0aafac3df85 Author: Jacob Barrett Date: Thu Sep 30 16:07:40 2021 -0700 GEODE-6588: Cleanup AbstractGatewaySender commit 042013dd3531f02ecafac856023b4a6ea4a95a6f Author: Jacob Barrett Date: Thu Sep 30 14:54:03 2021 -0700 GEODE-6588: Cleanup GatewaySenderAttributes ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [ ] Is your initial contribution a single, squashed commit? - [ ] Does `gradlew build` run cleanly? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] davebarnes97 merged pull request #7809: GEODE-10390: User guide: update authentication expiry instructions
davebarnes97 merged PR #7809: URL: https://github.com/apache/geode/pull/7809 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] davebarnes97 opened a new pull request, #7809: GEODE-10390: User guide: update authentication expiry instructions
davebarnes97 opened a new pull request, #7809: URL: https://github.com/apache/geode/pull/7809 Incorporating reviewer improvements to authentication expiry instructions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] rhoughton-pivot merged pull request #7759: Fixes for cleaning GCP resources from pipelines
rhoughton-pivot merged PR #7759: URL: https://github.com/apache/geode/pull/7759 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] davebarnes97 closed pull request #7808: Geode-10386: Document JDK 17 for 1.15 release
davebarnes97 closed pull request #7808: Geode-10386: Document JDK 17 for 1.15 release URL: https://github.com/apache/geode/pull/7808 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] rhoughton-pivot merged pull request #7806: GEODE-10388: create better output filter for srcDist task
rhoughton-pivot merged PR #7806: URL: https://github.com/apache/geode/pull/7806 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
