DonalEvans opened a new pull request, #7680:
URL: https://github.com/apache/geode/pull/7680
- Modify SSLUtil to attempt to create SSLContext using the default
protocols
- Add WANSSLDistributedTest to test protocol/cipher combinations in WAN
context
- Do not hide exception
mivanac commented on PR #7664:
URL: https://github.com/apache/geode/pull/7664#issuecomment-1124104592
Hi @Bill, @echobravopapa, @agingade, @kamilla1201 and @pivotal-jbarrett
could you review this PR.
Thanks
--
This is an automated message from the Apache Git Service.
To respond
mivanac commented on PR #7515:
URL: https://github.com/apache/geode/pull/7515#issuecomment-1124093541
Hi @kirklund,
just reminder,
are changes OK with you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
jinmeiliao merged PR #7652:
URL: https://github.com/apache/geode/pull/7652
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geo
pivotal-eshu opened a new pull request, #7679:
URL: https://github.com/apache/geode/pull/7679
* During putIfAbsent retry, comparing invalid token value when
putIfAbsent of a null value instead.
### For all changes:
- [ ] Is there a JIRA ticket associated with
rhoughton-pivot merged PR #7600:
URL: https://github.com/apache/geode/pull/7600
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr..
mhansonp commented on code in PR #7629:
URL: https://github.com/apache/geode/pull/7629#discussion_r870524698
##
geode-gfsh/src/main/java/org/apache/geode/management/internal/cli/commands/CreateIndexCommand.java:
##
@@ -96,7 +96,7 @@ public ResultModel createIndex(@CliOption(key
mhansonp commented on code in PR #7600:
URL: https://github.com/apache/geode/pull/7600#discussion_r870509656
##
build-tools/geode-testing-isolation/src/test/java/org/apache/geode/gradle/test/isolation/PortRangeTest.java:
##
@@ -16,31 +16,28 @@
package org.apache.geode.gradle.te
demery-pivotal merged PR #7678:
URL: https://github.com/apache/geode/pull/7678
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...
jvarenina commented on PR #7378:
URL: https://github.com/apache/geode/pull/7378#issuecomment-1123927160
This PR has been hanging for a long time now, and we should decide whether
to close it or merge it.
I think this PR adds value to Apache geode if we at least "synchronize"
send
jvarenina commented on code in PR #7665:
URL: https://github.com/apache/geode/pull/7665#discussion_r869924302
##
geode-core/build.gradle:
##
@@ -375,6 +375,7 @@ dependencies {
distributedTestImplementation(project(':geode-gfsh'))
+ distributedTestImplementation(project('
onichols-pivotal closed pull request #7676: GEODE-10295: fix ambiguous overload
URL: https://github.com/apache/geode/pull/7676
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
onichols-pivotal commented on PR #7676:
URL: https://github.com/apache/geode/pull/7676#issuecomment-1123218632
didn't help with LGTM issue and Geode doesn't support compiling on JDK11 so
this is not needed
--
This is an automated message from the Apache Git Service.
To respond to the mess
lgtm-com[bot] commented on PR #954:
URL: https://github.com/apache/geode-native/pull/954#issuecomment-1123172546
This pull request **introduces 1 alert** when merging
927e176d7433e029d7cae2ca7edd64d658f0ceac into
4d0578a829ee4d967ec4358133e4a8c3563f1310 - [view on
LGTM.com](https://lgtm.co
pivotal-jbarrett opened a new pull request, #168:
URL: https://github.com/apache/geode-benchmarks/pull/168
Configure HistogramLogProcessor to throw exceptions rather than exit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
lgtm-com[bot] commented on PR #954:
URL: https://github.com/apache/geode-native/pull/954#issuecomment-1123054711
This pull request **introduces 1 alert** when merging
4329b35950257a683e7654abce5ef4f91cb3c609 into
4d0578a829ee4d967ec4358133e4a8c3563f1310 - [view on
LGTM.com](https://lgtm.co
gesterzhou commented on code in PR #7670:
URL: https://github.com/apache/geode/pull/7670#discussion_r869774427
##
geode-core/src/main/java/org/apache/geode/internal/cache/InitialImageOperation.java:
##
@@ -1077,7 +1081,8 @@ protected Set
processReceivedRVV(RegionVersionVector r
gesterzhou commented on code in PR #7670:
URL: https://github.com/apache/geode/pull/7670#discussion_r869775615
##
geode-core/src/main/java/org/apache/geode/internal/cache/InitialImageOperation.java:
##
@@ -1052,19 +1052,23 @@ protected RegionVersionVector getRVVFromProvider(fina
gesterzhou commented on code in PR #7670:
URL: https://github.com/apache/geode/pull/7670#discussion_r869774525
##
geode-core/src/main/java/org/apache/geode/internal/cache/InitialImageOperation.java:
##
@@ -1100,6 +1105,12 @@ protected Set
processReceivedRVV(RegionVersionVector
gesterzhou commented on code in PR #7670:
URL: https://github.com/apache/geode/pull/7670#discussion_r869774427
##
geode-core/src/main/java/org/apache/geode/internal/cache/InitialImageOperation.java:
##
@@ -1077,7 +1081,8 @@ protected Set
processReceivedRVV(RegionVersionVector r
demery-pivotal merged PR #7673:
URL: https://github.com/apache/geode/pull/7673
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...
jinmeiliao opened a new pull request, #7677:
URL: https://github.com/apache/geode/pull/7677
* GEODE-10287: do distAdvisor.close after waitForCurrentOperations()
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
onichols-pivotal opened a new pull request, #7676:
URL: https://github.com/apache/geode/pull/7676
GEODE-6588 mass cleanup removed an explicit cast to remove a warning,
however in JDK11, the cast is necessary to disambiguate against a new
overloaded added to an interface this class implement
mmartell commented on code in PR #954:
URL: https://github.com/apache/geode-native/pull/954#discussion_r869734411
##
cppcache/integration/framework/Cluster.h:
##
@@ -124,6 +124,7 @@ using Password = NamedType;
using CacheXMLFiles =
NamedType, struct CacheXMLFilesParameter>
mmartell commented on code in PR #954:
URL: https://github.com/apache/geode-native/pull/954#discussion_r869733477
##
cppcache/integration/framework/Cluster.h:
##
@@ -141,6 +142,9 @@ class Cluster {
Cluster(InitialLocators initialLocators, InitialServers initialServers,
mmartell commented on code in PR #954:
URL: https://github.com/apache/geode-native/pull/954#discussion_r869732762
##
clicache/integration-test2/GfshTest.cs:
##
@@ -77,13 +77,16 @@ public void StartLocatorStringsTest()
.withSslKeyStore("some/path/keystore.jks")
rhoughton-pivot merged PR #7674:
URL: https://github.com/apache/geode/pull/7674
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr..
nabarunnag commented on code in PR #7670:
URL: https://github.com/apache/geode/pull/7670#discussion_r869687159
##
geode-core/src/main/java/org/apache/geode/internal/cache/InitialImageOperation.java:
##
@@ -1052,19 +1052,23 @@ protected RegionVersionVector getRVVFromProvider(fina
kirklund commented on code in PR #7571:
URL: https://github.com/apache/geode/pull/7571#discussion_r869685152
##
geode-junit/src/main/java/org/apache/geode/test/junit/rules/Folder.java:
##
@@ -0,0 +1,40 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
demery-pivotal commented on code in PR #7571:
URL: https://github.com/apache/geode/pull/7571#discussion_r869682714
##
geode-junit/src/main/java/org/apache/geode/test/junit/rules/gfsh/GfshExecutor.java:
##
@@ -0,0 +1,52 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
demery-pivotal commented on code in PR #7571:
URL: https://github.com/apache/geode/pull/7571#discussion_r869678386
##
geode-junit/src/main/java/org/apache/geode/test/junit/rules/Folder.java:
##
@@ -0,0 +1,40 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one o
demery-pivotal commented on code in PR #7571:
URL: https://github.com/apache/geode/pull/7571#discussion_r869676436
##
geode-assembly/src/upgradeTest/java/org/apache/geode/test/junit/rules/GfshContextVersionTest.java:
##
@@ -0,0 +1,55 @@
+/*
+ * Licensed to the Apache Software Fo
jchen21 commented on code in PR #7670:
URL: https://github.com/apache/geode/pull/7670#discussion_r869675129
##
geode-core/src/main/java/org/apache/geode/internal/cache/InitialImageOperation.java:
##
@@ -1077,7 +1081,8 @@ protected Set
processReceivedRVV(RegionVersionVector remo
pivotal-jbarrett commented on code in PR #954:
URL: https://github.com/apache/geode-native/pull/954#discussion_r869645866
##
clicache/integration-test2/GfshTest.cs:
##
@@ -77,13 +77,16 @@ public void StartLocatorStringsTest()
.withSslKeyStore("some/path/keystore
demery-pivotal merged PR #7675:
URL: https://github.com/apache/geode/pull/7675
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...
kirklund commented on code in PR #7571:
URL: https://github.com/apache/geode/pull/7571#discussion_r869604871
##
geode-core/src/upgradeTest/java/org/apache/geode/internal/net/SocketCreatorUpgradeTest.java:
##
@@ -244,26 +264,33 @@ public void
upgradingToNewGeodeOnOldJavaWithProt
kirklund commented on code in PR #7571:
URL: https://github.com/apache/geode/pull/7571#discussion_r869597915
##
geode-assembly/src/upgradeTest/java/org/apache/geode/session/tests/Tomcat8ClientServerRollingUpgradeTest.java:
##
@@ -125,21 +130,30 @@ protected void startLocator(Str
demery-pivotal commented on PR #7675:
URL: https://github.com/apache/geode/pull/7675#issuecomment-1122749018
> Seems like a sane script change.
>
> Are these all required parameters for running locally?
None are required for running locally. The `multi-process-test.gradle`
scri
rhoughton-pivot opened a new pull request, #7674:
URL: https://github.com/apache/geode/pull/7674
Authored-by: Robert Houghton
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in
the commit message?
- [ ] Has your PR
onichols-pivotal merged PR #7659:
URL: https://github.com/apache/geode/pull/7659
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr.
mmartell commented on code in PR #954:
URL: https://github.com/apache/geode-native/pull/954#discussion_r869537870
##
clicache/integration-test2/Cluster.cs:
##
@@ -71,7 +73,7 @@ private bool StartLocators()
for (var i = 0; i < locatorCount_; i++)
{
jdeppe-pivotal merged PR #7671:
URL: https://github.com/apache/geode/pull/7671
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...
demery-pivotal opened a new pull request, #7673:
URL: https://github.com/apache/geode/pull/7673
The argument file was generated on Linux using OpenJDK 17.0.2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
pivotal-jbarrett commented on code in PR #7665:
URL: https://github.com/apache/geode/pull/7665#discussion_r869466833
##
geode-core/build.gradle:
##
@@ -375,6 +375,7 @@ dependencies {
distributedTestImplementation(project(':geode-gfsh'))
+ distributedTestImplementation(pr
pivotal-jbarrett commented on code in PR #968:
URL: https://github.com/apache/geode-native/pull/968#discussion_r869462212
##
docker/ubuntu-22.04/Dockerfile:
##
@@ -0,0 +1,71 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreement
moleske commented on code in PR #968:
URL: https://github.com/apache/geode-native/pull/968#discussion_r869449791
##
docker/ubuntu-22.04/Dockerfile:
##
@@ -0,0 +1,71 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See t
pivotal-jbarrett commented on PR #966:
URL: https://github.com/apache/geode-native/pull/966#issuecomment-1122589756
Looks like CI didn't run. Please post empty commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
gaussianrecurrence commented on code in PR #969:
URL: https://github.com/apache/geode-native/pull/969#discussion_r869428049
##
cppcache/src/CacheImpl.hpp:
##
@@ -134,6 +134,12 @@ class APACHE_GEODE_EXPORT CacheImpl {
*/
DistributedSystem& getDistributedSystem();
Review C
pivotal-jbarrett commented on PR #967:
URL: https://github.com/apache/geode-native/pull/967#issuecomment-1122588565
Looks like the CI didn't run at all. Post an empty commit and see if it runs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please l
pivotal-jbarrett commented on code in PR #968:
URL: https://github.com/apache/geode-native/pull/968#discussion_r869424555
##
docker/ubuntu-22.04/Dockerfile:
##
@@ -0,0 +1,71 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreement
gaussianrecurrence commented on code in PR #969:
URL: https://github.com/apache/geode-native/pull/969#discussion_r869351686
##
cppcache/integration/test/PdxInstanceTest.cpp:
##
@@ -268,7 +268,7 @@ TEST(PdxInstanceTest, testPdxInstance) {
pdxTypeFromPdxTypeInstance->equals
pivotal-jbarrett commented on code in PR #969:
URL: https://github.com/apache/geode-native/pull/969#discussion_r869330026
##
cppcache/integration/test/PdxInstanceTest.cpp:
##
@@ -268,7 +268,7 @@ TEST(PdxInstanceTest, testPdxInstance) {
pdxTypeFromPdxTypeInstance->equals(*
dependabot[bot] opened a new pull request, #7672:
URL: https://github.com/apache/geode/pull/7672
Bumps [puma](https://github.com/puma/puma) from 5.3.2 to 5.6.4.
Release notes
Sourced from https://github.com/puma/puma/releases";>puma's
releases.
5.6.4
Security
C
rhoughton-pivot merged PR #7669:
URL: https://github.com/apache/geode/pull/7669
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr..
gaussianrecurrence commented on PR #969:
URL: https://github.com/apache/geode-native/pull/969#issuecomment-1122476087
> I realize this is a draft but was excited to take a peek and noticed this
one right away.
Yes, this is a WIP, there are some minor changes i yet want to make, and
w
gaussianrecurrence commented on code in PR #969:
URL: https://github.com/apache/geode-native/pull/969#discussion_r869302660
##
cppcache/src/CacheableObjectArray.cpp:
##
@@ -53,6 +54,18 @@ size_t CacheableObjectArray::objectSize() const {
}
return size;
}
+
+std::string Ca
gaussianrecurrence closed pull request #891: GEODE-9753: Solve PDX
serialization coredump
URL: https://github.com/apache/geode-native/pull/891
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
gaussianrecurrence commented on PR #891:
URL: https://github.com/apache/geode-native/pull/891#issuecomment-1122456236
Closing this PR as this issue is already addressed in GEODE-10276
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
gaussianrecurrence closed pull request #910: GEODE-9968: Fix new attrs in
PdxSerializable
URL: https://github.com/apache/geode-native/pull/910
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
gaussianrecurrence commented on PR #910:
URL: https://github.com/apache/geode-native/pull/910#issuecomment-1122454544
Closing this PR as the fix is already covered in GEODE-10276
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
pivotal-jbarrett commented on code in PR #969:
URL: https://github.com/apache/geode-native/pull/969#discussion_r869292240
##
cppcache/src/CacheableObjectArray.cpp:
##
@@ -53,6 +54,18 @@ size_t CacheableObjectArray::objectSize() const {
}
return size;
}
+
+std::string Cach
pivotal-jbarrett commented on PR #969:
URL: https://github.com/apache/geode-native/pull/969#issuecomment-1122447052
OMG! Awesome effort!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
gaussianrecurrence opened a new pull request, #969:
URL: https://github.com/apache/geode-native/pull/969
- Code related to PDX de(serialization) has been refactored and aligned
(in all possible means) to the Java client, solving the following
issues:
* GEODE-9968 - Fix des
mkevo commented on PR #7629:
URL: https://github.com/apache/geode/pull/7629#issuecomment-1122244670
Hi @mhansonp, @kirklund,
can you please check the file you are codeowner?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
mkevo commented on code in PR #6225:
URL: https://github.com/apache/geode/pull/6225#discussion_r869103403
##
geode-core/src/main/java/org/apache/geode/distributed/internal/ClusterDistributionManager.java:
##
@@ -1793,9 +1793,7 @@ private String prettifyReason(String r) {
*/
lgtm-com[bot] commented on PR #7671:
URL: https://github.com/apache/geode/pull/7671#issuecomment-1121945899
LGTM pull request analysis was skipped for
866f459e4e8939af312700705f17550e59a5ace5 by
[onichols-pivotal](https://github.com/onichols-pivotal). Analysis of future
commits will happen
jdeppe-pivotal opened a new pull request, #7671:
URL: https://github.com/apache/geode/pull/7671
* Update documentation
Co-authored-by: Dave Barnes
(cherry picked from commit d4b80d27277d3eda22f692cf95d95026096470d5)
### For all changes:
- [ ] Is there
jdeppe-pivotal merged PR #7666:
URL: https://github.com/apache/geode/pull/7666
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...
lgtm-com[bot] commented on PR #7666:
URL: https://github.com/apache/geode/pull/7666#issuecomment-1121894560
LGTM pull request analysis was skipped for
a8790f9d66b669106554e54b6904b42695ff44cc by
[jdeppe-pivotal](https://github.com/jdeppe-pivotal). Analysis of future commits
will happen as
moleske opened a new pull request, #968:
URL: https://github.com/apache/geode-native/pull/968
I don't have ami credentials nor concourse credentials to test any of this,
so I will need some help if this should be wanted in CI
--
This is an automated message from the Apache Git Service.
To
moleske opened a new pull request, #967:
URL: https://github.com/apache/geode-native/pull/967
Initially complained that it did not know what `boost::filesystem::ofstream`
before adding the header file
--
This is an automated message from the Apache Git Service.
To respond to the message,
moleske opened a new pull request, #966:
URL: https://github.com/apache/geode-native/pull/966
Initially failed to compile because it could not find `sleep_for` (was
undefined)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
gesterzhou opened a new pull request, #7670:
URL: https://github.com/apache/geode/pull/7670
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in
the commit message?
- [ ] Has your PR been rebased against the latest commit wi
jinmeiliao commented on PR #7659:
URL: https://github.com/apache/geode/pull/7659#issuecomment-1121677376
we have a go client that is a consumer of the swagger doc to issue
management rest api command and parse it's result. This will break that tool. I
know it is out of the scope of this PR.
lgtm-com[bot] commented on PR #7666:
URL: https://github.com/apache/geode/pull/7666#issuecomment-1121668439
LGTM pull request analysis was skipped for
d2e5ed404c26c7cba5f50414c73281c27dfb7a94 by
[onichols-pivotal](https://github.com/onichols-pivotal). Analysis of future
commits will happen
rhoughton-pivot opened a new pull request, #7669:
URL: https://github.com/apache/geode/pull/7669
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in
the commit message?
- [ ] Has your PR been rebased against the latest comm
dschneider-pivotal commented on code in PR #7667:
URL: https://github.com/apache/geode/pull/7667#discussion_r868325789
##
geode-core/src/main/java/org/apache/geode/internal/cache/DiskStoreImpl.java:
##
@@ -1716,67 +1723,78 @@ void doAsyncFlush() {
logger.debug("Async wr
jdeppe-pivotal commented on code in PR #7666:
URL: https://github.com/apache/geode/pull/7666#discussion_r868200094
##
geode-gfsh/src/main/java/org/apache/geode/management/internal/cli/commands/CreateRegionCommand.java:
##
@@ -168,6 +169,8 @@ public ResultModel createRegion(
rhoughton-pivot commented on code in PR #7600:
URL: https://github.com/apache/geode/pull/7600#discussion_r868260864
##
build.gradle:
##
@@ -29,16 +29,21 @@ plugins {
id "org.ajoberstar.grgit" version "4.1.1" apply false
id "org.nosphere.apache.rat" version "0.7.1" apply fa
jdeppe-pivotal commented on code in PR #7600:
URL: https://github.com/apache/geode/pull/7600#discussion_r868260710
##
buildScripts/src/main/groovy/code-analysis.gradle:
##
@@ -15,61 +15,85 @@
* limitations under the License.
*/
-if (project.hasProperty("staticAnalysis")) {
jdeppe-pivotal commented on code in PR #7600:
URL: https://github.com/apache/geode/pull/7600#discussion_r868259385
##
build.gradle:
##
@@ -29,16 +29,21 @@ plugins {
id "org.ajoberstar.grgit" version "4.1.1" apply false
id "org.nosphere.apache.rat" version "0.7.1" apply fal
jinmeiliao commented on code in PR #7652:
URL: https://github.com/apache/geode/pull/7652#discussion_r868201573
##
geode-core/src/integrationTest/java/org/apache/geode/internal/cache/tier/sockets/ConnectionProxyJUnitTest.java:
##
@@ -19,753 +19,377 @@
package org.apache.geode.in
jdeppe-pivotal commented on code in PR #7666:
URL: https://github.com/apache/geode/pull/7666#discussion_r868200094
##
geode-gfsh/src/main/java/org/apache/geode/management/internal/cli/commands/CreateRegionCommand.java:
##
@@ -168,6 +169,8 @@ public ResultModel createRegion(
jinmeiliao commented on code in PR #7666:
URL: https://github.com/apache/geode/pull/7666#discussion_r868198619
##
geode-gfsh/src/main/java/org/apache/geode/management/internal/cli/commands/CreateRegionCommand.java:
##
@@ -168,6 +169,8 @@ public ResultModel createRegion(
onichols-pivotal merged PR #7668:
URL: https://github.com/apache/geode/pull/7668
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr.
lgtm-com[bot] commented on PR #7668:
URL: https://github.com/apache/geode/pull/7668#issuecomment-1121294848
LGTM pull request analysis was skipped for
8d7065dea1773e073a4bc44a3b895987cb78b889 by
[onichols-pivotal](https://github.com/onichols-pivotal). Analysis of future
commits will happen
pivotal-jbarrett commented on code in PR #7652:
URL: https://github.com/apache/geode/pull/7652#discussion_r868152259
##
geode-core/src/integrationTest/java/org/apache/geode/internal/cache/tier/sockets/ConnectionProxyJUnitTest.java:
##
@@ -19,753 +19,377 @@
package org.apache.ge
mivanac commented on PR #7515:
URL: https://github.com/apache/geode/pull/7515#issuecomment-1121065697
Hi @kirklund,
just a reminder,
could you comment if something needs to be changed, or remove changes
requested.
--
This is an automated message from the Apache Git Service.
To resp
mivanac commented on PR #7323:
URL: https://github.com/apache/geode/pull/7323#issuecomment-1121064843
Hi @kirklund , are changes OK with you?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
mkevo commented on PR #7368:
URL: https://github.com/apache/geode/pull/7368#issuecomment-1120843776
@echobravopapa, @kamilla1201, @Bill, can you please review this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
mivanac opened a new pull request, #7667:
URL: https://github.com/apache/geode/pull/7667
### For all changes:
- [*] Is there a JIRA ticket associated with this PR? Is it referenced in
the commit message?
- [*] Has your PR been rebased against the latest commit withi
jdeppe-pivotal commented on code in PR #7666:
URL: https://github.com/apache/geode/pull/7666#discussion_r867375830
##
geode-gfsh/src/main/java/org/apache/geode/management/internal/cli/commands/CreateRegionCommand.java:
##
@@ -170,6 +171,8 @@ public ResultModel createRegion(
jinmeiliao commented on code in PR #7666:
URL: https://github.com/apache/geode/pull/7666#discussion_r867300041
##
geode-gfsh/src/main/java/org/apache/geode/management/internal/cli/commands/CreateRegionCommand.java:
##
@@ -170,6 +171,8 @@ public ResultModel createRegion(
onichols-pivotal merged PR #7663:
URL: https://github.com/apache/geode/pull/7663
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr.
lgtm-com[bot] commented on PR #7659:
URL: https://github.com/apache/geode/pull/7659#issuecomment-1120038012
LGTM pull request analysis was skipped for
8197b247d63291b842d95573f9bd1bb789b5f12c by
[onichols-pivotal](https://github.com/onichols-pivotal). Analysis of future
commits will happen
jdeppe-pivotal opened a new pull request, #7666:
URL: https://github.com/apache/geode/pull/7666
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in
the commit message?
- [ ] Has your PR been rebased against the latest commi
dschneider-pivotal commented on PR #7654:
URL: https://github.com/apache/geode/pull/7654#issuecomment-1119795329
redis was removed from geode so this pr is no longer needed in geode
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
dschneider-pivotal closed pull request #7654: GEODE-10196: handle 'Connection
reset" for jdk17
URL: https://github.com/apache/geode/pull/7654
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
dschneider-pivotal merged PR #7646:
URL: https://github.com/apache/geode/pull/7646
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubsc
jvarenina opened a new pull request, #7665:
URL: https://github.com/apache/geode/pull/7665
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in
the commit message?
- [ ] Has your PR been rebased against the latest commit wit
801 - 900 of 5929 matches
Mail list logo
