[GitHub] [geode] lgtm-com[bot] commented on pull request #5390: ClassLoader isolation

2020-08-10 Thread GitBox
lgtm-com[bot] commented on pull request #5390: URL: https://github.com/apache/geode/pull/5390#issuecomment-671500760 This pull request **introduces 2 alerts** and **fixes 2** when merging c572e6dcb5ab2f73dd069eb697442ddb96906876 into 6a08bba48a92db682a3443b9ce47b44796cb4ab1 - [view on

[GitHub] [geode] albertogpz commented on a change in pull request #5348: DRAFT: Add flag in gateway sender to not store dropped events while stopped …

2020-08-10 Thread GitBox
albertogpz commented on a change in pull request #5348: URL: https://github.com/apache/geode/pull/5348#discussion_r467116996 ## File path: geode-core/src/main/java/org/apache/geode/management/internal/configuration/functions/GatewaySenderManageFunction.java ## @@ -0,0 +1,148

[GitHub] [geode] karensmolermiller opened a new pull request #5437: GEODE-8410: remove offensive language from docs

2020-08-10 Thread GitBox
karensmolermiller opened a new pull request #5437: URL: https://github.com/apache/geode/pull/5437 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [geode] jujoramos commented on pull request #5175: GEODE-8119: Threads hangs when offline disk store command is invoked

2020-08-10 Thread GitBox
jujoramos commented on pull request #5175: URL: https://github.com/apache/geode/pull/5175#issuecomment-671321433 The `DescribeOfflineDiskStoreCommand` class calls `DiskStoreImpl.dumpInfo()`, which has an instance of the `DiskStoreImpl` class, it can be used directly to call `close()`, see

[GitHub] [geode] mkevo commented on pull request #5175: GEODE-8119: Threads hangs when offline disk store command is invoked

2020-08-10 Thread GitBox
mkevo commented on pull request #5175: URL: https://github.com/apache/geode/pull/5175#issuecomment-671311587 > Sure, can you point me exactly to which commands you're referring here?. The original ticket ([GEODE-8119](https://issues.apache.org/jira/browse/GEODE-8119)) doesn't mention

[GitHub] [geode] jujoramos commented on pull request #5175: GEODE-8119: Threads hangs when offline disk store command is invoked

2020-08-10 Thread GitBox
jujoramos commented on pull request #5175: URL: https://github.com/apache/geode/pull/5175#issuecomment-671309686 Sure, can you point me exactly to which commands you're referring here?. The original ticket ([GEODE-8119](https://issues.apache.org/jira/browse/GEODE-8119)) doesn't mention

[GitHub] [geode] mkevo commented on pull request #5175: GEODE-8119: Threads hangs when offline disk store command is invoked

2020-08-10 Thread GitBox
mkevo commented on pull request #5175: URL: https://github.com/apache/geode/pull/5175#issuecomment-671299214 > @mkevo > Thanks for adding the extra tests. I'm not fully convinced about the implemented fix, however, did you consider my comments

[GitHub] [geode] jivthesh commented on pull request #5430: added code of conduct to project

2020-08-09 Thread GitBox
jivthesh commented on pull request #5430: URL: https://github.com/apache/geode/pull/5430#issuecomment-671079579 @metatype should i wnat to make any changes This is an automated message from the Apache Git Service. To

[GitHub] [geode] jivthesh commented on pull request #5430: added code of conduct to project

2020-08-07 Thread GitBox
jivthesh commented on pull request #5430: URL: https://github.com/apache/geode/pull/5430#issuecomment-670828286 @metatype okay This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [geode] jinmeiliao opened a new pull request #5436: GEODE-7672: add dunit test to verify OQL index after PR clear.

2020-08-07 Thread GitBox
jinmeiliao opened a new pull request #5436: URL: https://github.com/apache/geode/pull/5436 * allow ClusterStartupRule to launch dunit default locator This is an automated message from the Apache Git Service. To respond to

[GitHub] [geode-native] moleske commented on a change in pull request #628: GEODE-8344: Add GatewaySenderEventCallbackArgument class

2020-08-07 Thread GitBox
moleske commented on a change in pull request #628: URL: https://github.com/apache/geode-native/pull/628#discussion_r467228776 ## File path: cppcache/integration/test/Order.cpp ## @@ -0,0 +1,60 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [geode-native] moleske commented on a change in pull request #625: GEODE-8340: Enforce Switch compiler warnings as errors

2020-08-07 Thread GitBox
moleske commented on a change in pull request #625: URL: https://github.com/apache/geode-native/pull/625#discussion_r467223869 ## File path: cppcache/src/ExceptionTypes.cpp ## @@ -297,7 +297,25 @@ const std::string& getThreadLocalExceptionMessage();

[GitHub] [geode] jujoramos commented on pull request #5175: GEODE-8119: Threads hangs when offline disk store command is invoked

2020-08-07 Thread GitBox
jujoramos commented on pull request #5175: URL: https://github.com/apache/geode/pull/5175#issuecomment-670655764 @mkevo Thanks for adding the extra tests. I'm not fully convinced about the implemented fix, however, did you consider my comments

[GitHub] [geode] bschuchardt closed pull request #5433: Revert "GEODE-8407: MergeLogFiles fails to include files with the sam…

2020-08-07 Thread GitBox
bschuchardt closed pull request #5433: URL: https://github.com/apache/geode/pull/5433 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [geode] bschuchardt merged pull request #5435: GEODE-8413: CI failure: MergeLogFilesIntegrationTest.testDircountZero fails on Windows

2020-08-07 Thread GitBox
bschuchardt merged pull request #5435: URL: https://github.com/apache/geode/pull/5435 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [geode] bschuchardt commented on pull request #5435: GEODE-8413: CI failure: MergeLogFilesIntegrationTest.testDircountZero fails on Windows

2020-08-07 Thread GitBox
bschuchardt commented on pull request #5435: URL: https://github.com/apache/geode/pull/5435#issuecomment-670643196 Since this is a test-only change and the checks that use that test have passed I'm merging this PR before all of the non-required checks have finished.

[GitHub] [geode] bschuchardt opened a new pull request #5435: GEODE-8413: CI failure: MergeLogFilesIntegrationTest.testDircountZero fails on Windows

2020-08-07 Thread GitBox
bschuchardt opened a new pull request #5435: URL: https://github.com/apache/geode/pull/5435 Fixing directory path formation problem for Windows. I've tested these changes on a Mac and on a Windows machine. Thank you for submitting a contribution to Apache Geode. In order

[GitHub] [geode] DonalEvans merged pull request #5418: GEODE-8396: Fixing NullPointerException in create jdbc-mapping command

2020-08-07 Thread GitBox
DonalEvans merged pull request #5418: URL: https://github.com/apache/geode/pull/5418 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [geode] albertogpz opened a new pull request #5434: DRAFT: Solution to not queue forever dropped events with 2 timeouts

2020-08-07 Thread GitBox
albertogpz opened a new pull request #5434: URL: https://github.com/apache/geode/pull/5434 Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all

[GitHub] [geode] agingade merged pull request #5424: GEODE-8394: Rewind the message Part on command failure

2020-08-07 Thread GitBox
agingade merged pull request #5424: URL: https://github.com/apache/geode/pull/5424 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [geode] bschuchardt opened a new pull request #5433: Revert "GEODE-8407: MergeLogFiles fails to include files with the sam…

2020-08-07 Thread GitBox
bschuchardt opened a new pull request #5433: URL: https://github.com/apache/geode/pull/5433 …e name b… (#5428)" This reverts commit d6c3b1f20a55c5d867f162a338910d5df7d47de5. The new test fails consistently on Windows. Thank you for submitting a contribution to Apache Geode.

[GitHub] [geode] rhoughton-pivot merged pull request #5427: GEODE-8406: Enable early-return in CI scripts for CI-only changes

2020-08-07 Thread GitBox
rhoughton-pivot merged pull request #5427: URL: https://github.com/apache/geode/pull/5427 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [geode] mivanac merged pull request #5432: GEODE-8191_1: test updated, added bucket initialization after creatio…

2020-08-07 Thread GitBox
mivanac merged pull request #5432: URL: https://github.com/apache/geode/pull/5432 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [geode] albertogpz commented on a change in pull request #5348: DRAFT: Add flag in gateway sender to not store dropped events while stopped …

2020-08-07 Thread GitBox
albertogpz commented on a change in pull request #5348: URL: https://github.com/apache/geode/pull/5348#discussion_r467116996 ## File path: geode-core/src/main/java/org/apache/geode/management/internal/configuration/functions/GatewaySenderManageFunction.java ## @@ -0,0 +1,148

[GitHub] [geode] albertogpz commented on a change in pull request #5348: DRAFT: Add flag in gateway sender to not store dropped events while stopped …

2020-08-07 Thread GitBox
albertogpz commented on a change in pull request #5348: URL: https://github.com/apache/geode/pull/5348#discussion_r467114892 ## File path: geode-core/src/main/java/org/apache/geode/management/internal/beans/GatewaySenderMBeanBridge.java ## @@ -334,4 +334,8 @@ public boolean

[GitHub] [geode] albertogpz commented on a change in pull request #5348: DRAFT: Add flag in gateway sender to not store dropped events while stopped …

2020-08-07 Thread GitBox
albertogpz commented on a change in pull request #5348: URL: https://github.com/apache/geode/pull/5348#discussion_r467114776 ## File path: geode-core/src/main/java/org/apache/geode/management/GatewaySenderMXBean.java ## @@ -273,6 +273,8 @@ */ int

[GitHub] [geode] masaki-yamakawa commented on pull request #5418: GEODE-8396: Fixing NullPointerException in create jdbc-mapping command

2020-08-07 Thread GitBox
masaki-yamakawa commented on pull request #5418: URL: https://github.com/apache/geode/pull/5418#issuecomment-670544653 @DonalEvans Thanks for the review. This is an automated message from the Apache Git Service. To respond

[GitHub] [geode] mivanac opened a new pull request #5432: GEODE-8191_1: test updated, added bucket initialization after creatio…

2020-08-07 Thread GitBox
mivanac opened a new pull request #5432: URL: https://github.com/apache/geode/pull/5432 …n of each child region Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been

[GitHub] [geode] jujoramos commented on pull request #5227: GEODE-8191: flaky test correction

2020-08-07 Thread GitBox
jujoramos commented on pull request #5227: URL: https://github.com/apache/geode/pull/5227#issuecomment-670514196 Dang!, somehow I totally missed that notification and there wasn't any new comments on the `PR` (other than the one from Owen) so I didn't get any specific email addressed to

[GitHub] [geode] mivanac commented on pull request #5227: GEODE-8191: flaky test correction

2020-08-07 Thread GitBox
mivanac commented on pull request #5227: URL: https://github.com/apache/geode/pull/5227#issuecomment-670507310 Just for record, If you look at last commit, you can see that your requst (to force the bucket creation) is fullfilled.

[GitHub] [geode] jujoramos commented on pull request #5227: GEODE-8191: flaky test correction

2020-08-07 Thread GitBox
jujoramos commented on pull request #5227: URL: https://github.com/apache/geode/pull/5227#issuecomment-670504376 Hello @mivanac , Just for the record, I've been actively reviewing this `PR` since it was opened but I don't think the fix is sufficient to fix the flakiness, that's why I

[GitHub] [geode] mivanac commented on pull request #5227: GEODE-8191: flaky test correction

2020-08-07 Thread GitBox
mivanac commented on pull request #5227: URL: https://github.com/apache/geode/pull/5227#issuecomment-670492076 Since there is no reply on this PR, I will close it. This is an automated message from the Apache Git Service. To

[GitHub] [geode] mivanac closed pull request #5227: GEODE-8191: flaky test correction

2020-08-07 Thread GitBox
mivanac closed pull request #5227: URL: https://github.com/apache/geode/pull/5227 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [geode] mivanac merged pull request #5426: GEODE-8292: Added check if key is destroyed in CQResults

2020-08-07 Thread GitBox
mivanac merged pull request #5426: URL: https://github.com/apache/geode/pull/5426 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [geode-native] pivotal-jbarrett commented on a change in pull request #630: GEODE-8102 Link and load OpenSSL library directly

2020-08-06 Thread GitBox
pivotal-jbarrett commented on a change in pull request #630: URL: https://github.com/apache/geode-native/pull/630#discussion_r466751787 ## File path: cppcache/src/TcpConn.cpp ## @@ -318,14 +237,35 @@ size_t TcpConn::socketOp(TcpConn::SockOp op, char *buff, size_t len,

[GitHub] [geode-native] pivotal-jbarrett commented on a change in pull request #630: GEODE-8102 Link and load OpenSSL library directly

2020-08-06 Thread GitBox
pivotal-jbarrett commented on a change in pull request #630: URL: https://github.com/apache/geode-native/pull/630#discussion_r466751011 ## File path: cppcache/src/TcpConn.cpp ## @@ -318,14 +237,35 @@ size_t TcpConn::socketOp(TcpConn::SockOp op, char *buff, size_t len,

[GitHub] [geode-native] pivotal-jbarrett commented on a change in pull request #630: GEODE-8102 Link and load OpenSSL library directly

2020-08-06 Thread GitBox
pivotal-jbarrett commented on a change in pull request #630: URL: https://github.com/apache/geode-native/pull/630#discussion_r466748307 ## File path: cppcache/src/TcpConn.hpp ## @@ -65,75 +62,33 @@ class APACHE_GEODE_EXPORT TcpConn : public Connector { virtual void

[GitHub] [geode-native] pivotal-jbarrett commented on a change in pull request #630: GEODE-8102 Link and load OpenSSL library directly

2020-08-06 Thread GitBox
pivotal-jbarrett commented on a change in pull request #630: URL: https://github.com/apache/geode-native/pull/630#discussion_r466748099 ## File path: cppcache/src/TcpConn.cpp ## @@ -318,14 +237,35 @@ size_t TcpConn::socketOp(TcpConn::SockOp op, char *buff, size_t len,

[GitHub] [geode-native] pdxcodemonkey commented on a change in pull request #630: GEODE-8102 Link and load OpenSSL library directly

2020-08-06 Thread GitBox
pdxcodemonkey commented on a change in pull request #630: URL: https://github.com/apache/geode-native/pull/630#discussion_r466728135 ## File path: cppcache/src/TcpConn.cpp ## @@ -318,14 +237,35 @@ size_t TcpConn::socketOp(TcpConn::SockOp op, char *buff, size_t len,

[GitHub] [geode] dschneider-pivotal opened a new pull request #5431: change memberDeparted to disconnect the connection

2020-08-06 Thread GitBox
dschneider-pivotal opened a new pull request #5431: URL: https://github.com/apache/geode/pull/5431 Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ###

[GitHub] [geode] bschuchardt merged pull request #5422: GEODE-6950: hot loop in PrimaryHandler.processRequest()

2020-08-06 Thread GitBox
bschuchardt merged pull request #5422: URL: https://github.com/apache/geode/pull/5422 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [geode] Bill commented on a change in pull request #5422: GEODE-6950: hot loop in PrimaryHandler.processRequest()

2020-08-06 Thread GitBox
Bill commented on a change in pull request #5422: URL: https://github.com/apache/geode/pull/5422#discussion_r466543551 ## File path: geode-membership/src/main/java/org/apache/geode/distributed/internal/membership/gms/locator/PrimaryHandler.java ## @@ -39,9 +39,17 @@

[GitHub] [geode] agingade commented on a change in pull request #5424: GEODE-8394: Rewind the message Part on command failure

2020-08-06 Thread GitBox
agingade commented on a change in pull request #5424: URL: https://github.com/apache/geode/pull/5424#discussion_r466584837 ## File path: geode-core/src/distributedTest/java/org/apache/geode/cache30/ClientServerCacheOperationDUnitTest.java ## @@ -0,0 +1,200 @@ +/* + * Licensed

[GitHub] [geode] jivthesh opened a new pull request #5430: added code of conduct to project

2020-08-06 Thread GitBox
jivthesh opened a new pull request #5430: URL: https://github.com/apache/geode/pull/5430 Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all

[GitHub] [geode] jinmeiliao commented on a change in pull request #5348: DRAFT: Add flag in gateway sender to not store dropped events while stopped …

2020-08-06 Thread GitBox
jinmeiliao commented on a change in pull request #5348: URL: https://github.com/apache/geode/pull/5348#discussion_r466542979 ## File path: geode-core/src/main/java/org/apache/geode/management/internal/beans/GatewaySenderMBeanBridge.java ## @@ -334,4 +334,8 @@ public boolean

[GitHub] [geode] bschuchardt merged pull request #5428: GEODE-8407: MergeLogFiles fails to include files with the same name b…

2020-08-06 Thread GitBox
bschuchardt merged pull request #5428: URL: https://github.com/apache/geode/pull/5428 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [geode-native] alb3rtobr commented on pull request #628: GEODE-8344: Add GatewaySenderEventCallbackArgument class

2020-08-06 Thread GitBox
alb3rtobr commented on pull request #628: URL: https://github.com/apache/geode-native/pull/628#issuecomment-669938261 With the new integration test it is possible to reproduce the problem and ensure it is solved. These two logs messages can be found on test log: ```

[GitHub] [geode] lgtm-com[bot] commented on pull request #5348: DRAFT: Add flag in gateway sender to not store dropped events while stopped …

2020-08-06 Thread GitBox
lgtm-com[bot] commented on pull request #5348: URL: https://github.com/apache/geode/pull/5348#issuecomment-669908975 This pull request **introduces 1 alert** when merging 3f749fa776d4f79a637e1851a8c23ceb3eec2565 into eb8668ad7caa6e20d9be242ad719e173ebf244d8 - [view on

[GitHub] [geode] albertogpz commented on a change in pull request #5348: DRAFT: Add flag in gateway sender to not store dropped events while stopped …

2020-08-06 Thread GitBox
albertogpz commented on a change in pull request #5348: URL: https://github.com/apache/geode/pull/5348#discussion_r466370988 ## File path: geode-gfsh/src/main/java/org/apache/geode/management/internal/cli/commands/StartGatewaySenderCommand.java ## @@ -155,4 +160,38 @@ public

[GitHub] [geode] PurelyApplied commented on a change in pull request #5427: GEODE-8406: Enable early-return in CI scripts for CI-only changes

2020-08-05 Thread GitBox
PurelyApplied commented on a change in pull request #5427: URL: https://github.com/apache/geode/pull/5427#discussion_r466052198 ## File path: ci/scripts/execute_tests.sh ## @@ -34,6 +34,11 @@ if [[ -z "${GRADLE_TASK}" ]]; then exit 1 fi +.

[GitHub] [geode] dschneider-pivotal commented on a change in pull request #5420: GEODE-8333: Second attempt to fix PUBSUB hang

2020-08-05 Thread GitBox
dschneider-pivotal commented on a change in pull request #5420: URL: https://github.com/apache/geode/pull/5420#discussion_r466037897 ## File path: geode-redis/src/distributedTest/java/org/apache/geode/redis/internal/executor/pubsub/PubSubDUnitTest.java ## @@ -86,11 +89,17 @@

[GitHub] [geode] dschneider-pivotal opened a new pull request #5429: GEODE-8409: S*STORE need to handle target that is not a redis set

2020-08-05 Thread GitBox
dschneider-pivotal opened a new pull request #5429: URL: https://github.com/apache/geode/pull/5429 Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ###

[GitHub] [geode] pivotal-jbarrett commented on a change in pull request #5427: GEODE-8406: Enable early-return in CI scripts for CI-only changes

2020-08-05 Thread GitBox
pivotal-jbarrett commented on a change in pull request #5427: URL: https://github.com/apache/geode/pull/5427#discussion_r466033207 ## File path: ci/scripts/execute_tests.sh ## @@ -34,6 +34,11 @@ if [[ -z "${GRADLE_TASK}" ]]; then exit 1 fi +.

[GitHub] [geode] onichols-pivotal commented on pull request #5427: GEODE-8406: Enable early-return in CI scripts for CI-only changes

2020-08-05 Thread GitBox
onichols-pivotal commented on pull request #5427: URL: https://github.com/apache/geode/pull/5427#issuecomment-669547485 keep the modular thing, fine, but can we have a wrapper script that encapsulates the magic list, so we just call that script 6 places?

[GitHub] [geode] rhoughton-pivot commented on pull request #5427: GEODE-8406: Enable early-return in CI scripts for CI-only changes

2020-08-05 Thread GitBox
rhoughton-pivot commented on pull request #5427: URL: https://github.com/apache/geode/pull/5427#issuecomment-669546743 @pivotal-jbarrett I could have, but chose instead to have it be a modular function that takes input. Makes it clear from the outside what is being tested. Or, call it

[GitHub] [geode] pivotal-jbarrett commented on a change in pull request #5427: GEODE-8406: Enable early-return in CI scripts for CI-only changes

2020-08-05 Thread GitBox
pivotal-jbarrett commented on a change in pull request #5427: URL: https://github.com/apache/geode/pull/5427#discussion_r466022409 ## File path: ci/scripts/execute_tests.sh ## @@ -34,6 +34,11 @@ if [[ -z "${GRADLE_TASK}" ]]; then exit 1 fi +.

[GitHub] [geode] bschuchardt opened a new pull request #5428: GEODE-8407: MergeLogFiles fails to include files with the same name b…

2020-08-05 Thread GitBox
bschuchardt opened a new pull request #5428: URL: https://github.com/apache/geode/pull/5428 …ut in different directories I modified the upper levels of the merge process to hold a new object containing the file's display name and its inputStream. The logFiles Map now holds the

[GitHub] [geode] rhoughton-pivot commented on a change in pull request #5427: GEODE-8406: Enable early-return in CI scripts for CI-only changes

2020-08-05 Thread GitBox
rhoughton-pivot commented on a change in pull request #5427: URL: https://github.com/apache/geode/pull/5427#discussion_r466015382 ## File path: ci/scripts/delete_instance.sh ## @@ -29,6 +29,11 @@ while [ -h "$SOURCE" ]; do # resolve $SOURCE until the file is no longer a symli

[GitHub] [geode] rhoughton-pivot commented on pull request #5427: GEODE-8406: Enable early-return in CI scripts for CI-only changes

2020-08-05 Thread GitBox
rhoughton-pivot commented on pull request #5427: URL: https://github.com/apache/geode/pull/5427#issuecomment-669521913 > does this affect PRs only or regular pipelines as well? Do I understand correctly that this will cause the jobs to run super-fast? That will mess with timing statistics

[GitHub] [geode] rhoughton-pivot commented on a change in pull request #5427: GEODE-8406: Enable early-return in CI scripts for CI-only changes

2020-08-05 Thread GitBox
rhoughton-pivot commented on a change in pull request #5427: URL: https://github.com/apache/geode/pull/5427#discussion_r466013886 ## File path: ci/scripts/execute_tests.sh ## @@ -34,6 +34,11 @@ if [[ -z "${GRADLE_TASK}" ]]; then exit 1 fi +.

[GitHub] [geode] onichols-pivotal commented on a change in pull request #5427: GEODE-8406: Enable early-return in CI scripts for CI-only changes

2020-08-05 Thread GitBox
onichols-pivotal commented on a change in pull request #5427: URL: https://github.com/apache/geode/pull/5427#discussion_r466006805 ## File path: ci/scripts/execute_tests.sh ## @@ -34,6 +34,11 @@ if [[ -z "${GRADLE_TASK}" ]]; then exit 1 fi +.

[GitHub] [geode] jchen21 commented on a change in pull request #5424: GEODE-8394: Rewind the message Part on command failure

2020-08-05 Thread GitBox
jchen21 commented on a change in pull request #5424: URL: https://github.com/apache/geode/pull/5424#discussion_r466003540 ## File path: geode-core/src/distributedTest/java/org/apache/geode/cache30/ClientServerCacheOperationDUnitTest.java ## @@ -0,0 +1,200 @@ +/* + * Licensed

[GitHub] [geode] onichols-pivotal commented on a change in pull request #5427: GEODE-8406: Enable early-return in CI scripts for CI-only changes

2020-08-05 Thread GitBox
onichols-pivotal commented on a change in pull request #5427: URL: https://github.com/apache/geode/pull/5427#discussion_r466006536 ## File path: ci/scripts/delete_instance.sh ## @@ -29,6 +29,11 @@ while [ -h "$SOURCE" ]; do # resolve $SOURCE until the file is no longer a

[GitHub] [geode] onichols-pivotal commented on a change in pull request #5427: GEODE-8406: Enable early-return in CI scripts for CI-only changes

2020-08-05 Thread GitBox
onichols-pivotal commented on a change in pull request #5427: URL: https://github.com/apache/geode/pull/5427#discussion_r466006805 ## File path: ci/scripts/execute_tests.sh ## @@ -34,6 +34,11 @@ if [[ -z "${GRADLE_TASK}" ]]; then exit 1 fi +.

[GitHub] [geode] jinmeiliao commented on a change in pull request #5348: DRAFT: Add flag in gateway sender to not store dropped events while stopped …

2020-08-05 Thread GitBox
jinmeiliao commented on a change in pull request #5348: URL: https://github.com/apache/geode/pull/5348#discussion_r465920598 ## File path: geode-gfsh/src/main/java/org/apache/geode/management/internal/cli/commands/StartGatewaySenderCommand.java ## @@ -155,4 +160,38 @@ public

[GitHub] [geode] albertogpz commented on a change in pull request #5348: DRAFT: Add flag in gateway sender to not store dropped events while stopped …

2020-08-05 Thread GitBox
albertogpz commented on a change in pull request #5348: URL: https://github.com/apache/geode/pull/5348#discussion_r465912609 ## File path: geode-gfsh/src/main/java/org/apache/geode/management/internal/cli/commands/StartGatewaySenderCommand.java ## @@ -155,4 +160,38 @@ public

[GitHub] [geode] albertogpz commented on a change in pull request #5348: DRAFT: Add flag in gateway sender to not store dropped events while stopped …

2020-08-05 Thread GitBox
albertogpz commented on a change in pull request #5348: URL: https://github.com/apache/geode/pull/5348#discussion_r465909971 ## File path: geode-core/src/main/java/org/apache/geode/internal/cache/wan/AbstractGatewaySender.java ## @@ -180,6 +180,9 @@ protected volatile

[GitHub] [geode] jinmeiliao commented on a change in pull request #5348: DRAFT: Add flag in gateway sender to not store dropped events while stopped …

2020-08-05 Thread GitBox
jinmeiliao commented on a change in pull request #5348: URL: https://github.com/apache/geode/pull/5348#discussion_r465905356 ## File path: geode-core/src/main/java/org/apache/geode/internal/cache/wan/AbstractGatewaySender.java ## @@ -180,6 +180,9 @@ protected volatile

[GitHub] [geode] mivanac opened a new pull request #5426: GEODE-8292: Added check if key is destroyed in CQResults

2020-08-05 Thread GitBox
mivanac opened a new pull request #5426: URL: https://github.com/apache/geode/pull/5426 Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all

[GitHub] [geode] rhoughton-pivot merged pull request #5416: GEODE-8382: Run Redis tests against Redis API for Geode

2020-08-05 Thread GitBox
rhoughton-pivot merged pull request #5416: URL: https://github.com/apache/geode/pull/5416 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [geode] demery-pivotal opened a new pull request #5425: DO NOT REVIEW: Use ephemeral port knocking to find and "reserve" free ports.

2020-08-04 Thread GitBox
demery-pivotal opened a new pull request #5425: URL: https://github.com/apache/geode/pull/5425 Co-Authored-by Jacob Barrett Co-Authored-by: Dale Emery diff --git a/geode-core/src/distributedTest/java/org/apache/geode/cache30/ReconnectWithClusterConfigurationDUnitTest.java

[GitHub] [geode] davebarnes97 merged pull request #5423: GEODE-8401: User Guide - incorrect method name on "forced disconnect"…

2020-08-04 Thread GitBox
davebarnes97 merged pull request #5423: URL: https://github.com/apache/geode/pull/5423 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [geode] demery-pivotal closed pull request #5406: DO NOT REVIEW Wip/available ports

2020-08-04 Thread GitBox
demery-pivotal closed pull request #5406: URL: https://github.com/apache/geode/pull/5406 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [geode] agingade opened a new pull request #5424: GEODE-8394: Rewind the message Part on command failure

2020-08-04 Thread GitBox
agingade opened a new pull request #5424: URL: https://github.com/apache/geode/pull/5424 This change rewinds the message part on command failure. Without this during retry on failure, the message (Part) is sent from the place where it was previously failed, instead of starting from the

[GitHub] [geode] lgtm-com[bot] commented on pull request #5390: ClassLoader isolation

2020-08-04 Thread GitBox
lgtm-com[bot] commented on pull request #5390: URL: https://github.com/apache/geode/pull/5390#issuecomment-668876145 This pull request **introduces 2 alerts** and **fixes 2** when merging c50c3429756811ed64e13675f2faa83b49daa71f into 53abb22cd295441f8794e15550b72ec81113ec05 - [view on

[GitHub] [geode] davebarnes97 opened a new pull request #5423: GEODE-8401: User Guide - incorrect method name on "forced disconnect"…

2020-08-04 Thread GitBox
davebarnes97 opened a new pull request #5423: URL: https://github.com/apache/geode/pull/5423 … page `Cache.waitForReconnect(long, TimeUnit)` should be `Cache.waitUntilReconnected(long, TimeUnit)` This is an automated

[GitHub] [geode] bschuchardt opened a new pull request #5422: GEODE-6950: hot loop in PrimaryHandler.processRequest()

2020-08-04 Thread GitBox
bschuchardt opened a new pull request #5422: URL: https://github.com/apache/geode/pull/5422 The ticket had a suggested fix for the locator's hot loop and I've implemented that. I modified PrimaryHandler to make the issue testable and added a couple of other tests for registered and

[GitHub] [geode] lgtm-com[bot] commented on pull request #5390: ClassLoader isolation

2020-08-04 Thread GitBox
lgtm-com[bot] commented on pull request #5390: URL: https://github.com/apache/geode/pull/5390#issuecomment-668746687 This pull request **introduces 2 alerts** and **fixes 2** when merging f855cfcb31700189d22469648e8584b483c006ba into 53abb22cd295441f8794e15550b72ec81113ec05 - [view on

[GitHub] [geode-native] alb3rtobr commented on pull request #628: GEODE-8344: Add GatewaySenderEventCallbackArgument class

2020-08-04 Thread GitBox
alb3rtobr commented on pull request #628: URL: https://github.com/apache/geode-native/pull/628#issuecomment-668701694 Sorry for the late answer, I have been on vacation. I have changed the PR to draft because Im still working on the tests. I have added some functionality to the

[GitHub] [geode] onichols-pivotal commented on a change in pull request #5416: GEODE-8382: Run Redis tests against Redis API for Geode

2020-08-04 Thread GitBox
onichols-pivotal commented on a change in pull request #5416: URL: https://github.com/apache/geode/pull/5416#discussion_r465158361 ## File path: ci/scripts/execute_redis_tests.sh ## @@ -0,0 +1,51 @@ +#!/usr/bin/env bash + +# +# Licensed to the Apache Software Foundation (ASF)

[GitHub] [geode] onichols-pivotal commented on a change in pull request #5416: GEODE-8382: Run Redis tests against Redis API for Geode

2020-08-04 Thread GitBox
onichols-pivotal commented on a change in pull request #5416: URL: https://github.com/apache/geode/pull/5416#discussion_r465158361 ## File path: ci/scripts/execute_redis_tests.sh ## @@ -0,0 +1,51 @@ +#!/usr/bin/env bash + +# +# Licensed to the Apache Software Foundation (ASF)

[GitHub] [geode] sabbeyPivotal commented on a change in pull request #5416: GEODE-8382: Run Redis tests against Redis API for Geode

2020-08-04 Thread GitBox
sabbeyPivotal commented on a change in pull request #5416: URL: https://github.com/apache/geode/pull/5416#discussion_r465148577 ## File path: ci/scripts/execute_redis_tests.sh ## @@ -0,0 +1,51 @@ +#!/usr/bin/env bash + +# +# Licensed to the Apache Software Foundation (ASF)

[GitHub] [geode] bschuchardt closed pull request #5265: work in progress

2020-08-04 Thread GitBox
bschuchardt closed pull request #5265: URL: https://github.com/apache/geode/pull/5265 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [geode] sabbeyPivotal commented on a change in pull request #5416: GEODE-8382: Run Redis tests against Redis API for Geode

2020-08-04 Thread GitBox
sabbeyPivotal commented on a change in pull request #5416: URL: https://github.com/apache/geode/pull/5416#discussion_r464665951 ## File path: ci/scripts/execute_redis_tests.sh ## @@ -0,0 +1,51 @@ +#!/usr/bin/env bash + +# +# Licensed to the Apache Software Foundation (ASF)

[GitHub] [geode] sabbeyPivotal closed pull request #5421: Pr2

2020-08-03 Thread GitBox
sabbeyPivotal closed pull request #5421: URL: https://github.com/apache/geode/pull/5421 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [geode] sabbeyPivotal opened a new pull request #5421: Pr2

2020-08-03 Thread GitBox
sabbeyPivotal opened a new pull request #5421: URL: https://github.com/apache/geode/pull/5421 test456 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [geode] dschneider-pivotal merged pull request #5419: GEODE-6564: fix entryExpiryTasks leak

2020-08-03 Thread GitBox
dschneider-pivotal merged pull request #5419: URL: https://github.com/apache/geode/pull/5419 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [geode] sabbeyPivotal commented on a change in pull request #5416: GEODE-8382: Run Redis tests against Redis API for Geode

2020-08-03 Thread GitBox
sabbeyPivotal commented on a change in pull request #5416: URL: https://github.com/apache/geode/pull/5416#discussion_r464666362 ## File path: ci/scripts/execute_redis_tests.sh ## @@ -0,0 +1,51 @@ +#!/usr/bin/env bash + +# +# Licensed to the Apache Software Foundation (ASF)

[GitHub] [geode] sabbeyPivotal commented on a change in pull request #5416: GEODE-8382: Run Redis tests against Redis API for Geode

2020-08-03 Thread GitBox
sabbeyPivotal commented on a change in pull request #5416: URL: https://github.com/apache/geode/pull/5416#discussion_r464666188 ## File path: ci/scripts/execute_redis_tests.sh ## @@ -0,0 +1,51 @@ +#!/usr/bin/env bash + +# +# Licensed to the Apache Software Foundation (ASF)

[GitHub] [geode] sabbeyPivotal commented on a change in pull request #5416: GEODE-8382: Run Redis tests against Redis API for Geode

2020-08-03 Thread GitBox
sabbeyPivotal commented on a change in pull request #5416: URL: https://github.com/apache/geode/pull/5416#discussion_r464665951 ## File path: ci/scripts/execute_redis_tests.sh ## @@ -0,0 +1,51 @@ +#!/usr/bin/env bash + +# +# Licensed to the Apache Software Foundation (ASF)

[GitHub] [geode] lgtm-com[bot] commented on pull request #5390: ClassLoader isolation

2020-08-03 Thread GitBox
lgtm-com[bot] commented on pull request #5390: URL: https://github.com/apache/geode/pull/5390#issuecomment-668245249 This pull request **introduces 2 alerts** and **fixes 2** when merging 373fdda56c7adb155d9255e2f96eb96993110467 into 54421c4cd5ddde9e459f544fef9f27b44fa1ab6c - [view on

[GitHub] [geode] sabbeyPivotal commented on a change in pull request #5416: GEODE-8382: Run Redis tests against Redis API for Geode

2020-08-03 Thread GitBox
sabbeyPivotal commented on a change in pull request #5416: URL: https://github.com/apache/geode/pull/5416#discussion_r464665517 ## File path: ci/scripts/execute_redis_tests.sh ## @@ -0,0 +1,51 @@ +#!/usr/bin/env bash + +# +# Licensed to the Apache Software Foundation (ASF)

[GitHub] [geode] sabbeyPivotal commented on a change in pull request #5416: GEODE-8382: Run Redis tests against Redis API for Geode

2020-08-03 Thread GitBox
sabbeyPivotal commented on a change in pull request #5416: URL: https://github.com/apache/geode/pull/5416#discussion_r464665333 ## File path: ci/pipelines/shared/jinja.variables.yml ## @@ -140,6 +140,19 @@ tests: PLATFORM: linux RAM: '210' name: Upgrade +-

[GitHub] [geode] bschuchardt merged pull request #5413: GEODE-8389: reconnect attempt fails due to distribution configuration…

2020-08-03 Thread GitBox
bschuchardt merged pull request #5413: URL: https://github.com/apache/geode/pull/5413 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [geode] onichols-pivotal commented on a change in pull request #5416: GEODE-8382: Run Redis tests against Redis API for Geode

2020-08-03 Thread GitBox
onichols-pivotal commented on a change in pull request #5416: URL: https://github.com/apache/geode/pull/5416#discussion_r464647336 ## File path: ci/scripts/execute_redis_tests.sh ## @@ -0,0 +1,51 @@ +#!/usr/bin/env bash + +# +# Licensed to the Apache Software Foundation (ASF)

[GitHub] [geode] onichols-pivotal commented on a change in pull request #5416: GEODE-8382: Run Redis tests against Redis API for Geode

2020-08-03 Thread GitBox
onichols-pivotal commented on a change in pull request #5416: URL: https://github.com/apache/geode/pull/5416#discussion_r464646511 ## File path: ci/scripts/execute_redis_tests.sh ## @@ -0,0 +1,51 @@ +#!/usr/bin/env bash + +# +# Licensed to the Apache Software Foundation (ASF)

[GitHub] [geode] onichols-pivotal commented on a change in pull request #5416: GEODE-8382: Run Redis tests against Redis API for Geode

2020-08-03 Thread GitBox
onichols-pivotal commented on a change in pull request #5416: URL: https://github.com/apache/geode/pull/5416#discussion_r464644167 ## File path: ci/scripts/execute_redis_tests.sh ## @@ -0,0 +1,51 @@ +#!/usr/bin/env bash + +# +# Licensed to the Apache Software Foundation (ASF)

[GitHub] [geode] dschneider-pivotal commented on pull request #5419: GEODE-6564: fix entryExpiryTasks leak

2020-08-03 Thread GitBox
dschneider-pivotal commented on pull request #5419: URL: https://github.com/apache/geode/pull/5419#issuecomment-668226584 The dunit failure is the known issue: GEODE-7710 This is an automated message from the Apache Git

[GitHub] [geode] onichols-pivotal commented on a change in pull request #5416: GEODE-8382: Run Redis tests against Redis API for Geode

2020-08-03 Thread GitBox
onichols-pivotal commented on a change in pull request #5416: URL: https://github.com/apache/geode/pull/5416#discussion_r464644167 ## File path: ci/scripts/execute_redis_tests.sh ## @@ -0,0 +1,51 @@ +#!/usr/bin/env bash + +# +# Licensed to the Apache Software Foundation (ASF)

[GitHub] [geode] rhoughton-pivot commented on a change in pull request #5416: GEODE-8382: Run Redis tests against Redis API for Geode

2020-08-03 Thread GitBox
rhoughton-pivot commented on a change in pull request #5416: URL: https://github.com/apache/geode/pull/5416#discussion_r464641006 ## File path: ci/scripts/execute_redis_tests.sh ## @@ -0,0 +1,51 @@ +#!/usr/bin/env bash + +# +# Licensed to the Apache Software Foundation (ASF)

  1   2   3   4   5   6   7   8   9   10   >