[GitHub] [geode-native] alb3rtobr commented on pull request #628: GEODE-8344: Add GatewaySenderEventCallbackArgument class

2020-08-18 Thread GitBox 


alb3rtobr commented on pull request #628:
URL: https://github.com/apache/geode-native/pull/628#issuecomment-675311553


   thanks for the reviews! Sorry but I need someone to merge the PR because Im 
not a committer



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [geode-native] alb3rtobr commented on pull request #628: GEODE-8344: Add GatewaySenderEventCallbackArgument class

2020-08-17 Thread GitBox 


alb3rtobr commented on pull request #628:
URL: https://github.com/apache/geode-native/pull/628#issuecomment-674947497


   Hi @moleske @echobravopapa @pivotal-jbarrett , is there anything else 
missing to approve this PR? 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [geode-native] alb3rtobr commented on pull request #628: GEODE-8344: Add GatewaySenderEventCallbackArgument class

2020-08-06 Thread GitBox 


alb3rtobr commented on pull request #628:
URL: https://github.com/apache/geode-native/pull/628#issuecomment-669938261


   With the new integration test it is possible to reproduce the problem and 
ensure it is solved.
   
   These two logs messages can be found on test log:
   ```
   Region::put: region [/region] created key [order], value [OrderID: 2 Product 
Name: product y Quantity: 37]
   Region::put: region [/region] created key [order], value 
[PDX[28743191,com.example.Order]{name=product y,order_id=2,quantity=37}]
   ```
   Without the GatewaySenderEventCallbackArgument class added to the code, 
there is a deserialization exception when receiving the second event, so 
instead of that message, this is one appears:
   ```
   Exception while receiving subscription event for endpoint localhost:33829:: 
apache::geode::client::IllegalStateException: Unregistered type in 
deserialization
   ```
   As the event generated in cluster A is not deserialized correctly in cluster 
B, it is not processed by the dummy cache listener implemented, and the test 
case will fail with this error:
   ```
Expected equality of these values:
 cacheListenerB->getNumEvents()
   Which is: 0
 1
   ```
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [geode-native] alb3rtobr commented on pull request #628: GEODE-8344: Add GatewaySenderEventCallbackArgument class

2020-08-04 Thread GitBox 


alb3rtobr commented on pull request #628:
URL: https://github.com/apache/geode-native/pull/628#issuecomment-668701694


   Sorry for the late answer, I have been on vacation. I have changed the PR to 
draft because Im still working on the tests. I have added some functionality to 
the integration test framework in order to reproduce configure two clusters to 
reproduce the error, but I still have a problem with a disk access exception 
when configuring gateway senders.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org