Github user paplorinc commented on a diff in the pull request:
https://github.com/apache/groovy/pull/360#discussion_r70182253
--- Diff: src/main/groovy/lang/ObjectRange.java ---
@@ -537,8 +539,9 @@ protected Object increment(Object value) {
* @param value the value to decr
Github user blackdrag commented on a diff in the pull request:
https://github.com/apache/groovy/pull/360#discussion_r70181647
--- Diff: src/main/groovy/lang/ObjectRange.java ---
@@ -537,8 +539,9 @@ protected Object increment(Object value) {
* @param value the value to decr
Github user paplorinc commented on a diff in the pull request:
https://github.com/apache/groovy/pull/360#discussion_r70181162
--- Diff: src/main/groovy/lang/ObjectRange.java ---
@@ -537,8 +539,9 @@ protected Object increment(Object value) {
* @param value the value to decr
Github user paulk-asert commented on a diff in the pull request:
https://github.com/apache/groovy/pull/360#discussion_r70181071
--- Diff: src/main/groovy/lang/ObjectRange.java ---
@@ -537,8 +539,9 @@ protected Object increment(Object value) {
* @param value the value to de
Github user paulk-asert commented on the pull request:
https://github.com/apache/groovy/commit/380ae614ae4d979f00e6e362d210e2dd1295bdce#commitcomment-18187118
In build.gradle:
In build.gradle on line 142:
I noticed that this broke japicmp. I know we have that disabled at the
m
Github user paplorinc commented on a diff in the pull request:
https://github.com/apache/groovy/pull/360#discussion_r70180831
--- Diff: src/main/groovy/lang/IntRange.java ---
@@ -379,32 +379,25 @@ public boolean containsAll(Collection other) {
@Override
public void
Github user paplorinc commented on a diff in the pull request:
https://github.com/apache/groovy/pull/360#discussion_r70180818
--- Diff: src/main/groovy/lang/ObjectRange.java ---
@@ -493,40 +495,52 @@ public void remove() {
/**
* Increments by step size
+
Github user paulk-asert commented on a diff in the pull request:
https://github.com/apache/groovy/pull/360#discussion_r70180723
--- Diff: src/main/groovy/lang/ObjectRange.java ---
@@ -493,40 +495,52 @@ public void remove() {
/**
* Increments by step size
Github user paplorinc commented on a diff in the pull request:
https://github.com/apache/groovy/pull/360#discussion_r70180656
--- Diff: src/main/groovy/lang/ObjectRange.java ---
@@ -518,25 +496,41 @@ private T peek() {
}
/**
- * Increments by one
Github user paplorinc commented on a diff in the pull request:
https://github.com/apache/groovy/pull/360#discussion_r70180619
--- Diff: src/main/groovy/lang/ObjectRange.java ---
@@ -493,40 +495,52 @@ public void remove() {
/**
* Increments by step size
+
Github user paplorinc commented on a diff in the pull request:
https://github.com/apache/groovy/pull/360#discussion_r70180603
--- Diff: src/main/groovy/lang/ObjectRange.java ---
@@ -261,16 +260,12 @@ public T get(int index) {
@Override
public boolean containsWithin
Github user paulk-asert commented on a diff in the pull request:
https://github.com/apache/groovy/pull/360#discussion_r70180536
--- Diff: src/main/groovy/lang/ObjectRange.java ---
@@ -518,25 +496,41 @@ private T peek() {
}
/**
- * Increments by one
Github user paulk-asert commented on a diff in the pull request:
https://github.com/apache/groovy/pull/360#discussion_r70180503
--- Diff: src/main/groovy/lang/ObjectRange.java ---
@@ -220,13 +219,15 @@ public boolean equals(ObjectRange that) {
}
@Override
Github user paulk-asert commented on a diff in the pull request:
https://github.com/apache/groovy/pull/360#discussion_r70180474
--- Diff: src/main/groovy/lang/ObjectRange.java ---
@@ -261,16 +260,12 @@ public T get(int index) {
@Override
public boolean containsWith
Github user paulk-asert commented on a diff in the pull request:
https://github.com/apache/groovy/pull/360#discussion_r70180377
--- Diff: src/main/groovy/lang/ObjectRange.java ---
@@ -493,40 +495,52 @@ public void remove() {
/**
* Increments by step size
Github user paulk-asert commented on a diff in the pull request:
https://github.com/apache/groovy/pull/360#discussion_r70180330
--- Diff: src/main/groovy/lang/IntRange.java ---
@@ -379,32 +379,25 @@ public boolean containsAll(Collection other) {
@Override
public vo
Github user paplorinc commented on a diff in the pull request:
https://github.com/apache/groovy/pull/360#discussion_r70178946
--- Diff: src/test/groovy/RangeTest.groovy ---
@@ -262,6 +264,21 @@ class RangeTest extends GroovyTestCase {
assert (0..
Github user paplorinc commented on a diff in the pull request:
https://github.com/apache/groovy/pull/360#discussion_r70178940
--- Diff: src/main/groovy/lang/ObjectRange.java ---
@@ -390,10 +390,6 @@ public boolean contains(Object value) {
@Override
public voi
Github user paplorinc commented on the pull request:
https://github.com/apache/groovy/commit/a009d432a7daa83094d59181addb14f64d0f857a#commitcomment-18186811
In src/main/groovy/lang/ObjectRange.java:
In src/main/groovy/lang/ObjectRange.java on line 530:
Again, could you please m
Github user paplorinc commented on the pull request:
https://github.com/apache/groovy/commit/ffc24888098019383272c66d90e746bb4139a74e#commitcomment-18186791
In src/main/groovy/lang/ObjectRange.java:
In src/main/groovy/lang/ObjectRange.java on line 384:
I thought I removed all c
Github user paulk-asert commented on the pull request:
https://github.com/apache/groovy/commit/ffc24888098019383272c66d90e746bb4139a74e#commitcomment-18186653
In src/main/groovy/lang/ObjectRange.java:
In src/main/groovy/lang/ObjectRange.java on line 384:
My preference is defini
21 matches
Mail list logo
