[jira] [Resolved] (GROOVY-11308) DefaultGroovyMethods#unique now returns null for empty or 1 element input

2024-02-13 Thread Paul King (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-11308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paul King resolved GROOVY-11308. Fix Version/s: 3.0.21 4.0.19 5.0.0-alpha-6

[jira] [Assigned] (GROOVY-11308) DefaultGroovyMethods#unique now returns null for empty or 1 element input

2024-02-13 Thread Paul King (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-11308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paul King reassigned GROOVY-11308: -- Assignee: Paul King > DefaultGroovyMethods#unique now returns null for empty or 1 element

[jira] [Commented] (GROOVY-11308) DefaultGroovyMethods#unique now returns null for empty or 1 element input

2024-02-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-11308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17817212#comment-17817212 ] ASF GitHub Bot commented on GROOVY-11308: - paulk-asert commented on PR #2056: URL:

Re: [PR] GROOVY-11308: Restore compatibility of Collection#unique [groovy]

2024-02-13 Thread via GitHub
paulk-asert commented on PR #2056: URL: https://github.com/apache/groovy/pull/2056#issuecomment-1943102336 Merged, thanks! There is a small tweak we can do to get the minor performance gain that I think the original code was after, but I can do that after the merge. -- This is an

[jira] [Commented] (GROOVY-11308) DefaultGroovyMethods#unique now returns null for empty or 1 element input

2024-02-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-11308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17817211#comment-17817211 ] ASF GitHub Bot commented on GROOVY-11308: - paulk-asert merged PR #2056: URL:

Re: [PR] GROOVY-11308: Restore compatibility of Collection#unique [groovy]

2024-02-13 Thread via GitHub
paulk-asert merged PR #2056: URL: https://github.com/apache/groovy/pull/2056 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] GROOVY-11308: Restore compatibility of Collection#unique [groovy]

2024-02-13 Thread via GitHub
codecov-commenter commented on PR #2056: URL: https://github.com/apache/groovy/pull/2056#issuecomment-1943095932 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/2056?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report All modified

[jira] [Commented] (GROOVY-11308) DefaultGroovyMethods#unique now returns null for empty or 1 element input

2024-02-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-11308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17817210#comment-17817210 ] ASF GitHub Bot commented on GROOVY-11308: - codecov-commenter commented on PR #2056: URL:

[jira] [Commented] (GROOVY-11308) DefaultGroovyMethods#unique now returns null for empty or 1 element input

2024-02-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-11308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17817193#comment-17817193 ] ASF GitHub Bot commented on GROOVY-11308: - octylFractal opened a new pull request, #2056: URL:

[jira] [Commented] (GROOVY-11311) Groovy Closure not retaining param annotations, but only for the default single object param case

2024-02-13 Thread Val E (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-11311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17817191#comment-17817191 ] Val E commented on GROOVY-11311: Heh. Thanks. So checking doCall (instead of call) works perfectly fine

[jira] [Updated] (GROOVY-11311) Groovy Closure not retaining param annotations, but only for the default single object param case

2024-02-13 Thread Val E (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-11311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Val E updated GROOVY-11311: --- Priority: Minor (was: Major) > Groovy Closure not retaining param annotations, but only for the default

[jira] [Commented] (GROOVY-11311) Groovy Closure not retaining param annotations, but only for the default single object param case

2024-02-13 Thread Jochen Theodorou (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-11311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17817182#comment-17817182 ] Jochen Theodorou commented on GROOVY-11311: --- I am a bit surprised because you check the call

[jira] [Updated] (GROOVY-11311) Groovy Closure not retaining param annotations, but only for the default single object param case

2024-02-13 Thread Val E (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-11311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Val E updated GROOVY-11311: --- Description: In trying to process Groovy closure param annotations, via Java reflection, I realized that

[jira] [Updated] (GROOVY-11311) Groovy Closure not retaining param annotations, but only for the default single object param case

2024-02-13 Thread Val E (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-11311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Val E updated GROOVY-11311: --- Description: In trying to process Groovy closure param annotations, via Java reflection, I realized that

[jira] [Updated] (GROOVY-11311) Groovy Closure not retaining param annotations, but only for the default single object param case

2024-02-13 Thread Val E (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-11311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Val E updated GROOVY-11311: --- Description: In trying to process Groovy closure param annotations, via Java reflection, I realized that

[jira] [Updated] (GROOVY-11311) Groovy Closure not retaining param annotations, but only for the default single object param case

2024-02-13 Thread Val E (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-11311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Val E updated GROOVY-11311: --- Description: In trying to process Groovy closure param annotations, via Java reflection, I realized that

[jira] [Created] (GROOVY-11311) Groovy Closure not retaining param annotations, but only for the default single object param case

2024-02-13 Thread Val E (Jira)
Val E created GROOVY-11311: -- Summary: Groovy Closure not retaining param annotations, but only for the default single object param case Key: GROOVY-11311 URL: https://issues.apache.org/jira/browse/GROOVY-11311