[GitHub] groovy pull request #:

2017-05-20 Thread danielsun1106
Github user danielsun1106 commented on the pull request: https://github.com/apache/groovy/commit/b02d2f57c09ba6ba46553ed77aff191ec9ab274e#commitcomment-22219164 In subprojects/parser-antlr4/src/main/java/org/apache/groovy/parser/antlr4/util/StringUtils.java: In subprojects/parser

[GitHub] groovy pull request #:

2017-05-20 Thread danielsun1106
Github user danielsun1106 commented on the pull request: https://github.com/apache/groovy/commit/b02d2f57c09ba6ba46553ed77aff191ec9ab274e#commitcomment-22219142 In subprojects/parser-antlr4/src/main/java/org/apache/groovy/parser/antlr4/util/StringUtils.java: In subprojects/parser

[GitHub] groovy pull request #:

2017-05-20 Thread PascalSchumacher
Github user PascalSchumacher commented on the pull request: https://github.com/apache/groovy/commit/b02d2f57c09ba6ba46553ed77aff191ec9ab274e#commitcomment-22219131 In subprojects/parser-antlr4/src/main/java/org/apache/groovy/parser/antlr4/util/StringUtils.java: In subprojects/par

[GitHub] groovy pull request #:

2017-05-20 Thread danielsun1106
Github user danielsun1106 commented on the pull request: https://github.com/apache/groovy/commit/b02d2f57c09ba6ba46553ed77aff191ec9ab274e#commitcomment-22219095 In src/main/org/apache/groovy/util/Maps.java: In src/main/org/apache/groovy/util/Maps.java on line 11: Thanks for rev

[GitHub] groovy pull request #542: GROOVY-8193: setting sourcePosition on Property Ex...

2017-05-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/groovy/pull/542 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] groovy pull request #:

2017-05-20 Thread jwagenleitner
Github user jwagenleitner commented on the pull request: https://github.com/apache/groovy/commit/b02d2f57c09ba6ba46553ed77aff191ec9ab274e#commitcomment-22218912 In src/main/org/apache/groovy/util/Maps.java: In src/main/org/apache/groovy/util/Maps.java on line 11: JDK9 added `Ma

[GitHub] groovy pull request #543: GROOVY-8166: Repeated operations in AnnotationColl...

2017-05-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/groovy/pull/543 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] groovy pull request #532: Prevent CachedField and CachedMethod from leaking ...

2017-05-20 Thread dpolivaev
Github user dpolivaev commented on a diff in the pull request: https://github.com/apache/groovy/pull/532#discussion_r117609738 --- Diff: src/main/groovy/lang/MetaClassImpl.java --- @@ -1832,6 +1832,9 @@ public Object getProperty(Class sender, Object object, String name, boolean use

[GitHub] groovy pull request #543: GROOVY-8166: Repeated operations in AnnotationColl...

2017-05-19 Thread jwagenleitner
GitHub user jwagenleitner opened a pull request: https://github.com/apache/groovy/pull/543 GROOVY-8166: Repeated operations in AnnotationCollectorTransform and … …Traits You can merge this pull request into a Git repository by running: $ git pull https://github.com/jwagenle

[GitHub] groovy pull request #542: GROOVY-8193: setting sourcePosition on Property Ex...

2017-05-19 Thread ArsenBabakhanyan
GitHub user ArsenBabakhanyan opened a pull request: https://github.com/apache/groovy/pull/542 GROOVY-8193: setting sourcePosition on Property Expression You can merge this pull request into a Git repository by running: $ git pull https://github.com/ArsenBabakhanyan/groovy GROO

[GitHub] groovy pull request #532: Prevent CachedField and CachedMethod from leaking ...

2017-05-18 Thread dpolivaev
Github user dpolivaev commented on a diff in the pull request: https://github.com/apache/groovy/pull/532#discussion_r117188820 --- Diff: src/main/groovy/lang/MetaClassImpl.java --- @@ -1832,6 +1832,9 @@ public Object getProperty(Class sender, Object object, String name, boolean use

[GitHub] groovy pull request #532: Prevent CachedField and CachedMethod from leaking ...

2017-05-18 Thread dpolivaev
Github user dpolivaev commented on a diff in the pull request: https://github.com/apache/groovy/pull/532#discussion_r117188688 --- Diff: src/main/groovy/lang/MetaClassImpl.java --- @@ -1832,6 +1832,9 @@ public Object getProperty(Class sender, Object object, String name, boolean use

[GitHub] groovy pull request #532: Prevent CachedField and CachedMethod from leaking ...

2017-05-18 Thread dpolivaev
Github user dpolivaev commented on a diff in the pull request: https://github.com/apache/groovy/pull/532#discussion_r117188226 --- Diff: src/main/org/codehaus/groovy/reflection/CachedMethod.java --- @@ -90,6 +92,12 @@ public CachedClass getDeclaringClass() { public fi

[GitHub] groovy pull request #532: Prevent CachedField and CachedMethod from leaking ...

2017-05-18 Thread dpolivaev
Github user dpolivaev commented on a diff in the pull request: https://github.com/apache/groovy/pull/532#discussion_r117188013 --- Diff: src/main/groovy/lang/MetaClassImpl.java --- @@ -1832,6 +1832,9 @@ public Object getProperty(Class sender, Object object, String name, boolean use

[GitHub] groovy pull request #532: Prevent CachedField and CachedMethod from leaking ...

2017-05-18 Thread blackdrag
Github user blackdrag commented on a diff in the pull request: https://github.com/apache/groovy/pull/532#discussion_r117177738 --- Diff: src/main/org/codehaus/groovy/reflection/CachedMethod.java --- @@ -90,6 +92,12 @@ public CachedClass getDeclaringClass() { public fi

[GitHub] groovy pull request #532: Prevent CachedField and CachedMethod from leaking ...

2017-05-18 Thread blackdrag
Github user blackdrag commented on a diff in the pull request: https://github.com/apache/groovy/pull/532#discussion_r117177601 --- Diff: src/main/groovy/lang/MetaClassImpl.java --- @@ -1832,6 +1832,9 @@ public Object getProperty(Class sender, Object object, String name, boolean use

[GitHub] groovy pull request #532: Prevent CachedField and CachedMethod from leaking ...

2017-05-17 Thread dpolivaev
Github user dpolivaev commented on a diff in the pull request: https://github.com/apache/groovy/pull/532#discussion_r117087531 --- Diff: src/main/groovy/lang/MetaClassImpl.java --- @@ -1832,6 +1832,9 @@ public Object getProperty(Class sender, Object object, String name, boolean use

[GitHub] groovy pull request #532: Prevent CachedField and CachedMethod from leaking ...

2017-05-17 Thread jwagenleitner
Github user jwagenleitner commented on a diff in the pull request: https://github.com/apache/groovy/pull/532#discussion_r117078128 --- Diff: src/main/groovy/lang/MetaClassImpl.java --- @@ -1832,6 +1832,9 @@ public Object getProperty(Class sender, Object object, String name, boolean

[GitHub] groovy pull request #296: remove unnecessary Gradle wrapper configuration

2017-05-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/groovy/pull/296 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] groovy pull request #533: GROOVY-7840: Verifier#makeDescriptorWithoutReturnT...

2017-05-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/groovy/pull/533 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] groovy pull request #541: Improve naming and documentation for String.tokeni...

2017-05-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/groovy/pull/541 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] groovy pull request #541: Improve naming and documentation for String.tokeni...

2017-05-16 Thread mnonnenmacher
GitHub user mnonnenmacher opened a pull request: https://github.com/apache/groovy/pull/541 Improve naming and documentation for String.tokenize Calling the delimiter argument token is confusing as according to the StringTokenizer documentation delimiters are NOT treated as tokens

[GitHub] groovy pull request #533: GROOVY-7840: Verifier#makeDescriptorWithoutReturnT...

2017-05-15 Thread jwagenleitner
Github user jwagenleitner commented on a diff in the pull request: https://github.com/apache/groovy/pull/533#discussion_r116533820 --- Diff: src/main/org/apache/groovy/ast/tools/MethodNodeUtils.java --- @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software Foundation (AS

[GitHub] groovy pull request #533: GROOVY-7840: Verifier#makeDescriptorWithoutReturnT...

2017-05-15 Thread paulk-asert
Github user paulk-asert commented on a diff in the pull request: https://github.com/apache/groovy/pull/533#discussion_r116460943 --- Diff: src/main/org/apache/groovy/ast/tools/MethodNodeUtils.java --- @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] groovy pull request #533: GROOVY-7840: Verifier#makeDescriptorWithoutReturnT...

2017-05-15 Thread paulk-asert
Github user paulk-asert commented on a diff in the pull request: https://github.com/apache/groovy/pull/533#discussion_r116460996 --- Diff: src/main/org/apache/groovy/ast/tools/MethodNodeUtils.java --- @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] groovy pull request #532: Prevent CachedField and CachedMethod from leaking ...

2017-05-14 Thread dpolivaev
Github user dpolivaev commented on a diff in the pull request: https://github.com/apache/groovy/pull/532#discussion_r116377499 --- Diff: src/main/org/codehaus/groovy/reflection/CachedMethod.java --- @@ -124,6 +131,12 @@ public String getSignature() { } public

[GitHub] groovy pull request #532: Prevent CachedField and CachedMethod from leaking ...

2017-05-14 Thread dpolivaev
Github user dpolivaev commented on a diff in the pull request: https://github.com/apache/groovy/pull/532#discussion_r116377497 --- Diff: src/main/org/codehaus/groovy/reflection/CachedMethod.java --- @@ -90,6 +91,12 @@ public CachedClass getDeclaringClass() { public fi

[GitHub] groovy pull request #532: Prevent CachedField and CachedMethod from leaking ...

2017-05-14 Thread dpolivaev
Github user dpolivaev commented on a diff in the pull request: https://github.com/apache/groovy/pull/532#discussion_r116377501 --- Diff: src/main/org/codehaus/groovy/reflection/CachedMethod.java --- @@ -324,6 +337,12 @@ else if (o2 instanceof CachedMethod) }

[GitHub] groovy pull request #532: Prevent CachedField and CachedMethod from leaking ...

2017-05-14 Thread dpolivaev
Github user dpolivaev commented on a diff in the pull request: https://github.com/apache/groovy/pull/532#discussion_r116377495 --- Diff: src/main/org/codehaus/groovy/reflection/CachedField.java --- @@ -65,6 +72,12 @@ public Object getProperty(final Object object) { * @thro

[GitHub] groovy pull request #532: Prevent CachedField and CachedMethod from leaking ...

2017-05-14 Thread dpolivaev
Github user dpolivaev commented on a diff in the pull request: https://github.com/apache/groovy/pull/532#discussion_r116377482 --- Diff: src/main/org/codehaus/groovy/reflection/CachedField.java --- @@ -51,6 +52,12 @@ public int getModifiers() { */ public Object ge

[GitHub] groovy pull request #532: Prevent CachedField and CachedMethod from leaking ...

2017-05-14 Thread dpolivaev
Github user dpolivaev commented on a diff in the pull request: https://github.com/apache/groovy/pull/532#discussion_r116377432 --- Diff: src/main/org/codehaus/groovy/reflection/AccessPermissionChecker.java --- @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Founda

[GitHub] groovy pull request #532: Prevent CachedField and CachedMethod from leaking ...

2017-05-14 Thread dpolivaev
Github user dpolivaev commented on a diff in the pull request: https://github.com/apache/groovy/pull/532#discussion_r116377435 --- Diff: src/main/org/codehaus/groovy/reflection/AccessPermissionChecker.java --- @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Founda

[GitHub] groovy pull request #532: Prevent CachedField and CachedMethod from leaking ...

2017-05-14 Thread dpolivaev
Github user dpolivaev commented on a diff in the pull request: https://github.com/apache/groovy/pull/532#discussion_r116377418 --- Diff: src/main/org/codehaus/groovy/reflection/AccessPermissionChecker.java --- @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Founda

[GitHub] groovy pull request #532: Prevent CachedField and CachedMethod from leaking ...

2017-05-14 Thread dpolivaev
Github user dpolivaev commented on a diff in the pull request: https://github.com/apache/groovy/pull/532#discussion_r116377367 --- Diff: src/main/org/codehaus/groovy/reflection/AccessPermissionChecker.java --- @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Founda

[GitHub] groovy pull request #540: GROOVY-7535: Groovy category throwing MissingMetho...

2017-05-13 Thread jwagenleitner
GitHub user jwagenleitner opened a pull request: https://github.com/apache/groovy/pull/540 GROOVY-7535: Groovy category throwing MissingMethodException and Miss… …ingPropertyException when using multiple threads You can merge this pull request into a Git repository by running:

[GitHub] groovy pull request #532: Prevent CachedField and CachedMethod from leaking ...

2017-05-13 Thread jwagenleitner
Github user jwagenleitner commented on a diff in the pull request: https://github.com/apache/groovy/pull/532#discussion_r116365638 --- Diff: src/main/org/codehaus/groovy/reflection/AccessPermissionChecker.java --- @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Fo

[GitHub] groovy pull request #532: Prevent CachedField and CachedMethod from leaking ...

2017-05-13 Thread jwagenleitner
Github user jwagenleitner commented on a diff in the pull request: https://github.com/apache/groovy/pull/532#discussion_r116365514 --- Diff: src/main/org/codehaus/groovy/reflection/CachedMethod.java --- @@ -324,6 +337,12 @@ else if (o2 instanceof CachedMethod) }

[GitHub] groovy pull request #532: Prevent CachedField and CachedMethod from leaking ...

2017-05-13 Thread jwagenleitner
Github user jwagenleitner commented on a diff in the pull request: https://github.com/apache/groovy/pull/532#discussion_r116365223 --- Diff: src/main/org/codehaus/groovy/reflection/CachedField.java --- @@ -65,6 +72,12 @@ public Object getProperty(final Object object) { * @

[GitHub] groovy pull request #532: Prevent CachedField and CachedMethod from leaking ...

2017-05-13 Thread jwagenleitner
Github user jwagenleitner commented on a diff in the pull request: https://github.com/apache/groovy/pull/532#discussion_r116365151 --- Diff: src/main/org/codehaus/groovy/reflection/AccessPermissionChecker.java --- @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Fo

[GitHub] groovy pull request #532: Prevent CachedField and CachedMethod from leaking ...

2017-05-13 Thread jwagenleitner
Github user jwagenleitner commented on a diff in the pull request: https://github.com/apache/groovy/pull/532#discussion_r116365503 --- Diff: src/main/org/codehaus/groovy/reflection/CachedMethod.java --- @@ -124,6 +131,12 @@ public String getSignature() { } pu

[GitHub] groovy pull request #532: Prevent CachedField and CachedMethod from leaking ...

2017-05-13 Thread jwagenleitner
Github user jwagenleitner commented on a diff in the pull request: https://github.com/apache/groovy/pull/532#discussion_r116365354 --- Diff: src/main/org/codehaus/groovy/reflection/CachedMethod.java --- @@ -90,6 +91,12 @@ public CachedClass getDeclaringClass() { publi

[GitHub] groovy pull request #532: Prevent CachedField and CachedMethod from leaking ...

2017-05-13 Thread jwagenleitner
Github user jwagenleitner commented on a diff in the pull request: https://github.com/apache/groovy/pull/532#discussion_r116365210 --- Diff: src/main/org/codehaus/groovy/reflection/CachedField.java --- @@ -51,6 +52,12 @@ public int getModifiers() { */ public Objec

[GitHub] groovy pull request #532: Prevent CachedField and CachedMethod from leaking ...

2017-05-13 Thread jwagenleitner
Github user jwagenleitner commented on a diff in the pull request: https://github.com/apache/groovy/pull/532#discussion_r116365112 --- Diff: src/main/org/codehaus/groovy/reflection/AccessPermissionChecker.java --- @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Fo

[GitHub] groovy pull request #532: Prevent CachedField and CachedMethod from leaking ...

2017-05-13 Thread jwagenleitner
Github user jwagenleitner commented on a diff in the pull request: https://github.com/apache/groovy/pull/532#discussion_r116365147 --- Diff: src/main/org/codehaus/groovy/reflection/AccessPermissionChecker.java --- @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Fo

[GitHub] groovy pull request #533: GROOVY-7840: Verifier#makeDescriptorWithoutReturnT...

2017-05-13 Thread jwagenleitner
Github user jwagenleitner commented on a diff in the pull request: https://github.com/apache/groovy/pull/533#discussion_r116363909 --- Diff: src/main/org/apache/groovy/ast/tools/MethodNodeUtils.java --- @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software Foundation (AS

[GitHub] groovy pull request #533: GROOVY-7840: Verifier#makeDescriptorWithoutReturnT...

2017-05-13 Thread jwagenleitner
Github user jwagenleitner commented on a diff in the pull request: https://github.com/apache/groovy/pull/533#discussion_r116363829 --- Diff: src/main/org/apache/groovy/ast/tools/MethodNodeUtils.java --- @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software Foundation (AS

[GitHub] groovy pull request #533: GROOVY-7840: Verifier#makeDescriptorWithoutReturnT...

2017-05-13 Thread jwagenleitner
Github user jwagenleitner commented on a diff in the pull request: https://github.com/apache/groovy/pull/533#discussion_r116363767 --- Diff: src/main/org/apache/groovy/ast/tools/ClassNodeUtils.java --- @@ -0,0 +1,48 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] groovy pull request #539: GROOVY-8074: Statically compiled dot property acce...

2017-05-11 Thread shils
Github user shils commented on a diff in the pull request: https://github.com/apache/groovy/pull/539#discussion_r116149015 --- Diff: src/test/org/codehaus/groovy/classgen/asm/sc/ArraysAndCollectionsStaticCompileTest.groovy --- @@ -128,6 +128,18 @@ class ArraysAndCollectionsStaticC

[GitHub] groovy pull request #537: GROOVY-8157: Flow typing doesn't work with assignm...

2017-05-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/groovy/pull/537 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] groovy pull request #539: GROOVY-8074: Statically compiled dot property acce...

2017-05-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/groovy/pull/539 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] groovy pull request #539: GROOVY-8074: Statically compiled dot property acce...

2017-05-10 Thread paulk-asert
Github user paulk-asert commented on a diff in the pull request: https://github.com/apache/groovy/pull/539#discussion_r115862393 --- Diff: src/test/org/codehaus/groovy/classgen/asm/sc/ArraysAndCollectionsStaticCompileTest.groovy --- @@ -128,6 +128,18 @@ class ArraysAndCollectionsS

[GitHub] groovy pull request #539: GROOVY-8074: Statically compiled dot property acce...

2017-05-07 Thread shils
GitHub user shils opened a pull request: https://github.com/apache/groovy/pull/539 GROOVY-8074: Statically compiled dot property accesses instance prope… …rty instead of Map property You can merge this pull request into a Git repository by running: $ git pull https://github

[GitHub] groovy pull request #536: Improve type inference/STC compatibility of Sql me...

2017-05-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/groovy/pull/536 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] groovy pull request #535: GROOVY-8176: tap - exception in phase 'instruction...

2017-05-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/groovy/pull/535 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] groovy pull request #530: Clarify documentation around indy

2017-05-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/groovy/pull/530 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] groovy pull request #538: GROOVY-8135: SecureASTCustomizer whitelist does no...

2017-05-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/groovy/pull/538 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] groovy pull request #538: GROOVY-8135: SecureASTCustomizer whitelist does no...

2017-05-06 Thread armsargis
GitHub user armsargis opened a pull request: https://github.com/apache/groovy/pull/538 GROOVY-8135: SecureASTCustomizer whitelist does not work For arrays we should get componentType instead of type You can merge this pull request into a Git repository by running: $ git pull ht

[GitHub] groovy pull request #537: GROOVY-8157: Flow typing doesn't work with assignm...

2017-05-06 Thread shils
GitHub user shils opened a pull request: https://github.com/apache/groovy/pull/537 GROOVY-8157: Flow typing doesn't work with assignment to a parameter You can merge this pull request into a Git repository by running: $ git pull https://github.com/shils/groovy GROOVY-8157 Alt

[GitHub] groovy pull request #536: Improve type inference/STC compatibility of Sql me...

2017-05-05 Thread shils
GitHub user shils opened a pull request: https://github.com/apache/groovy/pull/536 Improve type inference/STC compatibility of Sql methods with closure parameters This PR adds @ClosureParams to closure parameters of the following methods in Sql and DataSet: * asList * eachR

[GitHub] groovy pull request #485: Parrot for java7

2017-05-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/groovy/pull/485 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] groovy pull request #534: GROOVY-8174: Groovy.Sql+Oracle parameter substitut...

2017-05-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/groovy/pull/534 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] groovy pull request #535: GROOVY-8176: tap - exception in phase 'instruction...

2017-05-04 Thread paulk-asert
GitHub user paulk-asert opened a pull request: https://github.com/apache/groovy/pull/535 GROOVY-8176: tap - exception in phase 'instruction selection' You can merge this pull request into a Git repository by running: $ git pull https://github.com/paulk-asert/groovy groovy8176

[GitHub] groovy pull request #534: GROOVY-8174: Groovy.Sql+Oracle parameter substitut...

2017-05-03 Thread paulk-asert
GitHub user paulk-asert opened a pull request: https://github.com/apache/groovy/pull/534 GROOVY-8174: Groovy.Sql+Oracle parameter substitution problem You can merge this pull request into a Git repository by running: $ git pull https://github.com/paulk-asert/groovy groovy8174

[GitHub] groovy pull request #533: GROOVY-7840: Verifier#makeDescriptorWithoutReturnT...

2017-05-03 Thread paulk-asert
GitHub user paulk-asert opened a pull request: https://github.com/apache/groovy/pull/533 GROOVY-7840: Verifier#makeDescriptorWithoutReturnType uses ClassNode#… …toString with generics You can merge this pull request into a Git repository by running: $ git pull https://githu

[GitHub] groovy pull request #532: Prevent CachedField and CachedMethod from leaking ...

2017-05-01 Thread dpolivaev
GitHub user dpolivaev opened a pull request: https://github.com/apache/groovy/pull/532 Prevent CachedField and CachedMethod from leaking access permissions … …to scripts https://issues.apache.org/jira/browse/GROOVY-8163 You can merge this pull request into a Git reposit

[GitHub] groovy pull request #:

2017-05-01 Thread jwagenleitner
Github user jwagenleitner commented on the pull request: https://github.com/apache/groovy/commit/0fb89906aa587920d11fae063bba1d1f8fe26254#commitcomment-21969276 I created [GROOVY-8171](https://issues.apache.org/jira/browse/GROOVY-8171) because there is a slight difference in behavior

[GitHub] groovy pull request #:

2017-05-01 Thread danielsun1106
Github user danielsun1106 commented on the pull request: https://github.com/apache/groovy/commit/0fb89906aa587920d11fae063bba1d1f8fe26254#commitcomment-21966548 I run the test locally, parrot can handle it properly. --- If your project is set up for it, you can reply to this email an

[GitHub] groovy pull request #:

2017-05-01 Thread PascalSchumacher
Github user PascalSchumacher commented on the pull request: https://github.com/apache/groovy/commit/0fb89906aa587920d11fae063bba1d1f8fe26254#commitcomment-21966439 @danielsun1106 So is it a bug in the new groovy parser? --- If your project is set up for it, you can reply to this emai

[GitHub] groovy pull request #:

2017-04-30 Thread jwagenleitner
Github user jwagenleitner commented on the pull request: https://github.com/apache/groovy/commit/0fb89906aa587920d11fae063bba1d1f8fe26254#commitcomment-21963417 Thanks, I had forgot to test with antlr4 enabled. --- If your project is set up for it, you can reply to this email and hav

[GitHub] groovy pull request #531: fix spec test

2017-04-30 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/groovy/pull/531 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] groovy pull request #531: fix spec test

2017-04-30 Thread jwagenleitner
GitHub user jwagenleitner opened a pull request: https://github.com/apache/groovy/pull/531 fix spec test You can merge this pull request into a Git repository by running: $ git pull https://github.com/jwagenleitner/groovy dollarslashy Alternatively you can review and apply th

[GitHub] groovy pull request #:

2017-04-30 Thread PascalSchumacher
Github user PascalSchumacher commented on the pull request: https://github.com/apache/groovy/commit/0fb89906aa587920d11fae063bba1d1f8fe26254#commitcomment-21962912 test fails on travis, see: https://travis-ci.org/apache/groovy/builds/227402483?utm_source=github_status&utm_medium=notif

[GitHub] groovy pull request #530: Clarify documentation around indy

2017-04-30 Thread jwagenleitner
GitHub user jwagenleitner opened a pull request: https://github.com/apache/groovy/pull/530 Clarify documentation around indy From a recent [user mailing list question](http://mail-archives.apache.org/mod_mbox/groovy-users/201704.mbox/%3c44315a6eb40a3769a12a5bfe465da...@posteo.de%3E)

[GitHub] groovy pull request #527: remove skipping of tests for builds.apache.org as ...

2017-04-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/groovy/pull/527 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] groovy pull request #526: cleanup now that jdk7 is baseline

2017-04-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/groovy/pull/526 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] groovy pull request #529: GROOVY-8127: Access to Trait$Trait$Helper#$self is...

2017-04-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/groovy/pull/529 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] groovy pull request #528: GROOVY-7579: Improve docs for invokeMethod

2017-04-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/groovy/pull/528 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] groovy pull request #529: GROOVY-8127: Access to Trait$Trait$Helper#$self is...

2017-04-24 Thread paulk-asert
GitHub user paulk-asert opened a pull request: https://github.com/apache/groovy/pull/529 GROOVY-8127: Access to Trait$Trait$Helper#$self is forbidden You can merge this pull request into a Git repository by running: $ git pull https://github.com/paulk-asert/groovy groovy8127

[GitHub] groovy pull request #528: GROOVY-7579: Improve docs for invokeMethod

2017-04-23 Thread jwagenleitner
GitHub user jwagenleitner opened a pull request: https://github.com/apache/groovy/pull/528 GROOVY-7579: Improve docs for invokeMethod You can merge this pull request into a Git repository by running: $ git pull https://github.com/jwagenleitner/groovy groovy7579 Alternatively

[GitHub] groovy pull request #527: remove skipping of tests for builds.apache.org as ...

2017-04-23 Thread PascalSchumacher
GitHub user PascalSchumacher opened a pull request: https://github.com/apache/groovy/pull/527 remove skipping of tests for builds.apache.org as we no longer use it even groovy decides to use builds.apache.org again, these workarounds may not be necessary today You can merge this pu

[GitHub] groovy pull request #517: Differentiate between XML breadthFirst() traversal...

2017-04-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/groovy/pull/517 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] groovy pull request #525: Groovy 2 4 x

2017-04-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/groovy/pull/525 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] groovy pull request #512: bugfix for groovy-8117

2017-04-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/groovy/pull/512 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] groovy pull request #526: cleanup now that jdk7 is baseline

2017-04-21 Thread PascalSchumacher
GitHub user PascalSchumacher opened a pull request: https://github.com/apache/groovy/pull/526 cleanup now that jdk7 is baseline for master and the GROOVY_2_5_X branch You can merge this pull request into a Git repository by running: $ git pull https://github.com/PascalSchumache

[GitHub] groovy pull request #521: GROOVY-7879 Groovy calls wrong method if there is ...

2017-04-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/groovy/pull/521 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] groovy pull request #524: GROOVY-8156: Compile error when ListenerList annot...

2017-04-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/groovy/pull/524 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] groovy pull request #523: cleanup now that jdk7 is baseline

2017-04-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/groovy/pull/523 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] groovy pull request #525: Groovy 2 4 x

2017-04-18 Thread chetankm86
GitHub user chetankm86 opened a pull request: https://github.com/apache/groovy/pull/525 Groovy 2 4 x You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/groovy GROOVY_2_4_X Alternatively you can review and apply these changes

[GitHub] groovy pull request #524: GROOVY-8156: Compile error when ListenerList annot...

2017-04-17 Thread jwagenleitner
GitHub user jwagenleitner opened a pull request: https://github.com/apache/groovy/pull/524 GROOVY-8156: Compile error when ListenerList annotation exists You can merge this pull request into a Git repository by running: $ git pull https://github.com/jwagenleitner/groovy groovy

[GitHub] groovy pull request #518: GROOVY-8132: Owner properties should be preferred ...

2017-04-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/groovy/pull/518 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] groovy pull request #522: GROOVY-8144: Invoking a public method declared in ...

2017-04-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/groovy/pull/522 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] groovy pull request #523: cleanup now that jdk7 is baseline

2017-04-11 Thread blackdrag
Github user blackdrag commented on a diff in the pull request: https://github.com/apache/groovy/pull/523#discussion_r111070966 --- Diff: src/main/org/codehaus/groovy/vmplugin/VMPluginFactory.java --- @@ -26,39 +28,10 @@ */ public class VMPluginFactory { -pri

[GitHub] groovy pull request #515: Fix running out of memory ("GC overhead limit exce...

2017-04-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/groovy/pull/515 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] groovy pull request #523: cleanup now that jdk7 is baseline

2017-04-11 Thread jwagenleitner
GitHub user jwagenleitner opened a pull request: https://github.com/apache/groovy/pull/523 cleanup now that jdk7 is baseline Avoids reflective checks/constructions where it is no longer needed since 7 is now baseline in 2_5_X and master. You can merge this pull request into a Git r

[GitHub] groovy pull request #:

2017-04-10 Thread danielsun1106
Github user danielsun1106 commented on the pull request: https://github.com/apache/groovy/commit/ce12609009c6572247d8d194047aac6812753b92#commitcomment-21710945 In src/main/groovy/lang/Groovydoc.java: In src/main/groovy/lang/Groovydoc.java on line 1: OK. I will add it later :)

[GitHub] groovy pull request #522: GROOVY-8144: Invoking a public method declared in ...

2017-04-10 Thread jwagenleitner
GitHub user jwagenleitner opened a pull request: https://github.com/apache/groovy/pull/522 GROOVY-8144: Invoking a public method declared in a non-public class … …result in a IllegalAccessError Commit 1a4c9918a4f12e64 introduced the DecompiledClassNode as part of ena

[GitHub] groovy pull request #:

2017-04-10 Thread paulk-asert
Github user paulk-asert commented on the pull request: https://github.com/apache/groovy/commit/ce12609009c6572247d8d194047aac6812753b92#commitcomment-21709694 In src/main/groovy/lang/Groovydoc.java: In src/main/groovy/lang/Groovydoc.java on line 1: Needs the normal Apache heade

[GitHub] groovy pull request #521: GROOVY-7879 Groovy calls wrong method if there is ...

2017-04-06 Thread dkhamitov
GitHub user dkhamitov opened a pull request: https://github.com/apache/groovy/pull/521 GROOVY-7879 Groovy calls wrong method if there is a static method on … Hi guys, can we consider a small kind of tactical fix (imho) to GROOVY-7879 or is it a bad idea/solution? It fixes the situ

[GitHub] groovy pull request #520: GROOVY-8140: Invoke method not returning MOP super...

2017-04-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/groovy/pull/520 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] groovy pull request #520: GROOVY-8140: Invoke method not returning MOP super...

2017-04-02 Thread jwagenleitner
GitHub user jwagenleitner opened a pull request: https://github.com/apache/groovy/pull/520 GROOVY-8140: Invoke method not returning MOP super method if isCallTo… …Super See [dev mailing list discussion](http://mail-archives.apache.org/mod_mbox/groovy-dev/201703.mbox/%3C

<    5   6   7   8   9   10   11   12   13   14   >