[
https://issues.apache.org/jira/browse/GROOVY-7535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16025888#comment-16025888
]
Jochen Kemnade commented on GROOVY-7535:
Thanks guys, I learned some interesting things from
[
https://issues.apache.org/jira/browse/GROOVY-7535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16025584#comment-16025584
]
Paul King commented on GROOVY-7535:
---
Nice work everyone!
> Groovy category throwing
[
https://issues.apache.org/jira/browse/GROOVY-7535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16025564#comment-16025564
]
ASF GitHub Bot commented on GROOVY-7535:
Github user asfgit closed the pull request at:
[
https://issues.apache.org/jira/browse/GROOVY-7535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16020962#comment-16020962
]
Jochen Kemnade commented on GROOVY-7535:
Agreed. The current PR looks good to me again/still.
[
https://issues.apache.org/jira/browse/GROOVY-7535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16017957#comment-16017957
]
Jochen Theodorou commented on GROOVY-7535:
--
In that case my suggestion would be to do the
[
https://issues.apache.org/jira/browse/GROOVY-7535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16017549#comment-16017549
]
John Wagenleitner commented on GROOVY-7535:
---
The {{AtomicInteger#get}} shouldn't lock but would
[
https://issues.apache.org/jira/browse/GROOVY-7535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16017035#comment-16017035
]
Jochen Kemnade commented on GROOVY-7535:
Oh, that's GROOVY-7811
> Groovy category throwing
[
https://issues.apache.org/jira/browse/GROOVY-7535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16017012#comment-16017012
]
Jochen Kemnade commented on GROOVY-7535:
It doesn't make much of a difference. Pretty much all of
[
https://issues.apache.org/jira/browse/GROOVY-7535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16016984#comment-16016984
]
Jochen Kemnade commented on GROOVY-7535:
I actually liked the previous version better.
[
https://issues.apache.org/jira/browse/GROOVY-7535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16016499#comment-16016499
]
Jochen Theodorou commented on GROOVY-7535:
--
I think I am ok with the change in total now.
>
[
https://issues.apache.org/jira/browse/GROOVY-7535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16016486#comment-16016486
]
Jochen Theodorou commented on GROOVY-7535:
--
Let me modify your example from before:
1. T1 in
[
https://issues.apache.org/jira/browse/GROOVY-7535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16016441#comment-16016441
]
John Wagenleitner commented on GROOVY-7535:
---
That is true, I have not been able to find a
[
https://issues.apache.org/jira/browse/GROOVY-7535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16016429#comment-16016429
]
Jochen Theodorou commented on GROOVY-7535:
--
John, I thought this information is not used in the
[
https://issues.apache.org/jira/browse/GROOVY-7535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16016405#comment-16016405
]
John Wagenleitner commented on GROOVY-7535:
---
I updated the PR, my assumption still being that
[
https://issues.apache.org/jira/browse/GROOVY-7535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16016347#comment-16016347
]
Jochen Theodorou commented on GROOVY-7535:
--
ok, let me propose an alternative fix... remove
[
https://issues.apache.org/jira/browse/GROOVY-7535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16015265#comment-16015265
]
Jochen Kemnade commented on GROOVY-7535:
The updated PR looks good to me.
> Groovy category
[
https://issues.apache.org/jira/browse/GROOVY-7535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16012565#comment-16012565
]
Jochen Kemnade commented on GROOVY-7535:
bq. At worst stale non-zero values will cause it to
[
https://issues.apache.org/jira/browse/GROOVY-7535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16012559#comment-16012559
]
Jochen Kemnade commented on GROOVY-7535:
bq. If that were done then hasCategoryInAnyThread()
[
https://issues.apache.org/jira/browse/GROOVY-7535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16012546#comment-16012546
]
Jochen Kemnade commented on GROOVY-7535:
It's the other case that makes the difference and that
[
https://issues.apache.org/jira/browse/GROOVY-7535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16012499#comment-16012499
]
John Wagenleitner commented on GROOVY-7535:
---
I agree that synchronizing the read in
[
https://issues.apache.org/jira/browse/GROOVY-7535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16012479#comment-16012479
]
Jochen Theodorou commented on GROOVY-7535:
--
You said "The other thread may have incremented the
[
https://issues.apache.org/jira/browse/GROOVY-7535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16012018#comment-16012018
]
Jochen Kemnade commented on GROOVY-7535:
Why don't we just use a {{ThreadLocal}} for
[
https://issues.apache.org/jira/browse/GROOVY-7535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16011996#comment-16011996
]
Jochen Kemnade commented on GROOVY-7535:
With the PR, all writes are synchronized. Here's why I
[
https://issues.apache.org/jira/browse/GROOVY-7535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16011951#comment-16011951
]
Jochen Theodorou commented on GROOVY-7535:
--
[~jwagenleitner] and [~jkemnade] maybe I am now
[
https://issues.apache.org/jira/browse/GROOVY-7535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16011829#comment-16011829
]
Jochen Kemnade commented on GROOVY-7535:
Great explanation John. It took me a while to figure
[
https://issues.apache.org/jira/browse/GROOVY-7535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16011335#comment-16011335
]
John Wagenleitner commented on GROOVY-7535:
---
[~blackdrag] - as [~jkemnade] pointed out, there
[
https://issues.apache.org/jira/browse/GROOVY-7535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16011047#comment-16011047
]
Jochen Theodorou commented on GROOVY-7535:
--
I don´t get the patch... isn´t the sole purpose of
[
https://issues.apache.org/jira/browse/GROOVY-7535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16010661#comment-16010661
]
John Wagenleitner commented on GROOVY-7535:
---
The updated patch looks good, though it does seem
[
https://issues.apache.org/jira/browse/GROOVY-7535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16010043#comment-16010043
]
Jochen Kemnade commented on GROOVY-7535:
I think that this issue should be reopened as it seems
[
https://issues.apache.org/jira/browse/GROOVY-7535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16010041#comment-16010041
]
Jochen Kemnade commented on GROOVY-7535:
Oh, the race condition occurs between the modification
[
https://issues.apache.org/jira/browse/GROOVY-7535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16009598#comment-16009598
]
ASF GitHub Bot commented on GROOVY-7535:
GitHub user jwagenleitner opened a pull request:
[
https://issues.apache.org/jira/browse/GROOVY-7535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16008077#comment-16008077
]
Jochen Kemnade commented on GROOVY-7535:
A quick git bisect session also leads to that commit.
>
[
https://issues.apache.org/jira/browse/GROOVY-7535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16008042#comment-16008042
]
Jochen Kemnade commented on GROOVY-7535:
Alright, I can reproduce it with 1.8.0-beta-3 but not
[
https://issues.apache.org/jira/browse/GROOVY-7535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16008020#comment-16008020
]
Jochen Kemnade commented on GROOVY-7535:
I can reproduce the error with 1.8.0 but not with 1.7.x
[
https://issues.apache.org/jira/browse/GROOVY-7535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16007920#comment-16007920
]
Jochen Theodorou commented on GROOVY-7535:
--
Since the removal of setting it to false did not do
[
https://issues.apache.org/jira/browse/GROOVY-7535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16007836#comment-16007836
]
Jochen Kemnade commented on GROOVY-7535:
I don't think so. I'm not synchronizing the decrement
[
https://issues.apache.org/jira/browse/GROOVY-7535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16007826#comment-16007826
]
Jochen Theodorou commented on GROOVY-7535:
--
[~jkemnade] your change synchronizes the
[
https://issues.apache.org/jira/browse/GROOVY-7535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16007780#comment-16007780
]
Jochen Kemnade commented on GROOVY-7535:
Unfortunately, the patch doesn't fix it.
> Groovy
[
https://issues.apache.org/jira/browse/GROOVY-7535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16007737#comment-16007737
]
Jochen Kemnade commented on GROOVY-7535:
The first part of the PR should not have changed
[
https://issues.apache.org/jira/browse/GROOVY-7535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16006630#comment-16006630
]
Paul King commented on GROOVY-7535:
---
I haven't had time to explore this issue, but just a meta-comment.
[
https://issues.apache.org/jira/browse/GROOVY-7535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16006530#comment-16006530
]
Jochen Kemnade commented on GROOVY-7535:
I can also reproduce it with 2.5.0-alpha-1. Can we
[
https://issues.apache.org/jira/browse/GROOVY-7535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16006519#comment-16006519
]
Jochen Kemnade commented on GROOVY-7535:
I can actually reproduce this issue with Groovy 2.4.11
42 matches
Mail list logo