[GitHub] [groovy] danielsun1106 edited a comment on issue #998: GROOVY-9236: Avoid unnecessary resolving

2019-09-10 Thread GitBox
danielsun1106 edited a comment on issue #998: GROOVY-9236: Avoid unnecessary resolving URL: https://github.com/apache/groovy/pull/998#issuecomment-529890504 @paulk-asert In theory, it is not a breaking change and its build is green. But we can not test all frameworks based on Groovy,

[GitHub] [groovy] danielsun1106 edited a comment on issue #998: GROOVY-9236: Avoid unnecessary resolving

2019-09-02 Thread GitBox
danielsun1106 edited a comment on issue #998: GROOVY-9236: Avoid unnecessary resolving URL: https://github.com/apache/groovy/pull/998#issuecomment-527198828 @melix Hi Cédric, I am trying to reduce the cost of resolving[1], could you review the PR too? Thanks in advance :-) [1]

[GitHub] [groovy] danielsun1106 edited a comment on issue #998: GROOVY-9236: Avoid unnecessary resolving

2019-09-02 Thread GitBox
danielsun1106 edited a comment on issue #998: GROOVY-9236: Avoid unnecessary resolving URL: https://github.com/apache/groovy/pull/998#issuecomment-527198828 @melix Hi Cédric, I am trying to reduce the cost of resolving[1], could you review the PR too? Thanks in advance :-) Here

[GitHub] [groovy] danielsun1106 edited a comment on issue #998: GROOVY-9236: Avoid unnecessary resolving

2019-08-30 Thread GitBox
danielsun1106 edited a comment on issue #998: GROOVY-9236: Avoid unnecessary resolving URL: https://github.com/apache/groovy/pull/998#issuecomment-526739881 I tried to compile the following code to verify whether the times of guessing class names are reduced. Then I got the result:

[GitHub] [groovy] danielsun1106 edited a comment on issue #998: GROOVY-9236: Avoid unnecessary resolving

2019-08-30 Thread GitBox
danielsun1106 edited a comment on issue #998: GROOVY-9236: Avoid unnecessary resolving URL: https://github.com/apache/groovy/pull/998#issuecomment-526739881 I tried to compile the following code to verify whether the times of guessing class names are reduced. ```groovy

[GitHub] [groovy] danielsun1106 edited a comment on issue #998: GROOVY-9236: Avoid unnecessary resolving

2019-08-30 Thread GitBox
danielsun1106 edited a comment on issue #998: GROOVY-9236: Avoid unnecessary resolving URL: https://github.com/apache/groovy/pull/998#issuecomment-526538718 As `resolveFromStaticInnerClasses` only resolves classes whose name contains `.` and `resolveToOuter` only resolves classes whose

[GitHub] [groovy] danielsun1106 edited a comment on issue #998: GROOVY-9236: Avoid unnecessary resolving

2019-08-30 Thread GitBox
danielsun1106 edited a comment on issue #998: GROOVY-9236: Avoid unnecessary resolving URL: https://github.com/apache/groovy/pull/998#issuecomment-526538718 As `resolveFromStaticInnerClasses` only resolves classes whose name contains `.` and `resolveToOuter` only resolves classes whose

[GitHub] [groovy] danielsun1106 edited a comment on issue #998: GROOVY-9236: Avoid unnecessary resolving

2019-08-30 Thread GitBox
danielsun1106 edited a comment on issue #998: GROOVY-9236: Avoid unnecessary resolving URL: https://github.com/apache/groovy/pull/998#issuecomment-526538718 As `resolveFromStaticInnerClasses` only resolves classes whose name contains `.` and `resolveToOuter` only resolves classes whose

[GitHub] [groovy] danielsun1106 edited a comment on issue #998: GROOVY-9236: Avoid unnecessary resolving

2019-08-30 Thread GitBox
danielsun1106 edited a comment on issue #998: GROOVY-9236: Avoid unnecessary resolving URL: https://github.com/apache/groovy/pull/998#issuecomment-526538718 As `resolveToOuter` only resolves classes whose name does not contains `.` and `resolveFromStaticInnerClasses` only resolves classes

[GitHub] [groovy] danielsun1106 edited a comment on issue #998: GROOVY-9236: Avoid unnecessary resolving

2019-08-29 Thread GitBox
danielsun1106 edited a comment on issue #998: GROOVY-9236: Avoid unnecessary resolving URL: https://github.com/apache/groovy/pull/998#issuecomment-526408884 The following guessed class lists show the difference caused by the PR. As you can see, lots of classes will be avoided to guess

[GitHub] [groovy] danielsun1106 edited a comment on issue #998: GROOVY-9236: Avoid unnecessary resolving

2019-08-29 Thread GitBox
danielsun1106 edited a comment on issue #998: GROOVY-9236: Avoid unnecessary resolving URL: https://github.com/apache/groovy/pull/998#issuecomment-526408884 The following guessed class lists show the difference caused by the PR. * After changes: ```