Github user hlerebours commented on a diff in the pull request:
https://github.com/apache/groovy/pull/645#discussion_r158601211
--- Diff:
subprojects/groovy-groovysh/src/main/groovy/org/codehaus/groovy/tools/shell/completion/ImportsSyntaxCompletor.groovy
---
@@ -105,12 +105,12 @@
Github user paulk-asert commented on a diff in the pull request:
https://github.com/apache/groovy/pull/645#discussion_r158594944
--- Diff:
subprojects/groovy-groovysh/src/main/groovy/org/codehaus/groovy/tools/shell/completion/ImportsSyntaxCompletor.groovy
---
@@ -105,12 +105,12 @@
Github user paulk-asert commented on the pull request:
https://github.com/apache/groovy/commit/1972c21cb2ccade3109cf9befdbbc3ff9c7dad68#commitcomment-26458323
Does this look related? The latest CI build says:
[testStreamOf] (class: java_util_stream_Stream$of, method: call signature
Github user asfgit closed the pull request at:
https://github.com/apache/groovy/pull/646
---
GitHub user dovchinnikov opened a pull request:
https://github.com/apache/groovy/pull/647
GROOVY-8362: don't resolve class via class with package name
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dovchinnikov/groovy master
Al
GitHub user paulk-asert opened a pull request:
https://github.com/apache/groovy/pull/646
GROOVY-8386/GROOVY-8094: Final variable analysis broken with try/catcâ¦
â¦h/finally and if/then/else
You can merge this pull request into a Git repository by running:
$ git pull https://g
Github user paulk-asert commented on the pull request:
https://github.com/apache/groovy/commit/c89393104807cc49859f77ab86c62ab3c7e171e8#commitcomment-26389799
Adding classExcludes added the extra time? Perhaps it has a caching impact?
Or using the binaryCompatibilityCheck at all? Loca
Github user danielsun1106 commented on the pull request:
https://github.com/apache/groovy/commit/c89393104807cc49859f77ab86c62ab3c7e171e8#commitcomment-26387619
I reverted the commit on my fork, the build costs about 12 min
https://travis-ci.org/danielsun1106/groovy/builds/3190832
Github user melix commented on the pull request:
https://github.com/apache/groovy/commit/a6c82ad08b85ae8746b982a1a19107e93bfdb568#commitcomment-26384969
:+1: I apparently missed that!
---
Github user paulk-asert commented on the pull request:
https://github.com/apache/groovy/commit/047c8f29b1f7a1a98b2b003e4d09c1cef05feb0e#commitcomment-26370771
Let's watch it a few more times ...
---
Github user danielsun1106 commented on the pull request:
https://github.com/apache/groovy/commit/047c8f29b1f7a1a98b2b003e4d09c1cef05feb0e#commitcomment-26361555
Weird... The build costs much more time after this commit...
[26 min 14 sec] https://travis-ci.org/apache/groovy/builds/
Github user asfgit closed the pull request at:
https://github.com/apache/groovy/pull/644
---
GitHub user hlerebours opened a pull request:
https://github.com/apache/groovy/pull/645
DefaultGroovyMethods bug fix: Set.intersect(Iterable) throwing if the
iterable is bigger than the set
You can merge this pull request into a Git repository by running:
$ git pull https://g
Github user avafanasiev commented on a diff in the pull request:
https://github.com/apache/groovy/pull/643#discussion_r157445258
--- Diff: src/test/groovy/transform/stc/MethodCallsSTCTest.groovy ---
@@ -383,6 +406,94 @@ class MethodCallsSTCTest extends
StaticTypeCheckingTestCase {
Github user daniel-huss commented on a diff in the pull request:
https://github.com/apache/groovy/pull/643#discussion_r157355618
--- Diff: src/test/groovy/transform/stc/MethodCallsSTCTest.groovy ---
@@ -383,6 +406,94 @@ class MethodCallsSTCTest extends
StaticTypeCheckingTestCase {
Github user asfgit closed the pull request at:
https://github.com/apache/groovy/pull/643
---
Github user asfgit closed the pull request at:
https://github.com/apache/groovy/pull/641
---
Github user danielsun1106 commented on the pull request:
https://github.com/apache/groovy/commit/29727ea0c0318304ded181aebfa8cce661d34c56#commitcomment-26201603
In src/main/org/codehaus/groovy/runtime/memoize/CommonCache.java:
In src/main/org/codehaus/groovy/runtime/memoize/CommonC
Github user paulk-asert commented on a diff in the pull request:
https://github.com/apache/groovy/pull/644#discussion_r156233058
--- Diff: src/main/org/codehaus/groovy/runtime/DefaultGroovyMethods.java ---
@@ -3371,77 +3396,179 @@ public static Number count(byte[] self, Object
valu
Github user shils commented on a diff in the pull request:
https://github.com/apache/groovy/pull/644#discussion_r156211571
--- Diff: src/main/org/codehaus/groovy/runtime/DefaultGroovyMethods.java ---
@@ -3371,77 +3396,179 @@ public static Number count(byte[] self, Object
value) {
Github user blackdrag commented on the pull request:
https://github.com/apache/groovy/commit/29727ea0c0318304ded181aebfa8cce661d34c56#commitcomment-26193580
In src/main/org/codehaus/groovy/runtime/memoize/CommonCache.java:
In src/main/org/codehaus/groovy/runtime/memoize/CommonCache
GitHub user paulk-asert opened a pull request:
https://github.com/apache/groovy/pull/644
GROOVY-8406: Various DefaultGroovyMethods missing Array variants resuâ¦
â¦lting in no type inference
You can merge this pull request into a Git repository by running:
$ git pull https://g
GitHub user avafanasiev opened a pull request:
https://github.com/apache/groovy/pull/643
GROOVY-8241 SAM parameter type inference for explicit parameter
It should fix GROOVY-8241, GROOVY-7061, GROOVY-8317.
You can merge this pull request into a Git repository by running:
$ git
Github user danielsun1106 commented on the pull request:
https://github.com/apache/groovy/commit/e1ce4824186f62f5fb05a407da79b8da61bc87a4#commitcomment-26090087
In src/main/org/codehaus/groovy/runtime/DefaultGroovyMethods.java:
In src/main/org/codehaus/groovy/runtime/DefaultGroovyM
Github user paulk-asert commented on the pull request:
https://github.com/apache/groovy/commit/f5d0236f93302cf8d1f49f35f1ddf1d0dd1c12e4#commitcomment-26080209
In build.gradle:
In build.gradle on line 188:
Just a reminder, it is generally undesirable to release artifacts into
m
Github user paulk-asert commented on the pull request:
https://github.com/apache/groovy/commit/e1ce4824186f62f5fb05a407da79b8da61bc87a4#commitcomment-26078737
In src/main/org/codehaus/groovy/runtime/DefaultGroovyMethods.java:
In src/main/org/codehaus/groovy/runtime/DefaultGroovyMet
GitHub user alexstajos opened a pull request:
https://github.com/apache/groovy/pull/642
Fix documentation to say that private fields are turned into properties
I'm new to Groovy, and this section of the documentation was confusing to
me and seemed to contradict what is in the
[Prop
Github user danielsun1106 commented on the pull request:
https://github.com/apache/groovy/commit/e1ce4824186f62f5fb05a407da79b8da61bc87a4#commitcomment-26053152
In src/main/org/codehaus/groovy/runtime/DefaultGroovyMethods.java:
In src/main/org/codehaus/groovy/runtime/DefaultGroovyM
Github user asfgit closed the pull request at:
https://github.com/apache/groovy/pull/636
---
GitHub user shils opened a pull request:
https://github.com/apache/groovy/pull/641
GROOVY-8402: GroovyScriptEngine.ScriptClassLoader applies compilationâ¦
⦠customizers twice
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shil
Github user paulk-asert commented on the pull request:
https://github.com/apache/groovy/commit/7ea3047fdb65c9c15e80eecd6ba221c5fabbc578#commitcomment-25813402
In src/main/groovy/util/ProxyGenerator.java:
In src/main/groovy/util/ProxyGenerator.java on line 212:
Thanks Patric, th
Github user patric42 commented on the pull request:
https://github.com/apache/groovy/commit/7ea3047fdb65c9c15e80eecd6ba221c5fabbc578#commitcomment-25808709
In src/main/groovy/util/ProxyGenerator.java:
In src/main/groovy/util/ProxyGenerator.java on line 212:
Hi Paul,
I
Github user danielsun1106 commented on the pull request:
https://github.com/apache/groovy/commit/7ea3047fdb65c9c15e80eecd6ba221c5fabbc578#commitcomment-25807434
In src/main/groovy/util/ProxyGenerator.java:
In src/main/groovy/util/ProxyGenerator.java on line 212:
OK. I'll revert
Github user paulk-asert commented on the pull request:
https://github.com/apache/groovy/commit/7ea3047fdb65c9c15e80eecd6ba221c5fabbc578#commitcomment-25806906
In src/main/groovy/util/ProxyGenerator.java:
In src/main/groovy/util/ProxyGenerator.java on line 212:
Won't this be les
Github user asfgit closed the pull request at:
https://github.com/apache/groovy/pull/640
---
Github user asfgit closed the pull request at:
https://github.com/apache/groovy/pull/639
---
Github user asfgit closed the pull request at:
https://github.com/apache/groovy/pull/638
---
GitHub user paulk-asert opened a pull request:
https://github.com/apache/groovy/pull/640
GROOVY-8383: OptimizerVisitor#setConstField not @CS friendly
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/paulk-asert/groovy groovy8383
GitHub user paulk-asert opened a pull request:
https://github.com/apache/groovy/pull/639
GROOVY-8384 - Regression in 2.4.13 snapshot with STC and intdiv plus â¦
â¦some cleanup
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/paul
GitHub user russellsanborn opened a pull request:
https://github.com/apache/groovy/pull/638
Remove deprecated StringGroovyMethods.capitalize call
I also noticed that propName was being capitalized three times in the
createComparatorFor() method, so I only call it once at the beginni
Github user blackdrag commented on the pull request:
https://github.com/apache/groovy/commit/b58342060031f517d6ba42a64dd3ddf392e820bb#commitcomment-25679530
In src/main/groovy/lang/Binding.java:
In src/main/groovy/lang/Binding.java on line 99:
I think it is correct. An alterna
Github user dsatish commented on the pull request:
https://github.com/apache/groovy/commit/b58342060031f517d6ba42a64dd3ddf392e820bb#commitcomment-25677068
In src/main/groovy/lang/Binding.java:
In src/main/groovy/lang/Binding.java on line 99:
Hi @jstrachan - is the below impleme
Github user asfgit closed the pull request at:
https://github.com/apache/groovy/pull/633
---
Github user asfgit closed the pull request at:
https://github.com/apache/groovy/pull/627
---
Github user asfgit closed the pull request at:
https://github.com/apache/groovy/pull/637
---
GitHub user paulk-asert opened a pull request:
https://github.com/apache/groovy/pull/637
GROOVY-8382: Target Typing for empty collections should work for fielâ¦
â¦d/property initialisers
You can merge this pull request into a Git repository by running:
$ git pull https://gith
Github user asfgit closed the pull request at:
https://github.com/apache/groovy/pull/635
---
Github user melix commented on a diff in the pull request:
https://github.com/apache/groovy/pull/635#discussion_r150800145
--- Diff:
src/main/org/codehaus/groovy/transform/stc/StaticTypeCheckingVisitor.java ---
@@ -3461,6 +3465,36 @@ public void visitTernaryExpression(final
Ternar
GitHub user russellsanborn opened a pull request:
https://github.com/apache/groovy/pull/636
Update DefaultGroovyMethods boolean operations
* updated DefaultGroovyMethods.java boolean operations to allow for the
left parameter to be null instead of throwing a NullPointerExceptio
Github user asfgit closed the pull request at:
https://github.com/apache/groovy/pull/628
---
GitHub user paulk-asert opened a pull request:
https://github.com/apache/groovy/pull/635
GROOVY-8255: Odd problems with flow typing and generics in Groovy 2.4â¦
â¦.12+ (target typing for empty literals within Ternary/Elvis)
You can merge this pull request into a Git repository by
Github user asfgit closed the pull request at:
https://github.com/apache/groovy/pull/632
---
Github user asfgit closed the pull request at:
https://github.com/apache/groovy/pull/629
---
Github user asfgit closed the pull request at:
https://github.com/apache/groovy/pull/630
---
Github user asfgit closed the pull request at:
https://github.com/apache/groovy/pull/634
---
GitHub user paulk-asert opened a pull request:
https://github.com/apache/groovy/pull/634
GROOVY-7315: CompileStatic/TypeChecked cannot create non-static nesteâ¦
â¦d inner class using named-arg short-hand syntax
You can merge this pull request into a Git repository by running:
GitHub user erdi opened a pull request:
https://github.com/apache/groovy/pull/633
GROOVY-8377 Equals and hash code ast performance
See [GROOVY-8377](https://issues.apache.org/jira/browse/GROOVY-8377) for
the rationale behind this PR.
Given how simple the fix is and its impa
GitHub user paulk-asert opened a pull request:
https://github.com/apache/groovy/pull/632
GROOVY-8376: Add @DelegatesTo to SwingBuilder methods that call setDeâ¦
â¦legate
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/paulk-aser
Github user AndrewReitz commented on a diff in the pull request:
https://github.com/apache/groovy/pull/631#discussion_r149974307
--- Diff: gradle/assemble.gradle ---
@@ -247,6 +247,7 @@ allprojects {
if (isRootProject) {
Github user blackdrag commented on a diff in the pull request:
https://github.com/apache/groovy/pull/631#discussion_r149848170
--- Diff: gradle/assemble.gradle ---
@@ -247,6 +247,7 @@ allprojects {
if (isRootProject) {
zi
GitHub user AndrewReitz opened a pull request:
https://github.com/apache/groovy/pull/631
Android: Remove Invoke Dynamic Call
Uses jarjar to remove org.codehaus.groovy.vmplugin.v7.IndyInterface
which has a invoke dynamic call. This call causes android compilation
to fail when
GitHub user paulk-asert opened a pull request:
https://github.com/apache/groovy/pull/630
GROOVY-8289: STC and default value in ctor is causing debugging error
PR based on Eric's suggested fix in the issue. Still needs a test.
You can merge this pull request into a Git repository by
GitHub user paulk-asert opened a pull request:
https://github.com/apache/groovy/pull/629
GROOVY-8295: Groovyc ant task can overflow Windows command line if clâ¦
â¦asspath is large. PR based on Eric's patch in the related issue.
You can merge this pull request into a Git repository
GitHub user russellsanborn reopened a pull request:
https://github.com/apache/groovy/pull/628
adding note about the ./gradlew command on unix like systems to README
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/russellsanborn/g
Github user russellsanborn closed the pull request at:
https://github.com/apache/groovy/pull/628
---
Github user russellsanborn closed the pull request at:
https://github.com/apache/groovy/pull/627
---
GitHub user russellsanborn reopened a pull request:
https://github.com/apache/groovy/pull/627
Made the DefaultGroovyMethodsTest file more groovy like.
* Removed unnecessary semicolons and `public` modifiers.
* replaced java style for loops with groovy `eachWithIndex` closures
Github user asfgit closed the pull request at:
https://github.com/apache/groovy/pull/619
---
GitHub user russellsanborn opened a pull request:
https://github.com/apache/groovy/pull/628
adding note about the ./gradlew command on unix like systems to README
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/russellsanborn/gro
GitHub user russellsanborn opened a pull request:
https://github.com/apache/groovy/pull/627
Made the DefaultGroovyMethodsTest file more groovy like.
* Removed unnecessary semicolons and `public` modifiers.
* replaced java style for loops with groovy `eachWithIndex` closures
*
GitHub user erwa opened a pull request:
https://github.com/apache/groovy/pull/626
GROOVY-8372: GrapeIvy downloads wrong artifact for non-default conf when
artifact name is not the same as the module
Ref: https://issues.apache.org/jira/browse/GROOVY-8372
You can merge this pull requ
Github user asfgit closed the pull request at:
https://github.com/apache/groovy/pull/624
---
Github user asfgit closed the pull request at:
https://github.com/apache/groovy/pull/623
---
Github user asfgit closed the pull request at:
https://github.com/apache/groovy/pull/622
---
Github user paulk-asert commented on a diff in the pull request:
https://github.com/apache/groovy/pull/625#discussion_r148197190
--- Diff:
src/test/org/codehaus/groovy/classgen/asm/sc/FieldsAndPropertiesStaticCompileTest.groovy
---
@@ -696,4 +696,21 @@ import
org.codehaus.groovy.
Github user paulk-asert commented on a diff in the pull request:
https://github.com/apache/groovy/pull/625#discussion_r148195160
--- Diff:
src/test/org/codehaus/groovy/classgen/asm/sc/FieldsAndPropertiesStaticCompileTest.groovy
---
@@ -696,4 +696,21 @@ import
org.codehaus.groovy.
Github user paulk-asert commented on a diff in the pull request:
https://github.com/apache/groovy/pull/625#discussion_r148194617
--- Diff:
src/test/org/codehaus/groovy/classgen/asm/sc/FieldsAndPropertiesStaticCompileTest.groovy
---
@@ -696,4 +696,21 @@ import
org.codehaus.groovy.
Github user asfgit closed the pull request at:
https://github.com/apache/groovy/pull/625
---
GitHub user shils opened a pull request:
https://github.com/apache/groovy/pull/625
GROOVY-8369: Statically compiled property access on enum class throwsâ¦
⦠NoSuchFieldError
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shils
Github user paulk-asert commented on a diff in the pull request:
https://github.com/apache/groovy/pull/619#discussion_r147980977
--- Diff: src/test/gls/enums/EnumTest.groovy ---
@@ -592,6 +592,80 @@ class EnumTest extends CompilableTestSupport {
assert UsState.ID.to
Github user asfgit closed the pull request at:
https://github.com/apache/groovy/pull/621
---
GitHub user paulk-asert opened a pull request:
https://github.com/apache/groovy/pull/624
GROOVY-8367: @Memoized not working for inner classes
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/paulk-asert/groovy groovy8367
Alternat
GitHub user paulk-asert opened a pull request:
https://github.com/apache/groovy/pull/623
GROOVY-8357: EncodingGroovyMethods.decodeBase64() throws "bad charactâ¦
â¦er in base64 value" when meets \t \r
You can merge this pull request into a Git repository by running:
$ git pull
GitHub user paulk-asert opened a pull request:
https://github.com/apache/groovy/pull/622
GROOVY-8112: NPE in Groovy compiler when referencing @Field in aic
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/paulk-asert/groovy groovy
GitHub user russellsanborn opened a pull request:
https://github.com/apache/groovy/pull/621
Replaced deprecated padLeft call in BaseDuration
`StringGroovyMethods.padLeft(String, Number, String)` is deprecated. I
converted this to use the recommended
`StringGroovyMethods.padLeft(Cha
Github user asfgit closed the pull request at:
https://github.com/apache/groovy/pull/618
---
Github user asfgit closed the pull request at:
https://github.com/apache/groovy/pull/620
---
GitHub user russellsanborn opened a pull request:
https://github.com/apache/groovy/pull/620
Adding spacing around equals operator for consistency
I noticed this while looking at the documentation for operators:
http://groovy-lang.org/operators.html
You can merge this pull reques
Github user paulk-asert commented on the pull request:
https://github.com/apache/groovy/commit/4f2f7817dc6369abe464d5ad5239054656a5b21f#commitcomment-25192975
Yes, I put a comment to that effect in the file yesterday. I changed it to
false to get the faster build times on 2_6_X and ma
Github user danielsun1106 commented on the pull request:
https://github.com/apache/groovy/commit/4f2f7817dc6369abe464d5ad5239054656a5b21f#commitcomment-25182623
sudo reqired will let travis ci instance get more system resource(e.g.
memory), I do not know why sudo was modified to fals
Github user shils commented on a diff in the pull request:
https://github.com/apache/groovy/pull/619#discussion_r146433436
--- Diff: src/test/gls/enums/EnumTest.groovy ---
@@ -592,6 +592,80 @@ class EnumTest extends CompilableTestSupport {
assert UsState.ID.toString
GitHub user shils opened a pull request:
https://github.com/apache/groovy/pull/619
GROOVY-8360: Enums that are inner classes should have the static clasâ¦
â¦s modifier
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shils/groovy
Github user blackdrag commented on the pull request:
https://github.com/apache/groovy/commit/068ce3d445d0b5ce5c77517acb86e4cc11648b3b#commitcomment-25079300
In src/main/org/codehaus/groovy/classgen/AsmClassGenerator.java:
In src/main/org/codehaus/groovy/classgen/AsmClassGenerator.j
Github user turbanoff commented on the pull request:
https://github.com/apache/groovy/commit/068ce3d445d0b5ce5c77517acb86e4cc11648b3b#commitcomment-25074716
In src/main/org/codehaus/groovy/classgen/AsmClassGenerator.java:
In src/main/org/codehaus/groovy/classgen/AsmClassGenerator.j
Github user asfgit closed the pull request at:
https://github.com/apache/groovy/pull/616
---
Github user asfgit closed the pull request at:
https://github.com/apache/groovy/pull/617
---
Github user asfgit closed the pull request at:
https://github.com/apache/groovy/pull/604
---
GitHub user Nektro opened a pull request:
https://github.com/apache/groovy/pull/618
Condense org.codehaus.groovy.runtime.ArrayUtil
use varargs instead of manual 250-length Array construction
You can merge this pull request into a Git repository by running:
$ git pull https://gi
Github user aalmiray commented on a diff in the pull request:
https://github.com/apache/groovy/pull/617#discussion_r144314040
--- Diff: src/main/org/codehaus/groovy/classgen/Verifier.java ---
@@ -384,6 +387,7 @@ public void visit(MethodVisitor mv) {
protected void addGroovy
Github user paulk-asert commented on a diff in the pull request:
https://github.com/apache/groovy/pull/617#discussion_r144309069
--- Diff: src/main/org/codehaus/groovy/classgen/Verifier.java ---
@@ -384,6 +387,7 @@ public void visit(MethodVisitor mv) {
protected void addGro
601 - 700 of 2069 matches
Mail list logo
