[GitHub] [ignite-3] tkalkirill merged pull request #1547: IGNITE-18028 Implementation of a full rebalance for VolatilePageMemoryMvPartitionStorage on receiver

2023-01-19 Thread GitBox
tkalkirill merged PR #1547: URL: https://github.com/apache/ignite-3/pull/1547 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

[GitHub] [ignite-3] sanpwc commented on a diff in pull request #1503: IGNITE-18324 Calling tx.rollback() or tx.commit() is not failed for committed transaction.

2023-01-19 Thread GitBox
sanpwc commented on code in PR #1503: URL: https://github.com/apache/ignite-3/pull/1503#discussion_r1082171669 ## modules/transactions/src/main/java/org/apache/ignite/internal/tx/impl/ReadWriteTransactionImpl.java: ## @@ -88,8 +93,12 @@ public IgniteBiTuple enlist(ReplicationGr

[GitHub] [ignite-3] korlov42 merged pull request #1521: IGNITE-18254: Sql. Extend SQL grammar with ALTER ZONE statement

2023-01-19 Thread GitBox
korlov42 merged PR #1521: URL: https://github.com/apache/ignite-3/pull/1521 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ig

[GitHub] [ignite-3] apachont opened a new pull request, #1552: Build Improvements

2023-01-19 Thread GitBox
apachont opened a new pull request, #1552: URL: https://github.com/apache/ignite-3/pull/1552 ### Changes - Use relative path normalization in order to improve cache relocate-ability of Checkstyle, sql-parser and OpenApi cache keys - Disable timestamp autogeneration on Swagger causing c

[GitHub] [ignite-3] denis-chudov opened a new pull request, #1551: IGNITE-18527

2023-01-19 Thread GitBox
denis-chudov opened a new pull request, #1551: URL: https://github.com/apache/ignite-3/pull/1551 https://issues.apache.org/jira/browse/IGNITE-18527 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [ignite-3] sanpwc merged pull request #1538: IGNITE-18525 Introduce new PlacementDriver Ignite component

2023-01-19 Thread GitBox
sanpwc merged PR #1538: URL: https://github.com/apache/ignite-3/pull/1538 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@igni

[GitHub] [ignite] ivandasch opened a new pull request, #10490: IGNITE-18584 Enlarge compression buffer in order to provide sufficient space for compressors.

2023-01-19 Thread GitBox
ivandasch opened a new pull request, #10490: URL: https://github.com/apache/ignite/pull/10490 Thank you for submitting the pull request to the Apache Ignite. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### T

[GitHub] [ignite-3] ygerzhedovich commented on a diff in pull request #1528: IGNITE-18422: Sql. Match number of dynamic parameters with given parameters

2023-01-19 Thread GitBox
ygerzhedovich commented on code in PR #1528: URL: https://github.com/apache/ignite-3/pull/1528#discussion_r1081461103 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/prepare/IgniteSqlValidator.java: ## @@ -459,15 +459,23 @@ private boolean isSystemField

[GitHub] [ignite-3] lowka commented on a diff in pull request #1521: IGNITE-18254: Sql. Extend SQL grammar with ALTER ZONE statement

2023-01-19 Thread GitBox
lowka commented on code in PR #1521: URL: https://github.com/apache/ignite-3/pull/1521#discussion_r1081445505 ## modules/sql-engine/src/main/codegen/config.fmpp: ## @@ -594,7 +598,8 @@ data: { # Return type of method implementation should be 'SqlNode'. # Example: "SqlS

[GitHub] [ignite-3] lowka commented on a diff in pull request #1521: IGNITE-18254: Sql. Extend SQL grammar with ALTER ZONE statement

2023-01-19 Thread GitBox
lowka commented on code in PR #1521: URL: https://github.com/apache/ignite-3/pull/1521#discussion_r1081445505 ## modules/sql-engine/src/main/codegen/config.fmpp: ## @@ -594,7 +598,8 @@ data: { # Return type of method implementation should be 'SqlNode'. # Example: "SqlS

[GitHub] [ignite-3] lowka commented on a diff in pull request #1521: IGNITE-18254: Sql. Extend SQL grammar with ALTER ZONE statement

2023-01-19 Thread GitBox
lowka commented on code in PR #1521: URL: https://github.com/apache/ignite-3/pull/1521#discussion_r1081440348 ## modules/sql-engine/src/main/codegen/includes/parserImpls.ftl: ## @@ -532,3 +532,96 @@ SqlDrop SqlDropZone(Span s, boolean replace) : return new IgniteSqlDrop

[GitHub] [ignite-3] lowka commented on a diff in pull request #1521: IGNITE-18254: Sql. Extend SQL grammar with ALTER ZONE statement

2023-01-19 Thread GitBox
lowka commented on code in PR #1521: URL: https://github.com/apache/ignite-3/pull/1521#discussion_r1081438594 ## modules/sql-engine/src/main/codegen/config.fmpp: ## @@ -29,6 +29,7 @@ data: { imports: [ "org.apache.calcite.sql.SqlCreate", "org.apache.calcite.sq

[GitHub] [ignite-3] tkalkirill merged pull request #1530: IGNITE-18027 Implementation of a full rebalance for RocksDbMvPartitionStorage on receiver

2023-01-19 Thread GitBox
tkalkirill merged PR #1530: URL: https://github.com/apache/ignite-3/pull/1530 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

[GitHub] [ignite] Vladsz83 commented on a diff in pull request #10485: IGNITE-18232 : [IEP-80] Remove of CacheMetricsMXBean legacy JMX bean, v3 : keep JCache beans

2023-01-19 Thread GitBox
Vladsz83 commented on code in PR #10485: URL: https://github.com/apache/ignite/pull/10485#discussion_r1081238283 ## modules/core/src/main/java/org/apache/ignite/internal/processors/cache/CacheClusterMetricsMXBeanImpl.java: ## @@ -17,515 +17,121 @@ package org.apache.ignite.in

[GitHub] [ignite] nizhikov commented on a diff in pull request #10485: IGNITE-18232 : [IEP-80] Remove of CacheMetricsMXBean legacy JMX bean, v3 : keep JCache beans

2023-01-19 Thread GitBox
nizhikov commented on code in PR #10485: URL: https://github.com/apache/ignite/pull/10485#discussion_r1081234368 ## modules/core/src/main/java/org/apache/ignite/internal/processors/cache/CacheClusterMetricsMXBeanImpl.java: ## @@ -17,515 +17,121 @@ package org.apache.ignite.in

[GitHub] [ignite] Vladsz83 commented on pull request #10485: IGNITE-18232 : [IEP-80] Remove of CacheMetricsMXBean legacy JMX bean, v3 : keep JCache beans

2023-01-19 Thread GitBox
Vladsz83 commented on PR #10485: URL: https://github.com/apache/ignite/pull/10485#issuecomment-1396907110 > We don't need to copy code from existing to those new classes. Please, revert removal of existing JMX class and keep required methods in it. Done. I keep CacheClusterMetricsMXBe

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #1530: IGNITE-18027 Implementation of a full rebalance for RocksDbMvPartitionStorage on receiver

2023-01-19 Thread GitBox
tkalkirill commented on code in PR #1530: URL: https://github.com/apache/ignite-3/pull/1530#discussion_r1081197351 ## modules/storage-rocksdb/src/main/java/org/apache/ignite/internal/storage/rocksdb/RocksDbTableStorage.java: ## @@ -635,19 +644,117 @@ private static ColumnFamilyD

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #1530: IGNITE-18027 Implementation of a full rebalance for RocksDbMvPartitionStorage on receiver

2023-01-19 Thread GitBox
tkalkirill commented on code in PR #1530: URL: https://github.com/apache/ignite-3/pull/1530#discussion_r1081197136 ## modules/storage-rocksdb/src/main/java/org/apache/ignite/internal/storage/rocksdb/RocksDbTableStorage.java: ## @@ -635,19 +644,117 @@ private static ColumnFamilyD

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #1530: IGNITE-18027 Implementation of a full rebalance for RocksDbMvPartitionStorage on receiver

2023-01-19 Thread GitBox
tkalkirill commented on code in PR #1530: URL: https://github.com/apache/ignite-3/pull/1530#discussion_r1081185912 ## modules/storage-rocksdb/src/main/java/org/apache/ignite/internal/storage/rocksdb/RocksDbMvPartitionStorage.java: ## @@ -1405,4 +1454,84 @@ private V busy(Suppli

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #1530: IGNITE-18027 Implementation of a full rebalance for RocksDbMvPartitionStorage on receiver

2023-01-19 Thread GitBox
tkalkirill commented on code in PR #1530: URL: https://github.com/apache/ignite-3/pull/1530#discussion_r1081185536 ## modules/storage-rocksdb/src/main/java/org/apache/ignite/internal/storage/rocksdb/RocksDbMvPartitionStorage.java: ## @@ -1405,4 +1454,84 @@ private V busy(Suppli

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #1530: IGNITE-18027 Implementation of a full rebalance for RocksDbMvPartitionStorage on receiver

2023-01-19 Thread GitBox
tkalkirill commented on code in PR #1530: URL: https://github.com/apache/ignite-3/pull/1530#discussion_r1081184519 ## modules/storage-rocksdb/src/main/java/org/apache/ignite/internal/storage/rocksdb/RocksDbMvPartitionStorage.java: ## @@ -330,6 +333,14 @@ public void lastApplied(

[GitHub] [ignite-3] PakhomovAlexander commented on a diff in pull request #1549: IGNITE-18586 Add descriptions for REST components

2023-01-19 Thread GitBox
PakhomovAlexander commented on code in PR #1549: URL: https://github.com/apache/ignite-3/pull/1549#discussion_r1081168521 ## modules/rest-api/src/main/java/org/apache/ignite/internal/rest/api/InvalidParam.java: ## @@ -20,13 +20,17 @@ import com.fasterxml.jackson.annotation.Json

[GitHub] [ignite] Vladsz83 closed pull request #10435: IGNITE-16292 : unstable alter table server and client

2023-01-19 Thread GitBox
Vladsz83 closed pull request #10435: IGNITE-16292 : unstable alter table server and client URL: https://github.com/apache/ignite/pull/10435 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [ignite-3] sashapolo commented on a diff in pull request #1530: IGNITE-18027 Implementation of a full rebalance for RocksDbMvPartitionStorage on receiver

2023-01-19 Thread GitBox
sashapolo commented on code in PR #1530: URL: https://github.com/apache/ignite-3/pull/1530#discussion_r1081160394 ## modules/storage-rocksdb/src/main/java/org/apache/ignite/internal/storage/rocksdb/RocksDbTableStorage.java: ## @@ -635,19 +644,117 @@ private static ColumnFamilyDe

[GitHub] [ignite-3] sashapolo commented on a diff in pull request #1530: IGNITE-18027 Implementation of a full rebalance for RocksDbMvPartitionStorage on receiver

2023-01-19 Thread GitBox
sashapolo commented on code in PR #1530: URL: https://github.com/apache/ignite-3/pull/1530#discussion_r1081159865 ## modules/storage-rocksdb/src/main/java/org/apache/ignite/internal/storage/rocksdb/index/RocksDbHashIndexStorage.java: ## @@ -262,4 +290,58 @@ private V busy(Suppl

[GitHub] [ignite-3] sashapolo commented on a diff in pull request #1530: IGNITE-18027 Implementation of a full rebalance for RocksDbMvPartitionStorage on receiver

2023-01-19 Thread GitBox
sashapolo commented on code in PR #1530: URL: https://github.com/apache/ignite-3/pull/1530#discussion_r1081159533 ## modules/storage-rocksdb/src/main/java/org/apache/ignite/internal/storage/rocksdb/RocksDbMvPartitionStorage.java: ## @@ -1405,4 +1454,84 @@ private V busy(Supplie

[GitHub] [ignite-3] sashapolo commented on a diff in pull request #1530: IGNITE-18027 Implementation of a full rebalance for RocksDbMvPartitionStorage on receiver

2023-01-19 Thread GitBox
sashapolo commented on code in PR #1530: URL: https://github.com/apache/ignite-3/pull/1530#discussion_r1081158798 ## modules/storage-rocksdb/src/main/java/org/apache/ignite/internal/storage/rocksdb/RocksDbMvPartitionStorage.java: ## @@ -967,15 +1005,18 @@ public void destroyData

[GitHub] [ignite-3] sashapolo commented on a diff in pull request #1530: IGNITE-18027 Implementation of a full rebalance for RocksDbMvPartitionStorage on receiver

2023-01-19 Thread GitBox
sashapolo commented on code in PR #1530: URL: https://github.com/apache/ignite-3/pull/1530#discussion_r1081158465 ## modules/storage-rocksdb/src/main/java/org/apache/ignite/internal/storage/rocksdb/RocksDbMvPartitionStorage.java: ## @@ -330,6 +333,14 @@ public void lastApplied(l

[GitHub] [ignite-3] ygerzhedovich commented on a diff in pull request #1537: IGNITE-18227 Refactor scan nodes and add support RO index scans

2023-01-19 Thread GitBox
ygerzhedovich commented on code in PR #1537: URL: https://github.com/apache/ignite-3/pull/1537#discussion_r1081138614 ## modules/runner/src/integrationTest/java/org/apache/ignite/internal/sql/api/ItSqlAsynchronousApiTest.java: ## @@ -343,37 +346,59 @@ public void checkTransactio

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #1530: IGNITE-18027 Implementation of a full rebalance for RocksDbMvPartitionStorage on receiver

2023-01-19 Thread GitBox
tkalkirill commented on code in PR #1530: URL: https://github.com/apache/ignite-3/pull/1530#discussion_r1081133385 ## modules/storage-rocksdb/src/main/java/org/apache/ignite/internal/storage/rocksdb/RocksDbTableStorage.java: ## @@ -635,19 +644,117 @@ private static ColumnFamilyD

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #1530: IGNITE-18027 Implementation of a full rebalance for RocksDbMvPartitionStorage on receiver

2023-01-19 Thread GitBox
tkalkirill commented on code in PR #1530: URL: https://github.com/apache/ignite-3/pull/1530#discussion_r1081132844 ## modules/storage-rocksdb/src/main/java/org/apache/ignite/internal/storage/rocksdb/RocksDbTableStorage.java: ## @@ -635,19 +644,117 @@ private static ColumnFamilyD

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #1530: IGNITE-18027 Implementation of a full rebalance for RocksDbMvPartitionStorage on receiver

2023-01-19 Thread GitBox
tkalkirill commented on code in PR #1530: URL: https://github.com/apache/ignite-3/pull/1530#discussion_r1081132844 ## modules/storage-rocksdb/src/main/java/org/apache/ignite/internal/storage/rocksdb/RocksDbTableStorage.java: ## @@ -635,19 +644,117 @@ private static ColumnFamilyD

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #1530: IGNITE-18027 Implementation of a full rebalance for RocksDbMvPartitionStorage on receiver

2023-01-19 Thread GitBox
tkalkirill commented on code in PR #1530: URL: https://github.com/apache/ignite-3/pull/1530#discussion_r1081126727 ## modules/storage-rocksdb/src/main/java/org/apache/ignite/internal/storage/rocksdb/RocksDbMvPartitionStorage.java: ## @@ -1405,4 +1454,84 @@ private V busy(Suppli

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #1530: IGNITE-18027 Implementation of a full rebalance for RocksDbMvPartitionStorage on receiver

2023-01-19 Thread GitBox
tkalkirill commented on code in PR #1530: URL: https://github.com/apache/ignite-3/pull/1530#discussion_r1081129297 ## modules/storage-rocksdb/src/main/java/org/apache/ignite/internal/storage/rocksdb/index/RocksDbHashIndexStorage.java: ## @@ -262,4 +290,58 @@ private V busy(Supp

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #1530: IGNITE-18027 Implementation of a full rebalance for RocksDbMvPartitionStorage on receiver

2023-01-19 Thread GitBox
tkalkirill commented on code in PR #1530: URL: https://github.com/apache/ignite-3/pull/1530#discussion_r1081129036 ## modules/storage-rocksdb/src/main/java/org/apache/ignite/internal/storage/rocksdb/RocksDbMvPartitionStorage.java: ## @@ -1405,4 +1454,84 @@ private V busy(Suppli

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #1530: IGNITE-18027 Implementation of a full rebalance for RocksDbMvPartitionStorage on receiver

2023-01-19 Thread GitBox
tkalkirill commented on code in PR #1530: URL: https://github.com/apache/ignite-3/pull/1530#discussion_r1081128748 ## modules/storage-rocksdb/src/main/java/org/apache/ignite/internal/storage/rocksdb/RocksDbMvPartitionStorage.java: ## @@ -1405,4 +1454,84 @@ private V busy(Suppli

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #1530: IGNITE-18027 Implementation of a full rebalance for RocksDbMvPartitionStorage on receiver

2023-01-19 Thread GitBox
tkalkirill commented on code in PR #1530: URL: https://github.com/apache/ignite-3/pull/1530#discussion_r1081128431 ## modules/storage-rocksdb/src/main/java/org/apache/ignite/internal/storage/rocksdb/RocksDbMvPartitionStorage.java: ## @@ -967,15 +1005,18 @@ public void destroyDat

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #1530: IGNITE-18027 Implementation of a full rebalance for RocksDbMvPartitionStorage on receiver

2023-01-19 Thread GitBox
tkalkirill commented on code in PR #1530: URL: https://github.com/apache/ignite-3/pull/1530#discussion_r1081126934 ## modules/storage-rocksdb/src/main/java/org/apache/ignite/internal/storage/rocksdb/RocksDbMvPartitionStorage.java: ## @@ -330,6 +333,14 @@ public void lastApplied(

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #1530: IGNITE-18027 Implementation of a full rebalance for RocksDbMvPartitionStorage on receiver

2023-01-19 Thread GitBox
tkalkirill commented on code in PR #1530: URL: https://github.com/apache/ignite-3/pull/1530#discussion_r1081126727 ## modules/storage-rocksdb/src/main/java/org/apache/ignite/internal/storage/rocksdb/RocksDbMvPartitionStorage.java: ## @@ -1405,4 +1454,84 @@ private V busy(Suppli

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #1530: IGNITE-18027 Implementation of a full rebalance for RocksDbMvPartitionStorage on receiver

2023-01-19 Thread GitBox
tkalkirill commented on code in PR #1530: URL: https://github.com/apache/ignite-3/pull/1530#discussion_r1081126504 ## modules/storage-rocksdb/src/main/java/org/apache/ignite/internal/storage/rocksdb/RocksDbMvPartitionStorage.java: ## @@ -967,15 +1005,18 @@ public void destroyDat

[GitHub] [ignite-3] sashapolo commented on a diff in pull request #1530: IGNITE-18027 Implementation of a full rebalance for RocksDbMvPartitionStorage on receiver

2023-01-19 Thread GitBox
sashapolo commented on code in PR #1530: URL: https://github.com/apache/ignite-3/pull/1530#discussion_r1081075418 ## modules/storage-rocksdb/src/main/java/org/apache/ignite/internal/storage/rocksdb/RocksDbMvPartitionStorage.java: ## @@ -330,6 +333,14 @@ public void lastApplied(l

[GitHub] [ignite] nizhikov commented on a diff in pull request #10314: IGNITE-17029 Consistent Cut for incremental snapshot

2023-01-19 Thread GitBox
nizhikov commented on code in PR #10314: URL: https://github.com/apache/ignite/pull/10314#discussion_r1081080438 ## modules/core/src/test/java/org/apache/ignite/internal/processors/cache/consistentcut/ConcurrentTxsConsistentCutTest.java: ## @@ -0,0 +1,269 @@ +/* + * Licensed to

[GitHub] [ignite] nizhikov commented on a diff in pull request #10314: IGNITE-17029 Consistent Cut for incremental snapshot

2023-01-19 Thread GitBox
nizhikov commented on code in PR #10314: URL: https://github.com/apache/ignite/pull/10314#discussion_r1081076810 ## modules/core/src/test/java/org/apache/ignite/internal/processors/cache/consistentcut/AbstractConsistentCutTest.java: ## @@ -0,0 +1,296 @@ +/* + * Licensed to the A

[GitHub] [ignite] nizhikov commented on a diff in pull request #10314: IGNITE-17029 Consistent Cut for incremental snapshot

2023-01-19 Thread GitBox
nizhikov commented on code in PR #10314: URL: https://github.com/apache/ignite/pull/10314#discussion_r1081075077 ## modules/core/src/test/java/org/apache/ignite/internal/processors/cache/consistentcut/AbstractConsistentCutTest.java: ## @@ -0,0 +1,296 @@ +/* + * Licensed to the A

[GitHub] [ignite] nizhikov commented on a diff in pull request #10314: IGNITE-17029 Consistent Cut for incremental snapshot

2023-01-19 Thread GitBox
nizhikov commented on code in PR #10314: URL: https://github.com/apache/ignite/pull/10314#discussion_r1081037421 ## modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/ConsistentCutMarkWalFuture.java: ## @@ -0,0 +1,186 @@ +/* + * Licensed

[GitHub] [ignite] nizhikov commented on a diff in pull request #10314: IGNITE-17029 Consistent Cut for incremental snapshot

2023-01-19 Thread GitBox
nizhikov commented on code in PR #10314: URL: https://github.com/apache/ignite/pull/10314#discussion_r1081037100 ## modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/ConsistentCutMarkWalFuture.java: ## @@ -0,0 +1,186 @@ +/* + * Licensed

[GitHub] [ignite] nizhikov commented on a diff in pull request #10314: IGNITE-17029 Consistent Cut for incremental snapshot

2023-01-19 Thread GitBox
nizhikov commented on code in PR #10314: URL: https://github.com/apache/ignite/pull/10314#discussion_r1081036626 ## modules/core/src/main/java/org/apache/ignite/internal/pagemem/wal/record/ConsistentCutFinishRecord.java: ## @@ -0,0 +1,101 @@ +/* + * Licensed to the Apache Softwa

[GitHub] [ignite] nizhikov commented on pull request #10485: IGNITE-18232 : [IEP-80] Remove of CacheMetricsMXBean legacy JMX bean, v3 : keep JCache beans

2023-01-19 Thread GitBox
nizhikov commented on PR #10485: URL: https://github.com/apache/ignite/pull/10485#issuecomment-1396693426 We don't need to copy code from existing to those new classes. Please, revert removal of existing JMX class and keep required methods in it. -- This is an automated message from the A

[GitHub] [ignite] Vladsz83 commented on pull request #10485: IGNITE-18232 : [IEP-80] Remove of CacheMetricsMXBean legacy JMX bean, v3 : keep JCache beans

2023-01-19 Thread GitBox
Vladsz83 commented on PR #10485: URL: https://github.com/apache/ignite/pull/10485#issuecomment-1396688641 > Yes. We should cleanup existing MXBeans and keep only methods required by JCache specification. It is done in the new beans -- This is an automated message from the Apache Gi

[GitHub] [ignite] nizhikov commented on pull request #10485: IGNITE-18232 : [IEP-80] Remove of CacheMetricsMXBean legacy JMX bean, v3 : keep JCache beans

2023-01-19 Thread GitBox
nizhikov commented on PR #10485: URL: https://github.com/apache/ignite/pull/10485#issuecomment-1396681031 Yes. We should cleanup existing MXBeans and keep only methods required by JCache specification. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [ignite] Vladsz83 commented on pull request #10485: IGNITE-18232 : [IEP-80] Remove of CacheMetricsMXBean legacy JMX bean, v3 : keep JCache beans

2023-01-19 Thread GitBox
Vladsz83 commented on PR #10485: URL: https://github.com/apache/ignite/pull/10485#issuecomment-1396678879 > It seems like new classes in general just a copy of existing. JCache's interfaces are smaller, contain fewer methods. JCache's `CacheStatisticsMXBean` has 11 statistics methods.

[GitHub] [ignite] nizhikov commented on pull request #10485: IGNITE-18232 : [IEP-80] Remove of CacheMetricsMXBean legacy JMX bean, v3 : keep JCache beans

2023-01-19 Thread GitBox
nizhikov commented on PR #10485: URL: https://github.com/apache/ignite/pull/10485#issuecomment-1396660024 Can we keep one of `CacheClusterMetricsMXBeanImpl` or `CacheLocalMetricsMXBeanImpl` and implement in it JCache interfaces to reduce changes? It seems like new classes in general just a

[GitHub] [ignite] nizhikov merged pull request #10483: IGNITE-18573 DistributedProcess should have an option to await client node results

2023-01-19 Thread GitBox
nizhikov merged PR #10483: URL: https://github.com/apache/ignite/pull/10483 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ig

[GitHub] [ignite-3] tkalkirill opened a new pull request, #1547: IGNITE-18028 Implementation of a full rebalance for VolatilePageMemoryMvPartitionStorage on receiver

2023-01-19 Thread GitBox
tkalkirill opened a new pull request, #1547: URL: https://github.com/apache/ignite-3/pull/1547 https://issues.apache.org/jira/browse/IGNITE-18028 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [ignite-3] AMashenkov commented on a diff in pull request #1524: IGNITE-18464 Sql. Colocated sort aggregates need to compose a plans with additional sort

2023-01-19 Thread GitBox
AMashenkov commented on code in PR #1524: URL: https://github.com/apache/ignite-3/pull/1524#discussion_r1080923365 ## modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/planner/AggregatePlannerTest.java: ## @@ -389,52 +390,45 @@ public void mapAggregateWithou