[GitHub] [ignite] NSAmelchev commented on a diff in pull request #10393: IGNITE-18236 Cache objects transformation

NSAmelchev commented on code in PR #10393: URL: https://github.com/apache/ignite/pull/10393#discussion_r1082732858 ## modules/core/src/main/java/org/apache/ignite/events/EventType.java: ## @@ -526,6 +526,17 @@ public interface EventType { */ public static final int

[GitHub] [ignite] NSAmelchev commented on a diff in pull request #10393: IGNITE-18236 Cache objects transformation

NSAmelchev commented on code in PR #10393: URL: https://github.com/apache/ignite/pull/10393#discussion_r1082732023 ## modules/core/src/main/java/org/apache/ignite/events/CacheObjectTransformedEvent.java: ## @@ -0,0 +1,82 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [ignite] NSAmelchev commented on a diff in pull request #10393: IGNITE-18236 Cache objects transformation

NSAmelchev commented on code in PR #10393: URL: https://github.com/apache/ignite/pull/10393#discussion_r1082728668 ## modules/core/src/main/java/org/apache/ignite/configuration/IgniteConfiguration.java: ## @@ -416,6 +417,9 @@ public class IgniteConfiguration { /** Failover

[GitHub] [ignite] NSAmelchev commented on pull request #10393: IGNITE-18236 Cache objects transformation

NSAmelchev commented on PR #10393: URL: https://github.com/apache/ignite/pull/10393#issuecomment-1398588256 Should we check that cluster nodes have the same `CacheObjectTransformer`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [ignite-3] ibessonov merged pull request #1560: IGNITE-18598 Fix compilation after merge

ibessonov merged PR #1560: URL: https://github.com/apache/ignite-3/pull/1560 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [ignite-3] sashapolo opened a new pull request, #1560: IGNITE-18598 Fix compilation after merge

sashapolo opened a new pull request, #1560: URL: https://github.com/apache/ignite-3/pull/1560 https://issues.apache.org/jira/browse/IGNITE-18598 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [ignite-3] ibessonov merged pull request #1490: IGNITE-18397 Rework Watches based on Raft Learners

ibessonov merged PR #1490: URL: https://github.com/apache/ignite-3/pull/1490 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [ignite-3] rpuch opened a new pull request, #1559: IGNITE-18531 Destroy indices when destroying VolatilePageMemoryMvPartitionStorage

rpuch opened a new pull request, #1559: URL: https://github.com/apache/ignite-3/pull/1559 https://issues.apache.org/jira/browse/IGNITE-18531 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [ignite-3] SammyVimes merged pull request #1558: IGNITE-18597 Strip tail zeroes in RocksUtils#incrementArray

SammyVimes merged PR #1558: URL: https://github.com/apache/ignite-3/pull/1558 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [ignite-3] sashapolo commented on a diff in pull request #1490: IGNITE-18397 Rework Watches based on Raft Learners

sashapolo commented on code in PR #1490: URL: https://github.com/apache/ignite-3/pull/1490#discussion_r1082595722 ## modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/impl/MetaStorageManagerImpl.java: ## @@ -842,11 +753,9 @@ public boolean hasNext() {

[GitHub] [ignite-3] zstan commented on a diff in pull request #1550: IGNITE-18585 Sql. Introduce cache for serialized RelNodes representation

zstan commented on code in PR #1550: URL: https://github.com/apache/ignite-3/pull/1550#discussion_r1082590034 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/ExecutionServiceImpl.java: ## @@ -83,6 +86,13 @@ * ExecutionServiceImpl. TODO

[GitHub] [ignite-3] ibessonov commented on a diff in pull request #1490: IGNITE-18397 Rework Watches based on Raft Learners

ibessonov commented on code in PR #1490: URL: https://github.com/apache/ignite-3/pull/1490#discussion_r1082586412 ## modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/server/raft/MetaStorageLearnerListener.java: ## @@ -0,0 +1,73 @@ +/* + * Licensed to the

[GitHub] [ignite-3] ibessonov commented on a diff in pull request #1490: IGNITE-18397 Rework Watches based on Raft Learners

ibessonov commented on code in PR #1490: URL: https://github.com/apache/ignite-3/pull/1490#discussion_r1082584043 ## modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/impl/MetaStorageManagerImpl.java: ## @@ -842,11 +753,9 @@ public boolean hasNext() {

[GitHub] [ignite-3] ibessonov commented on a diff in pull request #1490: IGNITE-18397 Rework Watches based on Raft Learners

ibessonov commented on code in PR #1490: URL: https://github.com/apache/ignite-3/pull/1490#discussion_r1082584043 ## modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/impl/MetaStorageManagerImpl.java: ## @@ -842,11 +753,9 @@ public boolean hasNext() {

[GitHub] [ignite-3] ygerzhedovich commented on a diff in pull request #1469: IGNITE-18227: refactoring scan nodes and add support RO index scans.

ygerzhedovich commented on code in PR #1469: URL: https://github.com/apache/ignite-3/pull/1469#discussion_r1082583163 ## modules/runner/src/integrationTest/java/org/apache/ignite/internal/sql/api/ItSqlAsynchronousApiTest.java: ## @@ -343,37 +346,58 @@ public void

[GitHub] [ignite-3] ibessonov commented on a diff in pull request #1490: IGNITE-18397 Rework Watches based on Raft Learners

ibessonov commented on code in PR #1490: URL: https://github.com/apache/ignite-3/pull/1490#discussion_r1082582875 ## modules/distribution-zones/src/main/java/org/apache/ignite/internal/distributionzones/DistributionZoneManager.java: ## @@ -741,39 +742,27 @@ private void

[GitHub] [ignite-3] sanpwc merged pull request #1503: IGNITE-18324 Calling tx.rollback() or tx.commit() is not failed for committed transaction.

sanpwc merged PR #1503: URL: https://github.com/apache/ignite-3/pull/1503 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #1557: IGNITE-18596 Add RaftGroupConfiguration to MvTableStorage#finishRebalancePartition

tkalkirill commented on code in PR #1557: URL: https://github.com/apache/ignite-3/pull/1557#discussion_r1082521831 ## modules/storage-api/src/testFixtures/java/org/apache/ignite/internal/storage/AbstractMvTableStorageTest.java: ## @@ -917,4 +936,26 @@ private static List

[GitHub] [ignite-3] AMashenkov commented on a diff in pull request #1469: IGNITE-18227: refactoring scan nodes and add support RO index scans.

AMashenkov commented on code in PR #1469: URL: https://github.com/apache/ignite-3/pull/1469#discussion_r1082505775 ## modules/runner/src/integrationTest/java/org/apache/ignite/internal/sql/api/ItSqlAsynchronousApiTest.java: ## @@ -343,37 +346,58 @@ public void

[GitHub] [ignite-3] SammyVimes commented on a diff in pull request #1557: IGNITE-18596 Add RaftGroupConfiguration to MvTableStorage#finishRebalancePartition

SammyVimes commented on code in PR #1557: URL: https://github.com/apache/ignite-3/pull/1557#discussion_r1082490021 ## modules/storage-api/src/testFixtures/java/org/apache/ignite/internal/storage/AbstractMvTableStorageTest.java: ## @@ -917,4 +936,26 @@ private static List

[GitHub] [ignite-3] korlov42 commented on a diff in pull request #1536: IGNITE-18207 Sql. Pushdown DISTINCT aggregate with no particular function

korlov42 commented on code in PR #1536: URL: https://github.com/apache/ignite-3/pull/1536#discussion_r1082496024 ## modules/runner/src/integrationTest/java/org/apache/ignite/internal/sql/engine/AbstractBasicIntegrationTest.java: ## @@ -289,6 +299,26 @@ enum JoinType {

[GitHub] [ignite-3] korlov42 commented on a diff in pull request #1536: IGNITE-18207 Sql. Pushdown DISTINCT aggregate with no particular function

korlov42 commented on code in PR #1536: URL: https://github.com/apache/ignite-3/pull/1536#discussion_r1082494820 ## modules/runner/src/integrationTest/java/org/apache/ignite/internal/sql/engine/AbstractBasicIntegrationTest.java: ## @@ -244,9 +241,22 @@ protected QueryProcessor

[GitHub] [ignite-3] sashapolo opened a new pull request, #1558: IGNITE-18597 Strip tail zeroes in RocksUtils#incrementArray

sashapolo opened a new pull request, #1558: URL: https://github.com/apache/ignite-3/pull/1558 https://issues.apache.org/jira/browse/IGNITE-18597 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [ignite-3] korlov42 merged pull request #1513: IGNITE-18163: Old-style join on different column types fails with ClassCastException

korlov42 merged PR #1513: URL: https://github.com/apache/ignite-3/pull/1513 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [ignite-3] tkalkirill opened a new pull request, #1557: IGNITE-18596 Add RaftGroupConfiguration to MvTableStorage#finishRebalancePartition

tkalkirill opened a new pull request, #1557: URL: https://github.com/apache/ignite-3/pull/1557 https://issues.apache.org/jira/browse/IGNITE-18596 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [ignite-3] korlov42 commented on a diff in pull request #1524: IGNITE-18464 Sql. Colocated sort aggregates need to compose a plans with additional sort

korlov42 commented on code in PR #1524: URL: https://github.com/apache/ignite-3/pull/1524#discussion_r1082427170 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/rel/SortAggregateNode.java: ## @@ -159,6 +161,10 @@ public void end() throws Exception

[GitHub] [ignite-3] sergeyuttsel commented on a diff in pull request #1503: IGNITE-18324 Calling tx.rollback() or tx.commit() is not failed for committed transaction.

sergeyuttsel commented on code in PR #1503: URL: https://github.com/apache/ignite-3/pull/1503#discussion_r1082417133 ## modules/transactions/src/main/java/org/apache/ignite/internal/tx/impl/ReadWriteTransactionImpl.java: ## @@ -126,10 +135,14 @@ protected CompletableFuture

[GitHub] [ignite-3] sergeyuttsel commented on a diff in pull request #1503: IGNITE-18324 Calling tx.rollback() or tx.commit() is not failed for committed transaction.

sergeyuttsel commented on code in PR #1503: URL: https://github.com/apache/ignite-3/pull/1503#discussion_r1082415745 ## modules/transactions/src/main/java/org/apache/ignite/internal/tx/impl/ReadWriteTransactionImpl.java: ## @@ -88,8 +93,12 @@ public IgniteBiTuple

[GitHub] [ignite-3] sergeyuttsel commented on a diff in pull request #1503: IGNITE-18324 Calling tx.rollback() or tx.commit() is not failed for committed transaction.

sergeyuttsel commented on code in PR #1503: URL: https://github.com/apache/ignite-3/pull/1503#discussion_r1082415277 ## modules/transactions/src/main/java/org/apache/ignite/internal/tx/impl/ReadWriteTransactionImpl.java: ## @@ -126,10 +135,14 @@ protected CompletableFuture

[GitHub] [ignite-3] sergeyuttsel commented on a diff in pull request #1503: IGNITE-18324 Calling tx.rollback() or tx.commit() is not failed for committed transaction.

sergeyuttsel commented on code in PR #1503: URL: https://github.com/apache/ignite-3/pull/1503#discussion_r1082413152 ## modules/transactions/src/main/java/org/apache/ignite/internal/tx/impl/ReadWriteTransactionImpl.java: ## @@ -88,8 +93,12 @@ public IgniteBiTuple

[GitHub] [ignite-3] korlov42 commented on a diff in pull request #1524: IGNITE-18464 Sql. Colocated sort aggregates need to compose a plans with additional sort

korlov42 commented on code in PR #1524: URL: https://github.com/apache/ignite-3/pull/1524#discussion_r1082404654 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/rel/SortAggregateNode.java: ## @@ -76,7 +75,6 @@ public SortAggregateNode(

[GitHub] [ignite] ivandasch merged pull request #10490: IGNITE-18584 Enlarge compression buffer in order to provide sufficient space for compressors.

ivandasch merged PR #10490: URL: https://github.com/apache/ignite/pull/10490 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [ignite-3] sashapolo commented on a diff in pull request #1490: IGNITE-18397 Rework Watches based on Raft Learners

sashapolo commented on code in PR #1490: URL: https://github.com/apache/ignite-3/pull/1490#discussion_r1082360088 ## modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/server/raft/MetaStorageWriteHandler.java: ## @@ -0,0 +1,245 @@ +/* + * Licensed to the

[GitHub] [ignite-3] sashapolo commented on a diff in pull request #1490: IGNITE-18397 Rework Watches based on Raft Learners

sashapolo commented on code in PR #1490: URL: https://github.com/apache/ignite-3/pull/1490#discussion_r1082359287 ## modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/server/raft/MetaStorageLearnerListener.java: ## @@ -0,0 +1,73 @@ +/* + * Licensed to the

[GitHub] [ignite-3] sashapolo commented on a diff in pull request #1490: IGNITE-18397 Rework Watches based on Raft Learners

sashapolo commented on code in PR #1490: URL: https://github.com/apache/ignite-3/pull/1490#discussion_r1082356978 ## modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/impl/MetaStorageManagerImpl.java: ## @@ -842,11 +753,9 @@ public boolean hasNext() {

[GitHub] [ignite-3] sashapolo commented on a diff in pull request #1490: IGNITE-18397 Rework Watches based on Raft Learners

sashapolo commented on code in PR #1490: URL: https://github.com/apache/ignite-3/pull/1490#discussion_r1082352267 ## modules/metastorage/src/integrationTest/java/org/apache/ignite/internal/metastorage/impl/ItMetaStorageWatchTest.java: ## @@ -0,0 +1,339 @@ +/* + * Licensed to

[GitHub] [ignite-3] AMashenkov commented on a diff in pull request #1513: IGNITE-18163: Old-style join on different column types fails with ClassCastException

AMashenkov commented on code in PR #1513: URL: https://github.com/apache/ignite-3/pull/1513#discussion_r1082350058 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/type/IgniteTypeSystem.java: ## @@ -45,6 +45,8 @@ public int getMaxNumericPrecision() {

[GitHub] [ignite-3] lowka commented on a diff in pull request #1528: IGNITE-18422: Sql. Match number of dynamic parameters with given parameters

lowka commented on code in PR #1528: URL: https://github.com/apache/ignite-3/pull/1528#discussion_r1082340129 ## modules/runner/src/integrationTest/java/org/apache/ignite/internal/sql/engine/util/QueryChecker.java: ## @@ -251,6 +251,8 @@ public static Matcher

[GitHub] [ignite-3] ptupitsyn merged pull request #1554: IGNITE-18588 .NET: Fix BinaryTupleReader behavior on payload size mismatch

ptupitsyn merged PR #1554: URL: https://github.com/apache/ignite-3/pull/1554 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [ignite-3] AMashenkov commented on a diff in pull request #1528: IGNITE-18422: Sql. Match number of dynamic parameters with given parameters

AMashenkov commented on code in PR #1528: URL: https://github.com/apache/ignite-3/pull/1528#discussion_r1082320651 ## modules/runner/src/integrationTest/java/org/apache/ignite/internal/sql/engine/util/QueryChecker.java: ## @@ -251,6 +251,8 @@ public static Matcher

[GitHub] [ignite-3] AMashenkov commented on a diff in pull request #1528: IGNITE-18422: Sql. Match number of dynamic parameters with given parameters

AMashenkov commented on code in PR #1528: URL: https://github.com/apache/ignite-3/pull/1528#discussion_r1082316721 ## modules/runner/src/integrationTest/java/org/apache/ignite/internal/sql/engine/util/QueryChecker.java: ## @@ -363,27 +365,54 @@ public QueryChecker

[GitHub] [ignite-3] AMashenkov commented on a diff in pull request #1528: IGNITE-18422: Sql. Match number of dynamic parameters with given parameters

AMashenkov commented on code in PR #1528: URL: https://github.com/apache/ignite-3/pull/1528#discussion_r1082316721 ## modules/runner/src/integrationTest/java/org/apache/ignite/internal/sql/engine/util/QueryChecker.java: ## @@ -363,27 +365,54 @@ public QueryChecker

[GitHub] [ignite-3] AMashenkov commented on a diff in pull request #1528: IGNITE-18422: Sql. Match number of dynamic parameters with given parameters

AMashenkov commented on code in PR #1528: URL: https://github.com/apache/ignite-3/pull/1528#discussion_r1082316721 ## modules/runner/src/integrationTest/java/org/apache/ignite/internal/sql/engine/util/QueryChecker.java: ## @@ -363,27 +365,54 @@ public QueryChecker

[GitHub] [ignite-3] sashapolo commented on a diff in pull request #1490: IGNITE-18397 Rework Watches based on Raft Learners

sashapolo commented on code in PR #1490: URL: https://github.com/apache/ignite-3/pull/1490#discussion_r1082315255 ## modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/server/raft/MetaStorageWriteHandler.java: ## @@ -0,0 +1,245 @@ +/* + * Licensed to the

[GitHub] [ignite-3] sashapolo commented on a diff in pull request #1490: IGNITE-18397 Rework Watches based on Raft Learners

sashapolo commented on code in PR #1490: URL: https://github.com/apache/ignite-3/pull/1490#discussion_r1082314883 ## modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/server/raft/MetaStorageWriteHandler.java: ## @@ -0,0 +1,245 @@ +/* + * Licensed to the

[GitHub] [ignite-3] sashapolo commented on a diff in pull request #1490: IGNITE-18397 Rework Watches based on Raft Learners

sashapolo commented on code in PR #1490: URL: https://github.com/apache/ignite-3/pull/1490#discussion_r1082313704 ## modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/impl/MetaStorageManagerImpl.java: ## @@ -159,54 +135,164 @@ public

[GitHub] [ignite-3] sashapolo commented on a diff in pull request #1490: IGNITE-18397 Rework Watches based on Raft Learners

sashapolo commented on code in PR #1490: URL: https://github.com/apache/ignite-3/pull/1490#discussion_r1082313013 ## modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/impl/MetaStorageManagerImpl.java: ## @@ -159,54 +135,164 @@ public

[GitHub] [ignite-3] sashapolo commented on a diff in pull request #1490: IGNITE-18397 Rework Watches based on Raft Learners

sashapolo commented on code in PR #1490: URL: https://github.com/apache/ignite-3/pull/1490#discussion_r1082312367 ## modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/impl/MetaStorageManagerImpl.java: ## @@ -159,54 +135,164 @@ public

[GitHub] [ignite-3] sashapolo commented on a diff in pull request #1490: IGNITE-18397 Rework Watches based on Raft Learners

sashapolo commented on code in PR #1490: URL: https://github.com/apache/ignite-3/pull/1490#discussion_r1082311805 ## modules/distribution-zones/src/main/java/org/apache/ignite/internal/distributionzones/DistributionZoneManager.java: ## @@ -741,39 +742,27 @@ private void

[GitHub] [ignite-3] sashapolo commented on a diff in pull request #1490: IGNITE-18397 Rework Watches based on Raft Learners

sashapolo commented on code in PR #1490: URL: https://github.com/apache/ignite-3/pull/1490#discussion_r1082310535 ## modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/server/KeyValueStorage.java: ## @@ -220,32 +222,54 @@ public interface KeyValueStorage

[GitHub] [ignite-3] korlov42 commented on a diff in pull request #1524: IGNITE-18464 Sql. Colocated sort aggregates need to compose a plans with additional sort

korlov42 commented on code in PR #1524: URL: https://github.com/apache/ignite-3/pull/1524#discussion_r1082304386 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/rule/SortAggregateConverterRule.java: ## @@ -36,6 +36,7 @@ import

[GitHub] [ignite-3] korlov42 commented on a diff in pull request #1524: IGNITE-18464 Sql. Colocated sort aggregates need to compose a plans with additional sort

korlov42 commented on code in PR #1524: URL: https://github.com/apache/ignite-3/pull/1524#discussion_r1082303971 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/rule/AbstractIgniteConverterRule.java: ## @@ -24,6 +24,7 @@ import

[GitHub] [ignite-3] ibessonov commented on a diff in pull request #1490: IGNITE-18397 Rework Watches based on Raft Learners

ibessonov commented on code in PR #1490: URL: https://github.com/apache/ignite-3/pull/1490#discussion_r1080883366 ## modules/distribution-zones/src/main/java/org/apache/ignite/internal/distributionzones/DistributionZoneManager.java: ## @@ -741,39 +742,27 @@ private void

[GitHub] [ignite-3] korlov42 commented on a diff in pull request #1550: IGNITE-18585 Sql. Introduce cache for serialized RelNodes representation

korlov42 commented on code in PR #1550: URL: https://github.com/apache/ignite-3/pull/1550#discussion_r1082287428 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/ExecutionServiceImpl.java: ## @@ -83,6 +86,13 @@ * ExecutionServiceImpl. TODO

[GitHub] [ignite-3] tkalkirill opened a new pull request, #1556: IGNITE-18593 Get rid of MvPartitionStorage and TxStateStorage in PartitionAccess

tkalkirill opened a new pull request, #1556: URL: https://github.com/apache/ignite-3/pull/1556 https://issues.apache.org/jira/browse/IGNITE-18593 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [ignite-3] tkalkirill merged pull request #1547: IGNITE-18028 Implementation of a full rebalance for VolatilePageMemoryMvPartitionStorage on receiver

tkalkirill merged PR #1547: URL: https://github.com/apache/ignite-3/pull/1547 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [ignite-3] sanpwc commented on a diff in pull request #1503: IGNITE-18324 Calling tx.rollback() or tx.commit() is not failed for committed transaction.

sanpwc commented on code in PR #1503: URL: https://github.com/apache/ignite-3/pull/1503#discussion_r1082171669 ## modules/transactions/src/main/java/org/apache/ignite/internal/tx/impl/ReadWriteTransactionImpl.java: ## @@ -88,8 +93,12 @@ public IgniteBiTuple

[GitHub] [ignite-3] korlov42 merged pull request #1521: IGNITE-18254: Sql. Extend SQL grammar with ALTER ZONE statement

korlov42 merged PR #1521: URL: https://github.com/apache/ignite-3/pull/1521 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [ignite-3] apachont opened a new pull request, #1552: Build Improvements

apachont opened a new pull request, #1552: URL: https://github.com/apache/ignite-3/pull/1552 ### Changes - Use relative path normalization in order to improve cache relocate-ability of Checkstyle, sql-parser and OpenApi cache keys - Disable timestamp autogeneration on Swagger causing

[GitHub] [ignite-3] denis-chudov opened a new pull request, #1551: IGNITE-18527

denis-chudov opened a new pull request, #1551: URL: https://github.com/apache/ignite-3/pull/1551 https://issues.apache.org/jira/browse/IGNITE-18527 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [ignite-3] sanpwc merged pull request #1538: IGNITE-18525 Introduce new PlacementDriver Ignite component

sanpwc merged PR #1538: URL: https://github.com/apache/ignite-3/pull/1538 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [ignite] ivandasch opened a new pull request, #10490: IGNITE-18584 Enlarge compression buffer in order to provide sufficient space for compressors.

ivandasch opened a new pull request, #10490: URL: https://github.com/apache/ignite/pull/10490 Thank you for submitting the pull request to the Apache Ignite. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ###

[GitHub] [ignite-3] ygerzhedovich commented on a diff in pull request #1528: IGNITE-18422: Sql. Match number of dynamic parameters with given parameters

ygerzhedovich commented on code in PR #1528: URL: https://github.com/apache/ignite-3/pull/1528#discussion_r1081461103 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/prepare/IgniteSqlValidator.java: ## @@ -459,15 +459,23 @@ private boolean

[GitHub] [ignite-3] lowka commented on a diff in pull request #1521: IGNITE-18254: Sql. Extend SQL grammar with ALTER ZONE statement

lowka commented on code in PR #1521: URL: https://github.com/apache/ignite-3/pull/1521#discussion_r1081445505 ## modules/sql-engine/src/main/codegen/config.fmpp: ## @@ -594,7 +598,8 @@ data: { # Return type of method implementation should be 'SqlNode'. # Example:

[GitHub] [ignite-3] lowka commented on a diff in pull request #1521: IGNITE-18254: Sql. Extend SQL grammar with ALTER ZONE statement

lowka commented on code in PR #1521: URL: https://github.com/apache/ignite-3/pull/1521#discussion_r1081445505 ## modules/sql-engine/src/main/codegen/config.fmpp: ## @@ -594,7 +598,8 @@ data: { # Return type of method implementation should be 'SqlNode'. # Example:

[GitHub] [ignite-3] lowka commented on a diff in pull request #1521: IGNITE-18254: Sql. Extend SQL grammar with ALTER ZONE statement

lowka commented on code in PR #1521: URL: https://github.com/apache/ignite-3/pull/1521#discussion_r1081440348 ## modules/sql-engine/src/main/codegen/includes/parserImpls.ftl: ## @@ -532,3 +532,96 @@ SqlDrop SqlDropZone(Span s, boolean replace) : return new

[GitHub] [ignite-3] lowka commented on a diff in pull request #1521: IGNITE-18254: Sql. Extend SQL grammar with ALTER ZONE statement

lowka commented on code in PR #1521: URL: https://github.com/apache/ignite-3/pull/1521#discussion_r1081438594 ## modules/sql-engine/src/main/codegen/config.fmpp: ## @@ -29,6 +29,7 @@ data: { imports: [ "org.apache.calcite.sql.SqlCreate",

[GitHub] [ignite-3] tkalkirill merged pull request #1530: IGNITE-18027 Implementation of a full rebalance for RocksDbMvPartitionStorage on receiver

tkalkirill merged PR #1530: URL: https://github.com/apache/ignite-3/pull/1530 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [ignite] Vladsz83 commented on a diff in pull request #10485: IGNITE-18232 : [IEP-80] Remove of CacheMetricsMXBean legacy JMX bean, v3 : keep JCache beans

Vladsz83 commented on code in PR #10485: URL: https://github.com/apache/ignite/pull/10485#discussion_r1081238283 ## modules/core/src/main/java/org/apache/ignite/internal/processors/cache/CacheClusterMetricsMXBeanImpl.java: ## @@ -17,515 +17,121 @@ package

[GitHub] [ignite] nizhikov commented on a diff in pull request #10485: IGNITE-18232 : [IEP-80] Remove of CacheMetricsMXBean legacy JMX bean, v3 : keep JCache beans

nizhikov commented on code in PR #10485: URL: https://github.com/apache/ignite/pull/10485#discussion_r1081234368 ## modules/core/src/main/java/org/apache/ignite/internal/processors/cache/CacheClusterMetricsMXBeanImpl.java: ## @@ -17,515 +17,121 @@ package

[GitHub] [ignite] Vladsz83 commented on pull request #10485: IGNITE-18232 : [IEP-80] Remove of CacheMetricsMXBean legacy JMX bean, v3 : keep JCache beans

Vladsz83 commented on PR #10485: URL: https://github.com/apache/ignite/pull/10485#issuecomment-1396907110 > We don't need to copy code from existing to those new classes. Please, revert removal of existing JMX class and keep required methods in it. Done. I keep

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #1530: IGNITE-18027 Implementation of a full rebalance for RocksDbMvPartitionStorage on receiver

tkalkirill commented on code in PR #1530: URL: https://github.com/apache/ignite-3/pull/1530#discussion_r1081197351 ## modules/storage-rocksdb/src/main/java/org/apache/ignite/internal/storage/rocksdb/RocksDbTableStorage.java: ## @@ -635,19 +644,117 @@ private static

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #1530: IGNITE-18027 Implementation of a full rebalance for RocksDbMvPartitionStorage on receiver

tkalkirill commented on code in PR #1530: URL: https://github.com/apache/ignite-3/pull/1530#discussion_r1081197136 ## modules/storage-rocksdb/src/main/java/org/apache/ignite/internal/storage/rocksdb/RocksDbTableStorage.java: ## @@ -635,19 +644,117 @@ private static

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #1530: IGNITE-18027 Implementation of a full rebalance for RocksDbMvPartitionStorage on receiver

tkalkirill commented on code in PR #1530: URL: https://github.com/apache/ignite-3/pull/1530#discussion_r1081185912 ## modules/storage-rocksdb/src/main/java/org/apache/ignite/internal/storage/rocksdb/RocksDbMvPartitionStorage.java: ## @@ -1405,4 +1454,84 @@ private V

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #1530: IGNITE-18027 Implementation of a full rebalance for RocksDbMvPartitionStorage on receiver

tkalkirill commented on code in PR #1530: URL: https://github.com/apache/ignite-3/pull/1530#discussion_r1081185536 ## modules/storage-rocksdb/src/main/java/org/apache/ignite/internal/storage/rocksdb/RocksDbMvPartitionStorage.java: ## @@ -1405,4 +1454,84 @@ private V

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #1530: IGNITE-18027 Implementation of a full rebalance for RocksDbMvPartitionStorage on receiver

tkalkirill commented on code in PR #1530: URL: https://github.com/apache/ignite-3/pull/1530#discussion_r1081184519 ## modules/storage-rocksdb/src/main/java/org/apache/ignite/internal/storage/rocksdb/RocksDbMvPartitionStorage.java: ## @@ -330,6 +333,14 @@ public void

[GitHub] [ignite-3] PakhomovAlexander commented on a diff in pull request #1549: IGNITE-18586 Add descriptions for REST components

PakhomovAlexander commented on code in PR #1549: URL: https://github.com/apache/ignite-3/pull/1549#discussion_r1081168521 ## modules/rest-api/src/main/java/org/apache/ignite/internal/rest/api/InvalidParam.java: ## @@ -20,13 +20,17 @@ import

[GitHub] [ignite] Vladsz83 closed pull request #10435: IGNITE-16292 : unstable alter table server and client

Vladsz83 closed pull request #10435: IGNITE-16292 : unstable alter table server and client URL: https://github.com/apache/ignite/pull/10435 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [ignite-3] sashapolo commented on a diff in pull request #1530: IGNITE-18027 Implementation of a full rebalance for RocksDbMvPartitionStorage on receiver

sashapolo commented on code in PR #1530: URL: https://github.com/apache/ignite-3/pull/1530#discussion_r1081160394 ## modules/storage-rocksdb/src/main/java/org/apache/ignite/internal/storage/rocksdb/RocksDbTableStorage.java: ## @@ -635,19 +644,117 @@ private static

[GitHub] [ignite-3] sashapolo commented on a diff in pull request #1530: IGNITE-18027 Implementation of a full rebalance for RocksDbMvPartitionStorage on receiver

sashapolo commented on code in PR #1530: URL: https://github.com/apache/ignite-3/pull/1530#discussion_r1081159865 ## modules/storage-rocksdb/src/main/java/org/apache/ignite/internal/storage/rocksdb/index/RocksDbHashIndexStorage.java: ## @@ -262,4 +290,58 @@ private V

[GitHub] [ignite-3] sashapolo commented on a diff in pull request #1530: IGNITE-18027 Implementation of a full rebalance for RocksDbMvPartitionStorage on receiver

sashapolo commented on code in PR #1530: URL: https://github.com/apache/ignite-3/pull/1530#discussion_r1081159533 ## modules/storage-rocksdb/src/main/java/org/apache/ignite/internal/storage/rocksdb/RocksDbMvPartitionStorage.java: ## @@ -1405,4 +1454,84 @@ private V

[GitHub] [ignite-3] sashapolo commented on a diff in pull request #1530: IGNITE-18027 Implementation of a full rebalance for RocksDbMvPartitionStorage on receiver

sashapolo commented on code in PR #1530: URL: https://github.com/apache/ignite-3/pull/1530#discussion_r1081158798 ## modules/storage-rocksdb/src/main/java/org/apache/ignite/internal/storage/rocksdb/RocksDbMvPartitionStorage.java: ## @@ -967,15 +1005,18 @@ public void

[GitHub] [ignite-3] sashapolo commented on a diff in pull request #1530: IGNITE-18027 Implementation of a full rebalance for RocksDbMvPartitionStorage on receiver

sashapolo commented on code in PR #1530: URL: https://github.com/apache/ignite-3/pull/1530#discussion_r1081158465 ## modules/storage-rocksdb/src/main/java/org/apache/ignite/internal/storage/rocksdb/RocksDbMvPartitionStorage.java: ## @@ -330,6 +333,14 @@ public void

[GitHub] [ignite-3] ygerzhedovich commented on a diff in pull request #1537: IGNITE-18227 Refactor scan nodes and add support RO index scans

ygerzhedovich commented on code in PR #1537: URL: https://github.com/apache/ignite-3/pull/1537#discussion_r1081138614 ## modules/runner/src/integrationTest/java/org/apache/ignite/internal/sql/api/ItSqlAsynchronousApiTest.java: ## @@ -343,37 +346,59 @@ public void

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #1530: IGNITE-18027 Implementation of a full rebalance for RocksDbMvPartitionStorage on receiver

tkalkirill commented on code in PR #1530: URL: https://github.com/apache/ignite-3/pull/1530#discussion_r1081133385 ## modules/storage-rocksdb/src/main/java/org/apache/ignite/internal/storage/rocksdb/RocksDbTableStorage.java: ## @@ -635,19 +644,117 @@ private static

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #1530: IGNITE-18027 Implementation of a full rebalance for RocksDbMvPartitionStorage on receiver

tkalkirill commented on code in PR #1530: URL: https://github.com/apache/ignite-3/pull/1530#discussion_r1081132844 ## modules/storage-rocksdb/src/main/java/org/apache/ignite/internal/storage/rocksdb/RocksDbTableStorage.java: ## @@ -635,19 +644,117 @@ private static

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #1530: IGNITE-18027 Implementation of a full rebalance for RocksDbMvPartitionStorage on receiver

tkalkirill commented on code in PR #1530: URL: https://github.com/apache/ignite-3/pull/1530#discussion_r1081132844 ## modules/storage-rocksdb/src/main/java/org/apache/ignite/internal/storage/rocksdb/RocksDbTableStorage.java: ## @@ -635,19 +644,117 @@ private static

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #1530: IGNITE-18027 Implementation of a full rebalance for RocksDbMvPartitionStorage on receiver

tkalkirill commented on code in PR #1530: URL: https://github.com/apache/ignite-3/pull/1530#discussion_r1081126727 ## modules/storage-rocksdb/src/main/java/org/apache/ignite/internal/storage/rocksdb/RocksDbMvPartitionStorage.java: ## @@ -1405,4 +1454,84 @@ private V

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #1530: IGNITE-18027 Implementation of a full rebalance for RocksDbMvPartitionStorage on receiver

tkalkirill commented on code in PR #1530: URL: https://github.com/apache/ignite-3/pull/1530#discussion_r1081129297 ## modules/storage-rocksdb/src/main/java/org/apache/ignite/internal/storage/rocksdb/index/RocksDbHashIndexStorage.java: ## @@ -262,4 +290,58 @@ private V

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #1530: IGNITE-18027 Implementation of a full rebalance for RocksDbMvPartitionStorage on receiver

tkalkirill commented on code in PR #1530: URL: https://github.com/apache/ignite-3/pull/1530#discussion_r1081129036 ## modules/storage-rocksdb/src/main/java/org/apache/ignite/internal/storage/rocksdb/RocksDbMvPartitionStorage.java: ## @@ -1405,4 +1454,84 @@ private V

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #1530: IGNITE-18027 Implementation of a full rebalance for RocksDbMvPartitionStorage on receiver

tkalkirill commented on code in PR #1530: URL: https://github.com/apache/ignite-3/pull/1530#discussion_r1081128748 ## modules/storage-rocksdb/src/main/java/org/apache/ignite/internal/storage/rocksdb/RocksDbMvPartitionStorage.java: ## @@ -1405,4 +1454,84 @@ private V

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #1530: IGNITE-18027 Implementation of a full rebalance for RocksDbMvPartitionStorage on receiver

tkalkirill commented on code in PR #1530: URL: https://github.com/apache/ignite-3/pull/1530#discussion_r1081128431 ## modules/storage-rocksdb/src/main/java/org/apache/ignite/internal/storage/rocksdb/RocksDbMvPartitionStorage.java: ## @@ -967,15 +1005,18 @@ public void

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #1530: IGNITE-18027 Implementation of a full rebalance for RocksDbMvPartitionStorage on receiver

tkalkirill commented on code in PR #1530: URL: https://github.com/apache/ignite-3/pull/1530#discussion_r1081126934 ## modules/storage-rocksdb/src/main/java/org/apache/ignite/internal/storage/rocksdb/RocksDbMvPartitionStorage.java: ## @@ -330,6 +333,14 @@ public void

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #1530: IGNITE-18027 Implementation of a full rebalance for RocksDbMvPartitionStorage on receiver

tkalkirill commented on code in PR #1530: URL: https://github.com/apache/ignite-3/pull/1530#discussion_r1081126727 ## modules/storage-rocksdb/src/main/java/org/apache/ignite/internal/storage/rocksdb/RocksDbMvPartitionStorage.java: ## @@ -1405,4 +1454,84 @@ private V

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #1530: IGNITE-18027 Implementation of a full rebalance for RocksDbMvPartitionStorage on receiver

tkalkirill commented on code in PR #1530: URL: https://github.com/apache/ignite-3/pull/1530#discussion_r1081126504 ## modules/storage-rocksdb/src/main/java/org/apache/ignite/internal/storage/rocksdb/RocksDbMvPartitionStorage.java: ## @@ -967,15 +1005,18 @@ public void

[GitHub] [ignite-3] sashapolo commented on a diff in pull request #1530: IGNITE-18027 Implementation of a full rebalance for RocksDbMvPartitionStorage on receiver

sashapolo commented on code in PR #1530: URL: https://github.com/apache/ignite-3/pull/1530#discussion_r1081075418 ## modules/storage-rocksdb/src/main/java/org/apache/ignite/internal/storage/rocksdb/RocksDbMvPartitionStorage.java: ## @@ -330,6 +333,14 @@ public void

[GitHub] [ignite] nizhikov commented on a diff in pull request #10314: IGNITE-17029 Consistent Cut for incremental snapshot

nizhikov commented on code in PR #10314: URL: https://github.com/apache/ignite/pull/10314#discussion_r1081080438 ## modules/core/src/test/java/org/apache/ignite/internal/processors/cache/consistentcut/ConcurrentTxsConsistentCutTest.java: ## @@ -0,0 +1,269 @@ +/* + * Licensed to

[GitHub] [ignite] nizhikov commented on a diff in pull request #10314: IGNITE-17029 Consistent Cut for incremental snapshot

nizhikov commented on code in PR #10314: URL: https://github.com/apache/ignite/pull/10314#discussion_r1081076810 ## modules/core/src/test/java/org/apache/ignite/internal/processors/cache/consistentcut/AbstractConsistentCutTest.java: ## @@ -0,0 +1,296 @@ +/* + * Licensed to the

[GitHub] [ignite] nizhikov commented on a diff in pull request #10314: IGNITE-17029 Consistent Cut for incremental snapshot

nizhikov commented on code in PR #10314: URL: https://github.com/apache/ignite/pull/10314#discussion_r1081075077 ## modules/core/src/test/java/org/apache/ignite/internal/processors/cache/consistentcut/AbstractConsistentCutTest.java: ## @@ -0,0 +1,296 @@ +/* + * Licensed to the

[GitHub] [ignite] nizhikov commented on a diff in pull request #10314: IGNITE-17029 Consistent Cut for incremental snapshot

nizhikov commented on code in PR #10314: URL: https://github.com/apache/ignite/pull/10314#discussion_r1081037421 ## modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/ConsistentCutMarkWalFuture.java: ## @@ -0,0 +1,186 @@ +/* + * Licensed

  1   2   3   4   5   6   7   8   9   10   >