[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #1506: IGNITE-18029 Implementation of a full rebalance for PersistentPageMemoryMvPartitionStorage on receiver

2023-01-17 Thread GitBox
tkalkirill commented on code in PR #1506: URL: https://github.com/apache/ignite-3/pull/1506#discussion_r1072415322 ## modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/PersistentPageMemoryTableStorage.java: ## @@ -405,42 +373,148 @@ private

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #1506: IGNITE-18029 Implementation of a full rebalance for PersistentPageMemoryMvPartitionStorage on receiver

2023-01-17 Thread GitBox
tkalkirill commented on code in PR #1506: URL: https://github.com/apache/ignite-3/pull/1506#discussion_r1072414034 ## modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/PersistentPageMemoryTableStorage.java: ## @@ -405,42 +373,148 @@ private

[GitHub] [ignite-3] Flaugh24 commented on a diff in pull request #1502: IGNITE-18491: Add tests for completers

2023-01-17 Thread GitBox
Flaugh24 commented on code in PR #1502: URL: https://github.com/apache/ignite-3/pull/1502#discussion_r1072407243 ## modules/cli/src/integrationTest/java/org/apache/ignite/internal/cli/core/repl/executor/ItIgnitePicocliCommandsTest.java: ## @@ -356,6 +359,76 @@ void

[GitHub] [ignite-3] Flaugh24 commented on a diff in pull request #1502: IGNITE-18491: Add tests for completers

2023-01-17 Thread GitBox
Flaugh24 commented on code in PR #1502: URL: https://github.com/apache/ignite-3/pull/1502#discussion_r1072406356 ## modules/cli/src/integrationTest/java/org/apache/ignite/internal/cli/core/repl/executor/ItIgnitePicocliCommandsTest.java: ## @@ -356,6 +359,76 @@ void

[GitHub] [ignite-3] Flaugh24 commented on a diff in pull request #1502: IGNITE-18491: Add tests for completers

2023-01-17 Thread GitBox
Flaugh24 commented on code in PR #1502: URL: https://github.com/apache/ignite-3/pull/1502#discussion_r1072405813 ## modules/cli/src/integrationTest/java/org/apache/ignite/internal/cli/core/repl/executor/ItIgnitePicocliCommandsTest.java: ## @@ -356,6 +359,76 @@ void

[GitHub] [ignite-3] Flaugh24 commented on a diff in pull request #1502: IGNITE-18491: Add tests for completers

2023-01-17 Thread GitBox
Flaugh24 commented on code in PR #1502: URL: https://github.com/apache/ignite-3/pull/1502#discussion_r1072405500 ## modules/cli/src/integrationTest/java/org/apache/ignite/internal/cli/core/repl/executor/ItIgnitePicocliCommandsTest.java: ## @@ -356,6 +359,76 @@ void

[GitHub] [ignite] ivandasch opened a new pull request, #10484: IGNITE-18438 .NET: Fix marshalling of nested binarizable structures with different schemas.

2023-01-17 Thread GitBox
ivandasch opened a new pull request, #10484: URL: https://github.com/apache/ignite/pull/10484 Thank you for submitting the pull request to the Apache Ignite. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ###

[GitHub] [ignite-extensions] shishkovilja closed pull request #199: IGNITE-18209 Add check of a lag in a metadata topic

2023-01-17 Thread GitBox
shishkovilja closed pull request #199: IGNITE-18209 Add check of a lag in a metadata topic URL: https://github.com/apache/ignite-extensions/pull/199 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #1506: IGNITE-18029 Implementation of a full rebalance for PersistentPageMemoryMvPartitionStorage on receiver

2023-01-17 Thread GitBox
tkalkirill commented on code in PR #1506: URL: https://github.com/apache/ignite-3/pull/1506#discussion_r1072346248 ## modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/PersistentPageMemoryTableStorage.java: ## @@ -96,49 +98,22 @@ public

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #1506: IGNITE-18029 Implementation of a full rebalance for PersistentPageMemoryMvPartitionStorage on receiver

2023-01-17 Thread GitBox
tkalkirill commented on code in PR #1506: URL: https://github.com/apache/ignite-3/pull/1506#discussion_r1072334426 ## modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/PersistentPageMemoryTableStorage.java: ## @@ -405,42 +373,148 @@ private

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #1506: IGNITE-18029 Implementation of a full rebalance for PersistentPageMemoryMvPartitionStorage on receiver

2023-01-17 Thread GitBox
tkalkirill commented on code in PR #1506: URL: https://github.com/apache/ignite-3/pull/1506#discussion_r1072329420 ## modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/PersistentPageMemoryTableStorage.java: ## @@ -405,42 +373,148 @@ private

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #1506: IGNITE-18029 Implementation of a full rebalance for PersistentPageMemoryMvPartitionStorage on receiver

2023-01-17 Thread GitBox
tkalkirill commented on code in PR #1506: URL: https://github.com/apache/ignite-3/pull/1506#discussion_r1072329420 ## modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/PersistentPageMemoryTableStorage.java: ## @@ -405,42 +373,148 @@ private

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #1506: IGNITE-18029 Implementation of a full rebalance for PersistentPageMemoryMvPartitionStorage on receiver

2023-01-17 Thread GitBox
tkalkirill commented on code in PR #1506: URL: https://github.com/apache/ignite-3/pull/1506#discussion_r1072328103 ## modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/PersistentPageMemoryTableStorage.java: ## @@ -210,7 +177,8 @@ private

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #1506: IGNITE-18029 Implementation of a full rebalance for PersistentPageMemoryMvPartitionStorage on receiver

2023-01-17 Thread GitBox
tkalkirill commented on code in PR #1506: URL: https://github.com/apache/ignite-3/pull/1506#discussion_r1072279893 ## modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/mv/PersistentPageMemoryMvPartitionStorage.java: ## @@ -216,51 +197,41 @@

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #1506: IGNITE-18029 Implementation of a full rebalance for PersistentPageMemoryMvPartitionStorage on receiver

2023-01-17 Thread GitBox
tkalkirill commented on code in PR #1506: URL: https://github.com/apache/ignite-3/pull/1506#discussion_r1072276069 ## modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/mv/AbstractPageMemoryMvPartitionStorage.java: ## @@ -800,67 +732,65 @@

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #1506: IGNITE-18029 Implementation of a full rebalance for PersistentPageMemoryMvPartitionStorage on receiver

2023-01-17 Thread GitBox
tkalkirill commented on code in PR #1506: URL: https://github.com/apache/ignite-3/pull/1506#discussion_r1072275714 ## modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/mv/AbstractPageMemoryMvPartitionStorage.java: ## @@ -157,35 +141,31 @@

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #1506: IGNITE-18029 Implementation of a full rebalance for PersistentPageMemoryMvPartitionStorage on receiver

2023-01-17 Thread GitBox
tkalkirill commented on code in PR #1506: URL: https://github.com/apache/ignite-3/pull/1506#discussion_r1072257607 ## modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/index/sorted/PageMemorySortedIndexStorage.java: ## @@ -298,76 +276,74 @@

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #1506: IGNITE-18029 Implementation of a full rebalance for PersistentPageMemoryMvPartitionStorage on receiver

2023-01-17 Thread GitBox
tkalkirill commented on code in PR #1506: URL: https://github.com/apache/ignite-3/pull/1506#discussion_r1072257176 ## modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/index/sorted/PageMemorySortedIndexStorage.java: ## @@ -298,76 +276,74 @@

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #1506: IGNITE-18029 Implementation of a full rebalance for PersistentPageMemoryMvPartitionStorage on receiver

2023-01-17 Thread GitBox
tkalkirill commented on code in PR #1506: URL: https://github.com/apache/ignite-3/pull/1506#discussion_r1072256909 ## modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/index/sorted/PageMemorySortedIndexStorage.java: ## @@ -247,28 +233,20 @@

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #1506: IGNITE-18029 Implementation of a full rebalance for PersistentPageMemoryMvPartitionStorage on receiver

2023-01-17 Thread GitBox
tkalkirill commented on code in PR #1506: URL: https://github.com/apache/ignite-3/pull/1506#discussion_r1072251321 ## modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/index/sorted/PageMemorySortedIndexStorage.java: ## @@ -247,28 +233,20 @@

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #1506: IGNITE-18029 Implementation of a full rebalance for PersistentPageMemoryMvPartitionStorage on receiver

2023-01-17 Thread GitBox
tkalkirill commented on code in PR #1506: URL: https://github.com/apache/ignite-3/pull/1506#discussion_r1072251321 ## modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/index/sorted/PageMemorySortedIndexStorage.java: ## @@ -247,28 +233,20 @@

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #1506: IGNITE-18029 Implementation of a full rebalance for PersistentPageMemoryMvPartitionStorage on receiver

2023-01-17 Thread GitBox
tkalkirill commented on code in PR #1506: URL: https://github.com/apache/ignite-3/pull/1506#discussion_r1072249467 ## modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/index/hash/PageMemoryHashIndexStorage.java: ## @@ -97,100 +93,88 @@

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #1506: IGNITE-18029 Implementation of a full rebalance for PersistentPageMemoryMvPartitionStorage on receiver

2023-01-17 Thread GitBox
tkalkirill commented on code in PR #1506: URL: https://github.com/apache/ignite-3/pull/1506#discussion_r1072249794 ## modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/index/sorted/PageMemorySortedIndexStorage.java: ## @@ -105,71 +102,65 @@

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #1506: IGNITE-18029 Implementation of a full rebalance for PersistentPageMemoryMvPartitionStorage on receiver

2023-01-17 Thread GitBox
tkalkirill commented on code in PR #1506: URL: https://github.com/apache/ignite-3/pull/1506#discussion_r1072250057 ## modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/index/sorted/PageMemorySortedIndexStorage.java: ## @@ -105,71 +102,65 @@

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #1506: IGNITE-18029 Implementation of a full rebalance for PersistentPageMemoryMvPartitionStorage on receiver

2023-01-17 Thread GitBox
tkalkirill commented on code in PR #1506: URL: https://github.com/apache/ignite-3/pull/1506#discussion_r1072249213 ## modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/index/hash/PageMemoryHashIndexStorage.java: ## @@ -97,100 +93,88 @@

[GitHub] [ignite-3] korlov42 commented on a diff in pull request #1479: IGNITE-18360 Migrate storage to new Binary Tuple format

2023-01-17 Thread GitBox
korlov42 commented on code in PR #1479: URL: https://github.com/apache/ignite-3/pull/1479#discussion_r1072247433 ## modules/storage-api/src/main/java/org/apache/ignite/internal/storage/MvPartitionStorage.java: ## @@ -151,7 +151,7 @@ public interface MvPartitionStorage extends

[GitHub] [ignite-3] ibessonov opened a new pull request, #1540: IGNITE-18516 "Change closure" semantic fixed when it comes to concurr…

2023-01-17 Thread GitBox
ibessonov opened a new pull request, #1540: URL: https://github.com/apache/ignite-3/pull/1540 …ent access to "external" configuration. New "change" API introduced bot in registry and in generated Change interfaces. https://issues.apache.org/jira/browse/IGNITE-18516 -- This is an

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #1506: IGNITE-18029 Implementation of a full rebalance for PersistentPageMemoryMvPartitionStorage on receiver

2023-01-17 Thread GitBox
tkalkirill commented on code in PR #1506: URL: https://github.com/apache/ignite-3/pull/1506#discussion_r1072225481 ## modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/AbstractPageMemoryTableStorage.java: ## @@ -268,12 +377,52 @@ private

[GitHub] [ignite-3] ptupitsyn merged pull request #1535: Rename Gradle project from ignite-parent to Apache Ignite 3

2023-01-17 Thread GitBox
ptupitsyn merged PR #1535: URL: https://github.com/apache/ignite-3/pull/1535 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #1506: IGNITE-18029 Implementation of a full rebalance for PersistentPageMemoryMvPartitionStorage on receiver

2023-01-17 Thread GitBox
tkalkirill commented on code in PR #1506: URL: https://github.com/apache/ignite-3/pull/1506#discussion_r1072202522 ## modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/AbstractPageMemoryTableStorage.java: ## @@ -268,12 +377,52 @@ private

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #1506: IGNITE-18029 Implementation of a full rebalance for PersistentPageMemoryMvPartitionStorage on receiver

2023-01-17 Thread GitBox
tkalkirill commented on code in PR #1506: URL: https://github.com/apache/ignite-3/pull/1506#discussion_r1072201651 ## modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/AbstractPageMemoryTableStorage.java: ## @@ -167,86 +203,79 @@ public

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #1479: IGNITE-18360 Migrate storage to new Binary Tuple format

2023-01-17 Thread GitBox
tkalkirill commented on code in PR #1479: URL: https://github.com/apache/ignite-3/pull/1479#discussion_r1072175125 ## modules/storage-api/src/main/java/org/apache/ignite/internal/storage/MvPartitionStorage.java: ## @@ -151,7 +151,7 @@ public interface MvPartitionStorage extends

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #1506: IGNITE-18029 Implementation of a full rebalance for PersistentPageMemoryMvPartitionStorage on receiver

2023-01-17 Thread GitBox
tkalkirill commented on code in PR #1506: URL: https://github.com/apache/ignite-3/pull/1506#discussion_r107218 ## modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/AbstractPageMemoryTableStorage.java: ## @@ -18,61 +18,89 @@ package

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #1506: IGNITE-18029 Implementation of a full rebalance for PersistentPageMemoryMvPartitionStorage on receiver

2023-01-17 Thread GitBox
tkalkirill commented on code in PR #1506: URL: https://github.com/apache/ignite-3/pull/1506#discussion_r1072185181 ## modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/AbstractPageMemoryTableStorage.java: ## @@ -18,61 +18,89 @@ package

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #1506: IGNITE-18029 Implementation of a full rebalance for PersistentPageMemoryMvPartitionStorage on receiver

2023-01-17 Thread GitBox
tkalkirill commented on code in PR #1506: URL: https://github.com/apache/ignite-3/pull/1506#discussion_r1072184092 ## modules/storage-api/src/testFixtures/java/org/apache/ignite/internal/storage/AbstractMvTableStorageTest.java: ## @@ -811,8 +885,8 @@ private void

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #1506: IGNITE-18029 Implementation of a full rebalance for PersistentPageMemoryMvPartitionStorage on receiver

2023-01-17 Thread GitBox
tkalkirill commented on code in PR #1506: URL: https://github.com/apache/ignite-3/pull/1506#discussion_r1072181314 ## modules/storage-api/src/testFixtures/java/org/apache/ignite/internal/storage/AbstractMvTableStorageTest.java: ## @@ -548,6 +573,51 @@ public void

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #1506: IGNITE-18029 Implementation of a full rebalance for PersistentPageMemoryMvPartitionStorage on receiver

2023-01-17 Thread GitBox
tkalkirill commented on code in PR #1506: URL: https://github.com/apache/ignite-3/pull/1506#discussion_r1072180599 ## modules/storage-api/src/testFixtures/java/org/apache/ignite/internal/storage/AbstractMvTableStorageTest.java: ## @@ -88,25 +92,46 @@ public abstract class

[GitHub] [ignite-3] ibessonov commented on a diff in pull request #1506: IGNITE-18029 Implementation of a full rebalance for PersistentPageMemoryMvPartitionStorage on receiver

2023-01-17 Thread GitBox
ibessonov commented on code in PR #1506: URL: https://github.com/apache/ignite-3/pull/1506#discussion_r1072141988 ## modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/index/hash/PageMemoryHashIndexStorage.java: ## @@ -97,100 +93,88 @@

[GitHub] [ignite-3] ibessonov commented on a diff in pull request #1506: IGNITE-18029 Implementation of a full rebalance for PersistentPageMemoryMvPartitionStorage on receiver

2023-01-17 Thread GitBox
ibessonov commented on code in PR #1506: URL: https://github.com/apache/ignite-3/pull/1506#discussion_r1071208048 ## modules/storage-api/src/testFixtures/java/org/apache/ignite/internal/storage/AbstractMvTableStorageTest.java: ## @@ -548,6 +573,51 @@ public void

[GitHub] [ignite-3] valepakh commented on a diff in pull request #1479: IGNITE-18360 Migrate storage to new Binary Tuple format

2023-01-17 Thread GitBox
valepakh commented on code in PR #1479: URL: https://github.com/apache/ignite-3/pull/1479#discussion_r1072139004 ## modules/schema/src/main/java/org/apache/ignite/internal/schema/TableRow.java: ## @@ -0,0 +1,105 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [ignite-3] AMashenkov commented on a diff in pull request #1511: IGNITE-18510: Make composite publisher thread safe.

2023-01-17 Thread GitBox
AMashenkov commented on code in PR #1511: URL: https://github.com/apache/ignite-3/pull/1511#discussion_r1072138375 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/util/OrderedMergePublisher.java: ## @@ -36,49 +35,52 @@ * * Merges multiple

[GitHub] [ignite] timoninmaxim opened a new pull request, #10483: DistributedProcess can await client node results

2023-01-17 Thread GitBox
timoninmaxim opened a new pull request, #10483: URL: https://github.com/apache/ignite/pull/10483 Thank you for submitting the pull request to the Apache Ignite. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken:

[GitHub] [ignite-3] korlov42 commented on a diff in pull request #1479: IGNITE-18360 Migrate storage to new Binary Tuple format

2023-01-17 Thread GitBox
korlov42 commented on code in PR #1479: URL: https://github.com/apache/ignite-3/pull/1479#discussion_r1072122879 ## modules/storage-api/src/main/java/org/apache/ignite/internal/storage/MvPartitionStorage.java: ## @@ -151,7 +151,7 @@ public interface MvPartitionStorage extends

[GitHub] [ignite-3] ibessonov merged pull request #1534: IGNITE-18563 Reduce the list of duplicated jar dependencies

2023-01-17 Thread GitBox
ibessonov merged PR #1534: URL: https://github.com/apache/ignite-3/pull/1534 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [ignite-3] rpuch commented on a diff in pull request #1534: IGNITE-18563 Reduce the list of duplicated jar dependencies

2023-01-17 Thread GitBox
rpuch commented on code in PR #1534: URL: https://github.com/apache/ignite-3/pull/1534#discussion_r1072114151 ## modules/sql-engine/build.gradle: ## @@ -45,7 +45,11 @@ dependencies { implementation libs.jackson.core implementation libs.jackson.databind

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #1479: IGNITE-18360 Migrate storage to new Binary Tuple format

2023-01-17 Thread GitBox
tkalkirill commented on code in PR #1479: URL: https://github.com/apache/ignite-3/pull/1479#discussion_r1072106772 ## modules/schema/src/main/java/org/apache/ignite/internal/schema/TableRow.java: ## @@ -0,0 +1,105 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [ignite-3] lowka commented on a diff in pull request #1521: IGNITE-18254: Sql. Extend SQL grammar with ALTER ZONE statement

2023-01-17 Thread GitBox
lowka commented on code in PR #1521: URL: https://github.com/apache/ignite-3/pull/1521#discussion_r1072072004 ## modules/sql-engine/src/main/codegen/includes/parserImpls.ftl: ## @@ -532,3 +532,96 @@ SqlDrop SqlDropZone(Span s, boolean replace) : return new

[GitHub] [ignite-3] lowka commented on a diff in pull request #1521: IGNITE-18254: Sql. Extend SQL grammar with ALTER ZONE statement

2023-01-17 Thread GitBox
lowka commented on code in PR #1521: URL: https://github.com/apache/ignite-3/pull/1521#discussion_r1072072004 ## modules/sql-engine/src/main/codegen/includes/parserImpls.ftl: ## @@ -532,3 +532,96 @@ SqlDrop SqlDropZone(Span s, boolean replace) : return new

[GitHub] [ignite-3] lowka commented on a diff in pull request #1521: IGNITE-18254: Sql. Extend SQL grammar with ALTER ZONE statement

2023-01-17 Thread GitBox
lowka commented on code in PR #1521: URL: https://github.com/apache/ignite-3/pull/1521#discussion_r1072066793 ## modules/sql-engine/src/main/codegen/includes/parserImpls.ftl: ## @@ -532,3 +532,96 @@ SqlDrop SqlDropZone(Span s, boolean replace) : return new

[GitHub] [ignite-3] lowka commented on a diff in pull request #1521: IGNITE-18254: Sql. Extend SQL grammar with ALTER ZONE statement

2023-01-17 Thread GitBox
lowka commented on code in PR #1521: URL: https://github.com/apache/ignite-3/pull/1521#discussion_r1072065179 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/sql/IgniteSqlAlterZoneRenameTo.java: ## @@ -0,0 +1,70 @@ +/* + * Licensed to the Apache

[GitHub] [ignite-3] xtern merged pull request #1511: IGNITE-18510: Make composite publisher thread safe.

2023-01-17 Thread GitBox
xtern merged PR #1511: URL: https://github.com/apache/ignite-3/pull/1511 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [ignite-3] ptupitsyn closed pull request #1523: IGNITE-18509 .NET: Remove unused CompileMemberReader logic

2023-01-17 Thread GitBox
ptupitsyn closed pull request #1523: IGNITE-18509 .NET: Remove unused CompileMemberReader logic URL: https://github.com/apache/ignite-3/pull/1523 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [ignite-3] ptupitsyn merged pull request #1533: IGNITE-18215 .NET: LINQ: Fix GroupBy with complex expression

2023-01-17 Thread GitBox
ptupitsyn merged PR #1533: URL: https://github.com/apache/ignite-3/pull/1533 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [ignite-3] korlov42 commented on a diff in pull request #1479: IGNITE-18360 Migrate storage to new Binary Tuple format

2023-01-17 Thread GitBox
korlov42 commented on code in PR #1479: URL: https://github.com/apache/ignite-3/pull/1479#discussion_r1071959373 ## modules/storage-api/src/main/java/org/apache/ignite/internal/storage/TableRowAndRowId.java: ## @@ -18,31 +18,32 @@ package org.apache.ignite.internal.storage;

[GitHub] [ignite] petrov-mg opened a new pull request, #10482: wip

2023-01-17 Thread GitBox
petrov-mg opened a new pull request, #10482: URL: https://github.com/apache/ignite/pull/10482 Thank you for submitting the pull request to the Apache Ignite. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ###

[GitHub] [ignite] ptupitsyn closed issue #10469: Question on loading data onto ignite

2023-01-16 Thread GitBox
ptupitsyn closed issue #10469: Question on loading data onto ignite URL: https://github.com/apache/ignite/issues/10469 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [ignite-3] ibessonov opened a new pull request, #1534: IGNITE-18563 Reduce the list of duplicated jar dependencies

2023-01-16 Thread GitBox
ibessonov opened a new pull request, #1534: URL: https://github.com/apache/ignite-3/pull/1534 https://issues.apache.org/jira/browse/IGNITE-18563 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [ignite-3] korlov42 commented on a diff in pull request #1521: IGNITE-18254: Sql. Extend SQL grammar with ALTER ZONE statement

2023-01-16 Thread GitBox
korlov42 commented on code in PR #1521: URL: https://github.com/apache/ignite-3/pull/1521#discussion_r1071215818 ## modules/sql-engine/src/main/codegen/includes/parserImpls.ftl: ## @@ -532,3 +532,96 @@ SqlDrop SqlDropZone(Span s, boolean replace) : return new

[GitHub] [ignite-3] lowka commented on a diff in pull request #1521: IGNITE-18254: Sql. Extend SQL grammar with ALTER ZONE statement

2023-01-16 Thread GitBox
lowka commented on code in PR #1521: URL: https://github.com/apache/ignite-3/pull/1521#discussion_r1071837306 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/sql/IgniteAbstractSqlAlterZone.java: ## @@ -0,0 +1,48 @@ +/* + * Licensed to the Apache

[GitHub] [ignite] luchnikovbsk closed pull request #10300: IGNITE-17345 TEMP PR to ask questions (don't merge)

2023-01-16 Thread GitBox
luchnikovbsk closed pull request #10300: IGNITE-17345 TEMP PR to ask questions (don't merge) URL: https://github.com/apache/ignite/pull/10300 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [ignite-3] zstan commented on a diff in pull request #1521: IGNITE-18254: Sql. Extend SQL grammar with ALTER ZONE statement

2023-01-16 Thread GitBox
zstan commented on code in PR #1521: URL: https://github.com/apache/ignite-3/pull/1521#discussion_r1071766609 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/sql/IgniteSqlAlterZoneRenameTo.java: ## @@ -0,0 +1,70 @@ +/* + * Licensed to the Apache

[GitHub] [ignite-3] rpuch opened a new pull request, #1531: IGNITE-18505 Thread pool for components start

2023-01-16 Thread GitBox
rpuch opened a new pull request, #1531: URL: https://github.com/apache/ignite-3/pull/1531 https://issues.apache.org/jira/browse/IGNITE-18505 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [ignite-3] xtern commented on a diff in pull request #1511: IGNITE-18510: Make composite publisher thread safe.

2023-01-16 Thread GitBox
xtern commented on code in PR #1511: URL: https://github.com/apache/ignite-3/pull/1511#discussion_r1071289825 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/util/ConcatPublisher.java: ## @@ -0,0 +1,263 @@ +/* + * Licensed to the Apache Software

[GitHub] [ignite-3] xtern commented on a diff in pull request #1511: IGNITE-18510: Make composite publisher thread safe.

2023-01-16 Thread GitBox
xtern commented on code in PR #1511: URL: https://github.com/apache/ignite-3/pull/1511#discussion_r1071287538 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/util/OrderedMergePublisher.java: ## @@ -36,49 +35,52 @@ * * Merges multiple concurrent

[GitHub] [ignite-3] xtern commented on a diff in pull request #1511: IGNITE-18510: Make composite publisher thread safe.

2023-01-16 Thread GitBox
xtern commented on code in PR #1511: URL: https://github.com/apache/ignite-3/pull/1511#discussion_r1071286076 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/util/OrderedMergePublisher.java: ## @@ -36,49 +35,52 @@ * * Merges multiple concurrent

[GitHub] [ignite] timoninmaxim commented on a diff in pull request #10314: IGNITE-17029 Consistent Cut for incremental snapshot

2023-01-16 Thread GitBox
timoninmaxim commented on code in PR #10314: URL: https://github.com/apache/ignite/pull/10314#discussion_r1071285548 ## modules/core/src/test/java/org/apache/ignite/internal/processors/cache/consistentcut/AbstractConsistentCutTest.java: ## @@ -0,0 +1,301 @@ +/* + * Licensed to

[GitHub] [ignite-3] tkalkirill opened a new pull request, #1530: IGNITE-18027 Implementation of a full rebalance for RocksDbMvPartitionStorage on receiver

2023-01-16 Thread GitBox
tkalkirill opened a new pull request, #1530: URL: https://github.com/apache/ignite-3/pull/1530 https://issues.apache.org/jira/browse/IGNITE-18027 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [ignite] timoninmaxim commented on a diff in pull request #10314: IGNITE-17029 Consistent Cut for incremental snapshot

2023-01-16 Thread GitBox
timoninmaxim commented on code in PR #10314: URL: https://github.com/apache/ignite/pull/10314#discussion_r1071271269 ## modules/core/src/test/java/org/apache/ignite/internal/processors/cache/consistentcut/TransactionTestCase.java: ## @@ -0,0 +1,167 @@ +/* + * Licensed to the

[GitHub] [ignite-3] tkalkirill merged pull request #1526: IGNITE-18558 Fix Meta Storage prefix overflow

2023-01-16 Thread GitBox
tkalkirill merged PR #1526: URL: https://github.com/apache/ignite-3/pull/1526 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [ignite-3] xtern commented on a diff in pull request #1511: IGNITE-18510: Make composite publisher thread safe.

2023-01-16 Thread GitBox
xtern commented on code in PR #1511: URL: https://github.com/apache/ignite-3/pull/1511#discussion_r1071261364 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/util/ConcatPublisher.java: ## @@ -0,0 +1,263 @@ +/* + * Licensed to the Apache Software

[GitHub] [ignite-3] xtern commented on a diff in pull request #1511: IGNITE-18510: Make composite publisher thread safe.

2023-01-16 Thread GitBox
xtern commented on code in PR #1511: URL: https://github.com/apache/ignite-3/pull/1511#discussion_r1071260952 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/util/ConcatPublisher.java: ## @@ -0,0 +1,263 @@ +/* + * Licensed to the Apache Software

[GitHub] [ignite-3] xtern commented on a diff in pull request #1511: IGNITE-18510: Make composite publisher thread safe.

2023-01-16 Thread GitBox
xtern commented on code in PR #1511: URL: https://github.com/apache/ignite-3/pull/1511#discussion_r1071259733 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/util/OrderedMergePublisher.java: ## @@ -107,14 +109,20 @@ public void subscribe(Subscriber

[GitHub] [ignite-3] xtern commented on a diff in pull request #1511: IGNITE-18510: Make composite publisher thread safe.

2023-01-16 Thread GitBox
xtern commented on code in PR #1511: URL: https://github.com/apache/ignite-3/pull/1511#discussion_r1071259421 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/util/ConcatPublisher.java: ## @@ -0,0 +1,263 @@ +/* + * Licensed to the Apache Software

[GitHub] [ignite-3] lowka commented on a diff in pull request #1513: IGNITE-18163: Old-style join on different column types fails with ClassCastException

2023-01-16 Thread GitBox
lowka commented on code in PR #1513: URL: https://github.com/apache/ignite-3/pull/1513#discussion_r1071234558 ## modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/prepare/TypeCoercionTest.java: ## @@ -0,0 +1,395 @@ +/* + * Licensed to the Apache Software

[GitHub] [ignite-3] lowka commented on a diff in pull request #1513: IGNITE-18163: Old-style join on different column types fails with ClassCastException

2023-01-16 Thread GitBox
lowka commented on code in PR #1513: URL: https://github.com/apache/ignite-3/pull/1513#discussion_r1071234230 ## modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/prepare/TypeCoercionTest.java: ## @@ -0,0 +1,414 @@ +/* + * Licensed to the Apache Software

[GitHub] [ignite] timoninmaxim commented on a diff in pull request #10314: IGNITE-17029 Consistent Cut for incremental snapshot

2023-01-16 Thread GitBox
timoninmaxim commented on code in PR #10314: URL: https://github.com/apache/ignite/pull/10314#discussion_r1071226965 ## modules/core/src/main/java/org/apache/ignite/internal/processors/cache/transactions/IgniteTxHandler.java: ## @@ -218,73 +222,151 @@ public

[GitHub] [ignite] timoninmaxim commented on a diff in pull request #10314: IGNITE-17029 Consistent Cut for incremental snapshot

2023-01-16 Thread GitBox
timoninmaxim commented on code in PR #10314: URL: https://github.com/apache/ignite/pull/10314#discussion_r1071227994 ## modules/core/src/main/java/org/apache/ignite/internal/processors/cache/transactions/IgniteTxManager.java: ## @@ -3130,6 +3143,50 @@ public

[GitHub] [ignite-3] sashapolo commented on a diff in pull request #1526: IGNITE-18558 Fix Meta Storage prefix overflow

2023-01-16 Thread GitBox
sashapolo commented on code in PR #1526: URL: https://github.com/apache/ignite-3/pull/1526#discussion_r1071223554 ## modules/metastorage/src/testFixtures/java/org/apache/ignite/internal/metastorage/server/SimpleInMemoryKeyValueStorage.java: ## @@ -359,21 +360,30 @@ public

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #1526: IGNITE-18558 Fix Meta Storage prefix overflow

2023-01-16 Thread GitBox
tkalkirill commented on code in PR #1526: URL: https://github.com/apache/ignite-3/pull/1526#discussion_r1071220712 ## modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/impl/MetaStorageManagerImpl.java: ## @@ -676,17 +676,15 @@ public Cursor

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #1526: IGNITE-18558 Fix Meta Storage prefix overflow

2023-01-16 Thread GitBox
tkalkirill commented on code in PR #1526: URL: https://github.com/apache/ignite-3/pull/1526#discussion_r1071218519 ## modules/metastorage/src/testFixtures/java/org/apache/ignite/internal/metastorage/server/SimpleInMemoryKeyValueStorage.java: ## @@ -359,21 +360,30 @@ public

[GitHub] [ignite] nizhikov merged pull request #10481: IGNITE-18515 CDC: add documentation about metadata replication

2023-01-16 Thread GitBox
nizhikov merged PR #10481: URL: https://github.com/apache/ignite/pull/10481 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [ignite-3] sashapolo commented on a diff in pull request #1526: IGNITE-18558 Fix Meta Storage prefix overflow

2023-01-16 Thread GitBox
sashapolo commented on code in PR #1526: URL: https://github.com/apache/ignite-3/pull/1526#discussion_r1071211290 ## modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/impl/MetaStorageManagerImpl.java: ## @@ -676,17 +676,15 @@ public Cursor range(ByteArray

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #1526: IGNITE-18558 Fix Meta Storage prefix overflow

2023-01-16 Thread GitBox
tkalkirill commented on code in PR #1526: URL: https://github.com/apache/ignite-3/pull/1526#discussion_r1071209772 ## modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/impl/MetaStorageManagerImpl.java: ## @@ -676,17 +676,15 @@ public Cursor

[GitHub] [ignite-3] sashapolo commented on a diff in pull request #1526: IGNITE-18558 Fix Meta Storage prefix overflow

2023-01-16 Thread GitBox
sashapolo commented on code in PR #1526: URL: https://github.com/apache/ignite-3/pull/1526#discussion_r1071205107 ## modules/metastorage/src/testFixtures/java/org/apache/ignite/internal/metastorage/server/SimpleInMemoryKeyValueStorage.java: ## @@ -359,21 +360,30 @@ public

[GitHub] [ignite-3] sashapolo commented on a diff in pull request #1526: IGNITE-18558 Fix Meta Storage prefix overflow

2023-01-16 Thread GitBox
sashapolo commented on code in PR #1526: URL: https://github.com/apache/ignite-3/pull/1526#discussion_r1071204424 ## modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/impl/MetaStorageManagerImpl.java: ## @@ -676,17 +676,15 @@ public Cursor range(ByteArray

[GitHub] [ignite-3] zstan commented on a diff in pull request #1513: IGNITE-18163: Old-style join on different column types fails with ClassCastException

2023-01-16 Thread GitBox
zstan commented on code in PR #1513: URL: https://github.com/apache/ignite-3/pull/1513#discussion_r1071201780 ## modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/prepare/TypeCoercionTest.java: ## @@ -0,0 +1,414 @@ +/* + * Licensed to the Apache Software

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #1526: IGNITE-18558 Fix Meta Storage prefix overflow

2023-01-16 Thread GitBox
tkalkirill commented on code in PR #1526: URL: https://github.com/apache/ignite-3/pull/1526#discussion_r1071195665 ## modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/server/raft/MetaStorageListener.java: ## @@ -253,19 +254,27 @@ public void

[GitHub] [ignite-3] zstan opened a new pull request, #1529: IGNITE-18501 Sql. Remove deprecated QueryProcessor#queryAsync from QueryChecker

2023-01-16 Thread GitBox
zstan opened a new pull request, #1529: URL: https://github.com/apache/ignite-3/pull/1529 …eryChecker -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [ignite-3] lowka opened a new pull request, #1528: IGNITE-18422: Sql. Match number of dynamic parameters with given parameters

2023-01-16 Thread GitBox
lowka opened a new pull request, #1528: URL: https://github.com/apache/ignite-3/pull/1528 …meters -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [ignite] nizhikov commented on a diff in pull request #10314: IGNITE-17029 Consistent Cut for incremental snapshot

2023-01-16 Thread GitBox
nizhikov commented on code in PR #10314: URL: https://github.com/apache/ignite/pull/10314#discussion_r1071152344 ## modules/core/src/test/java/org/apache/ignite/internal/processors/cache/consistentcut/AbstractConsistentCutTest.java: ## @@ -0,0 +1,301 @@ +/* + * Licensed to the

[GitHub] [ignite] shishkovilja opened a new pull request, #10481: IGNITE-18515 CDC: add documentation about metadata replication

2023-01-16 Thread GitBox
shishkovilja opened a new pull request, #10481: URL: https://github.com/apache/ignite/pull/10481 Thank you for submitting the pull request to the Apache Ignite. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken:

[GitHub] [ignite-3] lowka commented on a diff in pull request #1513: IGNITE-18163: Old-style join on different column types fails with ClassCastException

2023-01-16 Thread GitBox
lowka commented on code in PR #1513: URL: https://github.com/apache/ignite-3/pull/1513#discussion_r1071140488 ## modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/prepare/LeastRestrictiveTypesTest.java: ## @@ -0,0 +1,257 @@ +/* + * Licensed to the Apache

[GitHub] [ignite] nizhikov commented on a diff in pull request #10314: IGNITE-17029 Consistent Cut for incremental snapshot

2023-01-16 Thread GitBox
nizhikov commented on code in PR #10314: URL: https://github.com/apache/ignite/pull/10314#discussion_r1071136370 ## modules/core/src/test/java/org/apache/ignite/internal/processors/cache/consistentcut/ConcurrentTxsConsistentCutTest.java: ## @@ -0,0 +1,194 @@ +/* + * Licensed to

[GitHub] [ignite] nizhikov commented on a diff in pull request #10314: IGNITE-17029 Consistent Cut for incremental snapshot

2023-01-16 Thread GitBox
nizhikov commented on code in PR #10314: URL: https://github.com/apache/ignite/pull/10314#discussion_r1071109454 ## modules/core/src/test/java/org/apache/ignite/internal/processors/cache/consistentcut/ConcurrentTxsConsistentCutTest.java: ## @@ -0,0 +1,194 @@ +/* + * Licensed to

[GitHub] [ignite] nizhikov commented on a diff in pull request #10314: IGNITE-17029 Consistent Cut for incremental snapshot

2023-01-16 Thread GitBox
nizhikov commented on code in PR #10314: URL: https://github.com/apache/ignite/pull/10314#discussion_r1071107606 ## modules/core/src/test/java/org/apache/ignite/internal/processors/cache/consistentcut/ConcurrentTxsConsistentCutTest.java: ## @@ -0,0 +1,194 @@ +/* + * Licensed to

[GitHub] [ignite] nizhikov commented on a diff in pull request #10314: IGNITE-17029 Consistent Cut for incremental snapshot

2023-01-16 Thread GitBox
nizhikov commented on code in PR #10314: URL: https://github.com/apache/ignite/pull/10314#discussion_r1071100462 ## modules/core/src/test/java/org/apache/ignite/internal/processors/cache/consistentcut/ConcurrentTxsConsistentCutTest.java: ## @@ -0,0 +1,194 @@ +/* + * Licensed to

[GitHub] [ignite-3] sashapolo opened a new pull request, #1526: IGNITE-18558 Fix Meta Storage prefix overflow

2023-01-16 Thread GitBox
sashapolo opened a new pull request, #1526: URL: https://github.com/apache/ignite-3/pull/1526 https://issues.apache.org/jira/browse/IGNITE-18558 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [ignite] nizhikov commented on pull request #10314: IGNITE-17029 Consistent Cut for incremental snapshot

2023-01-16 Thread GitBox
nizhikov commented on PR #10314: URL: https://github.com/apache/ignite/pull/10314#issuecomment-1383837598 Do we have tests that just: * performs transactions from several threads to several nodes * incremental snapshots created without any interaction with transaction threads *

[GitHub] [ignite] nizhikov commented on a diff in pull request #10314: IGNITE-17029 Consistent Cut for incremental snapshot

2023-01-16 Thread GitBox
nizhikov commented on code in PR #10314: URL: https://github.com/apache/ignite/pull/10314#discussion_r1071072854 ## modules/core/src/test/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/IncrementalSnapshotTest.java: ## @@ -219,6 +221,8 @@ public void

[GitHub] [ignite] nizhikov commented on a diff in pull request #10314: IGNITE-17029 Consistent Cut for incremental snapshot

2023-01-16 Thread GitBox
nizhikov commented on code in PR #10314: URL: https://github.com/apache/ignite/pull/10314#discussion_r1071071348 ## modules/core/src/test/java/org/apache/ignite/internal/processors/cache/consistentcut/ConsistentCutNoBackupMessagesBlockingTest.java: ## @@ -0,0 +1,82 @@ +/* + *

<    1   2   3   4   5   6   7   8   9   10   >