[jclouds-java-7-pull-requests
#1165](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1165/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/214#issuecomment-38656006
I think the whole authentication login with these ssh connections needs a
rethink at some point (hopefully not with this pull request though). The way I,
as a user, would like it to work is that I just pile on authentication methods
that have some hope of succeeding and then when connecting we
@@ -152,7 +163,7 @@ public void clear() {
}
@Override
- public Session create() throws Exception {
+ public synchronized Session create() throws Exception {
Have you experienced concurrency issues? In theory, the ssh client factory will
create independent clients, and each
@@ -63,9 +77,14 @@ public Factory(ProxyConfig proxyConfig,
BackoffLimitedRetryHandler backoffLimite
@Override
public SshClient create(HostAndPort socket, LoginCredentials
credentials) {
- SshClient client = new JschSshClient(proxyConfig,
@@ -63,9 +77,14 @@ public Factory(ProxyConfig proxyConfig,
BackoffLimitedRetryHandler backoffLimite
@Override
public SshClient create(HostAndPort socket, LoginCredentials
credentials) {
- SshClient client = new JschSshClient(proxyConfig,
@@ -156,6 +157,15 @@ public String getPrivateKey() {
}
/**
+* @return true if there is a private key attached that is not encrypted
+*/
+ public boolean hasUnencryptedPrivateKey() {
+ return getPrivateKey() != null
+ !getPrivateKey().isEmpty()
+
@demobox @nacx Been a while, but it works fine with current master.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/184#issuecomment-38692063
As discussed in https://github.com/jclouds/jclouds/pull/184 here is a new patch
for master.
Cheers,
Hugo
You can merge this Pull Request by running:
git pull https://github.com/spark404/jclouds JCLOUDS-347-1.8.x
Or you can view, comment on it, or merge it online at:
[jclouds » jclouds
#953](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/953/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
[jclouds-pull-requests
#697](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/697/) UNSTABLE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/328#issuecomment-38700999
[jclouds » jclouds
#954](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/954/) UNSTABLE
Looks like there's a problem with this pull request
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
[jclouds-pull-requests
#699](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/699/) UNSTABLE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/296#issuecomment-38707059
[jclouds-pull-requests
#698](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/698/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/296#issuecomment-38707154
@@ -152,7 +163,7 @@ public void clear() {
}
@Override
- public Session create() throws Exception {
+ public synchronized Session create() throws Exception {
I'd say yes. There is no direct use case in jclouds where a client is
shared between multiple actors, so I'd just remove
[jclouds-pull-requests
#700](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/700/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/312#issuecomment-38724118
[
https://issues.apache.org/jira/browse/JCLOUDS-515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Everett Toews updated JCLOUDS-515:
--
Assignee: Jasdeep Hundal
Cinder volume create does not require availability zone
[jclouds » jclouds
#956](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/956/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
[jclouds-pull-requests
#702](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/702/) UNSTABLE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/296#issuecomment-38732537
[jclouds » jclouds
#957](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/957/) UNSTABLE
Looks like there's a problem with this pull request
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
See https://buildhive.cloudbees.com/job/jclouds/job/jclouds/957/changes
@nacx : I removed the zone specification from the test and it passed, so I
think this is good to go. Could add another test to use zone as well, but I'm
not sure how valuable an additional test just for that will be.
---
Reply to this email directly or view it on GitHub:
[
https://issues.apache.org/jira/browse/JCLOUDS-515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13948419#comment-13948419
]
Everett Toews commented on JCLOUDS-515:
---
The Volume domain object is not actually
@jasdeep-hundal @nacx I made [a
comment](https://issues.apache.org/jira/browse/JCLOUDS-515?focusedCommentId=13948419page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13948419)
that was more appropriate to be made over in the issue.
---
Reply to this email directly or
}
- private boolean parentIsFolder(final ListContainerOptions options, final
StorageMetadata md) {
- return options.getDir() != null md.getName().indexOf('/') == -1;
+ private void waitForCompletion(final Semaphore semaphore,
+ final SetListenableFutureVoid
Only the minor question about a possible case-insensitive check for the
encrypted header from me, otherwise +1 - looks good. @nacx: Any more
questions from you?
I guess we want want to backport this to 1.7.x? And we should probably create
an issue for this, just for housekeeping...
---
Reply
I committed to master with some Checkstyle, Javadoc, and indentation fixes.
Let's address some of the TODOs and test more before backporting to 1.7.x.
Thank you for your contribution @shrinandj ! The previous implementation has
troubled us for some years now.
---
Reply to this email
Closed #214.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/214
[
https://issues.apache.org/jira/browse/JCLOUDS-510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13948439#comment-13948439
]
ASF subversion and git services commented on JCLOUDS-510:
-
Commit
I made a comment that was more appropriate to be made over in the issue.
Good catch, @everett-toews. Thanks!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/327#issuecomment-38738453
@@ -102,6 +103,27 @@ public String toString() {
}
+ public static class BlockDevice{
Are you confident that BlockDevice will only ever be used within the context of
CreateServerOptions?
Also there should be a space before the {
---
Reply to this email directly or view it on
@@ -102,6 +103,27 @@ public String toString() {
}
+ public static class BlockDevice{
Going to work through getting this running through the ComputeServiceApi this
week, should have a good answer for you then. Right now, I'm not sure.
---
Reply to this email directly or view it on
@@ -102,6 +103,27 @@ public String toString() {
}
+ public static class BlockDevice{
+ @Named(volume_size)
+ String volumeSize = ;
+ @Named(volume_id)
+ String volumeId;
+ @Named(delete_on_termination)
+ int deleteOnTermination = 0;
+
@@ -102,6 +103,27 @@ public String toString() {
}
+ public static class BlockDevice{
+ @Named(volume_size)
+ String volumeSize = ;
+ @Named(volume_id)
+ String volumeId;
+ @Named(delete_on_termination)
+ int deleteOnTermination = 0;
+
+ String volumeSize = ;
+ @Named(volume_id)
+ String volumeId;
+ @Named(delete_on_termination)
+ int deleteOnTermination = 0;
+ @Named(device_name)
+ String deviceName;
+
+ public BlockDevice(String volumeId, String deviceName){
+
@@ -113,6 +135,7 @@ public String toString() {
private SetNetwork novaNetworks = ImmutableSet.of();
private String availabilityZone;
private boolean configDrive;
+ private ListBlockDevice blockDeviceMapping = Lists.newArrayList();
`ImmutableList.of()`?
---
Reply to this email
@@ -463,6 +494,21 @@ public CreateServerOptions networks(String... networks) {
return networks(ImmutableSet.copyOf(networks));
}
+ /**
+* Block volumes that should be attached to the instance at boot time
+*/
+ public ListBlockDevice getBlockDeviceMapping() {
+
@@ -463,6 +494,21 @@ public CreateServerOptions networks(String... networks) {
return networks(ImmutableSet.copyOf(networks));
}
+ /**
+* Block volumes that should be attached to the instance at boot time
+*/
+ public ListBlockDevice getBlockDeviceMapping() {
+
[
https://issues.apache.org/jira/browse/JCLOUDS-514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13948481#comment-13948481
]
Everett Toews commented on JCLOUDS-514:
---
The two CLI docs linked to here seem to be
@@ -102,6 +103,27 @@ public String toString() {
}
+ public static class BlockDevice{
My suggestion would be to get it running properly in the NovaApi with expect
tests and live tests first. That stuff really needs to be done before you can
add proper support in the ComputeService
We'll also need more Javadoc for all of the parameters that can be used to
create a BlockDevice.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/326#issuecomment-38742092
[
https://issues.apache.org/jira/browse/JCLOUDS-514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13948499#comment-13948499
]
Jasdeep Hundal commented on JCLOUDS-514:
That was a bit for a derp on a blind
[
https://issues.apache.org/jira/browse/JCLOUDS-514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13948511#comment-13948511
]
Everett Toews commented on JCLOUDS-514:
---
I think the (Icehouse) link you really
[
https://issues.apache.org/jira/browse/JCLOUDS-514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13948520#comment-13948520
]
Everett Toews commented on JCLOUDS-514:
---
For the record, there are two similarly
@@ -102,6 +103,27 @@ public String toString() {
}
+ public static class BlockDevice{
Considering there's already a feature in Nova that boots from block devices
using the term block-device, I think it's more appropriate to call this object
BlockDeviceMapping.
---
Reply to this
jclouds-labs-openstack-pull-requests #185 UNSTABLE
Glance tests [are
failing](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/org.apache.jclouds.labs$openstack-glance/185/testReport/)
- I guess you are expecting that, @zack-shoylev?
If I recall, we had a follow-up PR
[
https://issues.apache.org/jira/browse/JCLOUDS-514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13948524#comment-13948524
]
Jasdeep Hundal commented on JCLOUDS-514:
This ticket is specifically for
See https://buildhive.cloudbees.com/job/jclouds/job/jclouds/958/changes
[jclouds » jclouds
#958](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/958/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
Yep, I see now (and agree). Thx @everett-toews !
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/327#issuecomment-38744957
[
https://issues.apache.org/jira/browse/JCLOUDS-515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13948531#comment-13948531
]
Jasdeep Hundal edited comment on JCLOUDS-515 at 3/26/14 9:57 PM:
[
https://issues.apache.org/jira/browse/JCLOUDS-515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13948531#comment-13948531
]
Jasdeep Hundal commented on JCLOUDS-515:
This was a fix because I did run into
[
https://issues.apache.org/jira/browse/JCLOUDS-515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13948532#comment-13948532
]
Jasdeep Hundal commented on JCLOUDS-515:
Ah, I realize after looking at this end
Thanks @everett-toews , I was a little quick to jump the gun there. Left a
comment in the ticket, but there is a fix that needs to be made, not sure if it
is this one though.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/327#issuecomment-38746123
@@ -102,6 +103,27 @@ public String toString() {
}
+ public static class BlockDevice{
Will go that route, and I'm fine with that name change (I actually started out
with that and then noticed that Nova called the entire list of block device
mappings a block device mapping itself.)
[jclouds-pull-requests
#703](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/703/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/312#issuecomment-38746443
Only the minor question about a possible case-insensitive check for the
encrypted header from me
@demobox Reading [the spec of the Proc-Type
header](http://tools.ietf.org/html/rfc1421#section-4.6.1.1) it seems that the
possible values are fixed and uppercase, so I'm ok with the current check
[
https://issues.apache.org/jira/browse/JCLOUDS-515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13948551#comment-13948551
]
Jasdeep Hundal commented on JCLOUDS-515:
^ Investigating that now.
Cinder
Just seen that the comparison is now case-insensitive. A case-sensitive check,
as it was done before, seems more correct. Mind changing this last small bit?
I'll merge it afterwards.
---
Reply to this email directly or view it on GitHub:
[jclouds-java-7-pull-requests
#1173](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1173/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/312#issuecomment-38747539
so I'm ok with the current check being case sensitive
Thanks for checking the spec, @nacx. Lazy me :-( Good to go on this one - just
the usual squash'n'rebase, and an issue number!
---
Reply to this email directly or view it on GitHub:
[
https://issues.apache.org/jira/browse/JCLOUDS-515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13948585#comment-13948585
]
Andrew Phillips commented on JCLOUDS-515:
-
Yes, this looks like it's happening
@demobox : Glance tests were fixed in another PR. I am working on follow up PRs
and trying to determine scope. Thanks for reminding me about the needed
checkstyle fixes. I will try to keep it in mind! :)
---
Reply to this email directly or view it on GitHub:
return this;
}
public static class Builder {
- /** @see UpdateCDNContainerOptions#ttl */
+ /**
+ * @see UpdateCDNContainerOptions#ttl
There was a discussion regarding @see vs text in another PR recently. What is
the right approach?
---
Reply to this email
[
https://issues.apache.org/jira/browse/JCLOUDS-508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13948618#comment-13948618
]
Andrew Gaul commented on JCLOUDS-508:
-
[~nwilton] ByteSource provides a size() method
+vm =
client.getVirtualMachineApi().getVirtualMachine(vm.getId());
+ListInteger ports =
Ints.asList(templateOptions.getInboundPorts());
+if (capabilities.getCloudStackVersion().startsWith(2)) {
+ logger.debug( setting up IP
+1 - seems saner to me. =)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/328#issuecomment-38753246
[jclouds » jclouds
#960](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/960/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
[jclouds-pull-requests
#704](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/704/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/327#issuecomment-38764216
[
https://issues.apache.org/jira/browse/JCLOUDS-509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lahiru Sandaruwan updated JCLOUDS-509:
--
Attachment: jclouds_patch.diff
Attaching the patch. This includes update of AWS API
Case insensitive now.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/312#issuecomment-38771519
70 matches
Mail list logo
