[jclouds] Azureblobs live-test Bug Fix (#336)

2014-03-31 Thread Bhathiya
Some Azureblob live- test fail when the System User has name with Upper case letters.Can simulated by running live test with -Duser.name=BhathiyaHS (Any name with upper case letters). You can merge this Pull Request by running: git pull https://github.com/hsbhathiya/jclouds master Or you

[jira] [Created] (JCLOUDS-520) Azureblob live-test fails when the system username contain uppercase letter.

2014-03-31 Thread Bhathiya Supun (JIRA)
Bhathiya Supun created JCLOUDS-520: -- Summary: Azureblob live-test fails when the system username contain uppercase letter. Key: JCLOUDS-520 URL: https://issues.apache.org/jira/browse/JCLOUDS-520

[jira] [Updated] (JCLOUDS-520) Azureblob live-test fails when the system username contain uppercase letters.

2014-03-31 Thread Bhathiya Supun (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bhathiya Supun updated JCLOUDS-520: --- Description: This can be simulated by running live test with -Duser.name=BhathiyaHS

[jira] [Commented] (JCLOUDS-520) Azureblob live-test fails when the system username contain uppercase letters.

2014-03-31 Thread Bhathiya Supun (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13954993#comment-13954993 ] Bhathiya Supun commented on JCLOUDS-520:

Re: [jclouds] Azureblobs live-test Bug Fix (#336)

2014-03-31 Thread Bhathiya
When I replace 'prefix' with ' CONTAINER_PREFIX ' all the test cases succeded.Before that there was a error in ' testCreateContainer ' and build failed. testCreateContainer java.lang.IllegalArgumentException: Validation on '[java.lang.String arg0,

Re: [jclouds] Azureblobs live-test Bug Fix (#336)

2014-03-31 Thread BuildHive
[jclouds » jclouds #979](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/979/) SUCCESS This pull request looks good [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub:

Jenkins build is back to stable : jclouds » jclouds #979

2014-03-31 Thread BuildHive
See https://buildhive.cloudbees.com/job/jclouds/job/jclouds/979/changes

Re: [jclouds] Azureblobs live-test Bug Fix (#336)

2014-03-31 Thread CloudBees pull request builder plugin
[jclouds-java-7-pull-requests #1191](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1191/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/336#issuecomment-39061836

Jenkins build is still unstable: jclouds » jclouds-karaf #843

2014-03-31 Thread BuildHive
See https://buildhive.cloudbees.com/job/jclouds/job/jclouds-karaf/changes

[jira] [Commented] (JCLOUDS-511) Incorrect feature definition: jclouds-rackspace-cloudblockstorage-uk/us

2014-03-31 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13955201#comment-13955201 ] ASF subversion and git services commented on JCLOUDS-511: - Commit

[jclouds-karaf] JCLOUDS-511: Correcting features with dependency-only bundles (#41)

2014-03-31 Thread Andrew Phillips
Backport of https://github.com/jclouds/jclouds-karaf/pull/40 to 1.7.x You can merge this Pull Request by running: git pull https://github.com/jclouds/jclouds-karaf JCLOUDS-511-1.7.x Or you can view, comment on it, or merge it online at: https://github.com/jclouds/jclouds-karaf/pull/41 --

[jira] [Commented] (JCLOUDS-511) Incorrect feature definition: jclouds-rackspace-cloudblockstorage-uk/us

2014-03-31 Thread Andrew Phillips (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13955230#comment-13955230 ] Andrew Phillips commented on JCLOUDS-511: - 1.7.x backport PR:

Re: [jclouds-karaf] JCLOUDS-511: Correcting features with dependency-only bundles (#41)

2014-03-31 Thread Andrew Phillips
Waiting for the PR builders... --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-karaf/pull/41#issuecomment-39098191

Jenkins build is still unstable: jclouds » jclouds-karaf #844

2014-03-31 Thread BuildHive
See https://buildhive.cloudbees.com/job/jclouds/job/jclouds-karaf/changes

Re: [jclouds-karaf] JCLOUDS-511: Correcting features with dependency-only bundles (#41)

2014-03-31 Thread BuildHive
[jclouds » jclouds-karaf #844](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-karaf/844/) UNSTABLE Looks like there's a problem with this pull request [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub:

Re: [jclouds-karaf] JCLOUDS-511: Correcting features with dependency-only bundles (#41)

2014-03-31 Thread CloudBees pull request builder plugin
[jclouds-karaf-pull-requests #53](https://jclouds.ci.cloudbees.com/job/jclouds-karaf-pull-requests/53/) UNSTABLE Looks like there's a problem with this pull request --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-karaf/pull/41#issuecomment-39104028

Re: [jclouds-karaf] JCLOUDS-511: Correcting features with dependency-only bundles (#41)

2014-03-31 Thread Andrew Phillips
jclouds » jclouds-karaf #844 UNSTABLE jclouds-karaf-pull-requests #53 UNSTABLE Oh oh...looks like https://github.com/jclouds/jclouds/pull/330 [broke

[jclouds-site] Link to how to write a guest blog post (#67)

2014-03-31 Thread Everett Toews
You can merge this Pull Request by running: git pull https://github.com/rackerlabs/jclouds-site guest-post Or you can view, comment on it, or merge it online at: https://github.com/jclouds/jclouds-site/pull/67 -- Commit Summary -- * Link to how to write a guest blog post -- File

Re: [jclouds-site] Link to how to write a guest blog post (#67)

2014-03-31 Thread CloudBees pull request builder plugin
[jclouds-site-pull-requests #222](https://jclouds.ci.cloudbees.com/job/jclouds-site-pull-requests/222/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/67#issuecomment-39111665

[jira] [Commented] (JCLOUDS-516) Support ssh-agent authentication to access created nodes

2014-03-31 Thread Andrew Phillips (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13955380#comment-13955380 ] Andrew Phillips commented on JCLOUDS-516: - It appears there are at least *some*

Re: [jclouds-site] Link to how to write a guest blog post (#67)

2014-03-31 Thread Andrew Phillips
@@ -3,6 +3,8 @@ title: Blog News --- +pa href=https://wiki.apache.org/jclouds/How%20to%20Contribute%20Documentation;Write a guest post for this blog!/a/p [minor] Perhaps just Write a guest post!? I guess it's obvious that it's for this blog? --- Reply to this email directly or

Re: [jclouds-site] Link to how to write a guest blog post (#67)

2014-03-31 Thread Andrew Phillips
One minor text comment, otherwise +1 - looks good to me! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/67#issuecomment-39114344

Re: [jclouds] Azureblobs live-test Bug Fix (#336)

2014-03-31 Thread Shri Javadekar
@@ -87,7 +87,9 @@ public void testListContainers() throws Exception { public void testCreateContainer() throws Exception { boolean created = false; while (!created) { - privateContainer = prefix + new SecureRandom().nextInt(); + + privateContainer =

Re: [jclouds] Azureblobs live-test Bug Fix (#336)

2014-03-31 Thread Shri Javadekar
@@ -87,7 +87,9 @@ public void testListContainers() throws Exception { public void testCreateContainer() throws Exception { boolean created = false; while (!created) { - privateContainer = prefix + new SecureRandom().nextInt(); + + privateContainer =

Re: [jclouds] Azureblobs live-test Bug Fix (#336)

2014-03-31 Thread Andrew Phillips
Thanks, @hsbhathiya! As @shrinandj pointed out, you can remove the parentheses around `(CONTAINER_PREFIX + new SecureRandom().nextInt())`. If you could update the PR, we can get this merged. --- Reply to this email directly or view it on GitHub:

Re: [jclouds-labs-openstack] Updates to Rackspace Cloud Files CDN (#85)

2014-03-31 Thread Jeremy Daggett
return this; } public static class Builder { - /** @see UpdateCDNContainerOptions#ttl */ + /** + * @see UpdateCDNContainerOptions#ttl That comment about the @see tag was in some of the model classes. If you look through the code base, most of the Options

Re: [jclouds-labs-openstack] Updates to Rackspace Cloud Files CDN (#85)

2014-03-31 Thread Jeremy Daggett
@@ -86,6 +117,45 @@ public void testGet() throws Exception { } } + /** +* By default, this method is disabled due to daily purge limitations of 25 objects per day. +*/ + @Test(enabled = false) Because you can only purge 25 objects per day, I felt that this test

Re: [jclouds-site] Link to how to write a guest blog post (#67)

2014-03-31 Thread CloudBees pull request builder plugin
[jclouds-site-pull-requests #223](https://jclouds.ci.cloudbees.com/job/jclouds-site-pull-requests/223/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/67#issuecomment-39124551

Re: [jclouds-labs-openstack] Updates to Rackspace Cloud Files CDN (#85)

2014-03-31 Thread Jeremy Daggett
@@ -86,6 +117,45 @@ public void testGet() throws Exception { } } + /** +* By default, this method is disabled due to daily purge limitations of 25 objects per day. +*/ + @Test(enabled = false) + public void testPurgeObject() throws Exception { + for

Re: [jclouds-labs-openstack] Updates to Rackspace Cloud Files CDN (#85)

2014-03-31 Thread Jeremy Daggett
+ MockWebServer server = mockOpenStackServer(); + server.enqueue(addCommonHeaders(new MockResponse().setBody(stringFromResource(/access.json; + server.enqueue(addCommonHeaders(new MockResponse().setResponseCode(404).setBody(stringFromResource(/cdn_container_list.json;

Re: [jclouds-site] Link to how to write a guest blog post (#67)

2014-03-31 Thread jclouds-commentator
Go to http://6a21acc6345d125ffce2-18de16e2feac29e299a226ea14cb6219.r45.cf1.rackcdn.com/ to review your changes. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/67#issuecomment-39124791

Re: [jclouds-site] Link to how to write a guest blog post (#67)

2014-03-31 Thread CloudBees pull request builder plugin
[jclouds-site-pull-requests #224](https://jclouds.ci.cloudbees.com/job/jclouds-site-pull-requests/224/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/67#issuecomment-39126125

Re: [jclouds-site] Link to how to write a guest blog post (#67)

2014-03-31 Thread jclouds-commentator
Go to http://ddd5ff4496aa02ab1791-50dfd0f8239b5549d8cdb74ee270c5e8.r76.cf1.rackcdn.com/ to review your changes. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/67#issuecomment-39126371

Re: [jclouds-site] Link to how to write a guest blog post (#67)

2014-03-31 Thread Everett Toews
Closed #67. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/67

Re: [jclouds-site] Link to how to write a guest blog post (#67)

2014-03-31 Thread Andrew Phillips
Merged and deployed. Thanks, @everett-toews! +1 - looks good to me. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/67#issuecomment-39127080

Re: [jclouds] JCLOUDS-515: Don't require availability zone when creating volumes in cinder (#327)

2014-03-31 Thread Everett Toews
+1 I'm okay with this. I suspect the value is set that way because of a driver in Cinder. I could see this being the case for other Cinder driver's as well. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/327#issuecomment-39128245

[jira] [Commented] (JCLOUDS-515) Cinder volume create does not require availability zone

2014-03-31 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=1395#comment-1395 ] ASF subversion and git services commented on JCLOUDS-515: - Commit

Re: [jclouds] JCLOUDS-515: Don't require availability zone when creating volumes in cinder (#327)

2014-03-31 Thread Everett Toews
Merged to master and 1.7.x. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/327#issuecomment-39129202

Re: [jclouds] JCLOUDS-515: Don't require availability zone when creating volumes in cinder (#327)

2014-03-31 Thread Everett Toews
Closed #327. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/327

[jira] [Resolved] (JCLOUDS-515) Cinder volume create does not require availability zone

2014-03-31 Thread Everett Toews (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Everett Toews resolved JCLOUDS-515. --- Resolution: Fixed Cinder volume create does not require availability zone

Re: [jclouds] Azureblobs live-test Bug Fix (#336)

2014-03-31 Thread BuildHive
[jclouds » jclouds #980](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/980/) SUCCESS This pull request looks good [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub:

[jira] [Commented] (JCLOUDS-515) Cinder volume create does not require availability zone

2014-03-31 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13955547#comment-13955547 ] ASF subversion and git services commented on JCLOUDS-515: - Commit

Re: [jclouds] Azureblobs live-test Bug Fix (#336)

2014-03-31 Thread CloudBees pull request builder plugin
[jclouds-pull-requests #722](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/722/) UNSTABLE Looks like there's a problem with this pull request --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/336#issuecomment-39129949

[jira] [Commented] (JCLOUDS-329) Missing Open stack functionality nova

2014-03-31 Thread Everett Toews (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13955562#comment-13955562 ] Everett Toews commented on JCLOUDS-329: --- These fixes are in 1.7.x. Missing Open

[jira] [Resolved] (JCLOUDS-329) Missing Open stack functionality nova

2014-03-31 Thread Everett Toews (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Everett Toews resolved JCLOUDS-329. --- Resolution: Not a Problem Fix Version/s: 1.7.0 Missing Open stack functionality

Re: [jclouds] Azureblobs live-test Bug Fix (#336)

2014-03-31 Thread CloudBees pull request builder plugin
[jclouds-java-7-pull-requests #1192](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1192/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/336#issuecomment-39130256

[jira] [Commented] (JCLOUDS-154) key [openstack-nova] not in the list of providers or apis: {}

2014-03-31 Thread Everett Toews (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13955567#comment-13955567 ] Everett Toews commented on JCLOUDS-154: --- Is this still a problem Shankar? If I

[jira] [Commented] (JCLOUDS-493) Extend TemplateOptions and CreateServerOptions to support fixed private IPs and more

2014-03-31 Thread Everett Toews (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13955580#comment-13955580 ] Everett Toews commented on JCLOUDS-493: --- Should this issue be closed? Extend

[jira] [Commented] (JCLOUDS-493) Extend TemplateOptions and CreateServerOptions to support fixed private IPs and more

2014-03-31 Thread Jeffrey Nguyen (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13955591#comment-13955591 ] Jeffrey Nguyen commented on JCLOUDS-493: Hi Everett, As per my comments on this

Jenkins build is back to stable : jclouds-1.7.x-branch #57

2014-03-31 Thread jenkins-no-reply
See https://jclouds.ci.cloudbees.com/job/jclouds-1.7.x-branch/57/changes

Jenkins build is back to normal : jclouds-labs-google-1.7.x-branch #76

2014-03-31 Thread jenkins-no-reply
See https://jclouds.ci.cloudbees.com/job/jclouds-labs-google-1.7.x-branch/76/

Jenkins build is back to normal : jclouds-labs-aws-1.7.x-branch » jcloud iam api #32

2014-03-31 Thread jenkins-no-reply
See https://jclouds.ci.cloudbees.com/job/jclouds-labs-aws-1.7.x-branch/org.apache.jclouds.labs$iam/32/

Jenkins build is back to normal : jclouds-labs-1.7.x-branch » jclouds virtualbox api #36

2014-03-31 Thread jenkins-no-reply
See https://jclouds.ci.cloudbees.com/job/jclouds-labs-1.7.x-branch/org.apache.jclouds.labs$virtualbox/36/

Jenkins build is back to normal : jclouds-labs-openstack-1.7.x-branch » jclouds rackspace-autoscale api #42

2014-03-31 Thread jenkins-no-reply
See https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-1.7.x-branch/org.apache.jclouds.labs$rackspace-autoscale/42/

Build failed in Jenkins: jclouds-labs-openstack » jclouds openstack-glance api #317

2014-03-31 Thread jenkins-no-reply
See https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack/org.apache.jclouds.labs$openstack-glance/317/ -- [...truncated 2230 lines...] Downloading:

Build failed in Jenkins: jclouds-labs-openstack #317

2014-03-31 Thread jenkins-no-reply
See https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack/317/ -- [...truncated 2378 lines...] Downloaded: http://repo.cloudbees.com/content/repositories/central/org/apache/maven/doxia/doxia-module-fml/1.0/doxia-module-fml-1.0.jar (19 KB at 696.6

Re: [jclouds] Refactor SoftLayer CCI support (#296)

2014-03-31 Thread Ignasi Barrera
+ } + + /** +* Builds a Json string suitable for sending to the softlayer api +* +* @param virtualGuest +* @return String +*/ + String buildJson(VirtualGuest virtualGuest) { + TemplateObject templateObject = null; + String hostname =

Re: [jclouds] Refactor SoftLayer CCI support (#296)

2014-03-31 Thread Ignasi Barrera
+ String buildJson(VirtualGuest virtualGuest) { + TemplateObject templateObject = null; + String hostname = checkNotNull(virtualGuest.getHostname(), hostname); + String domain = checkNotNull(virtualGuest.getDomain(), domain); + int startCpus =

Re: [jclouds] Refactor SoftLayer CCI support (#296)

2014-03-31 Thread Ignasi Barrera
+ .transform(new FunctionVirtualGuestBlockDevice, BlockDevice() { + @Override + public BlockDevice apply(VirtualGuestBlockDevice input) { +return new BlockDevice(input.getDevice(), input.getVirtualDiskImage().getCapacity());

Re: [jclouds] Refactor SoftLayer CCI support (#296)

2014-03-31 Thread Ignasi Barrera
.build(); } private IterableString createIso3166Codes(Address address) { - if (address == null) return ImmutableSet.String of(); + if (address== null) return ImmutableSet.String of(); [minor] Add the space back again --- Reply to

Re: [jclouds-labs-openstack] Updates to Rackspace Cloud Files CDN (#85)

2014-03-31 Thread Jeremy Daggett
+ } + + public void testUpdate() throws Exception { + for (String regionId : regions) { + UpdateCDNContainerOptions opts = new UpdateCDNContainerOptions(); + opts.ttl(1234567); + opts.logRetention(true); + opts.enabled(false); + +

Re: [jclouds] Refactor SoftLayer CCI support (#296)

2014-03-31 Thread Ignasi Barrera
+return input.getMountType().equals(Disk); + } + }) + .transform(new FunctionVirtualGuestBlockDevice, Volume() { + @Override + public Volume

Re: [jclouds-examples] Fixes broken README links (#36)

2014-03-31 Thread Everett Toews
Closed #36. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-examples/pull/36

Re: [jclouds-examples] Fixes broken README links (#36)

2014-03-31 Thread Everett Toews
Merged. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-examples/pull/36#issuecomment-39141829

Re: [jclouds] Refactor SoftLayer CCI support (#296)

2014-03-31 Thread Ignasi Barrera
+@Singleton +public class VirtualGuestToImage implements FunctionVirtualGuest, Image { + + private static final String CENTOS = CENTOS; + private static final String DEBIAN = DEBIAN; + private static final String RHEL = REDHAT; + private static final String UBUNTU = UBUNTU; +

Re: [jclouds-labs-openstack] Updates to Rackspace Cloud Files CDN (#85)

2014-03-31 Thread Jeremy Daggett
@@ -105,34 +123,64 @@ public void testListWithOptions() throws Exception { } } - public void testEnableAndDisable() throws Exception { + public void testListWithOptionsFail() throws Exception { Updating test method to **testListWithOptionsIsEmpty()** --- Reply to this

Re: [jclouds] Refactor SoftLayer CCI support (#296)

2014-03-31 Thread Ignasi Barrera
+ else if (description.startsWith(VYATTACE)) return OsFamily.LINUX; +} +return OsFamily.UNRECOGNIZED; + } + }; + } + + @Override + public Image apply(VirtualGuest from) { + + checkNotNull(from, from); + ImageBuilder

Re: [jclouds] Refactor SoftLayer CCI support (#296)

2014-03-31 Thread Ignasi Barrera
+import com.google.common.base.Splitter; +import com.google.common.collect.Iterables; + +import static com.google.common.collect.Iterables.getLast; + +/** + * @author Andrea Turli + */ +public class OperatingSystems { + + public static FunctionString, Integer bits() { + return

Re: [jclouds] Refactor SoftLayer CCI support (#296)

2014-03-31 Thread Ignasi Barrera
+ } + }; + } + + private static String parseVersion(String version) { + if(version.contains(-)) { + String rawVersion = version.substring(0, + version.lastIndexOf(-)); + if(Iterables.size(Splitter.on(.).split(rawVersion)) == 3) { +

Re: [jclouds] Refactor SoftLayer CCI support (#296)

2014-03-31 Thread Ignasi Barrera
@@ -49,6 +53,7 @@ public class SoftLayerTemplateOptions extends TemplateOptions implements Cloneable { protected String domainName = jclouds.org; + protected OptionalListInteger blockDevices = Optional.absent(); Add this variable to the `copyTo` method too, so the object is

Re: [jclouds-labs-openstack] Updates to Rackspace Cloud Files CDN (#85)

2014-03-31 Thread CloudBees pull request builder plugin
[jclouds-labs-openstack-pull-requests #191](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/191/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/85#issuecomment-39143472

Re: [jclouds] Refactor SoftLayer CCI support (#296)

2014-03-31 Thread Ignasi Barrera
Password pw = get(result.getOperatingSystem().getPasswords(), 0); return new NodeAndInitialCredentialsVirtualGuest(result, result.getId() + , LoginCredentials.builder().user(pw.getUsername()).password( pw.getPassword()).build()); } - private

Re: [jclouds] Refactor SoftLayer CCI support (#296)

2014-03-31 Thread Ignasi Barrera
+ for (int i = 0; i blockDeviceCapacities.size(); i++) { + if (i 0) { devicePosition = i + 1; } + blockDevices.add(VirtualGuestBlockDevice.builder() +.device(devicePosition + ) +.diskImage(VirtualDiskImage.builder() +

Re: [jclouds] Refactor SoftLayer CCI support (#296)

2014-03-31 Thread Ignasi Barrera
+List? extends Volume volumes2 = h2.getVolumes(); +ComparisonChain comparisonChain = ComparisonChain.start().compare(getCores(h1), getCores(h2)) +.compare(h1.getRam(), h2.getRam()) +.compare(getSpace(h1), getSpace(h2)) +

Re: [jclouds] JCLOUDS-317: Add missing states to Nova v2 Server (#334)

2014-03-31 Thread Everett Toews
Can you please put the STOPPED state back? I realize the OpenStack doesn't return this but that state has been in jclouds for a long time and some code is bound to depend on it. @Deprecated STOPPED and add a comment telling users to change it to SHUTOFF. --- Reply to this email directly or

Re: [jclouds] Refactor SoftLayer CCI support (#296)

2014-03-31 Thread Ignasi Barrera
+ + // list private images and transform them to OperatingSystem + SetVirtualGuestBlockDeviceTemplateGroup privateImages = api.getAccountApi().getBlockDeviceTemplateGroups(); + MapString, SoftwareDescription privateImagesSoftwareDescriptions =

[jclouds-site] Update stale BlobStore docs (#68)

2014-03-31 Thread Jeremy Daggett
This PR is to clean up the BlobStore Start Guide with current information and fix some minor typos. jekyll was run locally to verify these changes. You can merge this Pull Request by running: git pull https://github.com/rackerlabs/jclouds-site update-stale-docs Or you can view, comment on

Re: [jclouds-site] Update stale BlobStore docs (#68)

2014-03-31 Thread CloudBees pull request builder plugin
[jclouds-site-pull-requests #225](https://jclouds.ci.cloudbees.com/job/jclouds-site-pull-requests/225/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/68#issuecomment-39145122

Re: [jclouds-site] Update stale BlobStore docs (#68)

2014-03-31 Thread jclouds-commentator
Go to http://82cb4d27028b5f2da720-a5885cc8c368884850298f986087b419.r37.cf1.rackcdn.com/ to review your changes. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/68#issuecomment-39145294

Re: [jclouds] Refactor SoftLayer CCI support (#296)

2014-03-31 Thread Ignasi Barrera
@@ -236,28 +414,34 @@ public void destroyNode(String id) { VirtualGuest guest = getNode(id); if (guest == null) return; - - if (guest.getBillingItemId() == -1) - throw new IllegalStateException(String.format(no billing item for guest(%s) so we cannot

Re: [jclouds] Refactor SoftLayer CCI support (#296)

2014-03-31 Thread Ignasi Barrera
public class SoftLayerHttpApiModule extends HttpApiModuleSoftLayerApi { + public SoftLayerHttpApiModule() { + } This constructor isn't needed. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/296/files#r11138265

Re: [jclouds] Refactor SoftLayer CCI support (#296)

2014-03-31 Thread Ignasi Barrera
*/ public class SoftLayerParserModule extends AbstractModule { @Override protected void configure() { - bind(DateAdapter.class).to(Iso8601DateAdapter.class); + bind(GsonModule.DateAdapter.class).to(GsonModule.Iso8601DateAdapter.class); Any reason for the import

Re: [jclouds] Refactor SoftLayer CCI support (#296)

2014-03-31 Thread Ignasi Barrera
@@ -107,13 +176,30 @@ protected ConcreteBuilder self() { private final String country; private final String state; private final String description; + private final int accountId; + private final String address; Add missing `@Named(address1)` --- Reply to this email

Re: [jclouds] Refactor SoftLayer CCI support (#296)

2014-03-31 Thread Ignasi Barrera
}) - protected Address(int id, String country, @Nullable String state, @Nullable String description) { - this.id = id; - this.country = checkNotNull(emptyToNull(country), country cannot be null or empty: + country); + protected Address(int id, String country, @Nullable

Re: [jclouds] Refactor SoftLayer CCI support (#296)

2014-03-31 Thread Ignasi Barrera
+ this.template = template; + return this; + } + + public ContainerVirtualGuestConfigurationOption build() { + return new ContainerVirtualGuestConfigurationOption(productItemPrice, template); + } + + public Builder

Re: [jclouds] Refactor SoftLayer CCI support (#296)

2014-03-31 Thread Ignasi Barrera
+ } + + public Builder fromContainerVirtualGuestConfigurationOption(ContainerVirtualGuestConfigurationOption in) { + return this + .productItemPrice(in.getProductItemPrice()) + .template(in.getTemplate()); + } + } + + private

Re: [jclouds] Refactor SoftLayer CCI support (#296)

2014-03-31 Thread Ignasi Barrera
} @Override public String toString() { - return string().toString(); + return OperatingSystem{ + + id=' + id + '\'' + [minor] Why single-quoting the id? --- Reply to this email directly or view it on GitHub:

Re: [jclouds] Refactor SoftLayer CCI support (#296)

2014-03-31 Thread Ignasi Barrera
this.id = id; this.description = description; - this.units = units; - this.capacity = capacity; - this.prices = prices == null ? ImmutableSet.ProductItemPriceof() : ImmutableSet.copyOf(prices); - this.categories = categories == null ?

Re: [jclouds] Refactor SoftLayer CCI support (#296)

2014-03-31 Thread Ignasi Barrera
- @ConstructorProperties({ - id, description, units, capacity, prices, categories - }) - protected ProductItem(int id, @Nullable String description, @Nullable String units, @Nullable Float capacity, @Nullable SetProductItemPrice prices, @Nullable SetProductItemCategory

Re: [jclouds] Refactor SoftLayer CCI support (#296)

2014-03-31 Thread Ignasi Barrera
this.hourlyRecurringFee = hourlyRecurringFee; + this.recurringFee = recurringFee; Add null check. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/296/files#r11138709

Re: [jclouds] Refactor SoftLayer CCI support (#296)

2014-03-31 Thread Ignasi Barrera
- @ConstructorProperties({ - id, itemId, recurringFee, hourlyRecurringFee, item, categories - }) - protected ProductItemPrice(int id, long itemId, @Nullable Float recurringFee, @Nullable Float hourlyRecurringFee, @Nullable ProductItem item, @Nullable

Re: [jclouds] Refactor SoftLayer CCI support (#296)

2014-03-31 Thread Ignasi Barrera
+ @Nullable String requiredUser, @Nullable String version, int controlPanel, + String upgradeSoftwareDescriptionId, String upgradeSwDescId, String virtualLicense, + String virtualizationPlatform)

Re: [jclouds] Refactor SoftLayer CCI support (#296)

2014-03-31 Thread Ignasi Barrera
+ this.id = id; + this.softwareDescription = softwareDescription; + this.softwareDescriptionId = softwareDescriptionId; + } + + public int getId() { + return this.id; + } + + @Nullable + public SoftwareDescription getSoftwareDescription() { + return

Re: [jclouds] Refactor SoftLayer CCI support (#296)

2014-03-31 Thread Ignasi Barrera
+ this.softwareDescriptionId = softwareDescriptionId; + } + + public int getId() { + return this.id; + } + + @Nullable + public SoftwareDescription getSoftwareDescription() { + return this.softwareDescription; + } + + /** +* @return A longer location

Re: [jclouds] Refactor SoftLayer CCI support (#296)

2014-03-31 Thread Ignasi Barrera
+ @ConstructorProperties({ + id, uuid, capacity, units, typeId, description, name, storageRepositoryId, softwareReferences + }) + public VirtualDiskImage(int id, String uuid, float capacity, String units, int typeId, String description, + String

Re: [jclouds] Refactor SoftLayer CCI support (#296)

2014-03-31 Thread Ignasi Barrera
}) protected VirtualGuest(int accountId, @Nullable Date createDate, boolean dedicatedAccountHostOnly, @Nullable String domain, @Nullable String fullyQualifiedDomainName, @Nullable String hostname, int id, @Nullable Date lastVerifiedDate,

Re: [jclouds] Refactor SoftLayer CCI support (#296)

2014-03-31 Thread Ignasi Barrera
+ @Nullable + public SoftwareDescription getSoftwareDescription() { + return this.softwareDescription; + } + + @Override + public int hashCode() { + return Objects.hashCode(id); + } + + @Override + public boolean equals(Object obj) { + if (this == obj)

Re: [jclouds] Refactor SoftLayer CCI support (#296)

2014-03-31 Thread Ignasi Barrera
+ private final int groupId; + private final String units; + private final VirtualDiskImage diskImage; + + @ConstructorProperties({ + id, device, diskImageId, diskSpace, groupId, units, diskImage + }) + protected VirtualGuestBlockDeviceTemplate(int id, String

Re: [jclouds] Refactor SoftLayer CCI support (#296)

2014-03-31 Thread Ignasi Barrera
+ private final SetVirtualGuestBlockDeviceTemplateGroup children; + private final SetVirtualGuestBlockDeviceTemplate blockDevices; + + @ConstructorProperties({ + id, name, globalIdentifier, statusId, accountId, parentId, summary, children, blockDevices + }) + protected

Re: [jclouds] Refactor SoftLayer CCI support (#296)

2014-03-31 Thread Ignasi Barrera
+ private final String name; + private final int port; + private final int speed; + private final String status; + + @ConstructorProperties({ + id, uuid, guestId, networkId, macAddress, maxSpeed, name, port, speed, + status + }) + protected

  1   2   >