...rationException but call still succeeds
Fixes https://issues.apache.org/jira/browse/JCLOUDS-594
Should probably be backported to 1.7.x as well
You can merge this Pull Request by running:
git pull https://github.com/ccustine/jclouds fixes/JCLOUDS-594
Or you can view, comment on it, or merge
[
https://issues.apache.org/jira/browse/JCLOUDS-594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14028966#comment-14028966
]
Chris Custine commented on JCLOUDS-594:
---
This wasn't hard to figure out :-) Fixed
[jclouds-pull-requests
#879](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/879/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/403#issuecomment-45849421
[jclouds-java-7-pull-requests
#1350](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1350/)
UNSTABLE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/403#issuecomment-45849606
Is it OK to succeed the call even if the operation the user has requested has
not been executed? I mean, when calling `suspendNode`, one should expect the
node to be suspended if nothing went wrong.
Also, do we want this behavior in all OpenStack providers?
---
Reply to this email directly or
See https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1215/changes
[jclouds » jclouds
#1215](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1215/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
...now let the server return the error.
This PR addressed the issues discussed on
https://github.com/jclouds/jclouds-labs-aws/pull/6
You can merge this Pull Request by running:
git pull https://github.com/rcoedo/jclouds-labs-aws upstream
Or you can view, comment on it, or merge it online at:
[jclouds » jclouds-labs-aws
#940](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-aws/940/)
SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
[jclouds-labs-aws-pull-requests
#17](https://jclouds.ci.cloudbees.com/job/jclouds-labs-aws-pull-requests/17/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-aws/pull/7#issuecomment-45879886
[
https://issues.apache.org/jira/browse/JCLOUDS-594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14029134#comment-14029134
]
Christopher Dancy commented on JCLOUDS-594:
---
Yea I saw the exception being
Closed #108.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/108#event-130750452
Just chiming in as I made the initial bug. If this could be back ported to at
least 1.7.3 that would be great.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/403#issuecomment-45899226
Christopher Dancy created JCLOUDS-596:
-
Summary: Add 'SUSPENDED' predicate to
org.jclouds.compute.predicates.NodePredicates
Key: JCLOUDS-596
URL: https://issues.apache.org/jira/browse/JCLOUDS-596
How ironic that this should be PR 404. You were waiting for that, eh,
@jdaggett? ;-)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/404#issuecomment-45913303
@@ -28,6 +28,7 @@
import java.util.Set;
import java.util.concurrent.BlockingQueue;
import java.util.concurrent.LinkedBlockingQueue;
+import java.util.regex.Pattern;
Do you need this import?
---
Reply to this email directly or view it on GitHub:
Added second commit to remove hard-coded strings inside
NodePredicates.name.toString methods which is just asking for a typo to pop.
Replaced hard-coded strings by calling their respective enum.toString() methods.
---
Reply to this email directly or view it on GitHub:
@@ -101,7 +102,8 @@ public MockResponse dispatch(RecordedRequest request)
throws InterruptedExceptio
* access.json or accessRackspace) for the declared service
* endpoints.
*/
- String newBody = new
[jclouds-pull-requests
#881](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/881/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/405#issuecomment-45914352
[jclouds-pull-requests
#880](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/880/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/404#issuecomment-45914959
[jclouds-java-7-pull-requests
#1351](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1351/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/404#issuecomment-45915690
[jclouds-java-7-pull-requests
#1352](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1352/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/405#issuecomment-45915689
[jclouds-java-7-pull-requests
#1353](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1353/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/405#issuecomment-45916178
[jclouds » jclouds
#1216](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1216/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
[jclouds-pull-requests
#882](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/882/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/405#issuecomment-45917597
I agree that the optional is more correct. I am also ok with backporting this.
But we should probably send an email to user@jclouds[...]?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/392#issuecomment-45922389
[jclouds » jclouds
#1217](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1217/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
@nacx The Optional on the server admin extension will make this behave on any
openstack provider (providers without admin extension will fallback to throw
the UnsupportedOperationException). I didn't grok the first part of what you
said re: succeeding even if the call didn't execute, maybe that
Oh absolutely... After mucking around with availability zones, regions, etc
for a bit, I have my doubts that there is much use of availability zones api by
current users of jclouds (at least with openstack providers). Once I get my
head around the bigger picture of regions/azs I think there
Can you please a test or tests for this new predicate to
AtomicNodePredicatesTest?
You'll be able to use the tests at the bottom of that class as a template for
your test.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/405#issuecomment-45931104
Just to clarify: the call DOES execute, and succeeds, but immediately throws an
exception afterward. When working with more than 1 vm/id the first of the set
succeeds but again immediately throws exception. All other vm/id's in set are
then ignored and/or not executed.
---
Reply to this email
@nacx I'm not following either. The original code was...bizarre. It threw an
UOE no matter what. Even if the Admin Extension was supported.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/403#issuecomment-45933049
Should be good to go. Nothing special just copied one of the previous testers
that fails when node is not running.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/405#issuecomment-45936032
[jclouds-pull-requests
#883](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/883/) UNSTABLE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/405#issuecomment-45938634
[jclouds-java-7-pull-requests
#1354](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1354/)
UNSTABLE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/405#issuecomment-45938773
@everett-toews Yeah I think the bug is the result of a bad PR merge or
something (the original code dates to 5/2012)... I didn't go back to analyze
it in detail but something was definitely amiss. Now all of that aside, are
you guys saying that you don't follow the fix, or the original?
---
[jclouds » jclouds
#1218](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1218/) UNSTABLE
Looks like there's a problem with this pull request
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
See https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1218/changes
Fix looks good to me
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/403#issuecomment-45942629
This was due to a misunderstanding, and lack of testing locally, for a code
block I assumed was fairly straight forward. Test passes locally and NOW should
be good to go ;)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/405#issuecomment-45944766
[jclouds-labs-pull-requests
#176](https://jclouds.ci.cloudbees.com/job/jclouds-labs-pull-requests/176/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/57#issuecomment-45945836
[jclouds » jclouds-labs
#1158](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs/1158/)
SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
Fix looks good. I didn't quite follow what Ignasi was trying to say in his
first question.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/403#issuecomment-45949451
[jclouds-pull-requests
#884](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/884/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/405#issuecomment-45948778
[jclouds-java-7-pull-requests
#1355](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1355/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/405#issuecomment-45948992
See https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1219/changes
[jclouds » jclouds
#1219](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1219/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
+1
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/405#issuecomment-45952583
@rcoedo Sorry to reverse my opinion on this, but I created equivalent live
tests and do not believe the Glacier error messages are useful enough to remove
this functionality. The too long vault name delivers something readable but
the empty and invalid characters do not as shown by this gist:
Andrew Gaul created JCLOUDS-597:
---
Summary: Use Guava HashCode to represent Content-MD5
Key: JCLOUDS-597
URL: https://issues.apache.org/jira/browse/JCLOUDS-597
Project: jclouds
Issue Type:
Sure, no problem.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-aws/pull/7#issuecomment-45956506
Closed #7.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-aws/pull/7#event-130951791
Closed #384.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/384#event-130960566
[
https://issues.apache.org/jira/browse/JCLOUDS-597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14029974#comment-14029974
]
ASF subversion and git services commented on JCLOUDS-597:
-
Commit
Ahh, I think I almost caused a who's on first moment. ;-)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/403#issuecomment-45960561
See https://jclouds.ci.cloudbees.com/job/jclouds/2632/changes
See https://jclouds.ci.cloudbees.com/job/jclouds-labs-google/147/
--
[...truncated 2615 lines...]
Downloading:
http://repo.cloudbees.com/content/repositories/central/org/apache/maven/surefire/surefire-testng/2.17/surefire-testng-2.17.jar
Downloading:
See https://jclouds.ci.cloudbees.com/job/jclouds-1.7.x-branch/90/changes
Changes:
[Andrew Gaul] JCLOUDS-597: HashCode methods for Content-MD5
--
[...truncated 13000 lines...]
Starting test
See https://jclouds.ci.cloudbees.com/job/jclouds-labs-aws/106/
--
[...truncated 3105 lines...]
[pool-10-thread-5] Test
testGetWhenResponseIs404(org.jclouds.iam.features.RolePolicyApiExpectTest)
succeeded: 2009ms
Test suite progress: tests succeeded: 21,
See https://jclouds.ci.cloudbees.com/job/jclouds-labs-aws/106/
--
[...truncated 3105 lines...]
[pool-10-thread-5] Test
testGetWhenResponseIs404(org.jclouds.iam.features.RolePolicyApiExpectTest)
succeeded: 2009ms
Test suite progress: tests succeeded: 21,
Andrew Gaul created JCLOUDS-598:
---
Summary: Atmos ParseSystemMetadataFromHeaders parses blob hash
incorrectly
Key: JCLOUDS-598
URL: https://issues.apache.org/jira/browse/JCLOUDS-598
Project: jclouds
[
https://issues.apache.org/jira/browse/JCLOUDS-598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14030052#comment-14030052
]
Shri Javadekar commented on JCLOUDS-598:
Thanks for filing this Andrew. I'll take
See
https://jclouds.ci.cloudbees.com/job/jclouds-labs/org.apache.jclouds.labs$virtualbox/498/
--
[INFO]
[INFO]
See https://jclouds.ci.cloudbees.com/job/jclouds-labs/498/
--
[...truncated 5344 lines...]
Downloading:
http://repo.cloudbees.com/content/repositories/central/org/apache/commons/commons-parent/22/commons-parent-22.pom
Downloaded:
See https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack/372/
--
[...truncated 1189 lines...]
Test suite progress: tests succeeded: 57, failed: 0, skipped: 0.
Starting test
Erm...yes...that indeed looks like weird original code. Fix looks good to me,
too...but do we perhaps need a test for this? Something like
`suspendWithExtensionPresentSucceeds` and `suspendWithoutExtensionThrowsUOE`?
jclouds-java-7-pull-requests #1350 UNSTABLE
Unrelates [test
but I created equivalent live tests and do not believe the Glacier error
messages are useful enough
to remove this functionality.
That Gist is interesting, indeed! The one (name too long) error message seems
to contain all the information we'd need:
```
java.lang.IllegalArgumentException:
@andrewgaul W.r.t. the `testIllegalCharacters` errors in your Gist, do you
think the server _would_ return the correct error if we were to provide the
correct signature?
It seems to me our signature-generator is perhaps not handling the unexpected
name properly, and that's masking the correct
@@ -141,6 +141,19 @@ public void testNodeRunningReturnsTrueWhenRunning() {
Assert.assertTrue(nodeRunning.apply(reference));
Assert.assertEquals(reference.get(), node);
}
+
+ @Test
+ public void testNodeSuspendedReturnsTrueWhenSuspended() {
+
@@ -141,6 +141,19 @@ public void testNodeRunningReturnsTrueWhenRunning() {
Assert.assertTrue(nodeRunning.apply(reference));
Assert.assertEquals(reference.get(), node);
}
+
+ @Test
+ public void testNodeSuspendedReturnsTrueWhenSuspended() {
+
@@ -141,6 +141,19 @@ public void testNodeRunningReturnsTrueWhenRunning() {
Assert.assertTrue(nodeRunning.apply(reference));
Assert.assertEquals(reference.get(), node);
}
+
+ @Test
+ public void testNodeSuspendedReturnsTrueWhenSuspended() {
+
@@ -67,7 +67,7 @@
* Provides synchronous access to availability zone features
*/
@Delegate
- AvailabilityZoneAPI getAvailabilityZoneApi(
+ Optional? extends AvailabilityZoneAPI getAvailabilityZoneApi(
Just a minor...why is this `...API` (caps) when pretty much everywhere
@@ -160,6 +160,8 @@ protected void configure() {
URI.create(http://docs.openstack.org/compute/ext/quotas-sets/api/v1.1;))
.put(URI.create(ExtensionNamespaces.VOLUME_TYPES),
URI.create(http://docs.openstack.org/compute/ext/volume_types/api/v1.1;))
@@ -23,7 +23,7 @@
import org.jclouds.openstack.v2_0.services.Extension;
@Beta
-@Extension(of = ServiceType.COMPUTE, namespace =
ExtensionNamespaces.ADMIN_ACTIONS)
+@Extension(of = ServiceType.COMPUTE, namespace =
ExtensionNamespaces.AVAILABILITY_ZONE)
public interface
@@ -56,6 +58,9 @@ public void setup() {
super.setup();
zone = Iterables.getLast(api.getConfiguredZones(), nova);
volumeOption = api.getVolumeExtensionForZone(zone);
+
+ Optional? extends AvailabilityZoneAPI availabilityZoneApi =
api.getAvailabilityZoneApi(zone);
@@ -236,7 +242,11 @@ public boolean apply(VolumeApi volumeApi) {
assertNotNull(attachments);
assertEquals(attachments.size(), before + 1);
-
assertEquals(volumeOption.get().get(testVolume.getId()).getStatus(),
Volume.Status.IN_USE);
+
for (String zoneId : zones) {
ServerApi serverApi = api.getServerApiForZone(zoneId);
+ Optional? extends AvailabilityZoneAPI azApi =
api.getAvailabilityZoneApi(zoneId);
+ availabilityZone = azApi.isPresent() ?
azApi.get().list().last().get().getName() :
@@ -84,8 +85,12 @@ protected Properties setupProperties() {
}
protected Server createServerInZone(String zoneId) {
+ return createServerInZone(zoneId, null);
Use `new CreateServerOptions()` instead of `null` here, or have a (nasty?)
if...then below that does something like
Thanks, @ccustine! Just wondering if this potentially affects any code in
https://github.com/jclouds/jclouds-labs-openstack that would also need to be
updated?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/392#issuecomment-45972612
@jdaggett: It looks like this has [been
merged](https://git-wip-us.apache.org/repos/asf?p=jclouds.git;a=commit;h=446671a2a7433f201b87f40e4d9960d80aa1f804)?
Also, please set up your GitHub repo to use your `@apache.org` address as the
committer email? Thanks!
// see https://issues.apache.org/jira/browse/JCLOUDS-570
Optional? extends Image image = tryFind(images, idPredicate);
- if (!image.isPresent()) {
- logger.warn(Image %s not found in the image cache. Trying to get
it directly..., imageId);
- // Note that
81 matches
Mail list logo
