Re: [jclouds-labs] Add vSphere support (#61)

2014-08-12 Thread BuildHive
[jclouds » jclouds-labs #1411](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs/1411/) SUCCESS This pull request looks good [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub:

Re: [jclouds-labs] Add vSphere support (#61)

2014-08-12 Thread CloudBees pull request builder plugin
[jclouds-labs-pull-requests #230](https://jclouds.ci.cloudbees.com/job/jclouds-labs-pull-requests/230/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/61#issuecomment-51878861

Jenkins build is still unstable: jclouds » jclouds-karaf #1187

2014-08-12 Thread BuildHive
See https://buildhive.cloudbees.com/job/jclouds/job/jclouds-karaf/1187/

Re: [jclouds-examples] Make CreateServer allow a user to execute jobs via SSH. (#59)

2014-08-12 Thread najtmar
@@ -52,35 +60,55 @@ /** * To get a service account and its private key see [TODO: write some * documentation on the website and put a link to it] -* -* The first argument (args[0]) must be your service account email address -* The second argument (args[1]) must a

Re: [jclouds-examples] Make CreateServer allow a user to execute jobs via SSH. (#59)

2014-08-12 Thread najtmar
@@ -108,8 +137,15 @@ private void createServer() throws RunNodesException, TimeoutException { .locationId(ZONE) .hardwareId(getHardware().getId()) .imageId(getImage().getId()) -.build(); - +

Re: [jclouds-labs-google] JCLOUDS-661: Add ability to create single port firewall rule from Securi... (#39)

2014-08-12 Thread BuildHive
[jclouds » jclouds-labs-google #1230](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-google/1230/) SUCCESS This pull request looks good [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub:

Re: [jclouds-labs-google] JCLOUDS-661: Add ability to create single port firewall rule from Securi... (#39)

2014-08-12 Thread CloudBees pull request builder plugin
[jclouds-labs-google-pull-requests #110](https://jclouds.ci.cloudbees.com/job/jclouds-labs-google-pull-requests/110/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/39#issuecomment-51892643

Re: [jclouds-examples] Make CreateServer allow a user to execute jobs via SSH. (#59)

2014-08-12 Thread najtmar
@@ -108,8 +137,15 @@ private void createServer() throws RunNodesException, TimeoutException { .locationId(ZONE) .hardwareId(getHardware().getId()) .imageId(getImage().getId()) -.build(); - +

Re: [jclouds-examples] Make CreateServer allow a user to execute jobs via SSH. (#59)

2014-08-12 Thread najtmar
@@ -52,35 +60,55 @@ /** * To get a service account and its private key see [TODO: write some * documentation on the website and put a link to it] -* -* The first argument (args[0]) must be your service account email address -* The second argument (args[1]) must a

Re: [jclouds] Adding test for single port firewall rule (#477)

2014-08-12 Thread CloudBees pull request builder plugin
[jclouds-java-6-pull-requests #13](https://jclouds.ci.cloudbees.com/job/jclouds-java-6-pull-requests/13/) FAILURE Looks like there's a problem with this pull request --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/477#issuecomment-51892788

Re: [jclouds-labs-google] JCLOUDS-661: Add ability to create single port firewall rule from Securi... (#39)

2014-08-12 Thread Stuart Hendren
I couldn't find any existing unit test for this class, though I could be looking in the wrong place(?), so a bit unclear how to start? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/39#issuecomment-51892917

Re: [jclouds] Adding test for single port firewall rule (#477)

2014-08-12 Thread CloudBees pull request builder plugin
[jclouds-pull-requests #1084](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1084/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/477#issuecomment-51895761

Re: [jclouds] Adding test for single port firewall rule (#477)

2014-08-12 Thread BuildHive
[jclouds » jclouds #1501](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1501/) ABORTED [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/477#issuecomment-51902333

Re: [jclouds] Adding test for single port firewall rule (#477)

2014-08-12 Thread Andrew Phillips
- assertEquals(Iterables.getOnlyElement(newGroup.getIpPermissions()), perm, - Expecting IpPermission + perm + but group was + newGroup); + singlePortBuilder.ipProtocol(IpProtocol.UDP); + singlePortBuilder.fromPort(41); + singlePortBuilder.toPort(41);

Re: [jclouds] Adding test for single port firewall rule (#477)

2014-08-12 Thread Andrew Phillips
Thanks for the changes, @stuarthendren! Just one trivial comment that we can also happily ignore. I just wanted to verify that you've run the live test and it passes with your changes to support one-port ranges? --- Reply to this email directly or view it on GitHub:

Re: [jclouds-labs-google] JCLOUDS-661: Add ability to create single port firewall rule from Securi... (#39)

2014-08-12 Thread Andrew Phillips
I couldn't find any existing unit test for this class, though I could be looking in the wrong place No, I don't think you were. I couldn't find anything obvious either :-( @abayer: what was the intention regarding unit or MockWebServer tests here? --- Reply to this email directly or view it

[jira] [Created] (JCLOUDS-662) Can't attach multiple disks with same size to SoftLayer CCI

2014-08-12 Thread Andrea Turli (JIRA)
Andrea Turli created JCLOUDS-662: Summary: Can't attach multiple disks with same size to SoftLayer CCI Key: JCLOUDS-662 URL: https://issues.apache.org/jira/browse/JCLOUDS-662 Project: jclouds

Re: [jclouds-examples] Make CreateServer allow a user to execute jobs via SSH. (#59)

2014-08-12 Thread Andrew Phillips
Checkstyle recommended me to do this. Reverted. If Checkstyle recommended it, please put it back - we try to stick to Checkstyle generally. Thanks for the other updates, @najtmar. With this last change, looks good to me! --- Reply to this email directly or view it on GitHub:

[jclouds] fix JCLOUDS-662 (#479)

2014-08-12 Thread Andrea Turli
You can merge this Pull Request by running: git pull https://github.com/andreaturli/jclouds fix/JCLOUDS-662 Or you can view, comment on it, or merge it online at: https://github.com/jclouds/jclouds/pull/479 -- Commit Summary -- * fix creation of blockDevices using

[jira] [Commented] (JCLOUDS-662) Can't attach multiple disks with same size to SoftLayer CCI

2014-08-12 Thread Andrea Turli (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14094027#comment-14094027 ] Andrea Turli commented on JCLOUDS-662: -- I've issued a PR to fix that at

Re: [jclouds] fix JCLOUDS-662 (#479)

2014-08-12 Thread CloudBees pull request builder plugin
[jclouds-java-6-pull-requests #14](https://jclouds.ci.cloudbees.com/job/jclouds-java-6-pull-requests/14/) FAILURE Looks like there's a problem with this pull request --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/479#issuecomment-51909257

Re: [jclouds] fix JCLOUDS-662 (#479)

2014-08-12 Thread Andrew Phillips
for (VirtualGuestBlockDevice blockDevice : virtualGuest.getVirtualGuestBlockDevices()) { blockDevices.add(new BlockDevice(blockDevice.getDevice(), blockDevice.getVirtualDiskImage().getCapacity())); } - return blockDevices.build(); +

Re: [jclouds] fix JCLOUDS-662 (#479)

2014-08-12 Thread Andrew Phillips
@@ -71,17 +72,17 @@ public void testLaunchClusterWithMinDisk() throws RunNodesException { templateBuilder.imageId(CENTOS_6_64); //templateBuilder.osFamily(OsFamily.CENTOS); //templateBuilder.imageId(7bcd78dc-eb11-4e1b-8d93-111c62ed5fd1); Unrelated to this PR, but:

Re: [jclouds] fix JCLOUDS-662 (#479)

2014-08-12 Thread Andrew Phillips
//options.portSpeed(10); // multi-disk option - options.blockDevices(ImmutableSet.of(100)); + //options.blockDevices(ImmutableList.of(25, 400, 400)); Is this commented-out on purpose? --- Reply to this email directly or view it on GitHub:

Re: [jclouds] fix JCLOUDS-662 (#479)

2014-08-12 Thread Andrew Phillips
Thanks, @andreaturli! Two minor questions: * Can we get rid of the import reorderings in the PR? * Can we remove the commented-out code in the live test? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/479#issuecomment-51911791

Re: [jclouds] fix JCLOUDS-662 (#479)

2014-08-12 Thread CloudBees pull request builder plugin
[jclouds-java-6-pull-requests #15](https://jclouds.ci.cloudbees.com/job/jclouds-java-6-pull-requests/15/) FAILURE Looks like there's a problem with this pull request --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/479#issuecomment-51912839

Re: [jclouds] fix JCLOUDS-662 (#479)

2014-08-12 Thread CloudBees pull request builder plugin
[jclouds-pull-requests #1085](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1085/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/479#issuecomment-51913625

Re: [jclouds-labs] Add vSphere support (#61)

2014-08-12 Thread CloudBees pull request builder plugin
[jclouds-labs-pull-requests #231](https://jclouds.ci.cloudbees.com/job/jclouds-labs-pull-requests/231/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/61#issuecomment-51914160

Re: [jclouds] fix JCLOUDS-662 (#479)

2014-08-12 Thread BuildHive
[jclouds » jclouds #1502](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1502/) SUCCESS This pull request looks good [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub:

Jenkins build is back to stable : jclouds » jclouds #1502

2014-08-12 Thread BuildHive
See https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1502/changes

Re: [jclouds] fix JCLOUDS-662 (#479)

2014-08-12 Thread CloudBees pull request builder plugin
[jclouds-pull-requests #1086](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1086/) FAILURE Looks like there's a problem with this pull request --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/479#issuecomment-51915333

Re: [jclouds] fix JCLOUDS-662 (#479)

2014-08-12 Thread CloudBees pull request builder plugin
[jclouds-java-6-pull-requests #16](https://jclouds.ci.cloudbees.com/job/jclouds-java-6-pull-requests/16/) FAILURE Looks like there's a problem with this pull request --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/479#issuecomment-51917382

Re: [jclouds] fix JCLOUDS-662 (#479)

2014-08-12 Thread Andrew Phillips
jclouds-pull-requests #1086 FAILURE Missing an import? ``` [ERROR] symbol: variable Lists [ERROR] location: class org.jclouds.softlayer.binders.VirtualGuestToJson [ERROR]

Re: [jclouds-examples] Make CreateServer allow a user to execute jobs via SSH. (#59)

2014-08-12 Thread najtmar
@@ -179,7 +215,7 @@ private Image getImage() { /** * Always close your service when you're done with it. */ - public void close() throws IOException { + public final void close() throws IOException { Following the suggestion, the change has been reapplied. --- Reply to

Re: [jclouds] fix JCLOUDS-662 (#479)

2014-08-12 Thread CloudBees pull request builder plugin
[jclouds-pull-requests #1087](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1087/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/479#issuecomment-51920634

Re: [jclouds] fix JCLOUDS-662 (#479)

2014-08-12 Thread BuildHive
[jclouds » jclouds #1503](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1503/) FAILURE Looks like there's a problem with this pull request [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub:

Build failed in Jenkins: jclouds » jclouds #1503

2014-08-12 Thread BuildHive
See https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1503/changes Changes: [Andrea Turli] fix creation of blockDevices using SoftLayerTemplateOptions [Andrea Turli] address comments -- [...truncated 26826 lines...] ... 30 more [ERROR]

Re: [jclouds-labs] Add vSphere support (#61)

2014-08-12 Thread Andrew Phillips
@@ -0,0 +1,7 @@ +Apache jclouds labs +Copyright 2009-2014 The Apache Software Foundation + +This product includes software developed at +The Apache Software Foundation (http://www.apache.org/). + +The VMWare vSphere API includes software developed at Cisco Systems, Inc Thanks for the

Re: [jclouds-examples] Make CreateServer allow a user to execute jobs via SSH. (#59)

2014-08-12 Thread Andrew Phillips
+1 - looks good to me! Could you squash'n'rebase? Then we should be good to merge! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-examples/pull/59#issuecomment-51921515

Re: [jclouds] fix JCLOUDS-662 (#479)

2014-08-12 Thread Andrew Phillips
jclouds » jclouds #1503 FAILURE This is still a compilation failure: ``` [ERROR] symbol: variable Collections [ERROR] location: class org.jclouds.softlayer.binders.VirtualGuestToJson [ERROR] - [Help 1] org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal

Re: [jclouds] fix JCLOUDS-662 (#479)

2014-08-12 Thread Andrew Phillips
+1 - looks good to me. Thanks, @andreaturli! Just a squash'n'rebase and we are good to go, as far as I'm concerned ;-) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/479#issuecomment-51921955

Re: [jclouds] fix JCLOUDS-662 (#479)

2014-08-12 Thread Andrea Turli
squashed and rebased! thanks @demobox! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/479#issuecomment-51922305

Re: [jclouds-labs] Add vSphere support (#61)

2014-08-12 Thread igreenfield
@@ -0,0 +1,7 @@ +Apache jclouds labs +Copyright 2009-2014 The Apache Software Foundation + +This product includes software developed at +The Apache Software Foundation (http://www.apache.org/). + +The VMWare vSphere API includes software developed at Cisco Systems, Inc I talk with our

Re: [jclouds] fix JCLOUDS-662 (#479)

2014-08-12 Thread CloudBees pull request builder plugin
[jclouds-java-6-pull-requests #17](https://jclouds.ci.cloudbees.com/job/jclouds-java-6-pull-requests/17/) FAILURE Looks like there's a problem with this pull request --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/479#issuecomment-51922657

Re: [jclouds-labs] Add vSphere support (#61)

2014-08-12 Thread CloudBees pull request builder plugin
[jclouds-labs-pull-requests #232](https://jclouds.ci.cloudbees.com/job/jclouds-labs-pull-requests/232/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/61#issuecomment-51925141

Re: [jclouds] JCLOUDS-658: use xattr only on supported systems (#478)

2014-08-12 Thread Jeremy Daggett
:-1: There are still failures with this PR. I spent a few hours last night digging in to them with no avail. I believe that we should revert #443 for the time being until the Mac OS filesystem integration can be thoroughly tested. --- Reply to this email directly or view it on GitHub:

Re: [jclouds] JCLOUDS-496: Use the security groups options in the portable TemplateOptions (#439)

2014-08-12 Thread Werner Buck
Any chance of getting this in? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/439#issuecomment-51926465

Re: [jclouds] JCLOUDS-658: use xattr only on supported systems (#478)

2014-08-12 Thread Andrew Phillips
There are still failures with this PR Could you post the failed tests? I'm also fine with reverting and re-opening the corresponding PR. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/478#issuecomment-51926890

Re: [jclouds] fix JCLOUDS-662 (#479)

2014-08-12 Thread CloudBees pull request builder plugin
[jclouds-pull-requests #1088](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1088/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/479#issuecomment-51928381

Re: [jclouds-examples] Make CreateServer allow a user to execute jobs via SSH. (#59)

2014-08-12 Thread Andrew Phillips
Closed #59. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-examples/pull/59#event-151916757

Re: [jclouds-examples] Make CreateServer allow a user to execute jobs via SSH. (#59)

2014-08-12 Thread Andrew Phillips
Committed to [master](https://git-wip-us.apache.org/repos/asf?p=jclouds-examples.git;a=commit;h=e682ee8bf9762e350c64ee37694759a5996b71fb). Thanks, @najtmar! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-examples/pull/59#issuecomment-51928991

[jira] [Updated] (JCLOUDS-662) Can't attach multiple disks with same size to SoftLayer CCI

2014-08-12 Thread Andrew Phillips (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-662?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Phillips updated JCLOUDS-662: Fix Version/s: (was: 1.8.1) Can't attach multiple disks with same size to SoftLayer

Re: [jclouds] JCLOUDS-658: use xattr only on supported systems (#478)

2014-08-12 Thread Jeremy Daggett
@demobox The rabbit hole starts with the following exception: ``` testBlobMetadata_withDefaultMetadata(org.jclouds.filesystem.FilesystemAsyncBlobStoreTest) Time elapsed: 0.113 sec FAILURE! java.lang.AssertionError: Wrong blob content-type expected [application/unknown] but found [null]

[jira] [Commented] (JCLOUDS-662) Can't attach multiple disks with same size to SoftLayer CCI

2014-08-12 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14094162#comment-14094162 ] ASF subversion and git services commented on JCLOUDS-662: - Commit

[jira] [Updated] (JCLOUDS-662) Can't attach multiple disks with same size to SoftLayer CCI

2014-08-12 Thread Andrew Phillips (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-662?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Phillips updated JCLOUDS-662: Attachment: JCLOUDS-662.patch Can't attach multiple disks with same size to SoftLayer

Re: [jclouds] fix JCLOUDS-662 (#479)

2014-08-12 Thread Andrew Phillips
Committed to [master](https://git-wip-us.apache.org/repos/asf?p=jclouds.git;h=8743e94). @andreaturli: Does this also need backporting to 1.8.x? If so, could you open a PR for that, using [the patch](https://issues.apache.org/jira/secure/attachment/12661225/JCLOUDS-662.patch) attached to the

[jira] [Updated] (JCLOUDS-662) Can't attach multiple disks with same size to SoftLayer CCI

2014-08-12 Thread Andrew Phillips (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-662?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Phillips updated JCLOUDS-662: Fix Version/s: 2.0.0 Can't attach multiple disks with same size to SoftLayer CCI

[jira] [Commented] (JCLOUDS-662) Can't attach multiple disks with same size to SoftLayer CCI

2014-08-12 Thread Andrea Turli (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14094171#comment-14094171 ] Andrea Turli commented on JCLOUDS-662: -- This needs to be backported on 1.8.x as

[jira] [Created] (JCLOUDS-663) Backport JCLOUDS-662 to 1.8.x

2014-08-12 Thread Andrea Turli (JIRA)
Andrea Turli created JCLOUDS-663: Summary: Backport JCLOUDS-662 to 1.8.x Key: JCLOUDS-663 URL: https://issues.apache.org/jira/browse/JCLOUDS-663 Project: jclouds Issue Type: Bug

Re: [jclouds] JCLOUDS-496: Use the security groups options in the portable TemplateOptions (#439)

2014-08-12 Thread Andrew Phillips
Any chance of getting this in? @wernerb I don't see any technical reason (the one minor comment is easy to fix), I was just uncertain whether we had come to a conclusion on the discussion about deprecating other stuff. @nacx Ping? And thoughts on this? --- Reply to this email directly or

Re: [jclouds-labs-google] JCLOUDS-661: Add ability to create single port firewall rule from Securi... (#39)

2014-08-12 Thread Andrew Phillips
FYI: Live test in https://github.com/jclouds/jclouds/pull/477 --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/39#issuecomment-51934713

Re: [jclouds] JCLOUDS-496: Use the security groups options in the portable TemplateOptions (#439)

2014-08-12 Thread Ignasi Barrera
Sure it should be in 1.8.x. I won't be able to commit it until Monday 18, but feel free to take it if you have time! :) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/439#issuecomment-51935245

Re: [jclouds] JCLOUDS-496: Use the security groups options in the portable TemplateOptions (#439)

2014-08-12 Thread Andrew Phillips
Sure it should be in 1.8.x. Also master then, I guess? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/439#issuecomment-51935355

Re: [jclouds] Adding test for single port firewall rule (#477)

2014-08-12 Thread CloudBees pull request builder plugin
[jclouds-java-6-pull-requests #18](https://jclouds.ci.cloudbees.com/job/jclouds-java-6-pull-requests/18/) FAILURE Looks like there's a problem with this pull request --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/477#issuecomment-51935536

Re: [jclouds] JCLOUDS-496: Use the security groups options in the portable TemplateOptions (#440)

2014-08-12 Thread Andrew Phillips
Since the deprecation unfortunately didn't make it into 1.8.0, should we be removing the methods _after_ 2.0.0, then? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/440#issuecomment-51936234

Re: [jclouds] JCLOUDS-496: Use the security groups options in the portable TemplateOptions (#440)

2014-08-12 Thread Ignasi Barrera
Not a big deal, as the deprecated methods delegate to the *good* ones. Removal can wait. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/440#issuecomment-51936416

Re: [jclouds] JCLOUDS-496: Use the security groups options in the portable TemplateOptions (#439)

2014-08-12 Thread Ignasi Barrera
Yep, I see. That was because of my timing and vacations *sigh*. Anyway, there is still no release inconsistency as deprecation is in 1.7.x and 1.8.x but no released version has stil the fix. It will just come a bit later. --- Reply to this email directly or view it on GitHub:

Re: [jclouds] JCLOUDS-496: Use the security groups options in the portable TemplateOptions (#439)

2014-08-12 Thread Ignasi Barrera
There is PR #440 to be reopened against master which **removes** the methods instead of deprecating. I think that one should be the one to go there, perhaps after deprecating in master too, just for consistence? --- Reply to this email directly or view it on GitHub:

[jclouds] Use the security groups options in the portable TemplateOptions (#481)

2014-08-12 Thread Andrew Phillips
See #439 You can merge this Pull Request by running: git pull https://github.com/jclouds/jclouds fix-496 Or you can view, comment on it, or merge it online at: https://github.com/jclouds/jclouds/pull/481 -- Commit Summary -- * Use the security groups options in the portable

[jclouds] Use the security groups options in the portable TemplateOptions (1.8.x) (#480)

2014-08-12 Thread Andrew Phillips
You can merge this Pull Request by running: git pull https://github.com/jclouds/jclouds fix-496-1.8.x Or you can view, comment on it, or merge it online at: https://github.com/jclouds/jclouds/pull/480 -- Commit Summary -- * Use the security groups options in the portable

Re: [jclouds] JCLOUDS-496: Use the security groups options in the portable TemplateOptions (#439)

2014-08-12 Thread Andrew Phillips
Closed #439. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/439#event-151962585

Re: [jclouds] Use the security groups options in the portable TemplateOptions (#481)

2014-08-12 Thread Andrew Phillips
jclouds-java-6-pull-requests #20 FAILURE Expected --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/481#issuecomment-51941764

Re: [jclouds] Use the security groups options in the portable TemplateOptions (#481)

2014-08-12 Thread CloudBees pull request builder plugin
[jclouds-java-6-pull-requests #20](https://jclouds.ci.cloudbees.com/job/jclouds-java-6-pull-requests/20/) FAILURE Looks like there's a problem with this pull request --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/481#issuecomment-51941256

Re: [jclouds] Adding test for single port firewall rule (#477)

2014-08-12 Thread CloudBees pull request builder plugin
[jclouds-pull-requests #1089](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1089/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/477#issuecomment-51941660

Re: [jclouds] Adding test for single port firewall rule (#477)

2014-08-12 Thread Andrew Phillips
I didn't realize there was a dependency between the test methods. Ah, interesting! Wasn't aware of that either, sorry. It seems to require the file path of the .pem as the credential and the others the RSA text I seem to recall a recent change that allowed both. @ccustine I think it was

Re: [jclouds] fix JCLOUDS-662 (#479)

2014-08-12 Thread BuildHive
[jclouds » jclouds #1505](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1505/) ABORTED [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/479#issuecomment-51946217

Re: [jclouds] Use the security groups options in the portable TemplateOptions (1.8.x) (#480)

2014-08-12 Thread CloudBees pull request builder plugin
[jclouds-java-6-pull-requests #19](https://jclouds.ci.cloudbees.com/job/jclouds-java-6-pull-requests/19/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/480#issuecomment-51946931

Re: [jclouds] Use the security groups options in the portable TemplateOptions (1.8.x) (#480)

2014-08-12 Thread CloudBees pull request builder plugin
[jclouds-pull-requests #1090](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1090/) UNSTABLE Looks like there's a problem with this pull request --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/480#issuecomment-51947645

Re: [jclouds] Use the security groups options in the portable TemplateOptions (#481)

2014-08-12 Thread CloudBees pull request builder plugin
[jclouds-pull-requests #1091](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1091/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/481#issuecomment-51947890

Re: [jclouds] Use the security groups options in the portable TemplateOptions (1.8.x) (#480)

2014-08-12 Thread Andrew Phillips
jclouds-pull-requests #1090 UNSTABLE Spurious [test failure](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/org.apache.jclouds$jclouds-compute/1090/testReport/junit/org.jclouds.compute.util/ConcurrentOpenSocketFinderTest/testChecksSocketsConcurrently/) --- Reply to this email

Jenkins build became unstable: jclouds » jclouds Components Core #2716

2014-08-12 Thread jenkins-no-reply
See https://jclouds.ci.cloudbees.com/job/jclouds/org.apache.jclouds$jclouds-core/2716/

[jira] [Updated] (JCLOUDS-496) TemplateOptions securityGroups() method doesn't work in Openstack-Nova

2014-08-12 Thread Andrew Phillips (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-496?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Phillips updated JCLOUDS-496: Attachment: JCLOUDS-496.patch TemplateOptions securityGroups() method doesn't work in

Re: [jclouds] Use the security groups options in the portable TemplateOptions (#481)

2014-08-12 Thread Andrew Phillips
Committed to [master](https://git-wip-us.apache.org/repos/asf?p=jclouds.git;h=95b6064) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/481#issuecomment-51948636

Re: [jclouds] Use the security groups options in the portable TemplateOptions (#481)

2014-08-12 Thread Andrew Phillips
Closed #481. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/481#event-151989612

[jira] [Commented] (JCLOUDS-496) TemplateOptions securityGroups() method doesn't work in Openstack-Nova

2014-08-12 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14094370#comment-14094370 ] ASF subversion and git services commented on JCLOUDS-496: - Commit

Re: [jclouds] Use the security groups options in the portable TemplateOptions (1.8.x) (#480)

2014-08-12 Thread Andrew Phillips
Closed #480. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/480#event-151989809

[jira] [Commented] (JCLOUDS-496) TemplateOptions securityGroups() method doesn't work in Openstack-Nova

2014-08-12 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14094366#comment-14094366 ] ASF subversion and git services commented on JCLOUDS-496: - Commit

[jira] [Updated] (JCLOUDS-496) TemplateOptions securityGroups() method doesn't work in Openstack-Nova

2014-08-12 Thread Andrew Phillips (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-496?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Phillips updated JCLOUDS-496: Fix Version/s: 1.8.1 TemplateOptions securityGroups() method doesn't work in

Re: [jclouds-site] Release Notes for jclouds 1.8.0 (1e7df91)

2014-08-12 Thread Andrew Phillips
@ccustine: Do we have a PR planned to update the guide to demonstrate the region property? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/commit/1e7df91e259932d85476a41bbcfaddf72817b59a#commitcomment-7360198

Re: [jclouds] Use the security groups options in the portable TemplateOptions (1.8.x) (#480)

2014-08-12 Thread Ignasi Barrera
Thx @demobox! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/480#issuecomment-51950179

Re: [jclouds] Use the security groups options in the portable TemplateOptions (#481)

2014-08-12 Thread Ignasi Barrera
Thanks! :) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/481#issuecomment-51950237

Re: [jclouds] JCLOUDS-654: Add object size to StorageMetadata (#465)

2014-08-12 Thread Jeremy Daggett
@@ -332,6 +334,30 @@ public void testListContainer() throws InterruptedException, ExecutionException, } + @Test(groups = { integration, live }) + public void testListContainerGetBlobSize() throws Exception { + String containerName = getContainerName(); + try { +

Re: [jclouds] JCLOUDS-654: Add object size to StorageMetadata (#465)

2014-08-12 Thread Jeremy Daggett
super(id, name, location, uri, userMetadata); this.eTag = eTag; this.creationDate = creationDate; this.lastModified = lastModified; this.type = checkNotNull(type, type); + this.size = size; + } + + /** @deprecated use 10-argument variant of

Re: [jclouds] JCLOUDS-658: use xattr only on supported systems (#478)

2014-08-12 Thread Andrew Gaul
@jdaggett Can you please test this on Mac OS X and make the changes necessary to skip the failing integration tests on that platform? As previously stated, this pull request needs changes for Mac OS X to skip running the four tests that all platforms previously skipped. Given that this

Re: [jclouds] JCLOUDS-654: Add object size to StorageMetadata (#465)

2014-08-12 Thread Jeremy Daggett
@@ -72,9 +72,9 @@ public void testWithoutToken() { protected SetDirectoryEntry values() { BuilderDirectoryEntry expected = ImmutableSet.builder(); expected.add(new DirectoryEntry(4980cdb2a411106a04a4538c92a1b204ad92077de6e3, FileType.DIRECTORY, -

Re: [jclouds] JCLOUDS-654: Add object size to StorageMetadata (#465)

2014-08-12 Thread Jeremy Daggett
@andrewgaul +1 Just a few comments to address and this should be good to merge. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/465#issuecomment-51952940

Re: [jclouds] JCLOUDS-654: Add object size to StorageMetadata (#465)

2014-08-12 Thread Jeremy Daggett
@@ -62,6 +62,7 @@ */ MILLISECOND_PRECISION, + // TODO: how to use this? Extra comment? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/465/files#r16130759

Re: [jclouds] JCLOUDS-654: Add object size to StorageMetadata (#465)

2014-08-12 Thread Shri Javadekar
Sorry I missed this earlier. I will take a look at this later today. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/465#issuecomment-51953773

Jenkins build is back to stable : jclouds » jclouds Components Core #2717

2014-08-12 Thread jenkins-no-reply
See https://jclouds.ci.cloudbees.com/job/jclouds/org.apache.jclouds$jclouds-core/2717/

Re: [jclouds] JCLOUDS-658: use xattr only on supported systems (#478)

2014-08-12 Thread Andrew Phillips
this pull request needs changes for Mac OS X to skip running the four tests Should we be _skipping_ the tests? Doesn't the code now simply say that, if the appropriate view is not supported, the values we are comparing should be null? In that case, I can imagine two tests split by a

  1   2   >