Re: [jclouds-labs-openstack] adding: StackApi, Stack and StackResource (#188)

2015-04-13 Thread Zack Shoylev
+ return this; + } + + public CreateStack build() { + String missing = ; + + if (name == null) { +missing += name; + } + + + if (template == null templateUrl == null) { +missing += template and templateUrl;

Re: [jclouds-labs-openstack] adding: StackApi, Stack and StackResource (#188)

2015-04-13 Thread Zack Shoylev
+ assertThat(stackId).isNotEmpty(); + + boolean success = retry(new PredicateString() { +public boolean apply(String stackId) { + return stackApi.get(stackId).getStatus() == StackStatus.CREATE_COMPLETE; +} + + }, 60, 1,

Re: [jclouds-labs-openstack] adding: StackApi, Stack and StackResource (#188)

2015-04-13 Thread Zack Shoylev
+ boolean delete(@PathParam(stack_name) String name, @PathParam(stack_id) String id); + + @Named(stack:update) + @PUT + @Path(/{stack_name}/{stack_id}) + @Fallback(NullOnNotFoundOr404.class) + @Nullable + boolean update(@PathParam(stack_name) String name,

Re: [jclouds-labs-openstack] adding: StackApi, Stack and StackResource (#188)

2015-04-13 Thread Zack Shoylev
I really like how this is turning out. Great work @limorbortman! My one regret is that the autovalue builders are not officially out yet. But this will still be very easy to refactor once they are. Thanks! --- Reply to this email directly or view it on GitHub:

Re: [jclouds-labs-openstack] adding: StackApi, Stack and StackResource (#188)

2015-04-13 Thread Zack Shoylev
+import static org.testng.Assert.assertEquals; +import static org.testng.Assert.assertTrue; + +/** + * Tests annotation parsing of {@code StackApi} + */ +@Test(groups = unit, testName = StackApiMockTest) +public class StackApiMockTest extends BaseHeatApiMockTest { + + public static

Re: [jclouds-labs-openstack] adding: StackApi, Stack and StackResource (#188)

2015-04-13 Thread Zack Shoylev
+ boolean delete(@PathParam(stack_name) String name, @PathParam(stack_id) String id); + + @Named(stack:update) + @PUT + @Path(/{stack_name}/{stack_id}) + @Fallback(NullOnNotFoundOr404.class) + @Nullable + boolean update(@PathParam(stack_name) String name,

[jira] [Created] (JCLOUDS-887) add support for Azure append blobs

2015-04-13 Thread Andrew Gaul (JIRA)
Andrew Gaul created JCLOUDS-887: --- Summary: add support for Azure append blobs Key: JCLOUDS-887 URL: https://issues.apache.org/jira/browse/JCLOUDS-887 Project: jclouds Issue Type: New Feature

Re: [jclouds-labs-openstack] adding: StackApi, Stack and StackResource (#188)

2015-04-13 Thread Zack Shoylev
scopeprovided/scope /dependency dependency groupIdcom.google.auto.service/groupId artifactIdauto-service/artifactId + version1.0-rc2/version Good point. In any case, the right way to use this dependency, if I remember correctly, would be this:

Re: [jclouds-labs] JCLOUDS-702: JClouds ProfitBricks provider - ComputeServiceAdapter (#145)

2015-04-13 Thread Reijhanniel Jearl Campos
TODO: Live test --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/145#issuecomment-92278075

Re: [jclouds] Contribution to jClouds(HypervisorAPI for Openstack) (#729)

2015-04-13 Thread Ignasi Barrera
Thanks for the contribution @AlkaBeniwal. Can you take a look at the build failures? The code also reformats some unrelated code. Could you please make reformat your contribution so it uses the [jclouds coding standards](https://cwiki.apache.org/confluence/display/JCLOUDS/Coding+Standards)?

[jira] [Commented] (JCLOUDS-873) Complete Network Security Group API implementation

2015-04-13 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14492125#comment-14492125 ] ASF subversion and git services commented on JCLOUDS-873: - Commit

Re: [jclouds-examples] Adding License file and fixing compute-basic for GCE (#73)

2015-04-13 Thread Ignasi Barrera
It is not needed, as we're not distributing it, but I see no problem in having the file in the repo. Even if not an ASF release, people downloading the tarball from GitHub will already have the license file, and that's not bad (we already have the license headers in all files, so it makes sense

Re: [jclouds-labs] [JCLOUDS-873] fixed (#161)

2015-04-13 Thread Ignasi Barrera
Thanks! Just waiting for the tests mentioned in https://github.com/jclouds/jclouds-labs/pull/161#discussion_r28064957. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/161#issuecomment-92280818

Re: [jclouds-labs] [JCLOUDS-873] fixed (#161)

2015-04-13 Thread fmartelli
@nacx, just rebased again on the latest commit. Any news? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/161#issuecomment-92271501

Re: [jclouds-labs] [JCLOUDS-873] fixed (#161)

2015-04-13 Thread fmartelli
@nacx, I'm sorry for the mistake. I've just pushed the fix requested by you. Thanks. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/161#issuecomment-92289213

[jira] [Updated] (JCLOUDS-873) Complete Network Security Group API implementation

2015-04-13 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-873?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignasi Barrera updated JCLOUDS-873: --- Assignee: fabio martelli Complete Network Security Group API implementation

Re: [jclouds-labs] [JCLOUDS-873] fixed (#161)

2015-04-13 Thread Ignasi Barrera
Squashed and pushed to [master](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/29435e1c) and [1.9.x](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/2b69bed1). Thanks @fmartelli! --- Reply to this email directly or view it on GitHub:

[jira] [Commented] (JCLOUDS-873) Complete Network Security Group API implementation

2015-04-13 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14492129#comment-14492129 ] ASF subversion and git services commented on JCLOUDS-873: - Commit

Re: [jclouds-labs] JClouds Profitbricks provider - LoadBalancer API (#143)

2015-04-13 Thread Ignasi Barrera
Looked at it again and it was only the Server object. Pushed to [master](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/823df74f) and [1.9.x](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/c607a19a). Thanks! --- Reply to this email directly or view it on GitHub:

Re: [jclouds-labs] JClouds Profitbricks provider - LoadBalancer API (#143)

2015-04-13 Thread Ignasi Barrera
Closed #143. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/143#event-279601647

Build failed in Jenkins: jclouds-labs #884

2015-04-13 Thread jenkins-no-reply
See https://jclouds.ci.cloudbees.com/job/jclouds-labs/884/changes Changes: [Ignasi Barrera] JClouds Profitbricks provider - LoadBalancer API -- Started by an SCM change Building remotely on 70ad0e0a (lxc-fedora17 standard m1.large large) in workspace

Build failed in Jenkins: jclouds-labs-1.9.x-branch #27

2015-04-13 Thread jenkins-no-reply
See https://jclouds.ci.cloudbees.com/job/jclouds-labs-1.9.x-branch/27/changes Changes: [Ignasi Barrera] JClouds Profitbricks provider - LoadBalancer API -- Started by an SCM change Building remotely on 04791c16 (lxc-fedora17 standard m1.large large) in

Build failed in Jenkins: jclouds-1.9.x-branch #15

2015-04-13 Thread jenkins-no-reply
See https://jclouds.ci.cloudbees.com/job/jclouds-1.9.x-branch/15/ -- Started by user Ignasi Barrera Building remotely on 81dd6d50 (lxc-fedora17 standard m1.large large) in workspace https://jclouds.ci.cloudbees.com/job/jclouds-1.9.x-branch/ws/ $ sudo

Jenkins build is back to normal : jclouds-labs-1.9.x-branch #28

2015-04-13 Thread jenkins-no-reply
See https://jclouds.ci.cloudbees.com/job/jclouds-labs-1.9.x-branch/28/

Jenkins build is back to normal : jclouds-labs #885

2015-04-13 Thread jenkins-no-reply
See https://jclouds.ci.cloudbees.com/job/jclouds-labs/885/

[jira] [Commented] (JCLOUDS-881) Can't create ComputeServiceContext for aws-ec2 in Google App Engine

2015-04-13 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14492218#comment-14492218 ] Ignasi Barrera commented on JCLOUDS-881: The linked issue is about reflection

Re: [jclouds-labs] JCLOUDS-853: Improve Create VirtualMachine Deployment (#154)

2015-04-13 Thread fmartelli
hi @hsbhathiya, since #163 added reserved IP addresses support, could you handle this information during deployment creation? Thank you in advance. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/154#issuecomment-92294251

Build failed in Jenkins: jclouds-1.9.x-branch #14

2015-04-13 Thread jenkins-no-reply
See https://jclouds.ci.cloudbees.com/job/jclouds-1.9.x-branch/14/ -- Started by user Ignasi Barrera Building remotely on 3d067d76 (lxc-fedora17 standard m1.large large) in workspace https://jclouds.ci.cloudbees.com/job/jclouds-1.9.x-branch/ws/ $ sudo

Re: [jclouds-labs] JCLOUDS-853: Improve Create VirtualMachine Deployment (#154)

2015-04-13 Thread Bhathiya
@fmartelli I'll look into it change the PR as required --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/154#issuecomment-92381621

[jira] [Commented] (JCLOUDS-880) Create instance with additional disk attached / redefine boot disk size

2015-04-13 Thread Yaron Rosenbaum (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14492371#comment-14492371 ] Yaron Rosenbaum commented on JCLOUDS-880: - Hi Daniel Could you share your Eclipse

Re: [jclouds-labs-google] Add support for disks ip forward during node creation (#135)

2015-04-13 Thread Yaron Rosenbaum
+ this.diskMode = diskMode; + this.isBootDisk = isBootDisk; + this.diskSizeGb = diskSizeGb; + } + + public AutoCreateDiskOptions(final AttachDisk.Type diskType, final AttachDisk.Mode diskMode, final boolean isBootDisk, final int diskSizeGb, final String