[
https://issues.apache.org/jira/browse/JCLOUDS-172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14574090#comment-14574090
]
Ignasi Barrera commented on JCLOUDS-172:
Yes. I'd say this and the fix to the
+ MapString, String meta = templateOptions.getUserMetadata();
+ if (meta != null !meta.isEmpty()) {
+if (meta.containsKey(USER_META_NOTES)) {
+ return meta.get(USER_META_NOTES);
+} else {
+ String notes = User
I've just commented on the remaining bits. Also take
https://github.com/jclouds/jclouds/pull/763 into account when rebasing, just in
case Andrea merges that PR first, as it seems to overlap with some of your
changes.
---
Reply to this email directly or view it on GitHub:
+1
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/763#issuecomment-109281296
@@ -149,4 +152,34 @@
@Produces(MediaType.APPLICATION_JSON)
@Fallback(Fallbacks.FalseOnNotFoundOr404.class)
boolean setTags(@PathParam(id) long id, @BinderParam(TagToJson.class)
SetString tags);
+
+ /**
+* Set notes (visible in UI)
+*
+* @param id
+*
Closed #753.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/753#event-323524167
Pushed to master as
[97c16087](http://git-wip-us.apache.org/repos/asf/jclouds/commit/97c16087).
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/753#issuecomment-109284757
Yes, lgtm. Huge thanks for this PR @andreaturli!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/727#issuecomment-109285878
Thanks @ajatix! Could you please have a look at the build faliure?
Also would it make sense to include that flag into the
See https://jclouds.ci.cloudbees.com/job/jclouds-1.9.x-branch/70/
See
https://jclouds.ci.cloudbees.com/job/jclouds-1.9.x-branch/org.apache.jclouds$jclouds/70/
So much cleanup, thanks!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/727#issuecomment-109306936
yy - passes with that changed.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/141#issuecomment-109359455
Ok, https://cloud.google.com/compute/docs/instances/#stop_job seems to explain
it - TERMINATED is actually stopped here.
Closed #147.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/147#event-323723559
Closing since I hit the same live test failure.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/147#issuecomment-109349101
16 matches
Mail list logo
