Closed #443.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/443#event-1840127835
merger at
[master](https://git1-us-west.apache.org/repos/asf?p=jclouds-labs.git;a=commit;h=a5dbf0065d8fa8cabcaf020b7c10fe2f7ccf8d6a)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
[
https://issues.apache.org/jira/browse/JCLOUDS-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16611573#comment-16611573
]
ASF subversion and git services commented on JCLOUDS-1430:
--
Commit
thanks @nacx, merging it now
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/443#issuecomment-420501158
demobox commented on this pull request.
> @@ -763,6 +763,8 @@ private static void addHeader(Multimap
> headers, Headers header,
for (int i = 0; i < header.keys().length; i++) {
String value = header.values()[i];
value = replaceTokens(value, tokenValues);
+ if
demobox commented on this pull request.
> @@ -408,6 +408,21 @@ public void testCopyObject() throws Exception {
}
}
+ String sourceKeyRequiringEncoding = "apples#?:$&'\"<>čॐ";
+1 to move into the test, if possible
--
You are receiving this because you are subscribed to this
This looks good but could you amend the commit message with the prefix
JCLOUDS-1419? This will tag it correctly in Jira.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Hi, GCB allows the user to create a bucket with Storage Class REGIONAL however,
this jClouds API doesn't have the enum for the Storage class as REGIONAL.
That's the reason I have updated this class.
You can view, comment on, or merge this pull request online at:
gaul approved this pull request.
I am surprised we have not encountered this previously. @nacx can you think of
any other providers that need to URL encode headers?
> @@ -408,6 +408,21 @@ public void testCopyObject() throws Exception {
}
}
+ String sourceKeyRequiringEncoding =
[
https://issues.apache.org/jira/browse/JCLOUDS-1447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Gaul updated JCLOUDS-1447:
-
Affects Version/s: 2.1.1
> S3 CopyObject requires x-amz-copy-source to be URL encoded
>
jglick approved this pull request.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1238#pullrequestreview-154169386
[
https://issues.apache.org/jira/browse/JCLOUDS-1447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16610462#comment-16610462
]
David Currie commented on JCLOUDS-1447:
---
PR ready to review:
As described in https://jira.apache.org/jira/browse/JCLOUDS-1447, S3 CopyObject
requires the `x-amz-copy-source` header to be URL encoded.
This is not universally true of all headers though (for example the equals in
`x-amz-copy-source-range`) therefore introducing a new parameter on `@Headers`
13 matches
Mail list logo
