[GitHub] [jclouds] nacx commented on pull request #78: Replace embedded and repackaged GSON library

2020-10-26 Thread GitBox
nacx commented on pull request #78: URL: https://github.com/apache/jclouds/pull/78#issuecomment-716528333 Thank you very much for your contribution and patience @gurkerl83! This has been a very much appreciated PR. Thanks for your continued efforts on this!

[GitHub] [jclouds] nacx commented on pull request #78: Replace embedded and repackaged GSON library

2020-10-23 Thread GitBox
nacx commented on pull request #78: URL: https://github.com/apache/jclouds/pull/78#issuecomment-715197168 So, the general idea of this is to move to the BND plugin (which I'm OK with) and to address the issue of GSON unexported packages by exporting them from our jclouds-core module.

[GitHub] [jclouds] nacx commented on pull request #78: Replace embedded and repackaged GSON library

2020-07-05 Thread GitBox
nacx commented on pull request #78: URL: https://github.com/apache/jclouds/pull/78#issuecomment-653941801 So, the idea is that the jclouds-core OSGi module can export the son package we want instead of having them directly exported by the gson dependency itself? As long as that is enough

[GitHub] [jclouds] nacx commented on pull request #78: Replace embedded and repackaged GSON library

2020-06-27 Thread GitBox
nacx commented on pull request #78: URL: https://github.com/apache/jclouds/pull/78#issuecomment-650507931 As @gaul said, I'm not against this PR either, but it is a breaking change that can have significant impact. We know other projects are using our OSGi/Karaf support (such as Apache

[GitHub] [jclouds] nacx commented on pull request #78: Replace embedded and repackaged GSON library

2020-06-26 Thread GitBox
nacx commented on pull request #78: URL: https://github.com/apache/jclouds/pull/78#issuecomment-650318652 So, with the last update, this PR reverts back to the official gson library, which makes jclouds incompatible with OSGi. As mentioned in the different JIRA issues, we need to

[GitHub] [jclouds] nacx commented on pull request #78: Replace embedded and repackaged GSON library

2020-06-25 Thread GitBox
nacx commented on pull request #78: URL: https://github.com/apache/jclouds/pull/78#issuecomment-649639166 I think this is not correct. The project depends on pulling a dependency from a specific repository, otherwise, it will break. The main issue here is releasing under the same