Re: [jclouds/jclouds-cli] JCLOUDS-664: Added Azure ARM to jclouds-cli (#33)

2016-09-21 Thread Andrew Phillips
Thanks for taking care of this, Ignasi! -- You are receiving this because you modified the open/close state. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-cli/pull/33#issuecomment-248757354

Re: [jclouds/jclouds-karaf] Added Azure ARM (#84)

2016-09-21 Thread Andrew Phillips
> Yay! It worked just adding the feature Yayayay! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-karaf/pull/84#issuecomment-248728348

Re: [jclouds/jclouds] Add keystone authentication with an existing token (#1009)

2016-09-21 Thread Zack Shoylev
@olivierlemasle Yes, the code will still be quite useful for a few situations! I mostly wanted to add a comment to the code to ensure the limitations are documented. As for the tests, I think at least unit tests would be nice. For live tests, you can use devstack to test locally, but let's

Re: [jclouds/jclouds-labs] Use the existing region suppliers to filter (#321)

2016-09-21 Thread Andrea Turli
looks so clean, thx @nacx ! Merge it right away! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/321#issuecomment-248651612

Re: [jclouds/jclouds-labs] fix azure-arm features live tests (#317)

2016-09-21 Thread Andrea Turli
``` Failed tests: AzureComputeServiceLiveTest>BaseComputeServiceLiveTest.testCompareSizes:887->BaseComputeServiceLiveTest.doCompareSizes:891 ยป Provision

[jclouds/jclouds-labs] Use the existing region suppliers to filter (#321)

2016-09-21 Thread Ignasi Barrera
@andreaturli Can you give this a try? You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds-labs/pull/321 -- Commit Summary -- * Use the existing region suppliers to filter -- File Changes -- M

Re: [jclouds/jclouds-labs] separate the DeploymentToVMDeployment to a function (#320)

2016-09-21 Thread Andrea Turli
thx @nacx, merged at [master](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/28c56e06) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/320#issuecomment-248632037

Re: [jclouds/jclouds-labs] separate the DeploymentToVMDeployment to a function (#320)

2016-09-21 Thread Andrea Turli
Closed #320. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/320#event-797411872

Re: [jclouds/jclouds-labs] separate the DeploymentToVMDeployment to a function (#320)

2016-09-21 Thread Ignasi Barrera
nacx approved this pull request. > private final ProviderMetadata providerMetadata; + private final DeploymentToVMDeployment deploymentToVMDeployment; Better declare and inject it as `Function` to make it easier to re-bind. > @@ -288,7 +279,7 @@ public VMImage

Re: [jclouds/jclouds-labs] separate the DeploymentToVMDeployment to a function (#320)

2016-09-21 Thread Ignasi Barrera
Just minors. let's merge it, since I plan to open a PR with the minor fixes in a while. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/320#issuecomment-248627353

[jira] [Updated] (JCLOUDS-1182) Missing region in `listAssignableLocations` for AWS EC2

2016-09-21 Thread Abdysamat Mamutov (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1182?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abdysamat Mamutov updated JCLOUDS-1182: --- Affects Version/s: 2.0.0 > Missing region in `listAssignableLocations` for AWS EC2

[jira] [Updated] (JCLOUDS-1182) Missing region in `listAssignableLocations` for AWS EC2

2016-09-21 Thread Abdysamat Mamutov (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1182?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abdysamat Mamutov updated JCLOUDS-1182: --- Component/s: jclouds-compute > Missing region in `listAssignableLocations` for AWS

[jclouds/jclouds] Better predicate signature for node operations (#1011)

2016-09-21 Thread Ignasi Barrera
This changes the signature of the compute methods to have better predicates for nodes. Without this, most methods could only use a `Predicate` or a `Predicate`, which was pretty inconvenient, because generic predicates such as `NodePredicates.all()` or concrete ones like

[jira] [Commented] (JCLOUDS-664) Azure compute support

2016-09-21 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15509550#comment-15509550 ] ASF subversion and git services commented on JCLOUDS-664: - Commit

[jclouds/jclouds-cli] JCLOUDS-664: Added Azure ARM to jclouds-cli (#33)

2016-09-21 Thread Ignasi Barrera
You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds-cli/pull/33 -- Commit Summary -- * JCLOUDS-664: Added Azure ARM to jclouds-cli -- File Changes -- M assembly/pom.xml (1) -- Patch Links --

Re: [jclouds/jclouds-karaf] Added Azure ARM (#84)

2016-09-21 Thread Ignasi Barrera
Yay! It worked just adding the feature :) I've squashed the commits and merged to master as [b1152f3d](http://git-wip-us.apache.org/repos/asf/jclouds-karaf/commit/b1152f3d). Thanks for all the help @demobox! BTW, the ServiceMix bundles will be released by the end of this month, so perhaps we

Re: [jclouds/jclouds-karaf] Added Azure ARM (#84)

2016-09-21 Thread Ignasi Barrera
Closed #84. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-karaf/pull/84#event-796949828

[jira] [Commented] (JCLOUDS-664) Azure compute support

2016-09-21 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15509241#comment-15509241 ] ASF subversion and git services commented on JCLOUDS-664: - Commit

Re: [jclouds/jclouds-karaf] Added Azure ARM (#84)

2016-09-21 Thread Ignasi Barrera
@nacx pushed 1 commit. 3371b37 Added missing Azure ARM feature -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-karaf/pull/84/files/91f25d4305c928801fe980d98aee48fedd6406f6..3371b37b8403a3a61087e35b6477c75c37e3ebc4

Re: [jclouds/jclouds-karaf] Added Azure ARM (#84)

2016-09-21 Thread Ignasi Barrera
Sure :) I'll add it there and update the PR, and if it still fails I'll add the dependency to the root pom (I don't really know the details of how it works but I bet we'd need both)... And I'll try to cleanup my local env and see if I can make it fail the same way our CI builds fail! -- You

Re: [jclouds/jclouds-karaf] Added Azure ARM (#84)

2016-09-21 Thread Ignasi Barrera
Makes sense. I copied how our jclouds oauth lib is configured, as they are the same kind of dependency, and I have not found any differences... Wait! Perhaps oauth works because our google-common is declared in the root pom.xml and it brings oauth as a transitive dependency? I'll try adding