Re: [jclouds/jclouds-cli] JCLOUDS-664: Added Azure ARM to jclouds-cli (#33)

[Andrew Phillips]

Thanks for taking care of this, Ignasi!

-- 
You are receiving this because you modified the open/close state.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-cli/pull/33#issuecomment-248757354

Re: [jclouds/jclouds-karaf] Added Azure ARM (#84)

[Andrew Phillips]

> Yay! It worked just adding the feature

Yayayay!

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/84#issuecomment-248728348

Re: [jclouds/jclouds] Add keystone authentication with an existing token (#1009)

[Zack Shoylev]

@olivierlemasle 

Yes, the code will still be quite useful for a few situations! I mostly wanted 
to add a comment to the code to ensure the limitations are documented. As for 
the tests, I think at least unit tests would be nice. For live tests, you can 
use devstack to test locally, but let's get the unit tests done first.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1009#issuecomment-248720659

Re: [jclouds/jclouds-labs] Use the existing region suppliers to filter (#321)

[Andrea Turli]

looks so clean, thx @nacx ! Merge it right away!

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/321#issuecomment-248651612

Re: [jclouds/jclouds-labs] fix azure-arm features live tests (#317)

[Andrea Turli]

```
Failed tests:
  
AzureComputeServiceLiveTest>BaseComputeServiceLiveTest.testCompareSizes:887->BaseComputeServiceLiveTest.doCompareSizes:891
 » Provision
  
AzureComputeServiceLiveTest>BaseComputeServiceLiveTest.testCreateAndRunAService:733->BaseComputeServiceLiveTest.createAndRunAServiceInGroup:747->BaseComputeServiceLiveTest.buildTemplate:541
 » Provision
  AzureComputeServiceLiveTest>BaseComputeServiceLiveTest.testImageById:212 » 
Provision
  
AzureComputeServiceLiveTest>BaseComputeServiceLiveTest.testOptionToNotBlock:850->BaseComputeServiceLiveTest.buildTemplate:541
 » Provision
  
AzureComputeServiceLiveTest>BaseComputeServiceLiveTest.testWeCanCancelTasks:282->BaseComputeServiceLiveTest.buildTemplate:541
 » Provision
  
AzureComputeServiceLiveTest>BaseComputeServiceLiveTest.testTemplateMatch:341->BaseComputeServiceLiveTest.buildTemplate:541
 » Provision
  
AzureTemplateBuilderLiveTest>BaseTemplateBuilderLiveTest.testGetAssignableLocations:104->BaseTemplateBuilderLiveTest.assertProvider:225
 Sets differ: expected [US-IA, US-VA, US-IL, US-TX, US-CA, IE, NL, HK, SG, 
JP-11, JP-27, BR, AU-NSW, AU-VIC] but got [US-IA, US-VA, US-IL, US-TX, US-CA, 
IE, NL, HK, SG, JP-11, JP-27, BR, AU-NSW, AU-VIC, IN-GA, IN-TN, IN-MH, CN-SH, 
CN-BJ, CA-ON, CA-QC]
  
AzureTemplateBuilderLiveTest>BaseTemplateBuilderLiveTest.testTemplateBuilderWithLoginUserSpecified:189->BaseTemplateBuilderLiveTest.tryOverrideUsingPropertyKey:213
 expected [[user=foo, passwordPresent=true, privateKeyPresent=false, 
shouldAuthenticateSudo=true]] but found [[user=jclouds, passwordPresent=true, 
privateKeyPresent=false, shouldAuthenticateSudo=false]]
  
AzureComputeImageExtensionLiveTest>BaseImageExtensionLiveTest.testCreateImage:106
 » Execution
  NetworkInterfaceCardApiLiveTest.createNetworkInterfaceCard:89 » HttpResponse 
c...
  NetworkSecurityGroupApiLiveTest.deleteNetworkSecurityGroupDoesNotExist:61 » 
IllegalState
  NetworkSecurityRuleApiLiveTest.deleteNetworkSecurityRuleDoesNotExist:86 » 
IllegalState
  SubnetApiLiveTest.deleteSubnetResourceDoesNotExist:61 expected [false] but 
found [true]
  VirtualNetworkApiLiveTest.deleteVirtualNetworkResourceDoesNotExist:56 
expected [false] but found [true]
  PublicIPAddressApiLiveTest.getPublicIPAddress:103 » NullPointer
  PublicIPAddressApiLiveTest.listPublicIPAddresses:126 expected [true] but 
found [false]
  
NetworkSecurityGroupApiLiveTest.tearDown:56->BaseAzureComputeApiLiveTest.deleteResourceGroup:144
 » NullPointer
  
NetworkSecurityRuleApiLiveTest.tearDown:81->BaseAzureComputeApiLiveTest.deleteResourceGroup:144
 » NullPointer
  PublicIPAddressApiLiveTest.deletePublicIPAddress:132 » ResourceNotFound 
org.jc...
  
PublicIPAddressApiLiveTest.tearDown:56->BaseAzureComputeApiLiveTest.deleteResourceGroup:144
 » NullPointer
  SubnetApiLiveTest.deleteSubnet:92 » ResourceNotFound 
org.jclouds.http.HttpResp...
  
SubnetApiLiveTest.tearDown:55->BaseAzureComputeApiLiveTest.deleteResourceGroup:144
 » NullPointer
  VirtualNetworkApiLiveTest.deleteVirtualNetwork:89 » ResourceNotFound 
org.jclou...
  
VirtualNetworkApiLiveTest.tearDown:50->BaseAzureComputeApiLiveTest.deleteResourceGroup:144
 » NullPointer
  
VirtualMachineApiLiveTest.setup:82->BaseAzureComputeApiLiveTest.getOrCreateNetworkInterfaceCard:245
 » HttpResponse

Tests run: 116, Failures: 25, Errors: 0, Skipped: 47
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/317#issuecomment-248647285

[jclouds/jclouds-labs] Use the existing region suppliers to filter (#321)

[Ignasi Barrera]

@andreaturli Can you give this a try?
You can view, comment on, or merge this pull request online at:

  https://github.com/jclouds/jclouds-labs/pull/321

-- Commit Summary --

  * Use the existing region suppliers to filter

-- File Changes --

M 
azurecompute-arm/src/main/java/org/jclouds/azurecompute/arm/compute/AzureComputeServiceAdapter.java
 (59)
A 
azurecompute-arm/src/main/java/org/jclouds/azurecompute/arm/compute/predicates/IsDeploymentInRegions.java
 (46)

-- Patch Links --

https://github.com/jclouds/jclouds-labs/pull/321.patch
https://github.com/jclouds/jclouds-labs/pull/321.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/321

Re: [jclouds/jclouds-labs] separate the DeploymentToVMDeployment to a function (#320)

[Andrea Turli]

thx @nacx, merged at 
[master](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/28c56e06)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/320#issuecomment-248632037

Re: [jclouds/jclouds-labs] separate the DeploymentToVMDeployment to a function (#320)

[Andrea Turli]

Closed #320.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/320#event-797411872

Re: [jclouds/jclouds-labs] separate the DeploymentToVMDeployment to a function (#320)

[Ignasi Barrera]

nacx approved this pull request.



> private final ProviderMetadata providerMetadata;
+   private final DeploymentToVMDeployment deploymentToVMDeployment;

Better declare and inject it as `Function` to make it 
easier to re-bind.

> @@ -288,7 +279,7 @@ public VMImage getImage(final String id) {
 
@Override
public Iterable listLocations() {
-  final Iterable whiteListZoneName = findWhiteListOfRegions();
+  final Iterable whiteListedRegionNames = findWhiteListOfRegions();

You are parsing this list in several places. Just call this in the constructor 
and assign to a class final variable.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/320#pullrequestreview-960424

Re: [jclouds/jclouds-labs] separate the DeploymentToVMDeployment to a function (#320)

[Ignasi Barrera]

Just minors. let's merge it, since I plan to open a PR with the minor fixes in 
a while.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/320#issuecomment-248627353

[jira] [Updated] (JCLOUDS-1182) Missing region in `listAssignableLocations` for AWS EC2

[Abdysamat Mamutov (JIRA)]

 [ 
https://issues.apache.org/jira/browse/JCLOUDS-1182?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Abdysamat Mamutov updated JCLOUDS-1182:
---
Affects Version/s: 2.0.0

> Missing region in `listAssignableLocations` for AWS EC2
> ---
>
> Key: JCLOUDS-1182
> URL: https://issues.apache.org/jira/browse/JCLOUDS-1182
> Project: jclouds
>  Issue Type: Bug
>  Components: jclouds-compute
>Affects Versions: 2.0.0
>Reporter: Abdysamat Mamutov
>
> In the following example:
> {code:java}
> context = ContextBuilder.newBuilder("aws-ec2" )
> .credentials(accessKey, secretKey)
> .modules( ImmutableSet. of(new 
> Log4JLoggingModule(), new JschSshClientModule() ) )
> .overrides( properties )
> .buildView(ComputeServiceContext.class);
> computeService = context.getComputeService();
> computeService.listAssignableLocations()
> {code}
> in the returned list i don't see *ap-northeast-2* region (Seul).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (JCLOUDS-1182) Missing region in `listAssignableLocations` for AWS EC2

[Abdysamat Mamutov (JIRA)]

 [ 
https://issues.apache.org/jira/browse/JCLOUDS-1182?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Abdysamat Mamutov updated JCLOUDS-1182:
---
Component/s: jclouds-compute

> Missing region in `listAssignableLocations` for AWS EC2
> ---
>
> Key: JCLOUDS-1182
> URL: https://issues.apache.org/jira/browse/JCLOUDS-1182
> Project: jclouds
>  Issue Type: Bug
>  Components: jclouds-compute
>Reporter: Abdysamat Mamutov
>
> In the following example:
> {code:java}
> context = ContextBuilder.newBuilder("aws-ec2" )
> .credentials(accessKey, secretKey)
> .modules( ImmutableSet. of(new 
> Log4JLoggingModule(), new JschSshClientModule() ) )
> .overrides( properties )
> .buildView(ComputeServiceContext.class);
> computeService = context.getComputeService();
> computeService.listAssignableLocations()
> {code}
> in the returned list i don't see *ap-northeast-2* region (Seul).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jclouds/jclouds] Better predicate signature for node operations (#1011)

[Ignasi Barrera]

This changes the signature of the compute methods to have better predicates for 
nodes. Without this, most methods could only use a `Predicate` 
or a `Predicate`, which was pretty inconvenient, because generic 
predicates such as `NodePredicates.all()` or concrete ones like 
`NodePredicates.inGroup("")` could not be used in all methods.

This change should be backwards compatible regarding client code and will allow 
to use all node and generic predicates in all node methods.

/cc @andreaturli 
You can view, comment on, or merge this pull request online at:

  https://github.com/jclouds/jclouds/pull/1011

-- Commit Summary --

  * Better predicate signature for node operations

-- File Changes --

M 
apis/ec2/src/main/java/org/jclouds/ec2/compute/strategy/EC2ListNodesStrategy.java
 (2)
M compute/src/main/java/org/jclouds/compute/ComputeService.java (20)
M 
compute/src/main/java/org/jclouds/compute/internal/BaseComputeService.java (22)
M compute/src/main/java/org/jclouds/compute/strategy/ListNodesStrategy.java 
(2)
M 
compute/src/main/java/org/jclouds/compute/strategy/impl/AdaptingComputeServiceStrategies.java
 (2)
M 
compute/src/test/java/org/jclouds/compute/internal/BaseComputeServiceLiveTest.java
 (2)
M 
providers/google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/compute/GoogleComputeEngineService.java
 (2)

-- Patch Links --

https://github.com/jclouds/jclouds/pull/1011.patch
https://github.com/jclouds/jclouds/pull/1011.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1011

[jira] [Commented] (JCLOUDS-664) Azure compute support

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/JCLOUDS-664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15509550#comment-15509550
 ] 

ASF subversion and git services commented on JCLOUDS-664:
-

Commit 1ed73848bee4bbfa6165e98c08edd4a44c9482cf in jclouds-cli's branch 
refs/heads/master from [~nacx]
[ https://git-wip-us.apache.org/repos/asf?p=jclouds-cli.git;h=1ed7384 ]

JCLOUDS-664: Added Azure ARM to jclouds-cli


> Azure compute support
> -
>
> Key: JCLOUDS-664
> URL: https://issues.apache.org/jira/browse/JCLOUDS-664
> Project: jclouds
>  Issue Type: New Feature
>  Components: jclouds-compute, jclouds-labs
>Affects Versions: 2.0.0
>Reporter: Andrew Bayer
>  Labels: azure
> Fix For: 2.0.0
>
> Attachments: JCLOUDS-664.patch
>
>
> So we've got a very old, very stale, very incomplete azure-management (a.k.a. 
> compute) implementation in labs. Let's actually modernize and finish that 
> thing. Azure is unquestionably the biggest cloud out there that we don't have 
> viable support for, so it's a really useful target.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jclouds/jclouds-cli] JCLOUDS-664: Added Azure ARM to jclouds-cli (#33)

[Ignasi Barrera]

You can view, comment on, or merge this pull request online at:

  https://github.com/jclouds/jclouds-cli/pull/33

-- Commit Summary --

  * JCLOUDS-664: Added Azure ARM to jclouds-cli

-- File Changes --

M assembly/pom.xml (1)

-- Patch Links --

https://github.com/jclouds/jclouds-cli/pull/33.patch
https://github.com/jclouds/jclouds-cli/pull/33.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-cli/pull/33

Re: [jclouds/jclouds-karaf] Added Azure ARM (#84)

[Ignasi Barrera]

Yay! It worked just adding the feature :) I've squashed the commits and merged 
to master as 
[b1152f3d](http://git-wip-us.apache.org/repos/asf/jclouds-karaf/commit/b1152f3d).
Thanks for all the help @demobox!
BTW, the ServiceMix bundles will be released by the end of this month, so 
perhaps we are on time to update and remove ours if we have not released 2.0 
yet.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/84#issuecomment-248549414

Re: [jclouds/jclouds-karaf] Added Azure ARM (#84)

[Ignasi Barrera]

Closed #84.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/84#event-796949828

[jira] [Commented] (JCLOUDS-664) Azure compute support

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/JCLOUDS-664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15509241#comment-15509241
 ] 

ASF subversion and git services commented on JCLOUDS-664:
-

Commit b1152f3dc6f929edb6de26d7f14a8127689f91bc in jclouds-karaf's branch 
refs/heads/master from [~nacx]
[ https://git-wip-us.apache.org/repos/asf?p=jclouds-karaf.git;h=b1152f3 ]

JCLOUDS-664: Added Azure ARM to jclouds-karaf


> Azure compute support
> -
>
> Key: JCLOUDS-664
> URL: https://issues.apache.org/jira/browse/JCLOUDS-664
> Project: jclouds
>  Issue Type: New Feature
>  Components: jclouds-compute, jclouds-labs
>Affects Versions: 2.0.0
>Reporter: Andrew Bayer
>  Labels: azure
> Fix For: 2.0.0
>
> Attachments: JCLOUDS-664.patch
>
>
> So we've got a very old, very stale, very incomplete azure-management (a.k.a. 
> compute) implementation in labs. Let's actually modernize and finish that 
> thing. Azure is unquestionably the biggest cloud out there that we don't have 
> viable support for, so it's a really useful target.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: [jclouds/jclouds-karaf] Added Azure ARM (#84)

[Ignasi Barrera]

@nacx pushed 1 commit.

3371b37  Added missing Azure ARM feature


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/84/files/91f25d4305c928801fe980d98aee48fedd6406f6..3371b37b8403a3a61087e35b6477c75c37e3ebc4

Re: [jclouds/jclouds-karaf] Added Azure ARM (#84)

[Ignasi Barrera]

Sure :) I'll add it there and update the PR, and if it still fails I'll add the 
dependency to the root pom (I don't really know the details of how it works but 
I bet we'd need both)... And I'll try to cleanup my local env and see if I can 
make it fail the same way our CI builds fail!


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/84#issuecomment-248534770

Re: [jclouds/jclouds-karaf] Added Azure ARM (#84)

[Ignasi Barrera]

Makes sense. I copied how our jclouds oauth lib is configured, as they are the 
same kind of dependency, and I have not found any differences...

Wait! Perhaps oauth works because our google-common is declared in the root 
pom.xml and it brings oauth as a transitive dependency?

I'll try adding the okhttp driver there in a while (I'm in the train now :)) of 
you don't beat me!

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/84#issuecomment-248527257