Re: [jclouds/jclouds-labs] fix azure-arm features live tests (#317)

@andreaturli pushed 1 commit. 071c533 fix checkstyle -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-labs/pull/317/files/388177aa18ed03c633a3216f7dbc15be2c51..071c533908fc8e908074f0bd6fc6deb75d325782

Re: [jclouds/jclouds-labs] fix azure-arm features live tests (#317)

Yay! This is great progress @andreaturli! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/317#issuecomment-249677283

Re: [jclouds/jclouds] Add keystone authentication with an existing token (#1009)

nacx commented on this pull request. > @@ -234,6 +234,13 @@ public String get() { return authenticationMethods.get(credentialType); } + @Provides + @Singleton + @Named("credentialsRetryable") + protected final boolean credentialsRetryable(Function

Re: [jclouds/jclouds-labs] JCLOUDS-1181 oneandone-vpn-api (#319)

nacx requested changes on this pull request. Done reviewing. Thanks @alibazlamit! > @@ -62,9 +65,10 @@ @Named("vpn:configurations:get") @GET @Path("/{vpnId}/configuration_file") - @SelectJson("config_zip_file") + @ResponseParser(VPNConfigParser.class) Is this parser class

Re: [jclouds/jclouds] Remove hardcoded content size for personality in Openstack Nova (#1012)

I wouldn't be opposed, though I don't think refactoring old code to remove such checks is strictly necessary or high priority (unless actually needed). -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [jclouds/jclouds] Add keystone authentication with an existing token (#1009)

zack-shoylev commented on this pull request. > @@ -234,6 +234,13 @@ public String get() { return authenticationMethods.get(credentialType); } + @Provides + @Singleton + @Named("credentialsRetryable") + protected final boolean credentialsRetryable(Function

Re: [jclouds/jclouds-labs] fix azure-arm features live tests (#317)

``` Results : Failed tests: AzureComputeServiceLiveTest>BaseComputeServiceLiveTest.testCompareSizes:887->BaseComputeServiceLiveTest.doCompareSizes:891 » Provision

Re: [jclouds/jclouds-labs] JCLOUDS-1181 oneandone-vpn-api (#319)

alibazlamit commented on this pull request. > + @GET + @Fallback(Fallbacks.EmptyListOnNotFoundOr404.class) + List getList(GenericQueryOptions options); + + @Named("vpn:get") + @GET + @Path("/{vpnId}") + @Fallback(Fallbacks.NullOnNotFoundOr404.class) + Vpn get(@PathParam("vpnId")

Re: [jclouds/jclouds-labs] JCLOUDS-1181 oneandone-vpn-api (#319)

@alibazlamit pushed 1 commit. debbc9b Fixed eol -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-labs/pull/319/files/cdc081ebd87932804176473980ef7faf59076b4a..debbc9b5bc3c2d072ee55d9f184d3c59ed778fb8

Re: [jclouds/jclouds-labs] JCLOUDS-1181 oneandone-vpn-api (#319)

@alibazlamit pushed 1 commit. cdc081e Updated Changes. -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-labs/pull/319/files/4f275a8ce0ed1e4738587b3ed6a9e410cf70a259..cdc081ebd87932804176473980ef7faf59076b4a

Re: [jclouds/jclouds] GCE live test fixes (#1015)

+1 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1015#issuecomment-249585667

Re: [jclouds/jclouds] GCE live test fixes (#1015)

I'll merge it and I'll move tot he Azure ARM compute service live tests. The test that is failing shouldn't block the release. WDYT? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [jclouds/jclouds] GCE live test fixes (#1015)

great! you want to continue on this PR or prefer merging it and work on the last failing test on a different PR? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [jclouds/jclouds] rename oauth properties (#1014)

thx @nacx for the explanation! I'll close the pr as not needed -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1014#issuecomment-249579672

Re: [jclouds/jclouds] rename oauth properties (#1014)

Closed #1014. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1014#event-802329941

Re: [jclouds/jclouds] rename oauth properties (#1014)

Well, I'd say the wrong properties are the ones you point in this last comment, as they double-prefix the property. When jclouds creates the context, it tries to resolve the properties that are prefixed with the "provider id", and if not, it tries to resolve them with the "jclouds" prefix. You

[jclouds/jclouds] GCE live test fixes (#1015)

This fixes all live tests except one. We're close to having all green! You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds/pull/1015 -- Commit Summary -- * GCE live test fixes -- File Changes -- M

Re: [jclouds/jclouds] rename oauth properties (#1014)

because I thought it was jclouds's convention, thinking about stuff like ``` public static final String AUTO_ALLOCATE_FLOATING_IPS = "jclouds.openstack-nova.auto-create-floating-ips"; ``` so for simmetry I'd have expected that for oauth things as well, no? -- You are receiving this because you

Re: [jclouds/jclouds] rename oauth properties (#1014)

Why do you want to pass it like that? I mean, you are providing properties of two different jclouds providers/apis: "azurecompute-arm" and "oauth". And you are passing both using the jclouds convention `.endpoint`. Why do you want to change that add a prefix to one of the properties? -- You

Re: [jclouds/jclouds] rename oauth properties (#1014)

thanks @nacx but I don't follow completely. For example, to run tests in `jclouds-labs/azurecompute-arm` I need to specify: ``` mvn clean install -Plive -Dtest.azurecompute-arm.identity="identity" -Dtest.azurecompute-arm.credential="password"

Re: [jclouds/jclouds] Add keystone authentication with an existing token (#1009)

nacx commented on this pull request. > @@ -234,6 +234,13 @@ public String get() { return authenticationMethods.get(credentialType); } + @Provides + @Singleton + @Named("credentialsRetryable") + protected final boolean credentialsRetryable(Function

Re: [jclouds/jclouds] rename oauth properties (#1014)

:-1: jclouds alrady reads properties in the form: `.`, so you can configure properties (endpoints, for example) for multiple providers: * `aws-ec2.endpoint` * `openstack-nova.endpoint` * `openstack-nova.identity` If no provider specific property is found, jclouds fallsback to the `jclouds`

Re: [jclouds/jclouds-labs] Pb compute api (#292)

@devcsrj How close would you say we are to closing this PR? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/292#issuecomment-249547764

Re: [jclouds/jclouds-labs] Pb compute api (#292)

@alibazlamit pushed 1 commit. 9ecf22e minor fix -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-labs/pull/292/files/12a9a959ffc4343e260c4123091b9d5de5d972ea..9ecf22eec6ee480a81f989007465edbe872c19f7

[jclouds/jclouds] rename oauth properties (#1014)

- oauth.{endpoint.identity, credential} to jclouds.oauth.{endpoint, identity, credential} @nacx what do you think? I think it is more homogenous this way You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds/pull/1014 -- Commit Summary -- *