Re: [jclouds/jclouds] Configure Java 7 language level (#1224)

2018-07-11 Thread Andrew Phillips
demobox commented on this pull request. > @@ -1280,7 +1280,10 @@ org.gaul modernizer-maven-plugin +

Re: [jclouds/jclouds-labs] JCLOUDS-1432 - handle RESOURCE_NOT_FOUND, (#439)

2018-07-11 Thread Ignasi Barrera
Everything should be in place now in jclouds-core: rebuild please -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/439#issuecomment-404305499

[jclouds/jclouds] Adds missing virtualMachine field to NetworkInterfaceCardProperties (#1229)

2018-07-11 Thread Daniel Estévez
You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds/pull/1229 -- Commit Summary -- * Adds missing virtualMachine field to NetworkInterfaceCardProperties -- File Changes -- M

Re: [jclouds/jclouds] [JCLOUDS-1401] Properly URL-encode the CanonicalQueryString when it contains funny characters (#1226)

2018-07-11 Thread Jesse Glick
@nacx > if you run just the S3 ones and pass the endpoint, all succeed Confirmed that when running `S3ClientLiveTest` directly in the `s3` module, with the endpoint defined, all tests pass including `testCopyCannedAccessPolicyPublic` and `testPutCannedAccessPolicyPublic`. So there must be

Build failed in Jenkins: jclouds-cli #1676

2018-07-11 Thread jenkins-no-reply
See -- [...truncated 679.38 KB...] [INFO] --- duplicate-finder-maven-plugin:1.1.2:check (default) @ jclouds-cli-assembly --- [INFO] Skipping duplicate-finder execution! [INFO] [INFO]

Build failed in Jenkins: jclouds-cli #1675

2018-07-11 Thread jenkins-no-reply
See -- [...truncated 650.68 KB...] [JENKINS] Recording test results [INFO] Skipping duplicate-finder execution! [INFO] [INFO] --- maven-checkstyle-plugin:2.15:check (default) @

Re: [jclouds/jclouds] Configure Java 7 language level (3839432)

2018-07-11 Thread Jesse Glick
Suggest then turning `BaseBlobStoreIntegrationTest.getContainerName` / `.returnContainer` into an `AutoCloseable` to simplify test code. (Or you could have this be automatic in a tear-down method…) -- You are receiving this because you are subscribed to this thread. Reply to this email

Re: [jclouds/jclouds] Allow S3ClientLiveTest (and AWSS3ClientLiveTest) to use a session token. (34d272a)

2018-07-11 Thread Jesse Glick
from #1226 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/commit/34d272ac801971ef6115b01ab9c3984b5d523f7e#commitcomment-29674407

Re: [jclouds/jclouds] [JCLOUDS-1401] Properly URL-encode the CanonicalQueryString when it contains funny characters. (f770455)

2018-07-11 Thread Jesse Glick
from #1226 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/commit/f770455ff9f53a9413353cc0d4d534a3e1f6fb83#commitcomment-29674409

Re: [jclouds/jclouds] Live test demonstrating effectiveness of JCLOUDS-1401 fix. (9a65be7)

2018-07-11 Thread Jesse Glick
from #1226 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/commit/9a65be789e760cf279b6df525d6bfc7bd94732dd#commitcomment-29674406

Re: [jclouds/jclouds] Pinning down JCLOUDS-1401 fix behavior with a unit test which is able to distinguish URI.query from URI.rawQuery. (019ccb7)

2018-07-11 Thread Jesse Glick
from #1226 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/commit/019ccb74316374498f9fdac0339621b2a3b6ad76#commitcomment-29674403

Re: [jclouds/jclouds] Adds ConcurrentModificationException to the list of propagable types (#1227)

2018-07-11 Thread Ignasi Barrera
Closed #1227. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1227#event-1728432145

Re: [jclouds/jclouds] Adds ConcurrentModificationException to the list of propagable types (#1227)

2018-07-11 Thread Ignasi Barrera
Merged to master and 2.1.x -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1227#issuecomment-404237820

Re: [jclouds/jclouds] Configure Java 7 language level (#1224)

2018-07-11 Thread Ignasi Barrera
Merged to master -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1224#issuecomment-404236734

Re: [jclouds/jclouds] Configure Java 7 language level (#1224)

2018-07-11 Thread Ignasi Barrera
Closed #1224. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1224#event-1728425037

[jira] [Resolved] (JCLOUDS-1401) S3 SignatureDoesNotMatch when listing keys using prefix with ampersand

2018-07-11 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignasi Barrera resolved JCLOUDS-1401. - Resolution: Fixed Fix Version/s: 2.1.1 2.2.0 > S3

Re: [jclouds/jclouds] [JCLOUDS-1401] Properly URL-encode the CanonicalQueryString when it contains funny characters (#1226)

2018-07-11 Thread Ignasi Barrera
Closed #1226. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1226#event-1728411664

Re: [jclouds/jclouds] [JCLOUDS-1401] Properly URL-encode the CanonicalQueryString when it contains funny characters (#1226)

2018-07-11 Thread Ignasi Barrera
Thanks for the patch and for taking your time to run the live tests @jglick! Merged to master and 2.1.x. I'll have a look at the failing tests, as if you run just the S3 ones and pass the endpoint, all succeed. There must be some minor mess about the endpoints in the aws-s3 tests. -- You are

[jira] [Commented] (JCLOUDS-1401) S3 SignatureDoesNotMatch when listing keys using prefix with ampersand

2018-07-11 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16540352#comment-16540352 ] ASF subversion and git services commented on JCLOUDS-1401: -- Commit

[jira] [Commented] (JCLOUDS-1401) S3 SignatureDoesNotMatch when listing keys using prefix with ampersand

2018-07-11 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16540353#comment-16540353 ] ASF subversion and git services commented on JCLOUDS-1401: -- Commit

[jira] [Commented] (JCLOUDS-1401) S3 SignatureDoesNotMatch when listing keys using prefix with ampersand

2018-07-11 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16540354#comment-16540354 ] ASF subversion and git services commented on JCLOUDS-1401: -- Commit

[jira] [Commented] (JCLOUDS-1401) S3 SignatureDoesNotMatch when listing keys using prefix with ampersand

2018-07-11 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16540349#comment-16540349 ] ASF subversion and git services commented on JCLOUDS-1401: -- Commit

[jira] [Commented] (JCLOUDS-1401) S3 SignatureDoesNotMatch when listing keys using prefix with ampersand

2018-07-11 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16540347#comment-16540347 ] ASF subversion and git services commented on JCLOUDS-1401: -- Commit

[jira] [Commented] (JCLOUDS-1401) S3 SignatureDoesNotMatch when listing keys using prefix with ampersand

2018-07-11 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16540348#comment-16540348 ] ASF subversion and git services commented on JCLOUDS-1401: -- Commit

Re: [jclouds/jclouds] [JCLOUDS-1401] Properly URL-encode the CanonicalQueryString when it contains funny characters (#1226)

2018-07-11 Thread Ignasi Barrera
nacx approved this pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1226#pullrequestreview-136323635

Re: [jclouds/jclouds] [JCLOUDS-1401] Properly URL-encode the CanonicalQueryString when it contains funny characters (#1226)

2018-07-11 Thread Oleg Nenashev
oleg-nenashev approved this pull request. Looks good -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1226#pullrequestreview-136290748

Re: [jclouds/jclouds] [JCLOUDS-1401] Properly URL-encode the CanonicalQueryString when it contains funny characters (#1226)

2018-07-11 Thread Carlos Sanchez
carlossg approved this pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1226#pullrequestreview-136283174

Re: [jclouds/jclouds] [JCLOUDS-1401] Properly URL-encode the CanonicalQueryString when it contains funny characters (#1226)

2018-07-11 Thread Jesse Glick
jglick commented on this pull request. @nacx please take another look. I added both a unit test and a live test. A mock test seems redundant given those. > @@ -507,6 +538,23 @@ public void testCopyWithMetadata() throws > InterruptedException, ExecutionExcepti } } + //

Re: [jclouds/jclouds] [JCLOUDS-1401] Properly URL-encode the CanonicalQueryString when it contains funny characters (#1226)

2018-07-11 Thread Jesse Glick
@jglick pushed 2 commits. 3ad84f1 Live test demonstrating effectiveness of JCLOUDS-1401 fix. 793b728 Pinning down JCLOUDS-1401 fix behavior with a unit test which is able to distinguish URI.query from URI.rawQuery. -- You are receiving this because you are subscribed to this thread. View it

Re: [jclouds/jclouds-labs] JCLOUDS-1432 - handle RESOURCE_NOT_FOUND, (#439)

2018-07-11 Thread FileIOUtility
@FileIOUtility pushed 1 commit. 56fb4bc JCLOUDS-1432 - removed unused import -- You are receiving this because you are subscribed to this thread. View it on GitHub: