[jclouds/jclouds] Use temporary file for Swift test inputs (#1035)

2016-11-07 Thread Andrew Gaul
This avoids creating junk in the source directory. You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds/pull/1035 -- Commit Summary -- * Use temporary file for Swift test inputs -- File Changes -- M apis/openstack-swift/src/test/java/org/j

Re: [jclouds/jclouds] Use temporary file for Swift test inputs (#1035)

2016-11-07 Thread Andrew Gaul
@zack-shoylev Please review. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1035#issuecomment-258931853

Re: [jclouds/jclouds-labs] Remove duplicated sharedstorage test inputs (#335)

2016-11-07 Thread Andrew Gaul
`diff -r oneandone/src/test/resources/shared*` confirms that these files are identical. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/335#issuecomment-258985542

[jclouds/jclouds] Include part size in listMultipartUpload result (#1037)

2016-11-08 Thread Andrew Gaul
Clients use this during completeMultipartUpload. You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds/pull/1037 -- Commit Summary -- * Include part size in listMultipartUpload result -- File Changes -- M blobstore/src/main/java/org/jclouds/

Re: [jclouds/jclouds] Include part size in listMultipartUpload result (#1037)

2016-11-09 Thread Andrew Gaul
This causes integration test failures since `uploadMultipartPart` does not correctly return `partSize` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1037#issuecomment-259466971

Re: [jclouds/jclouds] Use temporary file for Swift test inputs (#1035)

2016-11-09 Thread Andrew Gaul
I discovered a more serious issue in `RegionScopedSwiftBlobStore.downloadBlob` which creates a temporary file with a relative path. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1035

Re: [jclouds/jclouds] Use temporary file for Swift test inputs (#1035)

2016-11-09 Thread Andrew Gaul
andrewgaul commented on this pull request. > @@ -679,7 +679,7 @@ public void downloadBlob(String container, String name, > File destination, Execut ListeningExecutorService listeningExecutor = MoreExecutors.listeningDecorator(executor); RandomAccessFile raf = null; - File

Re: [jclouds/jclouds] Use temporary file for Swift test inputs (#1035)

2016-11-09 Thread Andrew Gaul
andrewgaul commented on this pull request. > @@ -121,7 +126,7 @@ public void uploadMultipartBlob() { @Test(dependsOnMethods = "uploadMultipartBlob", singleThreaded = true) public void downloadParallelBlob() throws IOException { - final File downloadedFile = new File(BIG_FILE.getNa

Re: [jclouds/jclouds] Use temporary file for Swift test inputs (#1035)

2016-11-09 Thread Andrew Gaul
andrewgaul commented on this pull request. > @@ -679,7 +679,7 @@ public void downloadBlob(String container, String name, > File destination, Execut ListeningExecutorService listeningExecutor = MoreExecutors.listeningDecorator(executor); RandomAccessFile raf = null; - File

Re: [jclouds/jclouds] Use temporary file for Swift test inputs (#1035)

2016-11-09 Thread Andrew Gaul
andrewgaul commented on this pull request. > @@ -121,7 +126,7 @@ public void uploadMultipartBlob() { @Test(dependsOnMethods = "uploadMultipartBlob", singleThreaded = true) public void downloadParallelBlob() throws IOException { - final File downloadedFile = new File(BIG_FILE.getNa

Re: [jclouds/jclouds-karaf] Take into account the credentials file in GCE (#87)

2016-11-10 Thread Andrew Gaul
Does google-cloud-storage need a similar fix? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-karaf/pull/87#issuecomment-259763915

Re: [jclouds/jclouds-site] Initial draft for the 2.0.0 release notes (#188)

2016-11-14 Thread Andrew Gaul
andrewgaul commented on this pull request. > +The complete list of fixed issues and improvements can be found > [here](https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12327379&styleName=Html&projectId=12314430). + +We have also improved [our CI system](https://jclouds.ci.cloudbee

Re: [jclouds/jclouds-site] Align style of describing compute and blobstore improvements (#189)

2016-11-14 Thread Andrew Gaul
๐Ÿ‘ -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/189#issuecomment-260554927

Re: [jclouds/jclouds-karaf] Properly encapsulate google credential processing (#88)

2016-11-23 Thread Andrew Gaul
๐Ÿ‘ -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-karaf/pull/88#issuecomment-262581547

Re: [jclouds/jclouds-examples] update blobstore-basics to use 2.0.0 (#90)

2016-11-24 Thread Andrew Gaul
andrewgaul requested changes on this pull request. > @@ -138,6 +154,10 @@ public static void main(String[] args) throws > IOException { } } finally { + // delete cointainer + if (blobStore.containerExists(containerName)) { Should be OK to remove `con

Re: [jclouds/jclouds-examples] update blobstore-basics to use 2.0.0 (#90)

2016-11-24 Thread Andrew Gaul
andrewgaul requested changes on this pull request. > @@ -51,6 +51,11 @@ google-compute-engine ${jclouds.version} + + io.cloudsoft.jclouds.api + openstack-mitaka-nova + 1.9.3-cloudsoft.20160831 + What is this for? > // Create Container -

Re: [jclouds/jclouds-examples] update blobstore-basics to use 2.0.0 (#90)

2016-11-25 Thread Andrew Gaul
andrewgaul commented on this pull request. > // Create Container - BlobStore blobStore = context.getBlobStore(); Location location = null; Let's leave this as-is. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or v

Re: [jclouds/jclouds-examples] update blobstore-basics to use 2.0.0 (#90)

2016-11-25 Thread Andrew Gaul
andrewgaul approved this pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-examples/pull/90#pullrequestreview-10201682

[jclouds/jclouds] JCLOUDS-1223: Use larger block blobs for Azure (#1050)

2017-01-08 Thread Andrew Gaul
This raises the maximum multipart size from 195 GB to 4.77 TB. Reference: https://azure.microsoft.com/en-us/blog/general-availability-larger-block-blobs-in-azure-storage/ You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds/pull/1050 -- Commit

[jclouds/jclouds-labs] Update B2 domain (#339)

2017-01-09 Thread Andrew Gaul
The old domain will no longer function after 2 Feb 2017. Reference: https://help.backblaze.com/hc/en-us/articles/224959187-B2-Domain-Migration-Plan You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds-labs/pull/339 -- Commit Summary -- * Update

Re: [jclouds/jclouds] GetBucketLocation should use path-style requests. (#1052)

2017-01-11 Thread Andrew Gaul
I could not verify the original symptoms but the fix makes sense and passes integration tests against AWS S3 and DreamObjects. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1052#issu

[jclouds/jclouds] JCLOUDS-1228: Include PublicAccess in responses (#1054)

2017-01-20 Thread Andrew Gaul
REST API version 2016-05-31 includes PublicAccess in List Containers and Get Container Properties APIs. You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds/pull/1054 -- Commit Summary -- * JCLOUDS-1228: Include PublicAccess in responses -- File

Re: [jclouds/jclouds] Correct regex in ExpandProperties (#1055)

2017-01-24 Thread Andrew Gaul
@nacx Please review. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1055#issuecomment-275036651

[jclouds/jclouds] Correct regex in ExpandProperties (#1055)

2017-01-24 Thread Andrew Gaul
Previously Android choked on this incomplete regex. You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds/pull/1055 -- Commit Summary -- * Correct regex in ExpandProperties -- File Changes -- M core/src/main/java/org/jclouds/functions/Expand

Re: [jclouds/jclouds] Correct regex in ExpandProperties (#1055)

2017-01-25 Thread Andrew Gaul
Yeah jclouds does not work with Android for a few different reasons. I gave up when Guice threw some codegen errors. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1055#issuecomment-

Re: [jclouds/jclouds-site] Promote ApacheCon (#193)

2017-01-26 Thread Andrew Gaul
Should we wait until a jclouds talk is accepted before promoting ApacheCon? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/193#issuecomment-275605047

[jclouds/jclouds] Return lastModified and size when listing S3 parts (#1063)

2017-02-16 Thread Andrew Gaul
You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds/pull/1063 -- Commit Summary -- * Return lastModified and size when listing S3 parts -- File Changes -- M apis/s3/src/main/java/org/jclouds/s3/S3Client.java (14) A apis/s3/src/main/j

Re: [jclouds/jclouds] Return lastModified and size when listing S3 parts (#1063)

2017-02-16 Thread Andrew Gaul
Unfortunately this introduces a new method since we cannot change the `listMultipartParts` return type. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1063#issuecomment-280544153

Re: [jclouds/jclouds-site] Release notes for the 2.0.1 release (#195)

2017-02-19 Thread Andrew Gaul
andrewgaul approved this pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/195#pullrequestreview-22667783

Re: [jclouds/jclouds] Allow extending SwiftBlobStoreContextModule (#1069)

2017-03-01 Thread Andrew Gaul
I amended your commit to use a more descriptive message and include the correct JIRA link; please do this in the future. Also target the master branch and request a branch instead of targeting 2.0.x. Pushed to master as 8649002e03314e3e4ebe436021e5db56c20500a5 and 2.0.x as f76c09cbe6b31729f00

Re: [jclouds/jclouds] Allow extending SwiftBlobStoreContextModule (#1069)

2017-03-01 Thread Andrew Gaul
Closed #1069. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1069#event-982530939

Re: [jclouds/jclouds] Handle IOException for XATTRS when reading blob on Docker (#1066)

2017-03-01 Thread Andrew Gaul
Closed #1066. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1066#event-98264

Re: [jclouds/jclouds] Handle IOException for XATTRS when reading blob on Docker (#1066)

2017-03-01 Thread Andrew Gaul
Fixed whitespace, reworded commit message, and pushed to master as fbf62437c7e776422288564c419dc037dbd72dfa and 2.0.x as f210283cacf5a36e9d5cc303523f5730b95aae39. Thank you for your contribution @geertvanheusden! -- You are receiving this because you are subscribed to this thread. Reply to th

Re: [jclouds/jclouds] Remove all sonatype snapshot repositories (#1067)

2017-03-02 Thread Andrew Gaul
๐Ÿ‘ Please backport to 2.0.x since it may address failures such as: https://travis-ci.org/andrewgaul/s3proxy/builds/207098979 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1067#issueco

Re: [jclouds/jclouds] Remove all sonatype snapshot repositories (#1067)

2017-03-02 Thread Andrew Gaul
Never mind, a coincidence of errors. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1067#issuecomment-283744385

[jclouds/jclouds] JCLOUDS-1101: Upgrade to auto-value 1.4-rc2 (#1074)

2017-03-06 Thread Andrew Gaul
This resolves issues using Java 9. Release notes: https://github.com/google/auto/releases/tag/auto-value-1.4-rc2 You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds/pull/1074 -- Commit Summary -- * JCLOUDS-1101: Upgrade to auto-value 1.4-rc2

Re: [jclouds/jclouds] Return lastModified and size when listing S3 parts (#1063)

2017-03-06 Thread Andrew Gaul
andrewgaul commented on this pull request. > + */ +@Beta +public final class PartIdsFromHttpResponseFull extends ParseSax.HandlerWithResult> { + private final StringBuilder currentText = new StringBuilder(); + + private final DateService dateParser; + + private int partNumber; + private

Re: [jclouds/jclouds] Return lastModified and size when listing S3 parts (#1063)

2017-03-06 Thread Andrew Gaul
andrewgaul commented on this pull request. > +import com.google.auto.value.AutoValue; +import com.google.common.annotations.Beta; + +@AutoValue +@Beta +public abstract class ListMultipartUploadResponse { + public abstract int partNumber(); + public abstract Date lastModified(); + public ab

Re: [jclouds/jclouds] Return lastModified and size when listing S3 parts (#1063)

2017-03-06 Thread Andrew Gaul
Pushed to master as ec932321bde5662d8ecbef7cf5428a6017b07dd0 and 2.0.x as d2041667d770bcb865a7bfb451b5910dd9084d91. -- You are receiving this because you modified the open/close state. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1063#issuecomment-28

Re: [jclouds/jclouds] JCLOUDS-1101: Upgrade to auto-value 1.4-rc2 (#1074)

2017-03-07 Thread Andrew Gaul
Seems like everything has `provided`. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1074#issuecomment-284652611

Re: [jclouds/jclouds] JCLOUDS-1101: Upgrade to auto-value 1.4-rc2 (#1074)

2017-03-07 Thread Andrew Gaul
Verified that labs, karaf, and cli compile with this commit. -- You are receiving this because you modified the open/close state. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1074#issuecomment-284656827

Re: [jclouds/jclouds] Introduce BlobstoreCli (#487)

2017-03-20 Thread Andrew Gaul
Closed #487. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/487#event-1007818464

Re: [jclouds/jclouds-labs-google] JCLOUDS-1259: Add GCS multi-regional and coldline (78cf479)

2017-03-22 Thread Andrew Gaul
Is regional the same thing as standard? When I created a regional bucket in the console it created as standard. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/commit/78cf479cf

Re: [jclouds/jclouds-labs-google] JCLOUDS-1259: Add GCS multi-regional and coldline (78cf479)

2017-03-22 Thread Andrew Gaul
This is straightforward to fix and test -- could you submit a pull request? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/commit/78cf479cf0b394b81191cb6fffe6a0bb526e52cd#commit

Re: [jclouds/jclouds] Fix for Java 1.8 and Guice 4.1 (#1036)

2017-03-28 Thread Andrew Gaul
andrewgaul commented on this pull request. > @@ -82,7 +82,7 @@ public Function apply(HttpRequest in) { GeneratedHttpRequest request = GeneratedHttpRequest.class.cast(in); Function transformer; - Class> handler = getSaxResponseParserClassOrNull(request.getInvocation() +

Re: [jclouds/jclouds-site] Support apache disclaimer (#196)

2017-03-28 Thread Andrew Gaul
I am not convinced that jclouds will direct much traffic from our site to theirs. Do we have any analytics from the ApacheCon banner we added previously? Or any traffic numbers for our home page? -- You are receiving this because you are subscribed to this thread. Reply to this email directly

Re: [jclouds/jclouds] JCLOUDS-1263: URL encode object names from list object response before creating URIs with them (#1084)

2017-04-03 Thread Andrew Gaul
@matmannion Can you add a test to `ContainerApiLiveTest`? If you haven't run the integration tests before, you can do so via: ``` mvn integration-test -pl :openstack-swift -Plive -Dtest.rackspace-cloudfiles-us.identity="${JCLOUDS_IDENTITY}" -Dtest.rackspace-cloudfiles-us.credential="${JCLOUDS_

Re: [jclouds/jclouds] JCLOUDS-1264: Use core BindToJsonPayload to send OpenStack Swift multipart manifests (#1083)

2017-04-03 Thread Andrew Gaul
Ditto about integration tests, this time in `StaticLargeObjectApiLiveTest`. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1083#issuecomment-291394650

Re: [jclouds/jclouds] JCLOUDS-1263: URL encode object names from list object response before creating URIs with them (#1084)

2017-04-03 Thread Andrew Gaul
@matmannion Can you look at some of the earlier URL encoding commits to see if there is a better solution? @timuralp fixed a lot of these issues in [JCLOUDS-217](https://issues.apache.org/jira/browse/JCLOUDS-217). -- You are receiving this because you are subscribed to this thread. Reply to th

Re: [jclouds/jclouds] JCLOUDS-1264: Use core BindToJsonPayload to send OpenStack Swift multipart manifests (#1083)

2017-04-04 Thread Andrew Gaul
Squashed, reworded commit message, and pushed to master as d41101df5932043c3a8614552f25ab91194595ba. I encountered conflicts when cherry-picking to 2.0.x so please submit another pull request if you want to backport this. Thank you for your contribution @matmannion! -- You are receiving this

Re: [jclouds/jclouds] JCLOUDS-1264: Use core BindToJsonPayload to send OpenStack Swift multipart manifests (#1083)

2017-04-04 Thread Andrew Gaul
Closed #1083. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1083#event-1028296800

Re: [jclouds/jclouds] JCLOUDS-1263: URL encode object names from list object response before creating URIs with them (#1084)

2017-04-04 Thread Andrew Gaul
@matmannion Can you verify that the test does what you expect? `mvn integration-test -pl :rackspace-cloudfiles-us -Plive -Dtest=CloudFilesUSObjectApiLiveTest#testCreateAndListWithUnicodeCharacters` succeeds with and without your fix. -- You are receiving this because you are subscribed to thi

Re: [jclouds/jclouds] JCLOUDS-1258 S3 China Beijing Region Support (#1081)

2017-04-18 Thread Andrew Gaul
Do you actually have an AWS China account? This is seprate from the regular AWS accounts: https://www.amazonaws.cn/en/about-aws/china/#AWS_(China)_Accounts Unfortunately I lack a China account so I cannot test this. -- You are receiving this because you are subscribed to this thread. Reply to

[jclouds/jclouds-labs-google] JCLOUDS-902: Google Cloud Storage signed URLs (#175)

2017-04-19 Thread Andrew Gaul
You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds-labs-google/pull/175 -- Commit Summary -- * JCLOUDS-902: Google Cloud Storage signed URLs -- File Changes -- A google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/blobstor

Re: [jclouds/jclouds-labs-google] JCLOUDS-902: Google Cloud Storage signed URLs (#175)

2017-04-20 Thread Andrew Gaul
andrewgaul commented on this pull request. > @@ -29,5 +33,12 @@ protected void configure() { bind(ConsistencyModel.class).toInstance(ConsistencyModel.EVENTUAL); bind(BlobStore.class).to(GoogleCloudStorageBlobStore.class).in(Scopes.SINGLETON); + bind(BlobRequestSigner.cla

Re: [jclouds/jclouds-labs-google] JCLOUDS-902: Google Cloud Storage signed URLs (#175)

2017-04-20 Thread Andrew Gaul
andrewgaul commented on this pull request. > +import com.google.inject.name.Named; + +public final class GoogleCloudStorageBlobRequestSigner implements BlobRequestSigner { + private static final int DEFAULT_EXPIRY_SECONDS = 15 * 60; + private static final URI STORAGE_URL = URI.create("http

Re: [jclouds/jclouds] Fix default executor rejection policies (#1089)

2017-04-22 Thread Andrew Gaul
๐Ÿ‘ Outside the scope of this PR, we hoped to remove executors in [JCLOUDS-153](https://issues.apache.org/jira/browse/JCLOUDS-153). Is this still a goal? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/j

Re: [jclouds/jclouds] JClouds 1281- DLO Swift Implementation (#1090)

2017-04-29 Thread Andrew Gaul
andrewgaul requested changes on this pull request. Please address substantial comments and remove all stylistic changes. Also investigate these failed tests: ``` CloudFilesUSBlobIntegrationLiveTest>BaseBlobIntegrationTest.deleteObjectNoContainer:525 ยป NullPointer CloudFilesUSBlobIntegrat

Re: [jclouds/jclouds] JClouds 1281- DLO Swift Implementation (#1090)

2017-04-29 Thread Andrew Gaul
andrewgaul commented on this pull request. > return new > PageSetImpl(ImmutableList. of(), null); } else { - containerCache.put(container, Optional.of(objects.getContainer())); + //containerCache.put(container, Optional.of(objects.getContainer())); Why comment

Re: [jclouds/jclouds] JClouds 1281- DLO Swift Implementation (#1090)

2017-04-29 Thread Andrew Gaul
andrewgaul commented on this pull request. > +* @param segments +* ordered parts which will be concatenated upon download. +* @param metadata +* corresponds to {@link SwiftObject#getMetadata()}. +* @param headers +* Binds the map to headers,

Re: [jclouds/jclouds] JClouds 1281- DLO Swift Implementation (#1090)

2017-04-29 Thread Andrew Gaul
andrewgaul commented on this pull request. > @@ -123,6 +124,50 @@ public void uploadMultipartBlob() { // The etag returned by Swift is not the md5 of the Blob uploaded // It is the md5 of the concatenated segment md5s } + + @Test + public void uploadMultipartBlobDLO() {

Re: [jclouds/jclouds] JClouds 1281- DLO Swift Implementation (#1090)

2017-04-29 Thread Andrew Gaul
andrewgaul commented on this pull request. > + > assertEquals(object1s.getPayload().getContentMetadata().getContentLength(), > Long.valueOf(1024 * 1024)); + } + + protected void deleteAllObjectsInContainerDLO(String regionId, final String containerName) { + Uninterruptibles.slee

Re: [jclouds/jclouds] JClouds 1281- DLO Swift Implementation (#1090)

2017-04-29 Thread Andrew Gaul
andrewgaul commented on this pull request. > + assertReplaceManifest(regionId, defaultContainerName, defaultName); + } + } + + protected void assertReplaceManifest(String regionId, String containerName, String name) { + ObjectApi objectApi = getApi().getObjectApi(regionId,

Re: [jclouds/jclouds] JClouds 1281- DLO Swift Implementation (#1090)

2017-04-30 Thread Andrew Gaul
andrewgaul commented on this pull request. > +*/ + private String getSLOInfo(String container, String objectName) { + ObjectApi objectApi = api.getObjectApi(regionId, container); + Multimap objInfo = objectApi.getWithoutBody(objectName).getHeaders(); + if (objInfo.containsK

Re: [jclouds/jclouds] JClouds 1281- DLO Swift Implementation (#1090)

2017-04-30 Thread Andrew Gaul
andrewgaul commented on this pull request. > +* @param prefix +* +*/ + private void removeObjectsWithPrefix(String container, String prefix) { + String nextMarker = null; + ObjectApi objectApi = api.getObjectApi(regionId, container); + do { + org.jclouds.ope

Re: [jclouds/jclouds] JClouds 1281- DLO Swift Implementation (#1090)

2017-04-30 Thread Andrew Gaul
andrewgaul commented on this pull request. > +*/ + private void removeObjectsWithPrefix(String containerAndPrefix) { + String[] parts = splitContainerAndKey(containerAndPrefix); + + String container = parts[0]; + String prefix = parts[1]; + + removeObjectsWithPrefix(con

Re: [jclouds/jclouds] JClouds 1281- DLO Swift Implementation (#1090)

2017-05-02 Thread Andrew Gaul
andrewgaul commented on this pull request. >return api.getStaticLargeObjectApi(regionId, > mpu.containerName()).replaceManifest(mpu.blobName(), builder.build(), mpu.blobMetadata().getUserMetadata(), getContentMetadataForManifest(mpu.blobMetadata().getContentMetadata()));

Re: [jclouds/jclouds] JClouds 1281- DLO Swift Implementation (#1090)

2017-05-02 Thread Andrew Gaul
andrewgaul commented on this pull request. > +* @param containerAndKey +* @return array of size 2 with container and objectPrefix +*/ + private String[] splitContainerAndKey(String containerAndKey) { + String[] parts = containerAndKey.split("/", 2); + checkArgument(parts.

Re: [jclouds/jclouds] JClouds 1281- DLO Swift Implementation (#1090)

2017-05-02 Thread Andrew Gaul
andrewgaul commented on this pull request. > + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS"

Re: [jclouds/jclouds] JClouds 1281- DLO Swift Implementation (#1090)

2017-05-02 Thread Andrew Gaul
andrewgaul commented on this pull request. > + assertReplaceManifest(regionId, defaultContainerName, defaultName); + } + } + + protected void assertReplaceManifest(String regionId, String containerName, String name) { + ObjectApi objectApi = getApi().getObjectApi(regionId,

Re: [jclouds/jclouds] JClouds 1281- DLO Swift Implementation (#1090)

2017-05-02 Thread Andrew Gaul
> For DLO upload, etag will the md5 of the manifest and not the md5 of the > concatenated etags. > Thats the reason etag mismatch happens in ParallelLiveTest. So etag checking > for DLO objects requires > manifest to be constructed locally and compute its md5 and then compare with > the etag fro

Re: [jclouds/jclouds] JClouds 1281- DLO Swift Implementation (#1090)

2017-05-02 Thread Andrew Gaul
andrewgaul commented on this pull request. > +import org.jclouds.openstack.swift.v1.domain.SwiftObject; +import org.jclouds.openstack.swift.v1.internal.BaseSwiftApiLiveTest; +import org.jclouds.openstack.swift.v1.options.ListContainerOptions; +import org.testng.annotations.AfterClass; +import or

Re: [jclouds/jclouds] JClouds 1281- DLO Swift Implementation (#1090)

2017-05-04 Thread Andrew Gaul
andrewgaul commented on this pull request. > + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS"

Re: [jclouds/jclouds] JClouds 1281- DLO Swift Implementation (#1090)

2017-05-04 Thread Andrew Gaul
andrewgaul commented on this pull request. > +* @param containerAndKey +* @return array of size 2 with container and objectPrefix +*/ + private String[] splitContainerAndKey(String containerAndKey) { + String[] parts = containerAndKey.split("/", 2); + checkArgument(parts.

Re: [jclouds/jclouds] Promoted google cloud storage (#1093)

2017-05-06 Thread Andrew Gaul
@nacx @zack-shoylev Please review. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1093#issuecomment-299678471

[jclouds/jclouds] Promoted google cloud storage (#1093)

2017-05-06 Thread Andrew Gaul
You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds/pull/1093 -- Commit Summary -- * JCLOUDS-458: GCS skeleton with authentication * JCLOUDS-458: Added Default object access control * JCLOUDS-458: Add BucketAccessControls * JCLOUDS-458: A

[jclouds/jclouds-labs-google] JCLOUDS-944: Promote Google Cloud Storage to core (#176)

2017-05-08 Thread Andrew Gaul
You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds-labs-google/pull/176 -- Commit Summary -- * JCLOUDS-944: Promote Google Cloud Storage to core -- File Changes -- D CONTRIBUTING.md (9) M README.md (214) D google-cloud-storage/RE

Re: [jclouds/jclouds-labs-google] JCLOUDS-944: Promote Google Cloud Storage to core (#176)

2017-05-08 Thread Andrew Gaul
@nacx Please review modified `README.md`. Do we need to do anything else to retire this repository, e.g., modify build scripts? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/

Re: [jclouds/jclouds] fix for deleting an invalid file (#1094)

2017-05-08 Thread Andrew Gaul
@ttulka Please add a unit test to `FilesystemStorageStrategyImplTest` which exercises this behavior. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1094#issuecomment-299951771

[jclouds/jclouds] Promoted b2 (#1095)

2017-05-08 Thread Andrew Gaul
You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds/pull/1095 -- Commit Summary -- * JCLOUDS-1005: Backblaze B2 skeleton and bucket ops * JCLOUDS-1005: Correct B2 package names * JCLOUDS-1005: Remove unused Credentials * JCLOUDS-1005: Bac

Re: [jclouds/jclouds] Promoted b2 (#1095)

2017-05-08 Thread Andrew Gaul
@nacx @zack-shoylev Please review. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1095#issuecomment-299960053

Re: [jclouds/jclouds-labs-google] JCLOUDS-944: Promote Google Cloud Storage to core (#176)

2017-05-08 Thread Andrew Gaul
I dislike promoting a provider in a bugfix release but if others prefer this I will do the work. It would be great to release a new version although I prefer 2.1.0. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://g

Re: [jclouds/jclouds] Promoted b2 (#1095)

2017-05-08 Thread Andrew Gaul
andrewgaul commented on this pull request. > +http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, software +distributed under the License is distributed on an "AS IS" BASIS, +WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, ei

[jclouds/jclouds-labs] JCLOUDS-1272: Promote B2 to core (#388)

2017-05-08 Thread Andrew Gaul
You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds-labs/pull/388 -- Commit Summary -- * JCLOUDS-1272: Promote B2 to core -- File Changes -- D b2/pom.xml (132) D b2/src/main/java/org/jclouds/b2/B2Api.java (40) D b2/src/main/java/o

Re: [jclouds/jclouds-labs] JCLOUDS-1272: Promote B2 to core (#388)

2017-05-08 Thread Andrew Gaul
@nacx @zack-shoylev Please review. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/388#issuecomment-32351

[jclouds/jclouds-karaf] JCLOUDS-944: JCLOUDS-1272: Update B2 and GCS deps (#101)

2017-05-08 Thread Andrew Gaul
You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds-karaf/pull/101 -- Commit Summary -- * JCLOUDS-944: JCLOUDS-1272: Update B2 and GCS deps -- File Changes -- M feature-labs/src/main/feature/feature.xml (17) M feature/src/main/feature

Re: [jclouds/jclouds-karaf] JCLOUDS-944: JCLOUDS-1272: Update B2 and GCS deps (#101)

2017-05-08 Thread Andrew Gaul
@nacx @neykov Please review. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-karaf/pull/101#issuecomment-300025660

Re: [jclouds/jclouds-karaf] JCLOUDS-944: JCLOUDS-1272: Update B2 and GCS deps (#101)

2017-05-09 Thread Andrew Gaul
andrewgaul commented on this pull request. > @@ -549,7 +551,7 @@ limitations under the License. jclouds-blobstore jclouds-api-oauth mvn:org.apache.jclouds.common/googlecloud/${jclouds.version} - mvn:org.apache.jclouds.labs/google-cloud-storage/${jclouds.version

Re: [jclouds/jclouds-karaf] JCLOUDS-944: JCLOUDS-1272: Update B2 and GCS deps (#101)

2017-05-09 Thread Andrew Gaul
andrewgaul commented on this pull request. > @@ -18,11 +18,6 @@ limitations under the License. http://karaf.apache.org/xmlns/features/v1.0.0";> mvn:org.apache.jclouds.karaf/jclouds-karaf/${jclouds.version}/xml/features - -jclouds-b2 -jclouds-google-cloud-storage -

Re: [jclouds/jclouds-karaf] JCLOUDS-944: JCLOUDS-1272: Update B2 and GCS deps (#101)

2017-05-09 Thread Andrew Gaul
> Tests passed in the last build, although the promoted providers should be > moved to the right test class. Done. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-karaf/pull/101#issuecomme

Re: [jclouds/jclouds-karaf] JCLOUDS-944: JCLOUDS-1272: Update B2 and GCS deps (#101)

2017-05-09 Thread Andrew Gaul
> LGTM. Thanks! Just one minor (to be fixed when merging, no need for another > review): remove the "labs" text from the moved test methods. Done. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/j

Re: [jclouds/jclouds] test for deleting an invalid path file (#1096)

2017-05-10 Thread Andrew Gaul
@ttulka I do not understand this pull request -- it succeeds on Linux without the fix in #1094. Do you test on Windows? If so maybe we can make this fail by adding a trailing forward slash, `/`? -- You are receiving this because you are subscribed to this thread. Reply to this email directly

Re: [jclouds/jclouds] fix for deleting an invalid file (#1094)

2017-05-10 Thread Andrew Gaul
@ttulka I do not understand your test -- it succeeds on Linux without the fix. Do you test on Windows? If so maybe we can make this fail on Linux as well by adding a trailing forward slash, `/`? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or

Re: [jclouds/jclouds] fix for deleting an invalid file (#1094)

2017-05-10 Thread Andrew Gaul
Your test should fail before your change and succeed after, yet it succeeds before and after for me. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1094#issuecomment-300397608

Re: [jclouds/jclouds] fix for deleting an invalid file (#1094)

2017-05-10 Thread Andrew Gaul
andrewgaul commented on this pull request. > @@ -684,6 +685,16 @@ public void testPutIncorrectContentLength() throws > Exception { // expected } } + + @Test + public void testDeletingInvalidPathFileEndsNormally() { + String invalidPathBlobKey = "Ahttps://github.

Re: [jclouds/jclouds-karaf] Add built time karaf feature verification (#102)

2017-05-10 Thread Andrew Gaul
andrewgaul commented on this pull request. > jclouds +jclouds-services Did you mix in some unrelated fix here? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-karaf/pull

Re: [jclouds/jclouds] fix for deleting an invalid file (#1094)

2017-05-10 Thread Andrew Gaul
Squashed, removed unneeded whitespace, propagated exception cause, and pushed to master as 6452960c72a5f8247acae12481b94cdf9d8e4218 and 2.0.x as 9bf7c5da5acdfeac1e9298964cb591a142b48afd. Thank you for your contribution @ttulka! -- You are receiving this because you are subscribed to this thre

Re: [jclouds/jclouds] fix for deleting an invalid file (#1094)

2017-05-10 Thread Andrew Gaul
Closed #1094. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1094#event-1075942944

Re: [jclouds/jclouds] JClouds 1281- DLO Swift Implementation (#1090)

2017-05-10 Thread Andrew Gaul
@archupsg03 The more I think about this, let's work on the portable abstraction code in a separate pull request. Please focus this on only the provider, i.e., remove `RegionScopedSwiftBlobStore` changes and only add `RegionScopedSwiftBlobStore`. -- You are receiving this because you are subsc

Re: [jclouds/jclouds] JCLOUDS-1297: Fix uploadId format for non-English locale (#1099)

2017-05-15 Thread Andrew Gaul
Pushed to master as a299a6c1fdfff5669d2f9bc830e6b2df96bec1a8 and 2.0.x as f7cad22d937025e46110c93d93a8a7cb5ea630c3. Thank you for your contribution @ui4j! -- You are receiving this because you modified the open/close state. Reply to this email directly or view it on GitHub: https://github.com/

<    2   3   4   5   6   7   8   9   10   11   >