[jclouds/jclouds] Alphabetize modules (#1138)

2017-09-05 Thread Andrew Gaul
You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds/pull/1138 -- Commit Summary -- * Alphabetize modules -- File Changes -- M apis/pom.xml (28) M drivers/pom.xml (12) M providers/pom.xml (60) -- Patch Links -- https://github.com

Re: [jclouds/jclouds-labs] Add Azure queue storage as new provider. (#405)

2017-09-05 Thread Andrew Gaul
GSoC has ended. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/405#issuecomment-327330685

Re: [jclouds/jclouds-labs] Add Azure queue storage as new provider. (#405)

2017-09-05 Thread Andrew Gaul
Closed #405. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/405#event-1235868524

Re: [jclouds/jclouds-cli] WIP Upgrade Karaf (#38)

2017-09-05 Thread Andrew Gaul
@neykov Do we have a path forward on this pull request? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-cli/pull/38#issuecomment-327331129

Re: [jclouds/jclouds-karaf] [JCLOUDS-858] Upgrade Jersey bundle to 1.19 (#64)

2017-09-05 Thread Andrew Gaul
Closed #64. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-karaf/pull/64#event-1235872581

Re: [jclouds/jclouds] JIRA-1250 (#1104)

2017-09-06 Thread Andrew Gaul
Closed #1104. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1104#event-1237885337

Re: [jclouds/jclouds] DLO - Lower Level Provider API changes (#1105)

2017-09-06 Thread Andrew Gaul
@archupsg03 Do you plan to continue work on this pull request or should I close it? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1105#issuecomment-327648825

[jclouds/jclouds] Upgrade to AutoValue 1.5 (#1139)

2017-09-07 Thread Andrew Gaul
Release notes: https://github.com/google/auto/releases/tag/auto-value-1.5 You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds/pull/1139 -- Commit Summary -- * Upgrade to AutoValue 1.5 -- File Changes -- M project/pom.xml (2) -- Patch Lin

Re: [jclouds/jclouds] Address BindingToUnqualifiedCommonType warnings (#1140)

2017-09-07 Thread Andrew Gaul
@nacx Please review. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1140#issuecomment-327718497

[jclouds/jclouds] Address BindingToUnqualifiedCommonType warnings (#1140)

2017-09-07 Thread Andrew Gaul
Found via error-prone. You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds/pull/1140 -- Commit Summary -- * Address BindingToUnqualifiedCommonType warnings -- File Changes -- M apis/chef/src/main/java/org/jclouds/ohai/config/OhaiModule.jav

Re: [jclouds/jclouds] Upgrade to AutoValue 1.5 (#1139)

2017-09-07 Thread Andrew Gaul
Closed #1139. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1139#event-1238290032

Re: [jclouds/jclouds] Upgrade to AutoValue 1.5 (#1139)

2017-09-07 Thread Andrew Gaul
AutoValue 1.5 requires Java 8. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1139#issuecomment-327723140

[jclouds/jclouds] Specify jsr305 (#1141)

2017-09-07 Thread Andrew Gaul
This eliminates warnings of the form: ``` /home/gaul/.m2/repository/com/google/guava/guava/18.0/guava-18.0.jar(com/google/common/util/concurrent/Monitor.class): warning: Cannot find annotation method 'value()' in type 'GuardedBy' ``` You can view, comment on, or merge this pull request online at:

Re: [jclouds/jclouds] Address BindingToUnqualifiedCommonType warnings (#1140)

2017-09-07 Thread Andrew Gaul
rebuild please -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1140#issuecomment-327734271

Re: [jclouds/jclouds] JCLOUDS-1333: Correct JDK 1.8 method overloading (#1137)

2017-09-07 Thread Andrew Gaul
CloudBees seems sick; these changes passed local tests. -- You are receiving this because you modified the open/close state. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1137#issuecomment-327735425

Re: [jclouds/jclouds] JCLOUDS-1258: Allow China endpoints in FormSignerV4 (#1142)

2017-09-07 Thread Andrew Gaul
andrewgaul approved this pull request. Agree that we should remove the check -- eventually we will support V4 signer for non-Amazon providers. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jcl

[jclouds/jclouds] Remove Inject on constructors for abstract classes (#1143)

2017-09-07 Thread Andrew Gaul
This is not meaningful since these classes cannot be instantiated. Found via error-prone. You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds/pull/1143 -- Commit Summary -- * Remove Inject on constructors for abstract classes -- File Changes --

Re: [jclouds/jclouds] Fixes for jclouds openstack swift tests. (#1144)

2017-09-07 Thread Andrew Gaul
Successfully tested against rackspace-cloudfiles-us and verified that this commit reduces openstack-swift failures from: ``` Failed tests: TemporaryUrlSignerLiveTest.signForPublicAccess:55 » IO Server returned HTTP re... ContainerApiLiveTest.testDeleteMetadata:178 » ContainerNotFound Contai

[jclouds/jclouds] JCLOUDS-1340: Disable BackoffLimitedRetryHandlerTest (#1145)

2017-09-11 Thread Andrew Gaul
These often fail in our continuous integration tests. You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds/pull/1145 -- Commit Summary -- * JCLOUDS-1340: Disable BackoffLimitedRetryHandlerTest -- File Changes -- M core/src/test/java/org/jc

Re: [jclouds/jclouds] JCLOUDS-1340: Disable BackoffLimitedRetryHandlerTest (#1145)

2017-09-11 Thread Andrew Gaul
I successfully ran `mvn test -pl core` 300 times with this commit. Previously it would fail every 10-20 times. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1145#issuecomment-328709

Re: [jclouds/jclouds] JCLOUDS-893: Support compute API extension "Servers with scheduler hints" (#740)

2017-09-11 Thread Andrew Gaul
@VRanga000 Do we have a path forward on this? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/740#issuecomment-328725174

[jclouds/jclouds] Upgrade to EasyMock 3.5 (#1146)

2017-09-13 Thread Andrew Gaul
Also switch from unmaintained easymockclassextension to easymock. Release notes: https://github.com/easymock/easymock/releases You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds/pull/1146 -- Commit Summary -- * Upgrade to EasyMock 3.5 -- File

Re: [jclouds/jclouds] JCLOUDS-769: allow for streaming PUTs (#1129)

2017-09-13 Thread Andrew Gaul
I have started to implement the other providers; if you have feedback on the approach I would appreciate it sooner rather than later. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/11

Re: [jclouds/jclouds] Upgrade to EasyMock 3.4 (#1146)

2017-09-17 Thread Andrew Gaul
EasyMock 3.5 conflicts with testng subdependencies in a way that duplicate-finder-maven-plugin detects. Upgrading to EasyMock 3.4 instead. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/p

[jclouds/jclouds] JCLOUDS-1335: Azure Blob object access tiers (#1147)

2017-09-21 Thread Andrew Gaul
You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds/pull/1147 -- Commit Summary -- * JCLOUDS-1335: Upgrade to Azure Blob API 2017-04-17 * JCLOUDS-1335: Azure Blob object access tiers -- File Changes -- M providers/azureblob/src/main/ja

Re: [jclouds/jclouds] JCLOUDS-1335: Azure Blob object access tiers (#1147)

2017-09-21 Thread Andrew Gaul
The new tests will fail until the tiering goes GA or if you opt into the preview: https://azure.microsoft.com/en-us/blog/announcing-the-public-preview-of-azure-archive-blob-storage-and-blob-level-tiering/ -- You are receiving this because you are subscribed to this thread. Reply to this email d

Re: [jclouds/jclouds] DLO - Lower Level Provider API changes (#1105)

2017-09-21 Thread Andrew Gaul
I decline to share my Rackspace credentials which are linked to my credit card with some random Internet person. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1105#issuecomment-33125

Re: [jclouds/jclouds] DLO - Lower Level Provider API changes (#1105)

2017-09-21 Thread Andrew Gaul
Sorry how do these issues relate to your problem? Please do not make substantial edits to comments which are better addressed as new comments. GitHub does not generate mails for these and it ruins the flow of the discussion. -- You are receiving this because you are subscribed to this thread.

Re: [jclouds/jclouds] DLO - Lower Level Provider API changes (#1105)

2017-09-21 Thread Andrew Gaul
Please just sign up for a Rackspace account which takes a few minutes. I have spent hours reviewing code with you. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1105#issuecomment-33

Re: [jclouds/jclouds] Token based authentication in openstack-keystone (#433)

2017-09-21 Thread Andrew Gaul
@pimenas do we have a path forward on this pull request? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/433#issuecomment-331354779

Re: [jclouds/jclouds] adding attache detach interface to nova api (#697)

2017-09-21 Thread Andrew Gaul
@limorbortman do we have a path forward on this pull request? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/697#issuecomment-331354917

Re: [jclouds/jclouds] JCLOUDS-903 - Support nova compute api extension server groups (#748)

2017-09-21 Thread Andrew Gaul
@vapgar200 do we have a path forward on this pull request? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/748#issuecomment-331354957

Re: [jclouds/jclouds] Add support for disks & ip forward during node creation (#790)

2017-09-21 Thread Andrew Gaul
@yaronr do we have a path forward on this pull request? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/790#issuecomment-331354974

Re: [jclouds/jclouds] Update CloudStack API metadata (#863)

2017-09-21 Thread Andrew Gaul
@olivergondza do we have a path forward on this pull request? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/863#issuecomment-331355000

Re: [jclouds/jclouds] create OpenStack API by "Access" object or token (#886)

2017-09-21 Thread Andrew Gaul
@Xianguang-Zhou do we have a path forward on this pull request? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/886#issuecomment-331355022

Re: [jclouds/jclouds] Test retrieving images (#964)

2017-09-21 Thread Andrew Gaul
@bostko do we have a path forward on this pull request? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/964#issuecomment-331355075

Re: [jclouds/jclouds] Add keystone authentication with an existing token (#1009)

2017-09-21 Thread Andrew Gaul
@olivierlemasle do we have a path forward on this pull request? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1009#issuecomment-331355104

Re: [jclouds/jclouds-labs] JCLOUDS-104: Clean up jclouds-labs POMs (#130)

2017-09-21 Thread Andrew Gaul
Closed #130. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/130#event-1260632255

Re: [jclouds/jclouds-labs] JCLOUDS-104: Clean up jclouds-labs POMs (#130)

2017-09-21 Thread Andrew Gaul
Closed due to inactivity. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/130#issuecomment-331355317

Re: [jclouds/jclouds-labs-openstack] Add Manila support (#198)

2017-09-21 Thread Andrew Gaul
@marcuswanner do we have a path forward on this pull request? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/198#issuecomment-331355396

Re: [jclouds/jclouds] Update CloudStack API metadata (#863)

2017-09-21 Thread Andrew Gaul
Closed due to inactivity. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/863#issuecomment-331355485

Re: [jclouds/jclouds] Update CloudStack API metadata (#863)

2017-09-21 Thread Andrew Gaul
Closed #863. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/863#event-1260633235

Re: [jclouds/jclouds-labs-openstack] Add Manila support (#198)

2017-09-22 Thread Andrew Gaul
Closed #198. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/198#event-1262100447

Re: [jclouds/jclouds-labs-openstack] Add Manila support (#198)

2017-09-22 Thread Andrew Gaul
Closed due to inactivity. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/198#issuecomment-331580937

Re: [jclouds/jclouds] Add support for disks & ip forward during node creation (#790)

2017-09-24 Thread Andrew Gaul
Closed #790. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/790#event-1262728330

Re: [jclouds/jclouds] Add support for disks & ip forward during node creation (#790)

2017-09-24 Thread Andrew Gaul
Sorry code is incomplete without tests. Please reopen if you want to complete this. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/790#issuecomment-331724074

Re: [jclouds/jclouds] JCLOUDS-1263: URL encode object names from list object response before creating URIs with them (#1084)

2017-09-24 Thread Andrew Gaul
@timuralp Do you have any insight into this issue? Otherwise we can close this pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1084#issuecomment-331726071

Re: [jclouds/jclouds] JCLOUDS-1263: URL encode object names from list object response before creating URIs with them (#1084)

2017-09-27 Thread Andrew Gaul
@stevegomez17 Please stop adding irrelevant comments to jclouds pull requests. I have been deleting these. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1084#issuecomment-332682134

Re: [jclouds/jclouds] adding attache detach interface to nova api (#697)

2017-09-28 Thread Andrew Gaul
Closed #697. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/697#event-1270278027

Re: [jclouds/jclouds] Add keystone authentication with an existing token (#1009)

2017-09-28 Thread Andrew Gaul
Closed #1009. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1009#event-1270278806

Re: [jclouds/jclouds] adding attache detach interface to nova api (#697)

2017-09-28 Thread Andrew Gaul
Closed due to inactivity. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/697#issuecomment-332911390

Re: [jclouds/jclouds] Add keystone authentication with an existing token (#1009)

2017-09-28 Thread Andrew Gaul
Closed due to inactivity. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1009#issuecomment-332911517

[jclouds/jclouds] JCLOUDS-1337: Portable storage tiers (#1148)

2017-10-11 Thread Andrew Gaul
You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds/pull/1148 -- Commit Summary -- * JCLOUDS-1337: Portable storage tiers * JCLOUDS-1337: Azure putBlob portable storage tiers * JCLOUDS-1337: S3 putBlob portable storage tiers * JCLOUDS-133

Re: [jclouds/jclouds] JCLOUDS-1337: Portable storage tiers (#1148)

2017-10-11 Thread Andrew Gaul
rebuild please -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1148#issuecomment-335918428

Re: [jclouds/jclouds] JCLOUDS-1337: Portable storage tiers (#1148)

2017-10-11 Thread Andrew Gaul
CloudBees seems to be consuming some kind of Java 8 artifact with a JVM prior to 8: ``` Exception in thread "main" java.lang.UnsupportedClassVersionError: hudson/remoting/Launcher : Unsupported major.minor version 52.0 ``` -- You are receiving this because you are subscribed to this thread. Re

Re: [jclouds/jclouds] JCLOUDS-1337: Portable storage tiers (#1148)

2017-10-11 Thread Andrew Gaul
I will add storage tier support for copyBlob in a separate pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1148#issuecomment-335980294

Re: [jclouds/jclouds-labs] fix domain object (#414)

2017-10-13 Thread Andrew Gaul
@nacx I encountered similar CloudBees weirdness in jclouds/jclouds#1148 but could not find a solution. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/414#issuecomment-336373671

Re: [jclouds/jclouds] JCLOUDS-1337: Portable storage tiers (#1148)

2017-10-14 Thread Andrew Gaul
Still need to make a decision on how providers without tiering support handle calls with tiers. See jclouds-dev thread. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1148#issuecomme

Re: [jclouds/jclouds] Add Jenkins profile to use Maven toolchains (#1149)

2017-10-20 Thread Andrew Gaul
@nacx Sorry I missed this earlier. I fixed the tiering regression in 5448b92ee8c9ba230df9ad8e0d89b070f5b869ae. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1149#issuecomment-338271

Re: [jclouds/jclouds] JCLOUDS-903 - Support nova compute api extension server groups (#748)

2017-10-20 Thread Andrew Gaul
Closed #748. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/748#event-1303436258

Re: [jclouds/jclouds] JCLOUDS-903 - Support nova compute api extension server groups (#748)

2017-10-20 Thread Andrew Gaul
Closed due to inactivity. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/748#issuecomment-338272496

Re: [jclouds/jclouds] Add Jenkins profile to use Maven toolchains (#1149)

2017-10-23 Thread Andrew Gaul
> I'm merging this now to make the builds happy again, although a local build, > with the blobstore changes in this PR reverted and rebased to the latest > master version still presented some test failures. @gaul would you mind > having a look at those? Can you be more specific about these fail

Re: [jclouds/jclouds] Add Jenkins profile to use Maven toolchains (#1149)

2017-10-23 Thread Andrew Gaul
I see the error on Jenkins -- I was not running the labs integration tests. Fixed in jclouds/jclouds-labs@adb4087ab1c37bf8435b293778767e312d89e18b. -- You are receiving this because you modified the open/close state. Reply to this email directly or view it on GitHub: https://github.com/jclouds/

Re: [jclouds/jclouds] Add Jenkins profile to use Maven toolchains (#1149)

2017-10-23 Thread Andrew Gaul
@nacx You have described the problem exactly -- Java on Mac OS does not support extended attributes. Could you add some test exclusions for tiers similar to the ones we already have for other attributes? -- You are receiving this because you modified the open/close state. Reply to this email d

Re: [jclouds/jclouds] Exclude tier tests on OSX (#1150)

2017-10-23 Thread Andrew Gaul
gaul requested changes on this pull request. > @@ -89,6 +91,15 @@ protected void checkUserMetadata(Map > userMetadata1, Maphttps://github.com/jclouds/jclouds/pull/1150#pullrequestreview-71327087

Re: [jclouds/jclouds] Exclude tier tests on OSX (#1150)

2017-10-23 Thread Andrew Gaul
@nacx Agreed that this is inconsistent. I think it is better to throw `SkipException` since this flags tests in an obvious way, although several tests use `dataProvider` or conditional logic to avoid running some tests. If you do change this, note that methods like `validateMetadata` are not t

[jclouds/jclouds] JCLOUDS-1337: other putBlob portable storage tiers (#1151)

2017-10-23 Thread Andrew Gaul
These providers map all storage tiers to `STANDARD`. You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds/pull/1151 -- Commit Summary -- * JCLOUDS-1337: Atmos putBlob portable storage tiers * JCLOUDS-1337: B2 putBlob portable storage tiers *

Re: [jclouds/jclouds] Exclude tier tests on OSX (#1150)

2017-10-24 Thread Andrew Gaul
gaul requested changes on this pull request. > } // Mac OS X HFS+ does not support UserDefinedFileAttributeView: // https://bugs.openjdk.java.net/browse/JDK-8030048 @Override protected void validateMetadata(BlobMetadata metadata) throws IOException { - if (!isMacOSX())

Re: [jclouds/jclouds] Exclude tier tests on OSX (#1150)

2017-10-24 Thread Andrew Gaul
gaul approved this pull request. -- You are receiving this because you commented. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1150#pullrequestreview-71571973

Re: [jclouds/jclouds] Define the JDK version in a Maven property (#1152)

2017-10-25 Thread Andrew Gaul
gaul approved this pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1152#pullrequestreview-71885965

Re: [jclouds-site] Release 1.7.3 (#104)

2014-05-30 Thread Andrew Gaul
> +1. [Known Issues](#issues) > +1. [Reminder](#reminder) > +1. [Credits](#credits) > +1. [Test Results](#test) > + > +## Introduction > + > +You can read the official announcement at [Apache jclouds 1.7.3 > released](http://jclouds.markmail.org/message/6ormro7calbt5tjn). You can read > the detai

Re: [jclouds-site] Release 1.7.3 (#104)

2014-05-30 Thread Andrew Gaul
> @@ -57,6 +57,7 @@ > data-toggle="dropdown">Release Notes > > > +1.7.3 Broken link: http://d044609f24846c5cc196-e981417fa0775ee8db370444a872f96e.r86.cf1.rackcdn.com/releasenotes/1.7.3/ --- Reply to thi

Re: [jclouds] Resolves https://issues.apache.org/jira/browse/JCLOUDS-278 (#388)

2014-05-30 Thread Andrew Gaul
> @@ -138,20 +138,35 @@ public UriBuilder host(String host) { >} > >public UriBuilder path(@Nullable String path) { > + return path(path, true); > + } > + > + public UriBuilder path(@Nullable String path, boolean urlDecode) { Can we change `UriBuilder` to not en

Re: [jclouds-labs-aws] Added some fixes to the live test and a few things on the rest of the co... (#5)

2014-05-30 Thread Andrew Gaul
This pull requests addresses several suggestions from @demobox in #4. Tested locally and pushed to master. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-aws/pull/5#issuecomment-44710815

Re: [jclouds-labs-aws] Added some fixes to the live test and a few things on the rest of the co... (#5)

2014-05-30 Thread Andrew Gaul
Closed #5. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-aws/pull/5#event-126645368

Re: [jclouds] Increase timeouts for signed URL tests (#386)

2014-06-02 Thread Andrew Gaul
Clock skew refers to the perceived time difference between jclouds and the blobstore. In most cases this arises due to NTP misconfiguration although the needlessly tight timeouts can show spurious failures due to slow or lossy network links, such as my home wireless connection. --- Reply to th

Re: [jclouds-labs] [JCLOUDS-500] Initial commit for docker (#57)

2014-06-03 Thread Andrew Gaul
@imesh jclouds master branch uses Guava 17.0 which makes ```Stopwatch``` constructors private access. The jclouds dependency supersedes your application dependency on an older version of Guava. You should update your application dependency to 17.0 and address the Guava API changes and depreca

Re: [jclouds] Remove LocalAsyncBlobStore. (#220)

2014-06-09 Thread Andrew Gaul
> Is there anything else that needs to be done here? > > There is one feature that I am developing in jclouds that is made easier > because of this change. Let me know if there's anything I can do to help make > progress on this. I do not think `LocalAsyncBlobStore` is the appropriate place to

Re: [jclouds-examples] Updated Cloud Files examples (#50)

2014-06-10 Thread Andrew Gaul
> @@ -128,10 +128,14 @@ private void generateGetTempURL() throws IOException { > >// GET the file using jclouds >File file = File.createTempFile(FILENAME, ".tmp"); > - String content = > Strings2.toString(blobStoreContext.utils().http().invoke(request).getPayload()); >

Re: [jclouds-examples] Updated Cloud Files examples (#50)

2014-06-10 Thread Andrew Gaul
> + private final CloudFilesApi cloudFiles; > + > + /** > +* To get a username and API key see > http://jclouds.apache.org/guides/rackspace/ > +* > +* The first argument (args[0]) must be your username > +* The second argument (args[1]) must be your API key > +*/ > + pub

Re: [jclouds-labs-aws] This pull requests addresses more suggestions from @demobox. (#6)

2014-06-10 Thread Andrew Gaul
I prefer allowing the server to validate inputs. While the client can give more helpful error messages, having a single source of truth improves maintainability. Tested locally and pushed to master. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-

Re: [jclouds-labs-aws] This pull requests addresses more suggestions from @demobox. (#6)

2014-06-10 Thread Andrew Gaul
Closed #6. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-aws/pull/6#event-130009077

Re: [jclouds] Port fixes for JCLOUDS-178 to SwiftAuth and Keystone v1.1 (JCLOUDS-589) (#399)

2014-06-10 Thread Andrew Gaul
> @Inject(optional = true) > @Named(Constants.PROPERTY_MAX_RETRIES) > - private int retryCountLimit = 5; > + static final int NUM_RETRIES = 5; Should this be non-final since it is injectable? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pul

Re: [jclouds] Port fixes for JCLOUDS-178 to SwiftAuth and Keystone v1.1 (JCLOUDS-589) (#399)

2014-06-10 Thread Andrew Gaul
> @@ -60,6 +67,16 @@ protected RetryOnRenew(LoadingCache > authenticationResponseCac >this.backoffHandler = backoffHandler; > } > > + /* > +* The reason retries need to be tracked is that it is possible that a > token > +* * can be expired at any time. The reason we track

Re: [jclouds] Port fixes for JCLOUDS-178 to SwiftAuth and Keystone v1.1 (JCLOUDS-589) (#399)

2014-06-10 Thread Andrew Gaul
@zack-shoylev could you also look at this pull request? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/399#issuecomment-45683808

Re: [jclouds] Provide type-safe HashCode methods for Content-MD5 (#384)

2014-06-10 Thread Andrew Gaul
>@Override >public PayloadBlobBuilder contentMD5(byte[] md5) { > + return contentMD5(md5 == null ? null : HashCode.fromBytes(md5)); > + } > + > + @Override > + public PayloadBlobBuilder contentMD5(HashCode md5) { Added Nullable and allowing null for consisten

Re: [jclouds] Provide type-safe HashCode methods for Content-MD5 (#384)

2014-06-10 Thread Andrew Gaul
> > + public ContentMetadataBuilder contentMD5(HashCode contentMD5) { > + this.contentMD5 = contentMD5; Added a conditional for null. I do believe we want to allow setting to null although this is beyond the scope of this commit. --- Reply to this email directly or view it on GitHub: h

Re: [jclouds] Provide type-safe HashCode methods for Content-MD5 (#384)

2014-06-10 Thread Andrew Gaul
> @@ -83,7 +84,8 @@ public ContentMetadataBuilder expires(@Nullable Date > expires) { > } > > public ContentMetadata build() { > - return new BaseImmutableContentMetadata(contentType, contentLength, > contentMD5, contentDisposition, > + return new BaseImmutableContentMetadata(

Re: [jclouds] Provide type-safe HashCode methods for Content-MD5 (#384)

2014-06-10 Thread Andrew Gaul
> @@ -41,7 +41,7 @@ public BaseImmutableContentMetadata(String contentType, > Long contentLength, byte > String contentDisposition, String contentLanguage, String > contentEncoding, Date expires) { >this.contentType = contentType; >this.contentLength = contentLength;

Re: [jclouds] Provide type-safe HashCode methods for Content-MD5 (#384)

2014-06-10 Thread Andrew Gaul
Addressed Checkstyle violations. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/384#issuecomment-45697797

Re: [jclouds-labs-aws] Instead of validating the vault names and the pagination parameters, we ... (#7)

2014-06-12 Thread Andrew Gaul
@rcoedo Sorry to reverse my opinion on this, but I created equivalent live tests and do not believe the Glacier error messages are useful enough to remove this functionality. The too long vault name delivers something readable but the empty and invalid characters do not as shown by this gist:

Re: [jclouds] Provide type-safe HashCode methods for Content-MD5 (#384)

2014-06-12 Thread Andrew Gaul
Closed #384. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/384#event-130960566

Re: [jclouds-labs-aws] Now the live tests are not conditioned by the current state of the accou... (#8)

2014-06-13 Thread Andrew Gaul
Closed #8. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-aws/pull/8#event-131311274

Re: [jclouds-labs-aws] Now the live tests are not conditioned by the current state of the accou... (#8)

2014-06-13 Thread Andrew Gaul
Reworded commit message so that the summary is at most 50 characters as per best practices: https://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_GIT_commit_message_structure Ran integration tests locally and pushed to master. --- Reply to this email directly or view it on GitHub: https:

Re: [jclouds] Improve Expect Test readability (#397)

2014-06-13 Thread Andrew Gaul
I prefer that all committers to use their apache.org email addresses since they represent the project first and their employers second when working on jclouds. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/397#issuecomment-46055497

Re: [jclouds-labs-aws] JCLOUDS-457: Added deleteArchive and uploadArchive operations to the Glacier client. (#9)

2014-06-13 Thread Andrew Gaul
> + } > + > + //If there is one hash left, add it too. > + if (q.size() == 1) > + result.offer(q.poll()); > + return result; > + } > + > + /** > +* Build a TreeHash based on a map of hashed chunks. > +* > +* @return A String containing the calculated Tree

Re: [jclouds-labs-aws] JCLOUDS-457: Added deleteArchive and uploadArchive operations to the Glacier client. (#9)

2014-06-13 Thread Andrew Gaul
> + return q.poll().toString(); > + } > + > + /** > +* Build the Hash and the TreeHash values of the payload. > +*/ > + public void buildHashes() throws IOException { > + InputStream is = payload.openStream(); > + Hasher hasher = Hashing.sha256().newHasher(); > + Q

Re: [jclouds-labs-aws] JCLOUDS-457: Added deleteArchive and uploadArchive operations to the Glacier client. (#9)

2014-06-13 Thread Andrew Gaul
> + Queue q = Lists.newLinkedList(); > + > + //Divide the payload in chunks and queue them. > + byte[] buffer = new byte[CHUNK_SIZE]; > + int bytesRead; > + while ((bytesRead = is.read(buffer)) >= 0) { > + q.offer(Hashing.sha256().hashBytes(buffer, 0, bytesRead)); >

Re: [jclouds-labs-aws] JCLOUDS-457: Added deleteArchive and uploadArchive operations to the Glacier client. (#9)

2014-06-13 Thread Andrew Gaul
> + > + //Divide the payload in chunks and queue them. > + byte[] buffer = new byte[CHUNK_SIZE]; > + int bytesRead; > + while ((bytesRead = is.read(buffer)) >= 0) { > + q.offer(Hashing.sha256().hashBytes(buffer, 0, bytesRead)); > + hasher.putBytes(buffer, 0, byte

Re: [jclouds-labs-aws] JCLOUDS-457: Added deleteArchive and uploadArchive operations to the Glacier client. (#9)

2014-06-13 Thread Andrew Gaul
> + } > + > + /** > +* Build the Hash and the TreeHash values of the payload. > +*/ > + public void buildHashes() throws IOException { > + InputStream is = payload.openStream(); > + Hasher hasher = Hashing.sha256().newHasher(); > + Queue q = Lists.newLinkedList(); > + >

<    4   5   6   7   8   9   10   11   12   13   >