Cherry-picked to
[2.1.x](http://git-wip-us.apache.org/repos/asf/jclouds/commit/889a7f1d).
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1205#issuecomment-389768687
danielestevez commented on this pull request.
> @@ -103,7 +103,7 @@ public void simpleRootTestWithSudoPassword() {
expect(sshClient.getUsername()).andReturn("tester");
expect(sshClient.getHostAddress()).andReturn("somewhere.example.com");
expect(
-
danielestevez commented on this pull request.
> @@ -112,7 +112,8 @@ protected ExecResponse runCommand(String command) {
public String execAsRoot(String command) {
if (node.getCredentials().identity.equals("root")) {
} else if (node.getCredentials().shouldAuthenticateSudo()) {
nacx commented on this pull request.
> @@ -103,7 +103,7 @@ public void simpleRootTestWithSudoPassword() {
expect(sshClient.getUsername()).andReturn("tester");
expect(sshClient.getHostAddress()).andReturn("somewhere.example.com");
expect(
-sshClient.exec("sudo -S
demobox commented on this pull request.
Curious whether we need to extend the test coverage a bit here?
> @@ -103,7 +103,7 @@ public void simpleRootTestWithSudoPassword() {
expect(sshClient.getUsername()).andReturn("tester");
demobox commented on this pull request.
> @@ -112,7 +112,8 @@ protected ExecResponse runCommand(String command) {
public String execAsRoot(String command) {
if (node.getCredentials().identity.equals("root")) {
} else if (node.getCredentials().shouldAuthenticateSudo()) {
-
Closed #1205.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1205#event-1622778189
Pushed to
[master](http://git-wip-us.apache.org/repos/asf/jclouds/commit/82289948).
@andreaturli I think the change is safe enough to cherry-pick it to 2.1.x, WDYT?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
It's just a sometimes since these kind of characters can be included in
password random generator
https://github.com/danielestevez/jclouds/blob/9fef6ed06b027c1525579c88b58aa9f5833687fd/core/src/main/java/org/jclouds/util/PasswordGenerator.java#L65
--
You are receiving this because you are
Haven't tested myself but lgtm, thanks @danielestevez
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1205#issuecomment-388466244
Passwords can contain special characters as parentheses, password parameter
should be wrapped in '' to avoid this syntax errors in SSH command
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds/pull/1205
-- Commit Summary --
* Fixes Run SSH
11 matches
Mail list logo
