[GitHub] [kyuubi] pan3793 commented on a diff in pull request #4147: [K8S][HELM] Add configuration support for multiple frontends to helm chart

2023-01-20 Thread via GitHub
pan3793 commented on code in PR #4147: URL: https://github.com/apache/kyuubi/pull/4147#discussion_r1082908356 ## charts/kyuubi/templates/_helpers.tpl: ## @@ -16,33 +16,18 @@ */}} {{/* -Expand the name of the chart. +A comma separated string of enabled frontend protocols, e.g

[GitHub] [kyuubi] pan3793 commented on a diff in pull request #4147: [K8S][HELM] Add configuration support for multiple frontends to helm chart

2023-01-20 Thread via GitHub
pan3793 commented on code in PR #4147: URL: https://github.com/apache/kyuubi/pull/4147#discussion_r1082908356 ## charts/kyuubi/templates/_helpers.tpl: ## @@ -16,33 +16,18 @@ */}} {{/* -Expand the name of the chart. +A comma separated string of enabled frontend protocols, e.g

[GitHub] [kyuubi] pan3793 commented on a diff in pull request #4147: [K8S][HELM] Add configuration support for multiple frontends to helm chart

2023-01-20 Thread via GitHub
pan3793 commented on code in PR #4147: URL: https://github.com/apache/kyuubi/pull/4147#discussion_r1082908356 ## charts/kyuubi/templates/_helpers.tpl: ## @@ -16,33 +16,18 @@ */}} {{/* -Expand the name of the chart. +A comma separated string of enabled frontend protocols, e.g

[GitHub] [kyuubi] pan3793 commented on a diff in pull request #4147: [K8S][HELM] Add configuration support for multiple frontends to helm chart

2023-01-20 Thread via GitHub
pan3793 commented on code in PR #4147: URL: https://github.com/apache/kyuubi/pull/4147#discussion_r1082908356 ## charts/kyuubi/templates/_helpers.tpl: ## @@ -16,33 +16,18 @@ */}} {{/* -Expand the name of the chart. +A comma separated string of enabled frontend protocols, e.g

[GitHub] [kyuubi] pan3793 commented on a diff in pull request #4147: [K8S][HELM] Add configuration support for multiple frontends to helm chart

2023-01-20 Thread via GitHub
pan3793 commented on code in PR #4147: URL: https://github.com/apache/kyuubi/pull/4147#discussion_r1082908356 ## charts/kyuubi/templates/_helpers.tpl: ## @@ -16,33 +16,18 @@ */}} {{/* -Expand the name of the chart. +A comma separated string of enabled frontend protocols, e.g

[GitHub] [kyuubi] pan3793 commented on a diff in pull request #4147: [K8S][HELM] Add configuration support for multiple frontends to helm chart

2023-01-20 Thread via GitHub
pan3793 commented on code in PR #4147: URL: https://github.com/apache/kyuubi/pull/4147#discussion_r1082908356 ## charts/kyuubi/templates/_helpers.tpl: ## @@ -16,33 +16,18 @@ */}} {{/* -Expand the name of the chart. +A comma separated string of enabled frontend protocols, e.g

[GitHub] [kyuubi-website] pan3793 commented on pull request #104: Determine download url by incubating pattern

2023-01-20 Thread via GitHub
pan3793 commented on PR #104: URL: https://github.com/apache/kyuubi-website/pull/104#issuecomment-1398782316 thanks for fixing! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[GitHub] [kyuubi] pan3793 commented on issue #3478: [Bug] When kyuubi was upgraded from 1.5.2-incubating to 1.6.0-incubating, an error occurred when starting the hue client

2023-01-20 Thread via GitHub
pan3793 commented on issue #3478: URL: https://github.com/apache/kyuubi/issues/3478#issuecomment-1398784736 > Is it convenient to send your Hue configuration reference? I failed to configure kyuubi on cdh-hue. Thank you https://kyuubi.readthedocs.io/en/master/client/bi_tools/hue.html

[GitHub] [kyuubi] codecov-commenter commented on pull request #4152: Enhance LDAP authentication

2023-01-20 Thread via GitHub
codecov-commenter commented on PR #4152: URL: https://github.com/apache/kyuubi/pull/4152#issuecomment-1398818809 # [Codecov](https://codecov.io/gh/apache/kyuubi/pull/4152?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softw

[GitHub] [kyuubi] bowenliang123 closed issue #4106: [FEATURE] Support upload app jar file in POST /batches

2023-01-20 Thread via GitHub
bowenliang123 closed issue #4106: [FEATURE] Support upload app jar file in POST /batches URL: https://github.com/apache/kyuubi/issues/4106 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [kyuubi] bowenliang123 closed pull request #4144: [KYUUBI #4106] Introduce resource file uploading in batch creation via REST API

2023-01-20 Thread via GitHub
bowenliang123 closed pull request #4144: [KYUUBI #4106] Introduce resource file uploading in batch creation via REST API URL: https://github.com/apache/kyuubi/pull/4144 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [kyuubi] bowenliang123 commented on pull request #4144: [KYUUBI #4106] Introduce resource file uploading in batch creation via REST API

2023-01-20 Thread via GitHub
bowenliang123 commented on PR #4144: URL: https://github.com/apache/kyuubi/pull/4144#issuecomment-1399102616 Thanks for all the detailed reviews and productive suggestions. Merged to master. -- This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [kyuubi] bowenliang123 opened a new pull request, #4199: [Doc] Add REST API doc for POST /batches with uploading resource

2023-01-22 Thread via GitHub
bowenliang123 opened a new pull request, #4199: URL: https://github.com/apache/kyuubi/pull/4199 ### _Why are the changes needed?_ - add docs in REST API for POST /batches with uploading resource, which was introduced in #4106 . ### _How was this patch tested?_ - [ ]

[GitHub] [kyuubi] bowenliang123 commented on pull request #4199: [DOC] Add REST API doc for POST /batches with uploading resource

2023-01-22 Thread via GitHub
bowenliang123 commented on PR #4199: URL: https://github.com/apache/kyuubi/pull/4199#issuecomment-1399516285 This PR is adding REST API docs for resource file uploading in batch creation. I'm using `POST /batches (with uploading resource)` for the title to distinguish the similar API in

[GitHub] [kyuubi] bowenliang123 opened a new pull request, #4200: [Improvement] Introduce Markdown formatting for files in doc

2023-01-22 Thread via GitHub
bowenliang123 opened a new pull request, #4200: URL: https://github.com/apache/kyuubi/pull/4200 ### _Why are the changes needed?_ - apply markdown formatting rules with `spotless-maven-plugin` to markdown files in `/docs` ### _How was this patch tested?_ - [ ] A

[GitHub] [kyuubi] codecov-commenter commented on pull request #4199: [DOC] Add REST API doc for POST /batches with uploading resource

2023-01-22 Thread via GitHub
codecov-commenter commented on PR #4199: URL: https://github.com/apache/kyuubi/pull/4199#issuecomment-1399533088 # [Codecov](https://codecov.io/gh/apache/kyuubi/pull/4199?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softw

[GitHub] [kyuubi] dnskr commented on a diff in pull request #4147: [K8S][HELM] Add configuration support for multiple frontends to helm chart

2023-01-22 Thread via GitHub
dnskr commented on code in PR #4147: URL: https://github.com/apache/kyuubi/pull/4147#discussion_r1083508293 ## charts/kyuubi/values.yaml: ## @@ -57,12 +57,60 @@ probe: failureThreshold: 10 successThreshold: 1 -server: - bind: -host: 0.0.0.0 +# Kyuubi frontends +

[GitHub] [kyuubi] bowenliang123 opened a new pull request, #4201: [Improvement] Remove Gson dependency and use Jackson instead in Authz tests

2023-01-22 Thread via GitHub
bowenliang123 opened a new pull request, #4201: URL: https://github.com/apache/kyuubi/pull/4201 …dency ### _Why are the changes needed?_ - use `Jackson` instead of `Gson` in authz testing, where it is the only place `Gson` is used in project - remove `Gson` as depend

[GitHub] [kyuubi] codecov-commenter commented on pull request #4201: [Improvement] Remove Gson dependency and use Jackson instead in Authz tests

2023-01-22 Thread via GitHub
codecov-commenter commented on PR #4201: URL: https://github.com/apache/kyuubi/pull/4201#issuecomment-1399702176 # [Codecov](https://codecov.io/gh/apache/kyuubi/pull/4201?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softw

[GitHub] [kyuubi] Swarvenstein closed issue #4194: [Bug] Unable to adjust kyuubi driver pod idle timeout.

2023-01-22 Thread via GitHub
Swarvenstein closed issue #4194: [Bug] Unable to adjust kyuubi driver pod idle timeout. URL: https://github.com/apache/kyuubi/issues/4194 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [kyuubi] Swarvenstein commented on issue #4194: [Bug] Unable to adjust kyuubi driver pod idle timeout.

2023-01-22 Thread via GitHub
Swarvenstein commented on issue #4194: URL: https://github.com/apache/kyuubi/issues/4194#issuecomment-1399894690 Thanks again for your help with this issue. I think it can be closed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [kyuubi] bowenliang123 commented on pull request #4201: [Improvement] Remove Gson as direct dependency by using Jackson instead in Authz tests

2023-01-23 Thread via GitHub
bowenliang123 commented on PR #4201: URL: https://github.com/apache/kyuubi/pull/4201#issuecomment-1399953596 thanks, merged to master. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [kyuubi] bowenliang123 closed pull request #4201: [Improvement] Remove Gson as direct dependency by using Jackson instead in Authz tests

2023-01-23 Thread via GitHub
bowenliang123 closed pull request #4201: [Improvement] Remove Gson as direct dependency by using Jackson instead in Authz tests URL: https://github.com/apache/kyuubi/pull/4201 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [kyuubi] praveenkumarb1207 opened a new issue, #4202: [Bug] Issue when applying Masking policies on Iceberg Tables

2023-01-25 Thread via GitHub
praveenkumarb1207 opened a new issue, #4202: URL: https://github.com/apache/kyuubi/issues/4202 ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct) ### Search before asking - [X] I have searc

[GitHub] [kyuubi] bowenliang123 commented on issue #4202: [Bug] Issue when applying Masking policies on Iceberg Tables

2023-01-25 Thread via GitHub
bowenliang123 commented on issue #4202: URL: https://github.com/apache/kyuubi/issues/4202#issuecomment-1404433109 Are you compiling and using the Authz module from the master branch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [kyuubi] codecov-commenter commented on pull request #4200: [Improvement] Introduce Markdown formatting for files in docs folder

2023-01-25 Thread via GitHub
codecov-commenter commented on PR #4200: URL: https://github.com/apache/kyuubi/pull/4200#issuecomment-1404484965 # [Codecov](https://codecov.io/gh/apache/kyuubi/pull/4200?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softw

[GitHub] [kyuubi] praveenkumarb1207 commented on issue #4202: [Bug] Issue when applying Masking policies on Iceberg Tables

2023-01-25 Thread via GitHub
praveenkumarb1207 commented on issue #4202: URL: https://github.com/apache/kyuubi/issues/4202#issuecomment-1404550193 Yes , I am using the master branch . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [kyuubi] bowenliang123 commented on issue #4202: [Bug] Issue when applying Masking policies on Iceberg Tables

2023-01-25 Thread via GitHub
bowenliang123 commented on issue #4202: URL: https://github.com/apache/kyuubi/issues/4202#issuecomment-1404565511 Okay, more investigation is required. For row filter in iceberg, it's covered in `IcebergCatalogRangerSparkExtensionSuite` using `org.apache.iceberg.spark.extensions.Ice

[GitHub] [kyuubi] hanna-liashchuk opened a new issue, #4203: [Bug] 1.6.1 doesn't work with Spark on k8s

2023-01-26 Thread via GitHub
hanna-liashchuk opened a new issue, #4203: URL: https://github.com/apache/kyuubi/issues/4203 ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct) ### Search before asking - [X] I have searche

[GitHub] [kyuubi] pan3793 commented on issue #4203: [Bug] 1.6.1 doesn't work with Spark on k8s

2023-01-26 Thread via GitHub
pan3793 commented on issue #4203: URL: https://github.com/apache/kyuubi/issues/4203#issuecomment-1406004008 > 1.6.0 doesn't work without this podNamePrefix parameter as the name generated by the Kyuubi server doesn't conform to the k8s naming conventions. 1.6.1 doesn't work even with this p

[GitHub] [kyuubi] praveenkumarb1207 commented on issue #4202: [Bug] Issue when applying Masking policies on Iceberg Tables

2023-01-26 Thread via GitHub
praveenkumarb1207 commented on issue #4202: URL: https://github.com/apache/kyuubi/issues/4202#issuecomment-1406078677 Hi @bowenliang123 , Just to be clear , We are facing issue only with the Masking . Row level filtering is working as expected . -- This is an automated message f

[GitHub] [kyuubi] xuchunlai commented on issue #4196: [Bug] [K8S]Pod cannot be terminated, when using the configuration kyuubi.Engine.Share.Level=CONNECTION

2023-01-26 Thread via GitHub
xuchunlai commented on issue #4196: URL: https://github.com/apache/kyuubi/issues/4196#issuecomment-1406090558 > Pod can terminated when using the configuration kyuubi.Engine.Share.Level=USER.,and pod can terminated when do not use kyuubi. -- This is an automated message from t

[GitHub] [kyuubi] xuchunlai commented on issue #4196: [Bug] [K8S]Pod cannot be terminated, when using the configuration kyuubi.Engine.Share.Level=CONNECTION

2023-01-26 Thread via GitHub
xuchunlai commented on issue #4196: URL: https://github.com/apache/kyuubi/issues/4196#issuecomment-1406117381 > After the spark app exited, Completed is the expected status of Driver Pod Kyuubi Server are deployed on physical machines,pod can terminated when using the configuration ky

[GitHub] [kyuubi] hanna-liashchuk commented on issue #4203: [Bug] 1.6.1 doesn't work with Spark on k8s

2023-01-26 Thread via GitHub
hanna-liashchuk commented on issue #4203: URL: https://github.com/apache/kyuubi/issues/4203#issuecomment-1406142206 @pan3793 nope, it's `Unrecognized options: --podName` I've attached the log in the description -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [kyuubi] bowenliang123 commented on issue #4202: [Bug] Issue when applying Masking policies on Iceberg Tables

2023-01-27 Thread via GitHub
bowenliang123 commented on issue #4202: URL: https://github.com/apache/kyuubi/issues/4202#issuecomment-1406237738 Okay, well noticed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [kyuubi] turboFei commented on a diff in pull request #4199: [DOC] Add REST API doc for POST /batches with uploading resource

2023-01-27 Thread via GitHub
turboFei commented on code in PR #4199: URL: https://github.com/apache/kyuubi/pull/4199#discussion_r1089600051 ## docs/client/rest/rest_api.md: ## @@ -371,6 +373,23 @@ Create a new batch. The created [Batch](#batch) object. +### POST /batches (with uploading resource) + +Cr

[GitHub] [kyuubi] turboFei commented on a diff in pull request #4199: [DOC] Add REST API doc for POST /batches with uploading resource

2023-01-27 Thread via GitHub
turboFei commented on code in PR #4199: URL: https://github.com/apache/kyuubi/pull/4199#discussion_r1089601865 ## docs/client/rest/rest_api.md: ## @@ -371,6 +373,23 @@ Create a new batch. The created [Batch](#batch) object. +### POST /batches (with uploading resource) + +Cr

[GitHub] [kyuubi] turboFei opened a new pull request, #4204: Add connection metrics with session type

2023-01-27 Thread via GitHub
turboFei opened a new pull request, #4204: URL: https://github.com/apache/kyuubi/pull/4204 ### _Why are the changes needed?_ ### _How was this patch tested?_ - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possibl

[GitHub] [kyuubi] codecov-commenter commented on pull request #4204: Trace the connection metrics with session type

2023-01-27 Thread via GitHub
codecov-commenter commented on PR #4204: URL: https://github.com/apache/kyuubi/pull/4204#issuecomment-1407302096 # [Codecov](https://codecov.io/gh/apache/kyuubi/pull/4204?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softw

[GitHub] [kyuubi] turboFei opened a new pull request, #4205: Fix typo in TFrontendService

2023-01-28 Thread via GitHub
turboFei opened a new pull request, #4205: URL: https://github.com/apache/kyuubi/pull/4205 ### _Why are the changes needed?_ ### _How was this patch tested?_ - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possibl

[GitHub] [kyuubi] turboFei commented on pull request #4205: Fix typo in TFrontendService

2023-01-28 Thread via GitHub
turboFei commented on PR #4205: URL: https://github.com/apache/kyuubi/pull/4205#issuecomment-1407388296 https://github.com/apache/kyuubi/blob/master/kyuubi-common/src/main/scala/org/apache/kyuubi/service/TFrontendService.scala#L265-L280 -- This is an automated message from the Apache Git

[GitHub] [kyuubi] codecov-commenter commented on pull request #4205: Fix typo in TFrontendService

2023-01-28 Thread via GitHub
codecov-commenter commented on PR #4205: URL: https://github.com/apache/kyuubi/pull/4205#issuecomment-1407405019 # [Codecov](https://codecov.io/gh/apache/kyuubi/pull/4205?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softw

[GitHub] [kyuubi] cfmcgrady commented on pull request #4191: [Improvement] Resolve Maven dependencies before building `dependencyList`

2023-01-28 Thread via GitHub
cfmcgrady commented on PR #4191: URL: https://github.com/apache/kyuubi/pull/4191#issuecomment-1407422247 > thus many daily updated snapshot releases will be downloaded again and this process is invisible and make it seems jammed with no console output. do we have any daily updated sna

[GitHub] [kyuubi] bowenliang123 opened a new pull request, #4206: Bump scalafmt from 3.6.1 to 3.7.1

2023-01-28 Thread via GitHub
bowenliang123 opened a new pull request, #4206: URL: https://github.com/apache/kyuubi/pull/4206 ### _Why are the changes needed?_ - Bump scalafmt from 3.6.1 to 3.7.1, release notes: https://github.com/scalameta/scalafmt/releases/tag/v3.7.1 - Changes to existing code seem co

[GitHub] [kyuubi] bowenliang123 opened a new pull request, #4207: Bump snakeyaml from 1.31 to 1.33

2023-01-28 Thread via GitHub
bowenliang123 opened a new pull request, #4207: URL: https://github.com/apache/kyuubi/pull/4207 ### _Why are the changes needed?_ - Bump snakeyaml from 1.31 to 1.33 reducing 2 direct CVE, see (https://bitbucket.org/snakeyaml/snakeyaml/wiki/Changes) ### _How was this pat

[GitHub] [kyuubi] codecov-commenter commented on pull request #4206: Bump scalafmt from 3.6.1 to 3.7.1

2023-01-28 Thread via GitHub
codecov-commenter commented on PR #4206: URL: https://github.com/apache/kyuubi/pull/4206#issuecomment-1407449522 # [Codecov](https://codecov.io/gh/apache/kyuubi/pull/4206?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softw

[GitHub] [kyuubi] codecov-commenter commented on pull request #4207: Bump snakeyaml from 1.31 to 1.33

2023-01-28 Thread via GitHub
codecov-commenter commented on PR #4207: URL: https://github.com/apache/kyuubi/pull/4207#issuecomment-1407454548 # [Codecov](https://codecov.io/gh/apache/kyuubi/pull/4207?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softw

[GitHub] [kyuubi] pan3793 commented on a diff in pull request #4206: Bump scalafmt from 3.6.1 to 3.7.1

2023-01-28 Thread via GitHub
pan3793 commented on code in PR #4206: URL: https://github.com/apache/kyuubi/pull/4206#discussion_r1089848531 ## kyuubi-server/src/main/scala/org/apache/kyuubi/server/api/v1/AdminResource.scala: ## @@ -45,8 +45,7 @@ private[v1] class AdminResource extends ApiRequestContext with

[GitHub] [kyuubi] pan3793 commented on issue #4020: [Umbrella] Apache Kyuubi Graduation Tasks

2023-01-28 Thread via GitHub
pan3793 commented on issue #4020: URL: https://github.com/apache/kyuubi/issues/4020#issuecomment-1407543912 Thanks all! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[GitHub] [kyuubi] pan3793 closed issue #4020: [Umbrella] Apache Kyuubi Graduation Tasks

2023-01-28 Thread via GitHub
pan3793 closed issue #4020: [Umbrella] Apache Kyuubi Graduation Tasks URL: https://github.com/apache/kyuubi/issues/4020 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

[GitHub] [kyuubi] wheatxiong commented on pull request #4001: Support LDAPGroupProvider

2023-01-28 Thread via GitHub
wheatxiong commented on PR #4001: URL: https://github.com/apache/kyuubi/pull/4001#issuecomment-1407546224 > @wheatxiong sorry for the late reply, I'm working on #4152 which mainly referring the Hive codebase. AFAIK, the Hive ecosystem w/ LDAP is mature, let's keep the same behavior(configur

[GitHub] [kyuubi] turboFei closed pull request #4204: Trace the connection metrics with session type

2023-01-28 Thread via GitHub
turboFei closed pull request #4204: Trace the connection metrics with session type URL: https://github.com/apache/kyuubi/pull/4204 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[GitHub] [kyuubi] turboFei commented on pull request #4204: Trace the connection metrics with session type

2023-01-28 Thread via GitHub
turboFei commented on PR #4204: URL: https://github.com/apache/kyuubi/pull/4204#issuecomment-1407546429 thanks, merged to master -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [kyuubi] turboFei closed pull request #4205: Fix typo in TFrontendService

2023-01-28 Thread via GitHub
turboFei closed pull request #4205: Fix typo in TFrontendService URL: https://github.com/apache/kyuubi/pull/4205 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [kyuubi] turboFei commented on pull request #4205: Fix typo in TFrontendService

2023-01-28 Thread via GitHub
turboFei commented on PR #4205: URL: https://github.com/apache/kyuubi/pull/4205#issuecomment-1407546624 thanks, merged to master -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [kyuubi] turboFei opened a new pull request, #4208: Do not fail on unknown properties to keep kyuubi-ctl compatiblity

2023-01-28 Thread via GitHub
turboFei opened a new pull request, #4208: URL: https://github.com/apache/kyuubi/pull/4208 ### _Why are the changes needed?_ ### _How was this patch tested?_ - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possibl

[GitHub] [kyuubi] iodone commented on a diff in pull request #4182: [KYUUBI #3934] Compatiable with Trino rest dto

2023-01-28 Thread via GitHub
iodone commented on code in PR #4182: URL: https://github.com/apache/kyuubi/pull/4182#discussion_r1089873835 ## kyuubi-server/src/test/scala/org/apache/kyuubi/server/trino/api/v1/KyuubiTrinoQueryResultAdaptSuite.scala: ## @@ -0,0 +1,111 @@ +/* + * Licensed to the Apache Software

[GitHub] [kyuubi] turboFei closed pull request #4208: [KYUUBI #4119][FOLLOWUP] Do not fail on unknown properties to keep kyuubi-ctl compatiblity

2023-01-28 Thread via GitHub
turboFei closed pull request #4208: [KYUUBI #4119][FOLLOWUP] Do not fail on unknown properties to keep kyuubi-ctl compatiblity URL: https://github.com/apache/kyuubi/pull/4208 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [kyuubi] turboFei commented on pull request #4208: [KYUUBI #4119][FOLLOWUP] Do not fail on unknown properties to keep kyuubi-ctl compatiblity

2023-01-28 Thread via GitHub
turboFei commented on PR #4208: URL: https://github.com/apache/kyuubi/pull/4208#issuecomment-1407575886 thanks, merged to master and 1.6.2 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [kyuubi] bowenliang123 commented on a diff in pull request #4206: Bump scalafmt from 3.6.1 to 3.7.1

2023-01-28 Thread via GitHub
bowenliang123 commented on code in PR #4206: URL: https://github.com/apache/kyuubi/pull/4206#discussion_r1089879317 ## kyuubi-server/src/main/scala/org/apache/kyuubi/server/api/v1/AdminResource.scala: ## @@ -45,8 +45,7 @@ private[v1] class AdminResource extends ApiRequestContext

[GitHub] [kyuubi] pan3793 commented on a diff in pull request #4206: Bump scalafmt from 3.6.1 to 3.7.1

2023-01-28 Thread via GitHub
pan3793 commented on code in PR #4206: URL: https://github.com/apache/kyuubi/pull/4206#discussion_r1089879498 ## kyuubi-server/src/main/scala/org/apache/kyuubi/server/api/v1/AdminResource.scala: ## @@ -45,8 +45,7 @@ private[v1] class AdminResource extends ApiRequestContext with

[GitHub] [kyuubi] bowenliang123 closed pull request #4206: Bump scalafmt from 3.6.1 to 3.7.1

2023-01-28 Thread via GitHub
bowenliang123 closed pull request #4206: Bump scalafmt from 3.6.1 to 3.7.1 URL: https://github.com/apache/kyuubi/pull/4206 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [kyuubi] bowenliang123 commented on pull request #4206: Bump scalafmt from 3.6.1 to 3.7.1

2023-01-28 Thread via GitHub
bowenliang123 commented on PR #4206: URL: https://github.com/apache/kyuubi/pull/4206#issuecomment-1407581013 thanks, merged to master. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [kyuubi] pan3793 closed pull request #4207: Bump snakeyaml from 1.31 to 1.33

2023-01-29 Thread via GitHub
pan3793 closed pull request #4207: Bump snakeyaml from 1.31 to 1.33 URL: https://github.com/apache/kyuubi/pull/4207 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

[GitHub] [kyuubi] pan3793 commented on pull request #4207: Bump snakeyaml from 1.31 to 1.33

2023-01-29 Thread via GitHub
pan3793 commented on PR #4207: URL: https://github.com/apache/kyuubi/pull/4207#issuecomment-1407606984 Thanks, merged to master for 1.7 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [kyuubi] zhouyifan279 commented on a diff in pull request #4168: [KYUUBI #4167] [Authz] Introduce HiveFunctionPrivilegeBuilder refactored with Serde layers

2023-01-29 Thread via GitHub
zhouyifan279 commented on code in PR #4168: URL: https://github.com/apache/kyuubi/pull/4168#discussion_r1089920426 ## extensions/spark/kyuubi-spark-authz/src/main/resources/function_resource_command_spec.json: ## @@ -0,0 +1,53 @@ +[ { + "classname" : "org.apache.spark.sql.hive.

[GitHub] [kyuubi] yehere commented on pull request #4182: [KYUUBI #3934] Compatiable with Trino rest dto

2023-01-29 Thread via GitHub
yehere commented on PR #4182: URL: https://github.com/apache/kyuubi/pull/4182#issuecomment-1407634529 @ulysses-you Can you review the code for me -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kyuubi] bowenliang123 opened a new pull request, #4209: [Authz] Set Authz logging level to DEBUG for less error messages with mulitple specs

2023-01-29 Thread via GitHub
bowenliang123 opened a new pull request, #4209: URL: https://github.com/apache/kyuubi/pull/4209 ### _Why are the changes needed?_ - change logging level from `warn` to `debug` in Authz - to eliminate duplicated unuseful messages (as screenshot below) with multiple specs in

[GitHub] [kyuubi] codecov-commenter commented on pull request #4209: [Authz] Set Authz logging level to DEBUG for less error messages with mulitple specs

2023-01-29 Thread via GitHub
codecov-commenter commented on PR #4209: URL: https://github.com/apache/kyuubi/pull/4209#issuecomment-1407680220 # [Codecov](https://codecov.io/gh/apache/kyuubi/pull/4209?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softw

[GitHub] [kyuubi] bowenliang123 commented on pull request #4191: [Improvement] Resolve Maven dependencies before building `dependencyList`

2023-01-29 Thread via GitHub
bowenliang123 commented on PR #4191: URL: https://github.com/apache/kyuubi/pull/4191#issuecomment-1407823991 > > thus many daily updated snapshot releases will be downloaded again and this process is invisible and make it seems jammed with no console output. > > do we have any daily u

[GitHub] [kyuubi] bowenliang123 commented on a diff in pull request #4199: [DOC] Add REST API doc for POST /batches with uploading resource

2023-01-29 Thread via GitHub
bowenliang123 commented on code in PR #4199: URL: https://github.com/apache/kyuubi/pull/4199#discussion_r1090097197 ## docs/client/rest/rest_api.md: ## @@ -371,6 +373,23 @@ Create a new batch. The created [Batch](#batch) object. +### POST /batches (with uploading resource)

[GitHub] [kyuubi] bowenliang123 commented on a diff in pull request #4199: [DOC] Add REST API doc for POST /batches with uploading resource

2023-01-29 Thread via GitHub
bowenliang123 commented on code in PR #4199: URL: https://github.com/apache/kyuubi/pull/4199#discussion_r1090097197 ## docs/client/rest/rest_api.md: ## @@ -371,6 +373,23 @@ Create a new batch. The created [Batch](#batch) object. +### POST /batches (with uploading resource)

[GitHub] [kyuubi] ulysses-you commented on pull request #4188: [Improvement] Introduce code formatting for `*.g4` Antlr4 grammar files

2023-01-29 Thread via GitHub
ulysses-you commented on PR #4188: URL: https://github.com/apache/kyuubi/pull/4188#issuecomment-1407853040 To be honest, I do not like this new style. Here are my thoughts: 1. the new style just use more blank line which make it un-readable 2. the end on line `#xxx` is not aligned 3

[GitHub] [kyuubi] bowenliang123 commented on pull request #4188: [Improvement] Introduce code formatting for `*.g4` Antlr4 grammar files

2023-01-29 Thread via GitHub
bowenliang123 commented on PR #4188: URL: https://github.com/apache/kyuubi/pull/4188#issuecomment-1407861513 > To be honest, I do not like this new style. Here are my thoughts: > > 1. the new style just use more blank line which make it un-readable > 2. the end on line `#xxx` is not

[GitHub] [kyuubi] ulysses-you commented on pull request #4188: [Improvement] Introduce code formatting for `*.g4` Antlr4 grammar files

2023-01-29 Thread via GitHub
ulysses-you commented on PR #4188: URL: https://github.com/apache/kyuubi/pull/4188#issuecomment-1407864535 yeah, I think so. We can re-open it when we find a better way. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [kyuubi] bowenliang123 commented on pull request #4188: [Improvement] Introduce code formatting for `*.g4` Antlr4 grammar files

2023-01-29 Thread via GitHub
bowenliang123 commented on PR #4188: URL: https://github.com/apache/kyuubi/pull/4188#issuecomment-1407870158 OK, closing this PR. Thx. Btw, we are not expecting a better solution for Antlr styling from the future version of `spotless-maven-plugin`, since from `2.31.0` it requires Java 11

[GitHub] [kyuubi] bowenliang123 closed pull request #4188: [Improvement] Introduce code formatting for `*.g4` Antlr4 grammar files

2023-01-29 Thread via GitHub
bowenliang123 closed pull request #4188: [Improvement] Introduce code formatting for `*.g4` Antlr4 grammar files URL: https://github.com/apache/kyuubi/pull/4188 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [kyuubi] ulysses-you commented on a diff in pull request #4182: [KYUUBI #3934] Compatiable with Trino rest dto

2023-01-29 Thread via GitHub
ulysses-you commented on code in PR #4182: URL: https://github.com/apache/kyuubi/pull/4182#discussion_r1090115493 ## kyuubi-server/src/main/scala/org/apache/kyuubi/server/trino/api/TrinoContext.scala: ## @@ -166,4 +175,219 @@ object TrinoContext { throw new AssertionErr

[GitHub] [kyuubi] cfmcgrady commented on pull request #4191: [Improvement] Resolve Maven dependencies before building `dependencyList`

2023-01-29 Thread via GitHub
cfmcgrady commented on PR #4191: URL: https://github.com/apache/kyuubi/pull/4191#issuecomment-1407896991 Since all dependencies are stable, and only project submodules are snapshot versions, why don't we skip snapshot updates when updating the dependencies list? We can skip snapshot

[GitHub] [kyuubi] cfmcgrady commented on pull request #4191: [Improvement] Resolve Maven dependencies before building `dependencyList`

2023-01-29 Thread via GitHub
cfmcgrady commented on PR #4191: URL: https://github.com/apache/kyuubi/pull/4191#issuecomment-1407898553 Since all dependencies are stable, and only project submodules are snapshot versions, why don't we skip snapshot updates when updating the dependencies list? We can skip snapshot

[GitHub] [kyuubi-website] bowenliang123 opened a new pull request, #105: Add new committer

2023-01-29 Thread via GitHub
bowenliang123 opened a new pull request, #105: URL: https://github.com/apache/kyuubi-website/pull/105 - add `bowenliang` as new commiter -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [kyuubi] codecov-commenter commented on pull request #4182: [KYUUBI #3934] Compatiable with Trino rest dto

2023-01-29 Thread via GitHub
codecov-commenter commented on PR #4182: URL: https://github.com/apache/kyuubi/pull/4182#issuecomment-1407903805 # [Codecov](https://codecov.io/gh/apache/kyuubi/pull/4182?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softw

[GitHub] [kyuubi-website] Yikf opened a new pull request, #106: Add commiter

2023-01-29 Thread via GitHub
Yikf opened a new pull request, #106: URL: https://github.com/apache/kyuubi-website/pull/106 Add `Kaifei Yi` as new commiter -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [kyuubi] bowenliang123 closed pull request #4199: [DOC] Add REST API doc for POST /batches with uploading resource

2023-01-29 Thread via GitHub
bowenliang123 closed pull request #4199: [DOC] Add REST API doc for POST /batches with uploading resource URL: https://github.com/apache/kyuubi/pull/4199 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kyuubi] bowenliang123 commented on pull request #4199: [DOC] Add REST API doc for POST /batches with uploading resource

2023-01-29 Thread via GitHub
bowenliang123 commented on PR #4199: URL: https://github.com/apache/kyuubi/pull/4199#issuecomment-1407911864 Thanks, merged to master. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [kyuubi] bowenliang123 closed pull request #4200: [Improvement] [Docs] Introduce Markdown formatting with spotless-maven-plugin and flexmark for docs

2023-01-29 Thread via GitHub
bowenliang123 closed pull request #4200: [Improvement] [Docs] Introduce Markdown formatting with spotless-maven-plugin and flexmark for docs URL: https://github.com/apache/kyuubi/pull/4200 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kyuubi] bowenliang123 commented on pull request #4200: [Improvement] [Docs] Introduce Markdown formatting with spotless-maven-plugin and flexmark for docs

2023-01-29 Thread via GitHub
bowenliang123 commented on PR #4200: URL: https://github.com/apache/kyuubi/pull/4200#issuecomment-1407931433 Thanks, merged to master. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [kyuubi] bowenliang123 opened a new pull request, #4210: [KYUUBI #4199][Followup] Reformat `rest-api.md` doc file

2023-01-29 Thread via GitHub
bowenliang123 opened a new pull request, #4210: URL: https://github.com/apache/kyuubi/pull/4210 ### _Why are the changes needed?_ - Reformat markdown file `rest-api.md` with changes from (https://github.com/apache/kyuubi/pull/4200) in with ( https://github.com/apache/kyuubi

[GitHub] [kyuubi-website] ulysses-you merged pull request #105: Add committer

2023-01-29 Thread via GitHub
ulysses-you merged PR #105: URL: https://github.com/apache/kyuubi-website/pull/105 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubsc

[GitHub] [kyuubi] Yikf commented on pull request #4210: [KYUUBI #4199][Followup] Reformat `rest-api.md` with markdown style rules

2023-01-29 Thread via GitHub
Yikf commented on PR #4210: URL: https://github.com/apache/kyuubi/pull/4210#issuecomment-1407945726 This change looks fine to me. Also, It is better if add style check to CI work flow, since we added some new file format style check, Any thought? -- This is an automated message fro

[GitHub] [kyuubi-website] ulysses-you merged pull request #106: Add committer

2023-01-29 Thread via GitHub
ulysses-you merged PR #106: URL: https://github.com/apache/kyuubi-website/pull/106 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubsc

[GitHub] [kyuubi] bowenliang123 commented on pull request #4210: [KYUUBI #4199][Followup] Reformat `rest-api.md` with markdown style rules

2023-01-29 Thread via GitHub
bowenliang123 commented on PR #4210: URL: https://github.com/apache/kyuubi/pull/4210#issuecomment-1407947858 > This change looks fine to me. > > Also, It is better if add style check to CI workflow, since we added some new file format style check, Any thought? Yes, auto style c

[GitHub] [kyuubi] codecov-commenter commented on pull request #4210: [KYUUBI #4199][Followup] Reformat `rest-api.md` with markdown style rules

2023-01-29 Thread via GitHub
codecov-commenter commented on PR #4210: URL: https://github.com/apache/kyuubi/pull/4210#issuecomment-1407984965 # [Codecov](https://codecov.io/gh/apache/kyuubi/pull/4210?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softw

[GitHub] [kyuubi] bowenliang123 closed pull request #4210: [KYUUBI #4199][Followup] Reformat `rest-api.md` with markdown style rules

2023-01-29 Thread via GitHub
bowenliang123 closed pull request #4210: [KYUUBI #4199][Followup] Reformat `rest-api.md` with markdown style rules URL: https://github.com/apache/kyuubi/pull/4210 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [kyuubi] bowenliang123 commented on pull request #4210: [KYUUBI #4199][Followup] Reformat `rest-api.md` with markdown style rules

2023-01-29 Thread via GitHub
bowenliang123 commented on PR #4210: URL: https://github.com/apache/kyuubi/pull/4210#issuecomment-1407988804 Thanks, merged to master. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [kyuubi] codecov-commenter commented on pull request #4191: [Improvement] Resolve Maven dependencies before building `dependencyList`

2023-01-29 Thread via GitHub
codecov-commenter commented on PR #4191: URL: https://github.com/apache/kyuubi/pull/4191#issuecomment-1408027776 # [Codecov](https://codecov.io/gh/apache/kyuubi/pull/4191?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softw

[GitHub] [kyuubi] bowenliang123 commented on pull request #4191: [Improvement] Skip fetching Maven dependency snapshot update in building `dependencyList`

2023-01-29 Thread via GitHub
bowenliang123 commented on PR #4191: URL: https://github.com/apache/kyuubi/pull/4191#issuecomment-1408031249 > Since all dependencies are stable, and only project submodules are snapshot versions, why don't we skip snapshot updates when updating the dependencies list? > > We can skip

[GitHub] [kyuubi] bowenliang123 closed pull request #4191: [Improvement] Skip fetching Maven dependency snapshot update when building `dependencyList`

2023-01-29 Thread via GitHub
bowenliang123 closed pull request #4191: [Improvement] Skip fetching Maven dependency snapshot update when building `dependencyList` URL: https://github.com/apache/kyuubi/pull/4191 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [kyuubi] bowenliang123 commented on pull request #4191: [Improvement] Skip fetching Maven dependency snapshot update when building `dependencyList`

2023-01-29 Thread via GitHub
bowenliang123 commented on PR #4191: URL: https://github.com/apache/kyuubi/pull/4191#issuecomment-1408032830 Thanks, merged to master. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [kyuubi-website] bowenliang123 opened a new pull request, #107: Use `姓名` for column name on committer/PMC pages in Chinese

2023-01-29 Thread via GitHub
bowenliang123 opened a new pull request, #107: URL: https://github.com/apache/kyuubi-website/pull/107 - Use `姓名` for column name on committer/PMC pages in Chinese ![image](https://user-images.githubusercontent.com/1935105/215402394-70640a7f-acf2-4779-b551-7946fc45e5c9.png) -- T

  1   2   3   4   5   6   7   8   9   10   >